| commit | 079aad50ef47f34453eee9911655872397635c88 | |
| author | Volker Lendecke <vl@samba.org> | |
| Fri, 16 Jun 2023 11:45:57 +0000 (16 13:45 +0200) | ||
| committer | Jeremy Allison <jra@samba.org> | |
| Fri, 16 Jun 2023 16:14:31 +0000 (16 16:14 +0000) | ||
| tree | d80dc4d823e7400938782f390471cb1ac0a4d9e7 | treesnapshot (tar.gz zip) |
| parent | cf4e55421bbe809bd869781432f4c2385dbf41bc | commitdiff |
smbd: Remove a smb1-only optimization findfirst/findnext
I don't think this is an effective optimization at all anymore. It was
intended to speed up non-wildcard readdirs after we found the correct
entry. Nowadays we do the non-wildcard readdirs by a direct fstatat,
and after we successfully found the entry dptr_ReadDirName()
immediately returns without any further action. So my very strong
guess is that this never really kicked in anymore. Not using this flag
can't be *that* bad, smb2 never used it.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
I don't think this is an effective optimization at all anymore. It was
intended to speed up non-wildcard readdirs after we found the correct
entry. Nowadays we do the non-wildcard readdirs by a direct fstatat,
and after we successfully found the entry dptr_ReadDirName()
immediately returns without any further action. So my very strong
guess is that this never really kicked in anymore. Not using this flag
can't be *that* bad, smb2 never used it.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
| source3/smbd/globals.h | diffblobblamehistory | |
| source3/smbd/smb1_trans2.c | diffblobblamehistory | |
| source3/smbd/smb2_query_directory.c | diffblobblamehistory | |
| source3/smbd/smb2_trans2.c | diffblobblamehistory |