| commit | d88422703d0959bb77f7aaa395816d8773a065cd | |
| author | heikki <heikki> | |
| Mon, 19 May 2008 18:16:26 +0000 (19 18:16 +0000) | ||
| committer | heikki <heikki> | |
| Mon, 19 May 2008 18:16:26 +0000 (19 18:16 +0000) | ||
| tree | 4f3fd07058319250fa0eaf07c2e5f67da6cf7eb9 | treesnapshot (tar.gz zip) |
| parent | 20409288c4053d5ba5610b96f4c3e144289ffe82 | commitdiff |
Remove arbitrary 10MB limit on two-phase state file size. It's not that hard
to go beoynd 10MB, as demonstrated by Gavin Sharry's example of dropping a
schema with ~25000 objects. The really bogus thing about the limit was that
it was enforced when a state file file was read in, not when it was written,
so you would end up with a prepared transaction that you can't commit or
abort, and the only recourse was to shut down the server and remove the file
by hand.
Raise the limit to MaxAllocSize, and enforce it also when a state file is
written. We could've removed the limit altogether, but reading in a file
larger than MaxAllocSize would fail anyway because we read it into a
palloc'd buffer.
Backpatch down to 8.1, where 2PC and this issue was introduced.
to go beoynd 10MB, as demonstrated by Gavin Sharry's example of dropping a
schema with ~25000 objects. The really bogus thing about the limit was that
it was enforced when a state file file was read in, not when it was written,
so you would end up with a prepared transaction that you can't commit or
abort, and the only recourse was to shut down the server and remove the file
by hand.
Raise the limit to MaxAllocSize, and enforce it also when a state file is
written. We could've removed the limit altogether, but reading in a file
larger than MaxAllocSize would fail anyway because we read it into a
palloc'd buffer.
Backpatch down to 8.1, where 2PC and this issue was introduced.
| src/backend/access/transam/twophase.c | diffblobblamehistory |