| commit | 93fb2adc91368fb1ea011bb6aa0834f74590516c | |
| author | tgl <tgl> | |
| Fri, 1 May 2009 19:29:07 +0000 (1 19:29 +0000) | ||
| committer | tgl <tgl> | |
| Fri, 1 May 2009 19:29:07 +0000 (1 19:29 +0000) | ||
| tree | ef7acdb0ba2887aa6e842ef6fe5db4a838f6ce23 | treesnapshot (tar.gz zip) |
| parent | 753664c83addc8157329039e01fe0ba47b114c80 | commitdiff |
When checking for datetime field overflow, we should allow a fractional-second
part that rounds up to exactly 1.0 second. The previous coding rejected input
like "00:12:57.9999999999999999999999999999", with the exact number of nines
needed to cause failure varying depending on float-timestamp option and
possibly on platform. Obviously this should round up to the next integral
second, if we don't have enough precision to distinguish the value from that.
Per bug #4789 from Robert Kruus.
In passing, fix a missed check for fractional seconds in one copy of the
"is it greater than 24:00:00" code.
Broken all the way back, so patch all the way back.
part that rounds up to exactly 1.0 second. The previous coding rejected input
like "00:12:57.9999999999999999999999999999", with the exact number of nines
needed to cause failure varying depending on float-timestamp option and
possibly on platform. Obviously this should round up to the next integral
second, if we don't have enough precision to distinguish the value from that.
Per bug #4789 from Robert Kruus.
In passing, fix a missed check for fractional seconds in one copy of the
"is it greater than 24:00:00" code.
Broken all the way back, so patch all the way back.
| src/backend/utils/adt/datetime.c | diffblobblamehistory |