Fix pg_dumpall so that when --clean is specified, it drops roles and
commit662609e1b33e8bc0176d26f1b95fd98a26210edb
authortgl <tgl>
Sat, 11 Apr 2009 20:23:05 +0000 (11 20:23 +0000)
committertgl <tgl>
Sat, 11 Apr 2009 20:23:05 +0000 (11 20:23 +0000)
tree85446a338a6f9e2eebf5c08783e1e6bf2481d630
parent81518a6ccfee7ec1880c6ca9a34a88b9a1ae4eb3
Fix pg_dumpall so that when --clean is specified, it drops roles and
tablespaces in an order that has some chance of working.
Per a complaint from Kevin Bailey.

This is a pre-existing bug, but given the lack of prior complaints I'm
not sure it's worth back-patching.  In most cases failure of the DROP
commands wouldn't be that important anyway.

In passing, fix syntax errors in dumpCreateDB()'s queries for old servers;
these were apparently introduced in recent binary_upgrade patch.
src/bin/pg_dump/pg_dumpall.c