From 85dc24c43da7b6048fb680af7d6b7392d87165c1 Mon Sep 17 00:00:00 2001 From: Pawel Solyga Date: Wed, 15 Apr 2009 15:56:17 +0000 Subject: [PATCH] Fix too long line and redefining variable 'review' from outer scope in soc.views.models.student_proposal module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed --- app/soc/views/models/student_proposal.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/soc/views/models/student_proposal.py b/app/soc/views/models/student_proposal.py index 6aa4b1b2..49072fbb 100644 --- a/app/soc/views/models/student_proposal.py +++ b/app/soc/views/models/student_proposal.py @@ -897,7 +897,8 @@ class View(base.View): mentor_names = [] for mentor_key in possible_mentors: - possible_mentor = mentor_logic.logic.getFromKeyName(mentor_key.id_or_name()) + possible_mentor = mentor_logic.logic.getFromKeyName( + mentor_key.id_or_name()) mentor_names.append(possible_mentor.name()) context['possible_mentors'] = ', '.join(mentor_names) @@ -920,9 +921,9 @@ class View(base.View): # create a summary of all the private reviews review_summary = {} - for review in private_reviews: + for private_review in private_reviews: # make sure there is a reviewer - reviewer = review.reviewer + reviewer = private_review.reviewer if not reviewer: continue @@ -932,7 +933,7 @@ class View(base.View): if reviewer_summary: # we already have something on file for this reviewer old_total_score = reviewer_summary['total_score'] - reviewer_summary['total_score'] = old_total_score + review.score + reviewer_summary['total_score'] = old_total_score + private_review.score old_total_comments = reviewer_summary['total_comments'] reviewer_summary['total_comments'] = old_total_comments + 1 @@ -940,7 +941,7 @@ class View(base.View): review_summary[reviewer_key] = { 'name': reviewer.name(), 'total_comments': 1, - 'total_score': review.score} + 'total_score': private_review.score} context['review_summary'] = review_summary -- 2.11.4.GIT