From 3d79ac71d18566e0bd697eae119d6202dc01b494 Mon Sep 17 00:00:00 2001 From: Xisco Fauli Date: Fri, 3 Jul 2020 13:50:20 +0200 Subject: [PATCH] tdf#35636: sc: Add unittest Change-Id: I79eee92015b4a4eafd57702e2ac1bf7fe1682f0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97840 Tested-by: Jenkins Reviewed-by: Xisco Fauli --- sc/qa/unit/data/ods/tdf35636.ods | Bin 0 -> 9366 bytes sc/qa/unit/subsequent_filters-test.cxx | 16 ++++++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 sc/qa/unit/data/ods/tdf35636.ods diff --git a/sc/qa/unit/data/ods/tdf35636.ods b/sc/qa/unit/data/ods/tdf35636.ods new file mode 100644 index 0000000000000000000000000000000000000000..4ac33ccb4608bf2e3f94652f38884bf6e0ded89a GIT binary patch literal 9366 zcwW_dbzD^Mw*E+Wcc-AFASvA~EnP!1zzkg9u^J{06+o&RP}Gq{_9v7%$le%Y_Mf62=J@x=qWlBO%GTJz49q5G1+g`D0RM+>0Yi)-&Of;m2?^`VuNU-$my;nd(eUQGYlbNB1jiH&Tsj-=jjfJVbwHXKm0@`_5**e)eI9r3g zT`Y_oK-RB8Chm?_4h{}39m68G}mhVJU7 zw&tOk=INvE%CxTP?Do2n&d=2YT`hA14c*<{LqkJ-!(YY+yS@zdjeQxO`O-B#);Bgb z_GM~uW@e^+Vx?zpdwvZ%xpg!LJz1UV-&h>mUL1q2OzyAGFE1~D+uU2*+27sW{kC(w zcXaX{`t9Uk>+0a!$>Gk`(fY~B$?@66_p6(Wv!knv)7#tIhiKm22@>tw++Sm(vJ#@| zZnJx{+x9r3L_Ll>l9Hq|ni4xYeqA9lrSGICbDmNtt4>(!6lZIOOPA^tqwCCB2X?Ab zLuM{QOQpR6k*oSvhBvN&(}yOTT?`$ZBc@eCEWq4yxo&%+<0}3ZWa(8-kOInATLqLC zEV2XhX;2PfXkUsBXI~b)quI(EISw2i-SyYsR~WFj?H+4~4x@+ksr40jT$VuT#ZFRS z2TTmdxv2(+IDOk9%s*fQW4G9C~lgyZO|X%t+?3&30%~z~W1aXEnj1H=$;5fi1d+0!PxBD7 zca~WFl0oQQbqoD8-*ZsCw$|fR-*v>}YoaYASa#_;6z+{h>YV+$t31_{GI?+q%_DQA zB@zvt**%+6=U@f<<;jn!nf|sDmY1oG`$TG*tW`wE3Ko#fWIFS8TsI&vX2Z<_^a^dj z_}!sg6qTr-glr#}RNEyl7g+4&^+++6B0`vO(OpMqPS1VcNw3m`Xw`-`2f8C~pjTd+ z@rGNlqPta$t^uKEyE#{Wb1u73%XxdO=hQ@^R-_am=_kr0W0!B5^tvv+ z1+-?g5iRoSAYEQj8c{zuWE?t~hvWXA*|73_4ZviFkCBVEG=9jBvXV*?WnxBtf1Q{g z(i|A#4l)Bj?fcQM$OW7z>*q6x9;WxD^wY zcCGg9Acm`qB#$`@lUzQ&OPUUoFtV@ z{DEsa9_~5{s6@w^ZPT3;OMuY_x4~@4Qf@H-1J&D>9m|l?_;cbvK5%tU@3$h};DqSsYS&P$Bd+z1I9%hh1 zre_F4&6#Ey4F?%>Ix2RkXjSG0kU3Rry*++%f?7fLY`_g^U`AYd`0Hj?rqW<)R32X@ z>f@RwS7lZ95V^_iqDu zS)Nlt;;kM_1)S9^w5nzHBayo)VU5*tP#K!q-Cc?w`C2JbWXHUa$#v1%8u zS2HHBcqYk}1%yBp^*jPqwbh5PZY5;nzx?oeX0g)$YVV6Dab2Ud$~tRAV`I7Z3sp^w!L?E_Uh$ zDN=uwk89Opoe)8KA>AfgZoj|Fngd%yVdhUSg-v1{v_Dn){)_5RXNs%$Or?s-_2{Vz zOI7+(Oxc9T&cQ*PJ%Y%R-YZ4<^Rfg6NPwqHaPQcXYD{631dJE9>|4f6o5DZ@(@Bo@ z7%(rb5C+RSVq0W-g-H)11ZgG$o~=TVYWdk`iwVo|v!pCrH(T)ercPBvm`-h2RJcZL zVR=WlxK=El3PS< zqiwiKU4le^+`+W8vr4+BX=zIod4`Z@)8Af)j^G@9RV1%u94T}O97owkmex%5KKItm zE4+bddu5lrUm3H{`D{}DB+{lJ$g@Nx>7qeDEV1FpwhIj>M@f;tNLlgAjuCornCGTv z*c$y*fNM#E#aA8!rMaq_JL`Pk=EvTljItaBM)Zl^ERQjzcvHW!;}{`!LJ)cyh`wZF z*ZJSzaNJRybYoOBp_3d$i*BVO_%CiSwwkz2lG~))aMC#7=rd>SVL^ zYKG@blrxy_HADw5;SJtSH<0sbc7c$~)LHSPInHji&t{f0Wj&DptO1%P~3^M0pb(P8*skE*`$hF5reu&+P94c}dmIwz!pi1kj2{-$>*2iKm(i!k#n1e;U{m5CK}f!7Q$PF@(D@P&>%)ZQYyp^28`F^lrPxJI%QSoxtK^ltFPgg~_+rePCJeX^a zhGN1i(g~z=P|syq<|*P{W_cDY38w&fwtS1PNR&)p#i9rj9$2?7cp2Q#zs*z}+qohX z6wzU-4N@0#uJ$2+M6p2DnvnC@X<}TmmxJw)>|pFD;jH_+-s#BqYJwPt?}P)4sX{C| zIK*FWoj&W8!M^zhe;erPSbwsHV{=;0?ZJpMcji5I_*@B`g0@rm-Mq${LmkL~V&PgB zRM)}w+5R=+Lp$b(@(F-{-$*@Y`)51$r-upDdjs0rLH?_gTi2GipX0@9J}Adh&zu$< ztuD<~oZywD)Y{F_W==+!&ffA(V0_O=Z!O#Ja(jbOSYXx{J=ZN*f+?pkyqaPkB(B=* zQLk86m9P3Nnst80bcg>rxBc7kboag(j_-l}&PB37%d zTf{v5Ayv&4GcZ9Y@oc?-E~|gamyIJ?v*ETm!v2O})mJs$ppL1OlX7*)oO8wvml}Be zO^_QbGhW&q4`J?zI+q+HH3*+sU#G9FinpXQtz=pC1;}B9 zWNvZi#JqPyIu8WE)3qZ#%ajZmv`4E3&OPP!aSpnxcXuT%u@q|!8lywE%)u8b(LfHS zA;#mT+9shYb_oFD))IyhE5if zJbllaTFYFmSR_)Z5J{gCWd{w80Rg;*q;bvr`amJ!3i_J?h=$k!D&Jk1t3~M~$`P!u zV3t~Qz2}>X*SNHuJg`nraCEce#3g`FaImRTraZ*p5SvnsaTWD-Qu7Rhrarv4ed@-X zUb@1FGg=>mHXRt{QaR-_;M7-I#oijH1{D1^V;V$?f_8lLe7eYn;hi;y=3H;BGv?+F z8sQR@L>HT{A-D8!IArwP3zDQ+S6Z5~@>*HjwO`BpQY3CuYfM3A!N46TNUS|Q>q1yY z81d@7U5TF?@q0xy8j1GM7C*(%CO-wEMkARtr#%0xRXTGa895s$qjWH#W}ctbZQt3M zn^7mb{Zs_b0uC?QCp!v3Pu~zfVaK@Ohut;X{Hqx3X*cR!IV$7pW@7u|WMaH=yapO( z-5O)LJsDF4#8HGPIEW&&Jy^d5*!tGCZkR<@1M_VG9qx{#bQzJCo+Y=(CaakPP0sMp z9#w7GGLgf%-1u6`TU@66v`-L4RUH3eb})HcY-S_1)x56iX=jdyg)g3*#O#I4>zs}W z$eL37prIJ5Zu@YG@GZn{iTA)N6-s&sb!fe zfc6V#hN=3wpUZ->mrW0m8RTuzlx5bEGD><%&6-HzL@?F2?(c5!BE+CP03ICydqVfazQun%eE z$=Lb(C-kguU0ltL#{HqXr|p)8L})4Rc0IU1x39Ons)LsFc)uJqzd6ZNCE>t1_h;O+ z#-l9cM}l?T;(zq!yW{mxdR)M?4!IVe+1<=9>*3s(j8T4#q zQEaXC>WUt8kD1pY;1l)FObg$P@R0V@U16ZBxNgMo#kO4)Um6xOUmc9VtTrFSrqh@4 zt;AskMQX{jt%myE3MP|J%}!@Tl2tRJ2&A)q(B#>l=Q@?K3d{M?Mrrgu$;PY_3?&zb8A~u_4HxH>V^QU&-&@={I zg0nUF5;W0eDBtpeFpJ`pNpJ}YyyQ9CP(&*OVsV5;q*y*A(eRNo`KX>YreSd>*dZFs``au=H!uF9s!qRM`G zfcIFsZrK^s5Cn2v@E&>9h#$E>x=`;ZEaHx~Eks+{t0~8+G!?jkhyoRF z9wttNFL0-*jsH$Rn9-~jF~=}}$u0*C50P3J@J6q2N;@U(9Ho2u0V+9QKC~B16e@>R zCU?C7zalLxe@glgZQQfj(z-_gfHmyjMH}tjz-ADLm7T>u)(-Y`biuQ{c(0cXqmQ6U zA=E6oNdXbmdQP-PVA<=(b1)OVF-(0#m(W+WS&D@VszB#j&XnNg&=YTI>CLBg*B_6L zW=J?980*K1>>+z-IEfx_naiuUb6sx@u0}7RF{}i=fr^n0S(xv5H5PO_=Q_#!o|CynQ(*=TV-vXWpzj6gW8xHEy|{T(@J{?%~53 zjdTXrdXj~@4jr@ax zHGpJ|@3`|R>ZN|o;PJhxZa@96Q&&U|Qv4-h0B41<3 zD!EJ_d@Mp{jS2X}ZA|X7E#FjJD*R(k(Uvrhb|0!Hn6I=7A8|R9X5Ko{j&0o()$2Z?b0Cjq^l5d(riL|5?5yCN zN>y^GB(=lFQuu&e=MyZYfgp;)JQY`~*H5I-o9DRBO~?^L5atqmI78n3?oe~f%`)7r z><7KC1*+i$MAZ%GUsn_V6)6YKd-&6saO1=b*ZB-AFJ4c^VlJi_f{D##JTP^s;BW~K zKklMrA_73l^n_Khu9tNhC7t}H%qPFs=IdjbK(4RoEsNwmI!vu`bmDmxTKbBXk7o2r z#g?c6#$297m8|M|V?`k9d|yPk-Dfj|V#2M*4PFtRC<1B;198hV+xr%W`b)lxp9du+ zYKIxI1ZSk~3cFfXRQD*N6Cpj{N32oPpOa=~lKU(uhogs^(!?bb_ot-7CJE6+QJ;f& zj_H!Ik*Gq`#A>C#eX}wn=5Ac=3qT~BT&l%>1S+mE$ZlK0U+9Psp7XotaN@5+Co?f| zwYp}w%Ws%US+3=}x)`lD79d)IdQY)yYF=;my-8RSF>fgl*6q$0pLNzmkRY-%0+=%|_NnZ7BpU$H4@(RRPF z>NxY9FI7B9b+@;faHVTI}-BunQI(ltl1kJy$ ztf1|YoiP9{b*4uO&&CQ$b2KAthzleWxsDq&z9{1|(O!CNLxQ-vSsz@$rT2+J)RTzK zW2QNM>+6x5IqTpeNML(7J>z7jcUMVTYO18+20dtDXLkQ3G?EQ{$-qEA4U3i1j4|D5 z>xNx3-DpV)iwSK7VTtAtd>b}E=5$Q>=~2whE{%PQ-2P8 zLfjXx-HjNXQi7VpgYXUL<_OE6C=rR3OmIDED(J!O#W%!puq(<670v!L?M;z9Qks z3jF~Pf3gN8`7X|c?<#z4S$iuzMxV$1vjvO}nIcA}7vG}guNy3X{9G&= za31eETB40JO6AypxzqT<{ciJ?b>xnCrM%ij0wgk=V{sX^S$#~YAzl99zUp(!G5Gtk z=Kr^44gcO0CDlb)WR;}Y{@aiD^{q5c(XN9EEAX5zu&b6McQ0SevGT(NZZ2Y`n?sb5 z$hAb@UT7(=qXvD*+%A#%^=BSf^BO)awLNNyy^qu*5ZR|9+dAR;;zFM&Pf2G=2$`6a znclvO3@!2sJ|g3$LtImmAm>9tjb`XeLjpV9@eFyx^WB zR^S(^X9O%SQ*Q~;qq)jiA$y4t#Z89pjQNcr?5I*i5W+qsRr8E?K{tNotsev^C2;2V zuzY*CXvs%p;tASjhvm0TlcE%PJ~e9G(w{UHz;N+QWp_kl=)dkDlM z7(BpVD*}EU|I`Qkj{12YvR@GDfd5Sa@YhTvzc5Aof$3*Oz+dwa{le4z2cCZ^1pZx? z>p!skOEK{8vT!{5I|adCvrzuRV)+M_|Dh=Ocio)#2eO|P2LGSu=R5bGG69BPcozP^ z^B0PPe}8h%Vg6ok@GH;nii3X*5X@ie4}L$zpO@ZHeqnJz{Q1AT-*G?pY^cBBIxv4( zru!ZE^W*=ow_rQ|zZ$&XQ9lDoClose(); } +void ScFiltersTest::testTdf35636() +{ + ScDocShellRef xDocSh = loadDoc("tdf35636.", FORMAT_ODS); + CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is()); + + ScDocument& rDoc = xDocSh->GetDocument(); + + // Without the fix in place, SUMIF would have returned 0.0 + // with empty cells in the criteria + CPPUNIT_ASSERT_EQUAL(50.0, rDoc.GetValue(ScAddress(1,4,0))); + + xDocSh->DoClose(); +} + void ScFiltersTest::testVBAMacroFunctionODS() { ScDocShellRef xDocSh = loadDoc("vba_macro_functions.", FORMAT_ODS); -- 2.11.4.GIT