warn on load when a document binds an event to a macro
commitb3edf85e0fe6ca03dc26e1bf531be82193bc9627
authorCaolán McNamara <caolanm@redhat.com>
Wed, 7 Aug 2019 16:37:11 +0000 (7 17:37 +0100)
committerCaolán McNamara <caolanm@redhat.com>
Tue, 13 Aug 2019 11:26:15 +0000 (13 13:26 +0200)
tree62887e38b2f0b06ca8e74fffd126560b5b0c8049
parentc78dd0a726b32d922a0d75a26a51d4c30612368c
warn on load when a document binds an event to a macro

a) treat shared/Scripts equivalently to document scripts

This doesn't automatically warn/block running those scripts when used in a
freshly loaded document on its own however

because DocumentMacroMode::checkMacrosOnLoading will see at...

if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() )

that the document contains no macros and flip the allow macros flag to true so
that potentially new uses of macros added by the user during the edit are
allowed to run

b) so, add an additional flag to indicate existence of use of macros in a document

c) for odf import, set it when a script:event-listener tag is encountered
d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called
e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure
f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called
g) for oox import when VbaProject::attachMacros is called

Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b
Reviewed-on: https://gerrit.libreoffice.org/77131
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
30 files changed:
comphelper/source/misc/documentinfo.cxx
dbaccess/source/core/dataaccess/ModelImpl.cxx
dbaccess/source/core/dataaccess/databasedocument.cxx
dbaccess/source/core/inc/ModelImpl.hxx
include/comphelper/documentinfo.hxx
include/oox/ole/axcontrol.hxx
include/sfx2/docmacromode.hxx
include/sfx2/objsh.hxx
include/xmloff/xmlimp.hxx
oox/source/ole/vbaproject.cxx
sc/source/filter/excel/xiescher.cxx
sc/source/filter/inc/xiescher.hxx
sc/source/ui/vba/vbasheetobject.cxx
sc/source/ui/vba/vbasheetobject.hxx
scripting/source/protocolhandler/scripthandler.cxx
sfx2/source/doc/docmacromode.cxx
sfx2/source/doc/objmisc.cxx
sfx2/source/doc/objstor.cxx
sfx2/source/doc/objxtor.cxx
sfx2/source/doc/sfxbasemodel.cxx
sfx2/source/inc/objshimp.hxx
sw/source/filter/html/htmlform.cxx
sw/source/filter/html/htmlgrin.cxx
sw/source/filter/html/swhtml.cxx
sw/source/filter/html/swhtml.hxx
sw/source/filter/ww8/ww8par.cxx
sw/source/filter/ww8/ww8par.hxx
sw/source/filter/ww8/ww8par5.cxx
xmloff/source/core/xmlimp.cxx
xmloff/source/script/XMLEventImportHelper.cxx