LibreOffice.git
13 months agoBump version to 7.0.7.0.M3mimo-7.0.7.0.M3
Andras Timar [Mon, 7 Jun 2021 07:01:21 +0000 (7 09:01 +0200)]
Bump version to 7.0.7.0.M3

Change-Id: I655362c64ce7e517ac22c268bdf9be71c76da061

13 months agono MinimumWidth of Sidebar for MIMO
Andras Timar [Mon, 7 Jun 2021 07:00:47 +0000 (7 09:00 +0200)]
no MinimumWidth of Sidebar for MIMO

Change-Id: I66fc17b1d791e06debe95248a8952986171a4596

13 months agoResolves tdf#140360 - Provide option to turn off sidebar's minimum width
Heiko Tietze [Fri, 4 Jun 2021 12:42:58 +0000 (4 14:42 +0200)]
Resolves tdf#140360 - Provide option to turn off sidebar's minimum width

Boolean option Sidebar:General:MinimumWidth introduced defaulting
to true; if false the sidebar width is under full user control

Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
13 months agoBump version to 7.0.7.0.M2mimo-7.0.7.0.M2
Andras Timar [Tue, 25 May 2021 08:45:54 +0000 (25 10:45 +0200)]
Bump version to 7.0.7.0.M2

Change-Id: I3589ece776cf6c97e2a7652c455644642d28312a

13 months agoUpdate git submodules
Andras Timar [Tue, 25 May 2021 08:42:49 +0000 (25 10:42 +0200)]
Update git submodules

* Update translations from branch 'distro/mimo/mimo-7-0'
  to 39aa21b0115d6e2efeb7904dcf9477189cb00a0e
  - Frech translation of Esperanto dictionary bits

    Change-Id: I0a4620f0eb98f9c2293194fea0006e5a803bf9c2

13 months agoDictionary list required by MIMO
Andras Timar [Tue, 25 May 2021 08:16:03 +0000 (25 10:16 +0200)]
Dictionary list required by MIMO

Change-Id: Idefb9480460ae4ba946d7171811fde432c3c0927

13 months agoAdd Esperanto dictionaries
Andras Timar [Sun, 11 Apr 2021 08:00:41 +0000 (11 10:00 +0200)]
Add Esperanto dictionaries

Change-Id: I22d73bb5a6e4d215dc35acdd4ded47d29882671e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113941
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
13 months agoUpdate git submodules
Carmen Bianca Bakker [Tue, 25 May 2021 08:12:36 +0000 (25 09:12 +0100)]
Update git submodules

* Update dictionaries from branch 'distro/mimo/mimo-7-0'
  to 90cd7b5c7e4a304547373229c9bf5077504e431d
  - Add Esperanto dictionary

Signed-off-by: Carmen Bianca Bakker <carmen@carmenbianca.eu>
    Change-Id: I1852b0eedc9b397c43f213dab60ff08e44b01678
    Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/110415
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
14 months ago[cp] HACK: sleep before signmimo-7.0.7.0.M1
Andras Timar [Wed, 18 Apr 2018 14:19:00 +0000 (18 07:19 -0700)]
[cp] HACK: sleep before sign

On Windows, with 16x parallel build, build-nocheck target fails,
because it tries to sign a file that is already in use (gengal).

Change-Id: Ic582334f2c02f5e38f49d048fc0425025ffeee41
Reviewed-on: https://gerrit.libreoffice.org/75235
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
14 months agotry to use a different timestamp service
Andras Timar [Thu, 11 Feb 2021 07:27:23 +0000 (11 08:27 +0100)]
try to use a different timestamp service

Change-Id: I0fdbe2871d74836d530a69532bf22c17f642c922

14 months agoBump version to 7.0.7.0.M1
Andras Timar [Mon, 10 May 2021 21:27:34 +0000 (10 23:27 +0200)]
Bump version to 7.0.7.0.M1

Change-Id: I5198132ce2b586d95c9f5fe023ac9482acddbebe

14 months agoallow utf-8 in xml names (liborcus) (tdf#141672)
Luboš Luňák [Thu, 29 Apr 2021 18:10:34 +0000 (29 20:10 +0200)]
allow utf-8 in xml names (liborcus) (tdf#141672)

Change-Id: Ib150d55b588a572e4352396f18de2331983b2aae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114892
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 6b7c2fa65eb68be520ed4135cc245e33fa22e8bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114915
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
14 months agogbuild: work around GDB 10 bug with DWARF5 in split debug infolibreoffice-7-0mimo-7-0-branch-point
Michael Stahl [Tue, 4 May 2021 07:22:03 +0000 (4 09:22 +0200)]
gbuild: work around GDB 10 bug with DWARF5 in split debug info

GCC 11 defaults to -gdwarf-5 and GDB can only read it if
-gsplit-dwarf isn't used.

Dwarf Error: wrong unit_type in compilation unit header (is DW_UT_split_compile (0x05), should be DW_UT_type (0x02)) [in module /workdir/CObject/desktop/source/app/main.dwo]

https://sourceware.org/bugzilla/show_bug.cgi?id=27354
https://bugzilla.redhat.com/show_bug.cgi?id=1956475

Change-Id: Ie2ac7193a29a8f257cf6f1d711f9fa6941df48ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115054
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit dc8c8a4aa20ddd3139a25d5c052cac9bae944cb8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115193
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
14 months agoupdate credits
Christian Lohmaier [Thu, 6 May 2021 13:27:25 +0000 (6 15:27 +0200)]
update credits

Change-Id: Ifa86e93a66d54d5ad8f288ba111cbe4ca1695415
(cherry picked from commit b6516acdb96a7417f0d58749723750d83547f98a)

14 months agotdf#141930 document set as unmodified if editengine didn't modify on keyevent
Caolán McNamara [Tue, 4 May 2021 08:15:25 +0000 (4 09:15 +0100)]
tdf#141930 document set as unmodified if editengine didn't modify on keyevent

this appears to have always happened for cursor keys, and since

commit 0154f04e8c64df937b793c73ac58d553637f324f
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Feb 24 14:32:21 2021 +0000

    Resolves: rhbz#1931423 start update timer in IM events as well as keyevents

also happens on Input Engine events which don't cause changes

Change-Id: Ic5cdd9ef4f1bed1cc2b2c17fc847f196a9c6e23a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114930
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 8e78b937fca92f5ed07383e69ceef71715a15fe1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115085
Tested-by: Caolán McNamara <caolanm@redhat.com>
14 months agoUpdate git submodules
Christian Lohmaier [Wed, 5 May 2021 17:21:55 +0000 (5 19:21 +0200)]
Update git submodules

* Update translations from branch 'libreoffice-7-0'
  to 64657573815f1d85d3cc4cf44272d6ba58128dda
  - update translations for 7.0.6 rc2

    and force-fix errors using pocheck

    Change-Id: Ia3d84528857164d3f608be7c88b2b315b6c7b40a

14 months agotdf#139329: Shift widgets down and make hatch&bitmap list visible
Katarina Behrens [Tue, 4 May 2021 08:06:26 +0000 (4 10:06 +0200)]
tdf#139329: Shift widgets down and make hatch&bitmap list visible

regression from commit cbe86ee37018dc4bf04783ecf70fef2863e61ad7
which inserted additional gradient colour picker but didn't
adjust the positions of widgets below accordingly so in effect
there were 2 widgets at position y=4

Sad that neither glade nor our own code detects this condition and
e.g. asserts or warns this is the case

Change-Id: I4c635eeb8b740765542631a5f0319bfe1a5d94d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115056
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <bubli@bubli.org>
(cherry picked from commit c46a231b987b92bd866b415d1a0ba0d3a26a2457)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115074
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 4956d637401e07e9d562233d963739ec16d0d929)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115081

14 months agoexternal/libwpd: Missing include for size_t
Stephan Bergmann [Thu, 5 Nov 2020 07:16:43 +0000 (5 08:16 +0100)]
external/libwpd: Missing include for size_t

...as now reported when building with recent trunk GCC/libstdc++ on Linux:

> In file included from WPXContentListener.cpp:26:
> In file included from ./WPXContentListener.h:29:
> ./WPXTable.h:56:31: error: unknown type name 'size_t'; did you mean 'std::size_t'?
>         const WPXTableCell  *getCell(size_t i, size_t j)
>                                      ^~~~~~
>                                      std::size_t

Change-Id: Ic20240f01c7b0305cb87ababf53a3aaf66072d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105324
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 8d378abf1de0a47517427c086da26588f846592a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115000
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 months agoexteranl/coinmp: Fix build with recent GCC 11 trunk
Stephan Bergmann [Thu, 1 Oct 2020 09:50:40 +0000 (1 11:50 +0200)]
exteranl/coinmp: Fix build with recent GCC 11 trunk

It had started to fail for me now with

>  ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -O -MT CoinFinite.lo -MD -MP -MF .deps/CoinFinite.Tpo -c CoinFinite.cpp  -fPIC -DPIC -o .libs/CoinFinite.o
> CoinFinite.cpp: In function 'bool CoinFinite(double)':
> CoinFinite.cpp:38:19: error: 'DBL_MAX' was not declared in this scope
>    38 |     return val != DBL_MAX && val != -DBL_MAX;
>       |                   ^~~~~~~
> CoinFinite.cpp:8:1: note: 'DBL_MAX' is defined in header '<cfloat>'; did you forget to '#include <cfloat>'?
>     7 | #include "CoinUtilsConfig.h"
>   +++ |+#include <cfloat>
>     8 |

because of a missing -DCOINUTILS_BUILD.  Which in turn was caused by
workdir/UnpackedTarball/coinmp/CoinUtils/configure (see
workdir/UnpackedTarball/coinmp/CoinUtils/config.log), which first tries to
determine an ac_declaration that would apparently be a suitable declaration of
`exit` without actually including <stdlib.h> in a C++ file.  It settles on

> configure:3551: ~/gcc/trunk/inst/bin/g++ -c -g -O2  conftest.cc >&5
> conftest.cc:15:17: warning: 'void std::exit(int)' has not been declared within 'std'
>    15 | extern "C" void std::exit (int) throw (); using std::exit;
>       |                 ^~~
> <built-in>: note: only here as a 'friend'
> configure:3557: $? = 0

(which generates a warning, but no error with the given g++ invocation).  The
determined ac_declaration value is then included in confdefs.h, causing the
later

> configure:4014: ~/gcc/trunk/inst/bin/g++ -o conftest -O3 -pipe -DNDEBUG -pedantic-errors -Wparentheses -Wreturn-type -Wcast-qual -Wall -Wpointer-arith -Wwrite-strings -Wconversion -Wno-unknown-pragmas -Wno-long-long   -DCOINUTILS_BUILD  -Wl,-z,origin -Wl,-rpath,\$$ORIGIN conftest.cc  >&5
> conftest.cc:15:17: error: 'void std::exit(int)' has not been declared within 'std'
>    15 | extern "C" void std::exit (int) throw (); using std::exit;
>       |                 ^~~
> <built-in>: note: only here as a 'friend'
> configure:4020: $? = 1
> configure: failed program was:
> | /* confdefs.h.  */
> |
> | #define PACKAGE_NAME "CoinUtils"
> | #define PACKAGE_TARNAME "coinutils"
> | #define PACKAGE_VERSION "2.9.11"
> | #define PACKAGE_STRING "CoinUtils 2.9.11"
> | #define PACKAGE_BUGREPORT "http://projects.coin-or.org/CoinUtils"
> | #define COINUTILS_VERSION "2.9.11"
> | #define COINUTILS_VERSION_MAJOR 2
> | #define COINUTILS_VERSION_MINOR 9
> | #define COINUTILS_VERSION_RELEASE 11
> | #define COIN_COINUTILS_VERBOSITY 0
> | #define COIN_COINUTILS_CHECKLEVEL 0
> | #ifdef __cplusplus
> | extern "C" void std::exit (int) throw (); using std::exit;
> | #endif
> | /* end confdefs.h.  */
> |
> | int
> | main ()
> | {
> | int i=0; i++;
> |   ;
> |   return 0;
> | }
> configure:4045: WARNING: The flags CXXFLAGS="-O3 -pipe -DNDEBUG -pedantic-errors -Wparentheses -Wreturn-type -Wcast-qual -Wall -Wpointer-arith -Wwrite-strings -Wconversion -Wno-unknown-pragmas -Wno-long-long   -DCOINUTILS_BUILD" do not work.  I will now just try '-O', but you might want to set CXXFLAGS manually.

to fail, because its g++ invocation including -pedantic-errors turns that

> 'void std::exit(int)' has not been declared within 'std'

warning into an error.

There were similar build failures in the Cgl,

>  ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -DCOIN_HAS_CLP -O -MT ClpCholeskyDense.lo -MD -MP -MF .deps/ClpCholeskyDense.Tpo -c ClpCholeskyDense.cpp  -fPIC -DPIC -o .libs/ClpCholeskyDense.o
> In file included from ClpCholeskyDense.cpp:11:
> ClpHelperFunctions.hpp:16:4: error: #error "don't have header file for math"
>    16 | #  error "don't have header file for math"
>       |    ^~~~~
> In file included from ClpCholeskyDense.cpp:11:
> ClpHelperFunctions.hpp: In function 'double CoinSqrt(double)':
> ClpHelperFunctions.hpp:81:13: error: 'sqrt' was not declared in this scope
>    81 |      return sqrt(x);
>       |             ^~~~

and Clp,

>  ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -I.. -I./.. -I./../CglGomory -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Osi/src/Osi -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Clp/src/OsiClp -I~/lo/core/workdir/UnpackedTarball/coinmp/Clp/src -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Osi/src/Osi -O -MT CglLandPValidator.lo -MD -MP -MF .deps/CglLandPValidator.Tpo -c CglLandPValidator.cpp  -fPIC -DPIC -o .libs/CglLandPValidator.o
> CglLandPValidator.cpp: In member function 'int LAP::Validator::cleanCut(OsiRowCut&, const double*, const OsiSolverInterface&, const CglParam&, const double*, const double*)':
> CglLandPValidator.cpp:66:22: error: 'fabs' was not declared in this scope; did you mean 'labs'?
>    66 |         double val = fabs(elems[i]);
>       |                      ^~~~
>       |                      labs
> CglLandPValidator.cpp: In member function 'int LAP::Validator::cleanCut2(OsiRowCut&, const double*, const OsiSolverInterface&, const CglParam&, const double*, const double*)':
> CglLandPValidator.cpp:189:23: error: 'fabs' was not declared in this scope; did you mean 'labs'?
>   189 |     double smallest = fabs(rhs);
>       |                       ^~~~
>       |                       labs

subdirectories, and which happened to get solved by the same approach of
removing problematic ac_declaration values from configure.

I am not sure what all that magic of determining that ac_declaration value is
supposed to be good for.  There appears to be no trace of it in the
corresponding configure.ac sources, so it likely was automatically added by some
dated autotools (all three configure files mention "Generated by GNU
Autoconf 2.59").  At least on a cursory look, the determined ac_declaration
appears to only be used in configure itself, and not leak into the actual coinmp
build stage, so dropping the problematic ac_declaration values is hopefully
harmless.  These three subdirectories were all that failed for me, but there
might still be silent issues in other subdirectories when a problematic
ac_declaration value would negatively affect other configure checks.  (An
alternative approach could be to regenerate all the configure files from their
configure.ac sources with a recent autotools.  But at least some of the existing
external/coinmp/*.patch* already change such configure files, which would need
to be adapted.)

Change-Id: I0a33b0f654800e8288d3ca28e26a64efc23a3f6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103756
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 762aacc4e055fffbc605be81f66f2274dccb4be8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114999
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 months agoexternal/coinmp: C++17 no longer supports "register"
Stephan Bergmann [Mon, 20 Jul 2020 14:23:18 +0000 (20 16:23 +0200)]
external/coinmp: C++17 no longer supports "register"

...and GCC 11 trunk g++ now defaults to C++17, so compilation started to fail
with that compiler

Change-Id: I792e4c7ff59ad88e5571163d5b2362fdb349667d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99082
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit ad607d898f9826c6fa144783c93541a10ad4740c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114998
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 months agoexternal/liborcus: Missing includes
Stephan Bergmann [Wed, 7 Oct 2020 20:29:46 +0000 (7 22:29 +0200)]
external/liborcus: Missing includes

...as seen with recent GCC 11 trunk libstdc++:

> orcus_xlsx.cpp: In function ‘size_t orcus::{anonymous}::get_schema_rank(orcus::schema_t)’:
> orcus_xlsx.cpp:313:59: error: incomplete type ‘std::numeric_limits<long unsigned int>’ used in nested name specifier
>   313 |     return it == rank_map.end() ? numeric_limits<size_t>::max() : it->second;
>       |                                                           ^~~

etc.

Change-Id: If92cfb565ed9344b2ec1403793d7aeff8bd019ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104074
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit a9976a958b2857e308c6598532151878615bfd9f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114997
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 months agogbuild: don't use -Wunused-macros with sccache
Michael Stahl [Sat, 27 Feb 2021 21:30:41 +0000 (27 22:30 +0100)]
gbuild: don't use -Wunused-macros with sccache

In at least soltools, jurt and gperf generated files, build with GCC and
sccache 0.2.16-alpha.0 reports spurious -Werror=implicit-fallthrough=
due to comments and these go away by configuring sccache with
rewrite_includes_only = true.

But his results in
cc1: error: ‘-fdirectives-only’ is incompatible with ‘-Wunused-macros’
so disable that like for clang-with-icecream builds.

Change-Id: I6dec38e86aa6e22591d7a700a8daddf3fed88b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111716
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 6fb9f368c6824a8ff7bc5bc5cf66fc2df7d055b7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114856
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
14 months agotdf#137945: sc: Add UItest
Xisco Fauli [Fri, 30 Apr 2021 08:49:28 +0000 (30 10:49 +0200)]
tdf#137945: sc: Add UItest

Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114871
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114935
Tested-by: Jenkins
14 months agoapparmor: Fix "oopslash" typo
Rico Tzschichholz [Wed, 28 Apr 2021 18:13:48 +0000 (28 20:13 +0200)]
apparmor: Fix "oopslash" typo

Change-Id: I8b355bceadeebebc9e6fedbf92a35aa44a356e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114819
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit f616d96bd8ce8986e4cc204953db0467e6060b5c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114866
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 12c9b81927aae792743ce3dbc0b09fecdb15b33c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114870
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 months agotdf#137945: Revert "use more FastParser in ScXMLContentValidationContext"
Xisco Fauli [Thu, 29 Apr 2021 07:33:35 +0000 (29 09:33 +0200)]
tdf#137945: Revert "use more FastParser in ScXMLContentValidationContext"

This reverts commit ae854970bf9c734df132797c0f23a7829efd167c.

This is only reverted in libreoffice-7-0 branch.
See https://bugs.documentfoundation.org/show_bug.cgi?id=137945#c2

Besides, this commit partially reverts d32289d715f7182b9e82a4d3fde9cfcf87517da3
< loplugin:unusedmethods > and be9f45ad69a510185971957e7643fd64b873e98d
< loplugin:unusedenumconstants > since some methods and enumerations
are needed after reverting the commit
Change-Id: Ia71257a37d384e7eb6ba904a6a13f8ae5603a79b

Change-Id: I04c74ceb6e38c54ea41464b8337016bb5f81d90d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114882
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 months agotdf#135997: fix toolbar control
Mike Kaganski [Wed, 28 Apr 2021 09:25:18 +0000 (28 11:25 +0200)]
tdf#135997: fix toolbar control

This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7,
just for the toolbar control (the older one was for special
character dialog).

The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11.

Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit b27de500b1412bacefc7144b5222c307ca1ae0fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114853
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
14 months agoupdate credits
Christian Lohmaier [Wed, 28 Apr 2021 15:29:28 +0000 (28 17:29 +0200)]
update credits

Change-Id: Idd3d14c272c1eebca7207054dccbeae4632c51cc
(cherry picked from commit 93a90a5b0558aeac847aefe06f49f68c00a26678)

14 months agotdf#132472: do not set text color when table style is 'Themed-Style-2'
Xisco Fauli [Thu, 22 Apr 2021 12:10:57 +0000 (22 14:10 +0200)]
tdf#132472: do not set text color when table style is 'Themed-Style-2'

and it has no Accent

Regression from 2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef
< tdf#107604 Handle predefined table styles. >

Change-Id: Id9ab5b20825e2eaf8cc138c108608fe446f33db4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114477
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 54f7c32beca5a9c99d7316dc38818edad55f7415)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114497
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114649

14 months agoelementary: tdf#141823 unify function icons
Rizal Muttaqin [Sat, 24 Apr 2021 04:03:08 +0000 (24 11:03 +0700)]
elementary: tdf#141823 unify function icons

Change-Id: I01a3f6be32a02c8762d81d27c93b38760ebfc66e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114592
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
14 months agotdf#139305 make both 'empty' widget and its treeview replacement the same size
Caolán McNamara [Thu, 4 Mar 2021 15:17:28 +0000 (4 15:17 +0000)]
tdf#139305 make both 'empty' widget and its treeview replacement the same size

so on flipping one visible vs the other the panel scrollbar position
is equally valid for each mode

Change-Id: Iae422c30eb8b752c407070b66852fe23fdc38912
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111925
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 0d20074eb112186e0e2fa4241b57777a335eb68c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114438
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
14 months agotdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."
Xisco Fauli [Mon, 19 Apr 2021 19:37:53 +0000 (19 21:37 +0200)]
tdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."

This reverts commit db1d2af02861b49e4f53d726d59cd71c20cee9b1

The commit was already partically reverted in
bca8d8985666d3fd22b91eb280f9baaeb933c2d0 < Resolves: tdf#90583
3D pie-chart missing guide handles >.
This partial revert broke the optimization introduced in
db1d2af02861b49e4f53d726d59cd71c20cee9b1 <Resolves: #i123539#
some optimizations for 3D chart...> for 3D charts like
https://bz.apache.org/ooo/attachment.cgi?id=81810

Later, 3D charts were optimized again in
55a7e836a2db662a53adc4f8b98d08b06790c758 < chart2: When
creating objects prevent setting object rects dirty > so
the remaining code originally introduced can go.

Import time of https://bz.apache.org/ooo/attachment.cgi?id=81810
is the same with and without this patch

Change-Id: I25338d0dfb4b41651dfe05e7bfbd74c86091dacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114313
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit eec03e848cb6874ce6d64dc0b8f45dbaf52e6c2b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114277
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114325

14 months agoBetter handling of filelocs
Stephan Bergmann [Tue, 20 Apr 2021 13:44:18 +0000 (20 15:44 +0200)]
Better handling of filelocs

Change-Id: Ic9c06cb476942ceb7d0166f22103e2e88cc9c21f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114339
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 177dcfec4e833f83f1f11c7bdbfc6f1977ebcee7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114355
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
15 months agobump product version to 7.0.7.0.0+
Christian Lohmaier [Tue, 20 Apr 2021 12:17:19 +0000 (20 14:17 +0200)]
bump product version to 7.0.7.0.0+

Change-Id: Ide7b3ae495ba963637b5a8f2e1da3a8c486dae2c

15 months agoUpdate git submodules
Christian Lohmaier [Tue, 20 Apr 2021 11:14:06 +0000 (20 13:14 +0200)]
Update git submodules

* Update translations from branch 'libreoffice-7-0'
  to 33b4a0389b295ea30030dda8510ed7f4895f8369
  - update translations for 7.0.6 rc1

    and force-fix errors using pocheck

    Change-Id: Id5c85dc0e0a4c8bfb067e1b2dd7c6a56bf0640fe

15 months agotdf#141525 Fix "Line with Arrow/Circle" insertion error.
Jeff Huang [Mon, 12 Apr 2021 06:16:02 +0000 (12 14:16 +0800)]
tdf#141525 Fix "Line with Arrow/Circle" insertion error.

When you insert "Line with Arrow/Circle" from "Lines and Arrows", it will show
"Line Starts with Arrow" instead of "Line with Arrow/Circle". This patch can
fix this issue. (This issue exists at least since 6.3 series.)

Change-Id: I827b9582951fe359d89245970e73d63f7697553f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113963
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
(cherry picked from commit 2b498e380a91a536d177376e854cf3a6e2fb0b35)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114179
Reviewed-by: Po-Yen Huang <jeff@mail.ossii.com.tw>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 4ee3d213e8d3c4afdc3714b50def117dfe5c8023)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114275
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agosvx: fix crash in DefaultProperties::dumpAsXml()
Michael Stahl [Fri, 16 Apr 2021 14:21:26 +0000 (16 16:21 +0200)]
svx: fix crash in DefaultProperties::dumpAsXml()

mpItemSet can be null

Change-Id: I4192f84639116c550bba5303a5fc70528cb3e8c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114263
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 832b23d9376019619929764606276aacde1e329a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114273
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
15 months agotdf#132901: do not add updatecheck to libmerged
Xisco Fauli [Sun, 18 Apr 2021 17:10:20 +0000 (18 19:10 +0200)]
tdf#132901: do not add updatecheck to libmerged

LibreOffice crashes if "online update"
feature is not installed

Regression from c63148ba139bd6b9ae7a0f9e24e51f29e5370963
< Revert "Revert "add some libs to libmerged"" >

Change-Id: Ia18f50bc6baf830b2d3e0814645ef04283bfaa04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114247
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 6064446f828f8cd612f7d6660153b2eb1139239b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
15 months agoColibre: Revise some icons
Rizal Muttaqin [Sat, 17 Apr 2021 03:42:55 +0000 (17 10:42 +0700)]
Colibre: Revise some icons

Change-Id: Id52445cc75293d44ac29a11692ad39f27472544b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114221
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
(cherry picked from commit 31bd90673226938ada8cc89875ca8db77233d3fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114185

15 months agotdf#140639 cache FcPattern for font options
Caolán McNamara [Wed, 14 Apr 2021 08:57:33 +0000 (14 09:57 +0100)]
tdf#140639 cache FcPattern for font options

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
also includes...

getFontOptions is always called with pitch of PITCH_DONTKNOW

getFontOptions is called from only one location and there
the pitch value is left at its default PITCH_DONTKNOW
which is suspicious but that's the way it currently is

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114076
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
use original FontAttributes instead of an intermediate FastPrintFontInfo

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
hintstyle is unused

left behind after...

commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b
Date:   Thu Jun 15 15:28:46 2017 +0200

    loplugin:unusedfields in vcl part3

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114140
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 365df37004630b68afafdc676e26f2599c2194a9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114011
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agotdf#141623 Qt5+cairo init surface with widget size
Jan-Marek Glogowski [Sun, 11 Apr 2021 15:21:57 +0000 (11 17:21 +0200)]
tdf#141623 Qt5+cairo init surface with widget size

The QFont based rendering path directly uses the widgets size to
initialize the QImage buffer image, so do the same for the Cairo
surface, instead of the arbitrarily size of 640x480.

Change-Id: I91326dab67cbbb5e75b78b02c34eaca61ad26482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113955
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 91c883e75436210ca8af95df1ca597caeeda8703)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113869
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(cherry picked from commit 3f204ca2fed7614e1e12180af5ce5bfd88249eb7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113870
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agoRelated tdf#117750: fix "Solarization" and "Aging"
Julien Nabet [Sat, 10 Apr 2021 17:09:41 +0000 (10 19:09 +0200)]
Related tdf#117750: fix "Solarization" and "Aging"

For solarization, regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c38485279cd36da96ac81107d567ea4e779b2b96
author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:27:41 +1000
committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:11 +0200
commit c38485279cd36da96ac81107d567ea4e779b2b96 (patch)
tree ad9843a17f87271f9e0cf89643e2e6c3ee8a8de1
parent bcbf767bcfc024e2be839e0c0886f942dd068e4f (diff)
vcl: ImplSolarize() to BitmapSolarizeFilter

For aging, regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ab12471f3a69c4d502e6271e84ddf8a981f507f
author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:32:23 +1000
committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:39 +0200
commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f (patch)
tree 6652276229ad1c3ffca48f7a31e1b77d2ea04b07
parent c38485279cd36da96ac81107d567ea4e779b2b96 (diff)
vcl: ImplSepia -> BitmapSepiaFilter

Change-Id: I4f350aa8b494caf55c9c810ac7fa9ed8db349725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113926
(cherry picked from commit f3151e62bcc7cb66313df70a2ec8eed8ca8f2c88)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113858
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d41693f2eb48fce3d808f1719bbd60f2d2041203)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113868
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
15 months agoRelated tdf#117750: fix UnsharpenFilter
Julien Nabet [Sat, 10 Apr 2021 17:30:23 +0000 (10 19:30 +0200)]
Related tdf#117750: fix UnsharpenFilter

Change-Id: I372bb6baae747adb3b2d2a2b8fd39d1631b074ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113927
(cherry picked from commit 3d32e6a6ccfae56f379cb1dec6dcadf9aa8fa85f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113859
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 8a75c591ef0cb017c58a7f068d1ae6571f87bd90)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113867
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
15 months agoResolves: tdf#139075 diagonal focus rects contain focus rects of old size
Caolán McNamara [Fri, 9 Apr 2021 19:50:58 +0000 (9 20:50 +0100)]
Resolves: tdf#139075 diagonal focus rects contain focus rects of old size

since...

commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc
Date:   Tue Jan 15 08:55:00 2013 +0000

    teach FrameSelector to be resizable

Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113857
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agoSukapura: tdf#141618 fix blured vertical line of Sukapura's anchor marker
Rizal Muttaqin [Sun, 11 Apr 2021 05:37:15 +0000 (11 12:37 +0700)]
Sukapura: tdf#141618 fix blured vertical line of Sukapura's anchor marker

Change-Id: I11b3fca85ec00049dfe84df6cfb548a320e255cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113937
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
(cherry picked from commit d9f10d8f0f6bae31dd5ebd9fa00f989d17fc21da)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113866

15 months agotdf#141600 fix blured vertical line of Colibre anchor marker
Rizal Muttaqin [Sat, 10 Apr 2021 09:09:09 +0000 (10 16:09 +0700)]
tdf#141600 fix blured vertical line of Colibre anchor marker

Change-Id: I5acab0328fd40e7eb4043a77197d78925c38237a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113862
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
15 months agoColibre: Revise some bullet/numbering icons
Rizal Muttaqin [Sat, 10 Apr 2021 23:13:40 +0000 (11 06:13 +0700)]
Colibre: Revise some bullet/numbering icons

Change-Id: I6ff3e82cc02272e10314cc92e6ee584fcc50724c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113864
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
15 months agotdf#141547: maQueryItems can be 0
Mike Kaganski [Thu, 8 Apr 2021 07:12:16 +0000 (8 10:12 +0300)]
tdf#141547: maQueryItems can be 0

E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it
and leave empty if relevant input item is empty.

Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed
the same checks in ScQueryEntry::IsQueryBy[Non]Empty.

Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit a0d2fb3217094aa7158310f0bcf16093bcc4984f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113757
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 7ba4eeb2e9b8153eb17779c93492ab80a5cd4644)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113767

15 months agoxmlsec: fix signing documents on WNT
Michael Stahl [Wed, 7 Apr 2021 15:00:43 +0000 (7 17:00 +0200)]
xmlsec: fix signing documents on WNT

Duplicate ds:X509Certificate elements cause:
warn:xmlsecurity.comp:9604:3820:xmlsecurity/source/helper/xmlsignaturehelper.cxx:658: X509Data do not form a chain: certificate in cycle:

(regression from 5af5ea893bcb8a8eb472ac11133da10e5a604e66)

Change-Id: I3d319a2f74dbec17b73f1c7bb8f4efe4e335f0ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113746
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit ae08aa8a095832ae2a88eac14f9680ac8d3a13b6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113752
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
15 months agotdf#141297 : remove link to the file
Arnaud Versini [Mon, 5 Apr 2021 10:33:11 +0000 (5 12:33 +0200)]
tdf#141297 : remove link to the file

Change-Id: I5c14f46f5fbd51d95eeb58ea0a6d3aa39afef3cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113597
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 7289b9a90f5f8349875856c552330d512004925e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113642
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 6494b99f09a29c22d51fb898423ced36ce02a9e7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113645

15 months agotdf#139786 partial revert tdf#106181 XLSX export: output form controls
Justin Luth [Wed, 31 Mar 2021 07:21:45 +0000 (31 09:21 +0200)]
tdf#139786 partial revert tdf#106181 XLSX export: output form controls

Not every export is going to be to OOXML format,
so don't just set ooxmlexport to true
and remove the "if" clause (especially when
leaving the comment that this is for DOCX only).

This is a partial revert to 7.1 (and backported to 6.4.5)
commit 577dd32b1c4eb0a4cff574fbabca987cb52b831b.

Change-Id: If7ea32a236715ec779cac302773c4c9da19865a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113399
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit a3c5c0f7ce73001adab7475fde1f8ffec4eef48b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113484
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 4d63b046679539c1e0f5a6f44e87c9420d679f5b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113638

15 months agoofz: Segv on unknown address
Caolán McNamara [Fri, 2 Apr 2021 13:28:37 +0000 (2 14:28 +0100)]
ofz: Segv on unknown address

Change-Id: I6c69375a89781fc0b87230203335c861efb562f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113482
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agotdf#141084 don't notify that the control has changed content until focus-out
Caolán McNamara [Thu, 1 Apr 2021 16:31:58 +0000 (1 17:31 +0100)]
tdf#141084 don't notify that the control has changed content until focus-out

while also keeping tdf#140239 working too

Change-Id: I42833f6a4d2440781cf3f2297b78c6e313b3d239
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113474
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit d0628bd6813de2685f4367118dc0f9ca036d1eaf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113477
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
15 months agoKJ: Improve small Select Outline Format icons
Rizal Muttaqin [Thu, 1 Apr 2021 04:01:26 +0000 (1 11:01 +0700)]
KJ: Improve small Select Outline Format icons

Change-Id: I18fd7e4656b12790ad8896cbe56f3896f4a178f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113435
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
(cherry picked from commit bc4f06a80a234ae4a90864a075df1e94ced3045a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113369

15 months agoxmlsecurity: replace OOXMLSecParser implementation
Michael Stahl [Tue, 30 Mar 2021 15:37:31 +0000 (30 17:37 +0200)]
xmlsecurity: replace OOXMLSecParser implementation

This is similar to 12b15be8f4f930a04d8056b9219ac969b42a9784 and following
commits, but OOXMLSecParser has some differences to XSecParser, such as
using a ds:Manifest, and requires a couple extra namespaces.

Change-Id: I56e39d9609db8fcad50ca1632ff482c1f0a30ff5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113381
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit cc1d19f7bbaefa5fb22ebd1344112755068b93c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113360

15 months agopython3-ify hrcex & uiex (creation of pot files)
Christian Lohmaier [Mon, 29 Mar 2021 13:55:45 +0000 (29 15:55 +0200)]
python3-ify hrcex & uiex (creation of pot files)

Change-Id: I824c9ed536a1e852d6bd157fbd7d4766327b7bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113319
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 9dfd55dffc4cca6617b4ee67be9a8bfe96601c00)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113354
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
15 months agotdf#140556 master document view not launching subdocument from context menu
Caolán McNamara [Mon, 29 Mar 2021 13:17:31 +0000 (29 14:17 +0100)]
tdf#140556 master document view not launching subdocument from context menu

Change-Id: I0ae61e51266ae050e340c1af99e0dd6a481e6ff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113282
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agoResolves: tdf#135364 ensure the window is released by a11y dispose
Caolán McNamara [Tue, 23 Mar 2021 13:05:26 +0000 (23 13:05 +0000)]
Resolves: tdf#135364 ensure the window is released by a11y dispose

the window dtor wasn't called with a11y enabled, with the side
effect that the pen color wasn't stored by the dtor

Change-Id: I5f482f53d4d93f1e2632cacf7c0a7407f0df1450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112956
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
15 months agosw fr_FR AutoCorrect: fix crash using "Apply and Edit changes"
Julien Nabet [Sun, 7 Mar 2021 09:40:42 +0000 (7 10:40 +0100)]
sw fr_FR AutoCorrect: fix crash using "Apply and Edit changes"

Bad calling of SvxAutoCorrect::FnAddNonBrkSpace() in French
documents, see tdf#140849 for a similar problem.

Change-Id: I19b964fb8fe437c7f98342a873a456ffded75d82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112120
(cherry picked from commit df41967a29c4f8243d1df2d9b23d7c41d4a13819)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112792
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
15 months agotdf#122717: fix handling of zero width/height lines
Xisco Fauli [Thu, 25 Mar 2021 16:38:20 +0000 (25 17:38 +0100)]
tdf#122717: fix handling of zero width/height lines

The code was introduced in 627c2469843c9461b665c4571f1214aca7fc36a4
< tdf#96674 drawingML import: fix handling of zero width/height lines >
and later on removed by 36bade04d3780bc54c51b46bb0b63e69789658a5
< tdf106792 Get rid of SvxShapePolyPolygonBezier > with the comment

"I doubt that the additional code to make a line not exactly hor/ver is needed.
Checked and it is not needed, thus removed the change from
tdf#96674 in shape.cxx."

it turned out, it's still needed

Change-Id: Ib64ee17227e3e588e94381abeabe5a2ff2e0b7d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113102
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 3e4eb070787d4d44b3bdc95046e5b231dbbef42b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113119
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 11d344f6271e4171f8006c2cb29372f612cbdc00)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113123
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
15 months agoBreeze: Add Save All & Save a Copy icons
Rizal Muttaqin [Sun, 28 Mar 2021 02:46:03 +0000 (28 09:46 +0700)]
Breeze: Add Save All & Save a Copy icons

Change-Id: I0371bf3fd30f451c8dbb3f62c1bbae4532755662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113221
Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
15 months agoSukapura: tdf#141282 fix wrong icon for Demote One Level with Subpoints
Rizal Muttaqin [Sat, 27 Mar 2021 11:39:56 +0000 (27 18:39 +0700)]
Sukapura: tdf#141282 fix wrong icon for Demote One Level with Subpoints

Change-Id: I63ee5a71f52a51a1682f924982c68c33c60781be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113203
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
(cherry picked from commit 2eb3c3ebfadc0927c0cdb2dad2c8f7716557ab3b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113212

15 months agoColibre: tdf#141284 Inconsistent Track Changes icons
Rizal Muttaqin [Sat, 27 Mar 2021 10:54:39 +0000 (27 17:54 +0700)]
Colibre: tdf#141284 Inconsistent Track Changes icons

Change-Id: Ib2ff76d83e49b6ba5c68d3b461c0608bd589f955
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113131
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
15 months agotdf#125936 writerfilter: treat escapement in numbering like styles
Justin Luth [Tue, 23 Mar 2021 10:18:43 +0000 (23 12:18 +0200)]
tdf#125936 writerfilter: treat escapement in numbering like styles

deferCharacterProperties wasn't occurring in the numbering import
(and so it was affecting the first run of the body text).

But just like character styles, it would be better to just
consider this auto-superscript instead of to defer it
and calculate based on the fontsize - since that really
isn't known until layout time, and so only works with
direct formating.

cherry-picked from 7.2's 2a7617653fb3d31e44e5cbcf8daf4b4c2a24e2c8

Change-Id: I9ce5a31c173089603316f4c3389e5f2e5dbe165a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112987
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113076

15 months agotdf#141079 Restore double click behavior for script fields
Samuel Mehrbrodt [Thu, 18 Mar 2021 10:41:29 +0000 (18 11:41 +0100)]
tdf#141079 Restore double click behavior for script fields

Change-Id: I5daa730740ea042bdae56b832f2557ec974339b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112668
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
(cherry picked from commit 5302268de6a33716c7746aa13232746ad2f2b561)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113072
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
15 months agotdf#140590 Writer crash in Tools>Chapter Numbering
Noel Grandin [Sat, 13 Mar 2021 16:12:24 +0000 (13 18:12 +0200)]
tdf#140590 Writer crash in Tools>Chapter Numbering

and an assert in vcl to catch it a little higher up the stack.

Change-Id: Iaa2e70f901f93ca9f678118e4f5a8bc1b6eda20a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112459
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112866
(cherry picked from commit ebbf550f7087b173bdcf600a02bb87c0b655e787)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113124

15 months agoupdate credits
Christian Lohmaier [Wed, 24 Mar 2021 16:19:41 +0000 (24 17:19 +0100)]
update credits

also stabilize sorting (number of commits, if equal first commit date)

Change-Id: Ia2f8484991b0de36f9769120f3d810422e8fc201
(cherry picked from commit 8dded9c4c901118cb73bf59398f6fe08a73fa04a)

15 months agotdf#141166 widget with id "tabcontrol" might not be a TabControl
Caolán McNamara [Mon, 22 Mar 2021 15:46:53 +0000 (22 15:46 +0000)]
tdf#141166 widget with id "tabcontrol" might not be a TabControl

it might be a VerticalTabControl or any other type

Change-Id: I9f46f7e64a9be2487d400cc4a066575c0d45c19e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112802
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
16 months agoxmlsecurity: improve handling of multiple X509Data elements
Michael Stahl [Thu, 25 Feb 2021 13:17:48 +0000 (25 14:17 +0100)]
xmlsecurity: improve handling of multiple X509Data elements

Combine everything related to a certificate in a new struct X509Data.

The CertDigest is not actually written in the X509Data element but in
xades:Cert, so try to find the matching entry in
XSecController::setX509CertDigest().

There was a confusing interaction with PGP signatures, where ouGpgKeyID
was used for import, but export wrote the value from ouCertDigest
instead - this needed fixing.

The main point of this is enforcing a constraint from xmldsig-core 4.5.4:

  All certificates appearing in an X509Data element MUST relate to the
  validation key by either containing it or being part of a certification
  chain that terminates in a certificate containing the validation key.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111254
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 9e82509b09f5fe2eb77bcdb8fd193c71923abb67)

xmlsecurity: improve handling of multiple certificates per X509Data

It turns out that an X509Data element can contain an arbitrary number of
each of its child elements.

How exactly certificates of an issuer chain may or should be distributed
across multiple X509Data elements isn't terribly obvious.

One thing that is clear is that any element that refers to or contains
one particular certificate has to be a child of the same X509Data
element, although in no particular order, so try to match the 2 such
elements that the parser supports in XSecController::setX509Data().

Presumably the only way it makes sense to have multiple signing
certificates is if they all contain the same key but are signed by
different CAs. This case isn't handled currently; CheckX509Data() will
complain there's not a single chain and validation of the certificates
will fail.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111500
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 5af5ea893bcb8a8eb472ac11133da10e5a604e66)

xmlsecurity: add EqualDistinguishedNames()

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111545
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 1d3da3486d827dd5e7a3bf1c7a533f5aa9860e42)

xmlsecurity: avoid exception in DigitalSignaturesDialog::getCertificate()

Fallback to PGP if there's no X509 signing certificate because
CheckX509Data() failed prevents the dialog from popping up.

To avoid confusing the user in this situation, the dialog should
show no certificate, which is already the case.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111664
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 90b725675c2964f4a151d802d9afedd8bc2ae1a7)

xmlsecurity: fix crash in DocumentDigitalSignatures::isAuthorTrusted()

If the argument is null.

This function also should use EqualDistinguishedNames().

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111667
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit ca98e505cd69bf95d8ddb9387cf3f8e03ae4577d)

Change-Id: I9633a980b0c18d58dfce24fc59396a833498a77d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111910
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agotdf#118693: no need to use convertMm100ToTwip() for line shapes anymore
Xisco Fauli [Wed, 17 Mar 2021 23:48:49 +0000 (18 00:48 +0100)]
tdf#118693: no need to use convertMm100ToTwip() for line shapes anymore

It was introduced in 11129d89b152db54c86bb2bda58c24b8abb6c5a8
< tdf#85232 WPG import: fix handling of line shapes >
and later in 36bade04d3780bc54c51b46bb0b63e69789658a5
< tdf106792 Get rid of SvxShapePolyPolygonBezier >
ForceMetricToItemPoolMetric was added to SvxShapePolyPolygon::setPropertyValueImpl
to convert from 100thmm to twips as can be read
in the comment in testTdf85232
With this change, xShape->getPosition().X in testTdf85232
is 2267, which was already in twips

Change-Id: I30b757885327a477213f96f8f84541971f435164
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112663
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit c9e5640c8fcad7beb42a66f9bee0252eee9fe323)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112619
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112671

16 months agoxmlsecurity: ignore elements in ds:Object that aren't signed
Michael Stahl [Fri, 19 Feb 2021 16:56:21 +0000 (19 17:56 +0100)]
xmlsecurity: ignore elements in ds:Object that aren't signed

Change-Id: I2e4411f0907b89e7ad6e0185cee8f12b600515e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111253
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 2bfa00e6bf4b2a310a8b8f5060acec85b5f7a3ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111909
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agoxmlsecurity: XSecParser confused about multiple timestamps
Michael Stahl [Thu, 18 Feb 2021 18:22:31 +0000 (18 19:22 +0100)]
xmlsecurity: XSecParser confused about multiple timestamps

LO writes timestamp both to dc:date and xades:SigningTime elements.

The parser tries to avoid reading multiple dc:date, preferring the first
one, but doesn't care about multiple xades:SigningTime, for undocumented
reasons.

Ideally something should check all read values for consistency.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111160
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 4ab8d9c09a5873ca0aea56dafa1ab34758d52ef7)

xmlsecurity: remove XSecController::setPropertyId()

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111252
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit d2a345e1163616fe3201ef1d6c758e2e819214e0)

Change-Id: Ic018ee89797a1c8a4f870ae102af48006de930ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111908
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agoxmlsecurity: replace XSecParser implementation
Michael Stahl [Fri, 12 Feb 2021 15:42:51 +0000 (12 16:42 +0100)]
xmlsecurity: replace XSecParser implementation

Implement Namespaces in XML and follow xmldsig-core and XAdES schemas.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110833
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 12b15be8f4f930a04d8056b9219ac969b42a9784)

xmlsecurity: move XSecParser state into contexts

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111158
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 59df9e70ce1a7ec797b836bda7f9642912febc53)

xmlsecurity: move XSecParser Reference state into contexts

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111159
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit cfeb89a758b5f0ec406f0d72444e52ed2f47b85e)

Change-Id: I03537b51bb757ecbfa63a826b38de543c70ba032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111907
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agotdf#136956 reorder undo actions in removeColumns
Mark Hung [Thu, 11 Mar 2021 15:44:06 +0000 (11 23:44 +0800)]
tdf#136956 reorder undo actions in removeColumns

and removeRows.  Inside the removeColumns and removeRows, undo actions
are added first, and then cell spans are updated to reflect the removed
columns or rows. Once undo the cell spans they become immediately
invalid because the rows or columns are already removed, hence cause
Impress to crash.

Change-Id: I9d8641bdad43026eca03cbeaaa3a5907b516304f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112355
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
(cherry picked from commit f3f7cc53efda828af8897fa45fa2a8f18cf3b48b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112526
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112649

16 months agodo same set error state as ReadAndVerifySignature does
Caolán McNamara [Thu, 11 Mar 2021 20:23:31 +0000 (11 20:23 +0000)]
do same set error state as ReadAndVerifySignature does

this function is nearly exactly the same as ReadAndVerifySignature
except it doesn't set error-state on exception during parse

Change-Id: Ife881f639a11d3185920ca62cc2cd22812fae36d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112366
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112412

16 months agotdf#134607 use kMDItemFSName instead of _kMDItemDisplayNameWithExtensions
Christian Lohmaier [Fri, 12 Mar 2021 11:25:30 +0000 (12 12:25 +0100)]
tdf#134607 use kMDItemFSName instead of _kMDItemDisplayNameWithExtensions

apparently the latter is not available on older versions of macOS.
https://developer.apple.com/documentation/coreservices/kmditemfsname
lists it as in version 10.4 and not flagged as deprecated, so keeping
fingers crossed that it is not affected by user-settings or similar…

Change-Id: I208d22f2abd628e7d95babc23ddb145a88bcf5cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112385
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit daa162c20f4c7d61edc217ed44cb2854652a63ec)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112528
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
16 months agoRevert "tdf#114076: Expand ClipRange to next PixelBound" ...
Xisco Fauli [Thu, 11 Mar 2021 11:42:47 +0000 (11 12:42 +0100)]
Revert "tdf#114076: Expand ClipRange to next PixelBound" ...

and "tdf#124272 use ClipRegion's geometry if not a rectangle"

This commit reverts c1230cede19ae3633e51c7ca780cb34d9dbaa20f
and 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c

tdf#114076, or any of its duplicates, is not reproducible in master
if c1230cede19ae3633e51c7ca780cb34d9dbaa20f
("tdf#114076: Expand ClipRange to next PixelBound") is reverted.
(Tested on Linux and Windows)
So, if we revert it, we no longer need
362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c
("tdf#124272 use ClipRegion's geometry if not a rectangle"), which
was a follow-up fix for a regression introduced by the first commit.

This also fixes tdf#129085 and all the duplicates, which were
introduced by the follow-up commit.

I plan to add the unittests in a different commit

Change-Id: Ie4328c15b24b521127c1b653bd621bfc92ac39cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112340
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112398
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
(cherry picked from commit 8926d9282fe84793ce909471b5caec3583fd3ec9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112530
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agotdf#141045 - fixed copy paste error in the replace function
Andreas Heinisch [Mon, 15 Mar 2021 12:41:58 +0000 (15 13:41 +0100)]
tdf#141045 - fixed copy paste error in the replace function

Change-Id: Id68670fed89e4cc700c5eea395139914bebdb657
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112509
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
(cherry picked from commit ac0b6fb3842201e438950ea99a55ad334f8521ab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112512
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit fde29198bd8e345c9a61a9f4d4671a3022a84cf9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112521
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agotdf#127217: Fix buttons in forms not working in Adobe Reader
Julien Nabet [Sun, 28 Feb 2021 21:23:30 +0000 (28 22:23 +0100)]
tdf#127217: Fix buttons in forms not working in Adobe Reader

Regression from 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb:
author Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-04-09 02:19:14 +0200
committer Katarina Behrens <Katarina.Behrens@cib.de> 2019-07-03 14:48:45 +0200
commit 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb (patch)
tree e778dad33073a228eb61ab62ce5f38e2a26d07ca
parent 1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433 (diff)
tdf#113448 don't export any font for radio buttons

Don't let only color value in m_aDAString since it'll go here:
        if( !rWidget.m_aDAString.isEmpty() )
        {
            if( !rWidget.m_aDRDict.isEmpty() )
            {
                aLine.append( "/DR<<" );
                aLine.append( rWidget.m_aDRDict );
                aLine.append( ">>\n" );
            }
            else
            {
                aLine.append( "/DR<</Font<<" );
                appendBuildinFontsToDict( aLine );
                aLine.append( ">>>>\n" );
            }
            aLine.append( "/DA" );
            appendLiteralStringEncrypt( rWidget.m_aDAString, rWidget.m_nObject, aLine );
            aLine.append( "\n" );
            if( rWidget.m_nTextStyle & DrawTextFlags::Center )
                aLine.append( "/Q 1\n" );
            else if( rWidget.m_nTextStyle & DrawTextFlags::Right )
                aLine.append( "/Q 2\n" );
        }

But if we shouldn't have /DR at all since we don't want fonts for radiobutton, it also means
we don't want /DA too.
Indeed at the end of 12.7.3.3 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf:
The default appearance string (DA) contains any graphics state or text state operators needed to establish the
graphics state parameters, such as text size and colour, for displaying the field’s variable text. Only operators
that are allowed within text objects shall occur in this string (see Figure 9). At a minimum, the string shall
include a Tf (text font) operator along with its two operands, font and size. The specified font value shall match
a resource name in the Font entry of the default resource dictionary (referenced from the DR entry of the
interactive form dictionary; see Table 218).

Change-Id: Ib350495d7fc5a7a4fba88d710614a0f67a0b1553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111724
(cherry picked from commit a0d63ee5df921e5f1ac915ada783fdef0dbbb057)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112306
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agoTipOfTheDay: remove odd tip regarding GSOC
Xisco Fauli [Fri, 12 Mar 2021 11:11:10 +0000 (12 12:11 +0100)]
TipOfTheDay: remove odd tip regarding GSOC

Change-Id: I4d7111de1fb734c51e6449913caa52adaf43b594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112381
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 6cae56fe25a51c9c0ec05253be8508940a013eee)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112415
(cherry picked from commit 82273325969bfe85422ed5123d0007b5a28fa75d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112417

16 months agotdf#140597 DOCX import: fix missing tblPrEx border
László Németh [Tue, 9 Mar 2021 10:11:10 +0000 (9 11:11 +0100)]
tdf#140597 DOCX import: fix missing tblPrEx border

of first table cells, caused by the workaround for tdf#138612.

Now property set of a new cell is a copy of the table exception
property set of the table row, as needed for the import of the
table style inheritance.

Regression from commit f319d6b543c2367546bc80d138e56ed03731e265
(tdf#138612 DOCX import: fix lost part of split table cell).

Change-Id: Iaf6637e757fbfeef7651a4300a7f65a23615f5c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112247
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit 53884e8fe92597e909e4fa5599192783c3d31a56)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112225
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agotdf#133473 Change SDRATTR_SHADOWSIZEX flag.
Gülşah Köse [Mon, 22 Feb 2021 11:44:03 +0000 (22 14:44 +0300)]
tdf#133473 Change SDRATTR_SHADOWSIZEX flag.

SDRATTR_SHADOWSIZEX holds a percentage value. So we
shouldn't use METRIC_ITEM.

Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112241
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112262

16 months agofix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)
Luboš Luňák [Mon, 8 Mar 2021 21:50:58 +0000 (8 22:50 +0100)]
fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)

Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 2fb274950e5207ca55f4f52325fb522bd44024e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112212
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112250

16 months agomake RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)
Luboš Luňák [Thu, 4 Mar 2021 14:35:44 +0000 (4 15:35 +0100)]
make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)

The original implementation had this peculiar idea of implementing
clipping using transparency, which slows everything down, because
contents need to be copied and then alpha-blended. Keep that only
for when edges of the clip are to be smoothed.
As a side-effect this also seems to fix tdf#115843 again.
The commit also adjusts the test for tdf#133477 to not rely
on the rounding introduced by the optimization from tdf#115843.

Change-Id: Iebae5996159cf9f17066205985c5b591abdae105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111966
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 6b8c157a0b4f37a09fdbf656919b2df06a3abc3e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112217
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112249

16 months agoDeduplicate some code
Mike Kaganski [Wed, 19 Aug 2020 22:06:18 +0000 (20 00:06 +0200)]
Deduplicate some code

Change-Id: I37c492adef30db748eaa975247d386dcd953257b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100949
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112248

16 months agotdf#140833 show ScHeaderControl help tip after double click time has expired
Caolán McNamara [Sat, 6 Mar 2021 21:34:22 +0000 (6 21:34 +0000)]
tdf#140833 show ScHeaderControl help tip after double click time has expired

so under gtk the popover isn't active when the double click is processed
by gtk because under load on wayland the double click is getting handled
by something else and getting sent to the the window underneath our
window

Change-Id: Ie3afcf45c69b7b947b1aeb787478f947deca9307
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112136
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
16 months agotdf#140700 nullptr dereference
Mike Kaganski [Sun, 14 Feb 2021 10:24:42 +0000 (14 11:24 +0100)]
tdf#140700 nullptr dereference

Change-Id: I6a2ffddfd67784ddc2194dafba7d3eaeb6e4e12e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110854
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 20305894243e24eb383ab9feefebf4a0e9f2644f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112084
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agotdf#139940 oox: mark end before growing largest segment backwards
Justin Luth [Wed, 27 Jan 2021 07:46:05 +0000 (27 10:46 +0300)]
tdf#139940 oox: mark end before growing largest segment backwards

This fixes a regression in 7.1 (backported to 7.0.1) caused by
commit 73993fdb5d4b507694cd0edf80887d19f7e2bf9a for tdf#134183.

The largest segment has already been found, so we know where the
next segment starts. Now if we grow it backwards, that shouldn't
affect where it ends. So flag the end before growing the start,
otherwise we would have to recalculate the end again.

Change-Id: Iaae401d0438e533c7498be56f48fa153f7d3ff0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110004
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit 247963e53cce24c199a751c8ffb17f58b3a7d473)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111926
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112058
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agotdf#140552 RTF export: fix hyperlink, in footnote, in hyperlink
Miklos Vajna [Mon, 1 Mar 2021 19:57:38 +0000 (1 20:57 +0100)]
tdf#140552 RTF export: fix hyperlink, in footnote, in hyperlink

Regression from commit 7d42346ba77c9c4df241ea40eaf550993ca18783
(tdf#90421 RTF export: ignore hyperlinks without an URL, 2015-04-21),
URLs can be nested in the footnote case, which requires a stack.
Otherwise the inner URL clears "the" URL and we don't close the outer
field as we believe it's empty, so it was not started.

Change-Id: I9f87ddbb7e597c413bf836eb9b58beb76722361f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111794
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 5a74baa4f033f84c4bbcec869a68eef149f77161)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111778
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111823
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
16 months agotdf#132368 svx: empty the interop grab-bag on ending text edit
Miklos Vajna [Thu, 25 Feb 2021 17:04:19 +0000 (25 18:04 +0100)]
tdf#132368 svx: empty the interop grab-bag on ending text edit

Regression from commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 (PPTX
export: save SmartArt as diagram instead of group of shapes,
2019-03-13), the idea of interop grab-bag was to carry additional
information around as long as the object is not changed.

However, actual clearing of the grab-bag was never implemented, do this
when editing shape text.

An alternative would be to do this in SdrObject::SetChanged(), but
Writer sets the layer of SdrObjects during layout (when the import
filter is already finished and undo is enabled), so that would mean loss
of the smartart metadata for DOCX.

Change-Id: I9ab205b4ef84169f4b5a16b86fe9a152e3370a6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111560
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111595
(cherry picked from commit 4bf14305dfa22a3e4084b630b6924a718d7da3ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111702

16 months agogeneric Skia workaround for VCL sending empty size (tdf#140288)
Luboš Luňák [Thu, 25 Feb 2021 11:37:54 +0000 (25 11:37 +0000)]
generic Skia workaround for VCL sending empty size (tdf#140288)

There have already been commits to handle this, but the case
of getting the wrong size the first was still broken (or was
fixed in the past and got broken again). Try to be generic
by forcing these to be always considered to be offscreen
and force non-zero size there.

Change-Id: Ie366a296f7f6645333630fa31e9fe18d54c7fba8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111528
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 9d8c04d2d5529626d649af3fcebb6d4b65193b28)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111711
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 21305ff47a1bee1fa4787bf792fb3ecdb10d4863)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111782
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agopython3: upgrade to release 3.7.10
Michael Stahl [Wed, 17 Feb 2021 12:56:52 +0000 (17 13:56 +0100)]
python3: upgrade to release 3.7.10

Fixes CVE-2021-3177 plus these less important ones:
CVE-2021-23336 CVE-2020-27619 CVE-2020-14422 CVE-2020-26116
CVE-2019-20907 CVE-2020-8492 CVE-2019-18348

Change-Id: I8e83395bd3e871eb2ed030a03827b7d261c96049
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111067
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
16 months agoupdate credits
Christian Lohmaier [Tue, 2 Mar 2021 18:19:10 +0000 (2 19:19 +0100)]
update credits

Change-Id: I9493971d90d9bc1629b1f2a0a1259db233656284
(cherry picked from commit 6c92ca3e04c68dff68345b71a5d01c1764a5ef35)

16 months agoUpdate git submodules
Christian Lohmaier [Tue, 2 Mar 2021 13:03:00 +0000 (2 14:03 +0100)]
Update git submodules

* Update translations from branch 'libreoffice-7-0'
  to 4ad721ccb9748150616dfc4831e7f1d6706a831f
  - update translations for 7.0.5 rc2

    and force-fix errors using pocheck

    Change-Id: I1714d06878fca62790a2db7c580c1a2526842a05

16 months agotdf#139039 sfx2 store: fix export to PDF when dir name is URL-encoded
Miklos Vajna [Mon, 22 Feb 2021 20:07:34 +0000 (22 21:07 +0100)]
tdf#139039 sfx2 store: fix export to PDF when dir name is URL-encoded

Regression from commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2
store: create temp files next to local files, 2018-01-08), the problem
was that the directory hosting the input ODT file was called
"Bugzilla%C3%BF" (URL-encoded from "ÿ"), we got this as
"Bugzilla%25C3%25BF" (encoded from directory name), but we forgot to
decode it before passing this URL to the utl::TempFile ctor as a parent
directory, which resulted in failing to save as PDF, and crashing on
DOCX export.

Note that in practice this only caused a problem on Windows.

(cherry picked from commit aaf7fe0326b3be088a5440525363317fb3d0f158)

Change-Id: I5fc8a356b63efc2f16405a14ee59a061b52c5205
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111372
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111747

16 months agotdf#140137 Don't throw exception when w:gridCol is missing "w" attr
Aron Budea [Sun, 28 Feb 2021 21:04:24 +0000 (28 22:04 +0100)]
tdf#140137 Don't throw exception when w:gridCol is missing "w" attr

2149e924cbc32c370128c5f87a4f55c50c99e6bd added a division-by-zero
check, which caused Writer to throw an error on the bugdoc.
Since the file could be loaded fine before, let's return to a
working version, with the check included.

The cause is the following in document.xml
(originating from a non-MS generator):
  <w:tblGrid>
      <w:gridCol/>
      <w:gridCol/>
  </w:tblGrid>

Word still splits such tables differently, but that difference
was always there in Writer.

Change-Id: I6d91a736f460394a76f035298a238c41da201cb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111723
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111736
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111741

16 months agotdf#140528 Crash in writer when switching from Numbering to Position
Noel Grandin [Sat, 27 Feb 2021 13:05:21 +0000 (27 15:05 +0200)]
tdf#140528 Crash in writer when switching from Numbering to Position

regression from
    commit e5ecb998fd78137aec32ad2cc996eaa4bb3e499d
    Date:   Mon Dec 5 09:52:43 2016 +0000
    avoid coverity#1371269 Missing move assignment operator

rather write this code in a more obvious fashion, and bypass
the use of the very weird operator= method, which barely
copies anything at all.

Change-Id: I548d8f73224c2625ed6389861551038b18396b0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111677
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 9ab2284660857f52efc9b68b9d2dd8ea768d6916)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111696
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
16 months agoResolves: rhbz#1931423 start update timer in IM events as well as keyevents
Caolán McNamara [Wed, 24 Feb 2021 14:32:21 +0000 (24 14:32 +0000)]
Resolves: rhbz#1931423 start update timer in IM events as well as keyevents

Change-Id: I5a72adebd34c3983e7a414110c3192d05b725e45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111455
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Caolán McNamara <caolanm@redhat.com>
16 months agotdf#134940 sw: fix AutoCorrect of arrow "-->"
László Németh [Thu, 25 Feb 2021 09:55:57 +0000 (25 10:55 +0100)]
tdf#134940 sw: fix AutoCorrect of arrow "-->"

Fix bad replacement of "-->" with "–>" instead of "→"
(i.e. premature replacement of "--" to n-dash)
since '>' was added to IsAutoCorrectChar().

Regression from commit 57f07b1d7378d218648667c5b1315cc8ad905875
"tdf#133524 AutoCorrect: support double angle quotes".

Change-Id: I06f0cddb48d13c8e230dab964f79f588799ed4ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111527
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit d1be3d80d0ca5ccd7639ede379a1befc48dc73f2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111580
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
16 months agotdf#134619 docxexport: don't skip font properties in NumberingLevel
Justin Luth [Wed, 27 Jan 2021 19:56:04 +0000 (27 22:56 +0300)]
tdf#134619 docxexport: don't skip font properties in NumberingLevel

This partially reverts LO 6.4.5
commit 598ca431de96d8bfcf18fa2945e9e30f98387474

The output set can contain more than just the font name.
Things like colour and fontsize were being lost when
the "else" clause was added.

Since it looks like the main intent of the else clause was
to avoid specifying a font name twice, erase that from the
property set before writing out the rest of the font properties.
There is a unit test that enforces that.

(I was not able to reproduce the original problem that
this was trying to fix. The entire commit is hard to
revert, and I will assume that the rest of the commit
is useful/accurate, so just fix up a careless portion
of the commit.)

Change-Id: I772e40e8bd75c0589f3308d4d7470229855aed8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110034
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110169
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 5031a2932e9146db8b163ecfcaaf29e59cc4cc9d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110558
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
16 months agotdf#139070 format entry view of multilines with final formatting
Caolán McNamara [Tue, 23 Feb 2021 15:46:18 +0000 (23 15:46 +0000)]
tdf#139070 format entry view of multilines with final formatting

so during editing of a multiline the singleline entry shows what
it will show when editing is finished, so we suppress the default
behaviour of gtk to show a newline symbol and the default
behaviour of vcl to strip newlines

Change-Id: Id7d384efc8b737c463f1bd44ca61376f342edb25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111417
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Caolán McNamara <caolanm@redhat.com>