Public Git Hosting - LibreOffice.git/log

Branch libreoffice-7-2

This is 'libreoffice-7-2' - the stable branch for the 7.2.x releases.
The commit rules are different according to the development phase:

A. 7.2.0 beta phase:

   A. any bug fixes are allowed without review
   B. late features need approval by 3 people with different affiliation

B. 7.2.0 rc phase and later:

   A. fixes need approval by one reviewer
   B. late features need approval by 3 more people with different affiliation

IMPORTANT: Every developer is responsible for pushing the fixes into all
          appropriate branches. Note that we do not plan any merge
          from this branch to master or vice versa.

Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.

Update git submodules

* Update translations from branch 'master'
  to 47d2e3a3e6f9d4e2b17ff79b3a9cbdbe4619af16
  - update translations for 7.2.0 beta1

    and force-fix errors using pocheck

    Change-Id: I7ed5a77fb3ccb004ba1b79c55ae56a84c82f2803

tdf#142741 and tdf#38187 Set valid pages for footnote links PDF export.

Change-Id: I7c00e1a522a51796c9f543a74bd8abcee6792faf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117078
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

tdf#142242 Forename imported with trailing space

Fix the case where there is only a name, and no surname.

Change-Id: If11078364924c8332b113e5650e7ea2b262a357a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117080
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Update git submodules

* Update helpcontent2 from branch 'master'
  to 390d5cf871798108c4a45b78dfcdb22bbd4667cc
  - tdf#126507 Add help page for Combine Text in Draw

    Change-Id: I8fc7b9fa152d732486ac59c3d9544ac12a39e5e7
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117082
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Update git submodules

* Update helpcontent2 from branch 'master'
  to 94dc2e8bcf072bf62af674603cd9a5bc1a5d91bd
  - Fix embed links

    Change-Id: I5241d5b8e1417708bd8e4dfdee522cf6f5f6ccc9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117083
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Update git submodules

* Update translations from branch 'master'
  to 9b5d7036b809fb61a73e6a5b86bd3fcfbcda81f7
  - Update Slovenian translation

    Change-Id: I0b057409ee977097fd4020cd5cc606b5d4da1e63

tdf#128018 - Add column/row labels to the descriptive statistics

Change-Id: I22840433954a217ef5b5c1d3ea20e935d322e767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116852
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

Current baseline Clang 5.0.2 is able to upcast std::unique_ptr

Change-Id: I5ede872a6a629be1bcbd4d3e6fbd604cc76f1d77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116911
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#142387 DOCX track changes: export w:del in w:ins

by processing stack (revision history) of redline ranges,
see GetStackCount() and GetRedlineData().

Change-Id: I7a9085bc1598f0a5e3ab4de6887a12e81738d4f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117069
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Fix typos

Change-Id: Ibd4f8ac232eddad2b8a6c970999f0adf61a07acf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117077
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins

Update git submodules

* Update helpcontent2 from branch 'master'
  to c13c0567cc458e30b2947110f5a76015f52b4200
  - Fix typos

    Change-Id: If1fce3d46d1b26408fc4557c426c18ace6c07277
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117076
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Backgrd -> Background

Change-Id: I55bccacfe6c6b44570a24e9f5125e40a1a83d6ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

when converting WMF to WMF, simply do a direct copy

Actually, if we have the graphics data, just copy the graphics data,
that'll keep both the EMF+ and non-EMF+ content.

Change-Id: Ia14df0ba2a94d4310ee745b49de1d2190e425f05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117063
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

drop EMF+ also when converting WMF, not just EMF

A WMF may have EMF with EMF+ actions embedded. When we read that,
we drop drawing non-EMF+ actions if we use EMF+. But EMF+ actions
are stored as MetaCommentAction in the metafile, and WMF writer
(unlike EMF) writer simply ignores comments. So when writing WMF,
make sure to read non-EMF actions so that something is written.

This is an extension of 295626a0bd39540544b774094a63df23e5376839.

Change-Id: I37355f694fe656b661abe54274ea203934e68151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117062
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Related: tdf#127013 Check loaded separators for validity

... not only if something is present at all.
That way future restrictions can reset separators.

Change-Id: I738bcb9e052e8dbecb0a6cd07bbae8f4a8ea1c35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117072
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Update git submodules

* Update helpcontent2 from branch 'master'
  to 38ce99f8010aed59242b817b866055407f22cefb
  - Create introductory ScriptForge help page

    Change-Id: I5fd00cc05b0c28b600974c005a81804c1c6d5e74
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116906
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

Resolves: tdf#127013 differentiate non-/array separators and restrict

Change-Id: I9ff6b816b0c7af9081954fa407a4d516a576a338
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117068
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

gtk4: starting point for welded menus

submenus will need a rethink I guess

Change-Id: I6d2a645267146c537fe7ba62d8be2501855e7f62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

gtk4: build deeper levels of GMenuModel

Change-Id: Ia2cbe4fdc583d272152b4eaa9da9f9d2ff4af550
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117066
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

MetaAction::Clone() -> const

Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Add extended tips to bulletandposition.ui dialog

Change-Id: Ibb6c4013c587cc89b1438c264554d9e356467680
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117060
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Simplify Sequence/vector initializations

Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

EMF tdf#59814 tdf#142567 Align RestoreDC record with MSO implementation

Some of WMF and EMF behaviours are undocumented.
In that case, we are implementing the behaviour, observed in MS Office
or MS Paint.

With this commit the behaviour of import EMF RestoreDC records,
will be the same as for MS Paint and MS Office.

Change-Id: I73b65d14018f2667ffd59daf16ecc6d7ce9c1870
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117052
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

sw define bibliography entry dialog: unconditionally allow the browse button

This eliminates the "Local file" type, arguing that regardless of the
type of the bibliography entry, it may make sense to associate a local
URL with that.

Additionally, this allows using the file picker with non-HTTP URLs, like
webdav.

Change-Id: I315facdcf292f439765c420e5368a99267fe1a98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117059
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

ScriptForge - (scriptforge.py) add reference to SF/Python help page

Change-Id: I68ec6c53bbf9f6631f33192776b154936c1b721e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117065
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

Simplify vector initializations

Change-Id: Icf8972be204799e9b3b3824ab18d8584911fe1c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117061
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

gtk4: support separators via manipulating menu sections

Change-Id: Iaade04dd5a4fa89ef74a22a19ebe5e37655fc61a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

use freshly compiled dump_syms.exe on windows for symbolinfo extraction

while self compiled one still segfaults frequently, it is a tad better
than the included one (and compiling froms source instead of using
precompiled binaries is a net win in any case)

Out of 50 attempts with the mergedlo.dll, the new compiled dump_syms
succeeded 11 times, the shipped one succeeded 7 times - so could still
be regular variance in that small sample size, but at least not
significantly worse either.

Change-Id: I86c213fe6aece58f1391d4c2bf9906b85eee9c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117056
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

Another place where SfxItemState was used as placeholder

Change-Id: I54e549db50b7485024a305eb39fda848cbed6b78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117036
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

The mechanism around NUMRULE_STATE does only do something
when the SfxItemState is actually SfxItemState::SET, so this
can be reduced to use a valid Item shared_ptr when this is
the case

Change-Id: I973648abff3696057f2ca21608ed64570742dddb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117043
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

Another place where SfxItemState::UNKNOWN was used as placeholder

Change-Id: Ie2757e8356bfea7010b0442d72ef7865cbb18d5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117034
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins

qt5/kf5: Fix crash on exit

This extends the solution from

    commit fa8db25af6218262b3dab2e93b76464975889ceb
    Date:   Thu Jun 3 20:47:10 2021 +0100

        gtk4 crash on exit

to cover the qt5/kf5 cases as well, after seeing
equivalent crashes with kf5 VCL plugin
(e.g. when starting Writer and no profile exists) after

    commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
    Date:   Wed Jun 2 13:06:54 2021 +0200

        fix shutdown leak in CppunitTest_sw_filters_test

Change-Id: I4ef25bac0891c059588dbc8e6abe50db14230dea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117042
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Simplify Sequences initializations (writerfilter/writerperfect/x*)

Change-Id: I1bd31fe6cf0f8aaf4f2cfe1d3d49e61a0633f361
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117057
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify Sequences initializations (vbahelper)

Change-Id: I9bbcf97acd59e7430758e05ae949f7e494afc704
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117051
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify Sequences initializations (vcl)

Change-Id: Id93bde17dbc4c71ad93bc094b94408fc9e39ec98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117055
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

loplugin:unusedmethods improve filtering

Change-Id: I75771dbcecd58259bffdd2ddb0df631205aa8d93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117032
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Simplify Sequences initializations (unotools)

Change-Id: Ibc5deee4b69213310a75c2a74a800d99bc451424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117047
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify Sequences initializations (ucb)

Change-Id: Idd38076a40b1177253719c01c1928da4c903151c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117017
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify even more initializations in svl/passwordcontainer.cxx

Change-Id: I42cb919a8853df050d71b97f86abd20fdfccb5a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116978
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify Sequences initializations (sw)

Change-Id: I02647bdb720620afe20284a069a71c19dbfcea05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116944
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify Sequences initializations (sc)

Change-Id: I0c581b3a900a6b89c0f4e203310d65600545987f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116929
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

sw_uiwriter3: Unify code and use createSwDoc everywhere

Change-Id: I8054b4a9661e1873fa30390b7f7c85bd654343ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117049
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

gtk4: process sections and submenus of toplevel menumodel

and place initial contents into a section by default

Change-Id: I1e7bb20bf5efb481e4f7ed0f38c8b46c06f7a7d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117050
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

cid#1473844 Untrusted loop bound

and

cid#1474351 Untrusted loop bound
cid#1474118 Untrusted loop bound

this time without second guessing the original intent

Change-Id: Iaa6b636a08ed29feaf709fbcbac7deac761a0fc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117045
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

Update git submodules

* Update helpcontent2 from branch 'master'
  to ab81b6bfa02cd89c244bc55148486324863844f8
  - sf_form(control) Python support

    Change-Id: Iad14d1c5c7d353e50aba84d0cfa461e56f69f4ef
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115969
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

Resolves: tdf#142758 Revert record parse misunderstanding

of 'Related: cid#1474351 Untrusted loop bound'

and add in documentation for the records

This reverts commit 2134d83b8d6e73ca8eacd812eb3431bff38c74f6.
This reverts commit 7c2e6058439da9d061e5e0bbd07c8b6d4f2ffcbf.
This reverts commit 3748fe3e4fc22a400b3120010192b75754e38b17.

Change-Id: I5b407eb4388a8d67fc863cc6070fbbf8b15321d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117044
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

loplugin:unnecessaryreturn in SvxColorValueSet::layoutToGivenHeight

Change-Id: Ia42158597588fe802a2f06a6e8e59f372c62c022
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117031
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

uiwriter: use createSwDoc instead of loadFromDesktop for empty docs

Change-Id: Iacfda21398bfd920c5e0be62893ba723ee99d738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117041
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

no need to make a copy here

Change-Id: I47d51d3d372403f30ab38697037cdb205839df44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117030
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

sw image anchor type: consider a style-based custom value

The anchor type is determined during insertion, it's stored as direct
formatting after that.

We used to have a user-profile default for the anchor type. This commit
allows customizing the Graphics or OLE styles: if they specify a custom
anchor type, then that is user instead of the user profile setting.

This allows creating templates where the default depends on the used
template and not on the user profile.

The UI for this was added in commit
5951da5175b9d7e5b3b47bd0d90989d2ef528c79 (sw image anchor type: add
style UI for this, 2021-06-10).

Change-Id: Id05342a5f38dc6267cdbe68b248dc50b87854ce2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117040
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

ofz#35150 crash in Bitmap::Crop from wmf load

which is a problem since...

commit 33d2cf7008de79106b5da4bba0241aa14d81d88f
Date: Sat Jun 5 19:30:46 2021 +0200

WMF Change the sign of read fields in BITBLT and DIB records

Change-Id: Iea1261a52866d691435f0612f672636009c00355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117039
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

ofz#35149 crash in vcl::bitmap::CreateFromData from wmf load

which has started since...

commit 01ded1e6d362dbcd7148334c6965d6ad00981d4a
Date: Tue Jun 8 23:07:28 2021 +0200

WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt

Change-Id: I5bbde55dbd9e239c05544ac4a21e2758770245d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117038
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

WMF/EMF tdf#59814 tdf#142567 Fix RestoreDC record

With previous implementation, the RestoreDC index argument was skipped,
and always the last entry was taken.

With this commit the support for reading SaveDC by specific index
was added. The SaveDC/RestoreDC index support was added for
both EMF and WMF, according to [MS-WMF] and [MS-EMF] documentation.

Change-Id: I9b8a1a41462ae01de25ac3c85e453bcd80e05537
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117033
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Related: tdf#139447 DBTreeViewBase ctor takes a bool if its a sqltype or not

Change-Id: I7924dfb3dc15e34fae93b435e1a9e76f3da29463
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117037
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

loplugin:unnecessaryreturn in sw/

Change-Id: Iaca3f5385fd2c763cd1121ae50624aaa4a1f6165
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117029
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

loplugin:unnecessaryreturn SwWrtShell::Toggle*

Change-Id: I221dca35df23205023cf675b83c94c83178217d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117028
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

math.desktop include "Spreadsheet" category

but it's not a spreadsheet

since...

commit dad7fe7227fb80a32d3c2c777584dc9d74b9e929
Date: Thu Jan 2 16:16:55 2014 +0100

Fix math categories to make SUSE rpm check happy

Change-Id: I0397ea12cd7f29f4b0c1f0e0ad76a3429b55c455
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116884
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

"drawinglayer" -> "drawinglayer.emf" log area for some emf code

Change-Id: I83fa2d40225f83b82cea7f8934f4afdee181abe3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117000
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

tdf#139447 crash on dragging query/table from explorer to calc sheet

Change-Id: Ic827cb967a9a9cb78f28a23707813aeec8381cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117018
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

CppunitTest_vcl_svm_test: add missing basegfx link

Missing probably because
https://gerrit.libreoffice.org/c/core/+/116967/1 was merged before its
https://gerrit.libreoffice.org/c/core/+/116959/4 parent.

Change-Id: I0c6304c98f27e1f24ee615e4580c8ad7458bf79b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117027
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

ParaLineSpacingControl::Initialize() is another place where
SfxItemState::UNKNOWN was just used as a placeholder for
a non-set SfxItemState (aka could not be queried)

Change-Id: I95ad01579e5aa4c86ace619e2201481742297c2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117016
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

FontworkBar::getState does not need to check for SfxItemState::UNKNOWN
at all, actions solely depend on FontWork object being selected.
This also greatly simplifies that method. Also, the optimization
by passing in a variable to checkForSelectedFontWork and remember
if already computed can be removed - also in other places where
it had to be given, but was not re-used at all

Change-Id: I35b1f36195feb1d645619665d2dd65a84b75b118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN

In this case SfxItemState::UNKNOWN was used as boolean
state to decide to keep extracted value or replace. First
method even throws an exception when SfxItemState::UNKNOWN
should happen.
I tried to be very careful in changing these methods, so
another look/check from reviewers will be welcome. I think
that code was unnecessarily complicated, too, butz hope to
not have touched semantics (behaviour) at all

Change-Id: Id213fedcafcfb655749caf2659f9a15b240ec27d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116999
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

Remove duplicate code

The two

> aSet.Put( aAnch );

had been like that ever since at least 84a3db80b4fd66c6854b3135b5f69b61fd828e62
"initial import", but only now aa9cb8e14749e7fb7a83b55a2bb095501f731a18
"-Werror,-Wunused-but-set-variable (Clang 13 trunk)" removed the lines of code
between them (and which should not have changed neither aSet nor aAnch as a
side effect, which could have explained the putative duplication), making the
duplication stick out. Lets assume this was an error ever since, and that just
one call is enough.

Change-Id: Ie1ad54fb31212849f242eea77bc9e436b6fd92f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116980
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

sw: handle InvertBorderSpacing when replacing compat options

This was added in commit de0866b507e259f1726d1015293aad8fcadd763a
(sw-invert-border-spacing.diff:, 2010-09-14), it's off by default and is
on for Word documents.

Change-Id: Idf1999dbe9e641259e09eaafbebd347199cd5db4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117015
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Add IntersectClipRegion cppunit tests to vcl

Two tests where added, IntersectRectClipRegion and
IntersectRegionClipRegion, along with their .svm files.
The tests create mutliple IntersectClipRegions and test
their attributes.

Change-Id: I33b7b13b4f3eef1de07cc063ef22fea034d65cfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116967
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Resolves tdf#142651 Writer: Next Change stopped working

by normalizing copy of PaM instead of reference

Change-Id: If2c8664de18eb9473151c5961ad7654932ca37e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116875
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

sw_uiwriter: remove duplicated createDoc method

Change-Id: Ie29cd4aa6907018d1bfe492c22ac1d431d0331ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117020
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

sw_layoutwriter: remove duplicated createDoc method

Change-Id: I25f995f06ce56ecec3411007bfd4f381cc7af207
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117021
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

loplugin:unnecessaryreturn SotStorageStream::Commit

Change-Id: Icfd32ea8b29aa544b71d0c4fc6bc67c06f81e327
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116987
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

schema: update to ODF 1.3 OS

Change-Id: I97e28612aeeebed709da9ad621250c6b26e55f92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116734
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

EMF tdf#142745 Improve performance of FILLRGN, PAINTRGN, EXTSELECTCLIPRGN

With previous implementation, during reading of rectangles
the optimizations were made after reading every single
rectangle. This was causing performance issues, with many
rectangles (eg. 2500 rectangles).

With this commit, the optimization is made after reading all
rectangles. It is improving performance of FILLRGN, PAINTRGN and
EXTSELECTCLIPRGN records.

Change-Id: I1b8b844efddd08e9bf6f6726c3fdf213a629883f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116996
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

-Werror,-Wunused-but-set-variable (Clang 13 trunk)

...ever since the code's introduction in
4e386a897cd43aae3664ce68e47dd46b271de780 "INTEGRATION: CWS macosxspellchecker"

Change-Id: I932b7ff4cc8aabf2e70379ed9ebe361881246c46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116997
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

-Werror,-Wunused-but-set-variable (Clang 13 trunk)

...ever since the code block's introduction in
14bc62ad0d9e0179f4178d2913ebba7abf99755e "INTEGRATION: CWS
aquafilepicker02_DEV300"

Change-Id: Id4cda7ed087b350361b0207034fc31819d65efad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116992
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

-Werror,-Wunused-but-set-variable (Clang 13 trunk)

...ever since the code's introduction in
adf0066a17538a394550237a54f6fc0027f6ed29 "#i91478# aqua implementation
(continued)"

Change-Id: I2dd7bbaba9e8068929f4792b7f953cbf01e03a7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116989
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

sw image anchor type: add style UI for this

A frame style contains RES_ANCHOR, and SwFormatAnchor::m_eAnchorId
already describes an anchor type. This is even exposed on the UNO API as
the AnchorType property and its ODF import/export is also implemented.

Enable UI for this, so that templates can decide the default anchor type
when inserting images. Still keep the "to frame" anchor type disabled as
its meaning is unclear for frame styles.

Change-Id: I5d8ef63af9c8f2efa6485c4ec827ba9aef9b8956
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116990
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Update git submodules

* Update helpcontent2 from branch 'master'
  to 2b074d47c5f66d96576df2003b29d3cf09b4702a
  - tdf#130063 Add Help page for revamped B&N dialog for Impress and Draw

    Change-Id: I770a45ff062056ee38d904324e1f0148a7eec9da
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116945
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Update git submodules

* Update helpcontent2 from branch 'master'
  to db2d4a1373cc1a025888c4ef0359620eac3f88f6
  - tdf#112685 Advanced TSCP classification help page

    * Refactor TSCP pages
    * Add help page for Classification dialog
    * Add Help page for Classification Toolbar

    Change-Id: Id11c15d6937400b7cd28a5d80c4e9438693b28a1
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116874
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Add extended tips to document classification dialog

Change-Id: I41ffe5c66e56ec7add2d4fcbb129ae2e3ff13b20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116915
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

loplugin:unnecessaryreturn AddonsOptions_Impl

Change-Id: Ic2adf9467af7118e8efbbae2132912f3cc3d6943
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116988
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

small optimisation in SvtListener::EndListening

erase immediately after find so we're working with cache-hot data.

Instead of calling something else, which will load other stuff, then
reload the data to do the erase.

Change-Id: Ibbcca584b488ec3edc5b271efbd15d9a9ea2213f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116986
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

loplugin:unnecessaryreturn SvtListener::EndListening

Change-Id: Ifa7092b31b6027eeb5d7df67ac8b7de9337faf66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116985
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

-Werror,-Wunused-but-set-variable (Clang 13 trunk)

all three variables were unused ever since the code's introduction in
229a0de9c81554dfe6c96a0095a582476abc87ba "CWS-TOOLING: integrate CWS
appleremote01"

Change-Id: Ib755b86c81a6823c440f9f6a392b8f4b7de973ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116984
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Adapt compilerplugins to Clang VK_RValue -> VK_PRValue rename

<https://github.com/llvm/llvm-project/commit/aef5d8fdc7d0d348125d5ecf4a13be5888eb1654>
"[clang] NFC: Rename rvalue to prvalue"

Change-Id: I237e8a491465500e35637f8dae400402bcd9411d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116983
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

drop firebird test of initial experimental period fdb-only format

Initially when the firebird embedded database support was first
experimental we saved the fdb firebird file format.

A test was added by 3f114eb4a2f3994b980aa607f2d4afc58e5aaa1d around then
(2013) to test loading firebird odbs

Then with

commit de899f0b350e51b1932fa4674f7ce2ae386cd1ce
Date:   Thu Jun 2 11:56:10 2016 +0200

    connectivity: firebird: use ODS12 test database for Firebird 3

if building with firebird 3 a replacement odb was created in firebird
3.X ODS12 format to use instead of the 2.X ODS11 file.

Those fdb file formats were endian specific and database version
specific. Which was a well known problem documented in tdf#72987 and a
blocker for leaving 'experimental' at that point in time.

So finally with

commit 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
Date:   Thu Aug 11 12:02:56 2016 +0200

    tdf#72987 GSoC Use Firebird backup format

the save was changed to save the backup fbk file format and load
restores the database from that fbk file format (2016) when available.

later in

commit 860ecb9e583627ab43097784ad98b41afd983ff6
Date:   Thu Jan 5 12:58:26 2017 +0100

    require firebird 3.0 for build (don't allow 2.5)

the firebird 2.X (ODS11) test of loading the fdb format was
dropped leaving just the firebird 3.X (ODS12) fdb case because firebird
3.X cannot directly load the ODS11 format

Now with the appearance of firebird 4 the same problem arises that
firebird doesn't load older binary formats directly.

In the end all we established here is that an odb containing only a fdb
is endian and version specific and a bad idea wrt compatibility so we
shouldn't do that. But we knew that, so embedded firebird databases were
an experiemental curosity until 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
enabled use of the fbk format.

We're not gaining anything with the test of loading the binary only case
because we know that's an unsustainable route we abandoned.

Change-Id: I9f1715a817392de9f3f6e891966bbd838a9ce933
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116981
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

drop unused dbaccess/qa/unit/data/firebird_integer_le.odb

Change-Id: Ic8ab7db1a0b2fd3425caf4714d26207ea2c35db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116979
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

svxcore: provide UNO constructor for com.sun.star.text.TextColumns

This allows to create it e.g. in Basic macros using CreateUnoService

Change-Id: I949d3b92c83cd9e763244f70b22f0f367b93cb48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116970
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#136766 Zoom slider in calc print preview has white background

I cannot figure out any way to make transparent stuff on the toolbar
behave under all rendering backends, so just revert this

this reverts
    commit 00cffc20e40b2412c7e9867eed24c9834504e24f
    Date:   Mon Sep 7 13:28:33 2020 +0200
tdf#135181 Calc print preview zoom slider print preview not
transparent (gen)

    commit 444c7c736be7545344298a9cbb3a69886edc5ecb
    Date:   Mon May 18 18:23:13 2020 +0200
    tdf#125538 fix background of zoom control

Change-Id: I7c351796b2c0778c1520fc8177d05567b2ae8a48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116982
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Update git submodules

* Update helpcontent2 from branch 'master'
  to e5ac483bab252537ccbd087e6a133230cb8bae70
  - tdf#141474 tdf#124066 Basic keyword arguments explanations

    Change-Id: I9f05990a9c3513d171b7ae94e8d60e5d0d1ced2f
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116468
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

tdf#139658 OOXML: fix broken chart import at labels with quotes

During the import of the internal data table, incomplete
parsing of category labels with escaped quotation marks
resulted broken category labels and charts.

Change-Id: If5af3d527b80d1e055562f589bdaf17096ad49f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116714
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

tdf#140623 Chart OOXML import: set text overlap to false

of category axis label unless the rotation is 0 in xml.

Regression from commit: 21620f9d2f50e66dffc45a5afb539edb8d54434c
(tdf#138194 Chart OOXML import: set text break to true)

Change-Id: I18db7483f49c84a83760200037f8858a3b471994
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116575
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

loplugin:unnecessaryreturn FontTable::addEmbeddedFont

Change-Id: Ib64799f06ee1fbcc43132df6ad44975a0dff347e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116973
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

HAVE_FIREBIRD_30 is not used anymore

Change-Id: If318cd33356c0082a63cbd941cdfc753c9d800e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

fix firebird Cppunit targets

so

make CppunitTest_dbaccess_firebird_test
make CppunitTest_dbaccess_firebird_regression_test

work

which is presumably a problem since...

Commit 36befb3aca96907a14e71e82497dbb8f03ead5ab
Date: Sun Sep 23 19:40:59 2018 +0200

tdf#72987 split firebird test into a regression test and a "new" test

Change-Id: I3509364ba496c01c4a8a53674ec1c65495210274
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116969
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>