Version 7.0.0.0.beta1, tag libreoffice-7.0.0.0.beta1
bump product version to 7.0.0.0.beta1
Change-Id: Ia84d9ac9a25a3769e30cbdcb1e852e76527f5143
Change-Id: Ia84d9ac9a25a3769e30cbdcb1e852e76527f5143
Branch libreoffice-7-0
This is 'libreoffice-7-0' - the stable branch for the 7.0.x releases.
The commit rules are different according to the development phase:
A. 7.0.0 beta phase:
A. any bug fixes are allowed without review
B. late features need approval by 3 people with different affiliation
B. 7.0.0 rc phase and later:
A. fixes need approval by one reviewer
B. late features need approval by 3 more people with different affiliation
IMPORTANT: Every developer is responsible for pushing the fixes into all
appropriate branches. Note that we do not plan any merge
from this branch to master or vice versa.
Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.
This is 'libreoffice-7-0' - the stable branch for the 7.0.x releases.
The commit rules are different according to the development phase:
A. 7.0.0 beta phase:
A. any bug fixes are allowed without review
B. late features need approval by 3 people with different affiliation
B. 7.0.0 rc phase and later:
A. fixes need approval by one reviewer
B. late features need approval by 3 more people with different affiliation
IMPORTANT: Every developer is responsible for pushing the fixes into all
appropriate branches. Note that we do not plan any merge
from this branch to master or vice versa.
Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.
update list of [MS-LCID] from 3/4/2020 14.0 rev.
update list of [MS-LCID] from 3/4/2020 14.0 revision
see [MS-LCID]: Windows Language Code Identifier (LCID) Reference
Link: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f
Change-Id: I63c53915f0fb231def983bd80a10c31c55993004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94880
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
update list of [MS-LCID] from 3/4/2020 14.0 revision
see [MS-LCID]: Windows Language Code Identifier (LCID) Reference
Link: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f
Change-Id: I63c53915f0fb231def983bd80a10c31c55993004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94880
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Update git submodules
* Update translations from branch 'master'
to 13d55bb42d2f5617f568fd8b000e3d0c8bc4be6b
- update translations for 7.0.0 beta1
and force-fix errors using pocheck
Change-Id: I1adc224071cce4a7e0b21209890b3777f9e2539b
* Update translations from branch 'master'
to 13d55bb42d2f5617f568fd8b000e3d0c8bc4be6b
- update translations for 7.0.0 beta1
and force-fix errors using pocheck
Change-Id: I1adc224071cce4a7e0b21209890b3777f9e2539b
Use $PRODUCTNAME_WITHOUT_SPACES in app bundle name in help message for macOS
Don't mention $PRODUCTNAME at all in the message in general as it
might look confusing to newbie developers if it says "LibreOfficeDev".
On the other hand, hardcoding "LibreOffice" is misleading, too, if
what you are building is something not called LibreOffice.
Change-Id: Iee4949ea68bbaa542b577cc652b5241eaf4ac438
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94932
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Don't mention $PRODUCTNAME at all in the message in general as it
might look confusing to newbie developers if it says "LibreOfficeDev".
On the other hand, hardcoding "LibreOffice" is misleading, too, if
what you are building is something not called LibreOffice.
Change-Id: Iee4949ea68bbaa542b577cc652b5241eaf4ac438
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94932
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
tdf#78352: docx import: allow tab at left indent for list
Looks like first tab stop for list bullets is at left paragraph
boundry. Luckely there is a compatibility option for this.
Change-Id: Iea4bd2b51912746dbd4722ff61eeb2e9293cab31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94559
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Looks like first tab stop for list bullets is at left paragraph
boundry. Luckely there is a compatibility option for this.
Change-Id: Iea4bd2b51912746dbd4722ff61eeb2e9293cab31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94559
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
ofz#22588 Invalid-enum-value
Change-Id: Id632537856086490c3231879a81692e80edad4c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94934
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: Id632537856086490c3231879a81692e80edad4c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94934
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
tdf#131572 Add java 9 module info for unoloader.jar
Add a java module named "org.libreoffice.unoloader" for this jar.
Require this module from org.libreoffice.uno
(libreoffice.jar has unoloader.jar in its classpath,
so add the same dependency to the modules)
Change-Id: I7471d65ac7a0d2c6a11c002027a21f0c441dd1f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94419
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Add a java module named "org.libreoffice.unoloader" for this jar.
Require this module from org.libreoffice.uno
(libreoffice.jar has unoloader.jar in its classpath,
so add the same dependency to the modules)
Change-Id: I7471d65ac7a0d2c6a11c002027a21f0c441dd1f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94419
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
tdf#131572 Add java 9 module info for libreoffice.jar
Add a java module named "org.libreoffice.uno" for this jar.
This needs to be compiled with Java 9.
But since we want to keep b/c with Java 8,
the rest of the jar has to be compiled with Java 8.
This bumps the *build* requirement to Java 9 while keeping
the *runtime* requirement at Java 8.
The gbuild JavaClassSet class is changed to invoke javac twice,
where the 2nd invocation compiles with --release 9 and a --patch-modules
argument so that it finds the results of the first invocation and also
the javamaker generated files in CustomTargets.
Change-Id: I888f5dbe097cc37136e68db5919939877c981862
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91105
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Add a java module named "org.libreoffice.uno" for this jar.
This needs to be compiled with Java 9.
But since we want to keep b/c with Java 8,
the rest of the jar has to be compiled with Java 8.
This bumps the *build* requirement to Java 9 while keeping
the *runtime* requirement at Java 8.
The gbuild JavaClassSet class is changed to invoke javac twice,
where the 2nd invocation compiles with --release 9 and a --patch-modules
argument so that it finds the results of the first invocation and also
the javamaker generated files in CustomTargets.
Change-Id: I888f5dbe097cc37136e68db5919939877c981862
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91105
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
tdf#133426 Make mail merge progress dialog modal
This prevents doing things like trying to start another mail
merge for the same doc in parallel, thus crashing LibreOffice.
Change-Id: I5df2e804d97e82cccca4f0e297cb6d3396652882
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94933
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This prevents doing things like trying to start another mail
merge for the same doc in parallel, thus crashing LibreOffice.
Change-Id: I5df2e804d97e82cccca4f0e297cb6d3396652882
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94933
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
tdf#132594 Chart XLSX import: fix legend entries in pie charts
Legend entry text of pie chart wasn't imported correctly
in XLSX documents created with Excel 2007.
Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8
(tdf#128016 Chart OOXML Import: fix duplicated category labels)
Change-Id: I4567437a41fe66e124dccbd148c0c49196d5c007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94864
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Legend entry text of pie chart wasn't imported correctly
in XLSX documents created with Excel 2007.
Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8
(tdf#128016 Chart OOXML Import: fix duplicated category labels)
Change-Id: I4567437a41fe66e124dccbd148c0c49196d5c007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94864
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
WB_LISTBOX_POPUP is newly unused
Change-Id: I97a52499e1fda8a9426e6956e3e925e0572c41ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94886
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I97a52499e1fda8a9426e6956e3e925e0572c41ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94886
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Revert "bloaty: use -ffunction-sections and --gc-sections for linking"
This reverts commit bd39ec554f90badccfb26c843fd0d43237f1b622.
Reason for revert:
For -ffunction-sections and -fdata-sections, <https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Optimize-Options.html#Optimize-Options> warns: "Only use these options when there are significant benefits from doing so. When you specify these options, the assembler and linker create larger object and executable files and are also slower. These options affect code generation. They prevent optimizations by the compiler and assembler using relative locations inside a translation unit since the locations are unknown until link time. An example of such an optimization is relaxing calls to short call instructions."
Change-Id: I84225ca94de9afff23bdd2913c77095d5d26f7ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94950
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This reverts commit bd39ec554f90badccfb26c843fd0d43237f1b622.
Reason for revert:
For -ffunction-sections and -fdata-sections, <https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Optimize-Options.html#Optimize-Options> warns: "Only use these options when there are significant benefits from doing so. When you specify these options, the assembler and linker create larger object and executable files and are also slower. These options affect code generation. They prevent optimizations by the compiler and assembler using relative locations inside a translation unit since the locations are unknown until link time. An example of such an optimization is relaxing calls to short call instructions."
Change-Id: I84225ca94de9afff23bdd2913c77095d5d26f7ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94950
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
tdf#74244 Fix version info shown for major release candidates
Previous approach of setting the bundle version made e.g.,
6.4.0.3 show up as version 6.4.3 which was clearly wrong
CFBundleShortVersionString is supposed to be only three integers,
but this does not seem to be enforced by Apple.
Other applications, such as Spotiy, include even more than LO
Removed CFBundleGetInfoString as it's been deprecated since 10.5
Change-Id: I7c64553f6bc2712506062d8f8ec388f5279b333d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94623
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Previous approach of setting the bundle version made e.g.,
6.4.0.3 show up as version 6.4.3 which was clearly wrong
CFBundleShortVersionString is supposed to be only three integers,
but this does not seem to be enforced by Apple.
Other applications, such as Spotiy, include even more than LO
Removed CFBundleGetInfoString as it's been deprecated since 10.5
Change-Id: I7c64553f6bc2712506062d8f8ec388f5279b333d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94623
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
bloaty: use -ffunction-sections and --gc-sections for linking
strips out 3+ megabytes of duplicate functions (which originate in
the generated UNO header files)
Change-Id: I69ba5f478b2b062e2b05516bbaa2d18fa8312aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94868
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
strips out 3+ megabytes of duplicate functions (which originate in
the generated UNO header files)
Change-Id: I69ba5f478b2b062e2b05516bbaa2d18fa8312aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94868
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
tdf#133370 docx export: don't export unseen columnbreak
A compatibility option indicates whether a column break
is treated as a page break when there are no columns.
(Currently true only for DOCX). Don't export this column
break when compat is off, because it WILL show up as
a page-break in Word and LO when loaded.
In theory, the RTF and DOC code that converts these
into page-breaks on import could now be removed, but I
can't think of any reason why that would be of benefit.
testColumnBreak_ColumnCountIsZero in ooxmlexport4
covers the situation where docx MUST round-trip these.
Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
A compatibility option indicates whether a column break
is treated as a page break when there are no columns.
(Currently true only for DOCX). Don't export this column
break when compat is off, because it WILL show up as
a page-break in Word and LO when loaded.
In theory, the RTF and DOC code that converts these
into page-breaks on import could now be removed, but I
can't think of any reason why that would be of benefit.
testColumnBreak_ColumnCountIsZero in ooxmlexport4
covers the situation where docx MUST round-trip these.
Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Remove some unused includes
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Update git submodules
* Update helpcontent2 from branch 'master'
to cd96ed80cb27d31987cb878b379c3fa8c1dd0c03
- Added square brackets around applicable parameter in eight syntax statements (to indicate parameters are optional). All changes contained in one XHP file.
Change-Id: Ia4855d44b49f7d4198e8d644f5b53741b5083371
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94838
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to cd96ed80cb27d31987cb878b379c3fa8c1dd0c03
- Added square brackets around applicable parameter in eight syntax statements (to indicate parameters are optional). All changes contained in one XHP file.
Change-Id: Ia4855d44b49f7d4198e8d644f5b53741b5083371
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94838
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr
...where the get member function is defined on a std::__shared_ptr base class,
so loplugin:simplifypointertobool used to miss those until now. (While e.g.
using libc++ on macOS found those cases.)
366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool"
was mistaken in breaking isSmartPointerType(const clang::Type* t) out of
isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix
detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had
introduced that indivisible two-step algorithm on purpose.
The amount of additional hits (on Linux) apparently asked for turning
loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed
that the naive adivce to just "drop the get()" is not sufficient in places that
are not contextually converted to bool, as those places need to be wrapped in a
bool(...) functional cast now. If the expression was already wrapped in
parentheses, those could be reused as part of the functional cast, but
implementing that showed that such cases are not yet found at all by the
existing loplugin:simplifypointertobool. Lets leave that TODO for another
commit.
Besides the changes to compilerplugins/ itself, this change has been generated
fully automatically with the rewriting plugin on Linux.
Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
...where the get member function is defined on a std::__shared_ptr base class,
so loplugin:simplifypointertobool used to miss those until now. (While e.g.
using libc++ on macOS found those cases.)
366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool"
was mistaken in breaking isSmartPointerType(const clang::Type* t) out of
isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix
detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had
introduced that indivisible two-step algorithm on purpose.
The amount of additional hits (on Linux) apparently asked for turning
loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed
that the naive adivce to just "drop the get()" is not sufficient in places that
are not contextually converted to bool, as those places need to be wrapped in a
bool(...) functional cast now. If the expression was already wrapped in
parentheses, those could be reused as part of the functional cast, but
implementing that showed that such cases are not yet found at all by the
existing loplugin:simplifypointertobool. Lets leave that TODO for another
commit.
Besides the changes to compilerplugins/ itself, this change has been generated
fully automatically with the rewriting plugin on Linux.
Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Update git submodules
* Update helpcontent2 from branch 'master'
to 190b78fd2add6bb8468cd69f3d6a7bcccd692fef
- Add square brackets around final two parameters in syntax statement (to indicate parameters are optional)
Change-Id: Icbe4f4d834244dc8bb397b0eb5fa5df5d543ddbb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94840
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 190b78fd2add6bb8468cd69f3d6a7bcccd692fef
- Add square brackets around final two parameters in syntax statement (to indicate parameters are optional)
Change-Id: Icbe4f4d834244dc8bb397b0eb5fa5df5d543ddbb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94840
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to f9285f35a17dbdc69b0412cc73e4816906f85d9d
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I9703c7e556009613e377324b30a2a15accd33f5d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94839
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to f9285f35a17dbdc69b0412cc73e4816906f85d9d
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I9703c7e556009613e377324b30a2a15accd33f5d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94839
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to 1e6411ced00a5459e70a5f27651f2c55595ea9c5
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I9c60cc607f157114da48e5369866adf68394dcf4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94837
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 1e6411ced00a5459e70a5f27651f2c55595ea9c5
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I9c60cc607f157114da48e5369866adf68394dcf4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94837
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to 3dbc5d6b39165002e1de2f3ba6d99d6d7d9a5dd4
- tdf#126813 Fix scrolling of targeted references
Change-Id: Ic7ce644cc0a5053905e980952ad31767fa87125c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94885
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 3dbc5d6b39165002e1de2f3ba6d99d6d7d9a5dd4
- tdf#126813 Fix scrolling of targeted references
Change-Id: Ic7ce644cc0a5053905e980952ad31767fa87125c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94885
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
make highlight of get_dest_row_at_pos optional
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
emit activate-row in vcl treeview on return
to align it with the gtk one which does this
Change-Id: Id439fe684f263f59285ba9291fc803f88309c066
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94875
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
to align it with the gtk one which does this
Change-Id: Id439fe684f263f59285ba9291fc803f88309c066
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94875
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Update git submodules
* Update helpcontent2 from branch 'master'
to 695cea8d8ed485a8c32f9ccb67e2a182159a6734
- Remove unused CSS class
Change-Id: I9db4df3062c411570a77686ec2b4fe3124f71539
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94879
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 695cea8d8ed485a8c32f9ccb67e2a182159a6734
- Remove unused CSS class
Change-Id: I9db4df3062c411570a77686ec2b4fe3124f71539
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94879
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to a736b5e008fad1d0c05c961669cb62e1876218b9
- Add square brackets around final two parameters in syntax statement (to indicate parametes are optional)
Change-Id: I756376f90b8c9f51875ad1887142a82c6595daed
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94836
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to a736b5e008fad1d0c05c961669cb62e1876218b9
- Add square brackets around final two parameters in syntax statement (to indicate parametes are optional)
Change-Id: I756376f90b8c9f51875ad1887142a82c6595daed
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94836
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Don't run CompilerTest_o3tl_* with COMPILER_PLUGIN_TOOL=...
...similar to 2228203a8211dea1c8addb98298096a094ec788b "Don't run
CompilerTest_compilerplugins_clang with COMPILER_PLUGIN_TOOL=...", as otherwise
e.g., `make check COMPILER_PLUGIN_TOOL=fakebool` failed with
> o3tl/qa/compile-temporary.cxx:22:8: error: call to deleted function 'temporary'
> f(&o3tl::temporary(n)); // expected-error {{}} expected-note@o3tl/temporary.hxx:* 0+ {{}}
> ^~~~~~~~~~~~~~~
> include/o3tl/temporary.hxx:22:36: note: candidate function [with T = int] has been explicitly deleted
> template <typename T> constexpr T& temporary(T&) = delete;
> ^
> include/o3tl/temporary.hxx:21:36: note: candidate function [with T = int &]
> template <typename T> constexpr T& temporary(T&& x) { return x; }
> ^
Change-Id: I4dfa433708c064413f365375c84b85ced63c8d4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94871
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...similar to 2228203a8211dea1c8addb98298096a094ec788b "Don't run
CompilerTest_compilerplugins_clang with COMPILER_PLUGIN_TOOL=...", as otherwise
e.g., `make check COMPILER_PLUGIN_TOOL=fakebool` failed with
> o3tl/qa/compile-temporary.cxx:22:8: error: call to deleted function 'temporary'
> f(&o3tl::temporary(n)); // expected-error {{}} expected-note@o3tl/temporary.hxx:* 0+ {{}}
> ^~~~~~~~~~~~~~~
> include/o3tl/temporary.hxx:22:36: note: candidate function [with T = int] has been explicitly deleted
> template <typename T> constexpr T& temporary(T&) = delete;
> ^
> include/o3tl/temporary.hxx:21:36: note: candidate function [with T = int &]
> template <typename T> constexpr T& temporary(T&& x) { return x; }
> ^
Change-Id: I4dfa433708c064413f365375c84b85ced63c8d4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94871
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Drop -I$(dir $(2)) also from gb_*Object__tool_command
...after ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 "-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed" and
f218f8f6c8c587d2d78679f935093329f145fede "-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed" had already dropped it from
plain gb_CObject__command_pattern. (0349c738da5970d9f0fc10d7cf4d7b766ce10e13
"support for compiler rewriters" had created gb_*Object__tool_command at a time
when plain gb_*Object__command still contained those -I arguments, so had
presumably just copied them over without a specific additional need to have them
in the tool_command variants; and ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 and
f218f8f6c8c587d2d78679f935093329f145fede then just failed to also remove them
from the tool_command variants.)
Presence of the -I arguments in the tool_command variants caused e.g. `make
COMPILER_PLUGIN_TOOL=fakebool` to fail with
> sw/source/filter/ww8/ww8par.cxx:97:10: error: replace <...> include form with "..." for inclusion of a source file next to the current source file, sw/source/filter/ww8/../../core/inc/DocumentRedlineManager.hxx [loplugin:includeform]
> #include <../../core/inc/DocumentRedlineManager.hxx>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I7ef513507375dcee5d88db53cef58433f7f68e36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94867
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...after ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 "-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed" and
f218f8f6c8c587d2d78679f935093329f145fede "-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed" had already dropped it from
plain gb_CObject__command_pattern. (0349c738da5970d9f0fc10d7cf4d7b766ce10e13
"support for compiler rewriters" had created gb_*Object__tool_command at a time
when plain gb_*Object__command still contained those -I arguments, so had
presumably just copied them over without a specific additional need to have them
in the tool_command variants; and ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 and
f218f8f6c8c587d2d78679f935093329f145fede then just failed to also remove them
from the tool_command variants.)
Presence of the -I arguments in the tool_command variants caused e.g. `make
COMPILER_PLUGIN_TOOL=fakebool` to fail with
> sw/source/filter/ww8/ww8par.cxx:97:10: error: replace <...> include form with "..." for inclusion of a source file next to the current source file, sw/source/filter/ww8/../../core/inc/DocumentRedlineManager.hxx [loplugin:includeform]
> #include <../../core/inc/DocumentRedlineManager.hxx>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I7ef513507375dcee5d88db53cef58433f7f68e36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94867
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
tdf#133216 - Objects are not printed (Win-only)
Seem to have been introduced in commit 6fa6704a7e7c6970b7a7c:6
"vcl: move functionality out of checkRect(), rendering function obsolete"
This reverts:
commit 7b47a96b20122863e77aa1918e878372b3485c9f.
"vcl: refactor code into GenerateConnectedComponents()"
commit 5ef0f7dfafd8b83818c831914467f93e47a5bb2f.
"vcl: refactor code into GenerateIntersectingConnectedComponents()"
commit 93649784ddbb7d9ca779d14fd60fb97385325d17.
"vcl: move stage 1 functionality into DetectBackground()"
commit 34a699f1894f30f68c3243784586617e01e60ab6.
"vcl: refactor by creating GetActionAfterBackgroundAction() function"
commit f85769f61b2d2380750be564c6de47f28be35b8a.
"vcl: refactor by creating RecordMapModeChanges() function"
commit 8318a636336dd6d6b5862a3366f85f96c64d8243.
"vcl: refactor by creating SetBackgroundColorAndBounds() function"
commit f0ca5a0c447f4fe4667693d744af61eaeb0625ee.
"vcl: move functionality into FindIncompletelyOccludedBackground()"
commit 449f23c44ccdf6d2bfe7baa143d32d8f585aef4b.
"vcl: new local function setComponentsSizeAndColor()"
commit 6fa6704a7e7c6970b7a7c695a4a548f8dc693d03.
"vcl: move functionality out of checkRect(), rendering function obsolete"
Change-Id: Ic85397c1b69f2b529cff90206387d017692cecf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94804
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Seem to have been introduced in commit 6fa6704a7e7c6970b7a7c:6
"vcl: move functionality out of checkRect(), rendering function obsolete"
This reverts:
commit 7b47a96b20122863e77aa1918e878372b3485c9f.
"vcl: refactor code into GenerateConnectedComponents()"
commit 5ef0f7dfafd8b83818c831914467f93e47a5bb2f.
"vcl: refactor code into GenerateIntersectingConnectedComponents()"
commit 93649784ddbb7d9ca779d14fd60fb97385325d17.
"vcl: move stage 1 functionality into DetectBackground()"
commit 34a699f1894f30f68c3243784586617e01e60ab6.
"vcl: refactor by creating GetActionAfterBackgroundAction() function"
commit f85769f61b2d2380750be564c6de47f28be35b8a.
"vcl: refactor by creating RecordMapModeChanges() function"
commit 8318a636336dd6d6b5862a3366f85f96c64d8243.
"vcl: refactor by creating SetBackgroundColorAndBounds() function"
commit f0ca5a0c447f4fe4667693d744af61eaeb0625ee.
"vcl: move functionality into FindIncompletelyOccludedBackground()"
commit 449f23c44ccdf6d2bfe7baa143d32d8f585aef4b.
"vcl: new local function setComponentsSizeAndColor()"
commit 6fa6704a7e7c6970b7a7c695a4a548f8dc693d03.
"vcl: move functionality out of checkRect(), rendering function obsolete"
Change-Id: Ic85397c1b69f2b529cff90206387d017692cecf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94804
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
oox smartart import: fix aspect ratio of shape with composite algo
The layout node has alg=composite, then a parTx and a desTx child layout
nodes. No matter what order is used (parent first, child first), the
result will be wrong, as the constraints refer to each other. I did not
spot any description in ISO 29500-1 that would describe what is the
expected behavior.
Researching this, found "One other consideration when specifying
composite constraints is that the constraints must be specified in the
same order as the nested layout nodes." at
<http://web.archive.org/web/20111015151600/http://msdn.microsoft.com/en-us/magazine/cc163470.aspx>,
which suggests to handle constraints for each shape in a parent -> child
order, but keep a shared state when iterating over the children which
gives us:
- parent node, all direct constraints
- for each child node:
- child's constraints from parent
- child's own constraints
This way the desTx top value can depend on the parTx's height, and it's
supported to define parTx's height only in the parTx layout node, not in
the composite parent.
And after all, it matches what PowerPoint does, so the column headings
in the bugdoc have a 4:10 height:width aspect ratio.
Change-Id: Ideb76c1ddd1ffff8d2a217cddf81106d1bb97eb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94872
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The layout node has alg=composite, then a parTx and a desTx child layout
nodes. No matter what order is used (parent first, child first), the
result will be wrong, as the constraints refer to each other. I did not
spot any description in ISO 29500-1 that would describe what is the
expected behavior.
Researching this, found "One other consideration when specifying
composite constraints is that the constraints must be specified in the
same order as the nested layout nodes." at
<http://web.archive.org/web/20111015151600/http://msdn.microsoft.com/en-us/magazine/cc163470.aspx>,
which suggests to handle constraints for each shape in a parent -> child
order, but keep a shared state when iterating over the children which
gives us:
- parent node, all direct constraints
- for each child node:
- child's constraints from parent
- child's own constraints
This way the desTx top value can depend on the parTx's height, and it's
supported to define parTx's height only in the parTx layout node, not in
the composite parent.
And after all, it matches what PowerPoint does, so the column headings
in the bugdoc have a 4:10 height:width aspect ratio.
Change-Id: Ideb76c1ddd1ffff8d2a217cddf81106d1bb97eb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94872
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
tdf#133094 NotebookbarToolBox is not in the sidebar
though it is inheriting from SidebarToolBox and we're distinguish the sidebar
case from the non-sidebar case wrt certain color toolbuttons
Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
though it is inheriting from SidebarToolBox and we're distinguish the sidebar
case from the non-sidebar case wrt certain color toolbuttons
Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
make disabling of Skia override forcing it (tdf#133399)
Makes more sense if it's disabled because the VCL backend doesn't
actually support Skia.
Change-Id: I3f14c6ae1172c0a2cba3bf19c4cb5288e214eb2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94861
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Makes more sense if it's disabled because the VCL backend doesn't
actually support Skia.
Change-Id: I3f14c6ae1172c0a2cba3bf19c4cb5288e214eb2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94861
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
weld SwFieldListBox
Change-Id: I205ce5b300d869d6424c3552a2799c3b02282ff7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94810
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I205ce5b300d869d6424c3552a2799c3b02282ff7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94810
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
followed the advice from Mike at https://gerrit.libreoffice.org/c/core/+/94687
Change-Id: If961da88f3ecba03416394ab8e8093af1b20f664
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94832
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: If961da88f3ecba03416394ab8e8093af1b20f664
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94832
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
reduce dynamic_cast usage in an O(N^2) algorithm
When scrolling down in tdf#130431 this is the major CPU cost.
Move the dynamic_cast out of the loops as much as possible.
Change-Id: I0ea9f457bb17fbdde880f09b059f07dec4b1790b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94858
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
When scrolling down in tdf#130431 this is the major CPU cost.
Move the dynamic_cast out of the loops as much as possible.
Change-Id: I0ea9f457bb17fbdde880f09b059f07dec4b1790b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94858
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
use Skia to do dashed lines, no need to do it manually (tdf#130431)
Change-Id: Id5efe7227f3c2bcb5ef6f1b990327e72014e8c47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94857
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Change-Id: Id5efe7227f3c2bcb5ef6f1b990327e72014e8c47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94857
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
jenkins linux configs: use jdk 11 for master
mac uses /usr/libexec/java_home to determine jdk and without -v option
to limit to a specific version returns latest one
Change-Id: I8c8122ed71a31f990c3ffa1e71b180cbece7f172
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94862
Tested-by: Jenkins
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
mac uses /usr/libexec/java_home to determine jdk and without -v option
to limit to a specific version returns latest one
Change-Id: I8c8122ed71a31f990c3ffa1e71b180cbece7f172
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94862
Tested-by: Jenkins
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
uitest: replace sleep with processEventsToIdle
Change-Id: I48798e98718cae11b9ef7902cb48fe2d8ab9c2b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94812
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Change-Id: I48798e98718cae11b9ef7902cb48fe2d8ab9c2b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94812
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to 52d629e6d5d3599cdead037425021c288b224278
- Add square brackets around final parameter in syntax definition (to indicate that the parameter is optional)
Change-Id: If2e6489a28c7429b8c638c9bcdc6cc28ff3d8078
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94834
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 52d629e6d5d3599cdead037425021c288b224278
- Add square brackets around final parameter in syntax definition (to indicate that the parameter is optional)
Change-Id: If2e6489a28c7429b8c638c9bcdc6cc28ff3d8078
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94834
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Update git submodules
* Update helpcontent2 from branch 'master'
to 0e5f1058e25d21ea590e3fbfc6c87e925b791fc5
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I6ef58dab8926eb739b7477493ce228e43606124c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94833
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 0e5f1058e25d21ea590e3fbfc6c87e925b791fc5
- Add square brackets around final parameter in syntax statement (to indicate parameter is optional)
Change-Id: I6ef58dab8926eb739b7477493ce228e43606124c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94833
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
-Werror,-Wunused-private-field
...since b9353394f46e46485fd148f2842f0c1e8e5322e3 "[MS-OFFCRYPTO] convert oox
implementation into UNO service"
Change-Id: I0f226858ef9a1195fb26c1afe6c904d7cef6f541
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94813
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...since b9353394f46e46485fd148f2842f0c1e8e5322e3 "[MS-OFFCRYPTO] convert oox
implementation into UNO service"
Change-Id: I0f226858ef9a1195fb26c1afe6c904d7cef6f541
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94813
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
tdf#49247, tdf#101181: gtk needs "upper", otherwise the control is disabled
Change-Id: I3a3204ab0ad2376ee88adca5935813e241e6a049
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94831
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I3a3204ab0ad2376ee88adca5935813e241e6a049
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94831
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Revert "Resolves tdf#133265 - Save state indicator must not be hidden"
This reverts commit 194538345691272bf9d7c642f069cc1061a0b4d9, as it is suspected
of causing massive Jenkins JunitTest_toolkit_unoapi_1
toolkit.AccessibleStatusBarItem::com::sun::star::accessibility::XAccessibleText
::getIndexAtPoint() failures.
Change-Id: I1c13ecd660f6694edb3e164fca372962b0ccdd19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94827
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This reverts commit 194538345691272bf9d7c642f069cc1061a0b4d9, as it is suspected
of causing massive Jenkins JunitTest_toolkit_unoapi_1
toolkit.AccessibleStatusBarItem::com::sun::star::accessibility::XAccessibleText
::getIndexAtPoint() failures.
Change-Id: I1c13ecd660f6694edb3e164fca372962b0ccdd19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94827
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Update git submodules
* Update helpcontent2 from branch 'master'
to 55480f9f761aac470b97326ab13b5444cc57cb74
- Translating these is not worth it
In the vein of commit 8bece13f73046ebebfb5c18d02d857a961a4cdab.
Change-Id: I5273298a55cd13e5954c6e5a727feb58ac6ec831
* Update helpcontent2 from branch 'master'
to 55480f9f761aac470b97326ab13b5444cc57cb74
- Translating these is not worth it
In the vein of commit 8bece13f73046ebebfb5c18d02d857a961a4cdab.
Change-Id: I5273298a55cd13e5954c6e5a727feb58ac6ec831
Fix typo
Change-Id: I44b332e840a5e3084c0c16fe05f0918e42217c13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94821
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Change-Id: I44b332e840a5e3084c0c16fe05f0918e42217c13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94821
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Update git submodules
* Update helpcontent2 from branch 'master'
to 8444c2c1af48ac5f7f4fd9555bae695c88b682bc
- document new ODF 1.3 versions in Tools->Options->Load/Save
Change-Id: I40a7f06274d311a537b8290cec4d7708c4c4ea4d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94705
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Update helpcontent2 from branch 'master'
to 8444c2c1af48ac5f7f4fd9555bae695c88b682bc
- document new ODF 1.3 versions in Tools->Options->Load/Save
Change-Id: I40a7f06274d311a537b8290cec4d7708c4c4ea4d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94705
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
cfg.cxx build fix
Change-Id: I7bab3dc64f0976b3d3e8711a05ea826243a6be67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94687
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I7bab3dc64f0976b3d3e8711a05ea826243a6be67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94687
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
tdf#131715: uitest: add wrapper for roadmapwizard
Change-Id: I8e8999b7862ad13cb6d3328e05abe120da3ed5c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94759
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Change-Id: I8e8999b7862ad13cb6d3328e05abe120da3ed5c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94759
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
use -Xclang -debug-info-kind=constructor if available
The option, available since Clang10, emits debuginfo for classes
with explicit ctors only together with the ctor, which avoids
redundant debuginfo for such classes, noticeably saving both build
time and disk space. https://reviews.llvm.org/D72427
I've been using this for quite some time, without problems.
Change-Id: I24e5339f983cb8d8990185436dd63e00f0d3ce60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94756
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The option, available since Clang10, emits debuginfo for classes
with explicit ctors only together with the ctor, which avoids
redundant debuginfo for such classes, noticeably saving both build
time and disk space. https://reviews.llvm.org/D72427
I've been using this for quite some time, without problems.
Change-Id: I24e5339f983cb8d8990185436dd63e00f0d3ce60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94756
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
tdf#130456 sw: enable semi-transparent text for char style dialog
The code is shared, so this fixed the para style dialog as well.
Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The code is shared, so this fixed the para style dialog as well.
Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Add an option to create encyrpted PDF files with mailmerge.
With that option user can create encyrpted pdf files with
a password column in database via mailmerge.
Change-Id: I081ef050bc269b1fec24fd01ecc812acd7b857ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94709
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
With that option user can create encyrpted pdf files with
a password column in database via mailmerge.
Change-Id: I081ef050bc269b1fec24fd01ecc812acd7b857ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94709
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
tdf#133030: DOCX export: fix formula alignment - part 3
Follow-up of commit 1237acf9851f8b12d1ccd929e2aa8b184c06d552
(tdf#132811 DOCX: fix formula alignment – part 2)
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I5466649a2aa6b7ffdb0def723f79dfbecdf1495f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93665
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Follow-up of commit 1237acf9851f8b12d1ccd929e2aa8b184c06d552
(tdf#132811 DOCX: fix formula alignment – part 2)
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I5466649a2aa6b7ffdb0def723f79dfbecdf1495f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93665
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
tdf#106181 XLSX export: output form controls
Prepared general algorithm to ouput form controls into XLSX.
For now only CHECKBOX is supported with a possibility to
link withem to any worksheet/cell.
Change-Id: Ide8739d81ffb755aeae074c4ebecf24251383e34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94161
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Prepared general algorithm to ouput form controls into XLSX.
For now only CHECKBOX is supported with a possibility to
link withem to any worksheet/cell.
Change-Id: Ide8739d81ffb755aeae074c4ebecf24251383e34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94161
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Remapping NatNum-DBNum in Korean for compatibility tdf#130193
Remapping NatNum-DBNum in Korean for compatibility tdf#130193
Unlike Japanese and Chinese[Simplified, Traditional] environment on Excel, In Korean Situation, Excel exist DBNum1~4.
I checked DBNum1~4 series on Excel 2016 in Korean Environment.
DBNum1 1234567890 一十二億三千四百五十六万七千八百九十
DBNum2 1234567890 壹拾貳億參阡四百伍拾六萬七阡八百九拾
DBNum3 1234567890 十２億３千４百５十６万７千８百９十
DBNum4 1234567890 일십이억삼천사백오십육만칠천팔백구십
Also, I checked Korean Number to Strings on LibreOffice.
[natnum1] 1234567890 一二三四五六七八九〇
[natnum2] 1234567890 壹貳參四伍六七八九零
[natnum3] 1234567890 １２３４５６７８９０
[natnum4] 1234567890 一十二億三千四百五十六万七千八百九十
[natnum5] 1234567890 壹拾貳億參阡四佰伍拾六萬七阡八佰九拾
[natnum6] 1234567890 １십２억３천４백５십６만７천８백９십
[natnum7] 1234567890 十二億三千四百五十六万七千八百九十
[natnum8] 1234567890 拾貳億參阡四佰伍拾六萬七阡八佰九拾
[natnum9] 1234567890 일이삼사오육칠팔구영
[natnum10] 1234567890 일십이억삼천사백오십육만칠천팔백구십
[natnum11] 1234567890 십이억삼천사백오십육만칠천팔백구십
I also checked Korean billion units test.
[natnum1] 123456789012 一二三四五六七八九〇一二
[natnum2] 123456789012 壹貳參四五六七八九零壹貳
[natnum3] 123456789012 １２３４５６７８９０１２
[natnum4] 123456789012 一千二百三十四億五千六百七十八万九千一十二
[natnum5] 123456789012 壹仟貳佰參拾四億五仟六佰七拾八萬九仟壹拾貳
[natnum6] 123456789012 １천２백３십４억５천６백７십８만９천１십２
[natnum7] 123456789012 千二百三十四億五千六百七十八万九千十二
[natnum8] 123456789012 仟貳佰參拾四億五仟六佰七拾八萬九仟拾貳
[natnum9] 123456789012 일이삼사오육칠팔구영일이
[natnum10] 123456789012 일천이백삼십사억오천육백칠십팔만구천일십이
[natnum11] 123456789012 천이백삼십사억오천육백칠십팔만구천십이
As a result,
1. from DBNum to NatNum (import):
- DBNum1 -> NatNum4 (Korean Hanja text 한자숫자)
- DBNum2 -> NatNum5 (Korean Upper Hanja text 갖은자)
- DBNum3 -> NatNum6 (fullwidth Arabic digits with Korean hanja unit of Numbering)
- DBNum4 -> NatNum10 (Korean Hangul text)
I found the Bug for NatNum6 (I'll change Korean Hangul to Hanja for compatibility)
2. From NatNum to DBNum
- NatNum1 -> DBNum1
- NatNum2 -> DBNum2
- NatNum3 -> DBNum3
- NatNum4 -> DBNum1
- NatNum5 -> DBNum2
- NatNum6 -> DBNum3
- NatNum7 -> DBNum1
- NatNum8 -> DBNum2
- NatNum9 -> DBNum4
- NatNum10 -> DBNum4
- NatNum11 -> DBNum4
By the way, I change test cases for Korean.
It is included in svl/qa/unit/svl.cxx
It solves the issue tdf#130140
Also, It related the issue tdf#130077
Change-Id: Idb7f3defc5f19e3edc4c179b0a081d2abe8ee3a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94747
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Remapping NatNum-DBNum in Korean for compatibility tdf#130193
Unlike Japanese and Chinese[Simplified, Traditional] environment on Excel, In Korean Situation, Excel exist DBNum1~4.
I checked DBNum1~4 series on Excel 2016 in Korean Environment.
DBNum1 1234567890 一十二億三千四百五十六万七千八百九十
DBNum2 1234567890 壹拾貳億參阡四百伍拾六萬七阡八百九拾
DBNum3 1234567890 十２億３千４百５十６万７千８百９十
DBNum4 1234567890 일십이억삼천사백오십육만칠천팔백구십
Also, I checked Korean Number to Strings on LibreOffice.
[natnum1] 1234567890 一二三四五六七八九〇
[natnum2] 1234567890 壹貳參四伍六七八九零
[natnum3] 1234567890 １２３４５６７８９０
[natnum4] 1234567890 一十二億三千四百五十六万七千八百九十
[natnum5] 1234567890 壹拾貳億參阡四佰伍拾六萬七阡八佰九拾
[natnum6] 1234567890 １십２억３천４백５십６만７천８백９십
[natnum7] 1234567890 十二億三千四百五十六万七千八百九十
[natnum8] 1234567890 拾貳億參阡四佰伍拾六萬七阡八佰九拾
[natnum9] 1234567890 일이삼사오육칠팔구영
[natnum10] 1234567890 일십이억삼천사백오십육만칠천팔백구십
[natnum11] 1234567890 십이억삼천사백오십육만칠천팔백구십
I also checked Korean billion units test.
[natnum1] 123456789012 一二三四五六七八九〇一二
[natnum2] 123456789012 壹貳參四五六七八九零壹貳
[natnum3] 123456789012 １２３４５６７８９０１２
[natnum4] 123456789012 一千二百三十四億五千六百七十八万九千一十二
[natnum5] 123456789012 壹仟貳佰參拾四億五仟六佰七拾八萬九仟壹拾貳
[natnum6] 123456789012 １천２백３십４억５천６백７십８만９천１십２
[natnum7] 123456789012 千二百三十四億五千六百七十八万九千十二
[natnum8] 123456789012 仟貳佰參拾四億五仟六佰七拾八萬九仟拾貳
[natnum9] 123456789012 일이삼사오육칠팔구영일이
[natnum10] 123456789012 일천이백삼십사억오천육백칠십팔만구천일십이
[natnum11] 123456789012 천이백삼십사억오천육백칠십팔만구천십이
As a result,
1. from DBNum to NatNum (import):
- DBNum1 -> NatNum4 (Korean Hanja text 한자숫자)
- DBNum2 -> NatNum5 (Korean Upper Hanja text 갖은자)
- DBNum3 -> NatNum6 (fullwidth Arabic digits with Korean hanja unit of Numbering)
- DBNum4 -> NatNum10 (Korean Hangul text)
I found the Bug for NatNum6 (I'll change Korean Hangul to Hanja for compatibility)
2. From NatNum to DBNum
- NatNum1 -> DBNum1
- NatNum2 -> DBNum2
- NatNum3 -> DBNum3
- NatNum4 -> DBNum1
- NatNum5 -> DBNum2
- NatNum6 -> DBNum3
- NatNum7 -> DBNum1
- NatNum8 -> DBNum2
- NatNum9 -> DBNum4
- NatNum10 -> DBNum4
- NatNum11 -> DBNum4
By the way, I change test cases for Korean.
It is included in svl/qa/unit/svl.cxx
It solves the issue tdf#130140
Also, It related the issue tdf#130077
Change-Id: Idb7f3defc5f19e3edc4c179b0a081d2abe8ee3a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94747
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
tdf#130193: Asian Excel-Calc number format interop
remap NatNum - DBNum in Japanese/Chinese to improve
Excel interoprability
from DBNum to NatNum (import) in ja/zh:
- DBNum1 -> NatNum4 (modern long Kanji text)
- DBNum2 -> NatNum5 (traditional long Kanji text)
- DBNum3 -> NatNum3 (fullwidth Arabic digits)
from NatNum to DBNum (export) in ja:
- NatNum1 -> DBNum1
- NatNum2 -> DBNum2
- NatNum3 -> DBNum3
- NatNum4 -> DBNum1
- NatNum5 -> DBNum2
- NatNum6 -> DBNum3
- NatNum7 -> DBNum1
- NatNum8 -> DBNum2
- NatNum9 -> (DBNum0, as Arabic)
in zh, nothing change about export.
It also partially solves the issue tdf#130140
(about Japanese, not Korean)
To do this, more data-drivened MapDBNumToNatNum() and
MapNatNumToDBNum() in svl/source/numbers/zformat.cxx
By mapping "NatNum - DBNum" to a table using map and array, it
makes the specification for each language more understandable
The new test cases are also included in svl/qa/unit/svl.cxx
Change-Id: I34a70d970ef2e46c1b3db5db1c397ab89c056191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94376
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
remap NatNum - DBNum in Japanese/Chinese to improve
Excel interoprability
from DBNum to NatNum (import) in ja/zh:
- DBNum1 -> NatNum4 (modern long Kanji text)
- DBNum2 -> NatNum5 (traditional long Kanji text)
- DBNum3 -> NatNum3 (fullwidth Arabic digits)
from NatNum to DBNum (export) in ja:
- NatNum1 -> DBNum1
- NatNum2 -> DBNum2
- NatNum3 -> DBNum3
- NatNum4 -> DBNum1
- NatNum5 -> DBNum2
- NatNum6 -> DBNum3
- NatNum7 -> DBNum1
- NatNum8 -> DBNum2
- NatNum9 -> (DBNum0, as Arabic)
in zh, nothing change about export.
It also partially solves the issue tdf#130140
(about Japanese, not Korean)
To do this, more data-drivened MapDBNumToNatNum() and
MapNatNumToDBNum() in svl/source/numbers/zformat.cxx
By mapping "NatNum - DBNum" to a table using map and array, it
makes the specification for each language more understandable
The new test cases are also included in svl/qa/unit/svl.cxx
Change-Id: I34a70d970ef2e46c1b3db5db1c397ab89c056191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94376
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
tdf#133342 Add user defined percent string
With Add/Delete decimal place, insert percent char
and string text between number and '%'
Change-Id: I4a97e4361228020803810692d7977e5806baf180
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94757
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
With Add/Delete decimal place, insert percent char
and string text between number and '%'
Change-Id: I4a97e4361228020803810692d7977e5806baf180
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94757
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
UITest_writer_tests4: fix this under high load
The failure I had:
======================================================================
FAIL: test_tdf113284 (tdf113284.tdf113284)
----------------------------------------------------------------------
Traceback (most recent call last):
File "sw/qa/uitest/writer_tests4/tdf113284.py", line 34, in test_tdf113284
self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount))
AssertionError: '1' != '91'
- 1
+ 91
? +
And with this in place 'make check' passes just fine. I assume the go to
page dialog goes to the relevant page in an async way.
Change-Id: Ic4b2a755c589f113af58b5fb3e43f537a52a50d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94803
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The failure I had:
======================================================================
FAIL: test_tdf113284 (tdf113284.tdf113284)
----------------------------------------------------------------------
Traceback (most recent call last):
File "sw/qa/uitest/writer_tests4/tdf113284.py", line 34, in test_tdf113284
self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount))
AssertionError: '1' != '91'
- 1
+ 91
? +
And with this in place 'make check' passes just fine. I assume the go to
page dialog goes to the relevant page in an async way.
Change-Id: Ic4b2a755c589f113af58b5fb3e43f537a52a50d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94803
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Adapt to changed clang::ASTContext::getParents behavior on Clang 11 trunk
...since <https://github.com/llvm/llvm-project/commit/
d0da5d2bbe8305d06dc01a98706fd73e11e24a9f> "Change default traversal in AST
Matchers to ignore invisible nodes". This caused failures
> [CPT] compilerplugins/clang/test/constparams.cxx
> ParmVarDecl 0x11d76c730 <compilerplugins/clang/test/constparams.cxx:15:12, col:18> col:18 used f1 'int *'
> DeclRefExpr 0x11d76c948 'int *' lvalue ParmVar 0x11d76c730 'f1' 'int *'
> ParmVarDecl 0x11d76cc80 <compilerplugins/clang/test/constparams.cxx:21:12, col:18> col:18 used f2 'int *'
> DeclRefExpr 0x11d76ce60 'int *' lvalue ParmVar 0x11d76cc80 'f2' 'int *'
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/constparams.cxx Line 15: this parameter can be const Class1::Class1 [loplugin:constparams]
> error: 'error' diagnostics seen but not expected:
> File compilerplugins/clang/test/constparams.cxx Line 15: no parent? [loplugin:constparams]
> File compilerplugins/clang/test/constparams.cxx Line 21: no parent? [loplugin:constparams]
> 3 errors generated.
[...]
> [CPT] compilerplugins/clang/test/unusedenumconstants.cxx
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: read Bottom [loplugin:unusedenumconstants]
> error: 'error' diagnostics seen but not expected:
> File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: write Bottom [loplugin:unusedenumconstants]
> 2 errors generated.
[...]
> [CPT] compilerplugins/clang/test/unusedfields.cxx
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/unusedfields.cxx Line 156 (directive at compilerplugins/clang/test/unusedfields.cxx:164): write m_f5 [loplugin:unusedfields]
> File compilerplugins/clang/test/unusedfields.cxx Line 210 (directive at compilerplugins/clang/test/unusedfields.cxx:211): read m_f1 [loplugin:unusedfields]
> 2 errors generated.
For compilerplugins/clang/test/constparams.cxx at least it would have worked to
fix that locally with
> diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx
> index 95c8184009d7..70f056fa5a69 100644
> --- a/compilerplugins/clang/constparams.cxx
> +++ b/compilerplugins/clang/constparams.cxx
> @@ -274,7 +274,7 @@ bool ConstParams::checkIfCanBeConst(const Stmt* stmt, const ParmVarDecl* parmVar
> {
> for ( auto cxxCtorInitializer : cxxConstructorDecl->inits())
> {
> - if ( cxxCtorInitializer->getInit() == stmt)
> + if ( cxxCtorInitializer->getInit()->IgnoreImpCasts() == stmt)
> {
> if (cxxCtorInitializer->isAnyMemberInitializer())
> {
(somewhat unintuitively, given the Clang change is apparently about ignoring
more implicit nodes), but overall it appears better---at least for now---to use
a getParents variant that keeps the old traversal behavior.
For that, instead of using the clang::ASTContext::ParentMapCtx, we create our
own loplugin::Plugin::parentMapContext_. There appear to be no uses of
ASTContext::getParent across the Clang codebase itself, outside of ASTMatcher
code, so it looks unlikely that creating our own ParentMapContext instance would
degrade performance by no longer sharing cached data between Clang's internals
and our plugin. (And given that ASTContext::getParents is deprecated with the
note "New callers should use ParentMapContext::getParents() directly", this may
well be the correct way in the long run, anyway.)
Change-Id: I46c7912f2737e7c224fd45ab41441f69e2f10bd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94795
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...since <https://github.com/llvm/llvm-project/commit/
d0da5d2bbe8305d06dc01a98706fd73e11e24a9f> "Change default traversal in AST
Matchers to ignore invisible nodes". This caused failures
> [CPT] compilerplugins/clang/test/constparams.cxx
> ParmVarDecl 0x11d76c730 <compilerplugins/clang/test/constparams.cxx:15:12, col:18> col:18 used f1 'int *'
> DeclRefExpr 0x11d76c948 'int *' lvalue ParmVar 0x11d76c730 'f1' 'int *'
> ParmVarDecl 0x11d76cc80 <compilerplugins/clang/test/constparams.cxx:21:12, col:18> col:18 used f2 'int *'
> DeclRefExpr 0x11d76ce60 'int *' lvalue ParmVar 0x11d76cc80 'f2' 'int *'
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/constparams.cxx Line 15: this parameter can be const Class1::Class1 [loplugin:constparams]
> error: 'error' diagnostics seen but not expected:
> File compilerplugins/clang/test/constparams.cxx Line 15: no parent? [loplugin:constparams]
> File compilerplugins/clang/test/constparams.cxx Line 21: no parent? [loplugin:constparams]
> 3 errors generated.
[...]
> [CPT] compilerplugins/clang/test/unusedenumconstants.cxx
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: read Bottom [loplugin:unusedenumconstants]
> error: 'error' diagnostics seen but not expected:
> File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: write Bottom [loplugin:unusedenumconstants]
> 2 errors generated.
[...]
> [CPT] compilerplugins/clang/test/unusedfields.cxx
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/unusedfields.cxx Line 156 (directive at compilerplugins/clang/test/unusedfields.cxx:164): write m_f5 [loplugin:unusedfields]
> File compilerplugins/clang/test/unusedfields.cxx Line 210 (directive at compilerplugins/clang/test/unusedfields.cxx:211): read m_f1 [loplugin:unusedfields]
> 2 errors generated.
For compilerplugins/clang/test/constparams.cxx at least it would have worked to
fix that locally with
> diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx
> index 95c8184009d7..70f056fa5a69 100644
> --- a/compilerplugins/clang/constparams.cxx
> +++ b/compilerplugins/clang/constparams.cxx
> @@ -274,7 +274,7 @@ bool ConstParams::checkIfCanBeConst(const Stmt* stmt, const ParmVarDecl* parmVar
> {
> for ( auto cxxCtorInitializer : cxxConstructorDecl->inits())
> {
> - if ( cxxCtorInitializer->getInit() == stmt)
> + if ( cxxCtorInitializer->getInit()->IgnoreImpCasts() == stmt)
> {
> if (cxxCtorInitializer->isAnyMemberInitializer())
> {
(somewhat unintuitively, given the Clang change is apparently about ignoring
more implicit nodes), but overall it appears better---at least for now---to use
a getParents variant that keeps the old traversal behavior.
For that, instead of using the clang::ASTContext::ParentMapCtx, we create our
own loplugin::Plugin::parentMapContext_. There appear to be no uses of
ASTContext::getParent across the Clang codebase itself, outside of ASTMatcher
code, so it looks unlikely that creating our own ParentMapContext instance would
degrade performance by no longer sharing cached data between Clang's internals
and our plugin. (And given that ASTContext::getParents is deprecated with the
note "New callers should use ParentMapContext::getParents() directly", this may
well be the correct way in the long run, anyway.)
Change-Id: I46c7912f2737e7c224fd45ab41441f69e2f10bd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94795
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
weld ScFilterListBox
use the same positioning and sizing logic for
DataSelectMenu and ScenarioMenu
Change-Id: I34d183f72b6719528ce357b1fd40a1fdd1a4a29a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
use the same positioning and sizing logic for
DataSelectMenu and ScenarioMenu
Change-Id: I34d183f72b6719528ce357b1fd40a1fdd1a4a29a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
support activate-on-single-click
Change-Id: Iac0231b3bd84d664b1ab59023ef8242f3bd08940
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94773
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: Iac0231b3bd84d664b1ab59023ef8242f3bd08940
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94773
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Clean up dead code
...after 5bfa8b8d5e1cf3cb572dbd91bf3b0cfcf29fb65a "tdf#118314 Code clean up on
imestatuswindow" had removed the sole consumer of aText.
(It is unclear to me whether the use of StatusDrawCallback in the
SalI18N_InputContext in vcl/unx/generic/app/i18n_ic.cxx is still necessary when
StatusDrawCallback does not do anything. But StatusStartCallback and
StatusDoneCallback do not do anything, either, and are used exactly the same way
there, so lets keep all that, at least for now.)
Change-Id: Ic2a61819c6bb8ed192231ca309f03b6c29768f29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94760
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...after 5bfa8b8d5e1cf3cb572dbd91bf3b0cfcf29fb65a "tdf#118314 Code clean up on
imestatuswindow" had removed the sole consumer of aText.
(It is unclear to me whether the use of StatusDrawCallback in the
SalI18N_InputContext in vcl/unx/generic/app/i18n_ic.cxx is still necessary when
StatusDrawCallback does not do anything. But StatusStartCallback and
StatusDoneCallback do not do anything, either, and are used exactly the same way
there, so lets keep all that, at least for now.)
Change-Id: Ic2a61819c6bb8ed192231ca309f03b6c29768f29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94760
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Resolves tdf#133265 - Save state indicator must not be hidden
Document state indicator mandatory now
Change-Id: I719f8a97a867addcd6a544567b1173e6da0f7db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94780
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Document state indicator mandatory now
Change-Id: I719f8a97a867addcd6a544567b1173e6da0f7db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94780
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
NFC writerfilter: reorganize and re-use variables
My previous patch for tdf#133000 modified the
code flow a bit. I kept these "formatting" changes
separate so that they wouldn't interfere in understanding
the functional code changes (which is very important for
this extremely fragile numbering code).
In this patch, I relocate two lines to group them
with their logically similar counterpart
and the variables that control it.
I also got really confused by one of my earlier
code comments which seems to be completely wrong or
at best misleading, so I modified it to be what
I think is much more accurate.
Change-Id: I3ab0bbfab436f70f81adc4af6db4c5b6c9eca8b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94367
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
My previous patch for tdf#133000 modified the
code flow a bit. I kept these "formatting" changes
separate so that they wouldn't interfere in understanding
the functional code changes (which is very important for
this extremely fragile numbering code).
In this patch, I relocate two lines to group them
with their logically similar counterpart
and the variables that control it.
I also got really confused by one of my earlier
code comments which seems to be completely wrong or
at best misleading, so I modified it to be what
I think is much more accurate.
Change-Id: I3ab0bbfab436f70f81adc4af6db4c5b6c9eca8b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94367
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
if the scenario button is at the bottom of the range place the menu below it
and not over it
Change-Id: I7f6e803fccbac00a22cb049c428a09d07b29bf04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94772
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
and not over it
Change-Id: I7f6e803fccbac00a22cb049c428a09d07b29bf04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94772
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
createSocketImpl is always called with the same argument
Change-Id: I15d442a36407ebfecefe7adf594bffbf1204443e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94796
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Change-Id: I15d442a36407ebfecefe7adf594bffbf1204443e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94796
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
change Rand(de) comment to margin(en)
Change-Id: I65cbc0698afddf660dbb23626a537452b5e18bec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94784
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I65cbc0698afddf660dbb23626a537452b5e18bec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94784
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
uitest: use fixed values for width and height
Change-Id: Id7217392a94ba79f5737a95b056a8f53281e5844
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94792
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Change-Id: Id7217392a94ba79f5737a95b056a8f53281e5844
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94792
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
loplugin:unusedmethods
Change-Id: I235e00eca7b7cbc070bf5831117868eba5c7c273
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I235e00eca7b7cbc070bf5831117868eba5c7c273
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
loplugin:constantparam
Change-Id: I8961b5df1b3a7ea9b7dd83114fce1555b9e4ffcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94787
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I8961b5df1b3a7ea9b7dd83114fce1555b9e4ffcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94787
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
fix an incorrectly removed line
The change in cfaf93d2b3efdbbe was supposed to just remove the call,
not the whole variable assignment.
Change-Id: Id104035a430d3c3f7f462bd115a023f3c541aeac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94788
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The change in cfaf93d2b3efdbbe was supposed to just remove the call,
not the whole variable assignment.
Change-Id: Id104035a430d3c3f7f462bd115a023f3c541aeac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94788
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
tdf#88109 speed up calc autofill
switch from ScFlatUInt16RowSegments to ScCompressedArray
The problem with the underlying mdds::flat_segment_tree data structure
is that it is optimised for bulk-load and then frequent read.
But here we are interleaving reading and updating the data, which means
flat_segment_tree spends a lot of time in its build_tree code.
Change-Id: Ic0d46834a2449e4fa9f84343971417adb48ba2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94694
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
switch from ScFlatUInt16RowSegments to ScCompressedArray
The problem with the underlying mdds::flat_segment_tree data structure
is that it is optimised for bulk-load and then frequent read.
But here we are interleaving reading and updating the data, which means
flat_segment_tree spends a lot of time in its build_tree code.
Change-Id: Ic0d46834a2449e4fa9f84343971417adb48ba2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94694
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Code duplication
Change-Id: I1af2948e0332044ef88bc7dbd837e8c7afe7af19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94785
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Change-Id: I1af2948e0332044ef88bc7dbd837e8c7afe7af19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94785
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Do not time out execute_dialog_through_command
If something goes wrong, better keep the testing Python and the tested soffice
process in a state in which the actual problem can (hopefully) be debugged
better.
I happened to run into a hung UITest_options on Linux, where soffice.bin was
still at
> Thread 1 (Thread 0x7fa6371d9fc0 (LWP 1210042)):
> #0 futex_abstimed_wait_cancelable (private=0, abstime=0x7fa633a17f80, clockid=<optimized out>, expected=0, futex_word=0x60e000024e88) at /usr/src/debug/glibc-2.31-17-gab029a2801/sysdeps/nptl/futex-internal.h:320
> #1 __pthread_cond_wait_common (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:520
> #2 __pthread_cond_clockwait (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:677
> #3 __pthread_cond_clockwait (cond=0x60e000024e60, mutex=0x60e000024e38, clockid=<optimized out>, abstime=0x7fa633a17f80) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:665
> #4 0x00007fa66899be08 in std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:210
> #5 0x00007fa66899b895 in std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:120
> #6 0x00007fa668997505 in std::condition_variable::wait_until<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __atime=..., __p=...) at include/c++/10.0.1/condition_variable:159
> #7 0x00007fa668995460 in std::condition_variable::wait_for<long, std::ratio<1l, 1000l>, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::duration<long, std::ratio<1l, 1000l> > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __rtime=..., __p=...) at include/c++/10.0.1/condition_variable:186
> #8 0x00007fa66899408e in SvpSalInstance::DoYield(bool, bool) (this=0x611000001bc0, bWait=true, bHandleAllCurrentEvents=false) at vcl/headless/svpinst.cxx:497
> #9 0x00007fa667e7114d in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:455
> #10 0x00007fa667e70708 in Application::Yield() () at vcl/source/app/svapp.cxx:519
> #11 0x00007fa66498f6cd in Dialog::Execute() (this=0x618003c16480) at vcl/source/window/dialog.cxx:1030
> #12 0x00007fa667a93812 in SalInstanceDialog::run() (this=0x616000575780) at vcl/source/app/salvtables.cxx:1482
> #13 0x00007fa2e8711b8d in weld::DialogController::run() (this=0x60c004e70d80) at include/vcl/weld.hxx:2289
> #14 0x00007fa2e98a6cbc in OfaTreeOptionsDialog::run() (this=0x60c004e70d80) at cui/source/options/treeopt.cxx:1937
> #15 0x00007fa2e90c4d15 in CuiAbstractController_Impl::Execute() (this=0x60300187b4f0) at cui/source/factory/dlgfact.cxx:103
> #16 0x00007fa688bc9b2d in SfxApplication::OfaExec_Impl(SfxRequest&) (this=0x604006f2fe10, rReq=...) at sfx2/source/appl/appserv.cxx:1311
> #17 0x00007fa688b17655 in SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&) (pShell=0x604006f2fe10, rReq=...) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:1270
> #18 0x00007fa6892521f6 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x604006f2fe10, pFunc=0x7fa688b17530 <SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&)>, rReq=...) at include/sfx2/shell.hxx:197
> #19 0x00007fa6891dbb1f in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x6020013430b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at sfx2/source/control/dispatch.cxx:252
> #20 0x00007fa6891defd6 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) (this=0x6020013430b0, pReq=std::unique_ptr<class SfxRequest> = {...}) at sfx2/source/control/dispatch.cxx:989
[...]
but the Python process was already at
> Traceback (most recent call first):
> <built-in method waitpid of module object at remote 0x60800002d140>
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1611, in _try_wait
> (pid, sts) = os.waitpid(self.pid, wait_flags)
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1653, in _wait
> (pid, sts) = self._try_wait(0)
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1019, in wait
> return self._wait(timeout=timeout)
> File "uitest/libreoffice/connection.py", line 133, in tearDown
> ret = self.soffice.wait()
> File "uitest/libreoffice/connection.py", line 178, in tearDown
> self.connection.tearDown()
> File "uitest/uitest/framework.py", line 46, in tearDown
> self.connection.tearDown()
> File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 631, in run
> self.tearDown()
> File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 676, in __call__
> return self.run(*args, **kwds)
> File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 122, in run
> test(result)
> File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 84, in __call__
> return self.run(*args, **kwds)
> File "instdir/program/python-core-3.7.7/lib/unittest/runner.py", line 176, in run
> test(result)
> File "uitest/test_main.py", line 128, in <module>
> result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite)
and the relevant
> ======================================================================
> ERROR: test_tdf78133_options_app_colors (tdf78133.tdf78133)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "sw/qa/uitest/options/tdf78133.py", line 38, in test_tdf78133_options_app_colors
> self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") #optionsdialog
> File "uitest/uitest/test.py", line 78, in execute_dialog_through_command
> raise DialogNotExecutedException(command)
> uitest.test.DialogNotExecutedException: Dialog not executed for: .uno:OptionsTreeDialog
had not yet been written to workdir/UITest/options/done.log (Python's unittest
appears to unhelpfully hold back such vital information until the very end of
the full test run).
There appears to be no test code that relies on a timed-out
execute_dialog_through_command throwing an exception instead of hanging (at
least, there is no explicit catching of DialogNotExecutedException anywhere in
the code, and a full `make check screenshot` on Linux kept working with this
change).
(This is similar to 19d3dba72fd744ab8dc1288b1c7c4c811b24ca28 "Do not time out
close_dialog_through_button".)
Change-Id: Ie907a091ae09b59e65c4b2676298e147c9d2da2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94786
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
If something goes wrong, better keep the testing Python and the tested soffice
process in a state in which the actual problem can (hopefully) be debugged
better.
I happened to run into a hung UITest_options on Linux, where soffice.bin was
still at
> Thread 1 (Thread 0x7fa6371d9fc0 (LWP 1210042)):
> #0 futex_abstimed_wait_cancelable (private=0, abstime=0x7fa633a17f80, clockid=<optimized out>, expected=0, futex_word=0x60e000024e88) at /usr/src/debug/glibc-2.31-17-gab029a2801/sysdeps/nptl/futex-internal.h:320
> #1 __pthread_cond_wait_common (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:520
> #2 __pthread_cond_clockwait (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:677
> #3 __pthread_cond_clockwait (cond=0x60e000024e60, mutex=0x60e000024e38, clockid=<optimized out>, abstime=0x7fa633a17f80) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:665
> #4 0x00007fa66899be08 in std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:210
> #5 0x00007fa66899b895 in std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:120
> #6 0x00007fa668997505 in std::condition_variable::wait_until<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __atime=..., __p=...) at include/c++/10.0.1/condition_variable:159
> #7 0x00007fa668995460 in std::condition_variable::wait_for<long, std::ratio<1l, 1000l>, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::duration<long, std::ratio<1l, 1000l> > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __rtime=..., __p=...) at include/c++/10.0.1/condition_variable:186
> #8 0x00007fa66899408e in SvpSalInstance::DoYield(bool, bool) (this=0x611000001bc0, bWait=true, bHandleAllCurrentEvents=false) at vcl/headless/svpinst.cxx:497
> #9 0x00007fa667e7114d in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:455
> #10 0x00007fa667e70708 in Application::Yield() () at vcl/source/app/svapp.cxx:519
> #11 0x00007fa66498f6cd in Dialog::Execute() (this=0x618003c16480) at vcl/source/window/dialog.cxx:1030
> #12 0x00007fa667a93812 in SalInstanceDialog::run() (this=0x616000575780) at vcl/source/app/salvtables.cxx:1482
> #13 0x00007fa2e8711b8d in weld::DialogController::run() (this=0x60c004e70d80) at include/vcl/weld.hxx:2289
> #14 0x00007fa2e98a6cbc in OfaTreeOptionsDialog::run() (this=0x60c004e70d80) at cui/source/options/treeopt.cxx:1937
> #15 0x00007fa2e90c4d15 in CuiAbstractController_Impl::Execute() (this=0x60300187b4f0) at cui/source/factory/dlgfact.cxx:103
> #16 0x00007fa688bc9b2d in SfxApplication::OfaExec_Impl(SfxRequest&) (this=0x604006f2fe10, rReq=...) at sfx2/source/appl/appserv.cxx:1311
> #17 0x00007fa688b17655 in SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&) (pShell=0x604006f2fe10, rReq=...) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:1270
> #18 0x00007fa6892521f6 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x604006f2fe10, pFunc=0x7fa688b17530 <SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&)>, rReq=...) at include/sfx2/shell.hxx:197
> #19 0x00007fa6891dbb1f in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x6020013430b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at sfx2/source/control/dispatch.cxx:252
> #20 0x00007fa6891defd6 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) (this=0x6020013430b0, pReq=std::unique_ptr<class SfxRequest> = {...}) at sfx2/source/control/dispatch.cxx:989
[...]
but the Python process was already at
> Traceback (most recent call first):
> <built-in method waitpid of module object at remote 0x60800002d140>
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1611, in _try_wait
> (pid, sts) = os.waitpid(self.pid, wait_flags)
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1653, in _wait
> (pid, sts) = self._try_wait(0)
> File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1019, in wait
> return self._wait(timeout=timeout)
> File "uitest/libreoffice/connection.py", line 133, in tearDown
> ret = self.soffice.wait()
> File "uitest/libreoffice/connection.py", line 178, in tearDown
> self.connection.tearDown()
> File "uitest/uitest/framework.py", line 46, in tearDown
> self.connection.tearDown()
> File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 631, in run
> self.tearDown()
> File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 676, in __call__
> return self.run(*args, **kwds)
> File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 122, in run
> test(result)
> File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 84, in __call__
> return self.run(*args, **kwds)
> File "instdir/program/python-core-3.7.7/lib/unittest/runner.py", line 176, in run
> test(result)
> File "uitest/test_main.py", line 128, in <module>
> result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite)
and the relevant
> ======================================================================
> ERROR: test_tdf78133_options_app_colors (tdf78133.tdf78133)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "sw/qa/uitest/options/tdf78133.py", line 38, in test_tdf78133_options_app_colors
> self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") #optionsdialog
> File "uitest/uitest/test.py", line 78, in execute_dialog_through_command
> raise DialogNotExecutedException(command)
> uitest.test.DialogNotExecutedException: Dialog not executed for: .uno:OptionsTreeDialog
had not yet been written to workdir/UITest/options/done.log (Python's unittest
appears to unhelpfully hold back such vital information until the very end of
the full test run).
There appears to be no test code that relies on a timed-out
execute_dialog_through_command throwing an exception instead of hanging (at
least, there is no explicit catching of DialogNotExecutedException anywhere in
the code, and a full `make check screenshot` on Linux kept working with this
change).
(This is similar to 19d3dba72fd744ab8dc1288b1c7c4c811b24ca28 "Do not time out
close_dialog_through_button".)
Change-Id: Ie907a091ae09b59e65c4b2676298e147c9d2da2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94786
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Revert "tdf#104017 DOC export: be less aggressive with merging page styles"
This reverts LO 6.3.4 commit 5d1709a7c4184eb31cfc4c2d3acadff3a4a68189,
which tdf#133334 shows is wrong. How this made it past QA
is a mystery to me. There should be lots of examples.
Change-Id: I17be6e4bab44057f4535d4728825e12d068b65d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94782
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This reverts LO 6.3.4 commit 5d1709a7c4184eb31cfc4c2d3acadff3a4a68189,
which tdf#133334 shows is wrong. How this made it past QA
is a mystery to me. There should be lots of examples.
Change-Id: I17be6e4bab44057f4535d4728825e12d068b65d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94782
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
uitest: rework test that fails at times
sometimes it fails with
self.assertEqual(get_state_as_dict(xLineMetric)["Text"], "5.0 pt")
AssertionError: '8.8 pt' != '5.0 pt'
- 8.8 pt
+ 5.0 pt
Change-Id: I5287d5ebbd92ef82bd384f609b92fbcfeef7fd44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94778
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
sometimes it fails with
self.assertEqual(get_state_as_dict(xLineMetric)["Text"], "5.0 pt")
AssertionError: '8.8 pt' != '5.0 pt'
- 8.8 pt
+ 5.0 pt
Change-Id: I5287d5ebbd92ef82bd384f609b92fbcfeef7fd44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94778
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
tdf#133190 tdf#133191 Chart OOXML export: fix text wrap and rotation
of data point labels.
Change-Id: Ic61d9ee149e838c000b5dc9ac0411bbe0f07219a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94598
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
of data point labels.
Change-Id: Ic61d9ee149e838c000b5dc9ac0411bbe0f07219a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94598
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Fix typo
Change-Id: I01d37799ec2ba902613cc956b819af2f35e1c446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94779
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Change-Id: I01d37799ec2ba902613cc956b819af2f35e1c446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94779
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
high quality scale when drawing scaled Skia image (tdf#133339)
Apparently even drawBitmap() may lead to image scaling.
Change-Id: I8665dfc4d12768c3824bbc45aaa72277168acc8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94781
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Apparently even drawBitmap() may lead to image scaling.
Change-Id: I8665dfc4d12768c3824bbc45aaa72277168acc8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94781
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
tdf#133005 Chart: fix ODF import of date axis position
Chart with date axis setting "On tick marks" wasn't
imported correctly.
See commit 40d83914d43f60a196dfabddea0b52e2046b333a
(tdf#127792 implement UNO chart attribute MajorOrigin)
Change-Id: I5967c4bab8690df1f191b33ecb0e5b043bca68a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94621
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Chart with date axis setting "On tick marks" wasn't
imported correctly.
See commit 40d83914d43f60a196dfabddea0b52e2046b333a
(tdf#127792 implement UNO chart attribute MajorOrigin)
Change-Id: I5967c4bab8690df1f191b33ecb0e5b043bca68a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94621
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Fix typos
Change-Id: I7c94080396dae767079a968cdda74449a144a947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94655
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Change-Id: I7c94080396dae767079a968cdda74449a144a947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94655
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
svx:unit tests for theme count, gallery theme entry functions in gallery
Change-Id: I7ff7f6f5607348e8ff135614d7de1957741a11fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93305
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Change-Id: I7ff7f6f5607348e8ff135614d7de1957741a11fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93305
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Enforce "internal" or "fully-internal" Python on macOS
Offering a wider choice is pointless. There is no system Python on
end-user machines, and besides, trying to build against the Python
bundled with Xcode apparently causes compilation warnings.
Change-Id: Iba24da1de36705df60cc5cf349885a7bae0ab879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94769
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Offering a wider choice is pointless. There is no system Python on
end-user machines, and besides, trying to build against the Python
bundled with Xcode apparently causes compilation warnings.
Change-Id: Iba24da1de36705df60cc5cf349885a7bae0ab879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94769
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
tdf#125812 Chart: fix OOXML export of gradient center
See also: commit 898e4ae1364e76af8be22183ac64d73b6a6d8d90
(tdf#128794 Chart: Fix OOXML import/export of Radial gradient)
Change-Id: I9486c5b1dfcfd25bbf00d5f11b90c3c02459f634
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94486
Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
See also: commit 898e4ae1364e76af8be22183ac64d73b6a6d8d90
(tdf#128794 Chart: Fix OOXML import/export of Radial gradient)
Change-Id: I9486c5b1dfcfd25bbf00d5f11b90c3c02459f634
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94486
Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
offapi: 6.5 is now called 7.0
Change-Id: I6919bc94a96a3ecd63a22972dd0c0651d18559ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94771
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Change-Id: I6919bc94a96a3ecd63a22972dd0c0651d18559ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94771
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
vcl: refactor code into GenerateConnectedComponents()
Change-Id: I366900248d7d56bf98278463065460d98f321120
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94719
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Change-Id: I366900248d7d56bf98278463065460d98f321120
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94719
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
vcl: refactor code into GenerateIntersectingConnectedComponents()
Change-Id: I821feafacb5301c7001c68be995df72ba02a64b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94565
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Change-Id: I821feafacb5301c7001c68be995df72ba02a64b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94565
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
tdf#107119 DOCX import: fix parallel text wrap around frames
It was imported as "optimal page wrap" instead of parallel one,
resulting different page layout depending on the distance
of the frame object from the page margins.
Co-authored-by: Attila Bakos (NISZ)
Change-Id: I0db65c224f537bfd4f95ee073743a3d17d9e0e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94576
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
It was imported as "optimal page wrap" instead of parallel one,
resulting different page layout depending on the distance
of the frame object from the page margins.
Co-authored-by: Attila Bakos (NISZ)
Change-Id: I0db65c224f537bfd4f95ee073743a3d17d9e0e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94576
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
sd: add XPackageEncryption write support for binary ppt
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: Id82f8b3fa7ea045b00d7d81e2c9ce5e130c8060c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84442
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Jenkins
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: Id82f8b3fa7ea045b00d7d81e2c9ce5e130c8060c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84442
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Jenkins
sd: add XPackageEncryption support for binary ppt
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and description
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ib91538d53ee1f53a3cd14a44d47fd6f6136c0472
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84441
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and description
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ib91538d53ee1f53a3cd14a44d47fd6f6136c0472
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84441
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
calc: add XPackageEncryption write support for binary xls
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: I5faf885cf494becca2838c6493413bcc56e91826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84440
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: I5faf885cf494becca2838c6493413bcc56e91826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84440
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
calc: add XPackageEncryption support for binary xls
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and desrption
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ie580e5c12c48ccf99f9a932b1c66eb35866b7ef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84439
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and desrption
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ie580e5c12c48ccf99f9a932b1c66eb35866b7ef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84439
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
sw: add XPackageEncryption save support for binary doc
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: I814e4a7f73979ff7a65831b99f77f1a9e85916de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84438
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This adds save support for API-based MS-CRYPTO algos. If we have
custom encryption data in media descriptor and corresponding service
is available it will be used during saving.
Change-Id: I814e4a7f73979ff7a65831b99f77f1a9e85916de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84438
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
sw: add XPackageEncryption support for binary doc
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and desrption
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ie1a5b0417e1e7851b24d410c8f41dc85dd9210f7
Reviewed-on: https://gerrit.libreoffice.org/81600
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84437
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This adds read support for API-based MS-CRYPTO algos.
DRM encryption is implemented as a service and desrption
will be called if we found corresponding streams inside
binary OLE package.
Change-Id: Ie1a5b0417e1e7851b24d410c8f41dc85dd9210f7
Reviewed-on: https://gerrit.libreoffice.org/81600
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84437
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
[MS-OFFCRYPTO] convert oox implementation into UNO service
To permit pluggable crypto services, abstract existing
implementation behind an XPackageEncryption API.
Previous code already had two halfway-polymorphic classes (agile and
standard 2007 engine), so we're not adding much additional layers.
As MS crypto always uses OLE storage to wrap content into one single
file, current implementation passes all substorage names down into
XPackageEncryption APi, so different downstream implementations (e.g.
for MS RMS, or Azure AIP) are possible.
Because OleStorage classes are internal to LibO core, access is provided
via XInput/XOutput stream API function.
Change-Id: Icc32a4e0ce215090c3b739f1dcaa0654b36b7f08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84436
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
To permit pluggable crypto services, abstract existing
implementation behind an XPackageEncryption API.
Previous code already had two halfway-polymorphic classes (agile and
standard 2007 engine), so we're not adding much additional layers.
As MS crypto always uses OLE storage to wrap content into one single
file, current implementation passes all substorage names down into
XPackageEncryption APi, so different downstream implementations (e.g.
for MS RMS, or Azure AIP) are possible.
Because OleStorage classes are internal to LibO core, access is provided
via XInput/XOutput stream API function.
Change-Id: Icc32a4e0ce215090c3b739f1dcaa0654b36b7f08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84436
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
package: ignore unknown encryption parameters.
Do not throw an exception if there are encryption parameters,
but they are not supported in current output format. Invalid or
unsupported encryption then fails higher up the stack.
Change-Id: I21e4cf2f73d7c218ab5444b2016e838695163ca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84435
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Do not throw an exception if there are encryption parameters,
but they are not supported in current output format. Invalid or
unsupported encryption then fails higher up the stack.
Change-Id: I21e4cf2f73d7c218ab5444b2016e838695163ca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84435
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
sfx2 UNO API: XModel2::setArgs() now also supports "EncryptionData"
XModel2::setArgs() only permits hand-picked set of media descriptor
parameters. Add one more in preparation to API-based MS crypto rework.
Change-Id: I179a1cfc2cdd7b04becba0d7dfe9740d920ae4ee
Reviewed-on: https://gerrit.libreoffice.org/80432
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84434
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
XModel2::setArgs() only permits hand-picked set of media descriptor
parameters. Add one more in preparation to API-based MS crypto rework.
Change-Id: I179a1cfc2cdd7b04becba0d7dfe9740d920ae4ee
Reviewed-on: https://gerrit.libreoffice.org/80432
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84434
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
sw: prefix members of SwUndoDelNum, SwUndoInsNum, SwUndoNumruleRename ...
... and SwUndoRenameFormat
See tdf#94879 for motivation.
Change-Id: I9ff812ce6c3c956954262e0546fe5f538bd91d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94768
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
... and SwUndoRenameFormat
See tdf#94879 for motivation.
Change-Id: I9ff812ce6c3c956954262e0546fe5f538bd91d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94768
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
no GtkTextView:border cases exist anymore
Change-Id: I5f95ac2b34abbdcc91f052367dd7b8cce303db93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94741
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I5f95ac2b34abbdcc91f052367dd7b8cce303db93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94741
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>