Public Git Hosting - LibreOffice.git/log

tdf#118816 recover initial intent of enabled possibility of tristate as a flag

Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6
Reviewed-on: https://gerrit.libreoffice.org/57712
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 9f01dca60e6539f48cd529180f0d64c2131e0ea1)
Reviewed-on: https://gerrit.libreoffice.org/57760
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#104797 DOCX change tracking: handle moveFrom and moveTo

data as deletion and insertion instead of importing them
as normal (unmodified) texts (messing up document content
and losing change tracking information).

Change-Id: I9c0a7da83f3e8235d65d47afdb99ffe188f52704
Reviewed-on: https://gerrit.libreoffice.org/57723
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit bcdebc832b272662d28035007a4796e42d1305ae)
Reviewed-on: https://gerrit.libreoffice.org/58193
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

crashtesting: infinite recurse with moz609361-1.svg

Change-Id: I18c2dd159dd7a64c3627abdb472d65013453b1b9
Reviewed-on: https://gerrit.libreoffice.org/57893
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118304 reselect current glyph on changing font

preview glyph will rerender the glyph if its there, or the glyph description
changes to "missing glyph" if its not there anymore. Don't auto select
first entry of the subset when font changes, leave it as unselected and
let the glyph determine what's ends up there

Change-Id: I33d7dd3a071100175ac9bc7c7e9d44684a1aff28
Reviewed-on: https://gerrit.libreoffice.org/57724
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit e8bf2cb72dbe55f4e9ac7ace48e644a934cfc503)
Reviewed-on: https://gerrit.libreoffice.org/57765
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Update git submodules

* Update translations from branch 'libreoffice-6-1-0'
  - update translations for 6.1.0 rc3

    Change-Id: Ic0981c499d2d92d762de8fb2faf03ee8b2bfab20
    (cherry picked from commit ff3b3fa27451ec3e5fa557d83544b7578fb199d0)

Resolves: tdf#118862 new instances cannot be edited

Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c
Reviewed-on: https://gerrit.libreoffice.org/57962
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

tdf#119042: Also check if SfxViewFrame::Current() is nullptr

Change-Id: I5ac43ff626bfb4e2e754cacead5bf87115f3ce4b
Reviewed-on: https://gerrit.libreoffice.org/58447
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit d0a481d09e696f6d5a2a0d40a9d5c48cfca559bf)
Reviewed-on: https://gerrit.libreoffice.org/58458
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

tdf#118971: allow arrow keys to move images or drawing objects

Partially revert 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8

Change-Id: Ie4c91529c1ce878f4b0474d815a3a88ed48769c2
Reviewed-on: https://gerrit.libreoffice.org/58318
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e1d73cb5552c2566c6d7463ce001e555523f3d92)
Reviewed-on: https://gerrit.libreoffice.org/58343
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>

tdf#118869: mark some properties secure to pass them to elevated install

See also http://helpnet.flexerasoftware.com/installshield19helplib/helplibrary/ISBP10.htm

Change-Id: I217d68f98af8e56874af6c071bb7fa7354b3e4b4
Reviewed-on: https://gerrit.libreoffice.org/58326
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit ec9b18b75c193c914691a29d3eb78bd81961fced)
Reviewed-on: https://gerrit.libreoffice.org/58338
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 253cd2e450ca9c004237cd0c21b5c7f2f1f70bf7)
Reviewed-on: https://gerrit.libreoffice.org/58341
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Resolves: tdf#118965 fix input list edit button

regression since...

commit 7d5245848c28f5786258476cd7aa2a4523645de3
Date: Fri Sep 15 17:39:48 2017 +0200

tdf#79877 revert to old behavior when clicking on input fields.

Change-Id: I5e67a8f0c8d2599c139d3d728298c30f4a31c8d1
Reviewed-on: https://gerrit.libreoffice.org/58316
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

crashtesting: infinite recurse with moz455984-5.svg

Change-Id: Idef368c44454ae144b091132cd0d6103f92a6dde
Reviewed-on: https://gerrit.libreoffice.org/57856
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118764 Add missing tab stops in sidebar panels

Change-Id: I09d5df8d7f07eb4b6c4341d9cd281131fc2df23b
Reviewed-on: https://gerrit.libreoffice.org/57535
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/58217
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

crashtesting: infinite recurse with moz384637-1.svg

Change-Id: Ia4bbc9d471c63812dc3ef490f32e8490bda72bfe
Reviewed-on: https://gerrit.libreoffice.org/57890
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Update git submodules

* Update translations from branch 'libreoffice-6-1-0'
  - Updated Slovenian translation

    Change-Id: I300791744f2a85a8b10030a7e4382e6c6948ee2b
    (cherry picked from commit 652d82d20c965636694a36f9d43bacff1bd7025f)

tdf#118948 - Date format in Impress header/footer is lost when saving

regression from
commit 7d14555ef7e867c5b1a0e195e3ef056885697c59
convert SvxDateFormat to scoped enum

Change-Id: I9d365c710a20054e249433f54635068f713afa72
Reviewed-on: https://gerrit.libreoffice.org/58202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 93baa280670367ef6246d837080706f2c80eab0b)
Reviewed-on: https://gerrit.libreoffice.org/58290
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

update credits

Change-Id: I11206cbe209fc61c59af4d3be1c85168a518003f
(cherry picked from commit cba1c7421338324cb6c91511a294c4861e665c29)
(cherry picked from commit 28720483896211b54a606f7c4bed4b4b1e3239a3)

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1-0'
  - tdf#118844 Add missing icons in Help pages

    Apply strategy #1 described in tdf#118844 comment #3

    Change-Id: I072bf837217acc8dc84ff1104324df69e33a22bd
    Reviewed-on: https://gerrit.libreoffice.org/57802
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Update git submodules

* Update translations from branch 'libreoffice-6-1-0'
  - Updated Slovenian translation

    Change-Id: I35b6df1e23e86b91106b09af83f97f5a580f0520
    (cherry picked from commit d47af98a966ff72f60492aeded35b52637294a61)

tdf#118517: Use xStg before resetting it

Regression from 0f166ef5240ee155bf2544e6bc3c985b1e3bf646
Change-Id: I083951700895a00be8d4407871c27804ca3e5f30
Reviewed-on: https://gerrit.libreoffice.org/57881
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit a61d61f66f80c91c14825f8fe8fb9bd3f295591b)
Reviewed-on: https://gerrit.libreoffice.org/57907
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#118716 Inner border of an embedded table can't be dragged around

regression from
    commit f14b9d30293f180500fc56d81e5390021758e7c1
    convert (a>b?a:b) to std::max(a,b)

In this code
   int a;
   std::max<sal_uInt16>(a,0)
std::max will first convert a and b to sal_uInt16, therefore potentially
converting a negative number to a positive number due to the conversion
rules. Then it will take the larger number.

While this code
    int a;
    static_cast<sal_uInt16>(a > 0 ? a : 0)
will compare first, and then convert the larger number to sal_uInt16,
which might result in making a "a" that is larger than 2^16 into a
smaller value, but which will never convert a negative "a" value into a
positive value.

Change-Id: Id4f6df0089b1a74ea4ac1c5d05655e7c1d8f0c7f
Reviewed-on: https://gerrit.libreoffice.org/57846
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit c13865a4caf7898c4e59a5b22bbd493d6dad9661)
Reviewed-on: https://gerrit.libreoffice.org/57909
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Adapt solenv/flatpak-manifest.in to recent download.lst changes

(cherry picked from commit 5c016d6ae4e59629cfd0b80c631f67cf46e42d3e)
Conflicts:
solenv/flatpak-manifest.in

Change-Id: I7799abe1a6fc9cf79a751d76360ea7ad2face133
Reviewed-on: https://gerrit.libreoffice.org/57984
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fix shutdown crash when SfxApplication has already been destroyed

See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7

Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea
Reviewed-on: https://gerrit.libreoffice.org/57789
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 715fcaff01ed048c52c69264a7a0fb773dd57b32)
Reviewed-on: https://gerrit.libreoffice.org/57808
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 7b62c5266e62c3fb0ce1285949d51020075a3f81)
Reviewed-on: https://gerrit.libreoffice.org/57858
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#118777: Disable signature line slot if non-text object

in 6.1 only in sw, the functionality ain't there yet in sc

Change-Id: I54f7ec336026013d09ac6262779e7fcbd17c2084
Reviewed-on: https://gerrit.libreoffice.org/57949
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/57990
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 545ddabc6614e751c807e9d1e1cbf7c617fc4141)
Reviewed-on: https://gerrit.libreoffice.org/58049
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

tdf#118777 cui: use right XText in SignatureLineDialog

Writer has multiple nested XText and we have to call insertTextContent
on the one that corresponds to the xCursor, so use the convenient
getText() instead of hard-coding the body text.

Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36
Reviewed-on: https://gerrit.libreoffice.org/57969
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 7213a583f5c1d42c05dc4f19b4d4d2f9dded7733)
Reviewed-on: https://gerrit.libreoffice.org/57978
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 8a4f07b367284e898898b1840fc22f357099aba9)
Reviewed-on: https://gerrit.libreoffice.org/58050
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

forcepoint#53 restrict to expected index range

Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f
Reviewed-on: https://gerrit.libreoffice.org/57923
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

ofz#9431 don't check attribs of Invalid column

Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0
Reviewed-on: https://gerrit.libreoffice.org/57918
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Resolves: tdf#118919 crash on double click ole object

Change-Id: Id7b3df447db56f6f80d6255dabdcc7f6ab149e95
Reviewed-on: https://gerrit.libreoffice.org/57955
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

ofz#9507 wrong start point for Johab block 59

Change-Id: I011f4cbb10324c4a7d4e1be3ab1355291f79730b
Reviewed-on: https://gerrit.libreoffice.org/57841
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Update git submodules

* Update translations from branch 'libreoffice-6-1-0'
  - newlines at end of string must match what is in msgid

    Change-Id: I1e3ab006b238e11412f3d281fc1e9ac63169801b
    (cherry picked from commit 8a7d2f577bb9f9f540c61f775244a8d2af052048)

  - Version 6.1.0.2, tag libreoffice-6.1.0.2

    Change-Id: I11374e01aa8dcebc23fb5f6f3dc7e493f8ce7396

bump product version to 6.1.0.2.0+

Change-Id: I12dff725995c3fdaf36525f0f98c229d29dce3e1

Branch libreoffice-6-1-0

This is 'libreoffice-6-1-0' - the stable branch for the 6.1.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Ie67769a62181b764ce5d9a8be00d47555d287a5f

Resolves: tdf#118827 SetCareWin should be SetCareDialog

Change-Id: I84c00a193e65a18b3ba82351c07be0b63e0cd5d4
Reviewed-on: https://gerrit.libreoffice.org/57720
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND.

Change-Id: I7a875b172493112b66fca8f70d2061371a05486c
Reviewed-on: https://gerrit.libreoffice.org/57721
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit c69e7266916ac1b8917477fb4eccdb9098da5792)
Reviewed-on: https://gerrit.libreoffice.org/57728

Resolves: tdf#118302 drag n drop to same tab should cancel dnd

dropComplete is used to do this, follow the mac pattern here to
propogate this in the drag and drop from self to self case.

Maybe this also affects tdf#105320 ?

Change-Id: I2b8f8b0e0486f6ee45a65918fae2537750a75f2d
Reviewed-on: https://gerrit.libreoffice.org/57590
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

tdf#118651 OOXML ActiveX textbox: fix multiline support

of textfield component in DOCX/PPTX by handling properties
AX_FLAGS_MULTILINE and AX_FLAGS_WORDWRAP during the import
and export. Both of them need to be enabled to get multiline
textfield in MSO, but LibreOffice has got only one multiline
property. With this fix, LibreOffice imports only really
multiline textfields as multiline, and it doesn't export
multiline textfields as single line anymore.

Change-Id: I9b567c3fcdc5d01a5838a3ec2517579f8d788954
Reviewed-on: https://gerrit.libreoffice.org/57552
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-on: https://gerrit.libreoffice.org/57619
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

related tdf#106174 writerfilter: replace broken FindParentStyleSheet

FindParentStyleSheet didn't do anything right. An empty stylename
was supposed to check currentEntry, but instead it just returned
null. The passed stylename was completely ignored if there was
a currentEntry. And on top of that, the stylename itself was
returned, not its parent. Even worse, the currentEntry properties
were ignored because in that case it DID return the parent.
Even the comments were totally bogus. Amazing...

GetPropertyFromStyleSheet() has the potential for LOTS of use
in writerfilter. I'm surprised it has hardly been used. Perhaps
the completely wrong results led people to ignore it rather than
investigate why it didn't give the expected results.

Change-Id: I89a6b02877ab7990aa4eb58e5e0b6a572f3d10e3
Reviewed-on: https://gerrit.libreoffice.org/57195
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit bc67bda7363df48f1983513a8e969b61738139f5)
Reviewed-on: https://gerrit.libreoffice.org/57483

tdf#117038 set button width to max possible content width

Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba
Reviewed-on: https://gerrit.libreoffice.org/57718
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Resolves: tdf#118115 add missing help response id

Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c
Reviewed-on: https://gerrit.libreoffice.org/57716
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Update git submodules

* Update translations from branch 'libreoffice-6-1'
- update translations for 6.1.0 rc2

Change-Id: Ic312751e80079dee34a798631ac3bc7e4920d113

Resolves: tdf#118802 map GTK_RESPONSE_DELETE_EVENT to RET_CANCEL

Change-Id: I8285f329e4672c90f47d96ccffe60c21c565dde7
Reviewed-on: https://gerrit.libreoffice.org/57656
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118579 ignore body in body instead of flagging as an error

Change-Id: Ie6626a320a5264aea004f7c57244643798703de8
Reviewed-on: https://gerrit.libreoffice.org/57653
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Colibre icons: fix links.txt link and update addwatch icon

Change-Id: Iddb48d2cde206824f7721c5f4374166cc4979ad9
Reviewed-on: https://gerrit.libreoffice.org/57272
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 85f4ec6e0ebf4f97c1253c723d3c9c9b823ae372)
Reviewed-on: https://gerrit.libreoffice.org/57465
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

move freeze/thaw to Widget

Change-Id: I3944092c26ca81028912f6fb206b148b49e4f172
Reviewed-on: https://gerrit.libreoffice.org/57495
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118635 relative checkbox disabled on reopen

Change-Id: Ic52737e5122b1ae37390061a5f7cf17b69e7e665
Reviewed-on: https://gerrit.libreoffice.org/57499
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - Helponline: Fix alignment of TOC in sidebar

    It was too close to the window border in Edge, Chrome and Firefox Nightly.

    (cherry picked from commits 01319d64fae5989f35d10038d19d3371efb69d73
    and 1ee609da2c58c8628535602348d2a51dd7ac9f14)

    Change-Id: Ic65fd8bcddf9836cfa4c6529fe286885983c78d1
    Reviewed-on: https://gerrit.libreoffice.org/57341
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

xmlsecurity UI: restore lost AdES default for PDF signing

Regression from 13596e704e4b48e8b0892867b3f3fc351a2729f9 (Don't pass ODF
version, just retrieve it directly, 2018-05-17).

Change-Id: Ia031e597c610000db2820920c3dc1b58430dcc12
Reviewed-on: https://gerrit.libreoffice.org/57246
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit a9c0289886ee5519d4a718d8e3145d66b187faac)
Reviewed-on: https://gerrit.libreoffice.org/57259
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#118354 Do not dereference non-exsisting Object

Change-Id: Ie7323302f3b29dfc19b26e2185321c2e609cab2b
Reviewed-on: https://gerrit.libreoffice.org/57629
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/57711

Resolves: tdf#94925 proper recalc mode and dirty broadcast for OOXML import

This is a combination of 4 commits.

Rework FormulaTokenArray ScRecalcMode in preparation for tdf#94925

Strictly order the exclusive bits by priority, let AddRecalcMode()
handle all sets except forced ALWAYS or NORMAL.

Introduce ONLOAD_LENIENT and ONLOAD_MUST splitting ONLOAD to be
able to distinguish later during OOXML import.

Reviewed-on: https://gerrit.libreoffice.org/57402
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Resolves: tdf#94925 do not unset dirty if formula cell must be recalculated

Reviewed-on: https://gerrit.libreoffice.org/57404
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Broadcast formula cells marked for recalc, tdf#94925 related

In fact the ScDocument::CalcFormulaTree() call in
WorkbookFragment::recalcFormulaCells() never did anything because
no formula cell was added to the tree. Only visible dirty cells
were recalculated, but not their dependents.

Reviewed-on: https://gerrit.libreoffice.org/57431
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Remove the check for IsRecalcModeMustAfterImport(), tdf#94925 follow-up

It's now superfluous as we set those cells dirty and broadcast in
ScDocumentImport::broadcastRecalcAfterImport()

Reviewed-on: https://gerrit.libreoffice.org/57439
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
f70860b8babf1cce7fda2ae63412659e72dbb4c3
a9dd4ad16c20b23ee8a1d46b69a4702b1ad4c81f
188de2d53a2d54df32d24eeeb148c4f9e87e7cfc

Change-Id: I11217fa19adb766f509d0d6854502112de547c59
Reviewed-on: https://gerrit.libreoffice.org/57438
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Related: tdf#117016 DoubleRefToVars: always put in order

... as all callers expect, whatever dynamic range creating process
may have created it.

Change-Id: I47b2e174d5bf4d5c23f10685526b48eee07dd6a4
Reviewed-on: https://gerrit.libreoffice.org/57567
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit 6db5e1bdd67531fab14b375d6c624237d38de297)
Reviewed-on: https://gerrit.libreoffice.org/57621
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#118738: use SwDepend instead of WriterMultiListener in SwContentNode

This reverts commit 83243003b46dfb258c2b41049b0e1cb82a2d7ddb

use WriterMultiListener instead of SwDepend in SwContentNode
- also move SwContentNode and SwTextNode from
Modify to SwClientNotify
- this removes the last public use of SwDepend, which should now become
an implementation detail of WriterMultiListener

and commit ecf50fe71596c3edba8ce437481ab80ae1cd8935

remove now obsolete SwDepend

Revert them for now ( specially before the relese of LibreOffice 6.1 )
until a fix for the bugs listed in tdf#118738 is provided

Change-Id: I174feb3b092ff31b4c4837011c31343296c0c693
Reviewed-on: https://gerrit.libreoffice.org/57698
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

crashtesting: infinite recurse on moz330387-6.svg

Change-Id: I3c39d49504a4651b92f41c07e4cef8887366dc2b
Reviewed-on: https://gerrit.libreoffice.org/57627
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

bubble referer to LinkManager::GetGraphicFromAny

Change-Id: Id2c6d629692a365f96f3f81c5686930668389a6a
Reviewed-on: https://gerrit.libreoffice.org/57549
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

put load of html images (to measure dimensions) under referer control

Change-Id: I1de4a5214ef48394dcafa97e4ea12bb460f2fba2
Reviewed-on: https://gerrit.libreoffice.org/57566
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

only ellipize menubutton label when requesting narrower size

Change-Id: I32f4856756910ec1db8d37854b6e57dbec5aae76
Reviewed-on: https://gerrit.libreoffice.org/57618
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Resolves: tdf#118604 only use popover workaround for popovers, not menus

Change-Id: I7982a3836fbf699979beaa70e34bfa38aea80462
Reviewed-on: https://gerrit.libreoffice.org/57616
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Related: tdf#118681 use a case insensitive compare for hex digits

Change-Id: I7b177d2772a86cada37c20056794bc1d8ab50991
Reviewed-on: https://gerrit.libreoffice.org/57565
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Resolves: tdf#118520 insert sheet list not horizontally expanded

Change-Id: I0004602631fb82ed13d925a1911ea4ada544462d
Reviewed-on: https://gerrit.libreoffice.org/57633
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Resolves: tdf#118562 set correct help button placement

Change-Id: Ia7e5a5ba549c5824b43b36e6b3350b4b5f6c9118
Reviewed-on: https://gerrit.libreoffice.org/57658
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Resolves: tdf#118545 restore to historic logic

revert

commit 9eff9e699e17cc5a8a25895bd28dc8e4ceb8071e
Date:   Wed Aug 10 09:47:40 2016 +0200

    Don't re-check valid SwPageDescs when layouting

and then revert

commit 60d34e1c840d2c317bb7d0a5b14f4602c22b3fcc
Date:   Wed Nov 12 20:33:06 2014 +0000

    coverity#735517 Logically dead code

    its possible that this was the original intent, maybe

Change-Id: Iff45f1e7f3d7e3791d984eb117779a6f39ebb19c
Reviewed-on: https://gerrit.libreoffice.org/57578
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Resolves: tdf#118801 icons go missing on text-less buttons

Change-Id: I003a59643518e60948d71b335dfcd7e20ba8fee5
Reviewed-on: https://gerrit.libreoffice.org/57573
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - tdf#115254 Some branch bookmarks are not working 4

    sfx2 module dialogs

    Change-Id: Id7f799c0939c63695c29d0b6352e88c005386d3f
    Reviewed-on: https://gerrit.libreoffice.org/57468
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/57649

tdf#107690 OOXML import/export of setting "Open as read-only"

Import custom document property _MarkAsFinal as LoadReadonly
setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX
and PPTX documents.

Before this fix, LibreOffice opened read-only OOXML documents
as editable, also saved and exported _MarkAsFinal=true silently,
resulting unintented read-only warning info bar in MSO.

This commit improves interoperability a lot, because this is a
basic document protection of MSO, recommended on its UI.

Note: LoadReadonly (on File->Properties...->Security, property
"Open file read-only") doesn't show "Edit read-only" info bar
from commit 630186ff4e0eba7317e542f8c3eca39ebd068721,
but it's still possible to switch on editing by Edit->Edit Mode.
MSO shows info bar for _MarkAsFinal. (There is an advantage to
hide the info bar in LibreOffice in a mixed environment,
to avoid overwriting of press-ready MSO files by LibreOffice.)

Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal
in MSO: (1) Switching on editing doesn't remove the LoadReadonly
property automatically in LO. (2) Saving with LoadReadonly doesn't
switch off editing of the actual (still opened) document in LO.

(cherry picked from commit 9a5c56a9c4e04589b0a6bb710573922e459d9685
and bbdb6cb8ed0d77eeb2e413b38f29d2084bd8257b (unit tests))

Change-Id: I79897605e1fabe0708cce0b0c6216c152b201fc9
Reviewed-on: https://gerrit.libreoffice.org/56752
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#118751: Revert "tdf#117081: show Firebird by default"

Only in 6.1 branch

This reverts commit 8a1a9899e05b0ebbc3ff43f2db242724c8feb18f.

Change-Id: I48c9ce8dc9d45ab243c96e65da8d1b01a9423b5c
Reviewed-on: https://gerrit.libreoffice.org/57429
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - Fix typo

    Change-Id: I626c1943c79f2767c6c528e3305e76b375b4d4da
    Reviewed-on: https://gerrit.libreoffice.org/57592
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    (cherry picked from commit 67fd95451697b52199016ec1fbaedfe459295826)
    Reviewed-on: https://gerrit.libreoffice.org/57624

tdf#118752: Enable firebird migration in experimental mode

Only in 6.1

Revert "Disable migration in this release"

This reverts commit 443da1959d02569c59d064748a06d39c6dbb2f64.

Change-Id: Ib3286b01205ac5360aa299346ee524825e739167
Reviewed-on: https://gerrit.libreoffice.org/57508
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#113646, export font size for dxf records

Change-Id: I6dd6b0ef858fd933603be4435f7810c739b72ef0
Reviewed-on: https://gerrit.libreoffice.org/57471
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 14c2ca1b4efad2dcdc40e6d5c218cedd487857aa)
Reviewed-on: https://gerrit.libreoffice.org/57529
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#118549 crash on dialog teardown

only an issue for the current partially complete interim case

Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20
Reviewed-on: https://gerrit.libreoffice.org/57502
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#89893: Enable previous/next track changes in read-only mode

Change-Id: Ie7dd41b2f79347e9b959a73d58888915379f2e2a
Reviewed-on: https://gerrit.libreoffice.org/57100
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
(cherry picked from commit eedeeb63d1287ed0416e1fe3d2f7ba37632626d0)
Reviewed-on: https://gerrit.libreoffice.org/57155
Reviewed-by: Eike Rathke <erack@redhat.com>

coverity#1437960 Resource leak in object

Change-Id: Icee05e1ef1fef213de293971beb9e17753c8eb3b
Reviewed-on: https://gerrit.libreoffice.org/57460
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#118681 make sure we're using the right font char map

Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4
Reviewed-on: https://gerrit.libreoffice.org/57505
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#117816, work around MS Excel bug with containsText cond format

This is a combination o the following two master commits:

tdf#117816, work around MS Excel bug with containsText cond format

Excel seems to require the formula that is equal to the containsText
condition.

According to cfRule (18.3.1.10) "Only rules with a type attribute
value of expression support formula syntax." which contradicts the
MS EXCEL behavior.

Change-Id: Ifa3f9fee58194f70a64b37c62922513435d43bb8
Reviewed-on: https://gerrit.libreoffice.org/57432
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
related tdf#117816, add more work arounds for MS Excel bugs

Another set of cases where MS Excel needs the formula.

Change-Id: I58344a540ad69ff9b8c56aa817730079bd011acd
Reviewed-on: https://gerrit.libreoffice.org/57466
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

related tdf#117816, the dxf ID is a global and not a sheet property

Change-Id: I4c5ca66ce550de74d8b9396aa0213c558b7f884f
Reviewed-on: https://gerrit.libreoffice.org/57467
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

related tdf#113646, keep cjk, ctl font items in sync

If the default style and default pool items are no longer in sync,
our script detection assumes that any style without an explicitly
set font has script type CTL or CJK.

Use the same selection idea for both cases and at the same time
use the *_SPREADSHEET font items for the default pool items.

Change-Id: I6a5bb14a3fabab11627ad52b9e79554fdcedac89
Reviewed-on: https://gerrit.libreoffice.org/57470
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 952cbfd2de0801081665a8ff05600eb7ea1cf82f)
Reviewed-on: https://gerrit.libreoffice.org/57473
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#118769 parent of modal dialog not set

Change-Id: Ie3b1a626eb0ca4f39e015a18fede935b36ed194e
Reviewed-on: https://gerrit.libreoffice.org/57493
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

tdf#118647: Improve handling of system spell dictionaries on macOS

The system has generic spell dictionaries for languages spoken in many
countries, but LibreOffice wants them to correspond to specific
language-country combinations. So do it like that then.

Change-Id: I9ec4bb4302b2f1eec3ce7b1c1ef8f2be867bad52
Reviewed-on: https://gerrit.libreoffice.org/57220
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/57226
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#118702: partially revert the fix for tdf#78907

This is a regression from 2df0d9d32d05f08ccf673fd0f61f650438511acb

Reverting it as the unitest from tdf#78907 still passes.
Besides, adding a new unittest for tdf#118702

Finally, adapt ooxmlexport9 and remove pointless assert which fails
with:

ooxmlexport9.cxx:557:Assertion
Test name: testBnc519228OddBreaks::Import_Export_Import
equality assertion failed
- Expected: <Any: (void)>
- Actual : <Any: (string) Converted2>

Failures !!!
Run: 155 Failure total: 1 Failures: 1 Errors: 0

Change-Id: I486e9489ef6c3978cbcf90f3b9885248f4f92110
Reviewed-on: https://gerrit.libreoffice.org/57338
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit b0e2dbca5164c494a669bd48f8ff058f4c1ad710)
Reviewed-on: https://gerrit.libreoffice.org/57389

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - tdf#115254 Some branch bookmarks are not working 3

    dialogs from chart2

    Change-Id: I97e08c5b8ca2200f143073abadb355da99b38b9a
    Reviewed-on: https://gerrit.libreoffice.org/57451
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Icon theme bug: add sc icons for some page layout icons

this icons are needed in writer tabbed NB

Change-Id: Id71ff2d125923af9b9f13d1f8c2d34aa30be60f6
Reviewed-on: https://gerrit.libreoffice.org/57382
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit ccec2722aa816090f0ea51036c7df8e9871a5231)
Reviewed-on: https://gerrit.libreoffice.org/57449
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

tdf#118123 Tango shouldn't fallback to Colibre

move missing tango icons from galaxy
cause tango isn't finished without galaxy

missing links in links.txt from 6.1 release are not added

Change-Id: Ia199beabe2a465cb7e8013be807e610249f42424
Reviewed-on: https://gerrit.libreoffice.org/57291
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

disable OpenCL for XIRR

The function actually fails with sc/qa/.../xirr.fods if OpenCL is forced
(and mnOpenCLMinimumFormulaGroupSize is disabled). As far as I can tell
the OpenCL function gets the proper data and returns incorect data,
so it's the function itself that is buggy. No idea how to debug it,
feel free to.

Change-Id: I8879c6fdcfe8ecd2bc40fd3e0d1c13cddb1c2051
Reviewed-on: https://gerrit.libreoffice.org/57002
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 406ebf8e36ab1d1e10fb1d55101d7fc66add0c4b)
Reviewed-on: https://gerrit.libreoffice.org/57227
Reviewed-by: Eike Rathke <erack@redhat.com>

related tdf#114845 oox: ensure rXShape.is()

Change-Id: Ic5a78d3f650bff82ce8d86a62ecfc025ca2062e0
Reviewed-on: https://gerrit.libreoffice.org/57276
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit 10272122b2ace68add7d2b0191aa516558f8401f)
Reviewed-on: https://gerrit.libreoffice.org/57279
Reviewed-by: Eike Rathke <erack@redhat.com>

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - tdf#115524 Some branch bookmarks are not working 1

    With .ui dialogs, the Help system sends specific URL
    associated to the higlighted widget in the .ui dislog.

    Not every help page associated to the dialog has
    <bookmark branch="hid/<path to the dialog/widget"/>
    for all widgets of the dialog. As consequence, some URLs
    were not addressed and the default module entry page
    was displayed, instead of the dialog help page.

    The solution is to define a dumy bookmark '@@nowidget@@' to the
    help page associated to the dialog, and if the widget bookmark
    is missing in the help page then use the dummy target,
    thus offering a help page with the right contents anyway.

    This patch covers help pages for smath.

    Change-Id: I40b592271b0c336d4d3bacc33d2f3d19107ae702
    Reviewed-on: https://gerrit.libreoffice.org/57426
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-1'
  - tdf#115524 Some branch bookmarks are not working 2

    simpress and sdraw modules

    Change-Id: I5d498cb7ab504277a54f6d002e1f8e88ce78ab0c
    Reviewed-on: https://gerrit.libreoffice.org/57427
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Resolves: tdf#118624 let RAND() in array/matrix mode fill a matrix

... instead of only top left that is referenced for other
elements.

Change-Id: I718946d7e4327b152e2d9f80712395fd7ab67dee
Reviewed-on: https://gerrit.libreoffice.org/57235
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 8afccbd129ecda81ff00dd2c6e5e10af254ae0ef)
Reviewed-on: https://gerrit.libreoffice.org/57247
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#118620 - avoid out of bounds iterator for end of sheet pivots.

Change-Id: I2ddcf56dc94175718739611f0791558fda87b1ba
Reviewed-on: https://gerrit.libreoffice.org/57358
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit d3387b38fe0eea3fb7ac630c026f02986e8dafc4)
Reviewed-on: https://gerrit.libreoffice.org/57383
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#118063 Impress: Deselected spacing remained checked

The state of the attributes for spacing are now read and set
correctly.

Change-Id: I661c00e247b55c64ea39c03db77dab9fa0775852
Reviewed-on: https://gerrit.libreoffice.org/55455
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 5b72382516d94bc27321461297ded92f8af8112d)
Reviewed-on: https://gerrit.libreoffice.org/57388
Tested-by: Jenkins

SvTreeListBox::DoubleClickHdl: SwContentTree more, tdf#115950 related

This is a combination of 2 commits.

SvTreeListBox::DoubleClickHdl: SwContentTree more, tdf#115950 related

(cherry picked from commit 60c2f6d7f167cc313b33d29531f8c7320903e78d)

SvTreeListBox::DoubleClickHdl: SwContentTree more, tdf#115950 related

(cherry picked from commit 446f9cf176038881af166e46489bb1880b22174d)

86b5275484754b222698fb8c4540ff66bd6c962a

Change-Id: Id3d1e070467bdb681919b380c0d2ace78ebd388d
Reviewed-on: https://gerrit.libreoffice.org/57342
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins

SvTreeListBox::DoubleClickHdl: DbRegistrationOptionsPage more, tdf#115950 rel.

Change-Id: I820ce28a4df108f17cbb65210834acae6b0f8946
(cherry picked from commit 1a5ef55b7de60131efa7a831309186b29cb6214e)
Reviewed-on: https://gerrit.libreoffice.org/57355
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

tdf#101778: Disable crop and rotate in read-only mode

Change-Id: I26d6e98a768d40e97209e0a646cbb834d2635f9a
Reviewed-on: https://gerrit.libreoffice.org/57158
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit cdd373e593557984dcd90c94bbb9b053655c1b83)
Reviewed-on: https://gerrit.libreoffice.org/57321

Make setPagePrintSettings() accept IsLandscape again

Regression from 80c35d97b9b3b60a091aae77de0ffef38cbf531a - invert
the check for boost::optional validity.

Change-Id: If4e041e1fe349c1fcb2c74b2e5780bf57300486f
Reviewed-on: https://gerrit.libreoffice.org/57309
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 0853b05b1fabb231a7d57d811c5a06ee542d3295)
Reviewed-on: https://gerrit.libreoffice.org/57316

tdf#118232 Allow load and insert of SVGs with no Geometry

Change-Id: Iaf3d6a0423c5f11dda1e623dd730af01dbd6551c
Reviewed-on: https://gerrit.libreoffice.org/57284
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
(cherry picked from commit 0613ce41da0b94bc481b94b8141afcf15df8abe7)
Reviewed-on: https://gerrit.libreoffice.org/57350

SvTreeListBox::DoubleClickHdl: SwCondCollPage more, tdf#115950 related

Change-Id: I179c791aac5eb522aefb3ce20931fe44dd7248c6
(cherry picked from commit 3d73f76a91260becf171ea77589190714577b267)
Reviewed-on: https://gerrit.libreoffice.org/57344
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

SvTreeListBox::DoubleClickHdl: Navigator return more to be done, tdf#117063

Change-Id: I2b232cd9ea791273e8a776bf88fa45ee0ad5edf0
(cherry picked from commit 08ac6e6f991cffcb1fed7bd1bb4ec67e94817507)
Reviewed-on: https://gerrit.libreoffice.org/57329
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

NB Implementation: fix Underline command and add CharmapControl

The new CharmapControl action will be used instead of InsertSymbol

Change-Id: I9a2e519fb7b8b773763b4c58f8aaa40e6af810b6
Reviewed-on: https://gerrit.libreoffice.org/57283
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 3ffd06f141f86a695deb8672a34b95f31f4d1b16)
Reviewed-on: https://gerrit.libreoffice.org/57289

tdf#117697 add missing section icon in search

Change-Id: Iea2b4a7c98a2751048dc2228ac550708bd22c238
Reviewed-on: https://gerrit.libreoffice.org/57318
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit c6dc541a59a22c59d23c43c3dfcf8ef2c96095a6)
Reviewed-on: https://gerrit.libreoffice.org/57323
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Menubar Impress: add missing icons to menubar

Change-Id: I5116e214ab64923c28dda4d10feab1193b5d9d31
Reviewed-on: https://gerrit.libreoffice.org/56978
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit eada59bd3383b1711f3a68030ad52c69746e810a)
Reviewed-on: https://gerrit.libreoffice.org/57281
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

tdf#116861: better default settings for minimize Presentation

Change-Id: I6d05cb5591791afc438bfe38f179aa26d6cee920
Reviewed-on: https://gerrit.libreoffice.org/57285
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 5442670e4c643ef476fe154df9a0d226b7252d3a)
Reviewed-on: https://gerrit.libreoffice.org/57290
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>