Public Git Hosting - LibreOffice.git/log

No need for own implementation of erfc() in OpenCL

The own code was copied from the C++ one we used to have in
sal/rtl/math.cxx but which was removed in
a62bc6a65abb47adb0e4caff7e38823c15b302fc. However, it did not work
correctly on some machines at least, like my AMD A10-7800 running
Windows 10. I was unable to figure out why not. This lead to OpenCL
being disabled by the Desktop::CheckOpenCLCompute() code we now run
early on startup.

Anyway, as OpenCL has erfc(), just use that.

(cherry picked from commit 4afa88f289de1150850b52d36f2345fd9a9fbc1e)

Change-Id: I7ef7d493fe60c695b2dad528fe0be6ebf0e8a79e
Reviewed-on: https://gerrit.libreoffice.org/27543
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Resolves: tdf#59896 ww6 plcf generation reversed check

regression since...

commit 69e040a59e1c6497b606da8a27e8f605edd041bb
Author: Caolán McNamara <caolanm@redhat.com>
Date: Sun Jul 17 00:19:00 2011 +0100

check seeks, check available size, pointers to ref

(cherry picked from commit 99833c2d6c9882bfad17e3e7fb659f5a81184a3f)

Change-Id: Idfcde46959e5693d200a91a619e7196f00f40ca0
Reviewed-on: https://gerrit.libreoffice.org/27431
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Resolves: tdf#101096 remove the "H after M" rule

wrongly introduced with c9ed6e832213129cc579c1c309ce9dbd3593c57a

Change-Id: Ic6c9c404ad0af11eb5d638f453150ee0da60e633
(cherry picked from commit c6e7dbaaa471861dcf76186ed3978ac95f81256e)
Reviewed-on: https://gerrit.libreoffice.org/27529
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Related: tdf#101057 allow java update version number > 99

Change-Id: Icc37cf248fbf35f108eb5bbb25c36fbd54a9fe85
(cherry picked from commit 64d3270a89fd88d4d0cf70329af2c66f722fd95e)
Reviewed-on: https://gerrit.libreoffice.org/27426
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: tdf#101054 crash on options->path with non-native file picker

regression from...

commit 3bbc0574d78d129359638b74612de2f93419eeb0
Author: Caolán McNamara <caolanm@redhat.com>
Date: Tue Jul 5 10:16:51 2016 +0100

Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker

only clear the xFolderPicker immediately in the non-async case

Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf
(cherry picked from commit c1bd3156cf66318023f36d81ce809a38072588e4)
Reviewed-on: https://gerrit.libreoffice.org/27420
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Need to try to avoid TDR also with NVIDIA cards on Windows 7 or earlier

(TDR is Timeout detection and recovery, was introduced in Vista.)

Change-Id: If88f8e9e2aff2a5ffd633607ee6aebb5614c5caf
Reviewed-on: https://gerrit.libreoffice.org/27523
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Resolves: tdf#100847 also external svEmptyCell is 0 in numeric context

Regression of 243f19a1878d52a4074b59041dc3bc57ab84e417 that now
differentiates between numeric and string content of external
references' cells.

Change-Id: I7a9635357cc7651353067a38f9ac8bc295f88546
(cherry picked from commit 89a5464a21046821648ec77f03db8316ceb4e6f8)
Reviewed-on: https://gerrit.libreoffice.org/27111
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 9c30e2aab23e34ba91dbe80b7dd5e5c352bbaeb0)
Reviewed-on: https://gerrit.libreoffice.org/27373

Resolves: tdf#98778 fix parsing of exponents

regression from...

commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d
Date: Tue Mar 19 23:23:16 2013 +0100

resolved rhbz#919020 Basic CDbl() and CSng() scan localized number

Change-Id: I96535fd9bc9ec59d6e07739a3118c96eb2d8bd05
Reviewed-on: https://gerrit.libreoffice.org/27342
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 2aed0d49d7891b9360916b65771222810aeeac96)
Reviewed-on: https://gerrit.libreoffice.org/27350
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 43d1f9bfd4300e8bf5bcb631dcc2d849b4490d3a)
Reviewed-on: https://gerrit.libreoffice.org/27351

Resolves: tdf#100764 check row when determining bounds for deleted range

Regression introduced with a2e591e26549294cdb07eb685d4069343404d898 for tdf#86502

Change-Id: I493c458faedccfd6e2ddf849073a52661ef2e4d0
(cherry picked from commit ab1b351840160655a9f0caedbb35e9fdf203c5a0)
Reviewed-on: https://gerrit.libreoffice.org/27248
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

protect against empty m_aTableManagers stack

Change-Id: I29fecc5e0efb3b3d907f0c6505d42818fa464ffc
(cherry picked from commit 9d76d9d9abb08788f2882612cfe6d0df6e19af39)
Reviewed-on: https://gerrit.libreoffice.org/27281
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 808d72592aa6e9a9f9a8eddd4dada0fa9f14749c)
Reviewed-on: https://gerrit.libreoffice.org/27320
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

update credits

Change-Id: Ie49cfb83d86e85b593958fc4048022f71c351267
(cherry picked from commit bd894e5a7b9a9d6a3d3e4ea668bfea050ef39bae)
(cherry picked from commit 8a22eab3b59d7188bf40f0fa3b25c2893cd06f85)

bump product version to 5.1.5.1.0+

Change-Id: I82beb3fd1b431e7412542e26b91856a4872461e5

Branch libreoffice-5-1-5

This is 'libreoffice-5-1-5' - the stable branch for the 5.1.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 5.1.x release,
please use the 'libreoffice-5-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I6a12a32745bbaaaddb1644f00a8726e8b91d463d

update credits

Change-Id: I6d1fbba2231faaf3ef64564705cf5b1fbcc8433a
(cherry picked from commit 1c54cbf5bd811423ddfc29bea321510a1533d7d9)

Updated core
Project: translations 53bddc131cb00fe59f9649ed95fe60f863618814

update translations for 5.1.5 rc1

and force-fix errors using pocheck

Change-Id: I9f8bdd9d17cc21529d463011bee01b73c63a4624

tdf#100883 - opencl impls. that use SEH are still bad.

Amazingly we fell-back to the old calculation path for
crashes in older LibreOffices.

Change-Id: Ia182f7a25c5560b68494d5cdd68e02925bfd5845
Reviewed-on: https://gerrit.libreoffice.org/27164
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker

(cherry picked from commit 3bbc0574d78d129359638b74612de2f93419eeb0)

Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1
Reviewed-on: https://gerrit.libreoffice.org/26942
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Resolves: tdf#88396 switching to sidebar panel will toggle it *off*...

if its already visible.

This solves tdf#88396, but I did this fix originally for....

on switching to slide layouts panel move into slide layout context

i.e. exit current textbox edit and shape selection

(cherry picked from commit 05aaef55252bc9f90cbbcc1967c38ab9a5a6c798)

OpenThenSwitchToDeck actually *toggles* deck visibility

so rename it to that and add a OpenThenSwitchToDeck that actually
does that, using the Toggle varient as the callback from the
sidebar button which toggles the current deck on/off

which retains the features of

// tdf#67627 Clicking a second time on a Deck icon will close the Deck
// tdf#88241 Summoning an undocked sidebar a second time should close sidebar

but means that calls to OpenThenSwitchToDeck from e.g. slide layout
don't auto close it if that deck is already open

(cherry picked from commit b81daea4a78083def286fa2d5360b152b7a703fd)

3e3724626b93447a7ab6bc7032e9c6839dabcf55

Change-Id: I16a2fca158cb4caab7b6bd001742df698735dd2b
Reviewed-on: https://gerrit.libreoffice.org/27071
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

tdf#99090 docx export page-break only inside a paragraph

If a paragraph hadn't been started yet, a w:r was being written directly in
the /document/body which caused MSWord to complain about a corrupt document.

Reviewed-on: https://gerrit.libreoffice.org/26771
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 07fb94655f4745eb4e80bf6e8d4cdd95371f23bb)

Change-Id: Ie7f629869aab0f3d2405660a033c3f23bbd6baca
Reviewed-on: https://gerrit.libreoffice.org/27121
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...

by the user with GDK_CORE_DEVICE_EVENTS=1, and so manage to disable their wheel
scrolling

(cherry picked from commit 7dfd50f947671d79b9119f10259857700d5728d8)

Change-Id: I7df63f738983c90dea75b9f43a36133910446aba

Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...

better fix, if we listen to the eventbox we get either SMOOTH scrolling
or not smooth events, not both. We get SMOOTH when supported, and not
if not supported so no need to reintroduce the miserable hack, which
doesn't work under wayland anyway

Change-Id: I993e71d3553322425a506cd93d812efe081bf3c9
(cherry picked from commit 053a843bccaef2d2323be3ddff6217c592a4c5db)
Reviewed-on: https://gerrit.libreoffice.org/26646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Resolves: tdf#100813 crash during pagination of particular docx

Change-Id: Id2c99cc6c5fe4c3a5bcf3c0b3f16b603cdd46239
(cherry picked from commit f374e01af32c7752b31455642e7d76f2056a2aeb)
Reviewed-on: https://gerrit.libreoffice.org/27051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

loplugin:staticcall

Change-Id: I800eef0517f063ff7e08a95de9da268fb0e9d621
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/27160

desktop: validate OpenCL drivers before use.

OpenCL validation needs to happen before drivers are used in
anger. This should isolate any crashes, and/or mis-behavior to
We use app version, CL driver version and file time-stamp to
trigger re-testing the device. If anything fails: hard disable
OpenCL.

We use an opencl validation sheet (cl-test.ods) and install it.
It is a minimal CL set - it requires a very short formula group
length, and combines several CL functions into few formulae to
test more.

The sheet structure, in particular the manual squaring / SQRT is
necessary to stick within the default CL subset, and ensure that
formulae are CL enabled from the root of the dependency tree up.

Reviewed-on: https://gerrit.libreoffice.org/27131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit c44726c48228d9c6a5960e302b1c0bd16b0099c4)

+ opencl: bail out early in missing OpenCL case.
(cherry picked from commit 605a5dc088385ad21c33028d8107125c0316ddb1)

+ Remove bogus dependency from opencl to configmgr
Since f41eb66302208f384a475fb20c98b6d1b0676cb6 "opencl: OpenCLZone, detect CL
device change and disable CL on crash" vcl links against opencl (so indirectly
linked against configmgr), which caused CppunitTest_configmgr_unit to include
the configmgr object files both statically (through
gb_CppunitTest_use_library_objects) and through the linked-in configmgr dynamic
library, which in turn caused ASan builds to report an ODR violation for a
doubly defined 'typeinfo name for configmgr::Access'.

(cherry picked from commit 9c711f05fa10dc70e4257a1f48d43f539353541a)

Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3
Reviewed-on: https://gerrit.libreoffice.org/27146
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

opencl: OpenCLZone, detect CL device change and disable CL on crash

Guard OpenCL calls with OpenCLZone, so if a OpenCL call crashes we
detect this and disable OpenCL so next time the user doesn't encounter
the crash at the same calculation because he has a broken OpenCL
drivers. Similar has been implemented for OpenGL with good results.

Additionaly we persistently remember a known good OpenCL device ID and
driver version so we can match this and perform calculation tests when
they change. This is to ensure that the selected OpenCL device performs
as we expect. In this commit the calculation tests aren't included yet.

Remove complex static initializer in opencl wrapper library.

Reviewed-on: https://gerrit.libreoffice.org/27064
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit f41eb66302208f384a475fb20c98b6d1b0676cb6)

Change-Id: I1a8b81ee31298731efcf63dc6a476955afc035e9
Reviewed-on: https://gerrit.libreoffice.org/27103
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

rhbz#1351292 correctly set edit mode

... when switching between different shells, e.g., from Outline to Slide
master.

Change-Id: I22ef6f6cac73c52fb1bedd97e653b4b57c5a7a24
(cherry picked from commit b0535f3944975c1f6cdadc149d70502843331f86)
Reviewed-on: https://gerrit.libreoffice.org/27110
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#100463 tolerence in contour editor doesn't work

probably since

commit f51f03a46102333bac6a7fe06bc8538492f413a5
Author: Stephan Bergmann <sbergman@redhat.com>
Date: Wed Mar 5 12:24:14 2014 +0100

Do not needlessly truncate MinMax argument before comparison with bounds

Change-Id: I5c92f0af3e05ad68ed88fa860b36e8426e160bf9
(cherry picked from commit d5bd18ecac5806b7b4e39a1919b6b56df0f94ce3)
Reviewed-on: https://gerrit.libreoffice.org/27102
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

tdf#99512 - opencl - restrict scope of vlookup optimization to doubles.

Change-Id: Iab7316cb167f34c13adafe142af0fdd73eb7d04c
Reviewed-on: https://gerrit.libreoffice.org/27100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit dead5dc1ae3baab5e25d641322d138dd3d242bff)
Reviewed-on: https://gerrit.libreoffice.org/27105
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

tdf#100753 propagate error with VAR and STDEV functions.

Change-Id: I1b3ece177f5586f5cd64a34d16193d01d4bd5bd9
Reviewed-on: https://gerrit.libreoffice.org/26979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit b9c9bf666b4eb7ee4568fe155a2c8b50a02c4ad5)
Reviewed-on: https://gerrit.libreoffice.org/27061

Resolves: tdf#100713 on cancel curData points to deleted parents vector entry

Change-Id: Ic2f313c357ce9526eb045791e2d27451e52a7572
(cherry picked from commit 17cb84338d6921d012af1e1245f434f90bc25142)
Reviewed-on: https://gerrit.libreoffice.org/27041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

starmath: Fix missing negation

which was a regression from fa614231733800f4a961b77e36c86f8840d12251.

Change-Id: Ia7bab72dbd6f82519024809cf6384e1442a02327
Reviewed-on: https://gerrit.libreoffice.org/27033
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
(cherry picked from commit 2fcb8022a22b55b6680af57f2b101d56a3d88e36)

Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...

the master page is not the sole owner. Which happens when copying
and pasting slides which bring along a duplicate master page to
an already existing one, and the attempt to remove the duplicate
strips the fill properties from the shared stylesheet in use by
the other

regression from...

commit b876bbe2cacce8af379b10d82da6c7e7d229b361
Author: David Tardon <dtardon@redhat.com>
Date: Tue Apr 26 09:17:11 2016 +0200

rbhz#1326602 avoid exp. bg bitmaps from deleted slides

(cherry picked from commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1)

Change-Id: I91fb8f622a0e35741ecc37cef14fc93199bb730b
Reviewed-on: https://gerrit.libreoffice.org/26976
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Resolves: tdf#100692 crash in sidebar on deleting image from writer

stumbled on this in passing and it has the same bt as

http://crashreport.libreoffice.org/stats/signature/vcl::Window::setPosSizePixel(long,long,long,long,PosSizeFlags)

Change-Id: I1f19275029b05f353dfa823a2ff435e5045250a6
(cherry picked from commit 675c8faefd8756f7c43312f23eb341797bcbca4d)
Reviewed-on: https://gerrit.libreoffice.org/26805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

tdf#100295 try to cover second place in curl using GetTickCount64

Conflicts:
external/curl/ExternalProject_curl.mk

Change-Id: I08e51f70c7b0c92a8c1b8b06e7eb2f1437e2f3f4
Reviewed-on: https://gerrit.libreoffice.org/27027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cui: add calculation mode to Help->About.

Reviewed-on: https://gerrit.libreoffice.org/26964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit adc3932dfc4fe763b7db0af8843b01614bdc6aa2)

Change-Id: I4765436bed8a58c5097afcf7dce768d3ec325015
Reviewed-on: https://gerrit.libreoffice.org/27004
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Updated core
Project: dictionaries 0f1ab1fdfce99714b9af6090a0191facb21735b7

Update pt_PT dictionary to version 16.7.4.1

Change-Id: If00be0e9c05c5cf1cc67427eed723484ad33e6d2
(cherry picked from commit a4a8bb897b5e5dc0b90579b73ed071d47f66f699)
Reviewed-on: https://gerrit.libreoffice.org/27000
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#100770 crash on loading specific docx

use same safeguards as RemoveLastParagraph does

Change-Id: I43ed4eb28f44654054fd266bc464840af7014fea
(cherry picked from commit 000263f799d4aa9ad21e63f474def55438ce601e)
Reviewed-on: https://gerrit.libreoffice.org/26944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

update credits

Change-Id: Id597c51484924f0398bbb30ba419809beb9a96b5
(cherry picked from commit 296c74f61e5534898507529c8ebdd20d6dec73b9)

Resolves: tdf#90285 do not reuse the same StartListeningContext

... that after UpdateInsertTab and related may point into broadcasters'
ColumnBlockPosition that have been shifted to the next sheet.

Change-Id: I6f657021b6102cec427734a8ff3105f0c4309a7a
(cherry picked from commit dd7a2c95b86d158be8d0637bdff13b9a0ed9954b)
Reviewed-on: https://gerrit.libreoffice.org/26959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#90285 during sheet copying the old sheets retain their old index

at the point that ScDocument::CopyTab calls StartListeners so when

void ScColumn::StartListening(sc::StartListeningContext& rCxt...

calls rCxt.getBlockPosition(nTab) it calls it with the old nTab index
in ScDocument::maTabs, so the return block position is not correct.

Here I bubble down the requested ScAddress and use its Tab/Col/Row
members rather than trust the members of the indexed-into elements

Change-Id: I291e8c1146c2caa4d0976780b1ee6bcc41994e3c
Reviewed-on: https://gerrit.libreoffice.org/26552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 2511e272481172b439d167fd8b09d14c755f223d)
Reviewed-on: https://gerrit.libreoffice.org/26958
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#98710 check the font is bound, substitute FON fonts

If we can't bind the font then we can't proceed with rendering
and caching of the glyphs. This may avoid the crash but the font
won't be drawn. This happens for old Windows 3.1 bitmap fonts in
FON format which Direct Write doesn't support. So in addition
substitute "Script" and "Roman" FON fonts with "Times New Roman".

Reviewed-on: https://gerrit.libreoffice.org/26885
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit b5cd1220b849a9759dd4446032a7e1affbf151f2)

Change-Id: I16b480399b47989738a703ad84c0398493f9f4e3
Reviewed-on: https://gerrit.libreoffice.org/26970
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

explicitly disable partial cell shift with change-tracking, tdf#73335 related

... in ScDocFunc::InsertCells()/DeleteCells() that can be reached via
API but ChangeTrack produces a SC_CAT_NONE action because the partial
shift is not handled. UI slots are disabled for this.

Change-Id: Ie0f992b05753bb1467d3f7a80263714bfcc1a2d7
(cherry picked from commit 9f8e2065c42f1724ac7a24f1bb0531e8c954698a)
Reviewed-on: https://gerrit.libreoffice.org/26923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#91995 copying cells to undo doc shallow copied note pointer

maybe UpdateCaptionPos isn't needed if we do it this way and deep
copy it.

surely we have to copy the note here, otherwise it gets deleted by both the
source and destination document

Change-Id: I6bc885c45b2938d0c775572c48642e67cd1ef5ca
Reviewed-on: https://gerrit.libreoffice.org/26913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 7566851d653ec052e9b7baa98ec2a993328f84e4)
Reviewed-on: https://gerrit.libreoffice.org/26940
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#73335 sc: ODF export: ignore ScChangeAction SC_CAT_NONE harder

ScChangeTrackingExportHelper::WorkWithChangeAction() must not add
attributes when it does not export an element.

Change-Id: Ia6625b73114ab8bf93c4b7a31b484d11bef2fde9
(cherry picked from commit ed913ce8352dc4ad9f4688180a9b27d02e8f524f)
Reviewed-on: https://gerrit.libreoffice.org/26918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Step towards disposing of ScDataFormDlg properly

There were some VclPtrs hiding inside std::vector (twice), so fix
that, but the destructor is still not called (getting Window::~Window
inconsistency assert). With this patch however the screenshot cppunit
test no longer fails

Thanks noelgrandin for help

Change-Id: I8b46c4608cbab2070e36ef4abec226bcd997425e
Reviewed-on: https://gerrit.libreoffice.org/26772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit ec6956491a0c6553a9fb91f64c6ceb7cd8e8aa52)

fix Window::~Window: inconsistency in top window chain leak

Change-Id: I4f32b77a4b107e5315e0c2bc9b20db897135c8b0
(cherry picked from commit 937cbdb579820aa1dd0526682df1ea98a34168c5)
Reviewed-on: https://gerrit.libreoffice.org/26792
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

vcl: GTK: fix libstdc++ "irreflexive" assert

/usr/include/c++/6.1.1/bits/stl_algo.h:4737:
Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).

GdkRectangleCoincident is clearly not a less-than operator as required
for std::sort.

Change-Id: If2e65d420dc8cdf0707081361a40d4eaea28424e
(cherry picked from commit e2b267b1906817cc45f0e4896bed58cff5b6b0f9)
Reviewed-on: https://gerrit.libreoffice.org/26767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

boost: suppress GCC6 -Wplacement-new=

function_base.hpp line 308
error: placement new constructing an object of type "boost::..." and
size ‘16’ in a region of type ‘char’ and size ‘1’

Change-Id: If905d56bd21dd30a957b50fa3d5eed3a63899d62
Reviewed-on: https://gerrit.libreoffice.org/26769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

gbuild: recognize newfangled screen TERM=screen.xterm-256color

Seems to have changed from Fedora 23, where it was just "screen", to 24.

Change-Id: I9078c337093d12d62e9afe10b1f02aaf346d4b43
(cherry picked from commit 4dcba01d97b72db35885c505e647425059740a4c)
Reviewed-on: https://gerrit.libreoffice.org/26766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#100641 correct OOXML function name is EFFECT instead of EFFECTIVE

(cherry picked from commit ed5bcef57b678cb92c68bf842a72e50f4dd1e2ea)

accept EFFECTIVE as EFFECT in OOXML import

(cherry picked from commit f3f89f4f3180b0fd63c5290c665894c6a27f2ae2)

18a914972d69a37e9dcf5b18ffbea9177004dad7

Change-Id: Ieb7484afe210e378efd43ba3a181cd90d29619b9
Reviewed-on: https://gerrit.libreoffice.org/26704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

external/firebird: Adapt to GCC 6

...which switched defaults from C++03 to C++14, so causes some errors now.

Curiously, the throw(std::bad_alloc) vs. throw-anything mismatch between the
global operator new replacements and the standard headers is OK for GCC only
when there is no further declaration in between the standard header and the
replacmenet definition.

Change-Id: Ib54727fecf4ad07426b811a9cc04b08ea80e59dc
(cherry picked from commit 3179e8f7e6ce550bbe766ed730e68b0374944dd5)
Reviewed-on: https://gerrit.libreoffice.org/26768
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

tdf#100222: Show the dialog just once even if both toggles were changed

Change-Id: If6058d68f80ebc3e235f0a681cfe3240985e2429
Reviewed-on: https://gerrit.libreoffice.org/26697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

tdf#75387: Don't case-fold strings for formula group calculations

There should be no need for it as far as I see. Possibly it made some
sense back when we thought we could use OpenCL for operators and
functions that are supposed to ignore the case of strings they
handle. But we hopefully should never try to use OpenCL for string
data nowadays anyway. And actually, the case-folding ended up
affecting strings handled by the so-called software interpreter. For
the tdf#75387, the sample sheet worked fine when OpenCL was enabled.

Change-Id: I1c170ebf09551fea0964f394cdb3c65079672257
(cherry picked from commit f948dce856d51704e1962553198015dbebb6e527)
Reviewed-on: https://gerrit.libreoffice.org/26746
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

tdf#96540 dragging between sheets can change the current cursor position

so the at position at time of drop may not be that at the start of
the drag.

So set the current cursor position to ScTransferObj when the drag starts
and retrieve it later

Related to:

commit ac3b66057ba677903b6de354317417b267be0fa0
Author: Kohei Yoshida <kyoshida@novell.com>
Date:   Thu Sep 16 11:09:29 2010 +0200

    calc-selection-fixed-cursor.diff: Migrated

    n#502717, i#21869, i#97093, when making selection, don't move the cursor position

and

commit c433fa0639ccf5caeb0c128c8a3794322e2a1c81
Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date:   Fri Jul 6 02:04:44 2012 +0200

    adjust the calculation of the cursor pos if ALT is used, fdo#48869

    Change-Id: I6316717c860d999270aa7f0fb50af5f6dfc7efd7

I haven't used SetSourceCursorPos everywhere a ScTransferObj is created, just
where its created through a drag event

Change-Id: I50c36b4a2ba45426edebc1f1dfa5e262db3c5d03
Reviewed-on: https://gerrit.libreoffice.org/26512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit f9b46bbd2446a6c9a0aaab31016536bda4a77294)
Reviewed-on: https://gerrit.libreoffice.org/26538
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Resolves: tdf#100303 Report crashes on close of conditional formatting dialog

Condition multiply inherits so the Builder::disposeBuilder call was missed

and prenotify occurs during ::dispose when there is no m_pConditionPlayground
anymore, so m_pConditionPlayground == 0 where pPlaygroundCandidate is 0
passes, so a random widget gets cast to somethings its not, hence the bad
cast exception

Change-Id: I6d081dd55df1a68ab893294858e1ab0054d5e049
(cherry picked from commit 547e4b3a80708600edbc3f5669b4428877b5a951)
Reviewed-on: https://gerrit.libreoffice.org/26569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

tdf#98515: Bail out early if kernel would have ridiculously many parameters

The Right Thing to do would be to compare the accumulated kernel
parameter size against the CL_DEVICE_MAX_PARAMETER_SIZE of the device,
but let's just do this sanity check for now. Bail out if the kernel
would have more than 50 parameters.

Calculating the accumulated kernel parameter size would be more
complicated and I don't want to touch this code more than
necessary. The kernel compilation will fail anyway if the size of
parameters exceeds the limit and this sanity check is just to make us
bail out a bit earlier.

In tdf#98515 the slowness seems to indeed be caused by the OpenCL code
generation , and there the number of parameters was 999, so this
sanity check does fix the slow loading issue (I checked).

(cherry picked from commit a48aefcae40663b63005d49a04fc7b89a473d613)

Change-Id: Iead6dfb94ec8e7b2968ffed9423f0f9522a10ce9
Reviewed-on: https://gerrit.libreoffice.org/26703
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#100495 sw: Exchange Database shouldn't delete the created odb file

(regression from f01f31201f9b26b3071ab25f9a5a3a0311ff7423)

Change-Id: Ie5b83a82711229bda045b7ef7a9167cfd873f616
(cherry picked from commit 5a042dad2779eefc76269e14b888bd84df590aac)
Reviewed-on: https://gerrit.libreoffice.org/26723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#100105 sw: RTF export: fix empty hyperlinks

For empty hyperlinks the EndURL() is called immediately after StartURL()
Due to the way the various buffers are written, the group closing braces
are written before the groups are opened, which is rather invalid.

Using the m_aRun buffer instead of m_aStyles appears to fix the problem.

(regression from b8907bf3d3b37c686a414ffbbd2d732348aab5b9)

(cherry picked from commit b4855bd63c05096df1a2da339133f243bb30d902)
Reviewed-on: https://gerrit.libreoffice.org/26336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 744bd590fd2c39638e8df41a569cb2cc376e7450)

Change-Id: I6910e1afa0ee262ae0496cf1d3aa83ae3e537ad0
Reviewed-on: https://gerrit.libreoffice.org/26699
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#100411 start the flush timer when batching (PostBatchDraw)

When we batch a draw command we need to start the flush timer
(if not already started) as otherwise it could happen that we
won't flush the offscreen texture at the correct time or at all.
This fixes a problem with drawing of pop-up "help" text.

(cherry picked from commit e1296e295e7d4f1104d2c90b1f51d52251358bea)

Change-Id: I6afcf173c3ac517ed0612cd413d95e28c19faa81
Reviewed-on: https://gerrit.libreoffice.org/26630
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#100222: Inform user that a restart is needed after toggling OpenCL use

(cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797)

Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874
Reviewed-on: https://gerrit.libreoffice.org/26611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

package: fix exception handling in DeflateThread (related tdf#91807)

In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams
that raise exceptions in the DeflateThreads. Because the maximum
allowed number of threads happens to be 48, this results in an infinite
loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess().

(regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14)

In case an exception is thrown, don't re-throw it immediately, which
might cause trouble such as leaking all of the ZipOutputEntry instances
in m_aEntries.

(cherry picked from commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf)

sfx2: exception on storage commit is an error (related: tdf#91807)

For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows
embed::UseBackupException if there is a pTempFile, which (as the comment
claims) is "always now". This results in the temp file actually being
copied to the user-visible file and the SaveAs "succeeding", when it
clearly did not.

Also move the exception throwing to the end of ZipOutputStream::finish()
to avoid more memory leaks.

(cherry picked from commit 9084c11fb472f2024e609770ce922c911227e7a8)

Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11
Reviewed-on: https://gerrit.libreoffice.org/26618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#100460 queryContentCells doesn't count annotations...

since

commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094
Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date: Thu Feb 23 23:36:49 2012 +0100

remove mpNote from ScBaseCell

(cherry picked from commit 83f977c7f40d1a5fb975b8ce7c9958c992dba3f1)

Related: tdf#100460 GetNotesInRange doesn't count last cell in range

e.g. open document from tdf#100460 and select select A20:A21 and right click
and there is a hide comment entry. Shrink the selection to just A20 (which has
the comment in it) and the right click menu has no hide comment entry in it.

std::for_each(it, itEnd

means it < itEnd but here we want the rows indicated by

nStartRow <= nEndRow

so we need to increment itEnd by one to get the right range

(cherry picked from commit 84dc0157df9cb173ec74da2bd27507329efc3816)

Change-Id: I281a207e26aec8886b1f46b9279e1135b61586da
48e8c0748f520671e09f04b16961bf9729960317
Reviewed-on: https://gerrit.libreoffice.org/26614
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

VclPtr: svtools error message dialog doesn't dispose

Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2
(cherry picked from commit d531743ca34232aedc0b437a9ff5807dea8d51ed)
Reviewed-on: https://gerrit.libreoffice.org/26588
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

tdf#100451 convert texture buffer to 1-bit and 4-bit palette buffer

OpenGL doesn't support palettes so when the texture is created,
the bitmap buffer is converted to 24-bit RGB. This works nice for
showing the bitmaps on screen. The problem arises when we want to
read the bitmap buffer back (like in a PDF export) as we have to
convert that back to 1-bit or 4-bit palette bitmap buffer. For 4-bit
this was not implemented yet, on the other hand for 1-bit it was
implemented but it didn't take palette into account so the bitmap
was not correct (inverted).

This commit introduces a ScanlineWriter which handles writing
RGB colors to 1-bit and 4-bit palette scanlines. The class sets
up the masks and shifts needed to place the color information
at the correct place in a byte. It also automatically converts a
RGB to palette index.

Change-Id: Ie66ca8cecff40c1252072ba95196ef65ba787f4c
Reviewed-on: https://gerrit.libreoffice.org/26532
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/26534
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)
Reviewed-on: https://gerrit.libreoffice.org/26358
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Resolves: tdf#96251 address wizard crash when run from start center

Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281
(cherry picked from commit d6665da4eae15cf21eecaf048d1c9eb7381b3b99)
(cherry picked from commit 1cf6c67f629dd21a0fbcd223ef0dcdfabd4b6a9f)
Reviewed-on: https://gerrit.libreoffice.org/26408
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Resolves: tdf#90579 swap_single_to_multi_blocks is broken

when there is associated data in the src. Its copies those pointers
into the block that will appear in the destination. Then can destroy
the source block, which deletes the contents of those pointers, and
then inserts the new block which has dangling pointers to the deleted
data.

https://gitlab.com/mdds/mdds/merge_requests/2

(cherry picked from commit 9ec54e92407cd632c4e38317f914edd557835a86)
(cherry picked from commit 6114072a59cfff36218aea70e1b52fa4c3ba64b4)

Change-Id: Id9614d95652c8032b03cb5748a284917043d8d21
Reviewed-on: https://gerrit.libreoffice.org/26429
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

update credits

Change-Id: I98c62533785a72b88044fb36bda3edd010aa6bb9
(cherry picked from commit 614d20645065cab2467b7419707a1eda69992cdd)

tdf#100455 check for minimal dconf version

Change-Id: I8e164bb4afc221cefd93d519569cdefa4486349f
(cherry picked from commit 461e91ca91186c1ed23316127fffe4230e3aacd2)
Reviewed-on: https://gerrit.libreoffice.org/26539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#98955 hardware_concurrency not ideal for thread pools

A new static member getPreferredConcurrency added to
comphelper::ThreadPool to return a configurable max
number of threads.

By default the new function returns the hardware_concurrency
value provided by std::thread. When MAX_CONCURRENCY envar is
defined, the return value is limited to whatever is set there.

Three call-sites that used std::thread::hardware_concurrency
have been replaced with getPreferredConcurrency.

Unittests added to cover the functionality of the new member.

Unittests are capped to 4 threads.

Reviewed-on: https://gerrit.libreoffice.org/26254
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 60e75fb276778459f6055360646d879b8c615d83)

Change-Id: I3332e393a88a5ed436316fa712ed920a4b37f4af
Reviewed-on: https://gerrit.libreoffice.org/26394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

rhbz#1343752 fix view status in menu

... after commit 229fc164dc1773484b74eca016863cf68860e81b .

Change-Id: Ibfbbb86c81527f008b8e1cbe9d8ca3174a944931
(cherry picked from commit c4c7fe98b0f05329edf7930ff92b44892d4724e6)
Reviewed-on: https://gerrit.libreoffice.org/26500
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cppuhelper: fix use-after-free race in OWeakConnectionPoint

OWeakObject::m_pWeakConnectionPoint is returned from
OWeakObject::queryAdapter(), and stored in
OWeakRefListener::m_xWeakConnectionPoint.

This is cleared in OWeakRefListener::dispose(), called from
OWeakConnectionPoint::dispose(), called from
OWeakObject::disposeWeakConnectionPoint(), but it can happen that
another thread is in WeakReferenceHelper::get() and has copied
m_xWeakConnectionPoint onto the stack before the OWeakObject is
released and deleted, then calls OWeakConnectionPoint::queryAdapted()
after it is released, accessing the dead m_pObject.

(cherry picked from commit 131e604073f89e6c1dd54be88b94b7befd881f2e)

Change-Id: I7782e6fb7e07f5a48cf7064115217376714ba8e8
Reviewed-on: https://gerrit.libreoffice.org/26441
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Resolves: tdf#82532 parent mutex dtored before child dtor uses it

Mutex belonged to DisposeListenerGridBridge which inherits from
FmXDisposeListener, FmXDisposeListener dtor accesses a reference
to the parent mutex in its dtor, but the mutex has been destroyed
at this point.

Move the mutex from parent to child. FWIW these classes are on
the candidate list to merge.

(cherry picked from commit e841ed93d6c6d817be1f7fdc18ff971325c861cc)

(cherry picked from commit 1c0d1199fe02666de0d162f071ce7e6e812a23df)

Change-Id: Ic639eaed97c2b0625c368ed249f09920af37f94e
Reviewed-on: https://gerrit.libreoffice.org/26382
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

sw: speed up the navigator

The call to SwTextBoxHelper::findTextBoxes() in SwDoc::GetFlyNum() made
this so unbelievably slow that in a dbgutil build opening the navigator
on the bugdoc of tdf#94212 the UI freezes because getting all the fly
frames takes longer than the 1 second timeout.

Lets's not retrieve the flys one by one but instead all at once, which
makes it usable again.

Change-Id: Ic41c1648a82dcc3f758ae1b08bac6058f541f25e
(cherry picked from commit 5593d9e1422cbf8a122fa612713a832274d30559)
Reviewed-on: https://gerrit.libreoffice.org/26428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cppuhelper: WeakReference isn't thread-safe

... but its documentation claims that it is, which is partially
misleading, so fix both the documentation and the data race in
WeakReferenceHelper::clear().

This actually crashed in clear() in the multi-threaded ZipPackage code
on exporting the bugdoc from tdf#94212, presumably because clear()
races against OWeakRefListener::dispose().

(cherry picked from commit debe788bcf3ec258b6b95df3db1f7bfeba881be1)

Change-Id: I85665c11b8157e90d15e8263758e24e66efeb86c
Reviewed-on: https://gerrit.libreoffice.org/26427
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

tdf#100453 – bin/unpack-sources needs to be executable

otherwise building from source-tarballs fails when it tries to extract
fetched submodule tarballs

Change-Id: I75bcd6821e244ca2a3375ec2916ee7c38ec9844e
(cherry picked from commit 10f112376b5767aacef99aff239c87b17ac38d27)

tdf#79198 START CENTER: Close button doesn't reappear after being clicked

Change-Id: I23e3aed71eec85e8b8f0aceac125809fd56be4d5
Reviewed-on: https://gerrit.libreoffice.org/26399
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit 27bd030aa033565dfdff56c298c797c80cee5160)
Reviewed-on: https://gerrit.libreoffice.org/26416

crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6f

drop hint of previous window to get mouse wheel event
when that window is disposed in order to drop any
references to it immediately that happens to avoid
anything else lingering too late

move the VclPtr into ImplSVData alongside the rest of the things like this so
we can remove the static VclPtr which itself replaced a relatively harmless
static Window*

(cherry picked from commit bdfccfde308f0267965933a8273e6e9201a2c67c)
(cherry picked from commit 35205c6e3e2f85d9b7db935689ec949c98e7e431)

Change-Id: I1e172071b711b6e4ded9a813ee3de730d3dfdf38
Reviewed-on: https://gerrit.libreoffice.org/26337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

tdf#100275 sw: fix target node of bookmark copy

Replaces the defensive programming band-aid of
5c1a1d1c66aff497702abc20df5832fa348f1008 with a real fix.

The problem is that lcl_NonCopyCount() has some special case code
to ignore the first node in the target document, which erroneously is
executed for every bookmark, which results in the 2 bookmarks in the
bugdoc being created with nDelCount 1 and 2 so they land on the same
node, which is not allowed for cross-reference marks.

Extract the adjustment into a separate function that is called once.

(regression from 689962feae2054f965a7378c3408b0ccfad2bbd5)

(cherry picked from commit bc387975b11d87868884ec770a2a42a4f7092b5f)

Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c
Reviewed-on: https://gerrit.libreoffice.org/26291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#97501: crash in SwDBManager fixed

copy the connections to a temp container and iterate that because
disposing connections changes the data source params container

Change-Id: I06c59a19a6bcf97a541b32481d1d2a63f5c34032
Reviewed-on: https://gerrit.libreoffice.org/22027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
(cherry picked from commit 4426c20cf308f3bf7a2d3b33f9996687113c22e3)
Reviewed-on: https://gerrit.libreoffice.org/26304
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

/org.openoffice.Office.Writer/FormLetter/MailingOutput/Format is xs:int

...i.e., sal_Int32.  Regression introduced with
ba9acdf799bf556c8a20b1dc27eb116e23d481db "convert TXTFORMAT constants to scoped
enum".  (The problem with storing a sal_uInt8 in an Any is that sal_uInt8 ==
sal_Bool, so actually a Boolean Any is constructed---and configmgr will throw an
exception when trying to set that value for the "Format" prop.  The problem with
extracting a sal_uInt8 from a sal_Int32 Any with getValue/static_cast is that
it doesn't even read (only) the low order bits, but on big endian machines reads
the high order bits.)

This is a backported version of 25a60d19d56a4bdb4f1b6ef27d842f90617fcff8
"/org.openoffice.Office.Writer/FormLetter/MailingOutput/Format is xs:int" which
uses o3tl::doAccess newly introduced on master.

Change-Id: I654da713bbf78b3215de7a09056a5172fc204258
Reviewed-on: https://gerrit.libreoffice.org/26285
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit abca482aebeb01d516816b543a07edc1dd178240)
Reviewed-on: https://gerrit.libreoffice.org/26286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

update credits

Change-Id: Ie4c9f67d07d81c0724c206c3a309dd5ec68fb963
(cherry picked from commit 962b0aca0ee38e25364c6e2dee5267c213d8fc39)

Updated core
Project: translations 05976795240823d58b9f15bcbf6c84015338880d

update translations for 5.1.4 rc2

and force-fix errors using pocheck

Change-Id: I4574c1b2e1e4a0dbd1bb8c36cdbef009644d54fa

Resolves: tdf#90419 diminish precision error in Series Fill

There may be more elegant ways to accomplish this, go and find one..

Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6
(cherry picked from commit e89c0e4fb783bd36d5f5fea154ee8608e542dae4)
Reviewed-on: https://gerrit.libreoffice.org/26220
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#100342 fix order of weekdays in NETWORKDAYS

For the definition of working/weekend days, ODFF1.2 uses 0..6
for Sunday..Saturday. NETWORKDAYS used ISO ordering (Monday..Sunday),
but now complies with ODFF1.2.

Change-Id: I169433adfac5d66af979181c328658040d7ab77f
Reviewed-on: https://gerrit.libreoffice.org/26246
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit d81fa4eb3a8960c1a1280fdd07bafa29de8290d2)
Reviewed-on: https://gerrit.libreoffice.org/26270

check ExternalSingleRef token for svDouble type

... before accessing GetDouble(). Else convert the string.
The new assert() introduced in FormulaToken::GetDouble() virtual dummy
was hit by loading gnome334723-1.sxc

Change-Id: I144b0cabee3aac44d206d76a83b1c4d81ab4a02e
(cherry picked from commit 243f19a1878d52a4074b59041dc3bc57ab84e417)
Reviewed-on: https://gerrit.libreoffice.org/26261
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>

tdf#96887 vcl: stop using periodic timers on WNT

Every time the periodic timer fires, it does a PostMessage() to the
main thread. The main thread will only process the first message and
discard the rest anyway, but with a short enough timer and other
threads hogging the SolarMutex it's possible that the message queue
overflows and other PostMessage calls fail with ERROR_NOT_ENOUGH_QUOTA.

Try to avoid the problem by having the WinSalTimer always be a one-shot
timer; when it fires and the main thread processes the posted message,
it is restarted with the new due time.

This requires creating a new TimerQueueTimer because
ChangeTimerQueueTimer only works on periodic timers.

Change-Id: I816bd3fa5fbfbea4f26be8ff680a1c916618d3f9
Reviewed-on: https://gerrit.libreoffice.org/24024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/26257
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

tdf#96887 enhance SolarMutex AcquireWithWait for Windows

Currently the Windows-specific method ImplSalYieldMutexAcquireWithWait()
uses a messaging mechanism to learn about the SolarMutex being free again.
This is not reliable when the MessageQueue overflows (MS allows 10000
messages per queue). It is more safe to use MsgWaitForMultipleObjects.
This also allows to not only wait for the SolarMutex to be freed, but
also to detect when SendMessage() is used which needs to lead to a
reschedule to not block current Window handling.

Change-Id: Id317dda62aaa1fe7677d8d28929e6936e5a22705
Reviewed-on: https://gerrit.libreoffice.org/23921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Reviewed-on: https://gerrit.libreoffice.org/26256
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Resolves: tdf#92478 avoid crash on using scanner on windows x64

which appears to correspond to backtrace
http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d

(prevents the crash only, does not enable scanning on x64)

Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0
Reviewed-on: https://gerrit.libreoffice.org/26197
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 7c983445656e1f1942cf2d7398a77342004ed168)
Reviewed-on: https://gerrit.libreoffice.org/26248
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

tdf#83455 Remove color-inverted line images from Sifr

Change-Id: I3cee31526c0789e059730f303250eae0e79bf166
(cherry picked from commit ffac8e3a483c84de2961784fceac2b21aa39a18c)
Reviewed-on: https://gerrit.libreoffice.org/26214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: tdf#100272 row ally index is ROW_INVALID

which is < 0 so bad things happen, consider ROW_INVALID/COL_INVALID before
looking for a11y child at that index

(cherry picked from commit 0f32ba56a1e775e8ecd6c827ebd48f7f2fb51c81)
(cherry picked from commit 652026f0e2f9c323229151e854ad6591791e098e)

Change-Id: I16a9d86879e1a894c63932705c056268e98db7aa
Reviewed-on: https://gerrit.libreoffice.org/26186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Place help button on the left in dialog

The New folder dialog, that is opened by the Template Manager dialog
has now the help button on the left.

Change-Id: Iabc55a031247e1ea33887dffc929dde17549f8fb
Reviewed-on: https://gerrit.libreoffice.org/23740
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 82d14b4f9c086c48214445b8e49fdd748e13c05f)

The label of this dialog can grow very long…

… so place it above its associated entry.

Change-Id: I8fce05bef2cb6ea4589caed60f9384fb42170234
(cherry picked from commit 72cbcf97fadd46a6895797beb37aaa379e015855)
Reviewed-on: https://gerrit.libreoffice.org/26212
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

tdf#99795 drawAlphaBitmap should scale the bitmap if necessary

drawAlphaBitmap didn't use a high quality scaler for scaling
the texture but used the default scaling method in OpenGL (either
GL_NEAREST or GL_LINEAR, whichever is defined when texture
is created) which are low quality scalers - especially when
downscaling textures.

Change-Id: I6236b2ee92b9e5044b176a40a444027072b09b58
(cherry picked from commit 19baa61e1d7b140b9e24717f7080617ab3d324d4)
Reviewed-on: https://gerrit.libreoffice.org/26100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Related: tdf#99446 cairo text + xrender bodge

(cherry picked from commit 1d18db339242a535d956b7e944ad1488fd2b4fd8)

Change-Id: I926881bcfa4911f3d7f4899711be44a2f6d82026
Reviewed-on: https://gerrit.libreoffice.org/26087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Resolves: tdf#93135 can't resize shape with "resize shape to fit text"

These are regressions from...

commit 4a847bb4a2002d7f8f5854b7276ac67d369bdd3b
Date:   Sun Aug 2 21:20:48 2015 +0200

    tdf#93079:  "resize shape to fit text" state can't be disabled

    Wrong copy-paste

and

commit b2bae9b940fc34d2eecd7839e3cba1f41d111e87
Date:   Thu Apr 9 23:38:47 2015 +0200

    Related tdf#34467: Fit to Frame for text boxes is broken

    Wrong Copy-paste

Its turns out that there is *no* SDRATTR_TEXT_AUTOGROWSIZE property.
Only a SDRATTR_TEXT_AUTOGROWHEIGHT property

e.g. see CustomShapeProperties::UpdateTextFrameStatus of
svx/source/sdr/properties/customshapeproperties.cxx

"change TextFrame flag when bResizeShapeToFitText changes (which is mapped on
the item SDRATTR_TEXT_AUTOGROWHEIGHT for custom shapes, argh)"

So the inconsistency between

getting the itemstate of SDRATTR_TEXT_AUTOGROWSIZE
and then
setting/getting SDRATTR_TEXT_AUTOGROWHEIGHT
is better resolved by getting the itemstate of SDRATTR_TEXT_AUTOGROWHEIGHT

will have a follow up patch to remove SDRATTR_TEXT_AUTOGROWSIZE to show
its not used by anything

Change-Id: I8b8abde17c15761c621815ed2be62d6a8a5cd69a
(cherry picked from commit d1df071c3fc452817746a8daa13000d2df667aba)
(cherry picked from commit 65d1e5294c9f0d9300dbb92f6670cdcafa8a1ac2)
Reviewed-on: https://gerrit.libreoffice.org/26089
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes

Change-Id: I29863ca95e64ccd31795f78c29c89ff35009d718
(cherry picked from commit f120abb446bf3f5230ed06a3b148654dde36bb94)
(cherry picked from commit f7b0cbf1df98a1c42fe25cfdbd9977fba78347c8)
Reviewed-on: https://gerrit.libreoffice.org/26057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>