Version 4.4.2.2, tag libreoffice-4.4.2.2
Change-Id: Ia15c07821285a8239635f6421f6821a397f74315
Change-Id: Ia15c07821285a8239635f6421f6821a397f74315
bump product version to 4.4.2.2
Change-Id: I5211dcccf59f6857282153c49c1de0b626095370
Change-Id: I5211dcccf59f6857282153c49c1de0b626095370
tdf#90010 Partially revert "package: Do not bother with deflating jpeg images"
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when
the document is protected by password. Would be nice to fix properly later.
Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09
(cherry picked from commit ca5ff4559726455d0c8fbdd08cb35af3308492bf)
Reviewed-on: https://gerrit.libreoffice.org/15006
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit da651b6ccb47e82f71d890fc8bb9d6cf0201f289)
Reviewed-on: https://gerrit.libreoffice.org/15010
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when
the document is protected by password. Would be nice to fix properly later.
Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09
(cherry picked from commit ca5ff4559726455d0c8fbdd08cb35af3308492bf)
Reviewed-on: https://gerrit.libreoffice.org/15006
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit da651b6ccb47e82f71d890fc8bb9d6cf0201f289)
Reviewed-on: https://gerrit.libreoffice.org/15010
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Resolves: tdf#89958 filter ends with / does not end with correction
Regression of 8850633fe4cdac306c35caab1a0d14c13d9df864 String to
OUString and xub_StrLen to sal_Int32 conversion, it worked by accident
only anyway..
Change-Id: Id6fea7075949b98e58294d9fdaae4313f69f9b55
(cherry picked from commit 9e2e9453cbca9399e1c670b354cfc3c23d70307f)
Reviewed-on: https://gerrit.libreoffice.org/14922
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression of 8850633fe4cdac306c35caab1a0d14c13d9df864 String to
OUString and xub_StrLen to sal_Int32 conversion, it worked by accident
only anyway..
Change-Id: Id6fea7075949b98e58294d9fdaae4313f69f9b55
(cherry picked from commit 9e2e9453cbca9399e1c670b354cfc3c23d70307f)
Reviewed-on: https://gerrit.libreoffice.org/14922
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
tdf#89482 fix __refheading__ regression, set only CrossRefs as TOC.
bugfix tdf#68963 marked all __refheading__ bookmarks at TOC, but
those crossreferences were deleted if they are not recorded in
aReferencedTOCBookmarks. Redesigned the fix to include _Toc in the
crossreference name that is auto-generated, which is how MSWord
differentiates the markers.y
Change-Id: Ie11b90b1b933d275e4d59ee89f22ff527eb6c2ba
Reviewed-on: https://gerrit.libreoffice.org/14870
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
bugfix tdf#68963 marked all __refheading__ bookmarks at TOC, but
those crossreferences were deleted if they are not recorded in
aReferencedTOCBookmarks. Redesigned the fix to include _Toc in the
crossreference name that is auto-generated, which is how MSWord
differentiates the markers.y
Change-Id: Ie11b90b1b933d275e4d59ee89f22ff527eb6c2ba
Reviewed-on: https://gerrit.libreoffice.org/14870
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Make "Embedded Objects" frame expendable to fill space better
(cherry picked from commit b5aa8604ec39f7f8d573fe2dde94b7c7e70d93b8)
(cherry picked from commit 36c76e4731236c8044f757182954a7d8faabfb18)
Change-Id: I9b9335464c774bca13013576583877895d673592
Reviewed-on: https://gerrit.libreoffice.org/14832
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit b5aa8604ec39f7f8d573fe2dde94b7c7e70d93b8)
(cherry picked from commit 36c76e4731236c8044f757182954a7d8faabfb18)
Change-Id: I9b9335464c774bca13013576583877895d673592
Reviewed-on: https://gerrit.libreoffice.org/14832
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
bump product version to 4.4.2.1.0+
Change-Id: Icd0a963a0152ed4ca0e66e2e9de2d98ee7f61ed5
Change-Id: Icd0a963a0152ed4ca0e66e2e9de2d98ee7f61ed5
Branch libreoffice-4-4-2
This is 'libreoffice-4-4-2' - the stable branch for the 4.4.2 release.
Only very safe changes, reviewed by three people are allowed.
If you want to commit more complicated fix for the next 4.4.x release,
please use the 'libreoffice-4-4' branch.
If you want to build something cool, unstable, and risky, use master.
Change-Id: I8423702d1abb78d87f4e0e97cc11f664870d177e
This is 'libreoffice-4-4-2' - the stable branch for the 4.4.2 release.
Only very safe changes, reviewed by three people are allowed.
If you want to commit more complicated fix for the next 4.4.x release,
please use the 'libreoffice-4-4' branch.
If you want to build something cool, unstable, and risky, use master.
Change-Id: I8423702d1abb78d87f4e0e97cc11f664870d177e
tdf#89665: i18npool: speed up TextSearch::searchBackward()
There does not appear to be a good reason why searchBackward()
needs to call transliterate() on the entire passed string, so don't do that,
as in the previous commit for the other direction.
Change-Id: Iadfca806da89bf8825e5a3df7fcad64ea08d7f9c
(cherry picked from commit 666fb8b7bc210be6d785515bc7660e5a5d19b82e)
Reviewed-on: https://gerrit.libreoffice.org/14827
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
There does not appear to be a good reason why searchBackward()
needs to call transliterate() on the entire passed string, so don't do that,
as in the previous commit for the other direction.
Change-Id: Iadfca806da89bf8825e5a3df7fcad64ea08d7f9c
(cherry picked from commit 666fb8b7bc210be6d785515bc7660e5a5d19b82e)
Reviewed-on: https://gerrit.libreoffice.org/14827
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
tdf#89665: i18npool: speed up TextSearch::searchForward()
There does not appear to be a good reason why searchForward() needs to
call transliterate() on the entire passed string.
Restricting it to the passed range speeds it up from 104 billion to 0.19
billion callgrind cycles when built with GCC 4.9.2 -m32 -Os.
Change-Id: I440f16c34f38659b64f1eb60c50f0e414e3dfee8
(cherry picked from commit 806ced87cfe3da72df0d8e4faf5b82535fc7d1b7)
Reviewed-on: https://gerrit.libreoffice.org/14826
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
There does not appear to be a good reason why searchForward() needs to
call transliterate() on the entire passed string.
Restricting it to the passed range speeds it up from 104 billion to 0.19
billion callgrind cycles when built with GCC 4.9.2 -m32 -Os.
Change-Id: I440f16c34f38659b64f1eb60c50f0e414e3dfee8
(cherry picked from commit 806ced87cfe3da72df0d8e4faf5b82535fc7d1b7)
Reviewed-on: https://gerrit.libreoffice.org/14826
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
tdf#40835 add backward compatibility for ODFF function FDIST.
Change-Id: I611531e86363d6c2b4ccce1aa0f1a940693bc8d8
Reviewed-on: https://gerrit.libreoffice.org/14658
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Change-Id: I611531e86363d6c2b4ccce1aa0f1a940693bc8d8
Reviewed-on: https://gerrit.libreoffice.org/14658
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
tdf#53861 - add libGLU.so.1 and libXinerama.so.1 to rpm/deb requirements
only used for upstream packages/when epm is used (any auto-dependency
creation is disabled for those). Add two that might be missing in
barebone installations
Change-Id: I97c3af8cc8622c63ac831701e509097711822098
(cherry picked from commit 441523b0df8983fb34409a5f4e25dde571be1af7)
only used for upstream packages/when epm is used (any auto-dependency
creation is disabled for those). Add two that might be missing in
barebone installations
Change-Id: I97c3af8cc8622c63ac831701e509097711822098
(cherry picked from commit 441523b0df8983fb34409a5f4e25dde571be1af7)
tdf#89791: DOCX: don't save custom.xml if it's empty
Change-Id: I90f8e6c4de383b05345b8df9118000167bd20d2f
Reviewed-on: https://gerrit.libreoffice.org/14735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 97c9bc9fada9cdfff956101a4a5e264b4dba58be)
Reviewed-on: https://gerrit.libreoffice.org/14815
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Change-Id: I90f8e6c4de383b05345b8df9118000167bd20d2f
Reviewed-on: https://gerrit.libreoffice.org/14735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 97c9bc9fada9cdfff956101a4a5e264b4dba58be)
Reviewed-on: https://gerrit.libreoffice.org/14815
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
tdf#84102: Expose duplicated "level" accessible attribute.
There is no standard for this so some ATs will expect "level" and
others "heading-level"; we will expose both.
Change-Id: Ia935f7efdea11dc9be66fd9a54e1df0432c74662
(cherry picked from commit e697d9694a62b2943fa19b0fcd19e9b3354f6ad7)
Reviewed-on: https://gerrit.libreoffice.org/14808
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
There is no standard for this so some ATs will expect "level" and
others "heading-level"; we will expose both.
Change-Id: Ia935f7efdea11dc9be66fd9a54e1df0432c74662
(cherry picked from commit e697d9694a62b2943fa19b0fcd19e9b3354f6ad7)
Reviewed-on: https://gerrit.libreoffice.org/14808
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
tdf#89520 Make TOX creation more robust
The code is now more robust and will accept illegal arguments.
Change-Id: I43ae82b953cea845fb170aa7b6e8d42470ad4e5e
Reviewed-on: https://gerrit.libreoffice.org/14580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 4bdbea5447f36beb9cc33df173a89a49a9918290)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
The code is now more robust and will accept illegal arguments.
Change-Id: I43ae82b953cea845fb170aa7b6e8d42470ad4e5e
Reviewed-on: https://gerrit.libreoffice.org/14580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 4bdbea5447f36beb9cc33df173a89a49a9918290)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Fix issue in re-use of ScTokenArray objects from a TokenPool
The TokenPool::operator[] is used to initialise and take into use an object
from the pool. Which is a fascinating thing as such and probably not entirely
in good style. Anyway, the objects in the pool are of type ScTokenArray, a
class derived from FormulaTokenArray. The operator[] called the
FormulaTokenArray::Clear() function to initialise the object. This left the
fields added in ScTokenArray uninitialised, having whatever value the previous
use of the object had set. Which of course is bad.
In practice, this showed up in the handling of formulas in the .xls input
filter. If an earlier (or the first?) formula had happened to be one for which
we don't want to use OpenCL, the meVectorState of its ScTokenArray object in
the pool had been set to FormulaVectorDisabled. When the same pool object was
later re-used for another formula, it kept that same meVectorState, even if
there was no reason to. Thus formula groups that should have been OpenCL
accelerated weren't. This can have a significant impact on performance of
document loading and recalculation for large documents.
I added a function to ScTokenArray to clear (initialise) such an object, both
the FormulaTokenArray part and the ScTokenArray-specific part, and call that
instead. This fixes the issue.
I named the added function ClearScTokenArray() to make it clear that it is a
separate function. Sure, possibly Clear() should be made into a virtual of
FormulaTokenArry and overridden in ScTokenArray, and the overriding Clear()
would first call the base class's Clear(). But I can't be sure that there
aren't other calls of FormulaTokenArray::Clear() that *must* mean the base
class one. Better safe than sorry.
And of course, I did *not* want to name the function in ScTokenArray also
"Clear()", like in the base class, without it being virtual. That is horrible
style in my opinion, even if there certainly is precedence for such even in
the very same classes, i.e. the Clone() function...
Change-Id: I0e0e13e5ca705603005a1e0a46866f095cd2ac4d
Reviewed-on: https://gerrit.libreoffice.org/14824
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
The TokenPool::operator[] is used to initialise and take into use an object
from the pool. Which is a fascinating thing as such and probably not entirely
in good style. Anyway, the objects in the pool are of type ScTokenArray, a
class derived from FormulaTokenArray. The operator[] called the
FormulaTokenArray::Clear() function to initialise the object. This left the
fields added in ScTokenArray uninitialised, having whatever value the previous
use of the object had set. Which of course is bad.
In practice, this showed up in the handling of formulas in the .xls input
filter. If an earlier (or the first?) formula had happened to be one for which
we don't want to use OpenCL, the meVectorState of its ScTokenArray object in
the pool had been set to FormulaVectorDisabled. When the same pool object was
later re-used for another formula, it kept that same meVectorState, even if
there was no reason to. Thus formula groups that should have been OpenCL
accelerated weren't. This can have a significant impact on performance of
document loading and recalculation for large documents.
I added a function to ScTokenArray to clear (initialise) such an object, both
the FormulaTokenArray part and the ScTokenArray-specific part, and call that
instead. This fixes the issue.
I named the added function ClearScTokenArray() to make it clear that it is a
separate function. Sure, possibly Clear() should be made into a virtual of
FormulaTokenArry and overridden in ScTokenArray, and the overriding Clear()
would first call the base class's Clear(). But I can't be sure that there
aren't other calls of FormulaTokenArray::Clear() that *must* mean the base
class one. Better safe than sorry.
And of course, I did *not* want to name the function in ScTokenArray also
"Clear()", like in the base class, without it being virtual. That is horrible
style in my opinion, even if there certainly is precedence for such even in
the very same classes, i.e. the Clone() function...
Change-Id: I0e0e13e5ca705603005a1e0a46866f095cd2ac4d
Reviewed-on: https://gerrit.libreoffice.org/14824
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Also relative row references need to wrap around, like fdo#84556 for columns
Change-Id: I07400d6dead66ec437436b5ea8b49491f8048335
Reviewed-on: https://gerrit.libreoffice.org/14823
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Change-Id: I07400d6dead66ec437436b5ea8b49491f8048335
Reviewed-on: https://gerrit.libreoffice.org/14823
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Resolves: fdo#86493 Fix crash while scaling large bitmaps.
Fast bitmap scaling overflowed the LUT used by the nearest-neighbor algorithm.
When a bitmap has 46k pixel on a side and is enlarged, the scaling code
overflows the 32-bit long, resulting in negative indexes, which then segfaults.
This isn't as rare as it sounds. At least in web-view in writer the border/shadow
bitmap is as long as the document (which is an issue in its own right,)
which can overflow for large documents during scaling and segfault.
Reviewed-on: https://gerrit.libreoffice.org/14597
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c91bfb9ac7d110c5dca0ea34ec0e1668a985b34c)
Change-Id: I1ccf73d02469f6601a9a7e67b30524cb497cf6bc
Reviewed-on: https://gerrit.libreoffice.org/14809
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Fast bitmap scaling overflowed the LUT used by the nearest-neighbor algorithm.
When a bitmap has 46k pixel on a side and is enlarged, the scaling code
overflows the 32-bit long, resulting in negative indexes, which then segfaults.
This isn't as rare as it sounds. At least in web-view in writer the border/shadow
bitmap is as long as the document (which is an issue in its own right,)
which can overflow for large documents during scaling and segfault.
Reviewed-on: https://gerrit.libreoffice.org/14597
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c91bfb9ac7d110c5dca0ea34ec0e1668a985b34c)
Change-Id: I1ccf73d02469f6601a9a7e67b30524cb497cf6bc
Reviewed-on: https://gerrit.libreoffice.org/14809
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Revert "fdo#88547 allow inline date-arrays for array functions", tdf#89872
This reverts commit 104a1e641554be2e789758ae67c0e24620df8035.
A number sequence has to ignore all string and empty elements by
definition, see tdf#89872 for an example regression, further affected
are all functions that use ScInterpreter::GetSortArray() which in turn
uses ScInterpreter::GetNumberSequenceArray()
(cherry picked from commit 18de9b1de1aa404b3ca12e2018e5e5e220dd9786)
This reverts commit 104a1e641554be2e789758ae67c0e24620df8035.
A number sequence has to ignore all string and empty elements by
definition, see tdf#89872 for an example regression, further affected
are all functions that use ScInterpreter::GetSortArray() which in turn
uses ScInterpreter::GetNumberSequenceArray()
(cherry picked from commit 18de9b1de1aa404b3ca12e2018e5e5e220dd9786)
tdf#84102: Expose XAccessibleExtendedAttributes through ATK
Those attributes contain a lot of interesting properties, among them
the heading level which fixes this bug.
Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b
(cherry picked from commit 1e6515e64cb4a40071e09d5df000a94f96311ea1)
Reviewed-on: https://gerrit.libreoffice.org/14807
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Those attributes contain a lot of interesting properties, among them
the heading level which fixes this bug.
Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b
(cherry picked from commit 1e6515e64cb4a40071e09d5df000a94f96311ea1)
Reviewed-on: https://gerrit.libreoffice.org/14807
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Don't use configuration syntax that breaks when upgrading to 4.5
Use symbolic (not numeric) opcodes in the registry for the OpenCL use
subset. The opcode numeric values are not stable, and have in fact changed in
master recently.
Even if they were stable, storing them symbolically would be a good
idea. Makes it easier to edit them manually directly in the registry files.
(Something end-users are of course not expected to do, but admins or hackers
may want to do.)
I figured out how to do the mapping from symbolic names to enum values and
back without an ScDocument, turned out it was not complicated after all.
Change-Id: I062dbfa633668a645c6c308acacf0826b6459a93
Reviewed-on: https://gerrit.libreoffice.org/14775
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Use symbolic (not numeric) opcodes in the registry for the OpenCL use
subset. The opcode numeric values are not stable, and have in fact changed in
master recently.
Even if they were stable, storing them symbolically would be a good
idea. Makes it easier to edit them manually directly in the registry files.
(Something end-users are of course not expected to do, but admins or hackers
may want to do.)
I figured out how to do the mapping from symbolic names to enum values and
back without an ScDocument, turned out it was not complicated after all.
Change-Id: I062dbfa633668a645c6c308acacf0826b6459a93
Reviewed-on: https://gerrit.libreoffice.org/14775
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Fix bugs in the OpenCL implementation of some statistical functions
Don't return negative values from ScGroupTokenConverter::trimLength(). It
doesn't make sense, we should return zero instead. At the two call sites,
there are tests against a zero having been returned, but not against a
negative value. And the return value is even passed as the nArrayLength
parameter to a formula::DoubleVectorRefToken constructor, which is of type
size_t, thus unsigned. Passing for instance -4 to it ends up being interpreted
as 18446744073709551612, which has fun consequences. I got a crash from a
spreadsheet with formulas that referenced some empty cells.
Set #VALUE! error in COVAR() and PEARSON() OpenCL implementation when
appropriate. Returning a "bare" NaN with no "double error" semantic payload
does not make sense. Bare NaNs are displayed in Calc as 'nan' which probably
is not what we want.
Set #VALUE! error in COVAR() OpenCL implementation when appropriate. Returning
-DBL_MAX doesn't make sense. The traditional C++ implementation and other
spreadsheet products return an error.
Set #DIV/0! error in VAR() OpenCL implementation when appropriate. Returning
DBL_MAX doesn't make sense. The traditional C++ implementation and other
spreadsheet products return an error.
Return a #DIV/0! error in one case and #VALUE! in another in the OpenCL
SLOPE() implementation instead of bare NANs. There are still many places in
this function where the code bluntly returns a bare NAN. That is always the
wrong thing to do. However, it is not certain which error code is the right
error in each case. One would have to check in each case how to get to that
place in the code, and compare to what the reference C++ implementation and
other spreadsheet products do in each case.
Return #VALUE! instead of NaN in the OpenCL NORMSINV()
Add NORMSDIST, VAR, CORREL, COVAR, PEARSON and SLOPE to the OpenCL-enabled
default opcode subset. Having these statistical functions perform fast is
essential in many cases, and their implementations seem to be correct now.
Change-Id: Idb202756f5b64e30b9bb87c00e340b8060694509
Reviewed-on: https://gerrit.libreoffice.org/14769
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Don't return negative values from ScGroupTokenConverter::trimLength(). It
doesn't make sense, we should return zero instead. At the two call sites,
there are tests against a zero having been returned, but not against a
negative value. And the return value is even passed as the nArrayLength
parameter to a formula::DoubleVectorRefToken constructor, which is of type
size_t, thus unsigned. Passing for instance -4 to it ends up being interpreted
as 18446744073709551612, which has fun consequences. I got a crash from a
spreadsheet with formulas that referenced some empty cells.
Set #VALUE! error in COVAR() and PEARSON() OpenCL implementation when
appropriate. Returning a "bare" NaN with no "double error" semantic payload
does not make sense. Bare NaNs are displayed in Calc as 'nan' which probably
is not what we want.
Set #VALUE! error in COVAR() OpenCL implementation when appropriate. Returning
-DBL_MAX doesn't make sense. The traditional C++ implementation and other
spreadsheet products return an error.
Set #DIV/0! error in VAR() OpenCL implementation when appropriate. Returning
DBL_MAX doesn't make sense. The traditional C++ implementation and other
spreadsheet products return an error.
Return a #DIV/0! error in one case and #VALUE! in another in the OpenCL
SLOPE() implementation instead of bare NANs. There are still many places in
this function where the code bluntly returns a bare NAN. That is always the
wrong thing to do. However, it is not certain which error code is the right
error in each case. One would have to check in each case how to get to that
place in the code, and compare to what the reference C++ implementation and
other spreadsheet products do in each case.
Return #VALUE! instead of NaN in the OpenCL NORMSINV()
Add NORMSDIST, VAR, CORREL, COVAR, PEARSON and SLOPE to the OpenCL-enabled
default opcode subset. Having these statistical functions perform fast is
essential in many cases, and their implementations seem to be correct now.
Change-Id: Idb202756f5b64e30b9bb87c00e340b8060694509
Reviewed-on: https://gerrit.libreoffice.org/14769
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Resolves tdf#80137 Paste array formula into range pastes as non-array formula
Reviewed-on: https://gerrit.libreoffice.org/14770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 097a16b59884c777f724cec6c5d42734974ed44b)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Conflicts:
sc/qa/unit/ucalc.cxx
sc/qa/unit/ucalc.hxx
Change-Id: I500008b32e5af07702b76afb901a3ec270453462
Reviewed-on: https://gerrit.libreoffice.org/14770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 097a16b59884c777f724cec6c5d42734974ed44b)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Conflicts:
sc/qa/unit/ucalc.cxx
sc/qa/unit/ucalc.hxx
Change-Id: I500008b32e5af07702b76afb901a3ec270453462
tdf#39279: Prioritise Thunderbird address books in first-match search
stopgap measure until tdf#57873 is fully implemented,
since these days by far more people use Thunderbird
than Seamonkey (or Firefox address book, if the latter
even has any...).
Change-Id: I638ec90277063b1e7536c045bffb1052d3b76911
Reviewed-on: https://gerrit.libreoffice.org/14800
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
stopgap measure until tdf#57873 is fully implemented,
since these days by far more people use Thunderbird
than Seamonkey (or Firefox address book, if the latter
even has any...).
Change-Id: I638ec90277063b1e7536c045bffb1052d3b76911
Reviewed-on: https://gerrit.libreoffice.org/14800
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
tdf#50133: Wrong underlining in Reports
Change-Id: Ia1d37d150c2186f014733cd87179445722b54346
(cherry picked from commit 27bc6714df6638c6fd9d2ee5c26870ae5eb2f63e)
Reviewed-on: https://gerrit.libreoffice.org/14791
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Change-Id: Ia1d37d150c2186f014733cd87179445722b54346
(cherry picked from commit 27bc6714df6638c6fd9d2ee5c26870ae5eb2f63e)
Reviewed-on: https://gerrit.libreoffice.org/14791
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
tdf#88847: Fields of query design can be moved to the left only
Part of code
1299 ImplHeadItemList::iterator it = mpItemList->begin();
1300 ::std::advance( it, nPos );
1301 ImplHeadItem* pItem = *it;
1302 mpItemList->erase( it );
1303 if ( nNewPos < nPos ) <-- case move to left
1304 nPos = nNewPos;
1305 it = mpItemList->begin();
1306 ::std::advance( it, nPos );
1307 mpItemList->insert( it, pItem );
So in move to right case, we erase and insert pItem at the same place
We just have to use nNewPos in all cases
regression from bd24a310be1459510b760b812838cb87923853c5
Also add back "ImplUpdate" call erroneously removed in merge
commit 67d2af6fac2d9bad52a6b1f6e0cbd1229eb88a42
(there is an ImplUpdate call in each parent of that merge commit)
Change-Id: I100b0c6874b366f777c5d38470fcee7a9a7326df
(cherry picked from commit 63050dccbc50f148cd788730faa53d822d37e54f)
Reviewed-on: https://gerrit.libreoffice.org/14786
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Part of code
1299 ImplHeadItemList::iterator it = mpItemList->begin();
1300 ::std::advance( it, nPos );
1301 ImplHeadItem* pItem = *it;
1302 mpItemList->erase( it );
1303 if ( nNewPos < nPos ) <-- case move to left
1304 nPos = nNewPos;
1305 it = mpItemList->begin();
1306 ::std::advance( it, nPos );
1307 mpItemList->insert( it, pItem );
So in move to right case, we erase and insert pItem at the same place
We just have to use nNewPos in all cases
regression from bd24a310be1459510b760b812838cb87923853c5
Also add back "ImplUpdate" call erroneously removed in merge
commit 67d2af6fac2d9bad52a6b1f6e0cbd1229eb88a42
(there is an ImplUpdate call in each parent of that merge commit)
Change-Id: I100b0c6874b366f777c5d38470fcee7a9a7326df
(cherry picked from commit 63050dccbc50f148cd788730faa53d822d37e54f)
Reviewed-on: https://gerrit.libreoffice.org/14786
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
tdf#89391 : Datasource URL in Database Properties window cannot be viewed
Change-Id: Ia3e978e3fd9c0ce19ec679c41d40a34338147c37
(cherry picked from commit 1ac9985ade97f91869a11ce45231ffd6a5440959)
Reviewed-on: https://gerrit.libreoffice.org/14768
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Change-Id: Ia3e978e3fd9c0ce19ec679c41d40a34338147c37
(cherry picked from commit 1ac9985ade97f91869a11ce45231ffd6a5440959)
Reviewed-on: https://gerrit.libreoffice.org/14768
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Resolves tdf#84012 FORMATTING: Partially missing text in shrink-to-fit cells
Change-Id: I32f44acbcf5a6aed4d9f7442ad7212af31073352
Reviewed-on: https://gerrit.libreoffice.org/14723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 4acffa65b58c8bd359215345dca2c61e2c5ceba5)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I32f44acbcf5a6aed4d9f7442ad7212af31073352
Reviewed-on: https://gerrit.libreoffice.org/14723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 4acffa65b58c8bd359215345dca2c61e2c5ceba5)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Resolves tdf#78221 Cannot drag twice the same cell when editing formula
Change-Id: I69402778e68a2955bdda1ba2c9d31d9b10fb60cc
Reviewed-on: https://gerrit.libreoffice.org/14748
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 3381cb4a421bf390445b7dac9ea42f9ccaf3d875)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I69402778e68a2955bdda1ba2c9d31d9b10fb60cc
Reviewed-on: https://gerrit.libreoffice.org/14748
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 3381cb4a421bf390445b7dac9ea42f9ccaf3d875)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Resolves tdf#71095 Calc doesn't paste images copied from some web browsers
Fixed. When I try to paste an web image copied from web browser, it paste now
Reviewed-on: https://gerrit.libreoffice.org/14529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit b05330c64799067ca2e0b8ea8bfdee8ce8b023b2)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Conflicts:
sc/source/ui/view/viewfun3.cxx
Change-Id: I696feb3438022b506303b2f354ac9c4d306e08f4
Fixed. When I try to paste an web image copied from web browser, it paste now
Reviewed-on: https://gerrit.libreoffice.org/14529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit b05330c64799067ca2e0b8ea8bfdee8ce8b023b2)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Conflicts:
sc/source/ui/view/viewfun3.cxx
Change-Id: I696feb3438022b506303b2f354ac9c4d306e08f4
tdf#89482 - return size of system virtual device resource at construction.
Reviewed-on: https://gerrit.libreoffice.org/14678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Conflicts:
vcl/inc/win/salinst.h
Change-Id: I832a5626b52935180f24857e56297840667eec2a
Reviewed-on: https://gerrit.libreoffice.org/14679
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/14678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Conflicts:
vcl/inc/win/salinst.h
Change-Id: I832a5626b52935180f24857e56297840667eec2a
Reviewed-on: https://gerrit.libreoffice.org/14679
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#89266 SwDrawShell::GetState: fix crash on adding textbox to fontwork
Till we find a use case where it makes sense to support this, just hide
the menu item to avoid the crash.
(cherry picked from commit 5bfff14d8f2240ff37b91b78c337438214dfa1bc)
Change-Id: Ic1df38edc38495d7899038ec2b8ad753da87d352
Reviewed-on: https://gerrit.libreoffice.org/14726
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Till we find a use case where it makes sense to support this, just hide
the menu item to avoid the crash.
(cherry picked from commit 5bfff14d8f2240ff37b91b78c337438214dfa1bc)
Change-Id: Ic1df38edc38495d7899038ec2b8ad753da87d352
Reviewed-on: https://gerrit.libreoffice.org/14726
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
gbuild: CppunitTest: always use unittest configuration
The sc_subsequent_filters_test was failing because of a lock file
because it did not use the unittest configuration.
Refactor gb_CppunitTest_use_configuration so it uses both the instdir
and unittest configuration to prevent such errors.
In case there ever is a test that does not work with the unittest
configuration it should call gb_CppunitTest_use_instdir_configuration.
(cherry picked from commit f0a60415597bae7ca54767b397a217882578ce97)
Conflicts:
dbaccess/CppunitTest_dbaccess_RowSetClones.mk
sc/CppunitTest_sc_condformats.mk
sc/CppunitTest_sc_recordchanges.mk
Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e
Reviewed-on: https://gerrit.libreoffice.org/14738
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The sc_subsequent_filters_test was failing because of a lock file
because it did not use the unittest configuration.
Refactor gb_CppunitTest_use_configuration so it uses both the instdir
and unittest configuration to prevent such errors.
In case there ever is a test that does not work with the unittest
configuration it should call gb_CppunitTest_use_instdir_configuration.
(cherry picked from commit f0a60415597bae7ca54767b397a217882578ce97)
Conflicts:
dbaccess/CppunitTest_dbaccess_RowSetClones.mk
sc/CppunitTest_sc_condformats.mk
sc/CppunitTest_sc_recordchanges.mk
Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e
Reviewed-on: https://gerrit.libreoffice.org/14738
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
configure: properly check for Windows SDK 8.1A
Due to the wildcard checking for it will actually attempt to check for the
SDK 8.0, which fails with Visual Studio 2013 because its SDK 8.0 apparently
lacks a midl.exe, so configure fails.
Change-Id: Ib0e61a3a999d6a2ebe16645225fc9838dab3bdb1
(cherry picked from commit c503d3780fd095cc94103bf0f89b662c446b3b2b)
Reviewed-on: https://gerrit.libreoffice.org/14736
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Due to the wildcard checking for it will actually attempt to check for the
SDK 8.0, which fails with Visual Studio 2013 because its SDK 8.0 apparently
lacks a midl.exe, so configure fails.
Change-Id: Ib0e61a3a999d6a2ebe16645225fc9838dab3bdb1
(cherry picked from commit c503d3780fd095cc94103bf0f89b662c446b3b2b)
Reviewed-on: https://gerrit.libreoffice.org/14736
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
sw: PVS V656 Variables initialized through call to same function
(regression from c2ccd20c0fd92bddfff76447754541705e3eb8f3)
Change-Id: I78ac92869b0e9b56df708aa7d2d35b45bfb5f751
(cherry picked from commit 7d79ae437e16191a62dbe3ec81f9b82e79daf7ea)
Reviewed-on: https://gerrit.libreoffice.org/14737
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(regression from c2ccd20c0fd92bddfff76447754541705e3eb8f3)
Change-Id: I78ac92869b0e9b56df708aa7d2d35b45bfb5f751
(cherry picked from commit 7d79ae437e16191a62dbe3ec81f9b82e79daf7ea)
Reviewed-on: https://gerrit.libreoffice.org/14737
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Missing dependency
Change-Id: I4b66f7e549fe318f61b5ec8127ca073b2eb19ed3
(cherry picked from commit defbb4752bfa4bc2a35f5ee4c24d0e1654afeb2c)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Change-Id: I4b66f7e549fe318f61b5ec8127ca073b2eb19ed3
(cherry picked from commit defbb4752bfa4bc2a35f5ee4c24d0e1654afeb2c)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
cp#1000115 SwTxtFrm: don't join follow just because it has no content
The problem was that the bugdoc had a table, and inside the table there
was a long paragraph that flows to the next page, but only the paragraph
mark of it does so. We first split the frame to have space for the
paragraph mark, but later decided that all the content would fit the
first frame, and this way the last hard line break and the paragraph
mark was painted on each other.
This is normally not a problem without tables, because
SwTxtFrm::FormatAdjust() just calls SplitFrm(), sets its nNew flag to
non-zero make sure that later SwTxtFrm::_AdjustFollow() doesn't try to
join it, and we're ready. However, when the paragraph is inside a table,
then the paragraph was formatted multiple times, and next time when we
already had a follow nNew was not set, so even if there was a correct
split first, the new frame was joined later.
Fix the problem by explicitly setting nNew for the "in a table and
paragraph ends with a hard line break" case, that way we don't blindly
join the frame, only in case there is enough space for the follow in the
master.
(cherry picked from commit 7e33cce05b2df3f1761bcc66606c4d3b2b2671e9)
Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx
Change-Id: Iede654740dcb0d8aa768d742ee330208291a383a
Reviewed-on: https://gerrit.libreoffice.org/14476
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The problem was that the bugdoc had a table, and inside the table there
was a long paragraph that flows to the next page, but only the paragraph
mark of it does so. We first split the frame to have space for the
paragraph mark, but later decided that all the content would fit the
first frame, and this way the last hard line break and the paragraph
mark was painted on each other.
This is normally not a problem without tables, because
SwTxtFrm::FormatAdjust() just calls SplitFrm(), sets its nNew flag to
non-zero make sure that later SwTxtFrm::_AdjustFollow() doesn't try to
join it, and we're ready. However, when the paragraph is inside a table,
then the paragraph was formatted multiple times, and next time when we
already had a follow nNew was not set, so even if there was a correct
split first, the new frame was joined later.
Fix the problem by explicitly setting nNew for the "in a table and
paragraph ends with a hard line break" case, that way we don't blindly
join the frame, only in case there is enough space for the follow in the
master.
(cherry picked from commit 7e33cce05b2df3f1761bcc66606c4d3b2b2671e9)
Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx
Change-Id: Iede654740dcb0d8aa768d742ee330208291a383a
Reviewed-on: https://gerrit.libreoffice.org/14476
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Resolves: tdf#89500 catch ISO 8601 datetime in all locales
Change-Id: I906ebdc6aa5c365df98a29e9e0f319f89f6833c6
(cherry picked from commit 5d572e673dec3396487b14bb1f9e86aa8ab86786)
Reviewed-on: https://gerrit.libreoffice.org/14565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I906ebdc6aa5c365df98a29e9e0f319f89f6833c6
(cherry picked from commit 5d572e673dec3396487b14bb1f9e86aa8ab86786)
Reviewed-on: https://gerrit.libreoffice.org/14565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
jpeg-turbo: work around failure in AC_PROG_MAKE_SET on WNT
autoconf < 2.61a uses "echo" here and for some bizarre reason that
converts " inside ' to \ so remove the " to get it to work.
echo 'foo="bar"'
foo=\bar"
Change-Id: I6bee94d4d075ce953f5788b7fdf9d3b66a7db0c7
(cherry picked from commit 9c6ce47eaf1a891edf7c200145de400fd1cf2871)
Reviewed-on: https://gerrit.libreoffice.org/14589
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
autoconf < 2.61a uses "echo" here and for some bizarre reason that
converts " inside ' to \ so remove the " to get it to work.
echo 'foo="bar"'
foo=\bar"
Change-Id: I6bee94d4d075ce953f5788b7fdf9d3b66a7db0c7
(cherry picked from commit 9c6ce47eaf1a891edf7c200145de400fd1cf2871)
Reviewed-on: https://gerrit.libreoffice.org/14589
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
getAny() is not a safe default, it assumes there is actually an Any
at *m_aValue.m_pValue.
But there could not even be a pointer there, e.g. if m_aValue.m_nIntXX is in use.
Then the pointer dereference usually leads to a crash.
Can e.g. be reproduced by calling getBytes() on an integer column of a RowSet.
Change-Id: Ib5361d838d2869142fd797d4e3454e2562ea7acf
Reviewed-on: https://gerrit.libreoffice.org/14718
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
at *m_aValue.m_pValue.
But there could not even be a pointer there, e.g. if m_aValue.m_nIntXX is in use.
Then the pointer dereference usually leads to a crash.
Can e.g. be reproduced by calling getBytes() on an integer column of a RowSet.
Change-Id: Ib5361d838d2869142fd797d4e3454e2562ea7acf
Reviewed-on: https://gerrit.libreoffice.org/14718
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
tdf#87820 Images not displayed properly in Calc
Fixed. After opening, images were not displayed properly in Calc 4.3 and 4.4
Change-Id: I1f0dd7e9d332889df81be84a6c1e28a09f509733
Reviewed-on: https://gerrit.libreoffice.org/14505
Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
(cherry picked from commit 6c84442f99de109b585d3ba8964deb8dcf261c0f)
Reviewed-on: https://gerrit.libreoffice.org/14721
Fixed. After opening, images were not displayed properly in Calc 4.3 and 4.4
Change-Id: I1f0dd7e9d332889df81be84a6c1e28a09f509733
Reviewed-on: https://gerrit.libreoffice.org/14505
Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
(cherry picked from commit 6c84442f99de109b585d3ba8964deb8dcf261c0f)
Reviewed-on: https://gerrit.libreoffice.org/14721
More improvements of graphic cache size handling
* ImplFillSwappedGraphicObject method is part of
the old caching mechanism which interferes with
the newer one, so remove this method.
* Use Graphic size directly becuase in some case
it does not match with the GraphicObject's
size.
* Assertions to avoid underflow of mnUsedSize
Change-Id: I3381f49ca05e3e5d565848c8af24c78e7b9ac3af
(cherry picked from commit ab00ac3e88e0a28d0e38c5968c23014a6a8fb194)
Reviewed-on: https://gerrit.libreoffice.org/14699
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
* ImplFillSwappedGraphicObject method is part of
the old caching mechanism which interferes with
the newer one, so remove this method.
* Use Graphic size directly becuase in some case
it does not match with the GraphicObject's
size.
* Assertions to avoid underflow of mnUsedSize
Change-Id: I3381f49ca05e3e5d565848c8af24c78e7b9ac3af
(cherry picked from commit ab00ac3e88e0a28d0e38c5968c23014a6a8fb194)
Reviewed-on: https://gerrit.libreoffice.org/14699
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
in BITFIELDS mode (3) there are *3* pal entries not 12
There are 12 *bytes*, which presumably is the thinko there. But this nPalCount
gets multiplied by 4 to convert it to bytes later.
This is the source of the bad mask values found after "Use the cairo-compatible
basebmp surface for headless" etc. Arbitrary values ended up being read as mask
values.
Change-Id: If5d93f74b1c58d3ecdb5186f93cb0215a556586a
(cherry picked from commit 5e5b90c12862b522a4553337fbf6309bb8278b8c)
Reviewed-on: https://gerrit.libreoffice.org/14659
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
There are 12 *bytes*, which presumably is the thinko there. But this nPalCount
gets multiplied by 4 to convert it to bytes later.
This is the source of the bad mask values found after "Use the cairo-compatible
basebmp surface for headless" etc. Arbitrary values ended up being read as mask
values.
Change-Id: If5d93f74b1c58d3ecdb5186f93cb0215a556586a
(cherry picked from commit 5e5b90c12862b522a4553337fbf6309bb8278b8c)
Reviewed-on: https://gerrit.libreoffice.org/14659
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
sdbc:address:kab URLs don't have a trailing ":"
broken since 4bf95c4c31dd871065d4042028a4b3ae476dab70 "make use of startsWith()"
where the tricky
!url.compareTo(::rtl::OUString("sdbc:address:kab:"), 16)
was replaced with
url.startsWith("sdbc:address:kab:")
even though the original exempted the trailing ":" from the comparison
(cherry picked from commit 27e85dd314e02dc97612bf1682fccacaf0244127)
Conflicts:
connectivity/source/drivers/kab/KDriver.cxx
Change-Id: I45175b2669d61eb4cee36d4456ccb69d0f11ef63
Reviewed-on: https://gerrit.libreoffice.org/14670
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
broken since 4bf95c4c31dd871065d4042028a4b3ae476dab70 "make use of startsWith()"
where the tricky
!url.compareTo(::rtl::OUString("sdbc:address:kab:"), 16)
was replaced with
url.startsWith("sdbc:address:kab:")
even though the original exempted the trailing ":" from the comparison
(cherry picked from commit 27e85dd314e02dc97612bf1682fccacaf0244127)
Conflicts:
connectivity/source/drivers/kab/KDriver.cxx
Change-Id: I45175b2669d61eb4cee36d4456ccb69d0f11ef63
Reviewed-on: https://gerrit.libreoffice.org/14670
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Adapt code to changed libkabdrv1lo.so name
broken since LO 3.6, commit 07d512eff12fc89adbfb73e546b3946494f21472
"connectivity: convert kab to gbuild"
(cherry picked from commit d8a2a0b84a9aa570116febf23a6f1d6430fec287)
Conflicts:
connectivity/source/drivers/kab/KDriver.cxx
Change-Id: I65cc32fa55f1d5c0358585489b8b3dc3aaf8004b
Reviewed-on: https://gerrit.libreoffice.org/14669
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
broken since LO 3.6, commit 07d512eff12fc89adbfb73e546b3946494f21472
"connectivity: convert kab to gbuild"
(cherry picked from commit d8a2a0b84a9aa570116febf23a6f1d6430fec287)
Conflicts:
connectivity/source/drivers/kab/KDriver.cxx
Change-Id: I65cc32fa55f1d5c0358585489b8b3dc3aaf8004b
Reviewed-on: https://gerrit.libreoffice.org/14669
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#89679 - fix incorrect mapping of font-family-complex and CharFontNameAsian
Change-Id: I4adad1675f2a880e14ed870a3c74e43e8898c371
Reviewed-on: https://gerrit.libreoffice.org/14663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit cda9ae79e58d861a85128d6a37587b633b956aae)
Reviewed-on: https://gerrit.libreoffice.org/14667
Change-Id: I4adad1675f2a880e14ed870a3c74e43e8898c371
Reviewed-on: https://gerrit.libreoffice.org/14663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit cda9ae79e58d861a85128d6a37587b633b956aae)
Reviewed-on: https://gerrit.libreoffice.org/14667
Resolves: tdf#81659 handle expand reference edge correctly
split formula grouping for reference edge expansion, tdf#81659 related
Edge expansion may change expressions individually, which must be split
off the group.
Change-Id: Id4328bd8c42f2ff9f83d2edc845537971f3a39d3
(cherry picked from commit 0cd15b4494f8e8abe67a258fb10189135bf5a8ac)
tdf#81659 check that references are at least 2 cols/rows to expand edge
Needs also 0cd15b4494f8e8abe67a258fb10189135bf5a8ac if edges are to be
expanded and formula grouping is affected.
Change-Id: Ib3cee8dd214d216907248316a2ac5a290399b169
(cherry picked from commit 23b0112ecea2f8796a4e237e9061de1a36997a30)
Reviewed-on: https://gerrit.libreoffice.org/14655
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
split formula grouping for reference edge expansion, tdf#81659 related
Edge expansion may change expressions individually, which must be split
off the group.
Change-Id: Id4328bd8c42f2ff9f83d2edc845537971f3a39d3
(cherry picked from commit 0cd15b4494f8e8abe67a258fb10189135bf5a8ac)
tdf#81659 check that references are at least 2 cols/rows to expand edge
Needs also 0cd15b4494f8e8abe67a258fb10189135bf5a8ac if edges are to be
expanded and formula grouping is affected.
Change-Id: Ib3cee8dd214d216907248316a2ac5a290399b169
(cherry picked from commit 23b0112ecea2f8796a4e237e9061de1a36997a30)
Reviewed-on: https://gerrit.libreoffice.org/14655
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#89666: vcl: speed up HbLayoutEngine line layout for large paragraphs
When formatting a 180k char Writer paragraph, most of the time is spent
in vcl::ScriptRun::next(), which is called twice per line from
SwTxtGuess::Guess(), once via GetTxtBreak() and once via GetTxtSize().
In the second call, from GetTxtSize(), the end position of the line is
known, and passed to vcl, and iterating beyond that position seems
pointless.
This reduces vcl::ScriptRun::next() from 24 to 11 billion callgrind
cycles when built with GCC 4.9.2 -m32 -Os.
Change-Id: Ia23fcccaf5ef9c9ecdcb54bfc8f0f8a043c8711e
(cherry picked from commit 7fde44c85620f8079bc4863fe3f7ea1f69a0f88c)
Reviewed-on: https://gerrit.libreoffice.org/14646
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
When formatting a 180k char Writer paragraph, most of the time is spent
in vcl::ScriptRun::next(), which is called twice per line from
SwTxtGuess::Guess(), once via GetTxtBreak() and once via GetTxtSize().
In the second call, from GetTxtSize(), the end position of the line is
known, and passed to vcl, and iterating beyond that position seems
pointless.
This reduces vcl::ScriptRun::next() from 24 to 11 billion callgrind
cycles when built with GCC 4.9.2 -m32 -Os.
Change-Id: Ia23fcccaf5ef9c9ecdcb54bfc8f0f8a043c8711e
(cherry picked from commit 7fde44c85620f8079bc4863fe3f7ea1f69a0f88c)
Reviewed-on: https://gerrit.libreoffice.org/14646
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Adapt compilerplugins to Clang trunk towards 3.7
Change-Id: I5b41039bf63a4c2f313fe7a57c0f6934dcb0752d
(cherry picked from commit 193957750ab857dc5e01ee7259964ee92a54ee0d)
Change-Id: I5b41039bf63a4c2f313fe7a57c0f6934dcb0752d
(cherry picked from commit 193957750ab857dc5e01ee7259964ee92a54ee0d)
tdf#89665: i18npool: fix pathological transliterate slow-path
TransliterationImpl::transliterate() has a slow-path for the case when
more than one trasliteration module is cascaded which swaps 2
uno::Sequence. This is unbelievably slow because non-const
Sequence::operator[] does a function call into cppu to check whether COW
has to be done.
This speeds up transliterate() from 344 billion to 101 billion callgrind
cycles when built with GCC 4.9.2 -m32 -Os.
Commit d2771b63b94a8aae3c25c83e9dae9f83242f46c1 added a second
transliteration module that is enabled by default, making the problem
visible, especially with long paragraphs in Writer.
Change-Id: I2799df9173ac73aab8c4eb4cc6f592976b06c8da
(cherry picked from commit 88d4b2fb08b983531b1e0abc71b07f4bdecdc925)
Reviewed-on: https://gerrit.libreoffice.org/14643
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
TransliterationImpl::transliterate() has a slow-path for the case when
more than one trasliteration module is cascaded which swaps 2
uno::Sequence. This is unbelievably slow because non-const
Sequence::operator[] does a function call into cppu to check whether COW
has to be done.
This speeds up transliterate() from 344 billion to 101 billion callgrind
cycles when built with GCC 4.9.2 -m32 -Os.
Commit d2771b63b94a8aae3c25c83e9dae9f83242f46c1 added a second
transliteration module that is enabled by default, making the problem
visible, especially with long paragraphs in Writer.
Change-Id: I2799df9173ac73aab8c4eb4cc6f592976b06c8da
(cherry picked from commit 88d4b2fb08b983531b1e0abc71b07f4bdecdc925)
Reviewed-on: https://gerrit.libreoffice.org/14643
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
check if reads were successful
Reviewed-on: https://gerrit.libreoffice.org/14631
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f974db5d89eacf0c23e303c22c62972014e9db16)
Conflicts:
hwpfilter/source/hwpfile.cxx
Change-Id: I69ab0ca9c017c9a1c10d18fd850f32a92c641d12
Reviewed-on: https://gerrit.libreoffice.org/14635
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/14631
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f974db5d89eacf0c23e303c22c62972014e9db16)
Conflicts:
hwpfilter/source/hwpfile.cxx
Change-Id: I69ab0ca9c017c9a1c10d18fd850f32a92c641d12
Reviewed-on: https://gerrit.libreoffice.org/14635
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
SkipImages option for PDF import
This option allows images and drawings to be skipped while importing
a PDF, the main reason was performance improvement where images were
not needed.
And I've also added unit tests for it.
Change-Id: I6595d3ff22d5389eab4fe8450460d083f626d216
Reviewed-on: https://gerrit.libreoffice.org/14628
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This option allows images and drawings to be skipped while importing
a PDF, the main reason was performance improvement where images were
not needed.
And I've also added unit tests for it.
Change-Id: I6595d3ff22d5389eab4fe8450460d083f626d216
Reviewed-on: https://gerrit.libreoffice.org/14628
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#78148 Ordinal numbers should not be auto-capitalized
FnChgOrdinalNumber should return true if it changes the ordinal number.
This seems to be accentually removed when the function was
internationalized and has always returned false since.
Change-Id: I633058a99ec033e0c33f807776364a52e22e9c64
Reviewed-on: https://gerrit.libreoffice.org/14535
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 42ec6448f9acd474d8ec1a92d9362e1b38e13758)
Reviewed-on: https://gerrit.libreoffice.org/14578
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
FnChgOrdinalNumber should return true if it changes the ordinal number.
This seems to be accentually removed when the function was
internationalized and has always returned false since.
Change-Id: I633058a99ec033e0c33f807776364a52e22e9c64
Reviewed-on: https://gerrit.libreoffice.org/14535
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 42ec6448f9acd474d8ec1a92d9362e1b38e13758)
Reviewed-on: https://gerrit.libreoffice.org/14578
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
tdf#38837 Reduce power consumption by minimizing idle timers
Based on profiling, Writer's most CPU consuming idle event was
document statistics calculation.
This patch stops the idle timer once statistics has been updated.
Subsequent profiling shows a sharp decline in CPU usage.
Modifications to the document should initiate statistics update.
Change-Id: I8c38ad8847987264549945e4f482ea18d2635283
Reviewed-on: https://gerrit.libreoffice.org/14575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit c57213764b387dddad946e78145cea607ca9f460)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Based on profiling, Writer's most CPU consuming idle event was
document statistics calculation.
This patch stops the idle timer once statistics has been updated.
Subsequent profiling shows a sharp decline in CPU usage.
Modifications to the document should initiate statistics update.
Change-Id: I8c38ad8847987264549945e4f482ea18d2635283
Reviewed-on: https://gerrit.libreoffice.org/14575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit c57213764b387dddad946e78145cea607ca9f460)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Resolves: rhbz#1193971 clear hard-coded char props in table cells...
like we do already for shapes. So now when attempting to set replacement char
properties on the entire cell, clear any hard-coded sub ranges within the
existing paragraphs.
This extends the effort of
commit a217f3cb2dce71a4322f78ceb45edb6f171b2b65
Author: Matúš Kukan <matus.kukan@collabora.com>
Date: Tue Aug 26 10:16:34 2014 +0200
bnc#770711: Make changing table text color in impress always work
to encompass all character properties, not just color
Change-Id: If8b426c3531b4678868d8351426db32c3c558650
(cherry picked from commit b14259b946686c753c0df42c519fc2537e871601)
Reviewed-on: https://gerrit.libreoffice.org/14539
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
like we do already for shapes. So now when attempting to set replacement char
properties on the entire cell, clear any hard-coded sub ranges within the
existing paragraphs.
This extends the effort of
commit a217f3cb2dce71a4322f78ceb45edb6f171b2b65
Author: Matúš Kukan <matus.kukan@collabora.com>
Date: Tue Aug 26 10:16:34 2014 +0200
bnc#770711: Make changing table text color in impress always work
to encompass all character properties, not just color
Change-Id: If8b426c3531b4678868d8351426db32c3c558650
(cherry picked from commit b14259b946686c753c0df42c519fc2537e871601)
Reviewed-on: https://gerrit.libreoffice.org/14539
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
fdo#83371 : cannot navigate to list Files in LibreOffice dialogs
Change-Id: I64d95abb60d2ad635c0b67c2efef9567f526b30f
Reviewed-on: https://gerrit.libreoffice.org/14573
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Change-Id: I64d95abb60d2ad635c0b67c2efef9567f526b30f
Reviewed-on: https://gerrit.libreoffice.org/14573
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
ICONS: Fix icons in sifr and tango in Calc (4.4)
Change-Id: Ifcdf130322a4486f03a160179ac3ab064f9a1131
Reviewed-on: https://gerrit.libreoffice.org/14653
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Change-Id: Ifcdf130322a4486f03a160179ac3ab064f9a1131
Reviewed-on: https://gerrit.libreoffice.org/14653
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Fix dangling pointer
Change-Id: I352702ac50708a8f8c40e2752821178223052b7c
(cherry picked from commit 1c4e95db104cd5f732bc41a539a7dc5fd9269ef6)
Reviewed-on: https://gerrit.libreoffice.org/14632
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I352702ac50708a8f8c40e2752821178223052b7c
(cherry picked from commit 1c4e95db104cd5f732bc41a539a7dc5fd9269ef6)
Reviewed-on: https://gerrit.libreoffice.org/14632
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
-Werror,-Winconsistent-missing-override
(cherry picked from commit d7e92309239e6da60bd13b984ffaace8b4ef638e)
Conflicts:
include/vcl/floatwin.hxx
Change-Id: Ib1445e9c66c08044434c7e8c828d2fc7b6a0a04c
(cherry picked from commit d7e92309239e6da60bd13b984ffaace8b4ef638e)
Conflicts:
include/vcl/floatwin.hxx
Change-Id: Ib1445e9c66c08044434c7e8c828d2fc7b6a0a04c
Resolves: tdf#89484 check that sheet reference is within selected sheets
Change-Id: I88f1d0a134ffa3fbb9a5b5abdabbd4774f457e81
(cherry picked from commit 5803c76f318b2a8b655bf83a8257f60cd112ac71)
Reviewed-on: https://gerrit.libreoffice.org/14609
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Change-Id: I88f1d0a134ffa3fbb9a5b5abdabbd4774f457e81
(cherry picked from commit 5803c76f318b2a8b655bf83a8257f60cd112ac71)
Reviewed-on: https://gerrit.libreoffice.org/14609
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
OXYGEN: Added sidebar icons as well as add icons from the original set (4.4)
Change-Id: I08995a9a05bee178c7d9fa3c827f4fe9ef117a66
Reviewed-on: https://gerrit.libreoffice.org/14599
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Change-Id: I08995a9a05bee178c7d9fa3c827f4fe9ef117a66
Reviewed-on: https://gerrit.libreoffice.org/14599
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
file UCP: Ensure myLocalTime is initialized
When a file's time is epoch (1970-01-01 00:00:00, i.e., TimeValue temp is all
zero) and the TZ is UTC or westward, osl_getLocalTimeFromSystemTime returns
false and leaves myLocalTime uninitialized. That e.g. confuses getModuleByUrl
(scripting/source/pyprov/pythonscript.py), potentially re-loading a Python
script with epoch time (as happens e.g. for the share/Scripts/python/ files in
an xdg-app installation of LO) every time it is accessed, falsely assuming it
has changed on disk since last load.
Change-Id: I8d4228feb28e2697a7021e3488ae2c09e8439ed8
(cherry picked from commit 94c9206399954d018aae8a1bd4e4b33354b9cdaf)
Reviewed-on: https://gerrit.libreoffice.org/14587
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
When a file's time is epoch (1970-01-01 00:00:00, i.e., TimeValue temp is all
zero) and the TZ is UTC or westward, osl_getLocalTimeFromSystemTime returns
false and leaves myLocalTime uninitialized. That e.g. confuses getModuleByUrl
(scripting/source/pyprov/pythonscript.py), potentially re-loading a Python
script with epoch time (as happens e.g. for the share/Scripts/python/ files in
an xdg-app installation of LO) every time it is accessed, falsely assuming it
has changed on disk since last load.
Change-Id: I8d4228feb28e2697a7021e3488ae2c09e8439ed8
(cherry picked from commit 94c9206399954d018aae8a1bd4e4b33354b9cdaf)
Reviewed-on: https://gerrit.libreoffice.org/14587
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#88811 SwXText::convertToTextFrame: handle shapes anchored to us
(cherry picked from commit 38f2b8b3b16aab19a2564ec699d253d3dccecc3c)
Change-Id: Iedf8eacd37b8ed8e307a10e8ade32f53c7417c4a
Reviewed-on: https://gerrit.libreoffice.org/14571
Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
(cherry picked from commit 38f2b8b3b16aab19a2564ec699d253d3dccecc3c)
Change-Id: Iedf8eacd37b8ed8e307a10e8ade32f53c7417c4a
Reviewed-on: https://gerrit.libreoffice.org/14571
Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
tdf#89436 fix ScHorizontalAttrIterator performance
(cherry picked from master:
d619d23a1f641fc910723cc32c4d8c8d9a8f3681 add unit test
8e9540d3d4909c6dd45c9efa294f565d9735a0d9 fix indices
dd4bd0ee74fae3d7e3a16e018021da173152571b fix condition + cleanup
a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 handle skipping empty rows
4de4f1fd1125bc8cf6059cf143bb76d1ab212434 fix ScHorizontalAttrIterator performance)
Change-Id: Ieda6f3171c5e81d1029746fedd320d7caa7db676
Reviewed-on: https://gerrit.libreoffice.org/14526
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from master:
d619d23a1f641fc910723cc32c4d8c8d9a8f3681 add unit test
8e9540d3d4909c6dd45c9efa294f565d9735a0d9 fix indices
dd4bd0ee74fae3d7e3a16e018021da173152571b fix condition + cleanup
a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 handle skipping empty rows
4de4f1fd1125bc8cf6059cf143bb76d1ab212434 fix ScHorizontalAttrIterator performance)
Change-Id: Ieda6f3171c5e81d1029746fedd320d7caa7db676
Reviewed-on: https://gerrit.libreoffice.org/14526
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
update credits
Change-Id: I8750417eb7373624c6c1cf50036970ea35ca89bb
Change-Id: I8750417eb7373624c6c1cf50036970ea35ca89bb
liborcus: Remove BOOST_ALL_NO_LIB, it's already included upstream
Reviewed-on: https://gerrit.libreoffice.org/14559
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 38671c869d8903ba7d0bd516d53ba0ff9d152adf)
This fixes the MSVC build breakage from commit
1714d4ce2cc3b1b1d88a4b30ce0abdb7669ecad8
Change-Id: I39e65a9ee3ede5217d9d6d8499297e449af798fe
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/14559
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 38671c869d8903ba7d0bd516d53ba0ff9d152adf)
This fixes the MSVC build breakage from commit
1714d4ce2cc3b1b1d88a4b30ce0abdb7669ecad8
Change-Id: I39e65a9ee3ede5217d9d6d8499297e449af798fe
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Adapt gcc3_solaris_intel bridge to GCC 4.7
...similarly to 0fdbb5b0eabbaa571f3747fda12a56c938cba474 "Make
cpp_uno/gcc3_linux_x86-64 bridge work with GCC 4.7"
Change-Id: Idcafcb07678d02446172d7fde30631a342f6437e
(cherry picked from commit 834afd885bd74ff80b59898d3f63ba940a58c1d8)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
...similarly to 0fdbb5b0eabbaa571f3747fda12a56c938cba474 "Make
cpp_uno/gcc3_linux_x86-64 bridge work with GCC 4.7"
Change-Id: Idcafcb07678d02446172d7fde30631a342f6437e
(cherry picked from commit 834afd885bd74ff80b59898d3f63ba940a58c1d8)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Sun ld doesn't support -O1 optimize flag
reported by Gabriele Bulfon (gbulfon@sonicle)
Change-Id: Ie0ff8fe296054a7a266b4c73c30938bb2b7353ea
Reviewed-on: https://gerrit.libreoffice.org/14484
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 34a167e1bf9b478069c290dbf977c68639149852)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
reported by Gabriele Bulfon (gbulfon@sonicle)
Change-Id: Ie0ff8fe296054a7a266b4c73c30938bb2b7353ea
Reviewed-on: https://gerrit.libreoffice.org/14484
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 34a167e1bf9b478069c290dbf977c68639149852)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
tdf#89460 test pChangeTrack before using it
Change-Id: Ic02351c448929daa7d4c5a9a00df9842c2c5aa91
Reviewed-on: https://gerrit.libreoffice.org/14553
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit bf5c5f359cf4eb36a0a9a1110ec2aa3393bb87df)
Reviewed-on: https://gerrit.libreoffice.org/14557
Change-Id: Ic02351c448929daa7d4c5a9a00df9842c2c5aa91
Reviewed-on: https://gerrit.libreoffice.org/14553
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit bf5c5f359cf4eb36a0a9a1110ec2aa3393bb87df)
Reviewed-on: https://gerrit.libreoffice.org/14557
tdf#89423 add missing small delete table icons
Change-Id: I04071394442b4fcc8307d7188b57fe389cf8ccd0
Reviewed-on: https://gerrit.libreoffice.org/14521
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I04071394442b4fcc8307d7188b57fe389cf8ccd0
Reviewed-on: https://gerrit.libreoffice.org/14521
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
implement fill based on style also for chart area, tdf#89451
Change-Id: I7b488e222cd44e75d1e0ff7f8e545e9399f418b5
better way to set default for chart area fill style, related tdf#89451
Change-Id: Iee7fea0f55cf54d43a349b6cc0ffa25995069e40
no need for that anymore
Change-Id: I53002c0b97da66c44429b5ace0fc709b5e8a325f
Reviewed-on: https://gerrit.libreoffice.org/14547
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I7b488e222cd44e75d1e0ff7f8e545e9399f418b5
better way to set default for chart area fill style, related tdf#89451
Change-Id: Iee7fea0f55cf54d43a349b6cc0ffa25995069e40
no need for that anymore
Change-Id: I53002c0b97da66c44429b5ace0fc709b5e8a325f
Reviewed-on: https://gerrit.libreoffice.org/14547
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
tdf#82661 SwFrm::PaintBackground: handle fill attrs when comparing background
Regression from 7d9bb549d498d6beed2c4050c402d09643febdfa (Related:
i#124638 Second step of DrawingLayer FillAttributes..., 2014-06-02),
should be good enough till SdrAllFillAttributesHelper gets its own
operator ==().
Change-Id: I03f847bc1589e3771790427d9894cc330a7b8dc6
(cherry picked from commit 1e33cd8355eb1d856a1439b4a095e379b3acf0bd)
Reviewed-on: https://gerrit.libreoffice.org/14537
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Regression from 7d9bb549d498d6beed2c4050c402d09643febdfa (Related:
i#124638 Second step of DrawingLayer FillAttributes..., 2014-06-02),
should be good enough till SdrAllFillAttributesHelper gets its own
operator ==().
Change-Id: I03f847bc1589e3771790427d9894cc330a7b8dc6
(cherry picked from commit 1e33cd8355eb1d856a1439b4a095e379b3acf0bd)
Reviewed-on: https://gerrit.libreoffice.org/14537
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
this should be [-90, 90] and not (-90, 90), tdf#89454
Change-Id: I943be2cf660d2dc77eebd776208af96c0b5f67a4
Reviewed-on: https://gerrit.libreoffice.org/14546
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I943be2cf660d2dc77eebd776208af96c0b5f67a4
Reviewed-on: https://gerrit.libreoffice.org/14546
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
asan: failure to load tdf#55620 attachment under asan
still loops in layout though
how am I *still* finding bugs in this thing
Change-Id: I048595956516b9acfc60e90c64180b904d6cc1d7
(cherry picked from commit d6b28f0bfe5df0248b18e306c3144282f052c7f0)
Reviewed-on: https://gerrit.libreoffice.org/14524
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
still loops in layout though
how am I *still* finding bugs in this thing
Change-Id: I048595956516b9acfc60e90c64180b904d6cc1d7
(cherry picked from commit d6b28f0bfe5df0248b18e306c3144282f052c7f0)
Reviewed-on: https://gerrit.libreoffice.org/14524
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
tdf#89105: sw: Remove unnecessary downcast
This fixes an infinite loop in SwPaM::DoSearch() that can happen with
32-bit paragraphs now.
(cherry picked from commit dd9972f5f37063f5fe3eb5e011d2adc73f44d305)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Change-Id: I7511862ddf6ed672ba4f09ef6729fb1fa7c1d355
This fixes an infinite loop in SwPaM::DoSearch() that can happen with
32-bit paragraphs now.
(cherry picked from commit dd9972f5f37063f5fe3eb5e011d2adc73f44d305)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Change-Id: I7511862ddf6ed672ba4f09ef6729fb1fa7c1d355
Revert "tdf#89436 fix ScHorizontalAttrIterator performance"
This reverts commit f270e863668bfd0d303685de03d00ebf40e6ddb8.
This reverts commit f270e863668bfd0d303685de03d00ebf40e6ddb8.
tdf#89436 fix ScHorizontalAttrIterator performance
Change-Id: I69be1a85b74ede8f02788a6370d4ebb40bddbe11
Change-Id: I69be1a85b74ede8f02788a6370d4ebb40bddbe11
Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listener
... as the mdds storage segment may change when a formula cell is
inserted at a position such that two segments are merged into a new one.
(cherry picked from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc)
add some SAL_INFO to group area listener and formula cell ctor/dtor
guess we'll need them more often..
(cherry picked from commit f8d6640afa3c8528d2a66741edc49a48c67902d3)
let have FormulaGroupAreaListener a virtual dtor
(cherry picked from commit 0fafb53d1c860388461f30e613a37c128c90ad79)
0ef149fc5edceee765419764bf0efa571ba9d977
1f5e246d68971124ef21e9c2d0db80499928998b
Change-Id: I449a89005418aff7ea12099ea931b786959dbc3b
Reviewed-on: https://gerrit.libreoffice.org/14332
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
... as the mdds storage segment may change when a formula cell is
inserted at a position such that two segments are merged into a new one.
(cherry picked from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc)
add some SAL_INFO to group area listener and formula cell ctor/dtor
guess we'll need them more often..
(cherry picked from commit f8d6640afa3c8528d2a66741edc49a48c67902d3)
let have FormulaGroupAreaListener a virtual dtor
(cherry picked from commit 0fafb53d1c860388461f30e613a37c128c90ad79)
0ef149fc5edceee765419764bf0efa571ba9d977
1f5e246d68971124ef21e9c2d0db80499928998b
Change-Id: I449a89005418aff7ea12099ea931b786959dbc3b
Reviewed-on: https://gerrit.libreoffice.org/14332
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
fdo#81596 export to OOXML that need argument changes
Reviewed-on: https://gerrit.libreoffice.org/10831
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 4feaf96f50fa89eccb4e7a638220099e9a8482f1)
sensible indenting, fdo#81596 related
(cherry picked from commit 3dd241c52d6db424bd4696ff8f223976542e411b)
simplify RewriteMissing() and switch in Add...(), fdo#81596 related
(cherry picked from commit 14aabee5a73e57e26b2062b1ebf00c3f1dff1250)
write TRUE() for 2nd IF() parameter, fdo#81596 related
(cherry picked from commit 8f031861f590ba914321816657a003375d93ef5d)
f7eb11a950b45793d04837d02f9546a93673fa2f
f2ca37e1fda87ce56282fc2d2fc57a0784851139
52d0b43b19e10bee82109b635b3b7ce4f43650a3
Change-Id: I3a99e416be9f3f04175939e4560f8f7c55497185
Reviewed-on: https://gerrit.libreoffice.org/14388
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/10831
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 4feaf96f50fa89eccb4e7a638220099e9a8482f1)
sensible indenting, fdo#81596 related
(cherry picked from commit 3dd241c52d6db424bd4696ff8f223976542e411b)
simplify RewriteMissing() and switch in Add...(), fdo#81596 related
(cherry picked from commit 14aabee5a73e57e26b2062b1ebf00c3f1dff1250)
write TRUE() for 2nd IF() parameter, fdo#81596 related
(cherry picked from commit 8f031861f590ba914321816657a003375d93ef5d)
f7eb11a950b45793d04837d02f9546a93673fa2f
f2ca37e1fda87ce56282fc2d2fc57a0784851139
52d0b43b19e10bee82109b635b3b7ce4f43650a3
Change-Id: I3a99e416be9f3f04175939e4560f8f7c55497185
Reviewed-on: https://gerrit.libreoffice.org/14388
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Resolves: tdf#86159 floating windows have complicated borders
take the border window dimensions into account on the
layout size, but not the layout position
(cherry picked from commit d1f38b47c29ef5e2db2cabeb657668637d97e13d)
Conflicts:
include/vcl/syswin.hxx
Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d
Reviewed-on: https://gerrit.libreoffice.org/14480
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
take the border window dimensions into account on the
layout size, but not the layout position
(cherry picked from commit d1f38b47c29ef5e2db2cabeb657668637d97e13d)
Conflicts:
include/vcl/syswin.hxx
Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d
Reviewed-on: https://gerrit.libreoffice.org/14480
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
tdf#78174: toolkit: work around GCC 4.9 -Os link failure
A build with gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) for 32-bit x86
fails because of these undefined symbols:
> nm --demangle workdir/CxxObject/svx/source/fmcomp/fmgridif.o | grep
\\bWindowListenerMultiplexer::acquire
U non-virtual thunk to WindowListenerMultiplexer::acquire()
They should probably be generated inline. Work around by out-lining the
definition of the methods.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64812
Change-Id: I318f7c39bdf1243be385bc6dc0a47862b22e92c5
(cherry picked from commit 6b3aa0fe4094e87290bd33a30bd6cd99ee78ce38)
Reviewed-on: https://gerrit.libreoffice.org/14509
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
A build with gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) for 32-bit x86
fails because of these undefined symbols:
> nm --demangle workdir/CxxObject/svx/source/fmcomp/fmgridif.o | grep
\\bWindowListenerMultiplexer::acquire
U non-virtual thunk to WindowListenerMultiplexer::acquire()
They should probably be generated inline. Work around by out-lining the
definition of the methods.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64812
Change-Id: I318f7c39bdf1243be385bc6dc0a47862b22e92c5
(cherry picked from commit 6b3aa0fe4094e87290bd33a30bd6cd99ee78ce38)
Reviewed-on: https://gerrit.libreoffice.org/14509
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
tdf#84514: don't hide grid along with checkbox if not needed
Regression from .ui migration, which unconditionally (and wrongly)
hides the grid with radiobuttons. Do what the old code did - hide
the whole frame iff the grid has been hidden already.
Change-Id: Ia9dc8b166f4031b4c07fbb1969908d314cc3456c
Reviewed-on: https://gerrit.libreoffice.org/14511
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Regression from .ui migration, which unconditionally (and wrongly)
hides the grid with radiobuttons. Do what the old code did - hide
the whole frame iff the grid has been hidden already.
Change-Id: Ia9dc8b166f4031b4c07fbb1969908d314cc3456c
Reviewed-on: https://gerrit.libreoffice.org/14511
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Resolves: tdf#39316 add matrix empty cells to ScInterpreter::QueryMatrixType()
(cherry picked from commit eccbc97c7c224269fe261b8924e7866c3758ec91)
add ScMatrix::IsEmptyResult() for tdf#39316 fix preparation
(cherry picked from commit cf3f1d8dfeb45249eb60a30dba3243fe9a4a65e5)
9f2a3e6fa9f4ef43df672661afef996269b90a7a
Change-Id: Ifa5d59e90afcfff66f2e8683fac2a9090ed615da
Reviewed-on: https://gerrit.libreoffice.org/14428
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit eccbc97c7c224269fe261b8924e7866c3758ec91)
add ScMatrix::IsEmptyResult() for tdf#39316 fix preparation
(cherry picked from commit cf3f1d8dfeb45249eb60a30dba3243fe9a4a65e5)
9f2a3e6fa9f4ef43df672661afef996269b90a7a
Change-Id: Ifa5d59e90afcfff66f2e8683fac2a9090ed615da
Reviewed-on: https://gerrit.libreoffice.org/14428
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
fdo#88547 allow inline date-arrays for array functions
(Cherry-picked from: I090633944f6514964949566ffe94038b565abff4)
(Reviewed-on: https://gerrit.libreoffice.org/14019)
Change-Id: Iae5f3d1f80dbddfc58d73cfb4642a7809cfc155c
Reviewed-on: https://gerrit.libreoffice.org/14477
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(Cherry-picked from: I090633944f6514964949566ffe94038b565abff4)
(Reviewed-on: https://gerrit.libreoffice.org/14019)
Change-Id: Iae5f3d1f80dbddfc58d73cfb4642a7809cfc155c
Reviewed-on: https://gerrit.libreoffice.org/14477
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
fix windows build
Why do we backport unit tests?
Change-Id: I052eefa4ab84db49d396d871c0b594d10f317e3c
Why do we backport unit tests?
Change-Id: I052eefa4ab84db49d396d871c0b594d10f317e3c
tdf#88624 set DocumentBaseURL when saving report
regression from 1d38cb365543924f9c50014e6b2227e77de1d0c9
Change-Id: Ia8cfe47b9d92889b3724f394db5090a59e69dd48
Reviewed-on: https://gerrit.libreoffice.org/14494
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
regression from 1d38cb365543924f9c50014e6b2227e77de1d0c9
Change-Id: Ia8cfe47b9d92889b3724f394db5090a59e69dd48
Reviewed-on: https://gerrit.libreoffice.org/14494
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
related tdf#89004 improve performance of document data collection
Change-Id: Ieca50aa0920753cd952123e27d5355d32e82c918
Change-Id: Ieca50aa0920753cd952123e27d5355d32e82c918
tdf#89004 improve performance of document data collection
Change-Id: Ie74495745b48d721c7dda0b447fc59066c869874
Change-Id: Ie74495745b48d721c7dda0b447fc59066c869874
tdf#68117 Partially fix boolean labels in XLSX
Change-Id: I731a58c7749e157f6b40c60808687ce629683742
Reviewed-on: https://gerrit.libreoffice.org/14410
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Change-Id: I731a58c7749e157f6b40c60808687ce629683742
Reviewed-on: https://gerrit.libreoffice.org/14410
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
tdf#89330 preserve file name case in an unresolvable external named range
Reviewed-on: https://gerrit.libreoffice.org/14474
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 0a9e7293a570da8a36b2ac4fd1c4a22d6bc084f2)
add unittest for tdf#89330
Reviewed-on: https://gerrit.libreoffice.org/14473
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit e4882717f3dc0375e113ed692374870ab8302a16)
4c5c65733700e7e7245e96f85714221acf23bcfb
Change-Id: Ib8728a4a9c793b162de07a0cef66e242879f2aa1
Reviewed-on: https://gerrit.libreoffice.org/14479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/14474
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 0a9e7293a570da8a36b2ac4fd1c4a22d6bc084f2)
add unittest for tdf#89330
Reviewed-on: https://gerrit.libreoffice.org/14473
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit e4882717f3dc0375e113ed692374870ab8302a16)
4c5c65733700e7e7245e96f85714221acf23bcfb
Change-Id: Ib8728a4a9c793b162de07a0cef66e242879f2aa1
Reviewed-on: https://gerrit.libreoffice.org/14479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Resolves: tdf#89227 if no SwView then disable accept/reject change buttons
e.g. if the context is an embedded draw ole then we don't have a SwView
Change-Id: I6ba07f0ecf1c419e45f7e0ac628a82e6bd486668
(cherry picked from commit 25dd3d277e9b90a59e7b2a03202ef0cba7799b68)
Reviewed-on: https://gerrit.libreoffice.org/14454
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
e.g. if the context is an embedded draw ole then we don't have a SwView
Change-Id: I6ba07f0ecf1c419e45f7e0ac628a82e6bd486668
(cherry picked from commit 25dd3d277e9b90a59e7b2a03202ef0cba7799b68)
Reviewed-on: https://gerrit.libreoffice.org/14454
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
tdf#89281 fix performance regression of XLS import
The fix for Bug 76611 caused ~20% performance loss in XLS import.
With optional cloning of ScTokenArray of the shared XLS formulas
depending on the need of address wrapping, it is possible to gain
back near the original performance.
Note: The original patch for Bug 76611 has already got an unit test,
too (see wrapped-refs.xls), and that unit test works with this
improved patch, too.
Cherry picked from master:
ba686b9bd2596811141e4028947334f10799c356 cleanup
b18b5b7edf3d14ef5f0efe53e367f88a423088c4 first commit
Change-Id: Ibfb59d1543ef9c4b8a075d5c4e37f77ab451aaa0
Reviewed-on: https://gerrit.libreoffice.org/14393
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
The fix for Bug 76611 caused ~20% performance loss in XLS import.
With optional cloning of ScTokenArray of the shared XLS formulas
depending on the need of address wrapping, it is possible to gain
back near the original performance.
Note: The original patch for Bug 76611 has already got an unit test,
too (see wrapped-refs.xls), and that unit test works with this
improved patch, too.
Cherry picked from master:
ba686b9bd2596811141e4028947334f10799c356 cleanup
b18b5b7edf3d14ef5f0efe53e367f88a423088c4 first commit
Change-Id: Ibfb59d1543ef9c4b8a075d5c4e37f77ab451aaa0
Reviewed-on: https://gerrit.libreoffice.org/14393
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
tdf#88576 fix handling of empty arguments in IF(), IFERROR() and IFNA()
Reviewed-on: https://gerrit.libreoffice.org/14415
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 0b75eda1090f92adc678ceff2565da2dc7d9328c)
tdf#88576 check that two parameters are given for IFERROR() and IFNA()
Otherwise the functions failed only for the error case resulting in
#NULL! error.
(cherry picked from commit 6583f4e30015164af4972921b5bb7880dfb65f65)
eb987637698ab418fc0a60cd873e23878c9f497b
Change-Id: I8acca26cf7398768a9e25f97f3a9e61754ab2179
Reviewed-on: https://gerrit.libreoffice.org/14421
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/14415
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 0b75eda1090f92adc678ceff2565da2dc7d9328c)
tdf#88576 check that two parameters are given for IFERROR() and IFNA()
Otherwise the functions failed only for the error case resulting in
#NULL! error.
(cherry picked from commit 6583f4e30015164af4972921b5bb7880dfb65f65)
eb987637698ab418fc0a60cd873e23878c9f497b
Change-Id: I8acca26cf7398768a9e25f97f3a9e61754ab2179
Reviewed-on: https://gerrit.libreoffice.org/14421
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Resolves: tdf#79569 crash undoing tricky cell merge
Change-Id: I68d774d0d3758cdb67864d7939a7e1167dd9a7df
(cherry picked from commit 21796a5fb92fd9773017b782a654a8b5a190cc66)
Reviewed-on: https://gerrit.libreoffice.org/14467
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Change-Id: I68d774d0d3758cdb67864d7939a7e1167dd9a7df
(cherry picked from commit 21796a5fb92fd9773017b782a654a8b5a190cc66)
Reviewed-on: https://gerrit.libreoffice.org/14467
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Resolves: tdf#76636 crash on merging certain cells imported from a .doc
Change-Id: I61d5088a6f2e0b444b2943a2f9ce9feeb2e09c11
(cherry picked from commit e1f4022b9ea7ae99a31773c445d8229ba3bdea93)
Reviewed-on: https://gerrit.libreoffice.org/14463
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Change-Id: I61d5088a6f2e0b444b2943a2f9ce9feeb2e09c11
(cherry picked from commit e1f4022b9ea7ae99a31773c445d8229ba3bdea93)
Reviewed-on: https://gerrit.libreoffice.org/14463
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Resolves: tdf#81429 select corresponding listbox entry if not current
Change-Id: Ib475a43601ee22d33677ac45cd6ef9dba7e7c431
(cherry picked from commit a448f1bb9221f30f73574c580b506e00bf2ae61a)
Reviewed-on: https://gerrit.libreoffice.org/14457
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: Ib475a43601ee22d33677ac45cd6ef9dba7e7c431
(cherry picked from commit a448f1bb9221f30f73574c580b506e00bf2ae61a)
Reviewed-on: https://gerrit.libreoffice.org/14457
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>