LibreOffice.git
8 years agoVersion 4.1.2.3, tag libreoffice-4.1.2.3libreoffice-4.1.2.3
Christian Lohmaier [Sat, 28 Sep 2013 23:20:00 +0000 (29 01:20 +0200)]
Version 4.1.2.3, tag libreoffice-4.1.2.3

Change-Id: I21273546478832a1b908a0b8c9803b7a650a980c

8 years agobump product version to 4.1.2.3
Christian Lohmaier [Sat, 28 Sep 2013 23:14:02 +0000 (29 01:14 +0200)]
bump product version to 4.1.2.3

Change-Id: Icbc3be5ca3191614c8cfccdb51c7a5e4f18b79ad

8 years agoUpdated core
Christian Lohmaier [Sat, 28 Sep 2013 21:51:48 +0000 (28 23:51 +0200)]
Updated core
Project: translations  e59e79bddc8238831c8fcb955cdafb56cf62994d

8 years agofdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.
Michael Meeks [Fri, 27 Sep 2013 13:59:32 +0000 (27 15:59 +0200)]
fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.

Change-Id: Ib971824a7f274334012b872acec65310535ad767
Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Signed-off-by: Norbert Thiebaud <nthiebaud@gmail.com>
Signed-off-by: Caolán McNamara <caolanm@redhat.com>
8 years agoResolves: fdo#69220 crash in doc (ww6)
Caolán McNamara [Wed, 18 Sep 2013 09:22:29 +0000 (18 10:22 +0100)]
Resolves: fdo#69220 crash in doc (ww6)

Change-Id: I5a09d121a0b0342f28ba5d2d39027b27e9c9eba2
(cherry picked from commit 2e93541d00f9d4aaa6ad2aeb35ee0c901d216cc0)
Reviewed-on: https://gerrit.libreoffice.org/5991
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
8 years agoResolves: fdo#69440 only ask for tabcontrol in builder dialogs
Caolán McNamara [Wed, 18 Sep 2013 09:51:53 +0000 (18 10:51 +0100)]
Resolves: fdo#69440 only ask for tabcontrol in builder dialogs

(cherry picked from commit d4edce3b72d585915516a0a27c4815a0d4996cfb)

Change-Id: I6001f8921f3b90283525355b0094c4377c42c663
Reviewed-on: https://gerrit.libreoffice.org/5993
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
8 years agovalgrind: init. member variables
David Tardon [Mon, 27 May 2013 11:18:07 +0000 (27 13:18 +0200)]
valgrind: init. member variables

Change-Id: I7e0d99f549841d466d5dfb69cde74b424ae98b0b
(cherry picked from commit 38797f7f4129e1e09be9308a36311cf2f1afef79)
(cherry picked from commit 86128f3b24a830df87db4ed2f7176d84ede7230f)
Reviewed-on: https://gerrit.libreoffice.org/5995
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
8 years agobump product version to 4.1.2.2.0+
Christian Lohmaier [Wed, 18 Sep 2013 00:35:36 +0000 (18 02:35 +0200)]
bump product version to 4.1.2.2.0+

Change-Id: I9967fba187bdf6c9c2fcce0b95d8664533cc596a

8 years agoUpdated core
Christian Lohmaier [Tue, 17 Sep 2013 15:34:13 +0000 (17 17:34 +0200)]
Updated core
Project: translations  36fc2c0c4f118dc2ab7952679c79516caf167445

8 years agofdo#68210: Make tiff import work again with merged-libs
Bjoern Michaelsen [Wed, 4 Sep 2013 14:33:43 +0000 (4 16:33 +0200)]
fdo#68210: Make tiff import work again with merged-libs

- there was a symbol mismatch for dynamic loading
- this fixes fdo#68210 and the other dynamically loaded functionality
- this also includes Change-Id: I6041ca10f58335187928995368db673c1ce22e7b
- this also includes Change-Id: Ie59f2ba4daec0375d1d64b765be3b1484e8cba3e
  (tests that ensure the master to be broken arent that helpful)

Change-Id: I7e4d6baf256dbe7b145dcbc118b4cac2075e07f5
Reviewed-on: https://gerrit.libreoffice.org/5813
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoResolves: fdo#68081 why would I want a spinner that doesn't repeat
Caolán McNamara [Fri, 6 Sep 2013 11:22:50 +0000 (6 12:22 +0100)]
Resolves: fdo#68081 why would I want a spinner that doesn't repeat

surely WB_SPIN should imply repeat in the first place, *shrug*

Change-Id: I1e4cb5a01d473cd0f8d907d566cd26d51a81da93
(cherry picked from commit f96771165ea145a759f1bab76cd34bb70def04f6)
Reviewed-on: https://gerrit.libreoffice.org/5840
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
8 years agofdo#69041 LibreLogo: fix SVG/SMIL timing with filled polylines
László Németh [Fri, 6 Sep 2013 15:30:25 +0000 (6 17:30 +0200)]
fdo#69041 LibreLogo: fix SVG/SMIL timing with filled polylines

Change-Id: Icebd47d57a830986c371a62ec7dab81ca8fd930a
Reviewed-on: https://gerrit.libreoffice.org/5846
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#65330 fix meta.xml of AbstractYellow.otp
Andras Timar [Sun, 8 Sep 2013 09:49:33 +0000 (8 11:49 +0200)]
fdo#65330 fix meta.xml of AbstractYellow.otp

title was Abstract Green instead of Abstract Yellow

Change-Id: I80344940d96163809b889482334f02bb4f7a124f
Reviewed-on: https://gerrit.libreoffice.org/5873
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agofix validity dialog with lists, fdo#65686
Markus Mohrhard [Sat, 7 Sep 2013 10:52:21 +0000 (7 12:52 +0200)]
fix validity dialog with lists, fdo#65686

regression from b0cf3aba085373d84a55ef144b273a8a89d017af

Change-Id: Ia3d39e02f35f3e23d93c7fe771bdbeb6eb3d2caf
Reviewed-on: https://gerrit.libreoffice.org/5856
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/5880
Reviewed-by: Andras Timar <andras.timar@collabora.com>
8 years agofdo#68313 fix combining diacritics problem with Graphite fonts
László Németh [Fri, 6 Sep 2013 09:08:02 +0000 (6 11:08 +0200)]
fdo#68313 fix combining diacritics problem with Graphite fonts

Change-Id: Ied29f864dc5fc21fc55aaa5ddd40b02b53a564f8

8 years agoFix misspelled text with VoiceOver on 10.9
Boris Dušek [Thu, 5 Sep 2013 22:19:36 +0000 (6 00:19 +0200)]
Fix misspelled text with VoiceOver on 10.9

More in Apple's docs (Application Kit Release Notes for OS X v10.9,
section "New Accessibility constants").

Change-Id: I92fb6d552e86997bfc789723f32626d908d11419
Reviewed-on: https://gerrit.libreoffice.org/5834
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agobump product version to 4.1.2.1.0+
Christian Lohmaier [Tue, 3 Sep 2013 19:08:39 +0000 (3 21:08 +0200)]
bump product version to 4.1.2.1.0+

8 years agobDel is unused uninitialized
Caolán McNamara [Mon, 2 Sep 2013 20:26:49 +0000 (2 21:26 +0100)]
bDel is unused uninitialized

Change-Id: Idac3a6805700d896b8569d1df79d32ca493c48b3
(cherry picked from commit 91a557561c24c7532c525692f279b1fcfd520f92)
Reviewed-on: https://gerrit.libreoffice.org/5764
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
8 years agon#816593: docx consecutive tables with different tblpPr needs to be split
Cédric Bosdonnat [Fri, 31 May 2013 08:51:47 +0000 (31 10:51 +0200)]
n#816593: docx consecutive tables with different tblpPr needs to be split

When importing docx with 2 <w:tbl> following each other, we have 2
possible behaviors: either merge them as one table as we did before or
split them into two tables. The tables need to be split if they have
different floating position properties.

This required the ooxml tokenizer to repeat the table properties for
each row of the table: or how would we know we don't need to split the
table?

The basic idea behind this hack is to temporarily store the table
position and table properties before saving them. Thus we can compare
them at the end of the row and decide to split the table or not.

(cherry picked from commit 173d24a7316fccf0e838f71b92c10a772b19298d)

Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: I2e3e70dfe7386090fe356575ee9d0e81aa031dc4

8 years agon#816593: Floating table width import fix: adjust the frame width
Cédric Bosdonnat [Wed, 22 May 2013 09:34:01 +0000 (22 11:34 +0200)]
n#816593: Floating table width import fix: adjust the frame width

(cherry picked from commit 9f4c8a8bca06b4c2a916a51909367b453fc41a8b)

Change-Id: I8212bc5981418f6cbd514bf5002e6a5dbdf53152
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
8 years agoResolves: rhbz#993963 NULL m_pWindow on firefox deleted plugin
Caolán McNamara [Tue, 3 Sep 2013 11:24:34 +0000 (3 12:24 +0100)]
Resolves: rhbz#993963 NULL m_pWindow on firefox deleted plugin

Change-Id: Idb12b12e4313668bf3390a97551c688ee0dcde67
(cherry picked from commit 4a4ed52e57b540167c3ca45e6e762b9e21e874de)
Reviewed-on: https://gerrit.libreoffice.org/5773
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
8 years agofdo#68750: ensure that GetSuggestedEndOfSentence makes progress
Michael Stahl [Mon, 2 Sep 2013 13:58:00 +0000 (2 15:58 +0200)]
fdo#68750: ensure that GetSuggestedEndOfSentence makes progress

Checking a string of 17399 spaces takes 20 seconds here in
GrammarCheckingIterator::GetSuggestedEndOfSentence() because
BreakIterator_Unicode::endOfSentence() will always return
0 as a result regardless of what nStartPos it gets.

Change-Id: Id02440a91d7015c2896e387854445ee5383092fa
(cherry picked from commit b23999755a865a277c29adfc1dc0c249275bfd7e)
Reviewed-on: https://gerrit.libreoffice.org/5758
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agostop annoying temp full screen windows appearing on insert->index entry
Caolán McNamara [Mon, 2 Sep 2013 19:53:13 +0000 (2 20:53 +0100)]
stop annoying temp full screen windows appearing on insert->index entry

Change-Id: I730617f5ce28149f79d1d22efbfb7eab22e5840d
(cherry picked from commit 8f6b90a80c7b6e1c19422e944ca49657581e1042)
Reviewed-on: https://gerrit.libreoffice.org/5761
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoResolves: fdo#68794 blank placeholders when there is no known language yet
Caolán McNamara [Mon, 2 Sep 2013 10:00:05 +0000 (2 11:00 +0100)]
Resolves: fdo#68794 blank placeholders when there is no known language yet

Change-Id: I7f43144bd61ddc575d8b7094567433fdfd5ee291
(cherry picked from commit f42768fe0b60ecbbe9c68d775329bf28c0690131)
Reviewed-on: https://gerrit.libreoffice.org/5751
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoUpdated core
Andras Timar [Mon, 2 Sep 2013 20:11:26 +0000 (2 22:11 +0200)]
Updated core
Project: translations  ff3cff1f9e31f89c0648340f952dcb52a0403aaa

8 years agofdo#67584: remove .uno:FlipVertical from WriterCommands.xcu
Ivan Timofeev [Sun, 1 Sep 2013 13:48:32 +0000 (1 17:48 +0400)]
fdo#67584: remove .uno:FlipVertical from WriterCommands.xcu

mismerge in c991fb49aa174f300be0b978d89bc63e01e0aa2b

Change-Id: I7d890495bac0fa1a458a86c8625158c94cdba717
(cherry picked from commit 58aa737b2a37fa939580ee65f8976a13870b1de9)
Reviewed-on: https://gerrit.libreoffice.org/5741
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agofdo#42434: swap flipvertical and fliphorizontal icons in some themes
Ivan Timofeev [Sun, 1 Sep 2013 06:08:38 +0000 (1 10:08 +0400)]
fdo#42434: swap flipvertical and fliphorizontal icons in some themes

Change-Id: I484a783547c3bed1d80a0f510434b4c0fe37bed7
(cherry picked from commit 07aefbe310cad43bf9a71ba073486cddd7e062f2)
Reviewed-on: https://gerrit.libreoffice.org/5725
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agofdo#68689 Sub-divide ruler ticks into 1/8 insted of 1/10 for inch
Tomaž Vajngerl [Fri, 30 Aug 2013 17:38:53 +0000 (30 19:38 +0200)]
fdo#68689 Sub-divide ruler ticks into 1/8 insted of 1/10 for inch

Change-Id: Ied2a6982d5564228b0ce7fecb89723f3742b6d0d
Reviewed-on: https://gerrit.libreoffice.org/5726
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agocppcheck: Array index is used before limits check
Julien Nabet [Sat, 31 Aug 2013 19:08:42 +0000 (31 21:08 +0200)]
cppcheck: Array index is used before limits check

Change-Id: I531430ce4bc0937a023d3e2849ae07d8f94e3e70
Reviewed-on: https://gerrit.libreoffice.org/5723
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
8 years agofdo#41068: writerfilter: fix image wrap polygon import
Michael Stahl [Fri, 30 Aug 2013 17:13:40 +0000 (30 19:13 +0200)]
fdo#41068: writerfilter: fix image wrap polygon import

Mainly the problem seems to be that Stein's GCD algorithm requires
non-negative input parameters, and the document has this:
 <wp:lineTo x="-480" y="6104"/>

(regression from 86898639d4144a078ed295d0a8bef406868802cb)

Change-Id: I8da1272c3caae84f43472aa4acb65ed66dfbd8ae
(cherry picked from commit f8307e5ae11e8235fa1fb88ed52625bf9c650dc2)
Reviewed-on: https://gerrit.libreoffice.org/5700
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agoresolved fdo#67836 do not overwrite already interpreted English cell
Eike Rathke [Fri, 30 Aug 2013 20:23:01 +0000 (30 22:23 +0200)]
resolved fdo#67836 do not overwrite already interpreted English cell

... with a not matching locale dependent interpretation

Change-Id: I66553627cab282ed333443ee8bf687596a616a28
(cherry picked from commit a6fdfb960ad0f5b019adff700d0046f20a740996)
Reviewed-on: https://gerrit.libreoffice.org/5712
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
8 years agoResolves: fdo#68396 Yield allowed layout timer to run during init layout
Caolán McNamara [Fri, 30 Aug 2013 13:18:40 +0000 (30 14:18 +0100)]
Resolves: fdo#68396 Yield allowed layout timer to run during init layout

There are multiple pages getting generated in the styles dialog because the
dropcaps preview window calls "Yield" sometimes and sometimes the layout timer
gets a chance to activate *during* the creation of the dialog so there ends up
with two consecutive activations of some tabpages which has wonderful eventual
know on effects resulting in that crash later on.

Easiest thing is to disable the layout timer during the initial size
calculation

Change-Id: I7fb0a7ff89aa2c6013c5d8014deface107610000
(cherry picked from commit fe1cbda3b7513e0d3686d347aa991e7231067384)
Reviewed-on: https://gerrit.libreoffice.org/5696
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
8 years agoRelated: fdo#66700 don't crash on setting zoom state with no SfxObjectShell
Caolán McNamara [Fri, 30 Aug 2013 15:06:44 +0000 (30 16:06 +0100)]
Related: fdo#66700 don't crash on setting zoom state with no SfxObjectShell

(cherry picked from commit dd0f6c737b6af659389e473296e939ec6cfa5f4e)

Conflicts:
sfx2/source/appl/appserv.cxx

Change-Id: Id2943c92ce6deaae3e4d507a35c08466db21cece
Reviewed-on: https://gerrit.libreoffice.org/5697
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
8 years agoLibreLogo fixes (eg. fdo#68713 fix SVG cropping), see ChangeLog
László Németh [Thu, 29 Aug 2013 16:36:16 +0000 (29 18:36 +0200)]
LibreLogo fixes (eg. fdo#68713 fix SVG cropping), see ChangeLog

Conflicts:

helpcontent2

Change-Id: Ibb1cb41f526b4117e2d7ef39a2101286511bf48f
Reviewed-on: https://gerrit.libreoffice.org/5687
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoTPropertyValueLessFunctor must actually compare for "<"
Stephan Bergmann [Thu, 29 Aug 2013 14:05:01 +0000 (29 16:05 +0200)]
TPropertyValueLessFunctor must actually compare for "<"

Change-Id: I584a410d90531a0f7b784e62f94c39e715713cf1
(cherry picked from commit 2410b3c3ddc6fea02dadd56b39bb1181312c383a)
Reviewed-on: https://gerrit.libreoffice.org/5683
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#67313: Use "lo" suffix for private URE libs
Stephan Bergmann [Tue, 27 Aug 2013 11:58:52 +0000 (27 13:58 +0200)]
fdo#67313: Use "lo" suffix for private URE libs

...(like is done for most of LO's non-URE libs already) to reduce likelihood of
name clashes, esp. on Windows where URE libs are found via PATH.

This introduces PRIVATELIBS_URE, and [does not remove not-yet]-unused UNOLIBS_URE.

(cherry picked from commit 644c33a857c46d540202189228f519946dc33833)
Conflicts:
Repository.mk
solenv/gbuild/Helper.mk
solenv/gbuild/platform/IOS_ARM_GCC.mk
solenv/gbuild/platform/WNT_INTEL_GCC.mk
solenv/gbuild/platform/android.mk
solenv/gbuild/platform/com_MSC_class.mk
solenv/gbuild/platform/macosx.mk
solenv/gbuild/platform/mingw.mk
solenv/gbuild/platform/solaris.mk
solenv/gbuild/platform/unxgcc.mk

Change-Id: Ib95dd45f18de140a54e62d632dbf2239f83c232e
Reviewed-on: https://gerrit.libreoffice.org/5667
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
8 years agoAllow to set EXTRA_BUILDID also via environment variable (fdo#58034)
Petr Mladek [Thu, 29 Aug 2013 12:50:58 +0000 (29 14:50 +0200)]
Allow to set EXTRA_BUILDID also via environment variable (fdo#58034)

This is much easier with tinderboxed that work with static autogen.input

Change-Id: Ifb0b7884bbad14a286023b3dbd7d1d2a12f36787
Reviewed-on: https://gerrit.libreoffice.org/5679
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
8 years agofdo#66215: sw: fix clicking on text above background fly
Michael Stahl [Wed, 28 Aug 2013 12:16:38 +0000 (28 14:16 +0200)]
fdo#66215: sw: fix clicking on text above background fly

SwPageFrm::GetCrsrOfst() tries to compare the distance to the closest
text vs. fly but does not do it right because GetCharRect()
returns just a line of width 1 on the left edge of the character;
try to figure out the entire area covered by the character via 2 calls
to GetCrsrOfst(), which gives much better clickability.

(regression from e8fbe97900f13305b17015d9044993bde4adab36)

Change-Id: I825e86daf65692dfb962ad576772c5f543d02d19
(cherry picked from commit edd2db1c783bd571ff796a5298385cacc91877b9)
Reviewed-on: https://gerrit.libreoffice.org/5660
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#67358: sw: "fix" line painting artifacts when resizing columns
Michael Stahl [Wed, 28 Aug 2013 12:28:40 +0000 (28 14:28 +0200)]
fdo#67358: sw: "fix" line painting artifacts when resizing columns

SwEditWin::MouseButtonDown(): for unknown reasons invalidating the
window here causes the column resizing lines to not be removed after the
resize is done, so disable it.

(regression from 289185fd02d6d9734b6dbde01f15c4e6c5beacbb)

Change-Id: If3ba0a72c53c5c2734fb905ae35d62f6a3e8938b
(cherry picked from commit a2c67975c03010b90c706523293f180c1f29e229)
Reviewed-on: https://gerrit.libreoffice.org/5661
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agoFix loplugin error: checking whether a config macro EXTRA_BUILDID is defined.
Tor Lillqvist [Thu, 29 Aug 2013 11:50:10 +0000 (29 14:50 +0300)]
Fix loplugin error: checking whether a config macro EXTRA_BUILDID is defined.

Change-Id: Ieb04a8da4dc54b41f4df1d63b5e70ffb7ca7bb01

8 years agofdo#68648: SvxNumRule: serialize the aFmtsSet flags too
Michael Stahl [Wed, 28 Aug 2013 21:19:43 +0000 (28 23:19 +0200)]
fdo#68648: SvxNumRule: serialize the aFmtsSet flags too

The constructor of SvxNumRule initializes aFmts[i] with a format but
always sets aFmtsSet[i] to false, so SvxNumRule::Store()
and SvxNumRule::SvxNumRule(SvStream &rStream) need to be able
to round-trip that combination to prevent spurious numberings.

It is unlikely that this class is serialized in the table auto-format
files but i haven't checked; this change does not change the size of the
serialization so shouldn't cause trouble anyway.

(regression from a95cce27295f9cd255fa72eaded00972e3efb69b)

Change-Id: I589ea108ac069624aaa7b26cdc3bfe8182b15851
(cherry picked from commit 4b798d89a55714218dc9a7de161f93f9c4d6fc80)
Reviewed-on: https://gerrit.libreoffice.org/5671
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agorhbz#1001768: avoid deadlock in AccessibleEventNotifier
Michael Stahl [Tue, 27 Aug 2013 19:43:48 +0000 (27 21:43 +0200)]
rhbz#1001768: avoid deadlock in AccessibleEventNotifier

revokeClientNotifyDisposing(): drop the static lclMutex before calling
pListeners->disposeAndClear(), which may want to acquire the SolarMutex
and deadlock.

Change-Id: Ib35fc7fad6596450a3b10d58d5193b9b55c575cb
(cherry picked from commit cafff1bbc4effac74bbd2607fb83dd2547c8fa2e)
Reviewed-on: https://gerrit.libreoffice.org/5659
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agomake the tinderbox information more reliable in the about dialog (fdo#58034)
Petr Mladek [Thu, 29 Aug 2013 11:14:29 +0000 (29 13:14 +0200)]
make the tinderbox information more reliable in the about dialog (fdo#58034)

Pass the information via config_host/config_buildid.h. Then
cui/source/dialogs/about.cxx will get rebuilt also in the incremental build.

Change-Id: I058cbe162e7015cbea6c71253c20db097477708f
Reviewed-on: https://gerrit.libreoffice.org/5677
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoUpdated core
Caolán McNamara [Thu, 29 Aug 2013 10:52:10 +0000 (29 11:52 +0100)]
Updated core
Project: help  0d8b37cd9e0b89d1136b09a81671c88fc91fee3e

8 years agoResolves: fdo#68192 always recode from trad symbol to apple symbol
Caolán McNamara [Wed, 28 Aug 2013 19:22:26 +0000 (28 20:22 +0100)]
Resolves: fdo#68192 always recode from trad symbol to apple symbol

Even if the symbol font bit isn't set, the oox import route lacks the ability
to state that the bullet font is a font of symbol encoding. If the font is not
available on the system we go into fallback logic to state that famous symbol
fonts are in symbol encoding. But there is a symbol font on mac so its not
unknown and that doesn't happen. And the mac symbol font is not actually in
symbol encoding (seeing as it's all rearranged into the correct unicode
positions) so the recode logic is skipped in this special case to map the
microsoft/adobe private use area chars to the modern code points where they
were moved in the apple font.

I guess one alternative possible solution is to lookup all the fonts used in a
openxml doc using the fonttable stream where the charset info is available. But
seeing as it should only affect one particular font lets just move the encoder
test outside the issymbol block.

Change-Id: Ic5bd3ec15c8d8d99e2cab0fb67cc4bc33081c756
(cherry picked from commit b129867306ce918f4f8fbf9ec5f7dce86e52c9d2)
Reviewed-on: https://gerrit.libreoffice.org/5669
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoUpdated core
Caolán McNamara [Wed, 28 Aug 2013 10:21:05 +0000 (28 11:21 +0100)]
Updated core
Project: translations  e49890cde9c55dde50bcc9babe44c50906cc3ef3

8 years agoUpdated core
Andras Timar [Wed, 28 Aug 2013 09:28:03 +0000 (28 11:28 +0200)]
Updated core
Project: translations  f805dd3ebe91a1105979b21df554dba1f62c1bd9

8 years agoUploading libvisio 0.0.31, fixing fdo#68477
Fridrich Štrba [Wed, 28 Aug 2013 09:12:06 +0000 (28 11:12 +0200)]
Uploading libvisio 0.0.31, fixing fdo#68477

Base64 decoding in some boost versions throws on padding characters

(cherry picked from commit 710eb05b0fe7a4396dcec169d15c337d1664e9d4)

Conflicts:
download.lst

Change-Id: I9a9a43c2a7e55b6a6fca085302eae223bc8c1b13
Reviewed-on: https://gerrit.libreoffice.org/5656
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
8 years agoodbc insert: adjust buffer size *after* it is written to
Lionel Elie Mamane [Tue, 27 Aug 2013 16:03:21 +0000 (27 18:03 +0200)]
odbc insert: adjust buffer size *after* it is written to

the buffer (aBookmark) is written to by SQLBulkOperations or
SQLSetPos, not by SQLBindCol, which merely sets up the instruction
that the next call should write there. So its finak size is known
only *after* the call that makes the write, obviously.

Change-Id: I4faaaeffc060433645188f0eda3d9958b087cf6c
Reviewed-on: https://gerrit.libreoffice.org/5650
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#68315 odbc update *reads* a bookmark, not *writes* a bookmark
Lionel Elie Mamane [Tue, 27 Aug 2013 15:59:42 +0000 (27 17:59 +0200)]
fdo#68315 odbc update *reads* a bookmark, not *writes* a bookmark

This code was completely inverted. The row update operation
*reads* a bookmark (that is, what row to update), not *writes*
a bookmark.

So we were passing an empty bookmark, and thus the update was failing
because we were refering to a non-existent row.

Change-Id: I676b1a7727a88e13a3e465bd96cbbaf18dad2fa6
Reviewed-on: https://gerrit.libreoffice.org/5648
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agoFix iterator management
Julien Nabet [Sun, 25 Aug 2013 20:20:16 +0000 (25 22:20 +0200)]
Fix iterator management

Change-Id: Ifb230525d3f5462553a3e78bb4ee740f6a7cc5c2
Reviewed-on: https://gerrit.libreoffice.org/5629
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/5638
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agoRelated: fdo#68192 register bundled fonts
Caolán McNamara [Tue, 27 Aug 2013 15:40:53 +0000 (27 16:40 +0100)]
Related: fdo#68192 register bundled fonts

We have to register them one at a time, like windows, this means we detect our
bundled opensymbol which makes the "format->bullets and numbering" preview work
again.

Doesn't however fix fdo#68192 yet, more magic smoke required.

(cherry picked from commit 8efbafaf8681d39c8c3674368e02ddd572ba5d32)

Conflicts:
vcl/coretext/salgdi2.cxx

Change-Id: I430c91b48d96fb8d62e3b073898b72cf2b8ddea6
Reviewed-on: https://gerrit.libreoffice.org/5647
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agoResolves: fdo#67743 ensure user autocorr config dir exists
Caolán McNamara [Tue, 27 Aug 2013 13:35:18 +0000 (27 14:35 +0100)]
Resolves: fdo#67743 ensure user autocorr config dir exists

We try and copy the shared one to the user location the first time we create a
customized user file. If the dir doesn't exist then that migration doesn't
happen. The new autocorr file is then written, creating the dir, and any
further operations will reattempt the skipped share copy, and this time succeed
because the dir now exists.  Which overwrites the previously written customized
content.

This is similar to fdo#65501 "ensure configured backup dir exists before using
it", so reuse that code and move it into unotools.

Change-Id: I38fa621b8d7295d70b09172a028569ea95404120
(cherry picked from commit 68dea1c1b61a99cdef556ba7d8ccfdad1be8a663)
Reviewed-on: https://gerrit.libreoffice.org/5645
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agofdo#68581: The first paragraph text can be legitimately empty.
Kohei Yoshida [Mon, 26 Aug 2013 19:28:46 +0000 (26 15:28 -0400)]
fdo#68581: The first paragraph text can be legitimately empty.

Change-Id: I2309a0c6aebc8a111e67e2e3d591cbabfbbadfb4
(cherry picked from commit 969d5a3b97903fe32b3a7da0c3de8bf86f323c17)
Reviewed-on: https://gerrit.libreoffice.org/5637
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agofdo#66145 DOCX export: fix not-well-formed output
Adam Co [Sun, 21 Jul 2013 13:27:45 +0000 (21 16:27 +0300)]
fdo#66145 DOCX export: fix not-well-formed output

Reviewed-on: https://gerrit.libreoffice.org/5002
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
(partially cherry picked from commit 2d5978b22b402dea9dee5b468d2044ccc1208a15)

Change-Id: Id8cc3829ccd5806295b0f240a570dc1d66ed0c87
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
8 years agoResolves: fdo#68555 use (current) consistent ok/cancel/help button order
Caolán McNamara [Tue, 27 Aug 2013 09:39:05 +0000 (27 10:39 +0100)]
Resolves: fdo#68555 use (current) consistent ok/cancel/help button order

Change-Id: Id5bb5c48fe82229fe378500d7cacd36d8554707f
(cherry picked from commit 9d8cda2f54adc0af4abdc1fc9675e7bc9c94228c)
Reviewed-on: https://gerrit.libreoffice.org/5643
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofix uneditable field in memory option page
Faisal M. Al-Otaibi [Tue, 27 Aug 2013 05:20:54 +0000 (27 08:20 +0300)]
fix uneditable field in memory option page

this will fix an uneditable "remove from memory after" field

Change-Id: I0b47c4b8082d3244186596a7127f059bbb7214a5
Reviewed-on: https://gerrit.libreoffice.org/5640
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 93be66f98f3180cbbe358bb5b38f64852a0d30fc)
Reviewed-on: https://gerrit.libreoffice.org/5642
Reviewed-by: Jan Holesovsky <kendy@suse.cz>
Tested-by: Jan Holesovsky <kendy@suse.cz>
8 years agoResolves: fdo#59048 crash on text-to-table undo
Caolán McNamara [Mon, 26 Aug 2013 13:32:41 +0000 (26 14:32 +0100)]
Resolves: fdo#59048 crash on text-to-table undo

Delete the SwCellFrms attached to the layout of this SwTableNode early,
otherwise the SwCellFrms will dereference the SwTableNode after it is deleted
in _DeleteBox during the DelFrms of the DeleteSection in _DeleteBox when
invalidating following SwFrms.

SwUndoInsTbl::UndoImpl calls SwTableNode::DelFrms so presumably this is the
right way to go about it.

Change-Id: I6e088a30500d721bd18c57ced5c8ec331bb567eb
Reviewed-on: https://gerrit.libreoffice.org/5634
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 34f09dadd99a15aaad7fc8b982e01d6ec764c74c)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
8 years agobnc#834035 DOCX export: fix hyperlinks of illustration index
Miklos Vajna [Mon, 26 Aug 2013 09:05:04 +0000 (26 11:05 +0200)]
bnc#834035 DOCX export: fix hyperlinks of illustration index

We used to export raw Writer bookmarks, but that's not valid in OOXML.
Instead, it has normal bookmarks around the sequence fields, so use them
if they are available.

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
sw/source/filter/ww8/docxattributeoutput.cxx

(cherry picked from commits 750f0ebf97d19d1cf305dabe72d52ad6e90adf70,
e9275c08acc2f4f1c925f78b56a1089515cd9a37 and
8f146a8042dd8f3c88f39f8317372cd9c02ce4ad)

Change-Id: I0ef2ff7967c2802b53752c9505ef6db4cc2b8265
Reviewed-on: https://gerrit.libreoffice.org/5635
Reviewed-by: Jan Holesovsky <kendy@suse.cz>
Tested-by: Jan Holesovsky <kendy@suse.cz>
8 years agofdo#33960: sw: fix cross reference fields some more
Troy Rollo [Mon, 26 Aug 2013 13:14:40 +0000 (26 15:14 +0200)]
fdo#33960: sw: fix cross reference fields some more

Change-Id: I46f9cf4132835c10ad82c9b014e5e8647902ab5e
Signed-off-by: Michael Stahl <mstahl@redhat.com>
8 years agoUgly bad and nasty workaround for some dupplicate symbols issue
Fridrich Štrba [Mon, 26 Aug 2013 12:36:23 +0000 (26 14:36 +0200)]
Ugly bad and nasty workaround for some dupplicate symbols issue

Somehow, under same circumstances, MSVC creates object code for 2
inlined functions. Nobody here uses them, so simply define them away
so that there be no dupplicate symbols anymore.

The symbols extents and indices come from boost::multi_array.

(cherry picked from commit 5b734c8e19ceb38ec2f632b14fbbc753d95de77e)

Change-Id: I7283ecff340d95f16bb3a8d0aae97e166fa5f0e4
Reviewed-on: https://gerrit.libreoffice.org/5633
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agoresolved fdo#68437 append the bDetectSpecialNumber "true" string in options
Eike Rathke [Mon, 26 Aug 2013 12:08:08 +0000 (26 14:08 +0200)]
resolved fdo#68437 append the bDetectSpecialNumber "true" string in options

Regression introduced with 465dbaecf9890b7117a45d02ea982ef7aca32720

Change-Id: I7c05c7f246dddd0271c421aa358068365d44fb98
(cherry picked from commit aaa1bc40bb197968946c39d4c31c13588191bf55)
Reviewed-on: https://gerrit.libreoffice.org/5632
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoCreate the AppUserModelID registry values correctly
Jesús Corrius [Sat, 24 Aug 2013 11:55:46 +0000 (24 13:55 +0200)]
Create the AppUserModelID registry values correctly

This commit is a backport from master.

The original code is totally broken and creates useless
registry values in a wrong place.

The corrected patch allows LO to keep track of the MSO
file types opened by our application in the shell's
"recent documents" list.

Change-Id: I5db0a7f166ef73fe21a5f3fc891f86a91e1914d5
Reviewed-on: https://gerrit.libreoffice.org/5603
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agorhbz#1000150: Do not call exit upon XIOError
Stephan Bergmann [Fri, 23 Aug 2013 10:03:45 +0000 (23 12:03 +0200)]
rhbz#1000150: Do not call exit upon XIOError

...as done in _XIOError (libX11-1.6.0/src/XlibInt.c) after calling the XIOError
handler function (either the one supplied with XSetIOErrorHandler or
_XDefaultIOError), as that calls the atexit handlers, which can wreak havoc in
unrelated threads that happen to be running in parallel, leading to arbitrary
crashes.  So avoid that by always calling _exit already from our XIOError
handler.

The old code was careful to /not/ call _exit when the XIOError happened on any
thread but the main one, but I do not see the sense of that---after all,
_XIOError will inevitably call exit afterwards, so this cannot be a way to
"ignore" XIOErrors from special threads (that are set up say for the sole
purpose of trying out "known-shaky" activities without affecting the stability
of the whole process).  And findings like comment 12 to
<https://bugzilla.redhat.com/show_bug.cgi?id=831628#c12> "[abrt]
libreoffice-core-3.5.4.2-1.fc17: ICEConnectionWorker thread still running during
exit" ("it is very likely that this is not a normal exit from reaching the end
of main, but rather some explicit call to exit from some error handling code")
make it clear that we apparenly do suffer from such calls to _XIOError -> exit
on non-main threads.

I have no idea why vcl/unx/gtk has its own XIOErrorHdl that is substantially
different from the vcl/unx/generic one, though.

cherry picked from commit ffea65915b9cc6d4f3c01f829552702654a040f9, plus
follow-up b240a1c188b58e3e717335339bfc3f5e20bb2bf4:

    rhbz#1000150: Do not call exit upon XIOError, take two

    The _XDefaultIOError handler (libX11-1.6.0/src/XlibInt.c) already calls exit
    (even though _XIOError calling _XDefaultIOError would call exit afterwards,
    too), so our XIOError handler must not call aOrigXIOErrorHandler.

Change-Id: Ida7d407cf5f0fa4e719118cab5e725144ceb3a35
Reviewed-on: https://gerrit.libreoffice.org/5593
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoUpdated core
Andras Timar [Mon, 26 Aug 2013 06:33:54 +0000 (26 08:33 +0200)]
Updated core
Project: translations  0abb85f959149ee831719d944cb2a834e9744441

8 years agoFix build with compiler from OS X 10.6 SDK (hopefully)
Boris Dušek [Wed, 21 Aug 2013 06:23:44 +0000 (21 08:23 +0200)]
Fix build with compiler from OS X 10.6 SDK (hopefully)

The compiler in 10.6 SDK probably still requires methods to be defined in
such an order that one should not reference a method from a line of code
that precedes the one where the method is defined. Compilers in newer SDKs
support arbitrary order, as long as the requested method is defined
anywhere.

This is consistent with other methods in the same file that are not declared
anywhere (just defined and used apparently in the order I wrote above).

Change-Id: I14ba699056b6cdd2e804dbc87cfedaef47663664
Reviewed-on: https://gerrit.libreoffice.org/5577
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoDon't re-create Unicode and font functions for every text run
Khaled Hosny [Thu, 22 Aug 2013 20:57:54 +0000 (22 22:57 +0200)]
Don't re-create Unicode and font functions for every text run

Change-Id: I35ba21d753adfc619656d4473b214485dc00faba
Reviewed-on: https://gerrit.libreoffice.org/5599
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#66715: Avoid compatibility decomposition with HarfBuzz
Khaled Hosny [Thu, 22 Aug 2013 19:25:44 +0000 (22 21:25 +0200)]
fdo#66715: Avoid compatibility decomposition with HarfBuzz

Change-Id: Ibbf5720baf7fb507e66515104115d58597258b1d
Reviewed-on: https://gerrit.libreoffice.org/5598
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#68440 update Italian autocorrection
Andras Timar [Fri, 23 Aug 2013 13:19:27 +0000 (23 15:19 +0200)]
fdo#68440 update Italian autocorrection

Change-Id: I7f0dcccc5abf3ba0d0969973c4d0800095bfcca7
Reviewed-on: https://gerrit.libreoffice.org/5595
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#39484 - don't loose outlines while trying to undo formulae changes.
Michael Meeks [Thu, 22 Aug 2013 16:45:18 +0000 (22 17:45 +0100)]
fdo#39484 - don't loose outlines while trying to undo formulae changes.

Change-Id: Ib3b2bab5beffb8164a8cd2c0b4db4c97f427507e
Reviewed-on: https://gerrit.libreoffice.org/5592
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agofdo#68319: sw: fix Chinese Conversion
Michael Stahl [Fri, 23 Aug 2013 23:19:21 +0000 (24 01:19 +0200)]
fdo#68319: sw: fix Chinese Conversion

... and perhaps other things too: the SwScriptIterator constructor gets
passed a temporary String created by implicit conversion from OUString
and retains a reference to that; don't convert it to OUString like on
master but just cast to String.

(regression from 0295c8a34e39326414c1b98cf4da905802f061b0)

Change-Id: I30c7309c14ec8f9e41ee5fe89eed513ddad154fe
Reviewed-on: https://gerrit.libreoffice.org/5600
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoRelated: fdo#68396 FrameSelectorImpl draws before being initialized
Caolán McNamara [Thu, 22 Aug 2013 12:33:53 +0000 (22 13:33 +0100)]
Related: fdo#68396 FrameSelectorImpl draws before being initialized

Change-Id: Iae13a7484643117a6f0f40c298c95f6b2a2a4467
(cherry picked from commit ecf12c8286fece4e6f86dccbb37bff6794f0867e)
Reviewed-on: https://gerrit.libreoffice.org/5583
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoResolves: fdo#68275 Grayscale TIFF is imported as white
Caolán McNamara [Thu, 22 Aug 2013 14:06:10 +0000 (22 15:06 +0100)]
Resolves: fdo#68275 Grayscale TIFF is imported as white

this reverts 6c719c1585eb1a2dbab86cc73ff871da41765981 "n#615223 local nbyte1
should have been class-level nByte1" which was to fix the use seen
in valgrind og the uninitialized nByte1

So additionally remove the use of the uninit nByte1 entirely

Change-Id: I5b3f4fa00d74e545f207a11a5e90935f14a23a8e
(cherry picked from commit 98a61a2ae109f3d72940274ceafcf3e84d79aa0b)
Reviewed-on: https://gerrit.libreoffice.org/5584
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoWhat's it with all those *static* XSpreadsheetDocument instances?
Stephan Bergmann [Thu, 22 Aug 2013 12:33:51 +0000 (22 14:33 +0200)]
What's it with all those *static* XSpreadsheetDocument instances?

...appears to be completely unnecessary, and maybe this helps fix some obscure
DispsedException failures in JunitTest_sc_unoapi (not ones resulting from a
crashed soffice.bin, but "genuine" ones happening when chasing
util.AccessibilityTools.getAccessibleObjectForRole).

Change-Id: I127940e9a2a9784d01255307b60614d53c86436f
(cherry picked from commit 77dc93ddeaee5ee73c7b0afe49da7d699fe62e23)

Signed-off-by: Eike Rathke <erack@redhat.com>
8 years agofdo#66145: revert change to CopyMasterHeader
Michael Stahl [Mon, 19 Aug 2013 12:45:20 +0000 (19 14:45 +0200)]
fdo#66145: revert change to CopyMasterHeader

Not copying the nodes for first page is not an option; the real problem
with the fdo45183.rtf is that flys in the header are not copied
along with the nodes, like it is done in
SwDoc::CopyPageDescHeaderFooterImpl.

Also, the same problem may occur for footers too (CopyMasterFooter).

Conflicts:
sw/source/core/doc/docdesc.cxx

The comment above is for the master commit, but copyting the flys is
actually necessary with e1a9a348a519a69f898c9c1e6d87a5837b8267f9 too,
since that copying code is now executed when changing sharing flags in
the UI so withtout this commit you lose any flys anchored in the
header/footer.

(cherry picked from commit bf206549228685a68e1504db05119d8fa1d354b3)

Change-Id: I985a6b89f8cde96dc0fa0b489c44d77987f91a8a
Reviewed-on: https://gerrit.libreoffice.org/5541
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#66145: fix copying of header/footer when un-sharing
Michael Stahl [Tue, 20 Aug 2013 09:50:34 +0000 (20 11:50 +0200)]
fdo#66145: fix copying of header/footer when un-sharing

SwDoc::CopyMasterHeader/Footer(): this could result in sharing the
first-page header/footer with the left-page (!) when un-sharing
via the dialog; the reason is that what actually happens here is that
the left-page header/footer was never changed but the master one
was copied in SwDocStyleSheet::SetItemSet(), so it sort of worked
by accident before the first-page header/footer was added...

Change-Id: Ia24df6ad59cda484559f2ca48ecaa7563878120b
(cherry picked from commit e1a9a348a519a69f898c9c1e6d87a5837b8267f9)
Reviewed-on: https://gerrit.libreoffice.org/5532
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#66145: fix Undo invalidation in SwDoc::ChgPageDesc()
Michael Stahl [Tue, 20 Aug 2013 09:51:27 +0000 (20 11:51 +0200)]
fdo#66145: fix Undo invalidation in SwDoc::ChgPageDesc()

SwDoc::ChgPageDesc(): make the invalidation of the Undo stack on
change of IsFirstShared work by delaying ChgFirstShare() until after
the check.

Change-Id: Ifbefe446df8b6d785ed1bb6394ec5beb803fb1fe
(cherry picked from commit 0b7a823bb6df79384939dda4de3b7f28e5e52758)
Reviewed-on: https://gerrit.libreoffice.org/5531
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#66145: do not check IsFirstShared() in SwPageDesc::GetLeftFmt()
Michael Stahl [Tue, 20 Aug 2013 09:41:37 +0000 (20 11:41 +0200)]
fdo#66145: do not check IsFirstShared() in SwPageDesc::GetLeftFmt()

... and GetRightFmt().  If the first format is requested it must be
returned; the sharing works by copying the SwFmtHeader/Footer from
aMaster to the other members.

(regression from 4dc78aee9bcdb6ea5e9dc47ebb4a4b9e590c725a)

Change-Id: I1708f01c18b155ae75c14fc407e52ccd2bd798d7
(cherry picked from commit 4df438c9a9d5e698c47c1e85903eb81880a5e6fa)
Reviewed-on: https://gerrit.libreoffice.org/5530
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
8 years agofdo#68076 RTF import: default font had priority over the specified one
Miklos Vajna [Thu, 22 Aug 2013 09:21:25 +0000 (22 11:21 +0200)]
fdo#68076 RTF import: default font had priority over the specified one

Regression from 60c17b2873506ed8b068b34840aecda0c1d9bd65.

(cherry picked from commit f1e5e271f9aadc2c5e5af3ffae410b6c598e5398)

Change-Id: Ie16d611622e6a814d5cbea00c3f992cd9ecba027
Reviewed-on: https://gerrit.libreoffice.org/5579
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
8 years agodeb#719941: pythonscript.py: use open() instead of file()
Rene Engelhard [Wed, 21 Aug 2013 08:11:14 +0000 (21 10:11 +0200)]
deb#719941: pythonscript.py: use open() instead of file()

Change-Id: Ib9f06b2b5629d149e932fe37312fdf5e8448c39f
Signed-off-by: Michael Stahl <mstahl@redhat.com>
8 years agodeb#719941: unbreak python script provider debug logging on Python 3
Michael Stahl [Tue, 20 Aug 2013 15:16:16 +0000 (20 17:16 +0200)]
deb#719941: unbreak python script provider debug logging on Python 3

Don't mess with encoding in Logger.log, since sys.stdout.write()
accepts str (in python3) and both str/unicode (in python2) anyway.

Change-Id: Ib0339b7fd882a7654cc24c38efdaf67f519663ff
Signed-off-by: Michael Stahl <mstahl@redhat.com>
8 years agofdo#68381 take care of cell notes on Transpose
Laurent Godard [Wed, 21 Aug 2013 15:09:52 +0000 (21 17:09 +0200)]
fdo#68381 take care of cell notes on Transpose

Change-Id: I4272b45a1c8ad34b540ee39d9ef9dd717d4f6325
Reviewed-on: https://gerrit.libreoffice.org/5572
Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de>
Tested-by: Kohei Yoshida <kohei.yoshida@suse.de>
(cherry picked from commit 68dd91f9e9d9201287acb5825748954a5446f323)
Reviewed-on: https://gerrit.libreoffice.org/5575

8 years agofdo#53032 - Use the right mark area to undo paste of RTF.
Michael Meeks [Tue, 20 Aug 2013 11:45:34 +0000 (20 12:45 +0100)]
fdo#53032 - Use the right mark area to undo paste of RTF.

Change-Id: Iee0521e4f7851f5b51cf6ab7a973bf8b46fb09f5
Reviewed-on: https://gerrit.libreoffice.org/5538
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
8 years agoResolves: rhbz#998046 store last size/position of the table/query/form
Caolán McNamara [Tue, 20 Aug 2013 19:08:47 +0000 (20 20:08 +0100)]
Resolves: rhbz#998046 store last size/position of the table/query/form

Change-Id: I3623d5e133b8d7b2e7920824b05c46ade7b10d7c
(cherry picked from commit c3164e42dcdf879ed53e235db13f498eb730bae9)
Reviewed-on: https://gerrit.libreoffice.org/5551
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agoNSAppKitVersionNumber10_7 is not defined in SDK 10.6
Norbert Thiebaud [Wed, 21 Aug 2013 03:47:19 +0000 (20 22:47 -0500)]
NSAppKitVersionNumber10_7 is not defined in SDK 10.6

Change-Id: Ie52fdd9360bd8393baa733aed0d42f5cb9a57bf7
Reviewed-on: https://gerrit.libreoffice.org/5555
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agounopkg: use default umask when installing shared extensions
Björgvin Ragnarsson [Tue, 20 Aug 2013 00:46:13 +0000 (20 00:46 +0000)]
unopkg: use default umask when installing shared extensions

This makes sure shared extensions are readable by users when root's umask has been
set to a value such as 0027.

Change-Id: Ia1e389e1e6a271d78bd9fe90df345134befaaac0
Reviewed-on: https://gerrit.libreoffice.org/5523
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
8 years agoResolves: fdo#67665 font names filtered out on odp/odg export
Caolán McNamara [Tue, 20 Aug 2013 10:37:04 +0000 (20 11:37 +0100)]
Resolves: fdo#67665 font names filtered out on odp/odg export

Change-Id: Ia529992d15152db981379a1e0a4dec63b2dad40c
(cherry picked from commit 26dc5f2ee67342bd474640e1cc39b96d3220721b)
Reviewed-on: https://gerrit.libreoffice.org/5533
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agoResolves: rhbz#998136 different index to gWidgetData vs NWEnsureGTKNotebook
Caolán McNamara [Tue, 20 Aug 2013 13:25:22 +0000 (20 14:25 +0100)]
Resolves: rhbz#998136 different index to gWidgetData vs NWEnsureGTKNotebook

Change-Id: Ib3ebbfda09cd05477b65c1d81ac77e977b2a11e5
(cherry picked from commit 0aa3a73c9463f4d1e8918383b21131352635fe75)
Reviewed-on: https://gerrit.libreoffice.org/5545
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
8 years agofdo#68219: Parent style text attributes missing in accessibility
Boris Dušek [Sat, 17 Aug 2013 15:23:40 +0000 (17 17:23 +0200)]
fdo#68219: Parent style text attributes missing in accessibility

Thanks to Niklas Johansson for testing.

Change-Id: I550076e7d62f8db389cdbf902fce0ff7f8f98165
Reviewed-on: https://gerrit.libreoffice.org/5499
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agofdo#43807: Fix import of drop caps character style
Zolnai Tamás [Wed, 14 Aug 2013 14:28:09 +0000 (14 16:28 +0200)]
fdo#43807: Fix import of drop caps character style

Export works and import has just a little typo.

Change-Id: I570d70423b5a626f21117971fb7eff030eae20af
(cherry picked from commit 932901224ea8473bbcae6feced953340d489bcc5)
Reviewed-on: https://gerrit.libreoffice.org/5488
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
8 years agoMake VoiceOver announce paragraph alignment
Boris Dušek [Sun, 11 Aug 2013 17:45:19 +0000 (11 19:45 +0200)]
Make VoiceOver announce paragraph alignment

Change-Id: I7d9d012e0af3b5685421ca2f10d2d8cb3420cc15
Reviewed-on: https://gerrit.libreoffice.org/5352
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Reviewed-on: https://gerrit.libreoffice.org/5498

8 years agofdo#67980 - VoiceOver does not inform about misspelled text
Boris Dušek [Sun, 11 Aug 2013 14:37:48 +0000 (11 16:37 +0200)]
fdo#67980 - VoiceOver does not inform about misspelled text

Reviewed-on: https://gerrit.libreoffice.org/5351
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Conflicts:
vcl/aqua/source/a11y/aqua11ytextattributeswrapper.mm

Change-Id: I4aefa1c013e62942801dd38a06034103c0df24be
Reviewed-on: https://gerrit.libreoffice.org/5497
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agoAdd XAccessibleTextMarkup to AquaA11yWrapper
Boris Dušek [Sun, 11 Aug 2013 14:34:07 +0000 (11 16:34 +0200)]
Add XAccessibleTextMarkup to AquaA11yWrapper

Change-Id: Ic15aeb46b384531c4d64d6ec8a103f3e44068cf1
Reviewed-on: https://gerrit.libreoffice.org/5350
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Reviewed-on: https://gerrit.libreoffice.org/5496

8 years agofdo#67957: Font name reported in AXFont always Times New Roman
Boris Dušek [Sun, 11 Aug 2013 06:44:26 +0000 (11 08:44 +0200)]
fdo#67957: Font name reported in AXFont always Times New Roman

This is a partial fix. Now VoiceOver does report changes in font faces
but it works correctly only when the paragraph text style has font
"Times New Roman". If it has not, then parts of the text with
"Times New Roman" have not change in font reported, but parts with
font different both from the paragraph style font and "Times New Roman"
do have font change reported.

In other words, the default font for paragraph is still "Times New Roman"
in accessibility even though sometimes it's not true.

This also fixes font size being reported only when bold or italic is set,
and has more robustness for handling mixed bold/italic when at least one
of them is set in the paragraph style as well.

Change-Id: Id0715727d04cd9b814aa0e4093939cd3e6abe897
Reviewed-on: https://gerrit.libreoffice.org/5344
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Reviewed-on: https://gerrit.libreoffice.org/5495

8 years agofdo#67680: Impossible to search for text attributes with VoiceOver
Boris Dušek [Fri, 9 Aug 2013 06:41:42 +0000 (9 08:41 +0200)]
fdo#67680: Impossible to search for text attributes with VoiceOver

Change-Id: I02ae12233aa37830106eeffd16876670413f4627
Reviewed-on: https://gerrit.libreoffice.org/5334
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/5494
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agoUse NSAccessibilityActionDescription for action descriptions
Boris Dušek [Thu, 1 Aug 2013 22:20:57 +0000 (2 00:20 +0200)]
Use NSAccessibilityActionDescription for action descriptions

Reviewed-on: https://gerrit.libreoffice.org/5238
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Conflicts:
vcl/aqua/source/a11y/aqua11ywrapper.mm

Change-Id: I26a233e72274be7afc2e3e41e13a6743f75e695f
Reviewed-on: https://gerrit.libreoffice.org/5493
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agoFix accessibility of text attributes on OS X
Boris Dušek [Thu, 1 Aug 2013 22:04:35 +0000 (2 00:04 +0200)]
Fix accessibility of text attributes on OS X

The applyAttributesFrom:... method takes range parameter that specifies
a range in the 'string' parameter passed to that method, not in the whole
string of the UI element as retrievd in createAttributedStringForElement:...
(the former string is a substring of the latter).

In other words, the 'range' parameter in applyAttributesFrom: is relative
to the string passed to that method, not to the whole string of the UI
element.

This enables proper reading of text attributes in Writer - when moving
cursor through text, VoiceOver now announces e.g. "bold" or "plain" to
indicate changes in text formatting.

Change-Id: I21a633af0bf426759f639435581fcd3bfeafa598
Reviewed-on: https://gerrit.libreoffice.org/5236
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/5492
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
8 years agoUpdated core
Andras Timar [Tue, 20 Aug 2013 12:06:35 +0000 (20 14:06 +0200)]
Updated core
Project: translations  6d19b6dbcd66a36cfe3e61833d8d2499b1c27ce6

8 years agofix for fdo#62323 bad conversion of Hex strings for certain values
Noel Power [Mon, 19 Aug 2013 15:58:07 +0000 (19 16:58 +0100)]
fix for fdo#62323 bad conversion of Hex strings for certain values

Basic hex literals are basic Integer ( e.g. 4 byte ) types with
-2,147,483,648 through 2,147,483,647 range. Interally the scanner
was using a long to form/scan the literal, this led to bad behaviour
on 64bit linux ( where normally long -> 8 bytes )

(cherry picked from commit 4c9a08e78b6e2c5d19628281bd4141c268299bea)

and squash of
fix for fdo#62323 fix duplicated and wrong tests

Change-Id: I73dc238f7de59367a0a9d00e5421ea6675b4f556
(cherry picked from commit fbf8ae82411d56189f844f9f00ccc6cf6b0827bf)
Reviewed-on: https://gerrit.libreoffice.org/5526
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
8 years agoReturn on NULL right away, to avoid null dereferencing below.
Kohei Yoshida [Mon, 19 Aug 2013 20:47:42 +0000 (19 16:47 -0400)]
Return on NULL right away, to avoid null dereferencing below.

Change-Id: I17b45a5fb6ac5d30be5d3575fec76a61662decdf
(cherry picked from commit e7164ec2858a25a9f57fac199132dea0e70a8555)
Reviewed-on: https://gerrit.libreoffice.org/5520
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>