Public Git Hosting - LibreOffice.git/log

Branch libreoffice-4-1-0

This is 'libreoffice-4-1-0' - the stable branch for the 4.1.0 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 4.1.x release,
please use the 'libreoffice-4-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I8f8984ec1987cf53933f6cac86e821f746864923

the calculation of the progressbar leads to very slow saving

Change-Id: Ibba31126161b77b499561c5a74c057a56c07a4a8
Reviewed-on: https://gerrit.libreoffice.org/4647
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Reviewed-on: https://gerrit.libreoffice.org/4698
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

temporarily disable tests known to fail

Change-Id: I95c3c1af64b7d8b499c085c345b26d2df7e31965
Reviewed-on: https://gerrit.libreoffice.org/4700
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

simplify AddPrintRanges calls at import time

- at import time, use directly core functions
- honor IsUndoEnabled in uno calls

Change-Id: If1e762df0ca9cfa22fa2c0e75518fe892be602b6
Reviewed-on: https://gerrit.libreoffice.org/4656
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-on: https://gerrit.libreoffice.org/4696

i#112615 table names are allowed slashes

Change-Id: I1b69c4575d79ba1b6a6e9cd83abaf18bad54fd79
Reviewed-on: https://gerrit.libreoffice.org/4677
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

Fix Windows signing and timestamping

Change-Id: Ife8774c9a6157e8bb943d1ba8ec32f560c8281c4
(cherry picked from commit 523258e675e881d6f8efc031e3885d0197c8aad0)
Reviewed-on: https://gerrit.libreoffice.org/4692
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Updated core
Project: translations 576c36310413f55a282838588f60bc639de8dd59

fdo#66007 - spurious & causing entity warning errors

was already fixed for mn in ad5ed8525c1f41a9ee8dd9183ac7f6ae045625f7

Change-Id: I122816833b315cc62b856a461cb3f3671dd68042
Reviewed-on: https://gerrit.libreoffice.org/4691
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>

xls cells have all hard number format, fdo#66506

Change-Id: Ia2dd206bd1e9a91bef0021a9317f0d6486b2f276
(cherry picked from commit f45c47af72369859d1937cb8b46cba370031509a)
Reviewed-on: https://gerrit.libreoffice.org/4689
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

fdo#61429: Stylist: try a little harder to restore "hierarchical"

Change-Id: I30972224c5a9aa12c4ef4c2b5ca80e7aece0baad
(cherry picked from commit 8f04b172c5c78fa80c3692a729f0191425195869)
Reviewed-on: https://gerrit.libreoffice.org/4686
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

SvStream: remove the error prone operator<</>>(sal_Int64)

As the recent regression after merging AOO patch adding code serializing
"long" variables has shown, this overload (which was added in
7b2a0e541567be9750dfc7d98374555967da3470) is a bad idea.

In a unxlngx build, nm finds uses of the symbols _ZN8SvStreamrsERl
and _ZN8SvStreamlsEl in these files:

- sbxvalue.cxx: this appears to be a legitimate use with sal_Int64

- dateitem.cxx: this was accidentally changed by commit
  9830fd36dbdb72c79703b0c61efc027fba793c5a

- atrfrm.cxx: this was added for Table Autoformat enhancement in
  7e8c0bd73ee59ff3041e55268c77203373962e51, which is after the
  sal_Int64 operators were added, so the file format is now
  platform dependent

Change-Id: I78352b5429b53612c4831cdb81b587b5de5180a9
(cherry picked from commit 3835dee3c777bf10693903cb0866d22fab3794ea)
Reviewed-on: https://gerrit.libreoffice.org/4685
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

don't crash during chart copying, fdo#66508

(cherry picked from commit 92207231c3742873ad3b3a6fed2963d1bf924ad3)

Change-Id: I3a4806fcae7b830e71cda0ab7e6d5ac6f180d4d3
Reviewed-on: https://gerrit.libreoffice.org/4688
Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de>
Tested-by: Kohei Yoshida <kohei.yoshida@suse.de>

Resolves: fdo#66252 format->number for controls is busted

Change-Id: I7c88f3acd9a6c5faa40a8fedc7c9f6e7817cefb7
(cherry picked from commit 092281f1e7022ee26e3659cc1c54ac0dd73a4382)
Reviewed-on: https://gerrit.libreoffice.org/4682
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Related: fdo#66252 RID_SVXPAGE_NUMBERFORMAT needs a layout parent

Change-Id: I25f87916e5b8480e50cafb30b78da4d575a7df24
(cherry picked from commit eb39f90f071c03f8f9e61a0f129a060ffcfb96eb)
Reviewed-on: https://gerrit.libreoffice.org/4683
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Allow build with older boost

Change-Id: I49902109eb2a1b9561a9ccfa70d89c160a4965a9
(cherry picked from commit d37723a2496907bf60829306c6509fe24a9c4dbe)
Reviewed-on: https://gerrit.libreoffice.org/4681
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

Resolves: fdo#66502 set AutoMnemonics before calculating layout

Change-Id: I3274ec9e8e4e1f61f0108a3e6ba64107128736c2
(cherry picked from commit 00601259144f5b49b516581ca6ae28fc6e524030)
Reviewed-on: https://gerrit.libreoffice.org/4679
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#46361 oox: fixes for the VML import of groupshape textboxes

(cherry picked from commits b1f78c44c1acc246f06a963383232c9bf649a06b,
f24e4c74d7d6a7d95090c6fa6a584fed7787706c,
6bf79576aeca243db553ed3b5eade492dc35337b,
5a737fca37cd5a5f90aa03a30688d447677d3b8a,
ef53d4aec2a3d690de2c7cdaf73ca95bbe29a433 and
2a2105b002c482e6536d5c3046c9e7783c0cdca3)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: Ie7ce4fb5c32ff4b3c1f3d7ee92d8358ae67fc6c1
Reviewed-on: https://gerrit.libreoffice.org/4675
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Uploading new libvisio 0.0.29, fixing fdo#66421

Change-Id: I7b9bc581c81caf74cb6f922abc2cfaee87b20572
(cherry picked from commit 50b0bf15bf0e173ba449efed93ef3909253b9988)
Reviewed-on: https://gerrit.libreoffice.org/4678
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#64155 - fix unlocalized 'default' list entry

Change-Id: I3a8b706fe855e7fbff71f227b167a51d3a465be0
Reviewed-on: https://gerrit.libreoffice.org/4673
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

default report template should be language-independent

Change-Id: Ia0b18b90ffd2cb4c6958749e45d8cfec92825d02
Reviewed-on: https://gerrit.libreoffice.org/4672
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

make "gcc -Werror" happy

Change-Id: I6dd1bf6b4535bb956cb7e85908312d52749a6f2b
(cherry picked from commit e2d9138ce03d4f330e0737396b75871cab6ca5d2)

Signed-off-by: Eike Rathke <erack@redhat.com>

Handle synthetic bold italic with Core Text

Core Text does not fake missing italic and bold (unlike ATSUI), so we
have to do it on our own.

Change-Id: Ia5977d53739b7a6eaaccbf3aeb24adb820ca05c6
Reviewed-on: https://gerrit.libreoffice.org/4658
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#66385: bad line spacing under Core Text

We should be setting mnExtLeading not mnIntLeading, at least this is
what ATSUI code was doing.

Change-Id: Ibe69da4ea60630a31593b538f55fd2cd95642bf9
Reviewed-on: https://gerrit.libreoffice.org/4638
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

transpose "data in rows" ranges for internal data provider, fdo#62057

This is an ugly hack but it at least works. This regression has been
introduced by the merge from the AOO code. The order of calls during
import is totally screwed and I have no idea how to properly fix all
these problems without introducing new regressions.

The best solution would be to move the import/export code into chart2
where we could manipulate tese properties directly and would not need to
transform the same information N times until it is written into the
chart code.

(cherry picked from commit 14fa5488a829936275f79a7693b13da55114220e)

Conflicts:
xmloff/source/chart/SchXMLTableContext.cxx

Change-Id: Id53c49441c683b19a973a48884135a3f4e89de03
Reviewed-on: https://gerrit.libreoffice.org/4628
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#58995 Fix focus gained/lost event dropping for Window and Frame

See 9fd9b14cffbf2604022c099b6202bb0a1da6f06e for more details.

Change-Id: Iea92076be8cbcc110deff3c617ee13bbd66aab79
Reviewed-on: https://gerrit.libreoffice.org/4645
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#66464 initialise static join info at construct time

to ensure that isReadOnly returns something sensible as soon as construct() finishes

Change-Id: I5f9bef049297c5232df0ecdb9084add968a0052f
Reviewed-on: https://gerrit.libreoffice.org/4669
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>

fdo#64985 try harder to populate m_sCommandName::m_sCommandName

Change-Id: Ibef643498903c82eee5533d387a33ca26a77d496
Reviewed-on: https://gerrit.libreoffice.org/4633
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

don't forget the formula cell style during xls/xlsx export, fdo#66242

This reverts parts of commit 64223bda068cc6d82d3c5e359d465014568398bb.

Change-Id: I6d5379aaedbf011b39a4cf076f0a43bc8a6cbc93
(cherry picked from commit 93a5b7ee36818d60963e4fbe21f9e6c43c7c5a80)
Reviewed-on: https://gerrit.libreoffice.org/4670
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

using primary font for secondary max text width

Change-Id: If4d5d4be2a5552c52e7e98ff891e2166b7541800
(cherry picked from commit fea12c47101d3d13d1e6a611f88c54f257b49b11)
Reviewed-on: https://gerrit.libreoffice.org/4640
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Resolves: rhbz#979758 crash on 'Diagrammen in LibreOffice' help page

Change-Id: I269846840b8e2f67838da525c020a305901cf903
(cherry picked from commit 3090cfc972287da3fbdc567387527b65b3bfd128)
Reviewed-on: https://gerrit.libreoffice.org/4655
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66324 fix locking in webdav_ucp::Content::getResourceType()

Crash in there while accessing an evidently deleted DAVResourceAccess
instance with about 4 other threads also in various webdav_ucp::Content
methods.

The problem is apparently that the "outer" getResourceType() passes the
m_xResAccess to the "inner" getResourceType(), which accesses it
without locking the mutex, while another thread resets m_xResAccess
and thereby deletes the current instance.

(regression from 0c3500115c4fd86284a027fc32be704afcf77061)

Change-Id: I1c67021c536e303d766c7ff93fb71e40f991f3af
(cherry picked from commit 49a454225e35699d7351faaba3d296e1858c6107)
Reviewed-on: https://gerrit.libreoffice.org/4650
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#65650: fix Writer ODF import of list style with bullets and color

For such lists xmloff tries to set a BulletColor property but
SwXNumberingRules::SetNumberingRuleByIndex() throws a RuntimeException
and does not set any of the list properties on the NumRule.

(regression from abf18610998aa8330f8330f1d769508e47ef5b20)

Change-Id: Id3e80ee1ed67497786258a1096bc5c8dec90ce21
(cherry picked from commit 0520eaf9e661abddadf9a21cfbeab37b0b85dd68)
Reviewed-on: https://gerrit.libreoffice.org/4664
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66165: WW8 export: fix duplicated paragraph breaks

MSWordExportBase::OutputTextNode(): in commit
8f2a21eac4a904db3cc4c448179e2d2cf5878ef4
(which is not merged) a "WriteCR( pTextNodeInfoInner );" was moved up
a few lines, so it shows up as context in the other commit, and
the bug is that the cherry-pick 83ba821c10392c08334f7d8d3775fe3e8d08f8fd
erroneously adds this context line so now there are 2 WriteCR().

Change-Id: I08434b284f3d8d8426fa997623be352c37d6c7c2
(cherry picked from commit a201ae63ce798438057a1328dc644dc8b64fe4e8)
Reviewed-on: https://gerrit.libreoffice.org/4662
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

resolved fdo#35411 redefined MAXCODE 512 to FORMULA_MAXTOKENS 8192

Also renamed MAXJUMPCOUNT to FORMULA_MAXJUMPCOUNT but without changing
the value as the runtime array size of ocChose depends on it, should be
changed before.

Eliminated the duplicated and error causing redefinition of both in
sc/inc/compiler.hxx

Change-Id: I0e87d1439c9564a4f475fcb2870ab51c3b586942
(cherry picked from commit 9c1ca6dca3b553c302a635357e33591605343b99)
Reviewed-on: https://gerrit.libreoffice.org/4667
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Fix jitter when editing RTL text

When drawing right aligned text, rounding errors in the position
returned by GetDrawPosition() cause the right margin of the text to
change whenever text width changes causing "jumping letters" effect. So
here we calculate the drawing position relative to the right margin on
our own to avoid the rounding errors. That is basically a hack, and it
should go away if one day we managed to get rid of those rounding
errors.

Continue using GetDrawPosition() for non-right aligned text, to minimize
any unforeseen side effects.

Change-Id: Ia095a17a41f723f5fb7afc99df4250262e9a0051
Reviewed-on: https://gerrit.libreoffice.org/4618
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

hide the style boxes to collapse the date entries fully

Change-Id: I58f06a57a05ef007afc203c737acfe29df6ea6a3
(cherry picked from commit def32c7e14ad9743e2b55804442be5d596f6c21c)
Reviewed-on: https://gerrit.libreoffice.org/4617
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

update all style lists when a new style is added

Change-Id: Ib404958e2bc0e3bfe075d1c94f348e907ee004c8
(cherry picked from commit aa028cab4a72660c773a9eac0cd8a19a0d655c01)
Reviewed-on: https://gerrit.libreoffice.org/4616
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

handle localized default style names, fdo#61339

We need to map localized style names during import and export from and
to ODF. The default styles are the only localized style names and are
not imported with the name written into the file.

Change-Id: Ibdc2f750b7a4b7ce6994b22248e237fe95ac638d
(cherry picked from commit 5b9bad7482a98f2d0d37c4b75a13292abe653ea3)
Reviewed-on: https://gerrit.libreoffice.org/4615
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

extract this functionality from the uno code

we need this code in our next step for some mappings in the filters code

Change-Id: I059d9d05877846215e1a967123dc253de605417e
(cherry picked from commit b3aabf223ec7bc2678fd6dfbbbbb79ab7f079e5b)
Reviewed-on: https://gerrit.libreoffice.org/4614
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

only clean the cond format if we want to write attribs, fdo#62267

Change-Id: I2f4feecb3180b165f6b9b299ecb3dcdbb65f87e3
(cherry picked from commit d4f631e8ceb7f02a18565cf0470c8170215e69f8)
Reviewed-on: https://gerrit.libreoffice.org/4613
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

use the local setting aware method for the UI, fdo#64754

Change-Id: Ie3117c26b347e1a8996ef9cbcb8b0d6ee561b5b3
(cherry picked from commit a539cf2c09bdd62d1c4a0124ed536f88d4fd01d5)
Reviewed-on: https://gerrit.libreoffice.org/4612
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

Resolves: fdo#66263 calc's protect records doesn't do anything, sid collision

Change-Id: I50c9f0bd28f17e5d56c6d6948871042ba64650ef
(cherry picked from commit 257ba103fb9ffae87189eb5d435969961fe4e98c)
Reviewed-on: https://gerrit.libreoffice.org/4651
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

fix OUString conversion

This used to be equalsAscii( "hg", 0, 2 ) before conversion.

Fixes 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10

Change-Id: I2cf61d88c79b3ab33c0ee7d077ee65b16053c05c
Reviewed-on: https://gerrit.libreoffice.org/4035
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Signed-off-by: Michael Meeks <michael.meeks@suse.com>

Resolves: fdo#66403 infinite loop, typo i should be it

Change-Id: Ia3ec1302649809b7a63befc0a48fb142f1169936
(cherry picked from commit e21544132a6732334a14194e02232b28e559303b)
Reviewed-on: https://gerrit.libreoffice.org/4648
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>

Updated core
Project: translations e148dafb1b7c07a131e803ca477b6c281790d809

fdo#66130 correct "skip column name" condition for LIKE predicate

When converting a parse tree to SQL snippet for a predicate in the
context of a column, we skip the name of the same column in 'simple'
cases.

This is used mainly in the "Criterion" lines of query design,
and in the search/filter dialogs of forms, tables, etc.

In all other cases (such as when creating a full SQL command, or for
references to *other* columns than the context one), the column name
must be printed out.

In this respect, the condition "should we skip the column name?" in
impl_parseLikeNodeToString_throw was buggy, and different from the
one in the general case (in impl_parseNodeToString_throw), leading
to generating invalid SQL like:
SELECT foo, bar FROM baz LEFT JOIN qux ON LIKE qux.quu
instead of
SELECT foo, bar FROM baz LEFT JOIN qux ON baz.baa LIKE qux.quu

Change-Id: Ie14fce319554a66feb0fd0ce1a03d947a46a820a
Reviewed-on: https://gerrit.libreoffice.org/4606
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66101: lowriter crashed when trying to open .docx file

Change-Id: I516bcb4bc18806d5a83f94c0776bd0f918a1e927
Reviewed-on: https://gerrit.libreoffice.org/4550
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-on: https://gerrit.libreoffice.org/4610

fdo#66171 ListBox correctly save empty or zero BoundColumn

Change-Id: I05fa923f962191081ea3318837d3e181c183b466
Reviewed-on: https://gerrit.libreoffice.org/4589
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Replace buggy pgsql-sdbc datetime functions with dbtools equivalents

In particular, the string2time function segfaults when called on an empty string
(unconditionally tries to access the n-th character without checking whether the string is that long)
this happens in particular when reading a column of type TIME with a NULL value

Change-Id: I302044f67a92fe20685ce677ba3affdb9b44cb53
Reviewed-on: https://gerrit.libreoffice.org/4582
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix nanosecond computation

when less/more than nine digits

Change-Id: I222ae7c51e37468a01abc9caab91657ea2593d13
Reviewed-on: https://gerrit.libreoffice.org/4592
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix crash when parsing empty string

the parsing of the hours would succeed, but the parsing of the minutes would access past-the-end of the string.
Probably same crash when parsing HH or HHMM formats.

Change-Id: I248810e5c4c425186f33e573634883263caff312
Reviewed-on: https://gerrit.libreoffice.org/4591
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66216 JDBC no fractional second in time format

fractional second allowed in timestamp. But not in time. Don't ask why.

Change-Id: I5415889ab4cf4835b8b0db7363b7d9eb0a332393
Reviewed-on: https://gerrit.libreoffice.org/4566
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66216 fix DBTypeConversion::toTime overflow

Change-Id: I0aba2344afde94226cfbac5b3221e827e6774b3a
Reviewed-on: https://gerrit.libreoffice.org/4565
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#66216 fix DBTypeConversion::toTimeString format

std::ostringstream::width is not sticky

Change-Id: I32d77bec68506b7691a4f86dadb24e62fdc13d42
Reviewed-on: https://gerrit.libreoffice.org/4564
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

we don't need this hack without inherited number formats, fdo#66076

Change-Id: If315ce28a4182019002141c7330475e0843f9a40
(cherry picked from commit 3f0b5770790dfcb408d169df1265546d6e8e3ece)
Reviewed-on: https://gerrit.libreoffice.org/4593
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#31525 Dialogues now have an appropriate background in OSX

The proper background is now set using HIThemeBackground.

Change-Id: I71e4287273f7345a18eee4c4fc494eea10f2deb2
Reviewed-on: https://gerrit.libreoffice.org/4287
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>

improve performance switching modules in large Libraries fdo#66148

object catalog when updated, updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
(cherry picked from commit 61027ca6eb450fb20bfe9209ba180fe0606baeab)
Reviewed-on: https://gerrit.libreoffice.org/4598
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix text position for custom shapes with zoom != 100% fdo#59862

custom shapes that had text suffered from strange display at zoom
levels != 100%, this was because there was a bug in the code to
correct the textposition

Change-Id: I8d1817cc6be91b3e6379200eb21eb2966d3c2aa9
(cherry picked from commit 443c13e92c6f900a41e6e383684623ead3e088f5)
Reviewed-on: https://gerrit.libreoffice.org/4514
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

unit test for commit:1680a8cd4f4393ec15c4f85cb63b6654117d56d1 (fdo#56960)

expand the existing borders import check to cater for xlsx ( and
testing for fine/hair border styles )

Change-Id: Ic5c3cd46e0049dbce9997f0881c4d98e0d64e00c
(cherry picked from commit 69dcacedaccd1d698a54eed615ee8739747bc975)
Reviewed-on: https://gerrit.libreoffice.org/4503
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix hair & fine cell border export ( followon fix fdo#56960 )

1) align excel binary and oox import filter border thickness values
2) use new fine-dash border style
3) detect & determine hair vrs fine borderline on export

also squashed relevant part of commit ee51444ed1f7003dafc93c8181b5f8c1b0fd165b
( fix borders unit test ( test values have changed ) )
Change-Id: Ieb024bc6f4bfc87c525082c7b9a1f3c444f5c5ca
(cherry picked from commit 1680a8cd4f4393ec15c4f85cb63b6654117d56d1)
Reviewed-on: https://gerrit.libreoffice.org/4493
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix for bnc#823935

window network drive urls on import get internall converted to SMB
(so it appears anyway) when exported the file:/// that was on
the target ( in the relId ) for the hyperlink is dropped. Apparently
the scheme isn't necessary for the binary import. If one of these
strange 'detected as smb' window shares are exported make sure we
add the file:///
(cherry picked from commit 8e33e95500c2f5edc91e853024a5c0fff285fcce)

Change-Id: Id62e1f4845bfbc610f73499881dc33d3d955923b
(cherry picked from commit 732640c353b39cff7a9d5b5906f8975102cbed11)
Reviewed-on: https://gerrit.libreoffice.org/4484
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

n#820504: start a new subpath with m and t in VML path decoding

Change-Id: I7bac4b111ede5e815d2ed121c18f4cfe1ad0950e
(cherry picked from commit 8d6eb11d6965ee93e72513f5e01b67f598edf6c3)
(cherry picked from commit ff28c7b26b097a3213766cf2ba6f36a4b77b185f)
Reviewed-on: https://gerrit.libreoffice.org/4587
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>

Forgot to remove one case where nParamCount is set to twice the value

Change-Id: I3649364a889b7ef6ce7ac4316a1621b6328170eb
(cherry picked from commit 7f7a1294e2d0da30a58d897558a18a13dbc5e690)
(cherry picked from commit 696b9b1ce2b7ffa60ba80d6cfaef8a61711fd28f)
Reviewed-on: https://gerrit.libreoffice.org/4586
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

n#820504: VML path import fixes: get back missing points

nParamsCount was set to the double of the expected value, but the code
handling the command only took the first set of parameters. Removing
this 2* in nParamsCount.

(cherry picked from commit 442ad6eef9d6e1588e4985e97ec3eafd6289f9ae)
(cherry picked from commit 10cd569334971949b82bbccfd7a29334e374cc47)

Conflicts:
oox/source/vml/vmlformatting.cxx

Change-Id: I2a4bb07fc9167e056a52c7adfbee9e1ef8e2636c
Reviewed-on: https://gerrit.libreoffice.org/4585
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

n#820504: Some imported VML paths are closed, try to detect the

(cherry picked from commit 08db0b22bdce0f779e4af01a209aef1be29e9907)
(cherry picked from commit b516a9b69119b25df8f973b6318f2ae1c7e601df)

Conflicts:
oox/source/vml/vmlshape.cxx

Change-Id: Idefd0277a85bd7b2b727f59cc4e568869b4932a1
Reviewed-on: https://gerrit.libreoffice.org/4584
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Resolves: fdo#65743 MovePara gets stuck on hidden para fields

Change-Id: I03b26aaa9be491e760335185c5a9ffd5d04990bb
(cherry picked from commit 61533b8c54077bf1aa203f503e271037b6553411)
Reviewed-on: https://gerrit.libreoffice.org/4568
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

namespace fixup

Change-Id: I9554321562ed774d9367068ea9860b58b6c0ab94

Add Romanian auto correct words.

Change-Id: Ifb904350499039353a091a6710e8a9bbd603f094
Reviewed-on: https://gerrit.libreoffice.org/4569
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

must call FreeResource in old-resource-using dialogs/panels

Change-Id: I756ac431dfcd6a4d6a365fc38b465f4b588ddd79
(cherry picked from commit 23d9f2400bff7a6c1f0c55f9a1158d40a57d6239)
Reviewed-on: https://gerrit.libreoffice.org/4575
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

bnc#823655 fix RTF import of freeform shape coordinates

E.g. 0,1 was imported as 1,0, as we did not differentiate between not
having the coordinate yet and having it as zero.

Change-Id: Ia5fbbcc791dc9c6866ffd4c146793690661d81b4
(cherry picked from commit ddddfe8d6ffa05c467bddb3480e43d7043a3d3c9)
Reviewed-on: https://gerrit.libreoffice.org/4483
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

bnc#823655 RTF import: ignore styles without a type

Regression from 29dcdf6b56f8dbc1b7de0478afb04122f8dbf0f9.

Change-Id: I970c0e7b3652d7e6f093815b90e04e0c45904b28
(cherry picked from commit c6a941b51b68eb097d4d43323b39ff1aba4c753e)
Reviewed-on: https://gerrit.libreoffice.org/4482
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#50506, incomplete indent markers in Mac rulers

AquaSalGraphics::drawPolygon() should close the path like other polygon
drawing functions. It have been like that for 5 years since
3ca40fb8a2e8c805517b351ebd97c1385cfc92a3, no idea how it was never
noticed.

Change-Id: Ifba740afa66ad485943c7873d78e007b778cd7b3
Reviewed-on: https://gerrit.libreoffice.org/4448
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-on: https://gerrit.libreoffice.org/4456

Attempt to fix Core Text full justification

Apparently we need to subtract the trailing white space from the desired
line length or text will sometimes protrude to the margin.

Change-Id: Iee5ef40670c2fefc189afa319387b180c4ed648d
Reviewed-on: https://gerrit.libreoffice.org/4455
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#65123 Revert "n#782833: (PPT) Fix font size at end of para."

This reverts commit e36d227ee584aa07fa48dda7710ac6b7a850fcc3.

The description in the orig. commit: "Font size at the end of the para
when there is a new(empty) line is set using an extra charprops
definition." That would mean the extra StyleTextPropAtom record does not
have a record header, which seems pretty fishy. I suspect the real
problem is somewhere else (or the ppt is broken). But I cannot check it,
because I cannot access the bug.

Conflicts:
filter/source/msfilter/svdfppt.cxx

(cherry picked from commit 2022c84d1e7e88e65243c6dfd1a62ec17f1361a1)

Change-Id: I1d555cd2905ef8f297d1a96f56bebbea8f83ad62
Signed-off-by: David Tardon <dtardon@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/4572
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

SwModelTestBase: fix for leaking temporary files

This alone pushes down the number of created /tmp/lu* from 527 to 2
after a single run. Regression from
9b53538a076a2370df975655c8579dfe09cff09b.

Change-Id: I5ea2e3da0b89223fb32469af3d59a2a3b246d00f
Helped-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Signed-off-by: Luboš Luňák <l.lunak@suse.cz>

Remove temporary files

No more gbuild.XXXXXX files filling /tmp

Change-Id: I2f3cd388ccd9a09bc72e40c0d43d845bc8e38cd7
Signed-off-by: Luboš Luňák <l.lunak@suse.cz>

Fix fdo#65847 - avoid infinite recursion in style resolution.

That was previously asking back the node for the font size, which
was again asking the SvgNumber, which was ...
In this case, if the node has relative sizes, this is always
relative to the parent.

Change-Id: Iaa81d0238d9eb73f5af24df347d12d7cb8ba8c0a
(cherry picked from commit d9b09a3ff38b2cf11ee0b9f9f03d47375f2b11e8)
Reviewed-on: https://gerrit.libreoffice.org/4594
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#47646 fix undo of ungrouping

(cherry picked from commit 66480d15a04204b0f60008b9cd8e25a66ca6db6a)

Change-Id: If20e645d8d708ebe17e2d9455c896c94592993bb
Signed-off-by: David Tardon <dtardon@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/4573
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Updated core
Project: dictionaries ec1372f7e0f78ff84b90a9d61aa4e3e389008f99

Uploading libmwaw 0.1.10 and dumping unneeded patches

Change-Id: I837b885fb88ccbc1e7980712be4a3342575b3770
(cherry picked from commit d63bd6914f479ea4cd718b6f0a26b1edfc141562)
Reviewed-on: https://gerrit.libreoffice.org/4588
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#65975: do not put MSVC 64bit runtimes in solver/bin

Apparently causes problems for some people.

Unfortunately the scp2 entries are "non-standard" so i've had to add
another variable to let the installer find it.

(cherry picked from commit 9a6d5f15afa16e68d38e4a0cfd5ef904be481a17)

Conflicts:
instsetoo_native/util/openoffice.lst.in

Change-Id: I7a01160369ed8dc401625c06760008341afcee67
Reviewed-on: https://gerrit.libreoffice.org/4576
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Revert "better dependency working also for libmerged"

It might work with libmerged, but it does not work otherwise.

This reverts commit f8fd2e6a3b21ec3899a74d7400cafaba4e83ff6c.
(cherry picked from commit 247f37890060330f3c3d2d05bbd8e36d689e9ada)

Change-Id: I3b9f8831cf64514a089289dfd0631b7b9e24c6b7
Signed-off-by: David Tardon <dtardon@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/4571
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

valgrind: bInsertIntoEditWindow uninitialized

Change-Id: I3da23e991a70e12bdfefeda5f5e7669ab111cfb4
(cherry picked from commit 2278e3cc31f97259ba2eea86e99739006a23b8e3)
Reviewed-on: https://gerrit.libreoffice.org/4574
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Revert "fdo#65975 - fix failed compilation on windows 32bit."

This reverts commit 150d258234be57619c860c51a74410caf650cb00.

This breaks the 64bit shell extensions by bundling 32bit MSVC runtimes.

Change-Id: I9f958962315f0fe9e8a2f6a4bb580022b8122089
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

we now need librdf_world_set_raptor_init_handler from librdf

Change-Id: I4e3b56fd8c088983a8a01eb6ccf88691d6fd93ef
(cherry picked from commit 2728808553e5a248d1e4dc1361e4784400a75e7b)

Signed-off-by: Michael Stahl <mstahl@redhat.com>

unoxml needs to link with raptor2 now

Change-Id: Icbe5ac8e20b5a05fdba4ed7b8a287c3d9e94d2da
(cherry picked from commit 2b5203c9ac4b6a95fa77f1a31fdb7b13e736d37e)

Signed-off-by: Michael Stahl <mstahl@redhat.com>

fdo#58995 fix focus gain/lost events dropping on JDK 1.7

With JDK upgrade to 1.7.x focus gain/lost events were dropped and thus not
discoverable by AT tools.

The problem has nothing to do with different packaging of JAB (2.0.3 is
included with JDK 1.7u6 and higher).

The reason for the event droping was a new check in
DefaultKeyboardFocusManager.java that was introduced in JDK 1.7.x:

@@ -294,18 +271,10 @@ public class DefaultKeyboardFocusManager
        extends KeyboardFocusManager {

-      if (!(newFocusedWindow.isFocusableWindow()
-               && newFocusedWindow.isVisible()
-               && newFocusedWindow.isDisplayable()))
-         {
-             // we can not accept focus on such window, so reject it.
-             restoreFocus(we);
-             break;
-         }

With this check in place it is assumed that Component.isDisplayable() must
return true, for event to be dispatched. But particularly
`Dialog.isDisplayable()` didn't and thus all tab key events (focus traversal)
were dropped.

Many thanks to Jamie and Stuart for helping out with reproducing and tracking that down!

Change-Id: I4876773199ca06a6e73213401692e8275a1f3b22
Reviewed-on: https://gerrit.libreoffice.org/4560
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>

fdo#65856 allow shift cells in paste special for copy-mode

Change-Id: I7a7e13104e7256da9a82e16e14ddfa04e35e7f8a
Reviewed-on: https://gerrit.libreoffice.org/4525
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit e513fffeac1f4a814f644f156d88fc8810af4e46)

Signed-off-by: Eike Rathke <erack@redhat.com>

Fixup alpha bitmap generation for Windows.

This improves upon d6f58fd25eeca84a94528409a05b80aa5172b8b8 by
using the BitmapEx ctor instead of manual initialisation. Several
EMF+ files would otherwise show up horribly mangled on Windows.

Change-Id: I1808cb45818f3f0118653164c83c49d6134b9324
(cherry picked from commit fefab3bb38f55471d9fa9316d1249ad00adefc37)
(cherry picked from commit 77b273ee3a2df87664262418c360d3a4a0ed48ea)
Reviewed-on: https://gerrit.libreoffice.org/4473
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#65975 - fix failed compilation on windows 32bit.

Change-Id: I69033856962e8d716f059dca9a9d68cd40ec429c
Reviewed-on: https://gerrit.libreoffice.org/4401
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Updated core
Project: help 415faf95c2611ed264ff3e0b93f58207cd9bb4f8

Add Amharic (am) auxiliary files

Change-Id: I3ef1018e8b40b3c1626d5add7ffa217da6419a0c
Reviewed-on: https://gerrit.libreoffice.org/4551
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Fix fdo#65849 - really move control one line up.

If all other controls are moved up one line to fill the gap,
moving this one up one line relative to the rest needs a two-line
up-move.

Change-Id: I953f778dd0738dcd1d38fd2589f1ec9bc62ad611
Reviewed-on: https://gerrit.libreoffice.org/4548
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#64672 prevent raptor from setting global libxml2 error handlers

Raptor already sets up all 4 error handlers in xmlSAXHandler so why it
would need the global ones in addition to that is a mystery anyway.
Messing with libxml2's globals can only cause trouble.

Change-Id: I2935efe5c4cd75d48cc4ecdeaa8437e91b48349e
(cherry picked from commit 246a78b1d2a88ff1937b09b22325d160739ef47e)
Reviewed-on: https://gerrit.libreoffice.org/4552
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

colliding SID_SVX_START based ids

Change-Id: I6eba0b0c2291a71ebe683b23a0af400010d5b5d8
(cherry picked from commit 669ad519902e21e0cb3537fb7e203987f75a4077)
Reviewed-on: https://gerrit.libreoffice.org/4547
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

prevent cairo from using -flto with clang, cairo uses it incorrectly

The option should be used also at link time (as e.g. the gcc man page says),
but cairo doesn't do so, and since -flto makes clang generate .o with LLVM
bytecode, plain ld chokes on it.

Change-Id: Ia5ce9a98afa4f88b8d0943a5971450d7009af913
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Data-aware ListBox: fix case ListSourceType==TableFields

Change-Id: I9a89374fd1cc56c8185753f5959275a0a2d841ff
Reviewed-on: https://gerrit.libreoffice.org/4464
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>

ListBox: when LISTSOURCETYPE changes, need to (un)lock BOUNDCOLUMN

Change-Id: If83073ec19c1389bf87fc154fa0ae83fd5bd1f3a
Reviewed-on: https://gerrit.libreoffice.org/4463
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>

Related: fdo#65716 title substitutions

Change-Id: I1d9fe14cdfd77ef79089cdf9c20a876238862bae
(cherry picked from commit 9102d2517007db3afa867a9902ca526153439eb5)
Reviewed-on: https://gerrit.libreoffice.org/4519
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>

fdo#66180 librelogo: clockwise HEADING

Change-Id: I1154b29119fd3fbb30d50246e94b3906bea24220

Resolves: fdo#65716 MACROLANG not substituted in title

Change-Id: I1fa71a926e0df753a553f43aebaa201a13f74f95
(cherry picked from commit a85aed77e68f703db04e9f78625734c7551a9281)
Reviewed-on: https://gerrit.libreoffice.org/4518
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>