Insert - Watermark menu

Change-Id: Id3fcd40d59021d73f03a0a5db2afcdecb62b5e03

Fix Table Properties macro

Change-Id: I45e5b258ba8f739e3dc0043978488ee9e4ad74b4

Revert "Add windows start menu entry for Safe Mode"

This reverts commit 1ffc0ddfef403bd7cae3e43a4af368a4db7cc9f7.

tdf#116830 sw: handle cell background for BACKGROUND_PARA_OVER_DRAWINGS

Commit 18b3feb8bef06bf7b126fd0bc743e19479cb8026 (n#778133 sw: add
BackgroundParaOverDrawings compat flag, 2012-09-12) added a layout
compat flag that is meant to make Writer behave the same as Word when it
comes to the order of various backgrounds.

The original fix was that in case there are background shapes and also
paragraph backgrounds, then this flag can opt in to have the paragraph
backgrounds on top of background shapes.

Cell backgrounds behave the same way in Word, so extend the behavior of
the compat flag to cover not only the background of text frames but also
of cell frames.

(The test could be hacked into CppunitTest_sw_uiwriter, but 1) this is
layout, not UI and 2) that one started to get rather large.)

(cherry picked from commit 09954c381895f340c9b73af64b0833d8b4689c06)

Change-Id: Ifca1851217000f6daac50e6c9562c042aca6ff7d
Reviewed-on: https://gerrit.libreoffice.org/52668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit c8357e261be6715dd6c23219778362126d4a9844)

tdf#116555 filter: make sure default extension for HTML is not .xhtml

Since by default we don't write XHTML markup in the sw HTML export.

(cherry picked from commit 87e7fd163bc587b5c7cbb59ba40a9856f8bb225d)

Change-Id: Ifbf9850652d7838582725be391b2fd1a062495e5
Reviewed-on: https://gerrit.libreoffice.org/52709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit a3925ee114d551567a106161d9e747318ab60c6f)

tdf#116890: make unique column names in prepared statement

...like we do resultset.

Thanks to Lionel for this solution

Reviewed-on: https://gerrit.libreoffice.org/52662
(cherry picked from commit dc823f5fa4a5d2eca56297b9045e5962536c00f9)

Change-Id: I44f307cd6bddf76716d7c73b8783070abe43bdf3
Reviewed-on: https://gerrit.libreoffice.org/52698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
(cherry picked from commit 0d78d17249a58d95b4aa2e8fe09f08e22f20c407)

tdf#116772 adapt handling of LIKE conditions to cleaned up StructuredFilter

Change-Id: Ifc60da9a95833ee7820a0e03354fa1a8c006e136
Reviewed-on: https://gerrit.libreoffice.org/52576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 060e43da66c759de2c4799131e13c5156f01d492)

SQL string quoting: escape "'" character also at beginning of string

Change-Id: I51db43c1a3b6d3c93a04a3419238ea286cab987e
Reviewed-on: https://gerrit.libreoffice.org/52577
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 1ddb065adcd0c2f5666e86bdf841d818ab7a215e)

tdf#116536 Fix bullet position with linespacing > 100

Change-Id: I862246d9c69e754bdd883787fe42c7d61a1a53d3
Reviewed-on: https://gerrit.libreoffice.org/51790
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 596fd41b9b19e28bab0c84e3821f79cb5d468f24)
Reviewed-on: https://gerrit.libreoffice.org/52148
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e3bcaf133db6c78b0a7baeada6f7692a12e07cb2)

tdf#116410 DOCX import: restrict increased object spacing to multiple shapes

This anchored object handling is just there to be bug-compatible with
Word, it's not needed for the case when there is a single shape in the
paragraph.

(cherry picked from commit 2c4d84e93901571ead79c85aa3894ef4e10bf5af)

Also:

Related: tdf#115719 DOCX import: fix ignore of increased anchored obj spacing

If there is only a single anchored object, then ignore only the current
paragraph, not all paragraphs of the section.

(cherry picked from commit 599ff05300599d4e4ce818092f18e76e738b921e)

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx

Change-Id: I5e3dc4ba9a4a6f459ec6217e8974ebc2d7303bcc
Reviewed-on: https://gerrit.libreoffice.org/52022
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit da01b17379fcb3cb89eddf718c922d1676aa482a)

tdf#115407: preselect sound file saved

To display the sound in the dropbox, the complete filename
(eg: file:///home/julien/lo/libreoffice/instdir/share/gallery/sounds/pluck.wav)
was compared with items of the sound list formed like this:
file:///home/julien/lo/libreoffice/instdir/program/../share/gallery/sounds/pluck.wav

See https://bugs.documentfoundation.org/show_bug.cgi?id=115407#c1

Since listbox displays only basename, let's just compare basenames

Change-Id: I5fb49990322423fa7818e5d6e1cafd828e3500ec
Reviewed-on: https://gerrit.libreoffice.org/52476
(cherry picked from commit 23c82e1a377ea6fce65d71277ec59b3ca150b98a)
Reviewed-on: https://gerrit.libreoffice.org/52489
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 1576908dd0b5b275f90b50c0794559547aa0a25e)

Merge in Flatpak improvements

...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

commit 7a2393f5fcab8c6938180c4718f2c61acd495528
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 10:41:22 2018 +0100

    port to freedesktop.org 1.6 runtime

    Gtk+3/GIO/etc dependencies used by LO in "GNOME" mode are actually
    included in the freedesktop.org runtime. Try to build against fd.o
    by downgrading gst-libav (fd.o has gst 1.10 rather than gnome's 1.12),
    bundling dbus-glib and disable Gtk+ 2.

commit 42650da01f270e86bfb40035a9194b23ccf24c4c
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 11:23:27 2018 +0100

    fix up LD_LIBRARY_PATH with gcc7

    Append to library path rather than resetting it (causes build failures
    due to overriding /app/lib).

commit 3e4c655294c8124cb54e1c651ec4dc1230b8151e
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 11:25:02 2018 +0100

    fixup solenv/bin/assemble_flatpak.sh

    Use mkdir -p to be robust to other modules (ie dbus-glib) creating
    some of the paths before we do.

commit d1d449ffa837b1de876f524494dbce09ec92ce73
Author: Robert McQueen <rob@endlessm.com>
Date:   Wed Apr 4 15:50:49 2018 +0100

    split resource/registry data into Locales extension

    Move the language-specific data into the /app/share/runtime path which
    flatpak-builder splits into the Locale extension if we re-enable
    separate-locales. We symlink the original locations back to these paths, which
    means we have dangling symlinks depending on which Locale sutpaths are
    installed.

    Include Stephan Bergmann's patch from https://gerrit.libreoffice.org/#/c/52381/
    to make the configmgr robust to such dangling links.

commit ad6674f166c68fb79e19d80950a104a0a33f81dc
Author: Robert McQueen <rob@endlessm.com>
Date:   Wed Apr 4 16:05:28 2018 +0100

    make locale split glob more specific

    This loop will fail if the share/registry/res folder gains any .xcd
    files which are not named fcfg_langpack_* or registry_* so just to
    be safe, only glob these files.

Change-Id: Icd41d7077b9f308dbb196927715b210328709662
Reviewed-on: https://gerrit.libreoffice.org/52642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 727bfa2c87db170483c1e4ae895174295b070c77)
Reviewed-on: https://gerrit.libreoffice.org/52653
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 14d68eedb534d55cf2df60de38822c9b1678f9d7)

forcepoint#37 revert tdf#108572 let remove storage element

reverts

commit 26957fc325c27cf61e8ef5555b380d627def4931
Date:   Wed Sep 6 10:54:50 2017 +0200

    tdf#108572 let remove storage element

    void OStorage_Impl::RemoveElement( SotElement_Impl* pElement )
    expects that m_pAntiImpl will be nullptr, if not throws an exception.
    This caused that in case of deleting embedded database used for
    mail merge it wasn't fully removed and

The problem is that by allowing the removal of the element, existing readonly
accessors are left pointing to the deleted element which causes quite some problems
as seen in this sample document

Change-Id: Ie6ac36e6dea771b02637d77b78eb8026e3bb7ae8
Reviewed-on: https://gerrit.libreoffice.org/52600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 8182037871daf1d94f4beff63afeb56b20055480)

ofz#7109 infinite regress

Change-Id: Iac0bd81c9b0e3ac6b005bb0065895ca1b4ca4233
Reviewed-on: https://gerrit.libreoffice.org/51827
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit d7608726fbdc42749c35a3a49d094cd0c5c3476d)

fix global-buffer-overflow found through UI testing on UBSAN jenkins job

Change-Id: Ie4d81561057bb4d67fe050ca7fb82861d5d207a2
Reviewed-on: https://gerrit.libreoffice.org/52587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit c442ac8c20cfceb8c87e96c494dcd8372dc6e206)
Reviewed-on: https://gerrit.libreoffice.org/52609
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 9d3444ffe5b0ec37ad99d6969179184abea21385)

Related: tdf#77919 GetPosPixel() is relative to parent, not grandparent

so the tooltip rectangle is wrong and doesn't shown under mutter

we could use pCtrl->OutputToScreenPixel(Point(0, 0)) here too

Change-Id: I75a717127ad75a4aac2cb9c22e526419f798ea99
Reviewed-on: https://gerrit.libreoffice.org/52654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 7d95ef515c604bf67e68fd4824aa0073d8a76d07)

tdf#116706 fix for AGGREGATE with hidden rows and single references.

Change-Id: I6ac88f26b46a17e1857b7b40d2034fb321973625
Reviewed-on: https://gerrit.libreoffice.org/52522
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 0a4c1fb68c3619e61099a7c548f550b0d3fd7a53)
Reviewed-on: https://gerrit.libreoffice.org/52651
(cherry picked from commit 2c51260d91490a6fc512875d8befb38367bf3227)

Return correct length for Authority token

Regression from f4fd558ac9d61fe06aa0f56d829916ef9e5ee7b9
Take the chance to calculate token prefix just once.

Change-Id: I19ce5cb037198cb918e79c760a92b285f9b725f1
(cherry picked from commit 34b98af8e5a4e568d8316700bea1ce604d825ce8)
Reviewed-on: https://gerrit.libreoffice.org/52621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit c6e8460a5b47fa6fa971dde2a89e80662b6e97ae)

Fix regressions from d727476cff29382a34103b137542e15e1aeeb4b9

Calls to statusChanged may call addStatusListener or removeStatusListener
so copy m_aStatusListenerVector on stack and iterate on the copy

Thank you Michael for having pointed these

Change-Id: I8399db84874d7f68e24c57891a9ab408e7ebef78
Reviewed-on: https://gerrit.libreoffice.org/52579
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 8fced3ec9ff6f55a6e0b939183cf33b6c3c4a1db)
Reviewed-on: https://gerrit.libreoffice.org/52584
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 1e80227ff76896a2bb6243acff19a49567bb2387)

Add export of the side wall for 3D chart, during .xlsx export

LibreOffice doens't distinguish between sideWall and backWall.
It is controlled by the same Wall property.

Change-Id: If1919cf0a9bad3e80544cc5b2ae0f40f606febeb
Reviewed-on: https://gerrit.libreoffice.org/49429
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit ff63bae0133e3b90b32af88a4307fb4f5dafd95f)
Reviewed-on: https://gerrit.libreoffice.org/50679
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 49c0d98cb2bec7d171f9847b1335874c05042187)

tdf#114168 If minor axis unit is automatic, then set it to 5

Based on OOXML implementation in MS Excel,
if Minor axis Unit is set to automatic,
then during chart import, LibreOffice should set
Interval Count to 5, to mimic behaviour of MS Excel.
Becaues default Interval Count for LibreOffice is 2,
we need to override it to 5.
With that solution, the Minor axis unit is preserved
also after saving to .ods file format.

During .xlsx export, if Interval Count is set to 5,
then treat is as automatic axis unit.

Change-Id: Iab9209fb3950ef73e79229329606363b528d35fe
Reviewed-on: https://gerrit.libreoffice.org/49327
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit 274825b4180c81540cd0d1b22c5243f1b39fe4db)
Reviewed-on: https://gerrit.libreoffice.org/50676
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 40e722fd44e3cf026e1aee2b2c2c97eb57b53468)

tdf#114139 Don't export Plot Area shape property fot 3D charts

For 2D charts Plot Area equivalent is Chart Wall.
Unfortunately LibreOffice doesn't have Plot Area equivalent for 3D chart.
It means that Plot Area couldn't be displayed and changed for 3D chars in LibreOffice.
We cannot write Wall attributes into Plot Area for 3D charts, because Wall us used as background wall.

Change-Id: I16d3b326571c1e411a094ec799e20c7aeeb2c1d4
Reviewed-on: https://gerrit.libreoffice.org/49428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 5b9e76557d2b5c835a5873de1ce530f36ea98d2d)
Reviewed-on: https://gerrit.libreoffice.org/50678
(cherry picked from commit dfd19459a336a6cd9a67a0d3dc3cf305de567be1)

Avoid crash-reporter crash.

http://crashreport.libreoffice.org/stats/crash_details/f5086a7d-3c67-46e4-945e-e0882a604eee

Change-Id: Ic9ceed2e736a4ad1c155a31d3b2dc453e6a562aa
Reviewed-on: https://gerrit.libreoffice.org/52119
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/52516
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit f4082279078b59f0960d6683d0d039756354eccd)

configure: check for EGL header if EGL is required

Change-Id: Id7501b9adcd817ce84bfde3a928fe8b4c7e7e01f
Reviewed-on: https://gerrit.libreoffice.org/52330
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit e2e3118465411448a3b1f5e56c3456384c009f99)
Reviewed-on: https://gerrit.libreoffice.org/52382
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit e336b70550a5615a9b6fd1848c5785fe54c3156a)

tdf#114738 Add support for transparency for EMF+ records

With current EMF+ implementation all filled figures,
does not support transparency.
This patch add transparency support for following EMF+ records:
- DrawDriverString
- DrawString
- FillEllipse
- FillRects
- FillPolygon
- FillPie
- FillPath
- FillRegion

Change-Id: I1e59ea90bdf5fafc07ff9417fccace44872bbecd
Reviewed-on: https://gerrit.libreoffice.org/52021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit aee1904446cd0508cdf06fd23155373b5018dfed)

Ignore dangling symlink configuration files

This will be used by the Flatpak build, to offload per-locale data to a Locale
extension (which expects all per-locale files to be in one place, so we need to
add---potentially dangling, if a given locale is not installed---symlinks from
the original places to the location where that Locale extension stores the
actual files).

Change-Id: Id13b8c53fbc9e0763e53fd09c0c059c9e638c13d
Reviewed-on: https://gerrit.libreoffice.org/52381
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 8bd827c976037381be963d4ef99bfb9a2d720889)
Reviewed-on: https://gerrit.libreoffice.org/52397
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d5d9e64cd65ca0f9fbd07cea27bd7b17dffd8c76)

forcepoint #3: sw: don't do section-in-table splits when this is table

The problem with the bugdoc is that SwFrame::GetNextSctLeaf() creates a
follow frame for a section in a table, and puts it outside the table,
below the page's body frame, while moving text frames that have the
mbInfTab flag set into the follow frame.

The situation is different from forcepoint #18 though: the frame "this"
is a SwTabFrame here, and GetNextCellLeaf() *does* return a plausible
looking follow cell frame, however it's ignored later because
CanContainSplitSection(this) is false since it's a SwTabFrame.

IIRC table-in-section-in-table should not be split anyway, so
just add a check here and return early.

(regression f8a76d218305a56d15b82b9dac4fafa558872780)

Revert "forcepoint #3"
This reverts commit 34627ad7d03f93b89689b2e48a3985574d10f965
because it was just a work-around not to crash with the invalid table
frames.

Change-Id: I54692a67edade23c6b8e0a9be806728b0012a3fd
Reviewed-on: https://gerrit.libreoffice.org/51751
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 5e18136a01208f5df7c5f554bbcdab2ef661e136)
Reviewed-on: https://gerrit.libreoffice.org/52383
(cherry picked from commit 20e1544a3f84e784df65750d62eea42090d79a48)

Resolves: tdf#116540 Revert "ofz infinite loop"

This reverts commit e4551b905e12aa92b7509d9b994bfae5dec3d8e0.

Change-Id: I95634dd166c51586b5da47b996993a098823ca32
Reviewed-on: https://gerrit.libreoffice.org/51942
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 35f5f4c1537eadab85cddde5f9fd47a7421ebf3d)

forcepoint #33 ensure payload is a EMFPPath

Change-Id: I0a9f332cc66e43caa4e1611006fa765cad063539
Reviewed-on: https://gerrit.libreoffice.org/51915
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 7127598586faf612250129f1914c8a0ee9de5a5a)

forcepoint #32 survive missing emf paths

Change-Id: Ic27c3bbac12f66b30ff2f30f558180127cc73a51
Reviewed-on: https://gerrit.libreoffice.org/51874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 94c1f958d381b715816921f80e4142a052b77242)

forcepoint #32 survive missing value range

Change-Id: I90315f0481bf73c4d9071959bf5408f4a2690257
Reviewed-on: https://gerrit.libreoffice.org/51885
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit c30c7fc991e1bc5e7d81ec0c1e5abeca33d14162)

forcepoint #34 survive missing autostyles

Change-Id: I742816297659d614e836a8d5e8965b1c55154719
Reviewed-on: https://gerrit.libreoffice.org/51891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit c52efdf90592235e73f2d4c6e8579fb980c537c3)

forcepoint #31 check validity of another group range

Change-Id: I82ff3e47a033c91581b108e1685b1ff4d5865895
Reviewed-on: https://gerrit.libreoffice.org/51882
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 0213fc80c7bf8022fc2781c5a230d169eaa2c885)

forcepoint #31 survive missing control model

Change-Id: I37e4af560b46b4f6d9e0b87fe58493818f366d3c
Reviewed-on: https://gerrit.libreoffice.org/51877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 713a85d9a315b4fa84e1c5704bcb9c4f7457d113)

forcepoint #30 check validity of group range

Change-Id: Ie0611f36809b051ce46030e44c137b4e1f8d2fe0
Reviewed-on: https://gerrit.libreoffice.org/51864
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 6969f1fbfd1c8ead222af416ff86f30e2f74f00e)

forcepoint #29 detect illegal self series add

Change-Id: I3bba0f942780c54951a3a810c05cc3b56ca18a5e
Reviewed-on: https://gerrit.libreoffice.org/51861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 06af4f16ec1a6bfc93d5f22dba073a1f7093df8d)

forcepoint #28 missing cell on abw import

Change-Id: I7633a17afab5aa2eb9e47a552bd5d92c87d383c7
Reviewed-on: https://gerrit.libreoffice.org/51852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 7d99214d77ea0300cd149655bac70012a57278fe)

ofz#7110 ensure join is called on std::exceptions as well as uno::Exception

Change-Id: I1d17301e4d7f951b7176d5a91c0dca0ef051b2a2
Reviewed-on: https://gerrit.libreoffice.org/51831
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit cc709725803901edbb2c4c1cc4dad4114d91ef74)

a11y crash with no chars selected in character map

type gibberish in character map search box, click character map widget,
crash

Change-Id: Ifa3e4bce2d7e0b84cf3c5033eb819c73076daabe
Reviewed-on: https://gerrit.libreoffice.org/51775
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit ebd78caf7ff49328b902158ad101e9496b0f7a5b)

tdf#114648 tdf#115683 don't show new document until dialogs are gone

Change-Id: Ia9cb3fd549c17cb602fa3d7f9163a89697395c77
Reviewed-on: https://gerrit.libreoffice.org/51649
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit d604d977a748e982c3e71f09daf08ed5af778ed0)

Resolves: tdf#116474 bring hidden text property under undo control

Change-Id: I7bc18e8bc34f2a759371950f9d20dce48f472131
Reviewed-on: https://gerrit.libreoffice.org/51635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 2028cb82837393ac0ae283a41ac7187d203085dc)

tdf#84205 If theme not found, use first

Not a complete fix, workaround.

Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94
Reviewed-on: https://gerrit.libreoffice.org/51440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/51582
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit b8bb9a94266035b0d4579a7dbb3252a85fc896bc)

tdf#116544 crash on unhandled IllegalArgument exception

Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49
Reviewed-on: https://gerrit.libreoffice.org/51834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 944b882d3296b33f4b33b8ef3e33d020ed428732)

tdf#116266: Take into account file extension when image type is unknown

For external images there is no always exists image type,
we need to take into account the file extension to determine
its mime type.

Added unit test.

Reviewed-on: https://gerrit.libreoffice.org/52375
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit bc906ec69d47ecde13ddf63cf3d366ec89055cfe)

Change-Id: I884ae18939b6def683bb318260c4e195da5bb252

ofz#7063 ensure lifecycle

Change-Id: I18d62bc3bd409ca65c85ea47e8d5b3930481edf9
Reviewed-on: https://gerrit.libreoffice.org/51732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 717e0853dce50c33b61ea8541d24186e40e84c73)

ofz#7043 already registered

Change-Id: Ic94891c82944d04fe3391c0bd0731a6e3e4373e0
Reviewed-on: https://gerrit.libreoffice.org/51692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 30f57a9e59fd35e872ae9d8ddd7b319e467abb74)

forcepoint #35 handle odd number of dimension fragments

Change-Id: I97e4e1b38d80276077b3427c90ae33023afb5e59
Reviewed-on: https://gerrit.libreoffice.org/51900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 84d88ac8dc1763280ec45d0c341b1658d4af14b6)

ofz#7165 set a recursion limit for svm in svm

Change-Id: Id9089986012588690b6d5e33cd71d094ef2357dd
Reviewed-on: https://gerrit.libreoffice.org/51983
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 2e82188ff824f9d9f1cf7161f882ff7f3d227e7f)

forcepoint#36 avoid dangling SvTextShapeImportHelper in case of exceptions

Change-Id: Ibdbc047029c31d2b06d2349d68e1cbd9b15fd514
Reviewed-on: https://gerrit.libreoffice.org/52136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit e0f2887736aebf1244dc85ae7e05e65e1e3fb988)

A semicolon missing

Change-Id: I286aa29c94068b63dfef8cca9707afafc8562a50
Reviewed-on: https://gerrit.libreoffice.org/52371
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 1e3646411507640ab6790eae8796992c036be085)

tdf#116581: also read UTF16-encoded version string from TTF

Change-Id: I47d8a755450b085be39346615f06cee4f920859f
Reviewed-on: https://gerrit.libreoffice.org/51781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 2367557493c216be5b5e8156ba6493d440a10b0f)
Reviewed-on: https://gerrit.libreoffice.org/52327
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f207ae9c7010b04f8a10554a3c9b62991fe51247)

Make color scheme dropdown in Options span the window’s width

It was minuscule before.
Props to Andreas for reporting the issue.

Change-Id: If8ecbe39321c56018e2366147481dcefab4326dc
(cherry picked from commit cb5a55adbb67d9515f0048d1b2b595c04f2e2736)
Reviewed-on: https://gerrit.libreoffice.org/52238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 74362ac38814872d49de9d5ae32e7e61ae04a544)

tdf#106746: pDelPam is a bit special

Regression from db17d3c17c40d6b0e92392cf3c6e343d1d17b771

Change-Id: I17e2fef2eb16a900cc487b75c3b9dbba2764ac71
Reviewed-on: https://gerrit.libreoffice.org/51814
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 7b1d50e97eaa00855152e74f42b789fc643e0bac)
Reviewed-on: https://gerrit.libreoffice.org/51905
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 8e2850752bfa86f9b7c6f10a74d5ed69bc20ebee)

tdf#112997 multiple animated gif only one frame

Not sure what the problem is, but using a vector and just making sure
we insert into the right spot for the sorting fixes it.

Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63
Reviewed-on: https://gerrit.libreoffice.org/51829
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit d312ff2b52c0ea2e2864518a36f6b432653c8297)
Reviewed-on: https://gerrit.libreoffice.org/52009
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2439b95b4d34e519aa2a5617a7f1e194b7864222)

tdf#75256 Sifr bug fix

Wrong filename and lc_defineprintarea matches 32px and 16px now

Change-Id: I7aab973ad30f820d65c1049d62161e51879a6b4a
Reviewed-on: https://gerrit.libreoffice.org/52275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
(cherry picked from commit 20c680092fa2598feb4541b1c69a8389779dbae4)
Reviewed-on: https://gerrit.libreoffice.org/52287
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 2a2aeaeef39f6a940838e2da69c5e1bc61e3793d)

lok: sc: clicking outside a pop-up or context menu doesn't close it

Change-Id: Iecf0659467264d921c7c9faddc98fd5519e7db93
Reviewed-on: https://gerrit.libreoffice.org/52617
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 1cd76097043a5ece899dd7c9468755dcd961b0eb)
Reviewed-on: https://gerrit.libreoffice.org/52737

coverity#1426923 Pointer to local outside scope

Change-Id: I200b09dc514b64fbd88050a1f5a8668ec640305f
Reviewed-on: https://gerrit.libreoffice.org/47040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 6fabcc6d45774d1c99c99a6d0dc92c44ac196185)

sw lok: Don't try to open TOC marks in a new window, jump instead.

Change-Id: I1ecae82c4b1e08383f6957c38cb70b91fc3549d4
Reviewed-on: https://gerrit.libreoffice.org/52504
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/52508

tdf#116733: Fix expanding in the entries in "Open expert configuration".

The DoubleClickHdl()'s return value does not mean "was handled", but actually
"is there anything more to be done".

Change-Id: Ideeee31db648829546a713148124e3d366941b9a
Reviewed-on: https://gerrit.libreoffice.org/52292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 3af6be55ae1dabb1b72cbb4c57cca33c28b347f8)
Reviewed-on: https://gerrit.libreoffice.org/52305
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

tdf#116628: Fix expanding the entries in Help's Contents tab.

Change-Id: I50627ca577bf89810c716bf9e1db9ae74cec58d1
Reviewed-on: https://gerrit.libreoffice.org/52475
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

If the function is in mergelib, store mergelib module

Regression from commit 707f787cd991f9c59712cd3020d127d09605c792
It didn't ensure that we store mergelib when required, thus still
trying to get function from stubs and failing (with mergelibs
enabled), leading to SEGFAULT later.

Change-Id: Ib15528795f3d65b1ae5c31be2aa5284ce5ff04cf
Reviewed-on: https://gerrit.libreoffice.org/52428
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/52453

oox: don't segfault when failing to open a custom fragment

Change-Id: Ie05d1feea2e930b117b3754c6e0db86bdb85bc61
Reviewed-on: https://gerrit.libreoffice.org/51681
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f82888653c853f236ab0035bb578a7129ec72fa5)
Reviewed-on: https://gerrit.libreoffice.org/52228
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Add mode lines and license blurb

Change-Id: Ifc319e6954665b71f8a98d6ec849a71bbf2b7318
(cherry picked from commit 850b401ebad13d20481f3ed01990c8070a33f6f1)
Reviewed-on: https://gerrit.libreoffice.org/52096
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52319

Add DeleteNamedRange function

Change-Id: I081614cb34aee704c9162f58c78dbaa6a350d30b
(cherry picked from commit f21e341d0fbfb39f7d5d976f89f00f844e201576)
Reviewed-on: https://gerrit.libreoffice.org/52095
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52318

Add NamedRanges.py to the relevant Makefile

Change-Id: Ic2d36182795b2d27aec8fed8665d8bb9f8f12a0f
Reviewed-on: https://gerrit.libreoffice.org/51975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit a260eabf5c228567fc64e99ca72d332f7ebaf0d4)
Reviewed-on: https://gerrit.libreoffice.org/52094
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52317

Fix class name in debug message

Change-Id: I171e74a34273ddf969e49260fec487dd8cf2fb12
Reviewed-on: https://gerrit.libreoffice.org/51981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 8329f4541e27402d19729ae1588af8bfe61f7b49)
Reviewed-on: https://gerrit.libreoffice.org/52093
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52316

Add another sample Python script, to handle named ranges in spreadsheets

Change-Id: Ibe11ab2c3513a05b9aec574602b24df70270908c
Reviewed-on: https://gerrit.libreoffice.org/51968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit e32b4c8a079e4b51b1028d2467b872ff5b8cdd3a)
Reviewed-on: https://gerrit.libreoffice.org/52092
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52315

Handle also []any in unoAnyToPropertyTree()

We add it as a subtree where each element in the sequence has as its
name its number.

Change-Id: I9422777d887d899f76ad6d259631d15c2db53f03
Reviewed-on: https://gerrit.libreoffice.org/51967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 1bf2ed44a18666843d6c1b4a92966fd78cda07bf)
Reviewed-on: https://gerrit.libreoffice.org/52091
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52314

Add another sample Python script

Change-Id: I542a8b36a097d8961dc76fdcc3d25a3d7b6eb526
Reviewed-on: https://gerrit.libreoffice.org/51966
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit aa27a25d152ab70f60fedcea3bd4cd99d68103a0)
Reviewed-on: https://gerrit.libreoffice.org/52090
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52313

Filter out "SynchronMode" too

Change-Id: I2c5111ee34929b9740796f5e1f08b3a8a58218e4
Reviewed-on: https://gerrit.libreoffice.org/51964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 2147cbf6204ebca8fb5a306ad5d81215b1175ac2)
Reviewed-on: https://gerrit.libreoffice.org/52089
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52312

Bin some dead code

We defined the same function member in the class PythonScriptProvider
twice. The first one was some accidental leftover surely.

Change-Id: I10eebab7084af790a9263176f01f7817fa5124ff
Reviewed-on: https://gerrit.libreoffice.org/51965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit e25b905106598578449d5b2864654d0f58c3147f)
Reviewed-on: https://gerrit.libreoffice.org/52088
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52311

Add a separator between two words in an exception message

Change-Id: I5c2e01249058e03edfcf036036f9595b87f0a070
Reviewed-on: https://gerrit.libreoffice.org/51963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 7e16966d517f1c25e673ddbb88e72cf418f5aeaa)
Reviewed-on: https://gerrit.libreoffice.org/52087
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/52310

tdf#115853: save current custom property when adding line

by reloading current lines before adding a brand new one
indeed the info are deleted by ClearCustomProperties
each time SfxDocumentInfoItem destructor is called

Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d
Reviewed-on: https://gerrit.libreoffice.org/50070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/51297
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 5d3313c832862b545cf6ec35c2b6c5fc08d8213c)

tdf#115396 fix mode of files installed from externals

Change-Id: I608f46235f2e80e74f6900831d13e082b167cfce
Reviewed-on: https://gerrit.libreoffice.org/52144
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 4cb868abaf789afe3f2b4bc65454c21c08666a78)

tdf#116692 (Paragraph) Classification Dialog does not show translated UI

Change-Id: I9a08fe3d2d5efc14c8845993d3b18a230df51052
Reviewed-on: https://gerrit.libreoffice.org/52098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-on: https://gerrit.libreoffice.org/52143
(cherry picked from commit 87e8815b57d384587b4d6ccd092f54fa2c539970)

update credits

Change-Id: I8973bbbfd0b51106b528c1def872e1018a9c2159
(cherry picked from commit 14a8dfcfae560d8bb8592af64f2d133683decfc2)
(cherry picked from commit 1a96483c413c7fd61f896ccb879b39b65d42749c)

update emoji autocorrect files from po-files

Change-Id: I3247b2deb2c44ca2babc495d1fb1777bd6894c3e
(cherry picked from commit 5fec56c7e472cdd5484936f71e1ae2e1b13d5e1c)

tdf#116525 writer, no shadow around box

regression from

    commit 2ccde70d60d3a5074faf49260e8fe0ccdb91ff26
    teach redundantcast plugin about functional casts

because we are now passing the same variable as a both an in-parameter
and an out-parameter

Change-Id: I6454103fbc46530180cde5f725273e062eb2e25d
Reviewed-on: https://gerrit.libreoffice.org/51757
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 327fd7ea7209c9131ac86757fa8d5ca925eeccb5)
Reviewed-on: https://gerrit.libreoffice.org/52012
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 4027823b5aff2bc0503ed63baae64a33d75c6ffb)

missing ar_right icon used by starmath edit symbols dialog

it used to live at icon-themes/galaxy/res/helpimg/starmath/ar_right.png

but got moved by...

commit 2f6f851acab5284f516ad6a91c05149ffed575d2
Date:   Wed Sep 28 07:30:35 2016 +0200

    tdf#100015 (related) Move Math help icons to correct location

    So that they are actually packaged into the theme zip

and then removed by...

commit 38ded0332875a3d8ee34ddb4f2eac00d60517263
Date:   Mon Dec 12 15:11:13 2016 +0100

    Move help-specific images (the actual files) away from core

leaving this dialog missing its arrow image

Change-Id: I08127a823868d0b32b5f74bd5a7fb3fbfae95b28
Reviewed-on: https://gerrit.libreoffice.org/52024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit e5b41e4d3fe400ba1ba8ff4a2f0ec41e6538535e)

Don't pass empty option to JNI_CreateJavaVM

sUserClassPath may be empty (instead of containing "-Djava.class.path=...")
here, which older versions of Java have apparently silently ignored.  But
Java 10 now fails with JNI_EINVAL (-6).  (Happens e.g. during
CppunitTest_dbaccess_hsqldb_test.)

Change-Id: Ifd13222f0d0ae69547bd1a9fe0fd5eae47917d0a
Reviewed-on: https://gerrit.libreoffice.org/51949
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 19d2ec6539f789dfbe38612e5e7807cac9fe0819)
Reviewed-on: https://gerrit.libreoffice.org/51977
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 9a335d04c017b39df309471f5614cfdbe8ba2ce9)

Fix typo ("x86_64" -> "X86_64")

...introduced with 2d2294fb82bd4f0d1d805405631aeb1acbc36cbb "Add x64 Windows
here, too".  As reported by Richard Webb at
<https://lists.freedesktop.org/archives/libreoffice/2018-March/079870.html>
"Re: Manifest.xml for 64bit LO".

Change-Id: I1681908012e73e520bebd79b8149788358ea49a3
Reviewed-on: https://gerrit.libreoffice.org/51946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 045e2755163042c3c0bc83595b1c73104cb76721)
Reviewed-on: https://gerrit.libreoffice.org/51950
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 6d142e8f0a3dfb609ccaf9dd8905a16ed5525c36)

tdf#106667 Hang when trying to open a dialog and the whole sheet is selected

regression from

    commit 8d54796bf152499ecbe61788be64c9035f725dfa (patch)
    enhance pass-by-ref plugin to detect large arguments

which converted this peice of code into an O(n^2) loop

Change-Id: I0473a084518c0d10411615e1b3901b9b90144bc9
Reviewed-on: https://gerrit.libreoffice.org/51956
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit f4f1654c07ec58bc36d824e9434ab851b7900e9f)
Reviewed-on: https://gerrit.libreoffice.org/51970
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 3638dc92ce9b251327302fc903f17d6939fb334e)

ofz#7121 NamedDBs::insert takes ownership of its argument

at one point this was based on std::auto_ptr and didn't
free its arg on failure

Adapt description to reality

Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2
(cherry picked from commit f161cdc979587488df83e63002bee7ee15152d42)

Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207
Reviewed-on: https://gerrit.libreoffice.org/51933
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 28632f5c575e1ddc0920041f72686758bf521103)

tdf#116586 fix LibreOffice crash by Hungarian personal dictionary

"AkH. 11. (old orthography)", caused by bad handling of forbidden words
of alias compressed dictionaries during run-time dictionary extension.

Note: accepting also all – previously forbidden – affixed
forms of the modified stem is a removed function: "Grammar by" spell
checking (for example, in LibreOffice via SPELLML interface of Hunspell)
supports user words with affixation and compounding.

The original idea was to add substandard or interfering words
as forbidden words – but with flags – to the dictionary, and adding
the stem to the personal dictionary could “switch on” the affixed
forms of the word, too. Now the suggested method is using
"Grammar by" personal dictionaries, as in LibreOffice:

https://wiki.documentfoundation.org/ReleaseNotes/6.0#.E2.80.9CGrammar_By.E2.80.9D_spell_checking

Change-Id: I8160d3f49a73cb2481d51c336115b6c27e7c9f1d
Reviewed-on: https://gerrit.libreoffice.org/51918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit cb717d293f31ac98d2fd214f792ac5c1441aa444)

tdf#116586 hu_AkH11 is not a default personal dictionary

Change-Id: Ib3ea432872d5bb729c9b56d66a9c338cff2bbf8b
Reviewed-on: https://gerrit.libreoffice.org/51921
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 2d08125e2ad971ac81ba8ca7a0af616e768372e6)

tdf#115573 Revert: tdf#107555 Apply 'Default Style' table style

...to newly inserted tables

Revert due to tables with autoformat style not able to persist direct
formatting.

Reviewed-on: https://gerrit.libreoffice.org/51253
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit eeb4a2ec37bf88b26a9f243cc5682e96c9e35df6)

Conflicts:
sw/source/ui/table/tautofmt.cxx

Change-Id: Ic33033235b9f5bfba15ec74fa88e94da2dc21b69
Reviewed-on: https://gerrit.libreoffice.org/51362
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 30db8c9b1d9654e62c11657140fac24f0f52c547)

tdf#116516: INTERNET_PROXY_INFO always contains char* data

Regression from e80aef4e032f08ef0c4cfbb028bf83b81002f112

The InternetQueryOption has two variants: ANSI (A) and Unicode (W)
(see https://msdn.microsoft.com/en-us/library/aa385101).
INTERNET_PROXY_INFO struct we are using is defined to contain two
LPCTSTR members (see https://msdn.microsoft.com/en-us/library/aa385148).
When UNICODE is defined, InternetQueryOption expands to W variant,
and at the same time, all MS-specific generic string types (like
TCHAR or LPCTSTR) are expanded to wchar_t-based types.

So, the expectation is that InternetQueryOptionW fills the struct
with pointers to widechar strings.

But actually this is not true: InternetQueryOptionW still returns
char-based strings in the struct; so just revert partially commit
above.

Change-Id: I0facb1baf2a191f7bafdf185e684bfe741ca677a
Reviewed-on: https://gerrit.libreoffice.org/51629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 3837901ef422d432f709dd95352796a54b58aae6)
Reviewed-on: https://gerrit.libreoffice.org/51633
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 873814828f8db91cf622e900a59ec1009dcc03a2)

tdf#116269 RTF import: implement reverse deduplication for lists

This is the same mechanism that was added in commit
1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF
import: override style properties like Word, 2014-06-17), except that
here the reference is a list definition, not a paragraph style.

Also, this commit only implements the part that inserts explicit
defaults for not repeated properties, not the actual deduplication, as
that already works at a dmapper level.

(Saving the bugdoc as DOCX, it's visible in document.xml that DOCX marks
these defaults explicitly:

<w:ind w:left="0" w:right="-6" w:firstLine="0"/>

but RTF does not, so the right place to fix this is in the tokenizer.)

(cherry picked from commit 0f0a80123d970ef6f3f8269619813e5277fff4df)

Change-Id: Iec88d9bf1032d1d89194bd272500d6780c3c2224
Reviewed-on: https://gerrit.libreoffice.org/51690
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 01d7bbdc13594965aad55269c1283716974ae743)

Enable binary search for numeric values again

... as used in LOOKUP and VLOOKUP.

This was disabled as a fallout from

    commit bad266fa06294f1dacec11ec02dfc6ae4ec8cdc4
    CommitDate: Mon Feb 22 21:30:28 2016 +0100

        ScQueryEntry::GetSearchTextPtr() with SearchType, tdf#72196

that changed the !bRegExp condition (which includes numeric) to
bLiteral (which covers only text string) searches.

Change-Id: I265286ffe75bc7cd9e660ab82b0e647d82865eb9
(cherry picked from commit c53235ba9aab844c4b16ecf7a28429e256bace6d)
Reviewed-on: https://gerrit.libreoffice.org/51779
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c3ca9d933b289df49e45f223493f3a22a1f74d14)

gpg4libre: fix failing gpg test due to over-long filenames

This squashes the following commits:

From f68929ac611fdda19c1ee413effc59d33aa5ef97 Mon Sep 17 00:00:00 2001
From: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Date: Fri, 9 Mar 2018 01:38:26 +0100
Subject: gpg4libre: fix failing gpg test due to over-long filenames

With long workdir path, gpg sometimes fails with 'gpg: can't connect
to the agent: File name too long' error.
WK recommends to create preferred socket dir under /run/user, needs
prepping though via gpgconf.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=84720

From d7ecf4a4e37a9eeffa2b40f9fe5a2e6a8f90c876 Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Sun, 18 Mar 2018 11:25:41 +0100
Subject: properly check for gpgconf (and --create-socketdir) working

From d6ed1d415d36809d784af780231258ea0ee1024f Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Sun, 18 Mar 2018 19:06:58 +0100
Subject: actually add GPGCONF to config_host.mk.in

From 7a95ee8d0badb2cbbd137a6e18af1bada35ae933 Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Sun, 18 Mar 2018 19:26:45 +0100
Subject: actually add HAVE_GPGCONF_SOCKETDIR to config_host.mk.in...

From 5204a5145d8232ea0650144fb4756c38303ef06e Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Sun, 18 Mar 2018 19:28:55 +0100
Subject: revert accidentially comitted local changes :(

From bc358d39ac985914160e8aaa23b29469470c032b Mon Sep 17 00:00:00 2001
From: Rene Engelhard <rene@debian.org>
Date: Sun, 18 Mar 2018 20:36:45 +0100
Subject: this is sh, not make...

Change-Id: I7880fd7eee57cedc19b72348b45f0c1389409fe6
Reviewed-on: https://gerrit.libreoffice.org/51521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 74d438f716d9cef165c78f950d4c53a46c37503c)

tdf#116241 Customizing value highlighting colors

Available in: Tools->Options->Application colors

Change-Id: I6e4f7a0dcad9a6ee222275019596853f0cbd3ab0
Reviewed-on: https://gerrit.libreoffice.org/51791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/51976
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

remove obsoleted --enable-activex from configs

Change-Id: Ifae3732df56e63c577cdcf19073c8cc3b9d2d1c5

Avoid ambiguities

...when sc/source/ui/inc/tabvwsh.hxx happens to be also (indirectly) included
(as happens with Windows --enable-pch?)

Change-Id: I252af03524c0d8f354a2f64a2073c2b085b3cedc
(cherry picked from commit e1131556a8485c10af8224e29dbecbfb5c608353)

Fix copy-paste error

Change-Id: I01b20482aefadb1a755cc1d2f5705b2f7f7cf739
(cherry picked from commit 9c7f19a6a38eb6796df6216ff3f014db30dd635a)

lok: don't post events on disposed window

Change-Id: I7721380b1bb6e9ec21338a72523326d0cae6729e
Reviewed-on: https://gerrit.libreoffice.org/51777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit ed4df95f28d4081c8d244dc013fda53cee5f91b7)

Mention that SfxApplication is a singleton

Change-Id: Ib1f46c9172285245ed7bbc1fab299d29928c4d10
(cherry picked from commit c5fc1a0bbffa73d0a7249f8b38823588446831c8)

Add debug output operator<< for SfxHintId, SvMacroItemId, and SfxEventHintId

Change-Id: I36fd3efc630d99643fb7db3b89f777d4054ec87d
Reviewed-on: https://gerrit.libreoffice.org/51651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 406edb6407532ed725165c2d7e1d360680050377)

lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.

To get this dialog: Right-click on a mis-spelled word, and it's in the
tunneled context menu.

Still it should be converted to async though.

Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7
Reviewed-on: https://gerrit.libreoffice.org/51441
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 7b83827d7b5d07401878fe552c421331629a7880)
Reviewed-on: https://gerrit.libreoffice.org/51548
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 67a023ef9b251c1e6e2a46521a51ad829c417451)

Add BSTR handling

Change-Id: I89fcb37a5848120d5a3b2d73d40384c18d6cc069
(cherry picked from commit 584063ccaa3c5b7b984f30e288380cdf3b2f0ec4)

lok: 14pt font is too large for the context menus.

Change-Id: I8403b2bea81e61c4fa24ed205b8d2c77a235238b
Reviewed-on: https://gerrit.libreoffice.org/51438
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 8e98b3150f7ac0b569b686dd67f4699b307b30f8)
Reviewed-on: https://gerrit.libreoffice.org/51439
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 2dd2d2fd9924e50c5b68c8942c26bf8a07fa2bf0)