Public Git Hosting - LibreOffice.git/log

tdf#106929 sw: SwCursorShell::Pop() ensure cursor ring is recreated

... from table cursor. The problem is that in this case, between
Push() and Pop() there is no call to ClearMark() or any of the other
functions that sets the SwTableCursor::m_bChanged flag, so MakeBoxSels()
is never called for the m_pCurrentCursor after Pop() and there is no
cursor ring selecting all table cells.

(regression from b227a8e4d65e4bbfe991aed9342fe3e30eca8639)

Change-Id: I5bce18b71fed60a926f4ddf9938dfb7d1ddf4e92
(cherry picked from commit c72b9c1dc5683a132bf00659e0c8556253340c97)
Reviewed-on: https://gerrit.libreoffice.org/36670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 0ae1b76c3a90226ba588eb75837ab2f494ac5d5f)

call UpdateReference also for single cell copying, tdf#105245

This is a combination of 2 commits.

call UpdateReference also for single cell copying, tdf#105245

Reviewed-on: https://gerrit.libreoffice.org/36393
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit cb57a432ba98ffe197c8fd2528e4b363c3285cc4)

only handling copy&paste needed, cut&paste bailed out, tdf#105245 follow-up

(cherry picked from commit 840ac578dc5c21731b927bad6113839c4c69c108)

946d9f09e7571d347111ad66326ab375d153e298

Change-Id: I5fed22d2835466cbd07f8dbd917e9f881b7b2832
Reviewed-on: https://gerrit.libreoffice.org/36557
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit bbdaac9c5d03d59c55dc8ec1d9c34df502c11dea)

tdf#92650: handle overwritten references correctly in undo.

(cherry picked from commit de39b6ba3a9edd20a476937ef0c78920df2f5c6d)

Conflicts:
sc/source/ui/docshell/docfunc.cxx

Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353
Reviewed-on: https://gerrit.libreoffice.org/36539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 856a2d868fedd010d58d6082d3cb4753a019408a)

actually show the newly selected cell, tdf#106194

Change-Id: I0c9f839cbe55f2670602567e61dc4aba77fbef61
Reviewed-on: https://gerrit.libreoffice.org/36303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit dbc616c0021b86e6365930ba581818fea280d1a8)
Reviewed-on: https://gerrit.libreoffice.org/36386
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 7c1314bb1e63f9c3460175a8ee30422ebf3c4d37)

Change merge cell defaults for Collabora Office

Change-Id: Ib0f96e52f268df999fde34ea7bcf9ea9706ea11a

Settings for not showing Merge Cells dialog and for emptying hidden cells

By default nothing changes. But users have the possibility to avoid the
confusing (?) Merge Cell dialog. Also, when the dialog is disabled, users
may want to set the EmptyMergedCells to true, to mimic Excel's behaviour.

Change-Id: I9656ae59199bb697c45786dd478379f5c89eb08f
Reviewed-on: https://gerrit.libreoffice.org/36680
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

sw lok: Don't open the separate formula input bar in writer tables.

With LOK, it steals focus from the user, and the user has no chance to get the
focus back again.

Change-Id: Ie54a377a9543ddda88e739fe1ebdfcb04d000ea7
Reviewed-on: https://gerrit.libreoffice.org/36686
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

catch exception like text_wrapper_get_caret_offset does

Change-Id: I7d681a5cd58af60005eefa9969ec975d5cfc5580
(cherry picked from commit 0d2a607a849e3f1b51092c7d96bc5529420cfab2)
Reviewed-on: https://gerrit.libreoffice.org/36635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 615942e388c6dfa48d1edbf645fe6b0dd67cfa40)

coverity#1405158 Wrong sizeof argument

Change-Id: Ie6b7fc3d2b7d1ac709501698e55aabc72215b187
(cherry picked from commit b17177c63a4eac55dcdaa3006abec05ab71ca1b4)
Reviewed-on: https://gerrit.libreoffice.org/36578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit ee85316249902aa19f4426acae546ee79a083b07)

tdf#106933 vcl: delete D2DWriteTextOutRenderer before exit()

As it happens this DirectWrite stuff is using some thread pool
internally, and that must be shutdown before exit(), as Win32 will
terminate all other threads at that point, and then the thread pool
wants to talk to threads that don't exist any more.

https://blogs.msdn.microsoft.com/oldnewthing/20120427-00/?p=7763/

So convert this from a global variable that is deleted from DllMain()
to a member of SalData, so it is deleted from DeInitVCL().

Change-Id: I51408a07c78758cf0c193ab66b9214d0c9dbd9e3
(cherry picked from commit df556aa47da22f96b3fcd356c12419d3035cba3c)
Reviewed-on: https://gerrit.libreoffice.org/36534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 1ba5bae490f7e14e475e0b80f03e5f444cdce908)

ofz: header has to be at least 1 pair long

Change-Id: I5725048519a2b68265e90d12b1e4bcb506c56fc2
(cherry picked from commit e72f3ce68e18ac604469ce5e856341a469af27ff)
Reviewed-on: https://gerrit.libreoffice.org/36519
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit d180418fedd4592044c33558426e9ea9be6f1ebd)

Replace EmfPlusRecordType decimal valuse with hex

Change-Id: Ia5f248282e663e86b76a8c90fb5dd55d112f6912
Reviewed-on: https://gerrit.libreoffice.org/36260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit 723ee43cf65f85d7b586ae8c98529a22621054a3)
Reviewed-on: https://gerrit.libreoffice.org/36522
(cherry picked from commit 42bf09876a8cb7faef0c2490ff3e7531de4fec8f)

tdf#106970 DOCX import: don't collapse para auto space for different nums

Commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b (tdf#106690 DOCX import:
fix automatic spacing before/after numbered para block, 2017-04-04) made
sure that autospacing is only collapsed in case the adjacent text nodes
both have a numbering rule.

It turns out there is an additional condition: even if both text nodes
have a numbering rule, do the collapsing only in case they have the same
numbering rule.

(cherry picked from commit e1c83d0514e6123faa50ad0a7aa6a9031b271c9a)

Change-Id: Idb7a2b24d7eaa9094cc36f86b8a483045a33d028
Reviewed-on: https://gerrit.libreoffice.org/36510
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit e57873156d3c04ecc34bb5f38b186ebe29567f0c)

tdf#92007 python scripts with tuple-assignments fails on access from GUI

Change-Id: Ice1d7d92cec56751cb26cbb31a5995ab30895125
Reviewed-on: https://gerrit.libreoffice.org/36399
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 7ef47336411389ac492729bef52fe62aebe90f5a)
Reviewed-on: https://gerrit.libreoffice.org/36483
(cherry picked from commit 9a6d78b722f3a49f71a680e49cf64e7cfb637c43)

Resolves: tdf#106078 get bounding box of commented region for gtk3 tooltips

Change-Id: I4fdc1f471c6c191be9c7c611926bd2b5b2b41308
(cherry picked from commit eb433f83a5f66dd1ca8ed0c62ef9cc0761b7f0ac)
Reviewed-on: https://gerrit.libreoffice.org/36383
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 244d2abb6c1bcd89cedf773d8721f62451708c3f)

tdf#105286: Implement text rotation for Impress tables

Typo: TopToBotton -> TopToBottom

Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655
Reviewed-on: https://gerrit.libreoffice.org/36014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 334e6e2f1ad3da319be0849ec426aa64b18cb599)

Add SvxTextRotateItem inherited from SvxCharRotatItem

I will be use it later for text rotation inside a table.

Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc
Reviewed-on: https://gerrit.libreoffice.org/36021
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 1e30d2aface12a31687e5a27126e2061efd4b0cd)

Introduce text rotation for Impress tables

* Introduce new table property for text rotation
* Support only two rotation angle (270° and 90°)
* Implement editing and rendering of 270° rotated
text (90° rotation was already implemented)

(cherry picked from commit c671094154ecec6f3ba5beea9d26ff0d2d4d86ad)

Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e

Implement RotateAngle API property for Impress table cells

(cherry picked from commit a0755ab8772d01797f4945016a978a2bbd8fdf20)

Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4

tdf#100926: PPTX import of table with rotated text

(cherry picked from commit 2436cf17304f25c7d34da52a321d6da0e9011d19)

Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b

ODF import / export of rotated text in Impress table

(cherry picked from commit bcb371b1a830442610ad7fda476eda5271427a50)

Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8

Fix vertical text and bitmap bullet rendering

Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e
(cherry picked from commit 15ac3f9f4dc65fc0c6020284064e3725956f5d0a)

LOK - Calc: Selecting cells to the left/top does not work properly

This patch fix a regression of commit
4b39183c5740067cc31c006214cb24b81ee0f98c "LOK - Calc: make computation
of cell cursor position faster"

The problem occurs when bAllowNeg is false.
At present should be safe, in the LOK case, to assume that
GetPosX(eWhichX) and GetPosY(eWhichX) are always 0.

In the end we could always find the screen position for the left-top
cell position and subtract it from the final screen position values.

Change-Id: I7d4bf24cb57757e7ac05fcde48ade9feec56aba7
Reviewed-on: https://gerrit.libreoffice.org/36562
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

LOK - Calc: commit 92716ab follow-up

This patch is a follow-up for commit: 92716ab (Images are not painted
below row 1000).

There is no need to set the origin to (0,0) when checking the view
range / object range overlapping.

Change-Id: Id9fe9364155edd5a50c2d60ab08dd0bdcd1f568a
Reviewed-on: https://gerrit.libreoffice.org/36588
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

vcl PDF import: don't assume larger offset -> newer trailer

Usually when the PDF file contains incremental updates the updates are
appended at the end of the document. But this is not required, the
various trailers can be in any order. Make sure that we look at the last
trailer (logically last, not the one with the largest file offset) when
looking for pages.

Reviewed-on: https://gerrit.libreoffice.org/36527
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit f15a69bd57e578ca607f14cb62f29a16986b96e6)

Conflicts:
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx

Change-Id: Idcd85a7c6bbf08c9436dd73933d79cdb683f482c

Don't crash when deleting a non-existing comment.

Change-Id: If03f19c988f4c7ba6dfe1d3058c71ec11cd1b732

sc lok: Add/Remove comment uno undo/redo

Change-Id: I34a32ebecae44fd80789ed7daf13f31b181cd4c0
(cherry picked from commit 291ec5e9708352a1d98c54814dad8db7ce38fdb9)
Reviewed-on: https://gerrit.libreoffice.org/36507
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

tdf#103058: fix build failed because of missing header

Change-Id: I8cb7a94baad753f5cab07a085ae567d2c65ef5e1
Reviewed-on: https://gerrit.libreoffice.org/36502
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

fix previous commit

Change-Id: I204f83aede085bbe4f5bd6937238b2117e51c86a

ofz#1062 ensure cshape lifecycle matches expectations

Change-Id: I586e9b3546516a0f05d86b2f7dd93e7c292a6795
Reviewed-on: https://gerrit.libreoffice.org/36300
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 4e175b7aee7c00c6d0d8449a19b26ebf25446b9d)

infinite SetDefaultSize->SetPosSize->SetDefaultSize

https://retrace.fedoraproject.org/faf/reports/1278627/

presumably the 'optimal' starting size hits the invalid size path
causing another attempt usin the optimal size, so force a valid
initial fallback size

Change-Id: I6c38ee5e1b90ce41a4550c8a8370e791f5c351b0
(cherry picked from commit 4930acb18bbd145fd995084cd95e3e9d631424ed)
Reviewed-on: https://gerrit.libreoffice.org/36453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 3e4e13300db6a0c2c60dbe733d96ff5a7b0d32e5)

tdf#106690 DOCX import: fix automatic spacing before/after numbered para block

The context is text nodes with automatic before/after spacing and
numbering rules set, like:

A
* B
* C
* D
E

The correct behavior seems to be (though I haven't found this explicitly
written in the OOXML spec) to drop spacing between B and C and C and D,
but not before B and not after D. Originally no spacing was dropped,
then commit c486e875de7c8e845594f5043a37ee8800865782 (tdf#95031 DOCX
import: auto spacing inside numbering means no spacing, 2016-10-18)
removed spacing around all B/C/D.

Fix the problem by checking the numbering rules and automatic after
spacing of the previous paragraph, so spacing before B and after D is
not removed.

Change-Id: Icbdb36e31057ab0e8ac033888cf5cc7c52dad5d0
Reviewed-on: https://gerrit.libreoffice.org/36062
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b)
Reviewed-on: https://gerrit.libreoffice.org/36142
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 776839b8bfc6eed905ce97c6fe32af8deb8d1451)

Resolves: tdf#107031 writer depends on ACTION_DEFAULT

to do its standard "honor the DragDropMode setting" on
drag and drop of outline headings into a document

Change-Id: Ie154fb237de57ae18fa22d6f50dbf890fb9ebc77
(cherry picked from commit 55e7f73640d754bf0004a0d8a989e0a20de00351)
Reviewed-on: https://gerrit.libreoffice.org/36378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 3247dce15d041d178fa2a855b53415a80df16a28)

ofz: treat short properties as run end

Change-Id: I1250f74c9f4ed6679a89c7915fb704c8b8cd693f
(cherry picked from commit 5252673d686913210dd65608b7d24b0e9d51cf00)
Reviewed-on: https://gerrit.libreoffice.org/36147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 38b8896a700ec626fbcf924b8909af9f3295341a)

don't replace content of formula field when selecting range, tdf#58635

Change-Id: I85953fdd7c2b7f193b2a815564526d985ae2bba4
Reviewed-on: https://gerrit.libreoffice.org/36309
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 42aece949ec96c775b31216bddd723aa5321e966)
Reviewed-on: https://gerrit.libreoffice.org/36310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit dcd9eef1727efb7a909f8009fde4f34f26139522)

out-of-bounds tab access when deleting second last sheet

Which in a debug build lead to STL assert
Error: attempt to subscript container with out-of-bounds index

Change-Id: I09fddbc9e4b214b0313c193f85830ed458d20c0e
(cherry picked from commit 0c55972d747511dbc711f3c9cbb4db5d8c5dc2ff)
Reviewed-on: https://gerrit.libreoffice.org/36274
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 9826eb9b6bad6f21801dd8a0016bb770085a9072)

backport various fixes to aid future backporting

ofz#725 fix hwp leak

Change-Id: I09088981ca63b297781307590092725bc1cbed1b
(cherry picked from commit 681b6361f23a8f20511ad97989c642b07f25c495)

valgrind: uninitialized reads

Change-Id: Ia1e821d1e323d85c65484c980be09f015af6517b
(cherry picked from commit afabc7d2f2fcf8fcd39ff5002f09c32e8f03d4bb)

partial loplugin:useuniqueptr extend to catch more localvar cases

hwpfilter part of...

commit aa09b0c27a6d925da428d6267daadc7338829869
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date:   Thu Apr 6 09:46:06 2017 +0200

    loplugin:useuniqueptr extend to catch more localvar cases

    i.e. where the code looks like
    {
        foo * p = new foo;
        ...
        delete p;
        return ...;
    }

Change-Id: Iad770d1904b2373b1bf8ce609f4c95882388eff8

ofz: epic slow use of std::list

Change-Id: I790a3098272101fd33f83f21bdcef1bb061efd76
Reviewed-on: https://gerrit.libreoffice.org/34635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 283e843be91ef4d727c0815d1b8a0420fd16a7fd)

use rtl::Reference in HwpReader

instead of storing both a raw pointer and an uno::Reference

(cherry picked from commit 0bab51d8ad35a31685002118cdac20657b57137a)

Change-Id: I02dd356d9693116f98ad2b96951570b3ba448b14
Reviewed-on: https://gerrit.libreoffice.org/36299
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e48ec134dbe72f17b08ebdeaaa215b29243ee5c4)

tdf#106692 writerfilter: RTF import: fix \'0d in \leveltext

It's not a newline but yet another one of those bizarre RTF-encodings.

(regression from 10e733908038407791f9c14af2a86417cc4a653c)

(cherry picked from commit 69b7204164945cfed385d58e64592ce1b17937d7)
Reviewed-on: https://gerrit.libreoffice.org/36284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit fd93d09a5b6226a8297b5dd995301d514ec7b8ca)

Change-Id: I568050b031b95ac0b6ebfa1a0c39107e62f68bed

rhbz#1438179 sw: fix toolbar "Next Track Change" / "Previous..."

There's some confusing workarounds in SwView::Execute() that aren't
needed if the SwCursorShell just calls NormalizePam() so it always
makes progress.

(cherry picked from commit 25eb0899227830cca7f28006376962d84f8e9c7a)
Reviewed-on: https://gerrit.libreoffice.org/36166
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 644aacd1e4b419f2f85b6c2e18026ca04206b378)

Change-Id: I3b014079b19925041234fcd858526148890f560c

prev/next buttons start invisible in the .ui

Change-Id: Iec577adb469109a11188e83d95de6ed3960bc1c4
(cherry picked from commit 4a84cbaa3786e6ef9fa91c7eb3a6a49a9010456b)
Reviewed-on: https://gerrit.libreoffice.org/36157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 2e716c24a628b2da2de365eb338ccc5b72960f9e)

Resolves: tdf#106725 paint default window bg before spin button bg

Change-Id: I0c7f982c3a47f45d022271eba69ebed896288d78
(cherry picked from commit 6f0f2278662e29d054690a85bad6583b5c65f918)
Reviewed-on: https://gerrit.libreoffice.org/36097
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 1a9eff02e49c11787810b61b23f1d74b5a9e9952)

tdf#106253 Precision as shown for thousand dividor

Info().nThousand contains number of thousands dividors
after which digits are not displayed, i.e. 12345 is displayed
as 12 with format 0, (in en_US)

Change-Id: Ifa5540f2efd8ab006a07eade53f7aa0d31a19eac
Reviewed-on: https://gerrit.libreoffice.org/35097
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 60d7644a46970e6eaee882e0c5d65692da206c24)
Reviewed-on: https://gerrit.libreoffice.org/35204
(cherry picked from commit 506b228992ccb5a12486e2a8607ee3c81e3467a1)

tdf#106252 Engineering notation for Precision as shown

with more tests

Reviewed-on: https://gerrit.libreoffice.org/35089
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 5f2db66ad0de6fbbae309850516e17eaa17934cb)

Change-Id: Ifc77b847af4eaaa3c85e904e46c2663b6d768241
Reviewed-on: https://gerrit.libreoffice.org/36369
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 3c68b6520e743e8ed9afa908a461f766952e030f)

Tests for "Precision as shown" following tdf#105657 tdf#106052

I was unabled to add these test svl/qa/unit/svl.cxx because
they required ScDocument::RoundValueAsShown()

Found that other formats are not supported by
"Precision as shown" option:
- engineering tdf#106252
- thousand tdf#106253

Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7
Reviewed-on: https://gerrit.libreoffice.org/34750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 7496f7d3cae8a932dc43ede8a30a99289366a264)
Reviewed-on: https://gerrit.libreoffice.org/36368
(cherry picked from commit e9d13f703f212b317682c35877571903da18b4af)

tdf#106052 Treat SubFormat for "Precision as shown"

Get precision from the correct subformat

Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267
Reviewed-on: https://gerrit.libreoffice.org/34505
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit e7f769bc67d3f132b477b3c253f8065243b9b8ac)
Reviewed-on: https://gerrit.libreoffice.org/36367
(cherry picked from commit 09478b2211bbc9ec34d8de8452e30cf1254a250c)

don't obtain the underlying SvNumberformat thrice, tdf#105657 follow-up

... which all GetFormatTable()->...(nFormat) do.
Also introduce SvNumberformat::GetMaskedType() for convenience.

Change-Id: I9495d71b99116e74e8b877ffc9cd21bd36cc7b7f
(cherry picked from commit 820cb1f86f3fd177877b8719315fc03534e2049c)
Reviewed-on: https://gerrit.libreoffice.org/36366
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 2864c32733df6b0e9975ed5ee03a747cd2932472)

tdf#105657 Treat "Precision as shown" for fractions

For Option "Precision as shown",
fraction must specificly be treated
ImpGetFractionElements retrieves values of each part
of fraction (integer, numerator, denominator)
independently from its exact representation
Update: avoid include of zformat.hxx in document4.cxx

Change-Id: Ia3ea2322f3d311c04ef71f3260730c7154c3dc15
Reviewed-on: https://gerrit.libreoffice.org/34331
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 5706b29974c1c3ab0ba5a23685accf2fbebc3e06)
Reviewed-on: https://gerrit.libreoffice.org/36365
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 9f70f8761a8cc180171022ffcffc0094c4957057)

Resolves: tdf#102286 lets not crash on null pFrame

this is the FlyEmbeddedPrt case

ensure we don't end up with a null pFrame at return time

(cherry picked from commit 5ce387c4812466e6752b434cf0f5a54f98c6a147)

Change-Id: I68ff6f0a36462cffc47d774865e69041c4dd15a8
Reviewed-on: https://gerrit.libreoffice.org/36277
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 32f2370ac805513c4a968bd461d08f66958651d7)

tdf#106943 Lock down Experimental features and Macro recording

Visually disable these features if they are locked by
system administrators

Change-Id: Ib35840312ad9c506e689ec6c9d432a88c07a5c28
Reviewed-on: https://gerrit.libreoffice.org/36095
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/36319
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 75c1af593e94c049972fd929c810a9b0be23cb20)

Collabora Crashreport Dialog

Change-Id: Id44e446684993984cf5778c82eb0a990bdd2f465

SafeMode: s/LibreOffice/%PRODUCTNAME/, small UI changes

nouns are written Upper Case only in German
also Cancel button looks odd as secondary

Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de
Reviewed-on: https://gerrit.libreoffice.org/31971
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 8020215f1f502d30a5045689b865afc0092f126f)

PDF export of PDF images: compress page stream if requested

compressStream() automatically takes care of
VCL_DEBUG_DISABLE_PDFCOMPRESSION, so this also simplifies code.

Change-Id: I7661123e6ba73f8f064ec0543a03e2ec15fd2468
Reviewed-on: https://gerrit.libreoffice.org/36415
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 54a4121f2040bd11f3d6056767f2d7ad6c7745ac)

Related: tdf#106972 vcl PDF import: downgrade PDF >= 1.5

There are two problems with these newer PDF versions:

- the current PDF export code doesn't know how to roundtrip such PDF
images (needs work on both the import and export side)
- upgrading the default PDF export version would upset readers who can't
parse PDF >= 1.5

So instead of raising the default PDF export version, for now just be
conservative and depend on pdfium to downgrade the PDF image version to
1.4 if it would be higher.

Given that this modifies the input of the graphic filter this also needs
changes in the ODF export, so that the filter result will contain that
downgraded data, not the original one.

Reviewed-on: https://gerrit.libreoffice.org/36413
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 37bdf1659ddb11d8706289511623cc7c8b0d264b)

Conflicts:
vcl/source/filter/ipdf/pdfread.cxx

Change-Id: I1efa97af8110e9a6ee3e8a7339bcc7d70457cfb0

tdf#107089 PDF export of PDF images: handle mixed filters of page streams

It's allowed to compress different page streams differently, and we must
have a single object stream for our form XObject, so just incompress all
of them to be consistent.

Change-Id: I7a20dc2084a902a37dcefa3420d59a576f120bcd
Reviewed-on: https://gerrit.libreoffice.org/36409
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 9e8598c42a1a6f2fbd88711aa9bea5961eaf7b4a)

Related: tdf#107013 PDF export of PDF images: improve content streams

It can happen that the list of content streams have an equal number of
"q" and "Q" operators when all of them is parsed. This means it's not
correct to represent these separate streams with separate form objects,
as those require equal number of "q" and "Q" operators by the end of
each object.

Instead concatenate the streams and always write a single form object,
not only in case there is a single content stream.

Change-Id: I62e4ee4c86403376155d10447404416686c84ef9
Reviewed-on: https://gerrit.libreoffice.org/36385
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit a876f982a56c0bcc04667d55a53b05c90a8c3354)

tdf#107018 PDF export of PDF images: handle references in nested dictionaries

Also get rid of the GetKeyOffset() and GetKeyValueLength() calls when
copying dictionaries: the reference already knows its offset and length,
so no need to call them. This makes the dictionary and the array
handling more similar.

Change-Id: I65936acfaf857636a8d83da3a4cec69289eb89d8
Reviewed-on: https://gerrit.libreoffice.org/36282
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit ee73747ab58fbbd5039823767693431223c347d3)

PDF export of PDF images: avoid invalid offset for not used jpeg bitmaps

I missed the JPEG case in commit
30102ded91b9ecfea172ffc6443154230ee37cbd (vcl PDF export, norefxobj:
avoid replacement bitmap, 2017-03-29).

Change-Id: If1f74c7873d05d5d7da5eb881626d4e5e535a0a1
Reviewed-on: https://gerrit.libreoffice.org/36272
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 39038a3544d1b42388a15e6098ccad8398e8ef36)

tdf#107013 PDF export of PDF images: handle page tree and content streams

Handle when the page objects are not contained in a single list, but a
tree of "pages" objects.

Also handle when the page object has multiple content streams.

Change-Id: I7c5b0949314768af5915d37830a45e843e629446
Reviewed-on: https://gerrit.libreoffice.org/36256
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 4db4b9f016256fc8d2b637ed7a8f2b097aaa864b)

tdf#103058: use RegQueryValueEx instead of RegGetValue

because the latter is unsupported on WinXP

Change-Id: Ie922271ab837637d77f3d76c5144d10a7f5a5f0d
Reviewed-on: https://gerrit.libreoffice.org/36416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit aa4e06c67dbe414ae26b757d6968eb27b5ebeb99)
Reviewed-on: https://gerrit.libreoffice.org/36419
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#103058: allow optional registration for MS ProgIDs

To allow in-place replacement of OWSSUPP.dll, we need to be able
to handle the same ProgIDs that it handles, namely:
SharePoint.OpenDocuments and its versions. This allows to use
the SharePoint integration capabilities of LO without the need to
reconfigure SharePoint server's DOCICON.xml (the system would
start the component with same name as MS Office uses).

But this cannot be the default mode, since if MS Office is installed
on the same system, we would hijack the registration, that could be
undesirable.

So, this commit adds an option to use
regsvr32 [/u] /i:Substitute_OWSSUPP path o\spsupp.dll
to also [un]register SharePoint.OpenDocuments in addition to normal
LOSPSupport.OpenDocuments.

Reviewed-on: https://gerrit.libreoffice.org/36389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(Cherry-picked from commit 88829fd914105a0837ee41d3f00f9178228c19cf)

Change-Id: Icc284f9aa8f97ecf04594dd55b99bc1e3d20740d
Reviewed-on: https://gerrit.libreoffice.org/36411
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Bump version to 5.3-5

Change-Id: I9355f7cd94de3371e8b461e881ce9847c50cc7a6

Resolves: tdf#106732 the intent was surely to return a const ref

Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2
(cherry picked from commit a7d008a8dfdc0a8b42061329b5e756b1b034abaf)
Reviewed-on: https://gerrit.libreoffice.org/36276
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit d9736ca79ed3205bb091787e09ebb736ffd808a3)

tdf#106190 Fix (again) left alignment of denominator

Instead of moving spaces from left to right, like it was done
previously, this patch insert spaces directly on right
when in denominator
This avoid complex calculation when user enter such (stupid)
format:
# ?/ ???
or
# ?/" hello world "???

In SvNumberformat::ImpNumberFill, for NF_SYMBOLTYPE_FRAC_FDIV
you need at least to move in sBuf, to insert text at the
expected place for (stupid) format like
# ?/ 100
or
# ?/" hello world "100

All these formats works, but are stored in ODF with text
after fraction

Change-Id: I296e60643e93242b8006848a643135219ad4ad0c
Reviewed-on: https://gerrit.libreoffice.org/35320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 2fd110a78d03510d031c4c6cf6ad380d82899df8)
Reviewed-on: https://gerrit.libreoffice.org/36232
(cherry picked from commit 693c929c1a475e6b4bd737e50d09d6f390700812)

Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappings

This is a combination of 2 commits.

Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappings

... for CEILING and FLOOR that were lost when introducing CEILING.MATH
and FLOOR.MATH which are semantically identical, but the export needs a
distinct known mapping otherwise the function is stored as a macro call,
which Excel dislikes.

(cherry picked from commit ea01a08763e56a7de66f0c24655a627669c8a7f7)

these FUNCFLAG_EXPORTONLY need also FUNCFLAG_MACROCALL_NEW, tdf#100011 related

Maybe one day we'll actually use these tables also for export
capabilities ...

(cherry picked from commit 4dd95cadcd330aee49b3c84d3e336b808217af46)

f3d55ec008e321d95b21e0d284c7d58d13a2399b

Change-Id: Id371c1732984a8e5567f74fd265b9aee88fb1898
Reviewed-on: https://gerrit.libreoffice.org/36233
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit 84c3729eb210ff255761c4613ba03c4fb5e949f8)

LOK - Calc: charts are misplaced

We need to update the transformation primitive wrapping the chart when
the grid offset is changed.

Change-Id: I42179fdc7cc806c5757a125881f08279767ccbcc
Reviewed-on: https://gerrit.libreoffice.org/36257
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

-Werror=maybe-unintialized

Change-Id: I73eb58e44c00d5e1cfcabe71f2ba946a81a62fa7

tdf#51358 Add Support for more slide transitions to Impress SVG Export

Ported the class WaterfallWipe.

Change-Id: I4856243c4b29e45f16ee780db42c2f742a6b1dc1
Reviewed-on: https://gerrit.libreoffice.org/35107
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

tdf#51358 Support for SweepWipe transition in SVG Export

Ported the class SweepWipe

Change-Id: Ia67b50ba53900efab977a4cb284f7d1514ff8113
Reviewed-on: https://gerrit.libreoffice.org/34906
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

tdf#51358 Add Support for FanWipe class

Ported the class FanWipe In SVG engine.

Change-Id: I8a067f2df32968bb00d5b3adc020bc9ee8296f33
Reviewed-on: https://gerrit.libreoffice.org/33910
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

tdf#51358 Support for ZigZag-Wipe transition animation in SVG support

Ported classes ZigZagWipe and BarnZigZagWipe

Change-Id: Ib15929c24dc952944ac4de5b71c541cdd99affcc
Reviewed-on: https://gerrit.libreoffice.org/33763
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Fixed my mistake: fix flipOnYAxis for SVGPathElement

Fix flipOnYAxis() method which was the cause of some SnakeWipePath
transition subtypes not working.

Change-Id: I1bea5bdddf6c6312384f59d8614a0a2bc1a6e3ba
Reviewed-on: https://gerrit.libreoffice.org/35191
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

tdf#51358 Support for BarnDoorWipe transition animation in SVG support

ported the class BarnDoorWipe

Change-Id: I10c98cf575c76bb0c96a9622721d1ab368941dca
Reviewed-on: https://gerrit.libreoffice.org/33323
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Fix flip issue in Snake animation subtype

Fix flipOnYAxis function, alongwith minor tweaks.

Change-Id: If8958de9eb651a15f86963f2e40eb364011ce41f
Reviewed-on: https://gerrit.libreoffice.org/33918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

lok: Make getPart() always return 0 in Writer.

Until now, the getPart() in writer was mis-used to return the current page
number. This breaks assumptions about parts on many places, like that
that invalidates in one part should not affect invalidates in the other part,
and similar.

We have been special casing that on many places for Writer, but we should fix
the API instead (finally) - should we need the current page number, we should
introduce a new call for that, the current situation is just confusing.

For now I kept the rest of the part-related calls untouched in Writer, as
they are less harmful.

Change-Id: I1c996cbc8a3c33778e68e5f9c20f62d57289b5c7

tdf#106974 docx export: Crop is "long", not sal_Int16

I got size sal_Int16 from the return value type of the border
spacing, but somehow failed to lookup the return value of GraphicCrop.
It now matches .doc export's sal_Int32.
Bad mistake: regression 8eff1decd91cbfb10094c25d4cf1d2b434a4da72

Change-Id: Ie149630b9da9a067de319149f23ca21f78a186cf
Reviewed-on: https://gerrit.libreoffice.org/36231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit dd3325f0938aeb79221a0bb765b0fbed0fef42e6)

tdf#104706 Enable icon for Clear Direct Formatting command

Change-Id: Iba3cbd8148794ac984a91d22d33cdec1f4453c5f
Reviewed-on: https://gerrit.libreoffice.org/36221
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 54f6a0fe470096f6bdc3942e9f3032e40dbfcd23)
Reviewed-on: https://gerrit.libreoffice.org/36237
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit bb8b699f217dd0d0f25e4efb37ef5380074c61ca)

ofz: treat short properties as run end

Change-Id: I00a5bab63663e2dde43825707e84568fca6aa594
Reviewed-on: https://gerrit.libreoffice.org/36216
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit fedd27b758db58bfc0e283a03e3fbf7d7fb6090c)

tdf#105908: restore previously deleted range references upon undo.

Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137
Reviewed-on: https://gerrit.libreoffice.org/35607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
(cherry picked from commit 749405af4fc38e0c16dc7e860d23a13dfceb4e40)
Reviewed-on: https://gerrit.libreoffice.org/35672
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 97ce2a4eb0b2b479d48afe28299ad0ff1d3a264d)

tdf#106868: fix crash when modify external link

The EndDialog callback Hdl was disposing the Dialog, which is a little
troublesome since the stack wants to go back through the Dialog code
when the callback is done.
Rather just the more normal synchronous Execute() style of Dialog
execute, instead of the asynchronous StartExecuteModal.

Change-Id: I14933bd475da228c9648a6fa0564bda4a60d9d12
Reviewed-on: https://gerrit.libreoffice.org/36074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit cedbc4031f26ea13b188a4ecc5b90cc9646095fb)
Reviewed-on: https://gerrit.libreoffice.org/36179
(cherry picked from commit 16e2701d02e777673c957ff77bcc0a66e24f9d81)

tdf#104686: do not crash if Menu has been somehow disposed

The rare crashes in MenuFloatingWindow::ImplGetStartY() and
MenuFloatingWindow::ImplScroll(bool) likely happen because
of a disposed Menu.

Let's guard against invalid accesses.

Change-Id: Ie31240abbc48c06edd40d0a95f319725cdb3db16
Reviewed-on: https://gerrit.libreoffice.org/36026
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/36151
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 9fcb6cb86893b991ceb6395fbabba63c962f59db)

tdf#106237 sw: do some basic sanity checking on layout-cache

The bugdoc, with claimed generator AOO4.1.1 on Windows, contains
a bogus layout-cache:

debug:26706:1: nType P nIndex 29 2147483647
debug:26706:1: nType P nIndex 66 2147483647
debug:26706:1: nType P nIndex 105 2147483647
debug:26706:1: nType P nIndex 142 2147483647
debug:26706:1: nType P nIndex 178 2147483647
debug:26706:1: nType P nIndex 205 2147483647
debug:26706:1: nType P nIndex 229 2147483647
debug:26706:1: nType T nIndex 314 65535

Due to a loop-control this causes incorrect pagination if CalcLayout()
is called only once.

It should look like this:

debug:26765:1: nType T nIndex 382 65535
debug:26765:1: nType T nIndex 790 65535

In this case we can easily detect that the indexes and types in
the layout-cache are bogus by checking against the node types, so
do that in SwLayHelper::SwLayHelper().

(cherry picked from commit 8a5374f2fdbd1e15c107133f55930cbc431edbd5)

sw: [loplugin:sallogareas]
(cherry picked from commit 282b3e8c4d45aacae57e3542b872cdbfebcc7195)

loplugin:loopvartoosmall
(cherry picked from commit dbaab58c1442e7f62ef0732376fe5a49840e9fd6)

Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb
Reviewed-on: https://gerrit.libreoffice.org/36046
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 137ad218db262fb3531215adbc88b7093b4999c7)

Related: tdf#106515 show OpenSymbol if unavailable StarSymbol requested

Change-Id: I442df1c44839642bd1f91afedee577214032466b
(cherry picked from commit 011e1cdbf33e50626f1fefa8b7b4031fa368f3e8)
Reviewed-on: https://gerrit.libreoffice.org/35974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 7bb46f684ca939fbbbe67bdb1e427e37eec430a7)

Resolves: tdf#106080 fix explicitly setting automatic in search by format

this is still somewhat broken in that what you see is not what you get
if you don't explicitly set automatic, but clears the regression part
of things in that the old broken behavior is restored instead of the
new broken behavior

Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a
(cherry picked from commit d7f1a1689d70b2d66d0f727b6a898ef1a971da9d)
Reviewed-on: https://gerrit.libreoffice.org/35894
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit f75cf4c772279f680839e288b3f6104f9f98c13c)

ofz: check olst sprm for valid ANLD payload len

Change-Id: Ic1b6681a3f48ef0fe3f52eda9db8b7bc003ded55
(cherry picked from commit 98151bf95bda8d647310bdba6936dc6b388b05de)
Reviewed-on: https://gerrit.libreoffice.org/36098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 14028af4d978f126779e641a9605c6d4d864b3b6)

tdf#106938 TSA Dialog: Improve Dialog Layout

Moved Label above the content area

Change-Id: I0a23af5540bedc849c83fd342ac43538827e6b4a
Reviewed-on: https://gerrit.libreoffice.org/36071
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit 3873669fef3cac05a9b530de08f15e0d2a3fdc57)
Reviewed-on: https://gerrit.libreoffice.org/36105
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit c15eba1b1de9c41acd76f0b2a16cfbe38bf4fccb)

Resolves: tdf#106935 restore traditional toolbar labels

(cherry picked from commit f1a53e7a0b388e0a5303fe68dfbb4c60f4c7a0ff)

Change-Id: I00cf16e9ce429f9186cc900a07f4d386e33b8f7b
Reviewed-on: https://gerrit.libreoffice.org/36083
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 8e0220ce0d9e20577694b56011cfe34d1bc35fc5)

ofz: guard against bogus sprm len

Change-Id: I9b4074e1024753549f468f427afbfdf9cd01b674
(cherry picked from commit d30fb62f4f1022ae6294e246974d0018596cf8ec)

ofz: guard harder against bogus sprm len

Change-Id: Ic82526e1454b24f094d3deee89647e88760bc44b
(cherry picked from commit 924624b40a97d6925f66374259c2c21707805fcd)
Reviewed-on: https://gerrit.libreoffice.org/36078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit feecc82753c48b1c82df2315896b9996e33af2e2)

ofz: check anldPap sprm for valid ANLD payload len

Change-Id: Ie034e3b37e01c29cf19fe8ad78b1121f6eadecb2
Reviewed-on: https://gerrit.libreoffice.org/36053
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 29cf858a971273039fff50808082f231dbd43c92)
Reviewed-on: https://gerrit.libreoffice.org/36075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 5d5731a372e540fbb9344533b6dd7e06fc123687)

ofz: check bounds on read

Change-Id: I07779bec876b90e36f20a81d6dbf06ae727edf85
(cherry picked from commit fb05611064e12c8eda09bc32c42544cde8c2ab49)
Reviewed-on: https://gerrit.libreoffice.org/36018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit daa13c049f1d527e51a776f75748ddfba4e9666b)

ofz: check anlv text bounds

Change-Id: I6288aae2d439cde6a2b95c005a2090f73e21bb7a
(cherry picked from commit 3feabd87ad8066b45b55d61cd72684e47fd79082)
Reviewed-on: https://gerrit.libreoffice.org/36051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 09f5f4a39e4a9304d81565c33c009e8e0552778d)

sType and sSubType are already normalized to ASCII lower case

... upon successful return from INetContentType::parse

Change-Id: I8a0c50c1c655477138578e59031b64fb6b2b7218
Reviewed-on: https://gerrit.libreoffice.org/36129
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 97f048e633f07655eda000ae4f4da818c935091e)
Reviewed-on: https://gerrit.libreoffice.org/36146
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 6e336c43a239f515cc882a3da1bad63e3507b230)
Reviewed-on: https://gerrit.libreoffice.org/36236

tdf#106359: register .iqy in MSI and treat them as templates

Change-Id: I7ae94c7717fbea03d96c539e05eeb565bafefd9f
Reviewed-on: https://gerrit.libreoffice.org/36188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 0c547776340c3983a867890b34f4a931215f8f52)
Reviewed-on: https://gerrit.libreoffice.org/36203
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#106955: Detect XML by MediaType

According to Extensible Markup Language (XML) 1.0 (see
https://www.w3.org/TR/2008/REC-xml-20081126/#sec-prolog-dtd),
all parts of XML prolog (including XML declaration) are optional,
so XML stream without <?xml ... ?> is well-formed (though not
valid).

XMLFilterDetect uses only XML declaration to detect if the file is
to be processed further. However, this creates problems with said
documents.

This commit checks if the document has MediaType set to one of
known XML media types, in case when the check for XML declaration
failed.

Change-Id: I31627c0e3a39bee241f609650280ebac3f1cede8
Reviewed-on: https://gerrit.libreoffice.org/36101
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 156f778593ca9c57845076a88c6b544a63e12e7a)
Reviewed-on: https://gerrit.libreoffice.org/36133
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#106955: Open WebDAV resources on which PROPFIND fails

When PROPFIND fails on a WebDAV resource, its IsDocument property
stays undefined, and so stream creation fails. Proposed solution
is to default to IsDocument=true for all WebDAV documents where
we cannot get the property from server.

Such resources also fail to return their locking options, so
defaulting to server properties. When later locking is attempted
on it, the attempt fails with user notification (a dialog saying
that getting information from server failed). Proposed solution
is to check Content-Disposition header in such resources, and in
case it's attachment, disable lock on this resource. The rationale
for this is that "In a regular HTTP response, the Content-Disposition
response header is a header indicating if the content is expected
to be displayed ... as an attachment, that is downloaded and saved
locally" (see MDN:
https://developer.mozilla.org/en/docs/Web/HTTP/Headers/Content-Disposition

Also, Content::getProperties wasn't ready for PROPFIND returning
empty result.

Change-Id: I91dbffa8bdf0fe900c11d2f8c9c9394d2104bb49
Reviewed-on: https://gerrit.libreoffice.org/36090
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit fbc04c97231d629c1b5e9e57203dbe8d8eb06714)
Reviewed-on: https://gerrit.libreoffice.org/36132
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#106525: Implement an XSLT import filter for ADO rowset XML

There are online services and management systems (like SharePoint)
that allow to export datasets in ADO rowset XML format ([MS-PRSTFR],
https://msdn.microsoft.com/en-us/library/cc313112). Usually they are
intended to be open with MS Excel as a spreadsheet (with autofilter).

This allows to open this data in Calc.

Change-Id: I495cd790138bdd6bd24630c0f422a0c8b4e3d0fb
Reviewed-on: https://gerrit.libreoffice.org/35159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit d6323a2180cf51f9bd6a62d50503c2e0ef0964f1)
Reviewed-on: https://gerrit.libreoffice.org/36131
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

LOK - Calc - fix for MSVS 2013

Change-Id: Ieda51d7a4b91d9c107aa5550e27ba11c613ae5a9

Related: tdf#106972 vcl PDF export, PDF images: ignore PDF >= 1.5

When copying their page steam into ours, we need to make sure their
syntax is <= 1.4; so when checking if the image has PDF data, ignore the
case when it has, but it's >= 1.5 (at least in the default case when not
using reference XObjects).

Change-Id: I6bd77803b92fe16bdd327e5e7c3d2b42adeacca4
Reviewed-on: https://gerrit.libreoffice.org/36161
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 4443d7be61a9ae45630183d856a566cecd06ad95)

tdf#106972 vcl PDF export, PDF images: handle indirect font references

There were a number of problems here:

- the /Resources key of a page object may be an indirect object
- the /Font key of a resource object may be an indirect object
- the /Length key of an object may be an indirect object

So in all these cases handle not only a direct dictionary / number but
also when we have a reference-to-dictionary/number.

Change-Id: Ie74371f0ba43a133a1299843ef20cbfc75fe26d7
(cherry picked from commit 242a9b634213acf03cabc373928555dc81afc672)

lok: notify cell note removes before erasing storage

Change-Id: I6181b27b6a969d94789c42ea0914b17328c5c8d5
Reviewed-on: https://gerrit.libreoffice.org/36109
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

LOK - Calc: beyond row 65535 it is not possibile to resize a row

The row parameter type was a unsigned short.

Change-Id: I2da1a96d60988e8f1efeb49f55032fb84a8b562b

LOK - Calc: lift row limit to 500k

Due to previously intruduced optimizations, it is safe and fast enough
to navigate through a 500k rows document.

Change-Id: I8055672b58ea3c1e262f6e49d029eb0cf67086b5

LOK - Calc: row/column headers are updated faster

Now the computation of the row/column headers data exploits the cached
row/col positions in HeightHelper/WidthHelper.

That makes updating row/column headers at the bottom of the document
as fast as at the top even for very big spreadsheets.

Change-Id: Ida0ed8d8885b71fe3206efbdaa62a0bb95153ed7

LOK - Calc: make computation of cell cursor position faster

Now the computation of the cell cursor position exploits the cached
row/col positions in HeightHelper/WidthHelper.

That makes navigating through arrow keys independent from the current
cell cursor position: the cell cursor position is updated at the
bottom of the document as fast as at the top even for very big
spreadsheets.

Change-Id: Id369b63e547aedf30c233f75c70d18f32e015edf

LOK - Calc: invalidation of cached row/col positions on several cases

Cached row positions are invalidated when one of the following event
occurs:

- one or more rows are inserted
- one or more rows are deleted
- one or more hidden rows are made visible
- one or more visible rows are made hidden
- one row is resized
- optimal row height is changed
- the value of the PPTY parameter is updated

The same occurs for cached column positions.

Change-Id: Idf7b8cf1e694142e4fa0e1613d19ee9272b9a1be