Public Git Hosting - LibreOffice.git/log

bccu#1916 - svg-export - Removal of the SVG 1.1 path API in Chrome

On Chrome browser most of shape effects and slide transitions did not
work anymore: that was due to the fact that several animations exploit
the DOM api for handling path segments of the svg:path element.
Starting from version 48 such an api has been removed from Chrome:
https://bugs.chromium.org/p/chromium/issues/detail?id=539385 ;
Moreover Chrome does not yet provide an implementation for the new
svgpath api introduced in SVG 2.0 draft: so there is no native support
for handling path data directly.

The present patch adapts the JavaScript implementation of the old SVG
1.1 path api proposed here: https://github.com/progers/pathseg .

Change-Id: Ibcf3587b65f32cf4cd77d0f6e9c4a0837210fc76

bccu#1910 - better handling of not supported animation nodes.

Earlier, when a not supported animation node was hit all effects in
the same slide was ignored since the whole animation tree was
invalidated. This patch tries to minimize the impact of this issue by
removing only all children nodes of the direct parent container of the
not supported animation node.

Change-Id: I6ff55292f56939a9280c004b026260fe73626aeb

bccu#1900 - added support for discrete activities

Change-Id: I327c4f388fbe939e6c5c8b5e641179cefdc45519

bccu#1900 - additive and calc mode were not parsed correctly

Change-Id: I0721f0b7ce78e00c47837fb29998aec30244a257

bccu#1870 - added support for rotate attribute

Change-Id: Ic187b38afda7c737313c3c6c219ce439ba48e02d

tdf#95775: Allow zero shape width/height; fix setting width/height relation

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Reviewed on:
https://gerrit.libreoffice.org/19962

(cherry picked from commit ca80f73c3a330c38493e5e358bfa887adbe21db2)

Change-Id: Ic91ebf4a18a77704dc1ccd1e1180b42d0bc84c74

tdf#92157: allow both dimensions of a graphic to be 0

Commit ca80f73 made it possible for one of dimensions to be zero.
This commit goes further, allowing opening real-life documents
with graphics having both width and height equal to 0.
Thanks to libreoffice@arbruijn.dds.nl for debugging and initial
patch!

Reviewed-on: https://gerrit.libreoffice.org/21287
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
(cherry picked from commit 654f6ff28d7a148950b48ed8905d8f13a015a5b5)

Change-Id: I96a13b776adfd9fe46fc2c7691eb7904400c20a1

lok: Change version string to JSON format

(cherry-picked from d7b45c97b30f109aff0be6602a8fc8103af71e7f)

Leaving out the lokdocview changes intentionally, because we
don't need it, and too many merge conflicts.

Change-Id: Ie1264fed9964b09006980df2e151e170b48b4082

lok: Expose LO version information

(cherry-picked from 90c75f775b6d1ca68389782a3768ee554b528e5d)

Leaving out lokdocview changes as we don't need it, and it
results in too many merge conflicts anyways.

Change-Id: Ided924e928c04385457c7a2e231fdf57e7e38970

bccu#1307 - svg filter - added support for clip region meta action

Change-Id: Ie5177c7a0c3679db6f72c9a656c9474eac2cf047
Reviewed-on: https://gerrit.libreoffice.org/26506
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

svg filter - rewritten context handling

Change-Id: Ibb66ab6d339d48ad9eef90c2f6795793f0392d03
Reviewed-on: https://gerrit.libreoffice.org/26505
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

svgfilter - polish code formatting

Change-Id: I15179fd097661df7144ee9976f2da68ef60f1e97
Reviewed-on: https://gerrit.libreoffice.org/26504
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

lool - bccu#1307 - stop colors for background gradient was wrong

Change-Id: Ia92eecb9ad77b627bb6a5b01ef8a52d0c457a93a
Reviewed-on: https://gerrit.libreoffice.org/26503
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

lool - bccu#1307 - images must be scaled in a non-uniform way

Change-Id: Iaff479eb32998d679b1b0ef4515730a8d966f750
Reviewed-on: https://gerrit.libreoffice.org/26502
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>

Bump version to 5.0-39

Change-Id: Ieeace993521e091711df5dd79be955fedc783daa

bccu#1893 - [PERFORMANCE] .uno:ViewRowColumnHeaders too slow

For very large spreadsheets, the boost json generator
(property_tree) is extremely slow and memory-inefficient.

There is little need for generic json generator, however,
since there are exactly two nodes (rows and columns)
and each is an array of size/text pairs.

The new logic uses a string with reserved capacity
to accomodate the output and generates it in one
step.

The speed improvement is orders of magnitude (hours to seconds)
for very large spreadsheets.

Change-Id: Ifaf316c270ed6e4b923ec44189a315f69e7e9b0e
Reviewed-on: https://gerrit.libreoffice.org/26480
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: Fix cell editing with zoom

Change-Id: I243e8af47d35a2aae972b15d0b53ff9f41441668
Reviewed-on: https://gerrit.libreoffice.org/26478
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Use explicit type in std::max

Change-Id: I777d5387d9377f0f8032d68a9191a7fa110287c5
Reviewed-on: https://gerrit.libreoffice.org/26477
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Revert "sc lok: limit movement of the cursor"

This reverts commit 538d0c92ae2d5cb36869360a0889bc063a854f47.

No longer necessary with fast calc tile rendering.

Change-Id: I82b020666abe13aa7a5292ad3c3dd979b970e2b0
Reviewed-on: https://gerrit.libreoffice.org/26368
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: tile rendering regression fix

Calc fast rendering requires us to offset
the are being rendered and shift all
bitmaps accordingly. This however is
breaking Impress rendering since the
offseting logic is common (in svx and vcl).

This adds new API to enable or disable
this local rendering (as opposed to
rendering a full document as was previously
done.

The new flag is then set by Calc to
enable the offseting logic in isolation
without affecting other applications.

In one case isolation was achieved by
checking the MapModeUnit.

Change-Id: Ia0aadfc3f6df7c1a891b97dc731f5897414c9420
Reviewed-on: https://gerrit.libreoffice.org/26367
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: fast tile rendering (cell editing)

Cell editing uses editeng which has a different
set of requirements. The coordinates are in
100th mm and so we have to convert the ofsets
to 100mm.

Change-Id: I278457ffc2273eb786101875c85ddfb959d4c5e3
Reviewed-on: https://gerrit.libreoffice.org/26205
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: fast tile rendering (graphics and buttons)

Since embedded graphics and buttons use
absolute coordinates, we set the origin
to be the top-left corner of the tile.
This includes the origin + ScrPos (see
previous patch).

Then, the coordinates of the graphic is
shifted by this amount to make sure it
renders in its relative position to the tile.

This renders embedded graphics and buttons
at their correct position, with some limitations.

Tiles large enough to cover a graphic object
show the graphic object where it should be.
However, rendering a relatively small tile
doesn't render the graphic. This seems to be
an issue with moving the graphic's coordinate
at a later stage than the 2D Processor decides
what objects intersect with the 'view area'
that is rendered.

Another issue is that graphs don't render.
What they seem to suffer is incorrect scale
and a fix coordinates (they show up as tiny
thumbnails at the top-left corner and grow
in proportion to the real graph when resized).

These shall be addressed in a separate patch.

Change-Id: I4b71bf5f2e357d1114d46022bc00905ceed0c2f9
Reviewed-on: https://gerrit.libreoffice.org/26204
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: fast tile rendering (text only)

For every tile, the bounding columns and
rows are found. The origin of the device
is set to the top-left corner of the
top-most row and left-most column, respectively.

Because tiles don't have to align with a
column or row, the ScrX and ScrY (Screen Position)
coordinates are set to the offset a tile has
to its top-most row and left-most column.

Rendering of text is super fast as the
minimum area is rendered for a given tile.

However, it doesn't work for embedded objects.
This is addressed in a separate patch.

One pending issue with text is when editing.
The text doesn't correctly render while
editing a cell. This is almost certainly
because the edit control is not rendered
at the correct offset (in the middle top
row it can be seen showing up to the right
of where it should be).

Change-Id: I6f1ea0aa2f19a7fda926f596a2009290680c593c
Reviewed-on: https://gerrit.libreoffice.org/26203
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

sc lok: catch unhandled exception

Now, after 432b27ec73940738bb0b4f9d3d749c70a2525700, we do not
export newlines when empty range is selected. Trying to get
transfer data in such a case throws an exception.
(cherry-picked from commit
82ed95b7554cfa3b5e98f67cc53c6219e3a09886)

Change-Id: If2b16bfa2c1932b0599108b989e62e200c1b3b27

SwXDispatchProviderInterceptor: implement frame::XInterceptorInfo

With this, framework::InterceptionHelper can make a better decision what
interceptor to call: it can avoid calling SwXDispatchProviderInterceptor
when the sw code would just call the previous interceptor anyway.

Reviewed-on: https://gerrit.libreoffice.org/25961
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit b0d819ac5667a07f629f2acb5d3c542fa76d348b)

Conflicts:
sw/source/uibase/inc/unodispatch.hxx

Change-Id: I92897f2c8baa264dc9ccbc11b63f415da30a910d

sc: Don't export in case of invalid range

For example, copying an empty column or row range, and then
pasting as unformatted text exports all the newline characters
inspite of the fact that this is an invalid data range.

The problem becomes worse when someone tries to copy an entire
column which implies exporting MAXROW times newline characters.

Change-Id: Ie0a09890e2d0cd5f44d89d520959248e65365ad7
(cherry picked from commit 432b27ec73940738bb0b4f9d3d749c70a2525700)

Linux x86 build fix

Change-Id: I34a393745265b8daca832c7df896bea090bb2554

sc lok: limit movement of the cursor

Change-Id: Ic7fe2dec012efb8ba180feb4d3df6f4bfbf6c38a

sc lok: Add new param to .uno:EnterString to prevent committing

If new param, DontCommit, is specified start the edit engine and
edit the current cell. This helps in not triggering calculations
that depend on the current cell. In case DontCommit param is
missing, it will work as it used to.

Change-Id: I62408932e52ff68fa11568cfc16a43e4c1e919c5
Reviewed-on: https://gerrit.libreoffice.org/25753
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.com>
(cherry picked from commit c14627d66ca8d9fe14272fadb5305857101f513e)
Reviewed-on: https://gerrit.libreoffice.org/25788
Tested-by: pranavk <pranavk@collabora.com>

framework: last dispatchInterceptor gets asked first

Align implementation with API contract as spelled out in
offapi/com/sun/star/frame/XDispatchProviderInterception.idl -
no idea why this change happenend in 2003:

Date: Fri Apr 4 16:16:05 2003 +0000
INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED
2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception objects

At any rate, with this change extensions actually get a chance to
see dispatch requests first, and process/ignore at will.

Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3
Reviewed-on: https://gerrit.libreoffice.org/25215
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 08cf2fd01064306eef7fdbb5b62320947c4d1089)

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)

tdf#96949 Remove global static variable m_bPreferrFirstInterceptor and unused code

Remove global static variable "m_bPreferrFirstInterceptor" which is always true,
and remove the ifs where it is false.

Change-Id: I54dcea7a6010c825a66020ec3f7448bb32d120b8
Reviewed-on: https://gerrit.libreoffice.org/21519
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
(cherry picked from commit 5d4f1f6f630d4382679087a4fb0da364c9c9692b)

Bump version to 5.0-38

Change-Id: I888809cc1cfb72dc8d066f342e7771620e4c7de0

LOK: calc tile rendering

Change-Id: I122922ac18a652dbbce01932eaaad92ded45098d
Reviewed-on: https://gerrit.libreoffice.org/25782
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Bump version to 5.0-37

Change-Id: I998ddc1759bef24e2fc80b975cc22f832a6b6d49

bccu#1845 - Calc tile rendering very slow

For some reason trying to draw exactly the
region of the tile results in black tiles.
That is, when the top rows and left columns
are not drawn, black tiles show.

This patch still reduces the time to render
a given tile by limiting the bottom-most row
and right-most column to the max necessary.
For large tabs rendering the first few 100
rows is very fast (<100ms at most).

More work is necessary to reduce drawing time
for large sheets (when rendering tiles at the
bottom). Still, even those slow bottom-rows
are now faster with this patch.

Currently the slowest function by far is
ScGridWindow::DrawContent.

Change-Id: I6e88c7b3a1c483bf43bfcfb38f4b41ffc08a9744
Reviewed-on: https://gerrit.libreoffice.org/25586
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

lok: add uno command AssignLayout

Change-Id: I959d1a57945a3b5aa3f2c273c4b885ed5f628f6e

bccu#1851 - CTRL+A in Writer comments shows selection at top-left corner

Change-Id: Ia87b86a45a38449d59eb7bcea7f8cb4068655a17
Reviewed-on: https://gerrit.libreoffice.org/25571
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

bccu#1843 - Calc copy/paste chart tile invalidation problem

Change-Id: I2f0bf28e87f4188abd81eb6c42bae915b2a046a8
Reviewed-on: https://gerrit.libreoffice.org/25489
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

widen table-info capacity and count to SCSIZE

Change-Id: Id659978e71c7027bc1c58f0bc276da38e1ada4ba
Reviewed-on: https://gerrit.libreoffice.org/25488
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

lok: reset the font list when there are no items

In the pre-init stage the devices were initialized with no
font list, but later the font list is updated. So those devices
were not updated.

Change-Id: I157d4c7079f9b1252916eb92b512aadb8e77329f

sd bccu#1840: .uno: commands for inserting rows / columns in Impress.

Change-Id: Ic07722c3e1f75d909ec8f123919a1898dfde05b0

gtk_widget_get_window requires at least GTK 2.14

Change-Id: Ie795683b5b800d6b00ba54dcb3f5c5a71b39212f

lok don't supress start/end when there is selection

Change-Id: I347d90cfa5432e18b9a0091ab575c0833538d941
Reviewed-on: https://gerrit.libreoffice.org/25422
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

bccu#1811 - Writer comment focusing / selection / cursor issue

Partially based on fd205e40c58aa749fbe458d74ca0c2373a1017dc
which caused make desktop.check to fail when viewsh.?xx
changes were included, so left them out.

Change-Id: I5b4576d2385c1812f358a2434b87c8ca62024430
Reviewed-on: https://gerrit.libreoffice.org/25421
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Bump version to 5.0-36

Change-Id: Ib315d167486a5b3290ae014cd7d0de3d29bff72a

lok context menu: Remove disabled items (set enabled to false)

Change-Id: I18a95cc53f9e79eab257baa4d7b23853cb05e039

lok context menu: Expose context menu

(cherry-picked from 610db8d5d0500aed2ca6d4da822cf70746b44d49)

Earlier cherry-pick (6be044e919d28b93332f04bdc18f6def2925b098)
left out some code important to the working of lokdocview.

Change-Id: I6422c28e880f9e04f4fad88e5202e46c4de2650d

LOK: added the button type and key modifier to postMouseEvent()

To get a better functionality we need to know the button type (left,
right, middle). We also need the key modifier (ctrl, alt, shift) for
actions such as ctrl+click (to open a link) or shift+click to select

(cherry picked from commit c90c08a65c480a1012182979d5e9218f17a2ba2e)

Button type was not cherry-picked earlier in
527a83d77c139427028ad08bef3a6349135716f7

Change-Id: If05326b1d7c82f14808bd2c15f552508b97bc7c1

lokdocview: support LOK_CALLBACK_MOUSE_POINTER

Change-Id: I2052e39fa2e25988a40f293389d5a183a625acd4
Reviewed-on: https://gerrit.libreoffice.org/19903
Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>
Tested-by: Andrzej Hunt <andrzej@ahunt.org>

lok: Subcribe to more uno commands for state change

Change-Id: Id2870b176de4163fbe01e4ac380b4981d3187d90

sc lok bccu#1610 - Tiles not rendering in large spreadsheets

Variable max info rows instead of hard-coded allows
for collecting info on more rows.

FillInfo, however, is extremely slow for large
row count (a few thousand) and needs improving.

Change-Id: Ib0e475513bc3ba98fff66a5b9d405aeba1057331
Reviewed-on: https://gerrit.libreoffice.org/25293
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

coverity#738785 reorg to silence Uninitialized pointer field

(cherry picked from commit 3ac0778c0a2b2f693a1029b7b05c1be4f71944a9)

Change-Id: If2225e77215e2a6fb6b9e9dfc6021a2c20babe50
Reviewed-on: https://gerrit.libreoffice.org/25292
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

add TODO comment for a bug

This bug is the first one that was discovered because it is now much
easier to see which parts of the code work on cells, pattern areas and
whole columns/rows.

Change-Id: I8f22bf421298947d65bfc2fc9c986d85169e6545
Reviewed-on: https://gerrit.libreoffice.org/23636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 2c69316037e29db52393d898100e6593a6cd5a24)
Reviewed-on: https://gerrit.libreoffice.org/25291
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

extract another function from ScDocument::FillInfo

Change-Id: Ief094beebbff2bce9f087853cbda6adeeafe07fc
Reviewed-on: https://gerrit.libreoffice.org/23635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit b22e51d0c60f959c2db77bd3d23119b53bd87545)
Reviewed-on: https://gerrit.libreoffice.org/25290
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

stylistic changes in ScDocument::FillInfo

Change-Id: I98bb25d414106259a809698941a000d6d0bc35e0
Reviewed-on: https://gerrit.libreoffice.org/23634
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit b27428d2136e67ee7c7449a7db562a957af390d6)
Reviewed-on: https://gerrit.libreoffice.org/25289
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

limit scope of another variable in ScDocument::FillInfo

Change-Id: Ic53bcaa5e33f221a643de4e854990769b5c04a74
Reviewed-on: https://gerrit.libreoffice.org/23633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 8f0668a0e18f4fa01864ede5fa3f66b36bd4ad85)
Reviewed-on: https://gerrit.libreoffice.org/25288
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

limit the scope of a few variable in ScDocument::FillInfo

This makes the code at least a little bit easier to read as we can now
see much easier when a variable is used to transport state between loops
and when it is just a variable local to a loop

Change-Id: Ib92ff1596bda35f9892accc820bc3596bafb7d96
Reviewed-on: https://gerrit.libreoffice.org/23632
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 36eec4d179898302578c428564f1b60406c0716c)
Reviewed-on: https://gerrit.libreoffice.org/25287
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

extract another function from ScDocument::FillInfo

Change-Id: Iac607e1fe915c8bc90316508c98855a60117d435
Reviewed-on: https://gerrit.libreoffice.org/23631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 772e66406b90bdb898e73b4fa944a6e55a42683b)
Reviewed-on: https://gerrit.libreoffice.org/25286
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

extract another function from ScDocument::FillInfo

Change-Id: If6f898d514dc454a7f1c5448769a95269e9066d7
Reviewed-on: https://gerrit.libreoffice.org/23550
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 5ecda97eeab36ceab022458345f2c61c31ab2d94)
Reviewed-on: https://gerrit.libreoffice.org/25285
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

that should not have become part of the previous commit

Change-Id: Ia116e5f9fdbd34cd1017ec1f2dabf6e581c4c707
(cherry picked from commit 789a3e61785a2458429890e28ad9a37fab8cdade)
Reviewed-on: https://gerrit.libreoffice.org/25284
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

extract another function from ScDocument::FillInfo

(cherry picked from commit a70824f0220b88f3f209266f8e1cba98dc89ca8f)

Change-Id: Ifd39ec5ad7aebac532ea7145274005507a5b177f
Reviewed-on: https://gerrit.libreoffice.org/25283
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Refactor ScMarkData for tdf#50916

Made the container for storing multimarks dynamic.
Also let the full row marks to be stored in a dedicated
ScMarkArray object rather than in the multimarks container.

Unit tests for ScMarkData and ScMultiSel will come in a follow up
patch.

Reviewed-on: https://gerrit.libreoffice.org/22163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit bc20c6d0f397c0c1aef6ef7d6f750c2f81af8db6)

Change-Id: I300ff80bebd6f4f39c284c1e8cb7deece82c1bec
Reviewed-on: https://gerrit.libreoffice.org/25282
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

o3tl: add make_unique template till we can't use std::make_unique

Change-Id: I48b26f0199e339badf7a0e2bed322ca701689d13
Reviewed-on: https://gerrit.libreoffice.org/15846
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 821b72886f1e407a492f881a2efb27ead2c22b5c)
Reviewed-on: https://gerrit.libreoffice.org/25281
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

extract function from ScDocument::FillInfo

A first step in breaking the function into smaller pieces.

Change-Id: I94aeb11fd9c44a7eaa198cb39f208b574ef2758d
Reviewed-on: https://gerrit.libreoffice.org/23548
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit efea43b4c4f42023a540079866b065068ae8a8e5)
Reviewed-on: https://gerrit.libreoffice.org/25280
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

bccu#1800 fix bogus loops in slide animations and transitions

Change-Id: Ia0ba0921c3ebfbfbd66fddf81e43fec480f6d5bb

bccu#1781: Impress/Comments - selection not updated on delete

Change-Id: I694d76785fcf6ec9c158c34cbe07f4d1f2c7a41d
Reviewed-on: https://gerrit.libreoffice.org/25219
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: don't filter cursor visibility during painting

Change-Id: Ia44ffe08dc8f46e0d10a73db374a283eb032f771
Reviewed-on: https://gerrit.libreoffice.org/25120
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Revert "LOK: invalidate cursor only when required"

This reverts commit b229297372f793239f2304592f32065147169cde.

Change-Id: Iedc432c81829ba366966f96dfcd6ac2f405b9ba7
Reviewed-on: https://gerrit.libreoffice.org/25119
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

lok context menu: Include uno commands for submenus too

Change-Id: I4ba49ba94a3270a5d53754320e5fbd49e3f5c848

Revert "lok context menu: Include uno commands for submenus too"

By mistake resolved conflicts incorrectly. Correct version
comming up.

This reverts commit d57994a20b012c67db47d488409ee14fb11b9751.

lok context menu: Include uno commands for submenus too

Change-Id: I4ba49ba94a3270a5d53754320e5fbd49e3f5c848

LOK: invalidate cursor only when required

Change-Id: I3481dce94070f28593a970cb2d8530131165c41b
Reviewed-on: https://gerrit.libreoffice.org/25016
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: ensure KeyInput is handled with the correct MapMode

The MapMode is set explicitly to make sure the coordinates
of the comment widget is in absolute terms. However
PostItMgr::MakeVisible invalidates it. This is to
ensure that the MapMode is restored after MakeVisible
is called when LOK is active.

Change-Id: I2adf749488e6eb46d29a0b29c4dfd644606c92ab
Reviewed-on: https://gerrit.libreoffice.org/25015
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: invalidate annotation window upon showing

Change-Id: Ib2624c55759c8ac81986bf3b516fd17cbde19ec9
Reviewed-on: https://gerrit.libreoffice.org/25014
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: improved event handling and fixes

During painting, when notifications are disabled, we could still
receive notifications that are imporatant and cannot be suppressed.
So certain events are let through during painting.
A comment describes this better in the code.

Some widgets (notably postit/comment control) emits events in
relative (local) coordinates instead of absolute. This is patched
in many cases but some cases still exist that are rather hard
to patch due to the complex interaction with other parts of the code.
These supurious local coordinate updates (notably cursor invalidation)
are supressed to avoid the bad side-effects they cause in LOOL.

Change-Id: Ie22a316d54ea163c6976ed04314d6ced8247824c
Reviewed-on: https://gerrit.libreoffice.org/25013
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Revert "LOK: simplify notification compression to minimize error"

Restoring back Some of the notification compression.

This reverts commit 4bdff9b94b545aa966c44b54c21c23dd724382c0.

Change-Id: I229911c63386b3668e8bd9541b48c80479cc2771
Reviewed-on: https://gerrit.libreoffice.org/25012
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

framework: register DispatchDisabler service

Change-Id: I72d9f8b00ba8b2e4e5dc70d7fd77e13ccf9d3bcc
Reviewed-on: https://gerrit.libreoffice.org/24940
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 1f041bf31e071611a15ffa1559d2f5df05a685f0)

framework: initial implementation of a dispatch disabler.

This should allow remote, eg. URE dispatchers to trivially disable
lots of the UI without requiring a large volume of round-trip IPC.

Reviewed-on: https://gerrit.libreoffice.org/24938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 02833c03ee856a62d7185829b7c47bc088e086cc)

Conflicts:
framework/inc/services.h

Change-Id: Ibd0681ac993196f826b4ed411da5ffedb7f85786

sc lok: Invalidate the new extended area

Change-Id: I1fa58ca935860ed3c5983f4e6b15c9f7c8feda9b
Reviewed-on: https://gerrit.libreoffice.org/24930
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

sc: Add new param, DontTerminateEdit, to .uno:Save

... which determines if current editing mode before save should
be terminated with save or not.

Change-Id: I49318013f1244eb8681a19ed3da50fbecd336a3d
(cherry picked from commit a5a71cea62ac3041006c5e9815ae2317999639ac)
Reviewed-on: https://gerrit.libreoffice.org/24895
Reviewed-by: pranavk <pranavk@collabora.com>
Tested-by: pranavk <pranavk@collabora.com>

Bump version to 5.0-35

Change-Id: I0d56da9b5c6695b79796e5e6764edbead7490d29

sc lok: Extend the spreadsheet area when we are "close enough" to the end.

We can tweak later what the "close enough" means - for the moment it is 10
columns and 25 rows.

Change-Id: I92127a71aa6683c03692e96b9e0da7827942c94b

sc lok: Move the handling of the area back to GetTiledRenderingArea().

Change-Id: I4dbfc090ab43065c719f83b5355cd9832ee4d1e3

sc lok: set a limit for tiled column and row

In the tiled rendering case, not all column and row are rendered,
so it was set a limit for tiled column and row.
However, when a client request to move the cursor beyond the limit,
the tiled column and row is updated and they are rendered later.

Change-Id: Id0de533ebf7b3c6e0343f9dc15336150729299fa

tdf#84323: Make osl::Condition::wait more readable

[Stripped down version of the commit from master.]

Change-Id: Icd66ae1d390100549f903d45b2896cdcdca449be

LOK: fire SET_PART event when Calc page is changed

Change-Id: I9a2ed653bcb6afe803b781fc686c02f817d84e75
Reviewed-on: https://gerrit.libreoffice.org/24818
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: fire SET_PART event when Impress page is changed

Change-Id: Iebddffbdc66397b1f2937ed7320f7800c8bab4cc
Reviewed-on: https://gerrit.libreoffice.org/24817
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: simplify notification compression to minimize error

Change-Id: I4de2d652e08586b38294ebf903fedc9935711a13
Reviewed-on: https://gerrit.libreoffice.org/24816
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: drop identical invalidation notifications

And drop duplicate GRAPHIC_SELECTION notifications.

Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359
Reviewed-on: https://gerrit.libreoffice.org/24771
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

-Werror=missing-field-initializers.

Add missing initializer for member
‘comphelper::PropertyInfo::mnMemberId’.

Change-Id: Id8c1adb24c68432ddbf6b491c419f359d228286a

lok context menu: unit test

Reviewed-on: https://gerrit.libreoffice.org/23985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.com>
(cherry picked from commit d76b1b5b06c064938986c0b921b8d537fdf8bf4c)

Change-Id: I244fbf4b98368c7c0d66cdd865e1243639727026
Reviewed-on: https://gerrit.libreoffice.org/24732
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: process idle events when testing event processing

Change-Id: Id340f69ab6b9d539d92163acc7a1468b98e02779
Reviewed-on: https://gerrit.libreoffice.org/24731
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

LOK: SAL_WARN for each removed event is unnecessary

Change-Id: If5e4c7b8751ae4eeb278475fb00118e32c6bb565
Reviewed-on: https://gerrit.libreoffice.org/24730
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

flushTimers() -> Scheduler::ProcessEventsToIdle()

Change-Id: If8f67e61338d78852bc153805ad874095457a365
Reviewed-on: https://gerrit.libreoffice.org/24729
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

CppunitTest_desktop_lib: avoid #include "../..." style include

Change-Id: Ib5ce0dee00c9306f89ad4b43af4b34e604147a1c
(cherry picked from commit 04216006ee038232067bcf74d67b14e8918063f2)
Reviewed-on: https://gerrit.libreoffice.org/24728
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

sw: add AnchorType parameter to .uno:Paste

Which allows not hardcoding as-char for LOK.

(cherry picked from commit 552361aaad740e55fcfa7993b4111aba354f863f)

Change-Id: I3b2987abbaf1f259c614b7b2a8709f15048d362d
Reviewed-on: https://gerrit.libreoffice.org/24727
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>