LibreOffice.git
3 years agoBump version to 5.3-60cd-5.3-60
Andras Timar [Thu, 8 Nov 2018 21:21:48 +0000 (8 22:21 +0100)]
Bump version to 5.3-60

(cherry picked from commit 25ec65bf4b77a5cdb2544527f3d1a262fcb78fe6)

Change-Id: I7f5a4a30802c9348e8fef0d7a11b7efec47e1d88

3 years agoLOK: don't emit redline comments
Ashod Nakashian [Thu, 8 Nov 2018 16:02:26 +0000 (8 11:02 -0500)]
LOK: don't emit redline comments

Change tracking can be quite numerous. Showing the
markers (and their comments" as comment-boxes is
sensible where there is limited change in a doc.

However with extensively modified doc, this becomes
overwhelming both in terms of browser load and
editing performance. As such, we disable them
as they don't add much value. The user can still
access them from the Track Changes > Manage menu.

Use a rather nasty env. var hack to propagate this
setting from WSD for now.

Change-Id: I3f964816b4a10f565012b273added8a8413cd309
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit d4f821b7a385953542e90b2749690b9f8f4cc782)

3 years agoLOK: update main thread
Andras Timar [Mon, 5 Nov 2018 17:17:05 +0000 (5 18:17 +0100)]
LOK: update main thread

Change-Id: I75df6ae9f9fb41b08a8774ce026f79fdd120b629
Reviewed-on: https://gerrit.libreoffice.org/62921
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 6f076e75b2adb4628ee3cea311781c40f219bba7)

3 years agotdf#116342 Allow selecting text boxes anywhere by default
Samuel Mehrbrodt [Wed, 14 Mar 2018 13:25:44 +0000 (14 14:25 +0100)]
tdf#116342 Allow selecting text boxes anywhere by default

Not only by hitting the (invisble) frame or the text content.

Change-Id: I125f76a102611b628411d8c5acf70e3ed9e5e8fe
Reviewed-on: https://gerrit.libreoffice.org/51276
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit d799436414ab7e28b6bf9a918fd3779b3fc85008)
(cherry picked from commit ead83a1a3a346ae8a8206274954edabc6ce1116e)

3 years agokeep pyuno script processing below base uri
Caolán McNamara [Thu, 18 Oct 2018 19:39:23 +0000 (18 20:39 +0100)]
keep pyuno script processing below base uri

Change-Id: Icc13fb7193fb1e7c50e0df286161a10b4ed636c7
Reviewed-on: https://gerrit.libreoffice.org/61969
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit b1c85cdb37a47998f8ab135fbc96f186334b171c)
(cherry picked from commit a9d81dd30d809b9c5ce2d3e4752039f19be70494)
(cherry picked from commit 4c0d9942ebd56e83e83ac3079528e62ce5644008)

3 years agoouter loop unrelated to inner loop
Caolán McNamara [Wed, 15 Aug 2018 13:13:02 +0000 (15 14:13 +0100)]
outer loop unrelated to inner loop

since original checkin of...

commit 9cddf9da7fb256418e1bc3b4719abb55e3b0604c
Date:   Tue May 22 15:33:44 2007 +0000

    INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
...
    2006/12/13 12:31:03 tl 1.1.2.38: #i71244# update charts in writer

where I think this LockUnlockAllCharts chart2 loop was modelled on
the previous chart[1] styles loop of e.g. DoUpdateAllCharts which
loop over tables.

chart2 objects are unrelated to these tables, so remove the outer
loop, which then means the ofz#9689 ofz#9856 ofz9874 crashes that
made me look at it will get fixed

Change-Id: I7d7ba0a2aa257b5aa399f20d902f01306fbaecff
Reviewed-on: https://gerrit.libreoffice.org/59112
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit eadf6f4551416430b58efc42a5756556df0a237d)
(cherry picked from commit 74de907344923a9f9575927fca8d43260f86f4c9)
(cherry picked from commit c7b0292184c0942ca00633b88e76367092f3ea91)
(cherry picked from commit d20db10442dcc6c0c93d11219c1e60ba6d91245f)

3 years agoResolves: tdf#119954 do not copy the old parent, init with new parent instead
Eike Rathke [Thu, 20 Sep 2018 16:12:03 +0000 (20 18:12 +0200)]
Resolves: tdf#119954 do not copy the old parent, init with new parent instead

The parent is always the ScDBCollection that contains the
ScDBCollection::NamedDBs container, not the one the
ScDBCollection::NamedDBs was copy-constructed from.

Change-Id: Ia409347f3aeb9ad7a5e68da7af727adfac98d6a2
Reviewed-on: https://gerrit.libreoffice.org/60833
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit 7ea5d339dc4d8412f436f3affa589bfbd0b1ef68)
(cherry picked from commit 3298d3c68fa17b350ef7bec8271fcfc673b5e1a7)
(cherry picked from commit 15ce830eb8994bf1c01389b53c05aed7ed9daba4)

3 years agoofz#10523 guard aginst 0 pF->nLCode
Caolán McNamara [Thu, 20 Sep 2018 15:03:24 +0000 (20 16:03 +0100)]
ofz#10523 guard aginst 0 pF->nLCode

Change-Id: I8ef476e06f54ddd57be907488a8a65314abda3ee
(cherry picked from commit 108eca19c9043895f26c889c90b3f4081113a3fb)
(cherry picked from commit 40d91027e70518dff8404aaf10fd9830995d9409)

3 years agotdf#41425 XLS/XLSX export: workaround for style and validation loss
László Németh [Fri, 3 Aug 2018 14:11:16 +0000 (3 16:11 +0200)]
tdf#41425 XLS/XLSX export: workaround for style and validation loss

of cells of blank rows.

This workaround is probably a fix for problems of most users, but for
a full solution it needs to extend the workaround for all rows with not
default settings, also avoiding of the possible performance problems.

Note: the number 1000 of the extra rows came from a similar workaround used in
XLSX export of Google Spreadsheets, but instead of listing extra empty 1000
rows in OOXML, this fix writes only the cells with not default settings from
the extra 1000 blank rows.

Reviewed-on: https://gerrit.libreoffice.org/58575
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit 99b9ea63bfc9a5fe63a0cd7b30b66ce2c1bde08e)
Reviewed-on: https://gerrit.libreoffice.org/58812
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit d7cbaac61b8f3575184c675a760907c3b4bb225e)

Change-Id: Icac9441b7eb1520dcd20fc04337e070d070591c7

3 years agoBump version to 5.3-56
Andras Timar [Wed, 12 Sep 2018 14:01:23 +0000 (12 16:01 +0200)]
Bump version to 5.3-56

Change-Id: I64cdb0464bc42f28b91775ebe1bbe841c0b36164
(cherry picked from commit 83244cd67b23c68ab908221ff649ca7cd7ab2399)

3 years agolok: Avoid crash when inserting a table in a redline.
Jan Holesovsky [Wed, 12 Sep 2018 12:59:20 +0000 (12 14:59 +0200)]
lok: Avoid crash when inserting a table in a redline.

Steps to reproduce:

* turn on changetracking
* write few characters
* insert table
* move the cursor behind the table and type
* crash

Change-Id: Icd7b64d2fe594c2b87c9d3d7fa48a957755cbc3b
Reviewed-on: https://gerrit.libreoffice.org/60390
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 43197a3097d2939c30fd9f242ae52b03bf29f240)

3 years agoBump version to 5.3-55
Andras Timar [Thu, 6 Sep 2018 07:32:03 +0000 (6 09:32 +0200)]
Bump version to 5.3-55

Change-Id: Ib02683df7abc3df9bcb19f68d4cd9fcaf3e55031
(cherry picked from commit f30b8c7eaf18faf954b6473379296ae2aa081f4e)

3 years agoofz#10189 check container size
Caolán McNamara [Sun, 2 Sep 2018 20:20:40 +0000 (2 21:20 +0100)]
ofz#10189 check container size

Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161
Reviewed-on: https://gerrit.libreoffice.org/59913
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 6ee76d210846b84e93420a321c7908721ffe9e43)
(cherry picked from commit 59e68800029dd91aced2daf1bae41d6ee3e4b6b8)

3 years agotdf#119143: introduce tentative directional embedding import support
Mike Kaganski [Mon, 27 Aug 2018 09:34:12 +0000 (27 12:34 +0300)]
tdf#119143: introduce tentative directional embedding import support

ECMA-376-1:2016 states that w:dir is functionally equivalent to LRE/RLE+PDF
pair around the enclosed runs. So this patch does just that.

Change-Id: Ibf9775338cc38a3bbc38a42a33fc64ae787b478f
Reviewed-on: https://gerrit.libreoffice.org/59643
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/59672
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 348a1e11045ca8d9dbceab43a68d44dbde3f922c)

3 years agolokdialog: no invalidation when in init show
Pranav Kant [Tue, 17 Jul 2018 13:40:48 +0000 (17 19:10 +0530)]
lokdialog: no invalidation when in init show

This improves LOK dialog opening time considerably.

libreofficekit/tilebench results:

Before:
profile run:
  initialization - 346.5185(ms)
  load document - 2162.5881(ms)
  open dialog - 7077.8980(ms)
  wait for dialog - 52.7742(ms)
  render dialog - 256.9597(ms)
  post close dialog - 523.7811(ms)
  destroy document - 58.3723(ms)
Total: 10.4789(s)

After:
profile run:
  initialization - 336.5867(ms)
  load document - 2155.5481(ms)
  open dialog - 1151.4130(ms)
  wait for dialog - 51.5332(ms)
  render dialog - 260.3197(ms)
  post close dialog - 519.8729(ms)
  destroy document - 56.7322(ms)
Total: 4.5320(s)

Change-Id: I6345aca33c5881aba33c8a5f74765b99fe098711
Reviewed-on: https://gerrit.libreoffice.org/57561
Tested-by: Jenkins
Reviewed-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 8de98e61fbc96bf523b3dec7e1e52eb7e2d7693e)
Reviewed-on: https://gerrit.libreoffice.org/57562
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit a861adc9b0f4a527d1fe8c415dab33ce9d396de0)

3 years ago-Werror=int-in-bool-context (GCC 7)
Stephan Bergmann [Fri, 27 Jan 2017 15:23:52 +0000 (27 16:23 +0100)]
-Werror=int-in-bool-context (GCC 7)

Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647
(cherry picked from commit 53eb2fae381f4ed9d73bcc6d8e76a6f09777ba60)
(cherry picked from commit 700a6a6939605eb9d0bf5f762bf8c4420e8d85bb)

3 years agoBump version to 5.3-54cd-5.3-54
Andras Timar [Mon, 20 Aug 2018 10:02:13 +0000 (20 12:02 +0200)]
Bump version to 5.3-54

Change-Id: Ic2ed70b84b8d0f67445ef14d9a33f5f5679427b0

3 years agoforcepoint#50 fix end detection
Caolán McNamara [Tue, 19 Jun 2018 20:43:43 +0000 (19 21:43 +0100)]
forcepoint#50 fix end detection

rBuffer.size() of 26, nBytes of 25, rBuffer[25] is the first zero
so aLine.getLength() of 25, nBytes reduced by aLine.getLength()+1 and
nRun increased by same, so nBytes wraps and nRun is 26.

contains...

forcepoint: rework to explore loop

Change-Id: I14f6a3269fc3347a9976d899519e74f58d5975c8
Reviewed-on: https://gerrit.libreoffice.org/56125
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 6e5e83025c948b699bb65839ef810a45a98ba014)

Change-Id: Ia9f4789e081e6b77a21321f37d71cabfc7c84550
Reviewed-on: https://gerrit.libreoffice.org/56481
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 0cefb4f0552a9d1ec3afd64e695596480a1c9757)
(cherry picked from commit c102d535021abd31d6dfaca4f58b2312b7ef4d08)

3 years agotdf#101534 sw: fix lost indent attributes when copying into numbered paragraph
Miklos Vajna [Thu, 19 Jul 2018 13:32:59 +0000 (19 15:32 +0200)]
tdf#101534 sw: fix lost indent attributes when copying into numbered paragraph

Commit aa91dc0ccbe53ffcec9dbfec2265de057775d4e3 (CWS-TOOLING: integrate
CWS sw32numbf01, 2009-09-08) replaced the SwDoc::ReplaceNumRule() call
with SwDoc::SetNumRule(), as the later handles list ids. This required a
decision if resetting of the indent attributes is needed or not, but it
did not document why resetting was chosen.

On the other hand, the current bugdoc shows why resetting is a bad idea:
this way if you paste into a numbered paragraph which has a non-zero
paragraph indent inherited from the numbering + zero indent as direct
formatting, then this later is lost during paste.

Conflicts:
sw/qa/extras/uiwriter/uiwriter2.cxx

(cherry picked from commit 340eaa6aa15c18cc2696a4a304350810cb36565c)

Change-Id: Ie5dcf6ed86c240fd61c4d5bfed886910aea3648f
Reviewed-on: https://gerrit.libreoffice.org/57770
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 499c31d83f3ad6356678ae9103e7e0748ff45ad7)

3 years agotdf#118540: LO6.1b2: DOCX crashes when properties...
Henry Castro [Thu, 5 Jul 2018 19:28:06 +0000 (5 15:28 -0400)]
tdf#118540: LO6.1b2: DOCX crashes when properties...

are opened in print preview mode

Change-Id: Idc64d2b98dff157d28813dd3f90a276f8cacd11f
Reviewed-on: https://gerrit.libreoffice.org/57024
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/57059
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 8dd5be05ae7ed825af4fc99604f9772f0f60003c)

3 years agoConditional formatting: Allow to set the icon set CF via .uno: command.
Jan Holesovsky [Mon, 25 Jun 2018 20:58:30 +0000 (25 22:58 +0200)]
Conditional formatting: Allow to set the icon set CF via .uno: command.

When .uno:IconSetFormatDialog gets a parameter, it directly creates the
icon set conditional formatting with pre-selected values.

Change-Id: I75dda90e5ea9c191254acc24c564cda7b27243a5
Reviewed-on: https://gerrit.libreoffice.org/56429
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 5e3365e88c94450e6db687eb46425e07db6997f5)

3 years agochecksum of Noto-hinted.zip changed
Andras Timar [Tue, 19 Jun 2018 13:27:31 +0000 (19 15:27 +0200)]
checksum of Noto-hinted.zip changed

Change-Id: Ib7ebf33a69ebabbb28dd26ab1a702fc8c7c8ed66
(cherry picked from commit d99f351377a335ffbc5deddfca2860815e3bcfad)

3 years agolok: Unit test for passing table borders via jsonToPropertyValuesVector.
Jan Holesovsky [Mon, 18 Jun 2018 23:18:08 +0000 (19 01:18 +0200)]
lok: Unit test for passing table borders via jsonToPropertyValuesVector.

Change-Id: Iadc0d76a1903d76fcd84f316d4796cc1dec13277
(cherry picked from commit 749780c9b5e2922417a7686efc3e4f609bb20264)

3 years agolok: Unit test for jsonToPropertyValuesVector.
Jan Holesovsky [Mon, 18 Jun 2018 22:00:05 +0000 (19 00:00 +0200)]
lok: Unit test for jsonToPropertyValuesVector.

Change-Id: I3e0623cc68838c650edbd03cc89bf3fcb8098ff8
(cherry picked from commit f4e8bbe596cb337c36c3e80b53cac3f4beb85685)

3 years agolokit: add jsonToUnoAny
Henry Castro [Mon, 18 Jun 2018 12:28:40 +0000 (18 08:28 -0400)]
lokit: add jsonToUnoAny

Change-Id: I79c2fe22fe7f3a8daa121ecaa529b6bca3216bf3
(cherry picked from commit 1664de4d0b02bd99a14048244cdb8c1d7db3007a)

3 years agosc:test: fix access configuration ui dialogs
Henry Castro [Wed, 23 May 2018 20:47:49 +0000 (23 16:47 -0400)]
sc:test: fix access configuration ui dialogs

Change-Id: If5c5ec12fab7bca0c874efbec64661f4d0e1496d
Reviewed-on: https://gerrit.libreoffice.org/54735
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 54ba02f3ac2a0868106348ba83b66a69862d3674)

3 years agolok: sc: tunneled spell-check context menu appear in bottom right corner
Marco Cecchetti [Wed, 16 May 2018 19:43:59 +0000 (16 21:43 +0200)]
lok: sc: tunneled spell-check context menu appear in bottom right corner

In the end it seems that in this context LogicToLogic is used for
converting non-pixel units, too.

Change-Id: I268e5522e929dd55af1284c38780064315d8cd41
Reviewed-on: https://gerrit.libreoffice.org/54465
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 873f09df02a14c8e16ff13ce189c0af3317a754a)

3 years agolok: sc: tunneling the ascii import dialog on paste action
Marco Cecchetti [Fri, 27 Apr 2018 19:51:41 +0000 (27 21:51 +0200)]
lok: sc: tunneling the ascii import dialog on paste action

I needed to modify CreateScImportAsciiDlg signature so that we are
able
to pass a pointer to a dialog parent window to ScImportAsciiDlg.

Moreover, I needed to perform the execution of the ScImportAsciiDlg
dialog in ScViewFunc::PasteDataFormat asynchronously, both for lok and
desktop case. In order to achieve this result it has been needed
to modify the lifespan of some objects previously local
to PasteDataFormat.

Since PasteDataFormat returns a boolean, I took care to check how this
return value is used. I found out 2 cases:
1) in ScViewFunc::PasteFromSystem where it is used for popping up an
error dialog box, informing the user in the case that the paste
operation is failed;
2) in ScGridWindow::ExecuteDrop where it is used for informing the
system window manager of the success or fail of the drag and drop
action.

The first case is now handled by a lamba invoked soon after the dialog
execution ended. The second case is more tricky: I handle it as
the paste operation is always successful, hoping it doesn't do any
real
difference since the return value is used not by LO but by the system
window manager (e.g. gtk).

The asynchronous call and the behaviors described above occur only
when the paste operation involves some kind of simple text, in all
other
cases nothing is changed.

Change-Id: Id4f96180a9336f665a22a2441ea490af993431b0
Reviewed-on: https://gerrit.libreoffice.org/53931
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 32ebfd0da5da80a2fc7b92469024585f1d49bb16)

3 years agocurl: upgrade to release 7.60.0
Andras Timar [Wed, 23 May 2018 12:10:08 +0000 (23 14:10 +0200)]
curl: upgrade to release 7.60.0

Change-Id: Ic8510b424f52c059f979e26441e67ec15b332933
(cherry picked from commit f5a1568cb2e41b68d65e81dda099bc767a7a7801)
(cherry picked from commit 3f83a6d632ab3839fbab3865366e8a1eb244cbe3)

3 years agotdf#115853: save current custom property when adding line
Julien Nabet [Tue, 20 Feb 2018 22:50:04 +0000 (20 23:50 +0100)]
tdf#115853: save current custom property when adding line

by reloading current lines before adding a brand new one
indeed the info are deleted by ClearCustomProperties
each time SfxDocumentInfoItem destructor is called

Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d
Reviewed-on: https://gerrit.libreoffice.org/50070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/52349
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit c522b4017915b3a12203ac39f48a75ae6f4a5bc0)
(cherry picked from commit 4e82bfb26fcb189d18ca6f0e3dbdf79c8b28bf90)
(cherry picked from commit 6f0a7b1c6ecf6344b6c47b64c2f85634dc8eb06b)

3 years agoSQL string quoting: escape "'" character also at beginning of string
Lionel Elie Mamane [Sun, 8 Apr 2018 06:26:55 +0000 (8 08:26 +0200)]
SQL string quoting: escape "'" character also at beginning of string

Change-Id: I51db43c1a3b6d3c93a04a3419238ea286cab987e
Reviewed-on: https://gerrit.libreoffice.org/52578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 4bb50524e385803fddc50474667777fcf7ce19e1)
(cherry picked from commit 1301baea1f2e17d466772f23bbe06d2a2add66ef)
(cherry picked from commit 2fe4716e3ff52965e6591428c1471f692cd655c0)

3 years agoReturn correct length for Authority token
Matteo Casalin [Sun, 14 Jan 2018 18:12:30 +0000 (14 19:12 +0100)]
Return correct length for Authority token

Regression from f4fd558ac9d61fe06aa0f56d829916ef9e5ee7b9
Take the chance to calculate token prefix just once.

Change-Id: I19ce5cb037198cb918e79c760a92b285f9b725f1
(cherry picked from commit 34b98af8e5a4e568d8316700bea1ce604d825ce8)
Reviewed-on: https://gerrit.libreoffice.org/52621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit c6e8460a5b47fa6fa971dde2a89e80662b6e97ae)
Reviewed-on: https://gerrit.libreoffice.org/52626
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit df041d902eafb1e273eb360103252994bbd2cde2)
(cherry picked from commit f2dd38e8aeb7501a5855950d40ddc1818725ff92)
(cherry picked from commit 0fe16572a61d8a5309bb6a28396c49f269a2e7ce)

3 years agotdf#116899: normalize key times during PPT import if needed
Aron Budea [Sun, 22 Apr 2018 14:10:28 +0000 (22 16:10 +0200)]
tdf#116899: normalize key times during PPT import if needed

If TimeAnimationValueListEntry contains time with -1000,
key times have to be distributed evenly between 0 and 1.
([MS-PPT] 2.8.31)

Reviewed-on: https://gerrit.libreoffice.org/53284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 4e207c2e17d75a3cb7b6b72690375279be40d64a)

Reviewed-on: https://gerrit.libreoffice.org/54663
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit c703c934d3f9d6ad7cba620c76520d80cc0e2be7)

Change-Id: I67a3b83f1f1832fade5df7908c58032bcb9b73ce
Reviewed-on: https://gerrit.libreoffice.org/54700
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 37af3939b768be09b6c5671fc8ae89f4e5fc38b6)

3 years agotdf#116976 DOCX import: fix rel size of shape after bitmap
Miklos Vajna [Thu, 12 Apr 2018 16:39:36 +0000 (12 18:39 +0200)]
tdf#116976 DOCX import: fix rel size of shape after bitmap

We have a queue of these odd relative sizes (which are not XML
attributes but text inside the XML element), if the bitmap doesn't pop
the queue, the following shape won't get its size.

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx

Change-Id: I1602208c9509d8889bf0be254f3b25fb25fafca2
Reviewed-on: https://gerrit.libreoffice.org/54669
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit e6f39221b5ce652c78cc675c8dd0a662332ecacc)

3 years agoUse vcl::DeleteOnDeinit for resource managers.
Michael Meeks [Tue, 22 May 2018 14:52:50 +0000 (22 15:52 +0100)]
Use vcl::DeleteOnDeinit for resource managers.

Change-Id: I305c2dfd407f2606331a5950a3b36ee58e1d74d6
Reviewed-on: https://gerrit.libreoffice.org/54676
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit eac3d5cb7ec2369bd5409e79ce4b96552651dbaf)

3 years agoLocalize chart strings properly.
Michael Meeks [Thu, 26 Apr 2018 20:25:43 +0000 (26 21:25 +0100)]
Localize chart strings properly.

Change-Id: I982c95a50c1b4cd9f03f45b0203e06aca3711969
Reviewed-on: https://gerrit.libreoffice.org/53544
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 23109bc47daf037b76b3188c3ac3030873cb8529)

3 years agoAdapt writer translations dynamically for multiple users.
Michael Meeks [Mon, 30 Apr 2018 12:52:56 +0000 (30 13:52 +0100)]
Adapt writer translations dynamically for multiple users.

Change-Id: Id152cc2a3e12acf4850b035f3b5dba7b54fa455d
Reviewed-on: https://gerrit.libreoffice.org/53661
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 3954c5114468b46a6ffd3804feb9fe0a26f95e75)

3 years agobuild fix after ea7fba0ff338098dea5292557c418b7d8c8a100b
Andras Timar [Wed, 16 May 2018 09:03:54 +0000 (16 11:03 +0200)]
build fix after ea7fba0ff338098dea5292557c418b7d8c8a100b

Change-Id: I8885d3c97c3ae11d027e044f01e7bb2a2fcc8968
(cherry picked from commit 302cb9372c8185b8e003f508b587965d710e2911)

3 years agolokdialog: do not lock events when opened ScFilter Dialog
Henry Castro [Thu, 15 Mar 2018 18:23:48 +0000 (15 14:23 -0400)]
lokdialog: do not lock events when opened ScFilter Dialog

When exists 2 or more views and one of the views open the ScFilter dialog,
the other views are locked and no event process.

In tiled rendering case, collaborative editing is not functional with 2 or
more views are locked, so the patch prevents locking the other views

Change-Id: I0133d38ac5ecef4d3ebc22f3e922602704dcd0b3
Reviewed-on: https://gerrit.libreoffice.org/51370
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/51437
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit ea7fba0ff338098dea5292557c418b7d8c8a100b)

3 years agoexternal/python3: Drop nis.cpython-*m.so
Stephan Bergmann [Sat, 7 Apr 2018 10:19:43 +0000 (7 12:19 +0200)]
external/python3: Drop nis.cpython-*m.so

At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development
headers and libraries.  (It only still contains some binaries for backwards
compatibility, in the libnsl sub-package: "This package provides the legacy
version of libnsl library, for accessing NIS services.")

There is probably no real need to have nis.cpython-*m.so contained in
external/python3/ExternalPackage_python3.mk (it probably just happened to build
fine when that list was originally created, so was included).

Change-Id: Ic6128fd872432005c0ded76640c5b56781ca69a1
Reviewed-on: https://gerrit.libreoffice.org/52535
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 93e6a823bd8543d30621769c7b34d6261ea5cb01)
Reviewed-on: https://gerrit.libreoffice.org/53985
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 6debeae49e2485d37b3e6f6c050241f8579fb784)

3 years agoDon't throw in LdapUserProfileBe ctor on LDAP misconfiguration
Mike Kaganski [Wed, 9 May 2018 13:19:46 +0000 (9 16:19 +0300)]
Don't throw in LdapUserProfileBe ctor on LDAP misconfiguration

Otherwise LO crashes e.g. at opening Expert Configuration dialog.
Instead, log the event, create an empty backend, and return empty values.

Reviewed-on: https://gerrit.libreoffice.org/53958
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 5ed889e80805daf8471054786c1e424a73744ad3)

Change-Id: I433fc89c003e7886dfc5242a4ef8defa46d643d3
Reviewed-on: https://gerrit.libreoffice.org/54041
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 40eb8a0a22f4734714c19ea8143fad1d3ffe7117)

3 years agoUse the . separator between sheet name and cell range instead of ! to match UI
Tor Lillqvist [Wed, 9 May 2018 12:11:20 +0000 (9 15:11 +0300)]
Use the . separator between sheet name and cell range instead of ! to match UI

Also put a dollar in front of the sheet name.

Change-Id: I93d610dad8ad085718b0fe389e460b588939e5d2
(cherry picked from commit 79fa6ac73caeae089d255c6b8629075364b4a477)
Reviewed-on: https://gerrit.libreoffice.org/54035
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 849fb9927b85752787e34039a6e243eb5e399c02)

3 years agoWinreg config layer: Allow to define external backend separately
Mike Kaganski [Tue, 24 Apr 2018 15:01:56 +0000 (24 16:01 +0100)]
Winreg config layer: Allow to define external backend separately

Defining backend separately allows e.g. creating ADMX templates with
easy-to-use UI, where user defines only LDAP names for the setting, and
doesn't need to type the LO configuration backend name.

Change-Id: I64f23043c94a5a4e0ba7281d0f711a427d694126
Reviewed-on: https://gerrit.libreoffice.org/53413
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 8776a895d41f174bf5d86332093ed5795c73bdd6)
Reviewed-on: https://gerrit.libreoffice.org/53436
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ca5a44a9f765ca8f968e283b068be6e92f2ab394)

3 years agotdf#117246 RTF import: don't loose page breaks inside nested groups
Miklos Vajna [Thu, 26 Apr 2018 10:03:12 +0000 (26 12:03 +0200)]
tdf#117246 RTF import: don't loose page breaks inside nested groups

Regression from e3f254ab8211fbab7541cde2100a35c875b0c240 (RTF import:
fix spurious page breaks at doc end (related: rhbz#1065629),
2014-02-27), the problem was that now we update the parser state to
remember the next section break should set the break type of the current
section to "next page", but this state should be remembered once the RTF
group ends ("}" character), otherwise \page will be represented with a
continuous break, i.e. lost.

(cherry picked from commit 4a93b46e4652e73ed3460e4c66999d94e50db4b7)

Conflicts:
sw/qa/extras/rtfimport/rtfimport.cxx

Change-Id: I69a8413f45e17e11d6d676c7bfd13ca7560b4d43
Reviewed-on: https://gerrit.libreoffice.org/53510
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ed002d7b8de39de81ccd016bc40841b8d2a132dc)

3 years agoFix OSL_ENSURE invocations.
Michael Meeks [Thu, 26 Apr 2018 20:04:01 +0000 (26 21:04 +0100)]
Fix OSL_ENSURE invocations.

Change-Id: Ic217a75276956f200eaa539da0f5c06475106d0a
Reviewed-on: https://gerrit.libreoffice.org/53540
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 909d104b9e144f42087783acda6e71b1c1e54290)

3 years agoUse async dialog path for format columns.
Michael Meeks [Thu, 26 Apr 2018 18:08:53 +0000 (26 19:08 +0100)]
Use async dialog path for format columns.

Change-Id: I7097abd68b5921697d1d5f39f5e81ac961b61226
Reviewed-on: https://gerrit.libreoffice.org/53539
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 108bbd078c7b91fabc8cb2eb1976fe8973493193)

3 years agolok: charts context menu was misplaced + wrong LogicToLogic conversion
Marco Cecchetti [Wed, 18 Apr 2018 16:31:00 +0000 (18 18:31 +0200)]
lok: charts context menu was misplaced + wrong LogicToLogic conversion

Chart context menu was misplaced since the context menu expects a
position related to the document window not to the chart window.
Moreover map mode is not enabled for chart window, that leads to use
the LogicToLogic routine which unfortunately provides a wrong pixel to
twips conversion. In fact we gets a 20 twips per pixel conversion
since LogicToLogic uses a fixed 72 dpi value, instead of a correctly
computed output device real dpi or at least the most commonly used 96
dpi value.

Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36
Reviewed-on: https://gerrit.libreoffice.org/53118
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit fc409bae21ff400736278294ab6a82a5f3cedfa7)

3 years agotdf#116536 Fix bullet position with linespacing > 100
Szymon Kłos [Fri, 23 Mar 2018 18:51:37 +0000 (23 19:51 +0100)]
tdf#116536 Fix bullet position with linespacing > 100

Change-Id: I862246d9c69e754bdd883787fe42c7d61a1a53d3
Reviewed-on: https://gerrit.libreoffice.org/51790
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/52290
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit e449872333d0c0664eeecb5bb15331d397c1f011)

3 years agosw lok: Accept / reject change is always enabled in the context menu
Tamás Zolnai [Thu, 19 Apr 2018 10:10:52 +0000 (19 12:10 +0200)]
sw lok: Accept / reject change is always enabled in the context menu

Use conditional fastcall for allow executing these two uno commands
even if there is no tracked changes at the cursor position instead of
enable the menu slots unconditionally.

See also:
b6011f07254f8003929320ad842d8d09daca0e09

Reviewed-on: https://gerrit.libreoffice.org/53148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 67919621cb0b95074c4401bdfced9d87b230cc2f)

Change-Id: Iaf8a8082961cd174c038fc021d2c41fb7cb97bff
Reviewed-on: https://gerrit.libreoffice.org/53181
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit faf9d81f0406038b2fddd0a85d64e4a39edf3196)

3 years agoDon't crash when opening templates via WebDAV
Jan-Marek Glogowski [Tue, 19 Sep 2017 15:29:07 +0000 (19 17:29 +0200)]
Don't crash when opening templates via WebDAV

When loading a ODT template via HTTP, it crashes LO with an
lang::IllegalArgumentException in LockFileCommon::ResolveLinks.
This happens when closing the loaded template, as LO tries to
remove a not-existing lock. aDocURL at this point is empty, so
HasError() is true.

As stated in the comment, we don't need a lock for documents
created from templates, as this opens an internal copy of the
document, so don't mark the teplate document as locked.

Change-Id: Ide60020b6287aa67861dbcc8ec1b94f37896b7ef
Reviewed-on: https://gerrit.libreoffice.org/42485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit f95e7ef38e0bf79fa9662bfd50de612d50ef71de)
Reviewed-on: https://gerrit.libreoffice.org/53194
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 547dfbaa533242c19dec83cfd410fd28584cd877)

3 years agotdf#116420: Windows: Test if a filepath redirects to a WebDAV resource
Mike Kaganski [Tue, 17 Apr 2018 21:42:17 +0000 (18 00:42 +0300)]
tdf#116420: Windows: Test if a filepath redirects to a WebDAV resource

In Windows, filesystem redirectors can map WebDAV resources to UNC
paths, or to drive-based "local" paths; so a WebDAV URI of the form
"http://WebDADServer/root/directory/File.ext" may be accessed using
"\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext".

When using these paths, failure to create a lockfile aside the opened
document should not be considered an error; so this patch checks for
this.

Regression from commit 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e.

Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee
Reviewed-on: https://gerrit.libreoffice.org/53070
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 642a49e8d3006d000bc6c58def34d4e96764c6cc)
Reviewed-on: https://gerrit.libreoffice.org/53080
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit ebabd7133031199633b19b8764350f333c7cfc7d)

3 years agonss: upgrade to release 3.38distro/collabora/cd-5.3-3.2
Andras Timar [Wed, 8 Aug 2018 11:00:11 +0000 (8 13:00 +0200)]
nss: upgrade to release 3.38

Fixes CVE-2018-0495 and "the ASN.1 code".

Change-Id: I96ec90aaee7e4a803ebde1508951c55db4577e9e
(cherry picked from commit b01ee1682286a52cda1ee14597257e1f862d4e16)

3 years agoforcepoint#69 ditch any unclosed m_pPosAfterTOC before dropping cursor
Caolán McNamara [Thu, 2 Aug 2018 20:18:15 +0000 (2 21:18 +0100)]
forcepoint#69 ditch any unclosed m_pPosAfterTOC before dropping cursor

Reviewed-on: https://gerrit.libreoffice.org/58498
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 71aae473c9c3cf15f75e2722afc7153a3af76d44)

Change-Id: I6b56a48f5449b25fe3bdc2e02d3885388b0da74f
(cherry picked from commit 9b2efcf761678e24cceefa6f87300f2ffe98fb19)

3 years agoforcepoint#66 make sure we don't get stuck endlessly reparsing
Caolán McNamara [Wed, 1 Aug 2018 18:25:27 +0000 (1 19:25 +0100)]
forcepoint#66 make sure we don't get stuck endlessly reparsing

Change-Id: Ie2733e8d7f73e5f6a072604c477e949cd944189a
Reviewed-on: https://gerrit.libreoffice.org/58466
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit cc8140fe71becc92976167e2a96dbe1d727097dc)
(cherry picked from commit fab30b5d512edf8d5252ddde4132b0f310431afd)

3 years agoforcepoint#66 protect against infinite parse recurse
Caolán McNamara [Wed, 1 Aug 2018 14:05:45 +0000 (1 15:05 +0100)]
forcepoint#66 protect against infinite parse recurse

Reviewed-on: https://gerrit.libreoffice.org/58452
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 171657a1f675268839526b1a13e5f3549fb73516)

Change-Id: I0313cc141469a00b7d6a5bd15400e9d5a8f686cf
(cherry picked from commit 9291178596c4e5165de51c0be5a525cbaa564140)

3 years agoforcepoint#65 pdf page visiting revisits itself
Caolán McNamara [Wed, 1 Aug 2018 11:04:30 +0000 (1 12:04 +0100)]
forcepoint#65 pdf page visiting revisits itself

Change-Id: I6d9eb75f0850a94814fb4d69ea1442b826674496
Reviewed-on: https://gerrit.libreoffice.org/58418
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit e6d5ef741c75895ed97801112823b8332557d79a)
(cherry picked from commit d63463b0001cc6a439840d0cee36b6678aea467e)

3 years agoforcepoint#59 the "matrix" is always one row in height
Caolán McNamara [Wed, 1 Aug 2018 09:42:16 +0000 (1 10:42 +0100)]
forcepoint#59 the "matrix" is always one row in height

so it can be a vector instead, and by using vector::at() instead of
matrix::at() vector bounds checking is performed, unlike matrix::at()
which does no checking

Change-Id: Ic767c2dd884bffbf1cdff65c0980b21170612f4d
Reviewed-on: https://gerrit.libreoffice.org/58399
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit ccfdc4b675233131fb99c998d2dc48affb0ac7af)
(cherry picked from commit 58b4de56a389463eaef6dd228ffb7f37c1ba6103)

3 years agoofz#9431 don't check attribs of Invalid column
Caolán McNamara [Tue, 24 Jul 2018 13:20:20 +0000 (24 14:20 +0100)]
ofz#9431 don't check attribs of Invalid column

Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0
Reviewed-on: https://gerrit.libreoffice.org/57917
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit d909146913c762c2cdb6bed52fbbd817c05681e9)
(cherry picked from commit f4189f0dab25dbb61332d70c434485f8dc28be70)

3 years agoResolves: tdf#118919 crash on double click ole object
Caolán McNamara [Wed, 25 Jul 2018 08:09:15 +0000 (25 09:09 +0100)]
Resolves: tdf#118919 crash on double click ole object

Change-Id: Id7b3df447db56f6f80d6255dabdcc7f6ab149e95
Reviewed-on: https://gerrit.libreoffice.org/57956
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit d595829c64e149896d2b5e8a4974636f8d9bd892)
(cherry picked from commit 960b781ba14af8286f49012b47515b5babfb8737)

3 years agoforcepoint#53 restrict to expected index range
Caolán McNamara [Tue, 24 Jul 2018 13:47:14 +0000 (24 14:47 +0100)]
forcepoint#53 restrict to expected index range

Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f
Reviewed-on: https://gerrit.libreoffice.org/57922
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit fa82b6a5c74b527dc2aed9d3b63c997580cdb277)
(cherry picked from commit d0f42b02c29c1e6aeeaa13d5f0d4a2e8b5ccb881)

3 years agoofz#9507 wrong start point for Johab block 59
Caolán McNamara [Mon, 23 Jul 2018 08:23:54 +0000 (23 09:23 +0100)]
ofz#9507 wrong start point for Johab block 59

Change-Id: I011f4cbb10324c4a7d4e1be3ab1355291f79730b
Reviewed-on: https://gerrit.libreoffice.org/57839
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 6582602a126403185294afe9e3c2cd8479f9157b)
(cherry picked from commit a4cb046a1247c6e0c321ba961330ab5ca2f8d50a)

3 years agoforcepoint#48 null deref
Caolán McNamara [Tue, 26 Jun 2018 11:15:19 +0000 (26 12:15 +0100)]
forcepoint#48 null deref

Reviewed-on: https://gerrit.libreoffice.org/56463
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 6725491ce8ef2e41feb9b732ad7ac366ba545ca9)

Change-Id: I790fc6dafc0d8c9783b9dddc266b313af2a046d7
(cherry picked from commit 5ef3fadd509766032cd402552153e9d5e743a22d)

3 years agoUpdate git submodules
Andras Timar [Mon, 6 Aug 2018 14:28:29 +0000 (6 16:28 +0200)]
Update git submodules

* Update translations from branch 'distro/collabora/cd-5.3-3.2'
  - ja translation of 'No Fill'

    Change-Id: Ia27cce78a507b747284ef096c85105f11dc7ed00

3 years agoUpdate git submodules
Andras Timar [Mon, 30 Jul 2018 21:04:34 +0000 (30 23:04 +0200)]
Update git submodules

* Update translations from branch 'distro/collabora/cd-5.3-3.2'
  - Updated Korean translation

    Change-Id: I1a8af9ab040b58e809d79288edbe9a719666bee6

3 years agoUpdate git submodules
Andras Timar [Mon, 30 Jul 2018 17:24:58 +0000 (30 19:24 +0200)]
Update git submodules

* Update translations from branch 'distro/collabora/cd-5.3-3.2'
  - Updated Japanese translation

    Change-Id: Ie28f4c0ed0533cf4e96b6fa10f18ce00acbc7368

  - remove extra ~ characters from German translation

    Change-Id: Iadeafd183afecb6c16f8b7d23311b6f050266dde

4 years agoBump version 5.3-49cd-5.3-49
Jan Holesovsky [Thu, 12 Jul 2018 21:14:19 +0000 (12 23:14 +0200)]
Bump version 5.3-49

Change-Id: I27cbc26e1623123ad522ceefdaf9aaa9b235bd25

4 years agodesktop: move font initialization into preloadData
Ashod Nakashian [Fri, 6 Jul 2018 20:49:29 +0000 (6 16:49 -0400)]
desktop: move font initialization into preloadData

Change-Id: I66840512b45e987cc7b08b07b65bdb24f2023a41
Reviewed-on: https://gerrit.libreoffice.org/57160
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
4 years agolok: Don't even try to paint the ruler via LibreOfficeKit.
Jan Holesovsky [Thu, 28 Jun 2018 14:12:30 +0000 (28 16:12 +0200)]
lok: Don't even try to paint the ruler via LibreOfficeKit.

But we need to have it behind the scenes, otherwise the Online's ruler
does not get notifications.

Change-Id: I72bef28cb15c462572b511449d538b067f7cb141
Reviewed-on: https://gerrit.libreoffice.org/56598
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ee6e6bd5b853aa68c9721f53b5892384e7403eec)

4 years agosw lok: delay processing idle jobs to let LOK finish initialization
Ashod Nakashian [Thu, 28 Jun 2018 05:02:49 +0000 (28 01:02 -0400)]
sw lok: delay processing idle jobs to let LOK finish initialization

When loading document, LOK needs to setup the client view, register
callbacks, get document size and type, etc. All of these need
to take SolarMutex, which is taken by the idle jobs immediately
after loading, blocking LOK from finishing initialization
and rendering the first tiles for the user. This gives the
user the impression that the document is loading for far
longer than it actually is, due to lack of interactivity
(or indeed any activity on the screen besides the spinning wheel).

By delaying the idle jobs, we allow time for LOK to finish
initialization and render the first tiles before the idle
jobs kick in and hog SolarMutex.

Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae
Reviewed-on: https://gerrit.libreoffice.org/56572
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 1056640a6e1fd044cb61f5bf5ee85dfec3cbeb7c)

4 years agodesktop: move dictionary preload before font init
Aron Budea [Fri, 6 Jul 2018 13:32:49 +0000 (6 15:32 +0200)]
desktop: move dictionary preload before font init

spell-checker is initialized during font init

since e7f65920b12517b31f0c5cbfd0dcb8df96d20ba4

Change-Id: Ia5b5223aa8cc00d0e80451142ae18a7046ad00d4
Reviewed-on: https://gerrit.libreoffice.org/57064
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit bd88f41d53881fd1a3ad42268cd76d598bdd7838)

4 years agodesktop: initialize fonts in pre-init
Ashod Nakashian [Thu, 28 Jun 2018 05:07:32 +0000 (28 01:07 -0400)]
desktop: initialize fonts in pre-init

Change-Id: I5a3acc41196c7e0672514fa2dae00e5fc0f76a1f
Reviewed-on: https://gerrit.libreoffice.org/56573
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit e7f65920b12517b31f0c5cbfd0dcb8df96d20ba4)

4 years agoforcepoint#43 endless update ole2 preview recursion
Caolán McNamara [Tue, 29 May 2018 12:12:12 +0000 (29 13:12 +0100)]
forcepoint#43 endless update ole2 preview recursion

Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc
Reviewed-on: https://gerrit.libreoffice.org/55004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 1663a364c80fde2ac8396dd2fbcbee4240231271)
(cherry picked from commit 3ca78fd4d5c710c9f6baff2b975969d9d2ff41db)
(cherry picked from commit ac981fce182a6e7c0393fa128e2243c062746191)

4 years agoforcepoint#42 check available str length
Caolán McNamara [Mon, 28 May 2018 20:51:01 +0000 (28 21:51 +0100)]
forcepoint#42 check available str length

Change-Id: Ie476968ddaa4c3e5475ae9aa6133e7aba38d5975
Reviewed-on: https://gerrit.libreoffice.org/54978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 15ea1cda0b3c37ff944ad9a239b7ed453e8b0591)
(cherry picked from commit dbd8adf30c810558924929647fc5caea718e9635)
(cherry picked from commit 9d00f5034eef7867d8973a9d7b124e531bfccd7d)

4 years agoforcepoint#40 null deref
Caolán McNamara [Mon, 28 May 2018 20:22:56 +0000 (28 21:22 +0100)]
forcepoint#40 null deref

presumably since

commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207
Date:   Thu Sep 21 06:48:09 2017 +0200

    tdf#112501: Pivot table: popupbuttons are placed on wrong cells

Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50
Reviewed-on: https://gerrit.libreoffice.org/54970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 69c5be9b26cf1a45e220d69f65b1bb0fa2aedaf6)
(cherry picked from commit 47f090e2e4ba84684cdd1c0684cb1b9f2baa600f)
(cherry picked from commit 3547cd460263f710d2f49fbb8bf00808c012629e)

4 years agotdf#105720: lok: sc: currency symbol is displayed in the preceding cell
Marco Cecchetti [Thu, 14 Jun 2018 10:32:48 +0000 (14 12:32 +0200)]
tdf#105720: lok: sc: currency symbol is displayed in the preceding cell

Now in online the currency symbol is placed exactly as in the desktop
case. Essentially there was a mapping issue.

Change-Id: I6175cfeab3d8bc3a757c8522aa9c7a7e49c4bf2b
Reviewed-on: https://gerrit.libreoffice.org/55806
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit b1d003af24447a60d1e372caded54e30501b9fd6)

4 years agolokdialog: Allow switching language of editengine ResMgr
Aron Budea [Wed, 6 Jun 2018 14:50:20 +0000 (6 16:50 +0200)]
lokdialog: Allow switching language of editengine ResMgr

Change-Id: I48603cdff916c242dc20fe16fdaffaa9effa6f74
Reviewed-on: https://gerrit.libreoffice.org/55386
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 03e81df3441a8175770edd522f592f243b5f9082)

4 years agolok: sc: ctrl-clicking links doesn't work
Marco Cecchetti [Thu, 10 May 2018 21:13:12 +0000 (10 23:13 +0200)]
lok: sc: ctrl-clicking links doesn't work

I think there is no reason for not execuring the code below

if ((bDouble || bIsTiledRendering) && .... ) { ... }

for both desktop and online.

So since the code for open the clicked URL is below such if
clause, I changed the code so that we return only when it's really a
double click event.

Moreover I reverted back the code for executing the list validation
pop-up to its original place, since there is no more the need to have
it executed in two places.

Change-Id: Idbec2e6e45cd7ee8282005169e1132a11d4cac33
Reviewed-on: https://gerrit.libreoffice.org/56922
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
4 years agoResolves: tdf#108654 check nTabNo against maTabData size
Eike Rathke [Wed, 21 Jun 2017 15:42:42 +0000 (21 17:42 +0200)]
Resolves: tdf#108654 check nTabNo against maTabData size

ScViewData::DeleteTab() and DeleteTabs() never did that and worked by accident
for which commit 73dec49802ef8fc42c5719efaa42a33cde68e569 removed the
grounding..

squash this into it too:

assert(nTab < static_cast<SCTAB>(maTabData.size())); cause of tdf#108796

Have a dev friendly abort instead of a deep throw in case of the unexpected.

Change-Id: I95460cd017d558c073df7891551d0251009dc1d4
Reviewed-on: https://gerrit.libreoffice.org/56261
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit abe9a9b023d1b08384f2f529e442e9a59de10f8c)

4 years agoBump version 5.3-48cd-5.3-48
Andras Timar [Fri, 22 Jun 2018 14:29:38 +0000 (22 15:29 +0100)]
Bump version 5.3-48

Change-Id: I2c2ce51615dc34f590251e62ba22cf8ab7decb00

4 years agopdfium: Delay the swap out.
Jan Holesovsky [Fri, 22 Jun 2018 10:58:12 +0000 (22 12:58 +0200)]
pdfium: Delay the swap out.

If we swap out too early, the constructor of GraphicObject forces a swap
in, so we'd render everything during the load anyway.

Change-Id: I0ea1a755242fd57ef28d082ce4bf534a32199f87
Reviewed-on: https://gerrit.libreoffice.org/56286
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
4 years agopdfium: Avoid unnecessary copying + some warning fixes.
Jan Holesovsky [Fri, 22 Jun 2018 08:28:42 +0000 (22 10:28 +0200)]
pdfium: Avoid unnecessary copying + some warning fixes.

Change-Id: I114fa6b2d3dda86c55eb245d31ca3a1019197ae9
Reviewed-on: https://gerrit.libreoffice.org/56285
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
4 years agopdfium: Import PDF with unloaded images.
Ashod Nakashian [Sat, 9 Jun 2018 17:09:35 +0000 (9 13:09 -0400)]
pdfium: Import PDF with unloaded images.

Change-Id: I5e4a16ff38b9643127ce16879b35f456c13bcff8
Reviewed-on: https://gerrit.libreoffice.org/56268
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
4 years agopdfium: Keep the PDF data in memory, so that we can really share them.
Jan Holesovsky [Thu, 21 Jun 2018 22:44:44 +0000 (22 00:44 +0200)]
pdfium: Keep the PDF data in memory, so that we can really share them.

Otherwise the swap out / swap in creates new copy of the underlying PDF
stream.

Change-Id: I88a16a69143783a998201e183bea1a9553e337bd
Reviewed-on: https://gerrit.libreoffice.org/56266
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
4 years agopdfium: Share the GfxLink for PDF files.
Jan Holesovsky [Thu, 21 Jun 2018 19:33:56 +0000 (21 21:33 +0200)]
pdfium: Share the GfxLink for PDF files.

Partially based on work by Ashod Nakashian, thanks!

Change-Id: Id7e8c4543368b0caf3e459abaff8c53997779c83
Reviewed-on: https://gerrit.libreoffice.org/56265
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
4 years agoBump version 5.3-47cd-5.3-47
Jan Holesovsky [Mon, 28 May 2018 14:36:17 +0000 (28 16:36 +0200)]
Bump version 5.3-47

Change-Id: I3ab41b34d09e9318cdd23e172082ca96d6ba020d

4 years agovcl: fix pdf rendering regression
Ashod Nakashian [Mon, 28 May 2018 12:02:06 +0000 (28 08:02 -0400)]
vcl: fix pdf rendering regression

Change-Id: I6c2c48c033facb317b4ca7ed2af07348d6386b98
Reviewed-on: https://gerrit.libreoffice.org/54921
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
4 years agopdf: preserve the original page dimensions on import
Ashod Nakashian [Fri, 25 May 2018 03:01:15 +0000 (24 23:01 -0400)]
pdf: preserve the original page dimensions on import

Also allow for rendering PDFs to images at custom
resolution, instead of hard-coded (old hard-coded
value of 96 dpi is now default arguments).

Change-Id: Ia5b52f72d6ce7130a2debc7c6f86504aa041bdc8
Reviewed-on: https://gerrit.libreoffice.org/54786
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
4 years agosd: make the imported PDF page exactly as original
Ashod Nakashian [Thu, 24 May 2018 10:59:39 +0000 (24 06:59 -0400)]
sd: make the imported PDF page exactly as original

i.e. no borders or larger page than rendered PDF

Change-Id: I1f356cceeec1d5d9f1728f0e29160fdd9241a221
Reviewed-on: https://gerrit.libreoffice.org/54764
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
4 years agosd: render the correct PDF page on swapping in
Ashod Nakashian [Thu, 24 May 2018 05:33:50 +0000 (24 01:33 -0400)]
sd: render the correct PDF page on swapping in

Change-Id: I81225e228d9cf2b9849110715dbfdeb59f2805dd
Reviewed-on: https://gerrit.libreoffice.org/54746
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
4 years agoofz#7648 Bad-cast
Caolán McNamara [Fri, 13 Apr 2018 13:33:27 +0000 (13 14:33 +0100)]
ofz#7648 Bad-cast

Change-Id: I21aaf36f3d6b6c3054649208de809b99aa384c01
Reviewed-on: https://gerrit.libreoffice.org/52836
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 1db17a71b028c392a00393cdf313e1720b93fd2e)
(cherry picked from commit 20bf87c6a3a076fe78f938b7a3086146336976e7)

4 years agoofz#7109 infinite regress
Caolán McNamara [Sun, 25 Mar 2018 13:01:25 +0000 (25 14:01 +0100)]
ofz#7109 infinite regress

Change-Id: Iac0bd81c9b0e3ac6b005bb0065895ca1b4ca4233
Reviewed-on: https://gerrit.libreoffice.org/51828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit e4308d4b3638d52ca70778565ba2541e9f3f0ff2)
(cherry picked from commit 79bb8c64b633f9397601df4e73f09d7fef066c2b)

4 years agoIntroduce a LO_IMPORT_USE_PDFIUM envvar to force PDFium for PDF import.cd-5.3-46
Jan Holesovsky [Tue, 22 May 2018 08:47:46 +0000 (22 10:47 +0200)]
Introduce a LO_IMPORT_USE_PDFIUM envvar to force PDFium for PDF import.

Change-Id: Ibb7734430b955dad4aefec22260ba8694ccb9183

4 years agosd: disable pdf import tests
Ashod Nakashian [Mon, 21 May 2018 02:31:36 +0000 (20 22:31 -0400)]
sd: disable pdf import tests

Change-Id: Iaee679d2ff322c67d081185588103d5685fa970a

4 years agogtktiledviewer downgrade min gtk+ to 3.16
Ashod Nakashian [Tue, 14 Nov 2017 14:17:59 +0000 (14 09:17 -0500)]
gtktiledviewer downgrade min gtk+ to 3.16

Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5
Reviewed-on: https://gerrit.libreoffice.org/44724
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit a3f432a68733b6e76ecb68cf5704a59d1be1e5cb)

4 years agosvx: set the font name of imported PDF text
Ashod Nakashian [Sun, 20 May 2018 19:17:16 +0000 (20 15:17 -0400)]
svx: set the font name of imported PDF text

Change-Id: I79dde3c8983a70311de2d2a46093fac2722fb372

4 years agosvx: update PDFium patch and code
Ashod Nakashian [Sun, 20 May 2018 01:28:31 +0000 (19 21:28 -0400)]
svx: update PDFium patch and code

Change-Id: I07c6a7c65d5631b70da64927a35d7a3b371eff25

4 years agopdfium: update to 3426
Miklos Vajna [Mon, 14 May 2018 06:55:58 +0000 (14 08:55 +0200)]
pdfium: update to 3426

Allows dropping the ugly freetype.patch.1.

Reviewed-on: https://gerrit.libreoffice.org/54294
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 56195a4d0bbb21edeed1cea7a45283141c733f18)

Change-Id: Ifa8a6dac02a49a2c13572e59773261a847efad3f

4 years agosvx: cleanup pdfium importer
Ashod Nakashian [Fri, 18 May 2018 13:15:36 +0000 (18 09:15 -0400)]
svx: cleanup pdfium importer

Change-Id: Id925ba7734a2c73270e40f19d3fc50552441c34e

4 years agosvx: transform PDF text rectangles while importing
Ashod Nakashian [Mon, 14 May 2018 23:57:15 +0000 (14 19:57 -0400)]
svx: transform PDF text rectangles while importing

Change-Id: I7675a183bfb691a8783950f33dc34826f91cb768

4 years agosvx: set the Model explicitly before using SDR objects
Ashod Nakashian [Mon, 14 May 2018 23:01:44 +0000 (14 19:01 -0400)]
svx: set the Model explicitly before using SDR objects

Change-Id: I176d1c1c7f759904ab36796a47e879e45ce4a5af