LibreOffice.git
3 years agoBump version to 6.0-18CODE-4-RC1pcp-6.0-18
Andras Timar [Thu, 6 Dec 2018 13:47:43 +0000 (6 14:47 +0100)]
Bump version to 6.0-18

Change-Id: I0231b0541f626fedec3d5bed97adf5bb23f5f2f3
(cherry picked from commit 41a232eed11bb7bc0ca16127958e19ff33a6e7fd)

3 years agotdf#121779: extend TWo CApitals list to also ignore sMALL iNITIALS
Mike Kaganski [Fri, 7 Dec 2018 10:10:57 +0000 (7 13:10 +0300)]
tdf#121779: extend TWo CApitals list to also ignore sMALL iNITIALS

Now this list is used also in rules for capitalizing first letter of
every sentence, and for correcting accidental use of Caps Lock key.

Change-Id: I4fbdbccbae32743d5e9a6757344361eefd88e167
Reviewed-on: https://gerrit.libreoffice.org/64759
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/65087
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
3 years agolok: Handle Special character menu item's state correctly in online
Tamás Zolnai [Fri, 14 Dec 2018 16:36:41 +0000 (14 17:36 +0100)]
lok: Handle Special character menu item's state correctly in online

Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f
Reviewed-on: https://gerrit.libreoffice.org/65188
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 13998b050f445bac3593a8bb77b7320d1be9990d)
Reviewed-on: https://gerrit.libreoffice.org/65202
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agosvg.js: the SVG Path polyfill doesn't work with Firefox 59 and later
Marco Cecchetti [Wed, 12 Dec 2018 16:04:21 +0000 (12 17:04 +0100)]
svg.js: the SVG Path polyfill doesn't work with Firefox 59 and later

We use a drop-in replacement for the SVGPathSeg and SVGPathSegList
APIs that were removed from SVG2. Unfortunately the embedded version
of this polyfill doesn't work anymore with Firefox 59 and later.

It has been needed to adapt a new version of the same polyfill.
(See https://github.com/progers/pathseg)

Change-Id: Ib5208d67022e585b7a5fb24e37cc446f50e57ee3
(cherry picked from commit 1b2aedb7b9f81bb6b43b64559cab00956c189f82)

3 years agolok: Insert shape at the positon of the selected cell
Tamás Zolnai [Fri, 7 Dec 2018 12:25:59 +0000 (7 13:25 +0100)]
lok: Insert shape at the positon of the selected cell

Calculation of the visible area is not working correctly in
online case which leads to positioning of the shape outisde
of the view.
Instead of that calculation use the selected cell's position
to insert the shape at, similar how image insertion works.

Change-Id: I5c887261556c491962ed19f416ce480a63c24a9a
(cherry picked from commit 076675d5b57ad779a15e25c2105127d86e849fbb)

3 years agolok: sw: dragging image through SID_ATTR_TRANSFORM uno messages
Marco Cecchetti [Wed, 12 Dec 2018 09:39:39 +0000 (12 10:39 +0100)]
lok: sw: dragging image through SID_ATTR_TRANSFORM uno messages

In writer the new solution for dragging images through a uno message
to the transformation dialog didn't work.

Change-Id: Ie2c5fa7c3b724b6a8cba9970ee070c9998730a29
(cherry picked from commit c52d94454c46fa6a0e64081127b511bcde4f7a3e)

3 years agolok: shape selection: perform the needed unit conversion in a clever way
Marco Cecchetti [Fri, 30 Nov 2018 16:20:37 +0000 (30 17:20 +0100)]
lok: shape selection: perform the needed unit conversion in a clever way

Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5

3 years agotdf#98343: ensure PathRemoveFileSpec does not remove UNC's "\\"
Mike Kaganski [Fri, 14 Dec 2018 11:44:57 +0000 (14 12:44 +0100)]
tdf#98343: ensure PathRemoveFileSpec does not remove UNC's "\\"

PathRemoveFileSpec is used exclusively in GetCaseCorrectPathName(Ex).
The GetCaseCorrectPathName function is only called for absolute or
relative paths, not some arbitrary that chunks. So initial double
backslashes are only possible for UNC paths.

This change fixes handling of UNC paths by the functions. Previously,
the UNC path was recursively shortened until it only consisted of a
single "\"; then, if bCheckExistence was requested, testing this path
failed, which resulted in the whole recursion to return empty result;
else when returning from the recursion, original path components were
appended, but initial double backslashes were never restored. This led
to transformation "\\SERVER\Path\file.ext" to "\SERVER\Path\file.ext".

The GetCaseCorrectPathName itself is only used in two places:
osl_getSystemPathFromFileURL_() and osl_getFileStatus().

osl_getSystemPathFromFileURL_ only calls GetCaseCorrectPathName for
paths longer than 248 characters; bCheckExistence is false. In that
case, the resulting wrong path (missing one initial backslash) was then
processed in /* it should be an UNC path, use the according prefix */
branch, where two initial characters of it were stripped, one of which
being the first character of SERVER name. So, all the following
manipulations with resulting path were incorrect. This code path was
the reason for the bug.

osl_getFileStatus calls GetCaseCorrectPathName always; it requires
to check existence. This led to 0 returned from GetCaseCorrectPathName,
then osl_getFileStatus continued with copying the original string, thus
ignoring the error.

Change-Id: If7409afa2c0dd6dd001c79e719acbfd271a6ab72
Reviewed-on: https://gerrit.libreoffice.org/65158
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 12e878d3b5e8a59079811c36b7c89e588266dd0e)
Reviewed-on: https://gerrit.libreoffice.org/65192
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
3 years agomysqlc: Fix obtaining field information in rs
Tamas Bunth [Mon, 10 Dec 2018 09:43:14 +0000 (10 10:43 +0100)]
mysqlc: Fix obtaining field information in rs

Result set field information should be stored correctly. It is queried
from database on demand and stored locally.

Change-Id: Ia62c62e6db32b45640b9fcd5f48c6249aecc41a2
Reviewed-on: https://gerrit.libreoffice.org/64861
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/65160
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agoRevert "Add a localisation API to LibreOfficeKitClass"
Tor Lillqvist [Thu, 13 Dec 2018 15:21:46 +0000 (13 17:21 +0200)]
Revert "Add a localisation API to LibreOfficeKitClass"

Was reverted in master, too. The functionality is implemented
differently now in the iOS app, without requiring any new methods in
LibreOfficeKitClass.

This reverts commit 36beb79184e5f4153c8cc92b176b21b697594228.

Change-Id: Ic0c42848c81a9b48e50a2b01a0a5a98ef5220870

3 years agotdf#121734: ww8 import: use direct formatting for floating object frames
Mike Kaganski [Tue, 11 Dec 2018 21:31:13 +0000 (12 00:31 +0300)]
tdf#121734: ww8 import: use direct formatting for floating object frames

... and don't modify standard frame styles to have no borders and padding.
This makes "Frame", "OLE", and "Graphics" frame styles of imported DOC
files to have usual settings (for "Frame", it's 1.5 mm padding and all
borders set to 0.05 pt black line).

All objects that need invisible frame will have them with all necessary
settings set explicitly, which allows to copy and paste such frames to
other documents without problems.

This makes DOC import aligned with DOCX import in this regard.

Change-Id: I6f05cf71e63ceccb8e0ddebe23ec41bf69af9b52
Reviewed-on: https://gerrit.libreoffice.org/64992
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/65012
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
3 years agoFix C2695: overriding virtual function differs only by calling convention
Tor Lillqvist [Tue, 11 Dec 2018 13:47:14 +0000 (11 15:47 +0200)]
Fix C2695: overriding virtual function differs only by calling convention

Change-Id: Icc85d3ff747d7372968cf4a3f514f0d3b7f8647c

3 years agoAccept also Windows SDK 10.0.17763
Tor Lillqvist [Tue, 11 Dec 2018 11:08:01 +0000 (11 13:08 +0200)]
Accept also Windows SDK 10.0.17763

3 years agoAdd a localisation API to LibreOfficeKitClass
Tor Lillqvist [Mon, 10 Dec 2018 14:12:08 +0000 (10 16:12 +0200)]
Add a localisation API to LibreOfficeKitClass

Combines the LanguageTag::Create() and Translate::get() functionality.

Also add an ABI test for the Kit class in the LibreOfficeKit unit
test, and a test for the translation function.

(In this branch there is no Translate::nget() so no such
functionality.)

Change-Id: I78c48a8bbb434d6f204869290822830288022a53
Reviewed-on: https://gerrit.libreoffice.org/64894
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
3 years agoImplement SVG export of selected Writer imageCODE-4-RC1cp-6.0-17
Tamás Zolnai [Thu, 29 Nov 2018 15:21:28 +0000 (29 16:21 +0100)]
Implement SVG export of selected Writer image

A Writer image does not behave similar to other
shapes, so we need to generate a shape to get the
export code working.

Change-Id: Icfb25ceb40f73f1018d379863b836d8303e539f3

3 years agoRevert "g: ignore submodule changes"
Stephan Bergmann [Mon, 12 Mar 2018 15:56:30 +0000 (12 16:56 +0100)]
Revert "g: ignore submodule changes"

This reverts commit 27925032cd5aec8805185679e01c687c40bbd617.
Conflicts:
g

According to vmiklos, that commit was meant to help with the following scenario:
Assume a dev uses submodules and uses plain `git pull && git submodule update`
instead of ./g.  When they forget the "&& git submodule update" part and do
`git commit -a`, changes to the submodules were excluded from the commit.

However, when they do `git add -u && git commit` instead of `git commit -a`,
changes to the submodules /are/ included in the commit, despite `git status` or
`git diff` (both prior to `git add -u`) or `git diff --cached` (after `git add
-u`) not indicating that there are any changes to the submodules.  I consider
that problem more confusing and severe than the problem that the commit solved.

Change-Id: I595eed3c1c04efd108be1ccd792d8d7bce72a345
Reviewed-on: https://gerrit.libreoffice.org/51155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
3 years agoGet rid of ValueSet's internal VirtualDevice, draw to RenderContext
Mike Kaganski [Thu, 22 Nov 2018 12:20:16 +0000 (22 15:20 +0300)]
Get rid of ValueSet's internal VirtualDevice, draw to RenderContext

This improves support for Online HiDPI scenarios.

Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893

3 years agoAvoid busy-loop related to layout when dragging objects.
Michael Meeks [Thu, 22 Nov 2018 12:48:17 +0000 (22 12:48 +0000)]
Avoid busy-loop related to layout when dragging objects.

Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3

3 years agogit hooks: Tell what to do in another problematic submodules case.
Jan Holesovsky [Thu, 22 Nov 2018 10:52:21 +0000 (22 11:52 +0100)]
git hooks: Tell what to do in another problematic submodules case.

Change-Id: I6247df16c021c13c97471cae16d3a1c0f3ddc691

3 years agogit hooks: Check that you are not committing to submodules by accident.
Jan Holesovsky [Wed, 14 Nov 2018 14:20:14 +0000 (14 15:20 +0100)]
git hooks: Check that you are not committing to submodules by accident.

And also for a dangerous setting in the configuration that hides the
changes from you.

Change-Id: I99bad8024baf7048696d9602e857c253c20cb5c2
Reviewed-on: https://gerrit.libreoffice.org/63389
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
3 years agocolibre: Bring in the latest modifications from master.
Jan Holesovsky [Tue, 20 Nov 2018 22:38:44 +0000 (20 23:38 +0100)]
colibre: Bring in the latest modifications from 

Change-Id: I081e1b7400f4fd8dcb9c3011e75d746692a043f7

3 years agoPackage separate SVG icon sets
Jan-Marek Glogowski [Wed, 31 Oct 2018 17:24:28 +0000 (31 17:24 +0000)]
Package separate SVG icon sets

This change packages all SVG based icon sets in seperate zip
files. It automatically generates the SVGs links.txt from
the non-SVG version, if it doesn't exists by 's/\.png/\.svg/g'.

Same for the _dark version, but this just copies it.
This would also work for a _dark_svg version, if needed.

The patch explicitly does't package sifr_svg and tango_svg.

Change-Id: I8d7fda42d0ff9a2108ba8406bd4e82af4c54ff0c
Reviewed-on: https://gerrit.libreoffice.org/62706
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
3 years agoStrip _dark and _svg iconset filenames for display
Jan-Marek Glogowski [Fri, 2 Nov 2018 18:20:51 +0000 (2 19:20 +0100)]
Strip _dark and _svg iconset filenames for display

The new display name code handles _dark and _svg like an property
or extension. It strips both from the back of the base filename
and adds them in brackets to the display name as (SVG), (dark)
and (SVG + dark).

This way we can drop the special handling for breeze_dark and
sifr_dark display names.

Change-Id: I0ebc8392582d7240b51528078de9d81b36e5a9e9
Reviewed-on: https://gerrit.libreoffice.org/62788
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
3 years agolok: Implement SVG export for Calc (SelectionOnly mode)
Tamás Zolnai [Fri, 16 Nov 2018 15:35:09 +0000 (16 16:35 +0100)]
lok: Implement SVG export for Calc (SelectionOnly mode)

Change-Id: Ic305e5305890fd1efa3a3130e5216f9c672870e5

3 years agolok: Implement SVG export for Writer (SelectionOnly mode)
Tamás Zolnai [Fri, 16 Nov 2018 15:00:38 +0000 (16 16:00 +0100)]
lok: Implement SVG export for Writer (SelectionOnly mode)

Separate generic code from Impress / Draw specific code
and implement shape selection handling in case of Writer.
This is an internal filter, so it can be called only from
the code.

Change-Id: I807e04a0949530d6029037bb964c10c80197ff33

3 years agolok: shape scaling rework
Marco Cecchetti [Thu, 29 Nov 2018 21:37:45 +0000 (29 22:37 +0100)]
lok: shape scaling rework

Now shape scaling is handled through the transform dialog instead of
simulating a drag and drop event in core.

For Impress the unit used for length is '100th mm' instead of twips,
so we need to transform positions and size from twips to '100th mm'.
Anyway since we don't know in SetGeoAttrToMarked if the new data is
due to a mouse event or by entering a new value in the transormation
dialog or in the side pane, for Impress we need to convert the new
values sent by the dialogs from '100th mm' to twips which are
converted back in SetGeoAttrToMarked.

For performing a uniform scaling when the shape/image is rotated we
need to inform the client about the rotation angle for the selected
graphic object that has been achieved but appending an angle argument
to the graphic selection callback.

Now it is also possible to reverse shapes/images through negative
scaling.

Change-Id: I8a32f3e4b28f36e884a59c59b7e1351e85ef4489
Reviewed-on: https://gerrit.libreoffice.org/64696
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
3 years agocustom widgets: Rename 'stock' to 'action'.
Jan Holesovsky [Wed, 28 Nov 2018 21:21:57 +0000 (28 22:21 +0100)]
custom widgets: Rename 'stock' to 'action'.

If the button has this property, it means it is located in the action
area, not that it is a stock button per se.

Change-Id: Ia57ad24d8cd4ff1d7b74d7ef82da0f352fe3deb3

3 years agocustom widgets: Better way to find out whether to use the 'stock' theming.
Jan Holesovsky [Wed, 28 Nov 2018 21:12:00 +0000 (28 22:12 +0100)]
custom widgets: Better way to find out whether to use the 'stock' theming.

Change-Id: I75ea7b2d407d3acfd3094f17509c89240c48f50a

3 years agolok: Right rotation calculation in case of delta angle
Tamás Zolnai [Fri, 23 Nov 2018 12:01:02 +0000 (23 13:01 +0100)]
lok: Right rotation calculation in case of delta angle

Change-Id: Ia7d0a573c1902fba3fc1e69f425bbf2dc93a1c82

3 years agoAvoid moving the shape by rotation
Tamás Zolnai [Fri, 23 Nov 2018 11:14:49 +0000 (23 12:14 +0100)]
Avoid moving the shape by rotation

The difference between Impress and Writer is the used
unit. We can assume that SID_ATTR_TRANSFORM_ROT_X and
SID_ATTR_TRANSFORM_ROT_Y contains the values in twips.

Change-Id: I44ba9532348200742b2c7c369b89eb2545295684

3 years agoLOK: dialogs: limit listbox/combobox drop-down length
Ashod Nakashian [Fri, 23 Nov 2018 05:00:28 +0000 (23 00:00 -0500)]
LOK: dialogs: limit listbox/combobox drop-down length

Dialogs routed to the LOK client have limited real
estate on the screen because dialogs are rendered
on a canvas. When the listbox drop-down bleeds outside
the dialog area, on the desktop it's no problem, but
in the browser, that requires a larger canvas and
that brings a host of problems.

Here we limit the maximum length of listbox/combobox
drop-down lists to avoid this situation.

This would ideally be configured via ListBoxMaximumLineCount
alas it doesn't work.

Change-Id: I55fff28dbfc59dec36714e221f76cf4160ba1505

3 years agolok: get correct handlers for a single rotated shape
Marco Cecchetti [Thu, 22 Nov 2018 18:40:35 +0000 (22 19:40 +0100)]
lok: get correct handlers for a single rotated shape

Change-Id: I74668ca8079d8d56b8c3f2c4513e2a2ec95872c6

3 years agolok sd: Insert the new shapes in the center of the slide.
Jan Holesovsky [Thu, 22 Nov 2018 11:34:06 +0000 (22 12:34 +0100)]
lok sd: Insert the new shapes in the center of the slide.

Change-Id: I134f86dc0c49ddf26e7a3cfe790c49ab200de9e9

3 years agoLOK: Update failing unit tests
Tamás Zolnai [Fri, 23 Nov 2018 14:59:04 +0000 (23 15:59 +0100)]
LOK: Update failing unit tests

Change-Id: Ib30be297d87fa40c03974e0a97f243812dc488f3

3 years agolok: Insert shapes directly into the document.
Mike Kaganski [Thu, 22 Nov 2018 11:12:07 +0000 (22 12:12 +0100)]
lok: Insert shapes directly into the document.

Change-Id: I182aa395ce0f4e4185c9c85a866dec89499842f9

3 years agoAvoid writing out unneeded data to SVG file in SelectionOnly mode
Tamás Zolnai [Wed, 14 Nov 2018 11:50:55 +0000 (14 12:50 +0100)]
Avoid writing out unneeded data to SVG file in SelectionOnly mode

Change-Id: I6d0ce089be051667e965aff45a63f6b1a8342952

3 years agoadd parameter TransformRotationDeltaAngle to .uno:TransformDialog
Henry Castro [Wed, 14 Nov 2018 02:31:25 +0000 (13 22:31 -0400)]
add parameter TransformRotationDeltaAngle to .uno:TransformDialog

Change-Id: Ib22ba6956afedf1eea055e0ac3a78c53b4ee5861

3 years agoLOK: Fix API for renderShapeSelection
Ashod Nakashian [Tue, 13 Nov 2018 06:24:40 +0000 (13 01:24 -0500)]
LOK: Fix API for renderShapeSelection

Unlike C++, C doesn't allow reference-to-pointer types,
and we do have C code that wouldn't compile with ref-to-ptr.
Had to change to ptr-to-ptr, which is the proper way of
having output arrays.

For the same reason, we cannot use new/delete, rather we
must use malloc/free.

Another (lesser) issue was that we used the renderShapeSelection
API to echo back an array we give it as prefix. This made
the API unecessarily complex (in undocumented ways) and
forced the implementation to both worry about user-data
and managing the input memory. This logic is best moved
to the client and the API simply returns the output data.

Speaking of returning data, the API now returns the size
of the array it allocated and wrote to, so the client
can do a simple check on the return value directly.

Change-Id: Ida216c10d5b37efd1e0861e26b72cabb25c568e6

3 years agoRemove noise from the SVG file exported in SelectionOnly mode
Tamás Zolnai [Mon, 12 Nov 2018 19:04:05 +0000 (12 20:04 +0100)]
Remove noise from the SVG file exported in SelectionOnly mode

Change-Id: Ia09f6ab40c20c17230e8b544987a5d11b7359f2f

3 years agoRemove cout line
Tamás Zolnai [Mon, 12 Nov 2018 17:11:21 +0000 (12 18:11 +0100)]
Remove cout line

Change-Id: Ic1b30a89ae513b3b3ec71853830ef7600801dee0

3 years agosvx: add parameters to .uno:TransformDialog
Henry Castro [Sun, 11 Nov 2018 20:12:31 +0000 (11 16:12 -0400)]
svx: add parameters to .uno:TransformDialog

Change-Id: I6d9e110f48b0f4c6226503d01e10d099cfcb130c

3 years agoIntroduce client-server message for requesting the selected shape as SVG
Tamás Zolnai [Sat, 10 Nov 2018 17:57:26 +0000 (10 18:57 +0100)]
Introduce client-server message for requesting the selected shape as SVG

It works for Impress only now.

Change-Id: I95e3e37ae7df49b567108f6d6467038b715e886d

3 years agouse Image(OUString) instead of Image(Bitmap(OUString))
Noel Grandin [Fri, 7 Dec 2018 08:29:02 +0000 (7 10:29 +0200)]
use Image(OUString) instead of Image(Bitmap(OUString))

which benefits LOOL since we can delay creating the image until
we know the dpi setting of the display we are going to write to.

Achieved by

    perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" )

followed by

    git grep -nP '\bImage\s*\(\s*BitmapEx\s*\('

followed by commenting out the BitmapEx(OUString) constructor and seeing
what needed adjusting.

Change-Id: I3224e11937d720fa484b0d659d25673a9e809267
Reviewed-on: https://gerrit.libreoffice.org/64760
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/64860
Tested-by: Michael Meeks <michael.meeks@collabora.com>
3 years agoBump version to 6.0-17
Andras Timar [Sun, 9 Dec 2018 18:11:57 +0000 (9 19:11 +0100)]
Bump version to 6.0-17

Change-Id: I774513c44417a4a81a3afd157c1a4dbfefa4ba00

3 years agoutility constructor for Image "private:graphicrepository" urls
Noel Grandin [Fri, 7 Dec 2018 12:25:36 +0000 (7 14:25 +0200)]
utility constructor for Image "private:graphicrepository" urls

Change-Id: I118039f4e47818a43da9302ce3550ea800522675
Reviewed-on: https://gerrit.libreoffice.org/64765
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/64803
Tested-by: Michael Meeks <michael.meeks@collabora.com>
3 years agoAdd AnyCompareFactory_get_implementation and...
Tor Lillqvist [Mon, 3 Dec 2018 13:16:48 +0000 (3 15:16 +0200)]
Add AnyCompareFactory_get_implementation and...

... com_sun_star_comp_util_OfficeInstallationDirectories.

Needed when loading a .ott document.

Change-Id: I6074869074b47d2fb679132975520b18659b5c67
(cherry picked from commit f0b83878c2781ab6aa24bd5995155850920f4339)

3 years agoPropagate stock info through slide layouts.
Michael Meeks [Mon, 26 Nov 2018 19:50:38 +0000 (26 19:50 +0000)]
Propagate stock info through slide layouts.

Change-Id: If717db82fe6ab14bbf32225c1f1c95f44954f011
(cherry picked from commit f107161bbd0eb4ee5766f5f983d18b32b929b15c)

3 years agoUse lazy-loading stock Image to simplify framework image lists.
Michael Meeks [Mon, 26 Nov 2018 16:59:42 +0000 (26 16:59 +0000)]
Use lazy-loading stock Image to simplify framework image lists.

Project stock names through XGraphic via origin URL.

Change-Id: Ib445694f7c142a163ef7e7bc0beea39b88b99e14
(cherry picked from commit 77b88eebaadebb626108172e4f2de36c60960051)

3 years agoUse HiDPI scaling to load scaled images.
Michael Meeks [Mon, 26 Nov 2018 14:45:50 +0000 (26 14:45 +0000)]
Use HiDPI scaling to load scaled images.

We render these at apparently the same pixel size as normal images,
but the underlying canvas is larger so these then end up pixel-matching
the true underlying grid.

Change-Id: Ic4b749127e9c81da78d06b34d9f88c5635dc64b9
(cherry picked from commit 1799b122ef79432c9ce4e419bce660797c01efa4)

3 years agoAdd explicit API scaling via ImageTree API.
Michael Meeks [Mon, 26 Nov 2018 14:13:29 +0000 (26 14:13 +0000)]
Add explicit API scaling via ImageTree API.

Also add image scale to in-memory cache lookup.

Change-Id: I1e84b922d4a9ab2f1723c5cb8a72f295c6940504
(cherry picked from commit 59b3cdbc27b65fb3e72dd0b3b2565851bc8f772c)

3 years agoPreserve stock images until render time.
Michael Meeks [Mon, 26 Nov 2018 14:08:13 +0000 (26 14:08 +0000)]
Preserve stock images until render time.

This allows us to choose to render HiDPI images at the right time,
when we have the DPI of the device to render to.

The first step in a better, and more industry standard way of
improving our UI for HiDPI via rendering level scaling that should
retain a consistent look across the app with many fewer changes.

Change-Id: I36681f3242cb650de4f0b2d0fcdffbe5618e30fc
(cherry picked from commit e42c6d6903ab804235671d51ae3a05d1627e2574)

3 years agoAnti-alias toolbar button drop-downs.
Michael Meeks [Fri, 23 Nov 2018 02:14:00 +0000 (23 02:14 +0000)]
Anti-alias toolbar button drop-downs.

Change-Id: Id4eed12f3d4a32b71d00b99e6e82ca7cefb3f8ec
(cherry picked from commit 121a30224bbbe85b559b0e4559c14e145101511f)

3 years agosd: support inserting background image from file via .uno:SelectBackground
Ashod Nakashian [Thu, 13 Sep 2018 00:03:11 +0000 (12 20:03 -0400)]
sd: support inserting background image from file via .uno:SelectBackground

The UNO command always prompted the user via file open dialog.
This change allows for passing the filename as an argument
to allow for inserting slide background programatically.

Also, hide the Insert Image button in the sidebar
since we can't use that (just yet), because
it invokes .uno:SelectBackground directly. We would
need to send LOOL a notification to invoke this on
its own end to first prompt the user for a file.

Change-Id: I20c0e33d66f8bcd72a6388e39c4ac92e64978f45
(cherry picked from commit 2118143bdd246921439ba9e835207585203dd45f)

3 years agoJoin the thread only if launch succeeded.
Michael Meeks [Fri, 14 Sep 2018 10:53:39 +0000 (14 11:53 +0100)]
Join the thread only if launch succeeded.

Change-Id: Idee779cea587e11f6d0f7902182c9394e73d46eb
Reviewed-on: https://gerrit.libreoffice.org/60488
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/60544
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 5f3a3de26fca5e3e37e4a08940fa4bf9da5e5ecc)
(cherry picked from commit c595e7c60b7040510a9541e8fb8535db60a356d3)

3 years agoEnsure fastparser thread is joined in case of exceptions.
Michael Meeks [Tue, 11 Sep 2018 21:28:08 +0000 (11 22:28 +0100)]
Ensure fastparser thread is joined in case of exceptions.

Change-Id: Ie0fb21776514a9a67e9fdff2ae856392cd711adb
Reviewed-on: https://gerrit.libreoffice.org/60542
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit d06a8ce1434c1dcb45770e08395443771f57f1e9)
(cherry picked from commit 8325f20088c812fedbb94d8fd421c652f6d73db9)

3 years agoloplugin:useuniqueptr in CustomAnimationDialog
Noel Grandin [Thu, 21 Jun 2018 13:34:16 +0000 (21 15:34 +0200)]
loplugin:useuniqueptr in CustomAnimationDialog

Reviewed-on: https://gerrit.libreoffice.org/56328
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit e5dfdbcc2084bfdb213afbe03d00136e93d5c4d2)

Change-Id: Ic2e93c1493159c9602bd68b409052117766dcc02
(cherry picked from commit 130b9aa636200db1d349c1376f8166657f680c7c)

3 years agosd: modernize some loops
Ashod Nakashian [Fri, 14 Sep 2018 02:12:00 +0000 (13 22:12 -0400)]
sd: modernize some loops

Change-Id: Ic86960ce2f690bebc51c9120053bdd50232f0358
(cherry picked from commit beb738eb8688ddaf133a0832328073e3e2b78757)

3 years agoViewShellBase const correctness
Ashod Nakashian [Sun, 5 Aug 2018 03:38:44 +0000 (4 23:38 -0400)]
ViewShellBase const correctness

Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac
(cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28)

3 years agoconvert to range for
Tomaž Vajngerl [Fri, 30 Nov 2018 10:48:50 +0000 (30 11:48 +0100)]
convert to range for

Change-Id: I3558010129eaafdab94ca3f8a63abeda32318fbb
Reviewed-on: https://gerrit.libreoffice.org/64336
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit bb8c2b1cbf7a9eb56b1515f60a2aadbef24199a2)

3 years agotest signing with certificate chain and private key in PEM format
Tomaž Vajngerl [Thu, 29 Nov 2018 21:09:07 +0000 (29 22:09 +0100)]
test signing with certificate chain and private key in PEM format

Change-Id: If3b121e44ceec8be668820a7e8a9e35c15d547ff
Reviewed-on: https://gerrit.libreoffice.org/64295
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 07e586574d5f0255ade1fe4305d56730dd7ae4c7)

3 years agoxmlsecurity: clean-up code a bit
Tomaž Vajngerl [Thu, 29 Nov 2018 21:06:02 +0000 (29 22:06 +0100)]
xmlsecurity: clean-up code a bit

Reviewed-on: https://gerrit.libreoffice.org/64294
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 40d52cfe3b64e6bac035caed825486546bba5280)

Change-Id: I4a43f1f33f73919f56150310e7d05244d81b7510

3 years agolokit: disable triggering of GUI when changing a signed doc
Tomaž Vajngerl [Thu, 29 Nov 2018 20:58:57 +0000 (29 21:58 +0100)]
lokit: disable triggering of GUI when changing a signed doc

When a signed document is changed and saved, the dialog pops up
on the GUI to warn that the signature will be removed. When saving
over the lokit this dialog isn't shown and assumes that we don't
want to save (throws an exception) which means we can't save the
document ever. This changes the behavior so that we allow removal
of the signature and saving can proceed.

Reviewed-on: https://gerrit.libreoffice.org/64293
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit c2ee336288dcee103f297a55287fbca596a6c7a1)

Change-Id: I52e4a53f0cd3a326c767daee6301a78122af09d4

3 years agoAdd SolarMutexGuard where needed
Tomaž Vajngerl [Thu, 29 Nov 2018 20:53:48 +0000 (29 21:53 +0100)]
Add SolarMutexGuard where needed

When triggering rechecking of signature status, an assert fails and
brings down the program because we don't hold a SolarMutex. The
rechecking of signature status needs to broadcasts.

Change-Id: Ib500b06d2e191465df1e0da2097ddb1b6b06725a
Reviewed-on: https://gerrit.libreoffice.org/64292
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d7a88b902af983145b196990949e89420e5bc4cf)

3 years agolokit: convert PEM certificate to DER if it is detected as such
Tomaž Vajngerl [Thu, 29 Nov 2018 20:52:26 +0000 (29 21:52 +0100)]
lokit: convert PEM certificate to DER if it is detected as such

Change-Id: I1ae105067c109a32f4acc34749b425d9e4e26514
Reviewed-on: https://gerrit.libreoffice.org/64291
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d69edca3e004ab8669b3363b4755da8bb42f62fc)

3 years agoremove printf
Tomaž Vajngerl [Wed, 14 Nov 2018 13:59:35 +0000 (14 14:59 +0100)]
remove printf

Change-Id: I00394e7c9880bd96a4f68b6695f1b85fa95689b4
Reviewed-on: https://gerrit.libreoffice.org/63442
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 1874d71576d46e28b79fe2df87f379a28767dccc)

3 years agoMake use of SwView::InsertGraphicDlg() in the mobile app case work
Tor Lillqvist [Thu, 29 Nov 2018 13:04:06 +0000 (29 15:04 +0200)]
Make use of SwView::InsertGraphicDlg() in the mobile app case work

Despite the name of the function, when inserting an image that we
already know the file name for, we don't actually need to invoke any
interactive file dialog (file picker). We don't build any file picker
for non-desktop platforms anyway, so make sure this code does not
crash in trying to access a such.

Change-Id: I91cc8c4d9dac26e66f4f852c3d84f5c778c90644

3 years agoWe need svt, too, in the iOS app, for the image insertion feature
Tor Lillqvist [Thu, 29 Nov 2018 13:33:31 +0000 (29 15:33 +0200)]
We need svt, too, in the iOS app, for the image insertion feature

Change-Id: I5a656ab159eec44a537fc22da03763913372bc8f

3 years agoDo not validate SSL cert in LOK case
Andras Timar [Sun, 25 Nov 2018 17:15:24 +0000 (25 18:15 +0100)]
Do not validate SSL cert in LOK case

Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test environments.

Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878
Reviewed-on: https://gerrit.libreoffice.org/63994
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agotdf#90333 Dictionaries Path Cannot Be Changed
Caolán McNamara [Tue, 27 Nov 2018 14:02:12 +0000 (27 14:02 +0000)]
tdf#90333 Dictionaries Path Cannot Be Changed

PathSettings::impl_storePath wants to be able to nil the Dictionaries
path in the old copy of properties

Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f
Reviewed-on: https://gerrit.libreoffice.org/64115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit f913bdf712b9e03506b1278e1142283af92125b1)

3 years agoPrepare to bundle the Liberation fonts with the iOS app
Tor Lillqvist [Tue, 27 Nov 2018 14:10:25 +0000 (27 16:10 +0200)]
Prepare to bundle the Liberation fonts with the iOS app

The way the iOS app is built (over in the online repo), any
"resources" to be included need to be copied into the
workdir/CustomTarget/ios folder.

Change-Id: I0104df73326a8ccfa86235ea23b5900f9d2554b5

3 years agotdf#120920 Assertion failure when switching slide layouts with text entered
Noel Grandin [Wed, 31 Oct 2018 11:55:35 +0000 (31 13:55 +0200)]
tdf#120920 Assertion failure when switching slide layouts with text entered

no need to call StartListening here, has already been done inside
SdPage::CreatePresObj

Change-Id: I590e51f7afeb336d562d3ad9ccc123f542897aae
Reviewed-on: https://gerrit.libreoffice.org/62689
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit ef9bfdfe4f4ef75ca65547face0db09af7352314)
Reviewed-on: https://gerrit.libreoffice.org/64082
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
3 years agoFill buildid in versionrc for iOS with the git HEAD hash
Tor Lillqvist [Mon, 26 Nov 2018 22:41:04 +0000 (27 00:41 +0200)]
Fill buildid in versionrc for iOS with the git HEAD hash

Previously it tried to use a BUILDID Make variable that did not exist.

Change-Id: Idaf8076fac0a39fc3805c4445de2b41b55044c1a

3 years agoBump version to 6.0-16cp-6.0-16
Andras Timar [Mon, 26 Nov 2018 10:53:35 +0000 (26 11:53 +0100)]
Bump version to 6.0-16

Change-Id: I57dccc57e433aba964da95dcb2b20a5ba3ca34b2

3 years agoPut text label outside of the pie if..
Tamas Bunth [Mon, 26 Nov 2018 06:19:41 +0000 (26 07:19 +0100)]
Put text label outside of the pie if..

performLabelBestFitInnerPlacement fails.

Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305
Reviewed-on: https://gerrit.libreoffice.org/64015
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 3339c730f8c9a6088a2e8b335185f1bf0b232216)
Reviewed-on: https://gerrit.libreoffice.org/64034
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agomysqlc: next() should move cursor from Last
Tamas Bunth [Fri, 23 Nov 2018 17:31:37 +0000 (23 18:31 +0100)]
mysqlc: next() should move cursor from Last

XResultSet::next() should move cursor when called while cursor is on the
last position. It is not documented, but older versions of the mysqlc
extension are implemented that way. The cursor goes to the so called
afterlast position.

Even so, the next() call on the last position should return false.

Change-Id: I0fd145c920077151364a6a8c12e05290496b99c8
Reviewed-on: https://gerrit.libreoffice.org/63895
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/64017
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agoBuild mysql_jdbc library even when building..
Tamas Bunth [Fri, 23 Nov 2018 16:49:54 +0000 (23 17:49 +0100)]
Build mysql_jdbc library even when building..

.. without java

Change-Id: Id44ef2d94992423a12b32234822e8ed3f5a48299
Reviewed-on: https://gerrit.libreoffice.org/63889
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/64019
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agoUse the correct DPI scaling factor in LibreOfficeKit for iOS, too
Tor Lillqvist [Fri, 23 Nov 2018 15:36:33 +0000 (23 17:36 +0200)]
Use the correct DPI scaling factor in LibreOfficeKit for iOS, too

Fixes the rendering of spreadsheets in the iOS app. (The cell area was
rendered at half the scale of the row and column headers.)

(In this branch I don't bother updating the comments to mention
CoreGraphics in addition to cairo.)

Change-Id: Ife99c6a2d58e592cfea3b4ed1ab09c19fba77e72

3 years agoRe-factor internal filter logic, and impl. preload properly.
Michael Meeks [Wed, 21 Nov 2018 18:53:47 +0000 (21 18:53 +0000)]
Re-factor internal filter logic, and impl. preload properly.

Change-Id: I4c55ceb19d5db2c1e4756901d0d8b14878641a99
Reviewed-on: https://gerrit.libreoffice.org/63760
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
3 years agotdf#108022, don't overwrite chart export information
Markus Mohrhard [Sun, 18 Nov 2018 21:00:23 +0000 (18 22:00 +0100)]
tdf#108022, don't overwrite chart export information

Change-Id: I47d8a817022829c8cada614469303e440f377299
Reviewed-on: https://gerrit.libreoffice.org/63536
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 9ccdf4d8abf6ec6612c88ab65be25eb6be89b455)
Reviewed-on: https://gerrit.libreoffice.org/63540
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 21467c1c0fea676a33c7b7e75648947efea18fcb)

3 years agotdf#104579, if no data point shape props are set take the series props
Markus Mohrhard [Sun, 18 Nov 2018 23:13:36 +0000 (19 00:13 +0100)]
tdf#104579, if no data point shape props are set take the series props

Change-Id: Ia2c0d6b05385a0f3900e20ef807b869e4098654c
Reviewed-on: https://gerrit.libreoffice.org/63541
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit afe5e1f8de0a25364c8c98b453cfe831330c4eed)
Reviewed-on: https://gerrit.libreoffice.org/63544
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 3633414c485b39a1eb824bae0dd2002976a4dc6e)

3 years agotdf#102186, don't overwrite the deleted flag
Markus Mohrhard [Sun, 18 Nov 2018 03:37:02 +0000 (18 04:37 +0100)]
tdf#102186, don't overwrite the deleted flag

Change-Id: I3cc69a0baebc55ad52b64960657e9daa4be8f39d
Reviewed-on: https://gerrit.libreoffice.org/63510
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 4bd2e57653ce22044ab984b06c84f22ef287cecf)
Reviewed-on: https://gerrit.libreoffice.org/63513
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 47c05f6e1bb4ec77f242001e4c2d297af48f511e)

3 years agoBuilding of Library_mysql does not depend on Java
Andras Timar [Tue, 20 Nov 2018 17:58:46 +0000 (20 18:58 +0100)]
Building of Library_mysql does not depend on Java

Change-Id: Ic29caca84e18122da86940d518a2cb9457ebe007

3 years agoSwiss Standard German: replace 'ß' in German translation with 'ss'
Tor Lillqvist [Thu, 15 Nov 2018 22:54:14 +0000 (16 00:54 +0200)]
Swiss Standard German: replace 'ß' in German translation with 'ss'

In this branch, for iOS only.

Change-Id: I2af12394648ddad352f24c71581be0f9bf5e3d70

3 years agoBe less eager to use a fallback in SfxViewShell::SetLOKLanguageTag()
Tor Lillqvist [Thu, 15 Nov 2018 22:46:51 +0000 (16 00:46 +0200)]
Be less eager to use a fallback in SfxViewShell::SetLOKLanguageTag()

If the fallback language tag based on available localisations would
have the same language as the original Bcp47 tag string, use a tag
based on the original.

For example, if the user locale is 'de-CH', the localisation for plain
'de' will be used automatically anyway, without making the LOK
language tag 'de' which would actually end up being stored as 'de-DE'
and thus be misleading.

We will need to know that it's the 'de-CH' locale we are actually
working with when handling Swiss German translations by replacing 'ß'
characters in a generic German translation with 'ss'.

In this branch, do this only for iOS.

Change-Id: I5636d89e715d4881463881e19d4e77af93a0ecaa

3 years agoapparently libmysqllo.so is built only when Java is enabled
Andras Timar [Fri, 16 Nov 2018 07:39:47 +0000 (16 08:39 +0100)]
apparently libmysqllo.so is built only when Java is enabled

Change-Id: I14c1a3650c5933f0435936afc82438a53a34bba1

3 years agoDo include the message catalogs, if any, in program/resource for iOS
Tor Lillqvist [Wed, 14 Nov 2018 17:44:06 +0000 (14 19:44 +0200)]
Do include the message catalogs, if any, in program/resource for iOS

Change-Id: I75f3e3d9873e2612852a3a43476f6f453732e457

3 years agoDo produce message catalogs for sw, too, for iOS
Tor Lillqvist [Wed, 14 Nov 2018 17:43:47 +0000 (14 19:43 +0200)]
Do produce message catalogs for sw, too, for iOS

Change-Id: Ibeed019f411315904de96b2d6da616b7588c0323

3 years agoWe need share/liblangtag, too
Tor Lillqvist [Mon, 12 Nov 2018 18:06:20 +0000 (12 20:06 +0200)]
We need share/liblangtag, too

Otherwise i18nlantag works weirdly.

Change-Id: Ic5bf2007e586e6bb53a9e89782c2b05f73e348e3

3 years agoDon't bother setting LC_ALL, LC_CTYPE, and LANG on iOS
Tor Lillqvist [Fri, 9 Nov 2018 23:16:22 +0000 (10 01:16 +0200)]
Don't bother setting LC_ALL, LC_CTYPE, and LANG on iOS

An iOS app might itself, for testing and debugging purposes, look for
LANG in the environment (passed to by the developer in Xcode; the OS
does not set such an environment variable). It is confusing if that
then gets (re-)set during the execution of core code.

(cherry picked from commit f1801432abaaa6c6137d62319d855b6a3599e182)

Change-Id: I9dcf44090aed84b55fd4240bda2562026cd8dacb

3 years agocustom widgets: Use only with LibreOfficeKit.
Jan Holesovsky [Fri, 9 Nov 2018 18:20:31 +0000 (9 19:20 +0100)]
custom widgets: Use only with LibreOfficeKit.

Change-Id: I9f8f25ee72e93fdf575312b6b0c5d32be9ea45cc
Reviewed-on: https://gerrit.libreoffice.org/63209
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
3 years agocall System.runFinalizersOnExit by reflection, since it was removed in jdk11
Fridrich Štrba [Thu, 12 Jul 2018 09:57:07 +0000 (12 11:57 +0200)]
call System.runFinalizersOnExit by reflection, since it was removed in jdk11

Change-Id: I542c87bc1de21727a035cc6ac3b3e20c0ccfb5f7
Reviewed-on: https://gerrit.libreoffice.org/63208
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
3 years agoBump version to 6.0-15cp-6.0-15
Andras Timar [Fri, 9 Nov 2018 09:10:51 +0000 (9 10:10 +0100)]
Bump version to 6.0-15

Change-Id: Ic07aa7297c976b122ba11c60348e1ac18a65b7a0

3 years agoRevert "Support to sign a document with a specified signature"
Miklos Vajna [Fri, 9 Nov 2018 09:08:33 +0000 (9 10:08 +0100)]
Revert "Support to sign a document with a specified signature"

This reverts commit cc145029e896b8e65443898f65807a8c5414e0d2 partially,
the unwanted helpcontent2 part.

Change-Id: I0d256c6b8a69aabdf9cbc33e9d0a82f669875705

3 years agomysqlc: fix return value of XResultSet::next
Tamas Bunth [Thu, 8 Nov 2018 17:48:54 +0000 (8 18:48 +0100)]
mysqlc: fix return value of XResultSet::next

Change-Id: I59e4803a5d9b01062eb0eaca0bf65d28298bd3e4
Reviewed-on: https://gerrit.libreoffice.org/63122
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
3 years agoLOK: don't emit redline comments
Ashod Nakashian [Thu, 8 Nov 2018 16:02:26 +0000 (8 11:02 -0500)]
LOK: don't emit redline comments

Change tracking can be quite numerous. Showing the
markers (and their comments" as comment-boxes is
sensible where there is limited change in a doc.

However with extensively modified doc, this becomes
overwhelming both in terms of browser load and
editing performance. As such, we disable them
as they don't add much value. The user can still
access them from the Track Changes > Manage menu.

Use a rather nasty env. var hack to propagate this
setting from WSD for now.

Change-Id: I3f964816b4a10f565012b273added8a8413cd309
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
3 years agoNo updateSettings() in AquaSalGraphics
Tor Lillqvist [Thu, 8 Nov 2018 15:38:34 +0000 (8 17:38 +0200)]
No updateSettings() in AquaSalGraphics

Just ifdef out the call of it for now. This is a temporary solution,
we presumably do want dialogs to be "themed" appropriately for the iOS
app.

Change-Id: I0b14bd59ecc13037c9ff2a286405a5020081f1d5
Reviewed-on: https://gerrit.libreoffice.org/63112
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
3 years agoDon't build the CustomWidgetDraw code for iOS for now
Tor Lillqvist [Thu, 8 Nov 2018 15:37:47 +0000 (8 17:37 +0200)]
Don't build the CustomWidgetDraw code for iOS for now

Change-Id: I91a263aa68b8f84d975d42b2b48f858137370986
Reviewed-on: https://gerrit.libreoffice.org/63111
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
3 years agoRevert "CppunitTest_desktop_lib: disable failing test"
Miklos Vajna [Thu, 8 Nov 2018 15:54:58 +0000 (8 16:54 +0100)]
Revert "CppunitTest_desktop_lib: disable failing test"

This reverts commit 6c7e262fa9f11e160e5854231421710eec0ddee3, now that I
found the missing backport.

3 years agolibxmlsec: drop not needed xmlsec1-customkeymanage.patch.1
Miklos Vajna [Mon, 4 Jun 2018 19:25:38 +0000 (4 21:25 +0200)]
libxmlsec: drop not needed xmlsec1-customkeymanage.patch.1

This was added in commit ebd1b95bb5f9235d1dba1b840fd746c9b53320d2
(INTEGRATION: CWS xmlsec08 (1.1.2); FILE ADDED; 2005-03-10) without any
real commit message to explain why this is necessary.

system-xmlsec (not containing this patch) works fine for our XML signing
purposes with software certificates, and just recently I learned that
even hardware-based certificates work fine without this patch, so it can
go away.

I assume this was a refactor to allow some new feature as a next step,
but that feature was never implemented.

Reviewed-on: https://gerrit.libreoffice.org/55296
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit f06004c03bbd076767a570180b7fc239064713e6)

Conflicts:
external/xmlsec/UnpackedTarball_xmlsec.mk

Change-Id: I31639230483cd34b14b35fd41b4fcd8284476138

3 years agoCppunitTest_desktop_lib: disable failing test
Miklos Vajna [Thu, 8 Nov 2018 15:12:23 +0000 (8 16:12 +0100)]
CppunitTest_desktop_lib: disable failing test

Until I find out why that happens.

Change-Id: Ie10e402d29280b1a770dbc86cfa794645851fb05