LibreOffice.git
5 years agone plus faire la détection automatioque une 2e foisprivate/lmamane/for-julien2412
Lionel Elie Mamane [Sun, 25 Jun 2017 16:02:01 +0000 (25 18:02 +0200)]
ne plus faire la détection automatioque une 2e fois

et lui faire confiance, i.e. ne plus écraser IBM_850
TODO: vérifier le cas base, où ce ne serait pas une 2e fois et il faudrait encore la faire

Change-Id: I401a93dce8ddf100031f1f04872df47ef453eb63

5 years agoutiliser la détection automatique
Lionel Elie Mamane [Sun, 25 Jun 2017 15:49:28 +0000 (25 17:49 +0200)]
utiliser la détection automatique

Change-Id: I355396794a883e131698d56046b9226095dd8414

5 years agodétection automatique
Lionel Elie Mamane [Sun, 25 Jun 2017 15:21:45 +0000 (25 17:21 +0200)]
détection automatique

Change-Id: Ic6b940b4bd5f3c181b022acffb211b719b99710f

5 years agojanitorial; not useful; is actually used below
Lionel Elie Mamane [Sat, 24 Jun 2017 13:09:19 +0000 (24 15:09 +0200)]
janitorial; not useful; is actually used below

Change-Id: I87484b04d9f3feecdac3c53bc7eb3a5ec05e7af7

5 years agoremove unused #include
Lionel Elie Mamane [Mon, 6 Mar 2017 16:49:36 +0000 (6 17:49 +0100)]
remove unused #include

Change-Id: I97111309432359968e890aacd0a285d068991307

5 years agotdf#40575 remove obsolete MAX_DAYS check
Lionel Elie Mamane [Mon, 6 Mar 2017 16:49:17 +0000 (6 17:49 +0100)]
tdf#40575 remove obsolete MAX_DAYS check

Change-Id: Ifccf3a1fe27011a8e72464bf76cadcf16f5f5fa7

5 years agorecognise PostgreSQL interval
Lionel Elie Mamane [Fri, 6 Mar 2015 10:43:03 +0000 (6 11:43 +0100)]
recognise PostgreSQL interval

Change-Id: I3ce46215d3ae8043052b3291b7e570a302bba474

5 years agoLEM TODO
Lionel Elie Mamane [Fri, 26 Oct 2012 15:32:26 +0000 (26 17:32 +0200)]
LEM TODO

Change-Id: I044d70251f675c504a77bedc281243043cf29742

5 years agoLEM TODO note
Lionel Elie Mamane [Wed, 30 Nov 2011 14:55:07 +0000 (30 15:55 +0100)]
LEM TODO note

5 years agoLEM TODO note
Lionel Elie Mamane [Sun, 20 Nov 2011 16:37:39 +0000 (20 17:37 +0100)]
LEM TODO note

5 years agomaximal debugging information
Lionel Elie Mamane [Wed, 23 Nov 2011 20:34:18 +0000 (23 21:34 +0100)]
maximal debugging information

5 years agoLet Debian aclocal boost macros take effect
Lionel Elie Mamane [Mon, 16 Jun 2014 14:08:00 +0000 (16 16:08 +0200)]
Let Debian aclocal boost macros take effect

(they are fixed for multiarch)

Change-Id: I28a54b8b88b2a217249bcd4e8bcabbdd96ca7d12

5 years agotdf#108732 ListBox: in absence of a field, treat data as string
Lionel Elie Mamane [Sat, 24 Jun 2017 13:10:59 +0000 (24 15:10 +0200)]
tdf#108732 ListBox: in absence of a field, treat data as string

so that one meaningfully compare it; default is DataType::OTHER,
which is not comparable

Change-Id: Ifc1e1c9b801f45d0a95a83d30cc205b91e647880

5 years agoResolves: tdf#108292 WalkAndMatchElements: really limit the match
Eike Rathke [Wed, 21 Jun 2017 21:42:25 +0000 (21 23:42 +0200)]
Resolves: tdf#108292 WalkAndMatchElements: really limit the match

... to the columns queried, not just when entering an mdds node. Otherwise it
would return an unexpected index, plus bailing out early spares unnecessary
comparisons for the rest of a node block.

Regression of

    commit 3fed166279377f7ad702b8911899243b8adff3bf
    Date:   Fri Aug 16 16:29:38 2013 +0200

that started to use

    commit 7334f8db6f6004d48e2dbf014f27878a7ae21eb1
    Date:   Fri Aug 16 16:29:27 2013 +0200

with its bad implementation.

Just that VLOOKUP on a matrix with a larger block of same typed data as the
query *and* a match in an excess column seems to be rare..

Change-Id: Ia4ef3fd56490de82910d5aa13a84be2de851f9b0
(cherry picked from commit d3b77628efc72d857c63c8fb91d7ed2b499ac860)
Reviewed-on: https://gerrit.libreoffice.org/39082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agotdf#93968 bullet char style preview is unreadable, cause uses opensymbol
Caolán McNamara [Tue, 20 Jun 2017 10:44:47 +0000 (20 11:44 +0100)]
tdf#93968 bullet char style preview is unreadable, cause uses opensymbol

Change-Id: I1bd0a0e85c9d956184680d7e15709b3a7b590c30
Reviewed-on: https://gerrit.libreoffice.org/39010
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/39053
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agoResolves: tdf#108705 remove grabs on widget before destroying it
Caolán McNamara [Fri, 23 Jun 2017 11:48:12 +0000 (23 12:48 +0100)]
Resolves: tdf#108705 remove grabs on widget before destroying it

Change-Id: If02a0b4340788db638c74b98e855258145643452
Reviewed-on: https://gerrit.libreoffice.org/39167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#101821 sw: fix layout footnote use-after-free in SwRootFrame
Michael Stahl [Thu, 22 Jun 2017 08:39:36 +0000 (22 10:39 +0200)]
tdf#101821 sw: fix layout footnote use-after-free in SwRootFrame

The ClearSwLayouterEntries() accesses anchored objects and if they are
anchored in footnotes then RemoveFootnotes() has already deleted them.

(regression from 962d0500c4debaef43e5f146e47e08c66d851562)

Invalid write of size 1
   at 0x4143CCB3: SwAnchoredObject::SetTmpConsiderWrapInfluence(bool) (anchoredobject.cxx:739)
   by 0x414D8A21: SwObjsMarkedAsTmpConsiderWrapInfluence::Clear() (objstmpconsiderwrapinfl.cxx:58)
   by 0x414C943E: SwLayouter::ClearObjsTmpConsiderWrapInfluence(SwDoc const&) (layouter.cxx:401)
   by 0x411DBE57: sw::DocumentLayoutManager::ClearSwLayouterEntries() (DocumentLayoutManager.cxx:504)
   by 0x414D05D9: SwRootFrame::DestroyImpl() (newfrm.cxx:594)
   by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389)
   by 0x419E8171: std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (shared_ptr_base.h:464)
   by 0x40EB6DB5: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:150)
   by 0x40EB5E76: std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (shared_ptr_base.h:662)
   by 0x419E65F9: std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (shared_ptr_base.h:928)
   by 0x419E6615: std::shared_ptr<SwRootFrame>::~shared_ptr() (shared_ptr.h:93)
   by 0x419E619D: SwViewShell::~SwViewShell() (vnew.cxx:285)
  Address 0x5feb6eee is 334 bytes inside a block of size 488 free'd
   at 0x4C2F21A: operator delete(void*) (vg_replace_malloc.c:576)
   by 0x41488962: SwFlyAtContentFrame::~SwFlyAtContentFrame() (flyfrms.hxx:134)
   by 0x41535AFC: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:391)
   by 0x415360BD: SwLayoutFrame::DestroyImpl() (ssfrm.cxx:477)
   by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389)
   by 0x414A2FF4: sw_RemoveFootnotes(SwFootnoteBossFrame*, bool, bool) (ftnfrm.cxx:852)
   by 0x414A3104: sw_RemoveFootnotes(SwFootnoteBossFrame*, bool, bool) (ftnfrm.cxx:874)
   by 0x414A321A: SwRootFrame::RemoveFootnotes(SwPageFrame*, bool, bool) (ftnfrm.cxx:897)
   by 0x414D0558: SwRootFrame::DestroyImpl() (newfrm.cxx:585)
   by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389)
   by 0x419E8171: std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (shared_ptr_base.h:464)
   by 0x40EB6DB5: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:150)
   by 0x40EB5E76: std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (shared_ptr_base.h:662)
   by 0x419E65F9: std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (shared_ptr_base.h:928)
   by 0x419E6615: std::shared_ptr<SwRootFrame>::~shared_ptr() (shared_ptr.h:93)
   by 0x419E619D: SwViewShell::~SwViewShell() (vnew.cxx:285)

Change-Id: I147f46d49c90de46189ad34feed66c289adddc15
(cherry picked from commit c7782c7c27d85866872cc24a618df02504ff12ca)
Reviewed-on: https://gerrit.libreoffice.org/39106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
5 years agoofz: use our own OString instead
Caolán McNamara [Fri, 12 May 2017 11:00:44 +0000 (12 12:00 +0100)]
ofz: use our own OString instead

Reviewed-on: https://gerrit.libreoffice.org/37535
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit b5302844af49cc25c0720f3c2dccbdc0380d3b50)

Change-Id: I583a95aea0b29878bf4749a8cb2bb684da6da1e5

ofz: use OString instead of bare char*

Change-Id: I2f7bfbd62c0a5477f0cbb38e86684db4fdb9c37f
Reviewed-on: https://gerrit.libreoffice.org/38958
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agoResolves: rhbz#1454693 segv if tiled rendering is interrupted
Caolán McNamara [Fri, 16 Jun 2017 14:30:10 +0000 (16 15:30 +0100)]
Resolves: rhbz#1454693 segv if tiled rendering is interrupted

Change-Id: I1131f246c43806adb8a83f6eeafca2b734851a0e
Reviewed-on: https://gerrit.libreoffice.org/38890
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#107684 DOCX export: fix duplicated <w:outlineLvl> element for styles
Miklos Vajna [Mon, 29 May 2017 09:25:58 +0000 (29 11:25 +0200)]
tdf#107684 DOCX export: fix duplicated <w:outlineLvl> element for styles

Next to the existing OutlineNumbering() (which is only used for styles),
commit fd2d14d5543c82eb875e720c98b51518699a8fbc (Implement DOCX export
of paragraph outline level, 2013-10-04) added ParaOutlineLevel() to the
attribute output class that also wrote the outline level of a paragraph
(style), but worked for the cases when the style was imported by
writerfilter as well.

As a side-effect styles imported by xmloff now have their outline level
property handled twice, leading to duplicated elements.

Fix the problem by only writing <w:outlineLvl> in ParaOutlineLevel():
it covers both use-cases, so no need to do anything in
OutlineNumbering().

Change-Id: Ic982dd70a00609cdfc3744a8ab69aaa828410fd0
Reviewed-on: https://gerrit.libreoffice.org/38132
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit fe13c249c8964355e39869a357c393f3208b6def)
Reviewed-on: https://gerrit.libreoffice.org/38637
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agoResolves: tdf#107438 write <text:sender-initials> for fields
Eike Rathke [Tue, 20 Jun 2017 10:59:23 +0000 (20 12:59 +0200)]
Resolves: tdf#107438 write <text:sender-initials> for fields

Only in <office:annotation> context write <loext:sender-initials>

Broken since

    commit 5f8476c00f482ab5c8707de2ebdcd41faa4057fc
    Date:   Fri Dec 13 23:21:46 2013 +0100

and

    commit 49f9694e34d07468cff4a7e4de332f11be3e0dd8
    Date:   Fri Dec 13 23:30:34 2013 +0100

Change-Id: I48b146b779878bf0faa5830a721559d8e864dd33
(cherry picked from commit 29f250c428953750ce89dec7ee961723478609c1)
Reviewed-on: https://gerrit.libreoffice.org/39012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agoexpat: upgrade to release 2.2.1
Michael Stahl [Wed, 21 Jun 2017 20:28:49 +0000 (21 22:28 +0200)]
expat: upgrade to release 2.2.1

fixes CVE-2017-9233 and CVE-2016-9063

Change-Id: Iee70d1265ff4e9dd4d0bff9602bd70b85d6b83f3
Reviewed-on: https://gerrit.libreoffice.org/39078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit fb1b69a78742373f5652e731d0f32da1d159422c)
Reviewed-on: https://gerrit.libreoffice.org/39094
Tested-by: Michael Stahl <mstahl@redhat.com>
5 years agoofz#2287 check multiply
Caolán McNamara [Sat, 17 Jun 2017 20:16:34 +0000 (17 21:16 +0100)]
ofz#2287 check multiply

Change-Id: Ibc4c93ac1f5686a476b5e303347dc951daa58e33
Reviewed-on: https://gerrit.libreoffice.org/38911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agoofz#2332 fix dangling pCObj
Caolán McNamara [Wed, 21 Jun 2017 08:16:33 +0000 (21 09:16 +0100)]
ofz#2332 fix dangling pCObj

Change-Id: Ifa62b1ce2aefa939cfceb2e110d126b785cb6e26
Reviewed-on: https://gerrit.libreoffice.org/39035
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#80671: mediawiki, no superscript tags allowed in footnotes
Julien Nabet [Sun, 11 Jun 2017 19:57:14 +0000 (11 21:57 +0200)]
tdf#80671: mediawiki, no superscript tags allowed in footnotes

Change-Id: I54c2cc0fc6b2a9c631fc83f59c2204dd5e374d2c
Reviewed-on: https://gerrit.libreoffice.org/38666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 6a24160894e91c007d4a2f8ef193eed670909ea5)
Reviewed-on: https://gerrit.libreoffice.org/38669
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agotdf#99680 modified clipping for PDF export
Vasily Melenchuk [Thu, 25 May 2017 10:44:52 +0000 (25 13:44 +0300)]
tdf#99680 modified clipping for PDF export

If clipping is requested, but no clipping region is defined,
clipping is ignored.

This squashes the following 3 commits:

Reviewed-on: https://gerrit.libreoffice.org/38021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-on: https://gerrit.libreoffice.org/38403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/38694
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-on: https://gerrit.libreoffice.org/38825
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit f6726209329fefe9decca8fda8e136b8472a95a2)

Conflicts:
vcl/qa/cppunit/pdfexport/pdfexport.cxx
no pdf unit tests on -5-3, so dropping those pieces

Change-Id: I793c1de1f4f6b0203727c0ff6aa8adecc43ad413
d4565858b0135b3177044558db87a68ef828955b
102722140e216cb9ad29107aae3bdaa70472d471
Reviewed-on: https://gerrit.libreoffice.org/38852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
5 years agoResolves: tdf#104875 defer filter detection to first load/update of external
Eike Rathke [Wed, 14 Jun 2017 21:30:57 +0000 (14 23:30 +0200)]
Resolves: tdf#104875 defer filter detection to first load/update of external

 This is a combination of 2 commits.

This could never have been meant

Since commit 67b374980f340faa2695001984aaf98886a32fad
executing ScDocumentLoader::GetFilterName() twice if there was no stored
filter, and still executing it if there was one, even if the comment says we
shouldn't.

(cherry picked from commit 1bc793f8ab8f9b4ce435bd3585f9579df4a11819)

Resolves: tdf#104875 defer filter detection to first load/update of external

Attempting to access all linked external documents right on load time was
specifically nasty for non-local URIs (unmounted smb, http, ...)

(cherry picked from commit 416752b9e4bc4605c479d3eff7797be9f0ef2a38)

f4a7414dfe36875b505c73b8c963b650eeffe204

Change-Id: Iaf4b88e63b3987fb661df0e9b095f06b29076894
Reviewed-on: https://gerrit.libreoffice.org/38820
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agoFix screenshot missing quotes in code snippet
Olivier Hallot [Fri, 16 Jun 2017 19:21:44 +0000 (16 16:21 -0300)]
Fix screenshot missing quotes in code snippet

The code snippet suggested has no quotes in atttributes values.

Change-Id: I604fb34827da3bebf3f6759b491d719a96854754
Reviewed-on: https://gerrit.libreoffice.org/38895
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
5 years agotdf#108418 Fix vertical alignment of checkbox text
Gabor Kelemen [Thu, 8 Jun 2017 16:50:37 +0000 (8 18:50 +0200)]
tdf#108418 Fix vertical alignment of checkbox text

Change-Id: I8daa6c2c5941a894259a5af74a16f7ef32f8a867
Reviewed-on: https://gerrit.libreoffice.org/38577
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 9d0ed8352ac9f27552f62d536c506f5cbc2a4afe)
Reviewed-on: https://gerrit.libreoffice.org/38956
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 50bab52194f570d48b92eb2f240dc4de7b3e1d3c)
Reviewed-on: https://gerrit.libreoffice.org/38963

5 years agotdf#108118 sw: fix recursive layouting during SwCursorShell::Paint()
Michael Stahl [Fri, 9 Jun 2017 16:03:40 +0000 (9 18:03 +0200)]
tdf#108118 sw: fix recursive layouting during SwCursorShell::Paint()

The problem, in a nutshell, is that SwDrawContact::Changed() is called
during layout, and recursively starts another layout that removes a
drawing object that is being iterated over in frame #28
SwObjectFormatter::FormatObjsAtFrame_() from the layout.

Apparently SwDrawContact::Changed() is by far the most dangerous
function to call during layout; set the quite targeted flag
SetCallbackActionEnabled() to prevent the recursion.

0  SwSortedObjs::Remove(SwAnchoredObject&) (this=0x73e4a00, _rAnchoredObj=...) at sw/source/core/layout/sortedobjs.cxx:228
1  SwFrame::RemoveDrawObj(SwAnchoredObject&) (this=0x9430e20, _rToRemoveObj=...) at sw/source/core/layout/fly.cxx:2076
2  SwDrawVirtObj::RemoveFromWriterLayout() (this=0x95ce130) at sw/source/core/draw/dcontact.cxx:2199
3  SwDrawContact::DisconnectObjFromLayout(SdrObject*) (this=0x70fef00, _pDrawObj=0x95ce130) at sw/source/core/draw/dcontact.cxx:1663
4  SwLayoutFrame::DestroyImpl() (this=0x91c6c60) at sw/source/core/layout/ssfrm.cxx:489
5  SwFrame::DestroyFrame(SwFrame*) (pFrame=0x91c6c60) at sw/source/core/layout/ssfrm.cxx:389
6  SwLayoutFrame::DestroyImpl() (this=0x9435cd0) at sw/source/core/layout/ssfrm.cxx:500
7  SwPageFrame::DestroyImpl() (this=0x9435cd0) at sw/source/core/layout/pagechg.cxx:270
8  SwFrame::DestroyFrame(SwFrame*) (pFrame=0x9435cd0) at sw/source/core/layout/ssfrm.cxx:389
9  SwRootFrame::RemovePage(SwPageFrame**, SwRemoveResult) (this=0x36b26f0, pDelRef=0x7ffeafbf2e38, eResult=SwRemoveResult::Prev) at sw/source/core/layout/pagechg.cxx:1351
10 SwRootFrame::RemoveSuperfluous() (this=0x36b26f0) at sw/source/core/layout/pagechg.cxx:1426
11 SwLayAction::InternalAction(OutputDevice*) (this=0x7ffeafbf3250, pRenderContext=0x3595030) at sw/source/core/layout/layact.cxx:502
12 SwLayAction::Action(OutputDevice*) (this=0x7ffeafbf3250, pRenderContext=0x3595030) at sw/source/core/layout/layact.cxx:351
13 SwViewShell::ImplEndAction(bool) (this=0x364cc00, bIdleEnd=false) at sw/source/core/view/viewsh.cxx:279
14 SwViewShell::EndAction(bool) (this=0x364cc00, bIdleEnd=false) at sw/inc/viewsh.hxx:605
15 SwCursorShell::EndAction(bool, bool) (this=0x364cc00, bIdleEnd=false, DoSetPosX=false) at sw/source/core/crsr/crsrsh.cxx:259
16 SwRootFrame::EndAllAction(bool) (this=0x36b26f0, bVirDev=false) at sw/source/core/layout/pagechg.cxx:1728
17 SwDrawContact::Changed(SdrObject const&, SdrUserCallType, tools::Rectangle const&) (this=0x70fef00, rObj=..., eType=SdrUserCallType::MoveOnly, rOldBoundRect=...) at sw/source/core/draw/dcontact.cxx:985
18 SdrObject::SendUserCall(SdrUserCallType, tools::Rectangle const&) const (this=0x95ce130, eUserCall=SdrUserCallType::MoveOnly, rBoundRect=...) at svx/source/svdraw/svdobj.cxx:2736
19 SdrObject::Move(Size const&) (this=0x95ce130, rSiz=Size = {...}) at svx/source/svdraw/svdobj.cxx:1482
20 SwDrawVirtObj::Move(Size const&) (this=0x95ce130, rSiz=Size = {...}) at sw/source/core/draw/dcontact.cxx:2366
21 SwAnchoredDrawObject::SetObjTop_(long) (this=0x95ce250, _nTop=777490) at sw/source/core/layout/anchoreddrawobject.cxx:677
22 SwAnchoredObject::SetObjTop(long) (this=0x95ce250, _nTop=777490) at sw/source/core/layout/anchoredobject.cxx:593
23 objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition() (this=0x7ffeafbf3980) at sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx:739
24 SwAnchoredDrawObject::MakeObjPosAnchoredAtPara() (this=0x95ce250) at sw/source/core/layout/anchoreddrawobject.cxx:421
25 SwAnchoredDrawObject::MakeObjPos() (this=0x95ce250) at sw/source/core/layout/anchoreddrawobject.cxx:318
26 SwObjectFormatter::FormatObj_(SwAnchoredObject&) (this=0x90623d0, _rAnchoredObj=...) at sw/source/core/layout/objectformatter.cxx:374
27 SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool) (this=0x90623d0, _rAnchoredObj=..., _bCheckForMovedFwd=false) at sw/source/core/layout/objectformattertxtfrm.cxx:126
28 SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame*) (this=0x90623d0, _pMasterTextFrame=0x0) at sw/source/core/layout/objectformatter.cxx:443
29 SwObjectFormatterTextFrame::DoFormatObjs() (this=0x90623d0) at sw/source/core/layout/objectformattertxtfrm.cxx:328
30 SwObjectFormatter::FormatObjsAtFrame(SwFrame&, SwPageFrame const&, SwLayAction*) (_rAnchorFrame=..., _rPageFrame=..., _pLayAction=0x0) at sw/source/core/layout/objectformatter.cxx:191
31 SwHeadFootFrame::FormatSize(long, SwBorderAttrs const*) (this=0x91c6c60, nUL=663, pAttrs=0x8fbc530) at sw/source/core/layout/hffrm.cxx:263
32 SwHeadFootFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x91c6c60, pRenderContext=0x3595030, pAttrs=0x8fbc530) at sw/source/core/layout/hffrm.cxx:416
33 SwLayoutFrame::MakeAll(OutputDevice*) (this=0x91c6c60) at sw/source/core/layout/calcmove.cxx:913
34 SwFrame::PrepareMake(OutputDevice*) (this=0x91c6c60, pRenderContext=0x3595030) at sw/source/core/layout/calcmove.cxx:346
35 SwFrame::Calc(OutputDevice*) const (this=0x91c6c60, pRenderContext=0x3595030) at sw/source/core/layout/trvlfrm.cxx:1783
36 lcl_FormatLay(SwLayoutFrame*) (pLay=0x91c6c60) at sw/source/core/layout/pagechg.cxx:360
37 lcl_FormatLay(SwLayoutFrame*) (pLay=0x9435cd0) at sw/source/core/layout/pagechg.cxx:357
38 SwPageFrame::PreparePage(bool) (this=0x9435cd0, bFootnote=false) at sw/source/core/layout/pagechg.cxx:456
39 (anonymous namespace)::doInsertPage(SwRootFrame*, SwPageFrame**, SwFrameFormat*, SwPageDesc*, bool, SwPageFrame**) (pRoot=0x36b26f0, pRefSibling=0x7ffeafbf43c8, pFormat=0x3076050, pDesc=0x3076010, bFootnote=false, pRefPage=0x7ffeafbf43d8) at sw/source/core/layout/pagechg.cxx:1210
40 SwFrame::InsertPage(SwPageFrame*, bool) (this=0x3620d70, pPrevPage=0x9227900, bFootnote=false) at sw/source/core/layout/pagechg.cxx:1269
41 SwFrame::GetNextLeaf(MakePageType) (this=0x3620d70, eMakePage=MAKEPAGE_INSERT) at sw/source/core/layout/flowfrm.cxx:994
42 SwFrame::GetLeaf(MakePageType, bool) (this=0x3620d70, eMakePage=MAKEPAGE_INSERT, bFwd=true) at sw/source/core/layout/flowfrm.cxx:797
43 SwFlowFrame::MoveFwd(bool, bool, bool) (this=0x3620e18, bMakePage=true, bPageBreak=false, bMoveAlways=false) at sw/source/core/layout/flowfrm.cxx:1851
44 SwContentFrame::MakeAll(OutputDevice*) (this=0x3620d70) at sw/source/core/layout/calcmove.cxx:1681
45 SwFrame::PrepareMake(OutputDevice*) (this=0x707a340, pRenderContext=0x3595030) at sw/source/core/layout/calcmove.cxx:312
46 SwFrame::Calc(OutputDevice*) const (this=0x707a340, pRenderContext=0x3595030) at sw/source/core/layout/trvlfrm.cxx:1783
47 GetFrameOfModify(SwRootFrame const*, SwModify const&, SwFrameType, Point const*, SwPosition const*, bool) (pLayout=0x36b26f0, rMod=..., nFrameType=(SwFrameType::Txt | SwFrameType::NoTxt), pPoint=0x707c6f0, pPos=0x707c720, bCalcFrame=true) at sw/source/core/layout/frmtool.cxx:3247
48 SwContentNode::getLayoutFrame(SwRootFrame const*, Point const*, SwPosition const*, bool) const (this=0x71328c0, _pRoot=0x36b26f0, pPoint=0x707c6f0, pPos=0x707c720, bCalcFrame=true) at sw/source/core/docnode/node.cxx:1118
49 SwRootFrame::CalcFrameRects(SwShellCursor&) (this=0x36b26f0, rCursor=...) at sw/source/core/layout/trvlfrm.cxx:2028
50 SwShellCursor::FillRects() (this=0x707c680) at sw/source/core/crsr/viscrs.cxx:609
51 SwSelPaintRects::Show(std::__debug::vector<rtl::OString, std::allocator<rtl::OString> >*) (this=0x707c680, pSelectionRectangles=0x7ffeafbf5570) at sw/source/core/crsr/viscrs.cxx:332
52 SwShellCursor::Show(SfxViewShell*) (this=0x707c680, pViewShell=0x0) at sw/source/core/crsr/viscrs.cxx:619
53 SwCursorShell::Paint(OutputDevice&, tools::Rectangle const&) (this=0x364cc00, rRenderContext=..., rRect=...) at sw/source/core/crsr/crsrsh.cxx:1283
54 SwEditWin::Paint(OutputDevice&, tools::Rectangle const&) (this=0x3595030, rRenderContext=..., rRect=...) at sw/source/uibase/docvw/edtwin2.cxx:476

Change-Id: I1b237f0f425e58bb95bae9f19019f26fe5da21fd
(cherry picked from commit 2ca0360a6c75959bf61bd2ee0ef96b2729369a15)
Reviewed-on: https://gerrit.libreoffice.org/38619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agoResolves: tdf#104989 a matrix/array formula cell needs to have dimensions
Eike Rathke [Thu, 15 Jun 2017 11:05:16 +0000 (15 13:05 +0200)]
Resolves: tdf#104989 a matrix/array formula cell needs to have dimensions

 This is a combination of 2 commits.

Resolves: tdf#104989 a matrix/array formula cell needs to have dimensions

Most spreadsheet functions don't need it, but some may.

(cherry picked from commit 033d018a3a1d345d61f3c4dc4da693cdd4004dea)

Ensure all cases push an error return, tdf#104989 related (not the cause)

A formula cell in matrix context could have no dimensions.. (which is the cause
but elsewhere).

(cherry picked from commit e6abe9c3d06d6776e05bef93b5e6f87b403ea967)

1a04f9808d8f5c802789e3db77052351b24c24c7

Change-Id: I954acaa0a64c4dac8d15acd5b3f404019a7e0bce
Reviewed-on: https://gerrit.libreoffice.org/38832
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
5 years agoupload graphite 1.3.10
David Tardon [Thu, 15 Jun 2017 14:02:48 +0000 (15 16:02 +0200)]
upload graphite 1.3.10

Change-Id: Ib70e1c08a11465f5a65be8cd0c892e8f7667b478
Reviewed-on: https://gerrit.libreoffice.org/38837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 619d93c8f660b26e19f41c6908807819ac783958)
Reviewed-on: https://gerrit.libreoffice.org/38845

5 years agouse correct size
David Tardon [Thu, 15 Jun 2017 11:17:40 +0000 (15 13:17 +0200)]
use correct size

(cherry picked from commit d1ae31a1fc49ec7a68b2a07c5e5e97d95b346ca9)

Change-Id: I620ada9b209bb2084eccaa81385beb6306d6a3d0
Reviewed-on: https://gerrit.libreoffice.org/38827
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
5 years agoResolves: tdf#108187 fatal exception on testing if ooxml is a odf
Caolán McNamara [Fri, 2 Jun 2017 10:57:30 +0000 (2 11:57 +0100)]
Resolves: tdf#108187 fatal exception on testing if ooxml is a odf

Change-Id: Ie88a66aa8d73bb3c4045629604756470ce51b92b
Reviewed-on: https://gerrit.libreoffice.org/38354
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
5 years agoupdate credits
Christian Lohmaier [Tue, 13 Jun 2017 22:28:47 +0000 (14 00:28 +0200)]
update credits

Change-Id: I873b10323375d17b0a3bce1fb578c8169dd5c2b7
(cherry picked from commit 458fadbaf7b7f816a01304b48c0938407e65f060)

5 years agotdf#103091 conditional style conditions not saved
Troy Rollo [Tue, 6 Jun 2017 07:41:33 +0000 (6 17:41 +1000)]
tdf#103091 conditional style conditions not saved

Change-Id: Iccf3eb531ee3382d27105e5ccce6013707a646b6
Reviewed-on: https://gerrit.libreoffice.org/38451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit a5b4cb3f836c991d0647f55e1ef4920ce6115eac)
Reviewed-on: https://gerrit.libreoffice.org/38747

5 years agoUpdated core
Christian Lohmaier [Tue, 13 Jun 2017 18:40:06 +0000 (13 20:40 +0200)]
Updated core
Project: translations  49ef30e572012e8330c295c6ccc9152fc2dc778f

update translations for 5.3.4 rc2

and force-fix errors using pocheck

Change-Id: I3db56fae0235a04ec4293ed2a31de2d23202fc8a

5 years agotdf#108480: Undo from clone formating does not remove vertical alignment
Tamás Zolnai [Mon, 12 Jun 2017 12:34:59 +0000 (12 14:34 +0200)]
tdf#108480: Undo from clone formating does not remove vertical alignment

In the related change:
d36aa2ba3132ce62a370b7260ca620642cbf7dbf
wrong method was used to set cell properties, which does
not handle undo actions, so use the proper function.

Other issue was related to undo handling of vertical text
alignment in general. In some cases undo actions were lost
after user clicked out of the cell. It is because vertical
alignment is not affecting the outliner and so the related
undo actions were just dropped in EndTextEdit() method.

Reviewed-on: https://gerrit.libreoffice.org/38699
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 37d8ac12902506f4185e10f1de4f566dbaf53e42)

Change-Id: I3a6a95fac711056a658a3dee616733939cd13330
Reviewed-on: https://gerrit.libreoffice.org/38723
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
5 years agotdf#98888: mediawiki inserts redundant emptylines in <ref>
Julien Nabet [Tue, 6 Jun 2017 21:15:20 +0000 (6 23:15 +0200)]
tdf#98888: mediawiki inserts redundant emptylines in <ref>

There's a newline in case of heading, table or bibliography following text:p
ok but only if we're not in text:note node

Change-Id: I71172751a51e29abdd770e758d27b1bc8f15cb0d
Reviewed-on: https://gerrit.libreoffice.org/38470
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 8a400cfa468655142103f18f722adf1d5cbda9c7)
Reviewed-on: https://gerrit.libreoffice.org/38485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agotdf#106423: dbase file can have no records
Julien Nabet [Sun, 11 Jun 2017 10:57:31 +0000 (11 12:57 +0200)]
tdf#106423: dbase file can have no records

Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3ff19b33c84557fd20e68960499933b4e52638
tdf#84834 sc: stricter type detection for dBASE files

Log test file from tdf#84834 still opens in Writer as expected

Change-Id: Ibf5a0f586e3a132455d2363e61e5cc7ea249002d
Reviewed-on: https://gerrit.libreoffice.org/38660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 57ae8834c8313354477117b65d87c86407f6bf82)
Reviewed-on: https://gerrit.libreoffice.org/38692
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
5 years agotdf#108305 sw: fix crash on fly "Position and Size"
Michael Stahl [Wed, 7 Jun 2017 15:47:15 +0000 (7 17:47 +0200)]
tdf#108305 sw: fix crash on fly "Position and Size"

Everything else in SwFrameShell::Execute() checks pArgs isn't null so do
the same here.

(regression from d02f75a8c36705924ddd6a5921fe3012fafce812)

Change-Id: I73d85b111a5d2c088b9d888b8595ceb3979e8d2b
(cherry picked from commit 28d760e5220a175a5eb8e859498baa4c7f97f3e2)
Reviewed-on: https://gerrit.libreoffice.org/38521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agoFix typo in queryAggregation
Stephan Bergmann [Fri, 9 Jun 2017 17:47:57 +0000 (9 19:47 +0200)]
Fix typo in queryAggregation

...that caused UBSan failure in UITest_calc_demo:

> framework/source/services/desktop.cxx:406:47: runtime error: member call on address 0x611000887c80 which does not point to an object of type 'com::sun::star::lang::XServiceInfo'
> 0x611000887c40: note: object is base class subobject at offset 64 within object of type 'chart::CreationWizardUnoDlg'
>  1a 06 80 29  70 23 e8 c8 5a 7f 00 00  50 87 f0 00 40 60 00 00  48 24 e8 c8 5a 7f 00 00  02 00 00 00
>               ^
>     #0 0x7f5d62c1413b in framework::Desktop::addTerminateListener(com::sun::star::uno::Reference<com::sun::star::frame::XTerminateListener> const&) framework/source/services/desktop.cxx:406:47
>     #1 0x7f5ac78f9337 in chart::CreationWizardUnoDlg::CreationWizardUnoDlg(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:52:15
>     #2 0x7f5ac7906cdd in com_sun_star_comp_chart2_WizardDialog_get_implementation chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:368:30
>     #3 0x7f5df087ff37 in std::_Function_handler<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:1716:9
>     #4 0x7f5df0757dab in std::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:2127:14
>     #5 0x7f5df06f69f1 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) cppuhelper/source/servicemanager.cxx:667:13
>     #6 0x7f5df07134f2 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) cppuhelper/source/servicemanager.cxx:998:17
>     #7 0x7f5df0715d7a in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) cppuhelper/source/servicemanager.cxx
>     #8 0x7f5d47aca8ca in FuInsertChart::FuInsertChart(ScTabViewShell*, vcl::Window*, ScDrawView*, SdrModel*, SfxRequest&) sc/source/ui/drawfunc/fuins2.cxx:650:27
>     #9 0x7f5d49da003c in ScTabViewShell::ExecDrawIns(SfxRequest&) sc/source/ui/view/tabvwshb.cxx:344:13
>     #10 0x7f5d49ce50ed in SfxStubScTabViewShellExecDrawIns(SfxShell*, SfxRequest&) workdir/SdiTarget/sc/sdi/scslots.hxx:1407:1
>     #11 0x7f5de463ea6d in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) include/sfx2/shell.hxx:211:35
>     #12 0x7f5de4600cbe in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:377:20
>     #13 0x7f5de4621593 in SfxDispatcher::PostMsgHandler(SfxRequest*) sfx2/source/control/dispatch.cxx:1156:17
>     #14 0x7f5de460487a in SfxDispatcher::LinkStubPostMsgHandler(void*, SfxRequest*) sfx2/source/control/dispatch.cxx:1136:1
>     #15 0x7f5de5f18eda in Link<SfxRequest*, void>::Call(SfxRequest*) const include/tools/link.hxx:84:45
>     #16 0x7f5de5f189d2 in SfxHintPoster::DoEvent_Impl(void*) sfx2/source/notify/hintpost.cxx:44:12
>     #17 0x7f5de5f18861 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) sfx2/source/notify/hintpost.cxx:42:1
>     #18 0x7f5dbc3bb9fa in Link<void*, void>::Call(void*) const include/tools/link.hxx:84:45
>     #19 0x7f5dbc3a5bdf in ImplHandleUserEvent(ImplSVEvent*) vcl/source/window/winproc.cxx:1946:30
>     #20 0x7f5dbc39103c in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) vcl/source/window/winproc.cxx:2495:13
>     #21 0x7f5dbf2f016f in SalFrame::CallCallback(SalEvent, void const*) const vcl/inc/salframe.hxx:276:33
>     #22 0x7f5dbf350db2 in SvpSalInstance::DoYield(bool, bool, unsigned long) vcl/headless/svpinst.cxx:345:31
>     #23 0x7f5dbe714b69 in ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:494:29
>     #24 0x7f5dbe6efb53 in Application::Yield() vcl/source/app/svapp.cxx:558:5
>     #25 0x7f5dbe6ef896 in Application::Execute() vcl/source/app/svapp.cxx:458:9
>     #26 0x7f5dfab81984 in desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1354:5
>     #27 0x7f5dfab89eb6 in desktop::Desktop::Main() desktop/source/app/app.cxx:1698:17
>     #28 0x7f5dbe76c6ab in ImplSVMain() vcl/source/app/svmain.cxx:192:35
>     #29 0x7f5dbe779bf1 in SVMain() vcl/source/app/svmain.cxx:230:16
>     #30 0x7f5dfadb8659 in soffice_main desktop/source/app/sofficemain.cxx:166:12
>     #31 0x50fa39 in sal_main desktop/source/app/main.c:48:15
>     #32 0x50f9e3 in main desktop/source/app/main.c:47:1
>     #33 0x7f5df9322400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289
>     #34 0x419f79 in _start (instdir/program/soffice.bin+0x419f79)

Change-Id: I0a798c6d77b7349077ea44dfe112024abb2567f0
(cherry picked from commit 89214e05e0c2f92fbe68e6c4f4a9035a94cff282)
Reviewed-on: https://gerrit.libreoffice.org/38612
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#37859: Odb data copied to Calc showed wrong encoding in Windows
Julien Nabet [Tue, 30 May 2017 21:50:18 +0000 (30 23:50 +0200)]
tdf#37859: Odb data copied to Calc showed wrong encoding in Windows

Blind fix since I don't have Windows.
If it works, many thanks to:
- Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16)
- Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35)

Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a
Reviewed-on: https://gerrit.libreoffice.org/38253
(cherry picked from commit 39487b14956d883899311b6294f6f09ca2371366)
Reviewed-on: https://gerrit.libreoffice.org/38547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#107795 fixed cursor position after inserting input field
Bernhard Widl [Fri, 12 May 2017 11:55:50 +0000 (12 13:55 +0200)]
tdf#107795 fixed cursor position after inserting input field

Change-Id: I3c063c0393b524132e522914a7a9885c8a9c3b78
Reviewed-on: https://gerrit.libreoffice.org/37536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 408a7e320db978a8f784fa25e35caedf931612c5)
Reviewed-on: https://gerrit.libreoffice.org/38443
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
5 years agolibstaroffice: use correct loop index
David Tardon [Tue, 6 Jun 2017 12:12:00 +0000 (6 14:12 +0200)]
libstaroffice: use correct loop index

(cherry picked from commit cc2db25645ede743bdc3824fe7d26ea4beda6a96)
Signed-off-by: David Tardon <dtardon@redhat.com>
Change-Id: I1b862ed2d69c41361bc8c26d96c5329473fe64aa
Reviewed-on: https://gerrit.libreoffice.org/38444
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agoofz: fix remaining length check
Caolán McNamara [Fri, 2 Jun 2017 18:22:19 +0000 (2 19:22 +0100)]
ofz: fix remaining length check

Change-Id: I1788ae2a15823b0dc165ad1a99bd0f2aac0bcaf1
Reviewed-on: https://gerrit.libreoffice.org/38363
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#101885: fix crash in AccFrameSelector
Julien Nabet [Sat, 13 May 2017 15:24:04 +0000 (13 17:24 +0200)]
tdf#101885: fix crash in AccFrameSelector

Deal with no parent case
0x00007ffff5e98240 in vcl::Window::GetChildCount() const ()
0  0x00007ffff5e98240 in vcl::Window::GetChildCount() const ()
1  0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() ()
See https://bugs.documentfoundation.org/attachment.cgi?id=127141

Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43
Reviewed-on: https://gerrit.libreoffice.org/37575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit c9275062ed745a8c5d52a3863299baf8bcf86ea7)
Reviewed-on: https://gerrit.libreoffice.org/38414
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
5 years agosc::ColRowSpan::mnEnd is inclusive
Eike Rathke [Sat, 3 Jun 2017 11:00:50 +0000 (3 13:00 +0200)]
sc::ColRowSpan::mnEnd is inclusive

Wrong since

    commit 1e721077b43de84edab2a3ed2f316ddcbec6e3ec
    Date:   Tue Oct 7 00:22:32 2014 +0900

and

    commit 91502a72c12c559442e8bf77c27a516b49c2a68d
    Date:   Thu Oct 9 14:44:27 2014 +0200

So HasAttribSelection() and HasSelectionMatrixFragment() did not query the
rightmost column of each marked range from ScMarkData.

Change-Id: Ie3aca26ee1b6c249c1135268dc0ad3ea053ea2b8
(cherry picked from commit 77d1e0c49adea959dd418de9b6cf9901e01be3ae)
Reviewed-on: https://gerrit.libreoffice.org/38371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#108024 Keep original selection during DrawViewShell::FuTemporary()
Takeshi Abe [Fri, 26 May 2017 14:16:57 +0000 (26 23:16 +0900)]
tdf#108024 Keep original selection during DrawViewShell::FuTemporary()

Otherwise it was disposed in the middle of its own mouse event handler
FuSelection::MouseButtonUp().

Change-Id: I0d96048526dece7232e5a777364ad4da1d64c904
Reviewed-on: https://gerrit.libreoffice.org/37976
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 96d59ffc572c4cf112405a85aee3366d45bc7757)
Reviewed-on: https://gerrit.libreoffice.org/38302
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 years agoResolves: tdf#108279 dimension rows are 32-bit and don't wrap at 64k
Eike Rathke [Thu, 1 Jun 2017 18:50:27 +0000 (1 20:50 +0200)]
Resolves: tdf#108279 dimension rows are 32-bit and don't wrap at 64k

Change-Id: I7bf7a149fb1db526ef62bea2f52b200cf5053cc2
(cherry picked from commit 259c2409310814ae62c8d0aefef19a71e8d88dbe)
Reviewed-on: https://gerrit.libreoffice.org/38331
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agobump product version to 5.3.5.0.0+
Christian Lohmaier [Thu, 1 Jun 2017 18:12:01 +0000 (1 20:12 +0200)]
bump product version to 5.3.5.0.0+

Change-Id: Ifb8a0d553437b8da598d9841de96859b009d8962

5 years agotdf#75256 sifr icon theme - trackchangesbar
Matthias Freund [Thu, 1 Jun 2017 16:46:08 +0000 (1 18:46 +0200)]
tdf#75256 sifr icon theme - trackchangesbar

Fix for wrong filename for trackchangesbar

Change-Id: I3a286c87b6ca9e01a8e256acde00715a84f7b4d9
Reviewed-on: https://gerrit.libreoffice.org/38323
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
5 years agoUpdated core
Christian Lohmaier [Thu, 1 Jun 2017 17:11:16 +0000 (1 19:11 +0200)]
Updated core
Project: translations  bdbcd4decf1ae9699ebffa6aa8c6e3f1c6cb41a0

update translations for 5.3.4 rc1

and force-fix errors using pocheck

Change-Id: I0b1e1ccf9d04d9bad6bcab4c1800f8fe223af73f

5 years agotdf#105281 Rearrange a few things for l10n-friendliness
Adolfo Jayme Barrientos [Wed, 29 Mar 2017 09:25:43 +0000 (29 03:25 -0600)]
tdf#105281 Rearrange a few things for l10n-friendliness

With the Notebookbar addition, no care was taken to update this UI
bearing in mind that there *might* be a few languages suffering in
consequence.

Change-Id: I78c4a1846e192c4c7a64328b730517d42aff979f
(cherry picked from commit bd911c02594c77e1f7e8a01a364b6e0967d4db26)
Reviewed-on: https://gerrit.libreoffice.org/35832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
5 years agotdf#106607 - Sifr icon for "Table Styles" needed
Matthias Freund [Tue, 30 May 2017 18:27:57 +0000 (30 20:27 +0200)]
tdf#106607 - Sifr icon for "Table Styles" needed

Change-Id: I174e8022fbc206256b19fb8e9f2a60f02757fce4
Reviewed-on: https://gerrit.libreoffice.org/38229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
5 years agotdf#108072: match sprmTFCantSplit with its correct id
Aron Budea [Sun, 28 May 2017 21:16:24 +0000 (28 23:16 +0200)]
tdf#108072: match sprmTFCantSplit with its correct id

The behavior was adjusted with
72ef0d88e916b320de85fe2ebf08cb7aea28ca08 , but the ids
for sprmTFCantSplit90 and sprmTFCantSplit remained mixed up.

Change-Id: Ic97224a3af39e5df707a6dba59b785580c17b739
Reviewed-on: https://gerrit.libreoffice.org/38117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/38277

5 years agoRelated: tdf#107961 ensure notifyhdl is unset after dispose
Caolán McNamara [Tue, 30 May 2017 09:49:01 +0000 (30 10:49 +0100)]
Related: tdf#107961 ensure notifyhdl is unset after dispose

Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a
Reviewed-on: https://gerrit.libreoffice.org/38238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#86776 Digitally sign soffice.bin on Windows
Andras Timar [Tue, 30 May 2017 21:24:38 +0000 (30 23:24 +0200)]
tdf#86776 Digitally sign soffice.bin on Windows

Change-Id: I79e223f7ac8367a22668c015afddafe1c8b8cd42
Reviewed-on: https://gerrit.libreoffice.org/38248
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
5 years agotdf#100072 zero height of shape's path was causing geometry errors
Vasily Melenchuk [Mon, 15 May 2017 10:41:14 +0000 (15 13:41 +0300)]
tdf#100072 zero height of shape's path was causing geometry errors

DOCX custom geometry shape's path width and height are now used
independently for scaling calculations.

Reviewed-on: https://gerrit.libreoffice.org/37639
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 5477f7274e4df1210298c0f503a54eabc0f06bfc)

plus:

tdf#100072 extra test for DOCX shape import with zero height

Corresponding bug is already fixed in tdf#107104. However created
tests do care only for width, but not for height, like we have in
this testcase.

Reviewed-on: https://gerrit.libreoffice.org/37538
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit cffc5a04661fc0a84dff9fa5da954236d88a8b38)

Change-Id: If5d5499f402379df125b0f31dd071ca51b2553f1
Reviewed-on: https://gerrit.libreoffice.org/38224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
5 years agolibreofficekit: GTK 3.22 deprecates gtk_show_uri
Michael Stahl [Mon, 6 Mar 2017 12:13:52 +0000 (6 13:13 +0100)]
libreofficekit: GTK 3.22 deprecates gtk_show_uri

Avoid -Werror=deprecated-declaration and use
gtk_show_uri_on_window instead, which needs a GtkWindow.

Change-Id: Ia77978348809c8d88cb2823a1549cbdeffcc6c97
Reviewed-on: https://gerrit.libreoffice.org/34926
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 45dd570ac474c336cceac1ca2792f243ee125fa2)
Reviewed-on: https://gerrit.libreoffice.org/38158
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
5 years agotdf#106131 no global drag when anchor drag active
Armin Le Grand [Fri, 26 May 2017 09:49:58 +0000 (26 11:49 +0200)]
tdf#106131 no global drag when anchor drag active

If in Writer dragging the anchor is already active
it is not allowed to enter global object drag mode.
This check was missing and may lead to various
inconsistencies

Change-Id: I7d8dd2a62737e6d5d72f69747ceb21bcb73c45ed
Reviewed-on: https://gerrit.libreoffice.org/38059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
(cherry picked from commit 1b27bed2d5b6915cda408c6f8d27d15bf13cc9be)
Reviewed-on: https://gerrit.libreoffice.org/38188
Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
(cherry picked from commit c3c208e1fdfd60b95fc09ed48d9ee975bddb214d)
Reviewed-on: https://gerrit.libreoffice.org/38209
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#107729: Disable toolbar items that are not available yet.
Jan Holesovsky [Tue, 30 May 2017 08:19:16 +0000 (30 10:19 +0200)]
tdf#107729: Disable toolbar items that are not available yet.

Otherwise trying to use them crashes LibreOffice.

Change-Id: I268e5b783905ec7aaaf50cbc629fd44e6341bf8d
Reviewed-on: https://gerrit.libreoffice.org/38185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#107682 - Repeated images replace correct ones in exported PDF
Marco Cecchetti [Mon, 29 May 2017 19:07:10 +0000 (29 21:07 +0200)]
tdf#107682 - Repeated images replace correct ones in exported PDF

The problem was due to the buffer acquire methods: in Bitmap::Checksum
(old implementation) Bitmap::AcquireReadAccess is used to get the bitmap
buffer: indeed this method relies on SalBitmap::AcquireBuffer (which is
used in the new implementation) but in case the buffer acquisition
fails, instead of giving up, it tries to update the imp bitmap instance
embedded in the bitmap (see BitmapInfoAccess::ImplCreate).

The solution is to perform this further attemp in Bitmap::Checksum when
the value returned by ImpBitmap::GetChecksum is 0.

Change-Id: Ib901ac941db57756e9a951bacbc573ca206316e0
Reviewed-on: https://gerrit.libreoffice.org/38168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
5 years agotdf#75256 Sifr icon theme - showtrackchanges
Matthias Freund [Mon, 29 May 2017 22:03:34 +0000 (30 00:03 +0200)]
tdf#75256 Sifr icon theme - showtrackchanges

Change-Id: I0205b71fe1a7123f7bd7e09b597e3e17af4eea57
Reviewed-on: https://gerrit.libreoffice.org/38172
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#108231 tdf#108109 xmloff: SvxUnoDrawingModel doesn't implement...
Michael Stahl [Tue, 30 May 2017 11:11:01 +0000 (30 13:11 +0200)]
tdf#108231 tdf#108109 xmloff: SvxUnoDrawingModel doesn't implement...

... XStyleFamiliesSupplier, so try to do without.  This is called from
sw in case SWTRANSFER_OBJECTTYPE_DRAWMODEL.

(regression from 9835a5823e0f559aabbc0e15ea126c82229c4bc7)

Change-Id: Ic99ad4bf0c8e6e24fc10da173ec480c9d29c0363
(cherry picked from commit db38e3f201517acf22c1773ae9fc4cb2514788b1)
Reviewed-on: https://gerrit.libreoffice.org/38214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agoResolves: tdf#108111 backport mono checkboxes fix
Caolán McNamara [Wed, 4 Jan 2017 18:39:34 +0000 (4 18:39 +0000)]
Resolves: tdf#108111 backport mono checkboxes fix

replace the blue which will be set to transparent, with transparent

and then we don't "manually" replace a color with transparent which
makes tdf#108111 look right again

(cherry picked from commit f1a8e00764b32c3b799ecd40dcb4dd632493bc45)

Change-Id: I95923685d412145e88b672a50311c767d1425493
Reviewed-on: https://gerrit.libreoffice.org/38223
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agoRelated tdf#108068: Use new name of column when it's been changed
Julien Nabet [Thu, 25 May 2017 08:14:30 +0000 (25 10:14 +0200)]
Related tdf#108068: Use new name of column when it's been changed

First fix simple case, the rename of a column which is not a primary key

Change-Id: Ia0de8e531021cbec0409408008c541c25a4bcd85
Reviewed-on: https://gerrit.libreoffice.org/38014
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit c751318868f3f0082b2c86df493216d452b8ecc5)
Reviewed-on: https://gerrit.libreoffice.org/38023
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
5 years agotdf#107389: Wrong positioning of AutoFilter buttons in tiledrendering mode
Tamás Zolnai [Sat, 27 May 2017 20:15:52 +0000 (27 22:15 +0200)]
tdf#107389: Wrong positioning of AutoFilter buttons in tiledrendering mode

Must be a regression from this commit:
9113f17e65b1dafbc178fd269e2967c1e2632f0e

Where the offset's and origin's meaning were changed, but
not all code path was updated accordingly.

Change-Id: Ib519303d5ca5ac7f13e74944e8147ea3220d7684
Reviewed-on: https://gerrit.libreoffice.org/38102
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit ba5a9132375bcfedebd7c3d2500006161800da3b)
Reviewed-on: https://gerrit.libreoffice.org/38112
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#107176: just return initial selection when there's no range
Julien Nabet [Sun, 16 Apr 2017 15:40:07 +0000 (16 17:40 +0200)]
tdf#107176: just return initial selection when there's no range

See https://bugs.documentfoundation.org/show_bug.cgi?id=107176#c2

Change-Id: I606b7f248821bb24b3a9026ecd26a9bc93971748
Reviewed-on: https://gerrit.libreoffice.org/36582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 6bde2e93a2e0f94bc2263928cb27c4b85827822d)
Reviewed-on: https://gerrit.libreoffice.org/37788
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agoimport stream on the LibreOffice side, tdf#107827
Markus Mohrhard [Sat, 13 May 2017 17:10:45 +0000 (13 19:10 +0200)]
import stream on the LibreOffice side, tdf#107827

This adds support for all LibreOffice content providers and non-ascii file names.

Change-Id: I0a0fd0ab0c78ef039679516e7a3e880929e8f725
Reviewed-on: https://gerrit.libreoffice.org/37578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 5e9178f765b327a8aba17476d135ba3b1f881bf7)
Reviewed-on: https://gerrit.libreoffice.org/37582
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agouse empty document in orcus gnumeric import, tdf#107828
Markus Mohrhard [Sat, 13 May 2017 19:34:28 +0000 (13 21:34 +0200)]
use empty document in orcus gnumeric import, tdf#107828

Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d
Reviewed-on: https://gerrit.libreoffice.org/37579
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-on: https://gerrit.libreoffice.org/37659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#106532 Sifr icon for "Cross-reference" needed
Matthias Freund [Thu, 25 May 2017 22:01:24 +0000 (26 00:01 +0200)]
tdf#106532 Sifr icon for "Cross-reference" needed

16px png and 24px png

Change-Id: Id90f656880f05681d9d95132851be0566918a792
Reviewed-on: https://gerrit.libreoffice.org/38047
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agotdf#106533 Sifr icon for "Index Entry" needed
Matthias Freund [Sat, 27 May 2017 22:37:44 +0000 (28 00:37 +0200)]
tdf#106533 Sifr icon for "Index Entry" needed

Change-Id: I267496d6b67aed56dee12b2a44036b71f8b0fbb2
Reviewed-on: https://gerrit.libreoffice.org/38097
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
5 years agoResolves: tdf#108069 2nd OpenGLContext::init should dispose earlier results
Caolán McNamara [Fri, 26 May 2017 11:41:10 +0000 (26 12:41 +0100)]
Resolves: tdf#108069 2nd OpenGLContext::init should dispose earlier results

Change-Id: If6bb9517a4081576347d71ddf26d020119d34247
(cherry picked from commit 0b9b36cafe29916a9fdeac420a49c174adb10c59)
Reviewed-on: https://gerrit.libreoffice.org/38065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agosw: coverity#1409899 Null pointer dereferences
Michael Stahl [Fri, 26 May 2017 09:25:06 +0000 (26 11:25 +0200)]
sw: coverity#1409899 Null pointer dereferences

Change-Id: I152def3c629980aedb705ac511f154cc6e9d1b0f
(cherry picked from commit 40587c191ecf6ec667f40e9148c197246e3c45a5)
Reviewed-on: https://gerrit.libreoffice.org/38060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agoResolves: tdf#96426 more whitespace intersection operator in Excel syntax
Eike Rathke [Wed, 17 May 2017 13:21:25 +0000 (17 15:21 +0200)]
Resolves: tdf#96426 more whitespace intersection operator in Excel syntax

Handle also stacked token arrays resulting from named expressions like
=range1 range2

Change-Id: I1838af155f17b5e4f941e46895303caed75b6075
(cherry picked from commit 70cb7757f971c4c16d1b0a5585d95816cd4382e6)
Reviewed-on: https://gerrit.libreoffice.org/37712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agoPushError() instead of SetError() so there's a result token
Eike Rathke [Tue, 23 May 2017 12:01:41 +0000 (23 14:01 +0200)]
PushError() instead of SetError() so there's a result token

Change-Id: I8c2a7e01b04c26e008c8cbea9332f71d47293c75
(cherry picked from commit cd87661b4761ee9f512fc01f95d84f786c97bb66)
Reviewed-on: https://gerrit.libreoffice.org/37950
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agotdf#108049 VBA exception avoided in ScVbaRange::setStyle
Justin Luth [Wed, 24 May 2017 09:48:12 +0000 (24 12:48 +0300)]
tdf#108049 VBA exception avoided in ScVbaRange::setStyle

Change-Id: I5fc928373d70829b6e68d9000140a30f04179536
Reviewed-on: https://gerrit.libreoffice.org/37981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 4dc3e7d5e9044be66177e467d739bd8be7556783)
Reviewed-on: https://gerrit.libreoffice.org/38063
(cherry picked from commit bb9c240046955c432d963610d5dd99edcc6b43e6)
Reviewed-on: https://gerrit.libreoffice.org/38083
Tested-by: Justin Luth <justin_luth@sil.org>
5 years agotdf#107720 Bound Control initFromField: consider the case of the insert row
Lionel Elie Mamane [Tue, 9 May 2017 10:53:25 +0000 (9 12:53 +0200)]
tdf#107720 Bound Control initFromField: consider the case of the insert row

loplugin: simplifybool
(cherry picked from commit 95b25532d24bfb08c4846b991451a36475dd439f)

Change-Id: If18e161c994c926fd86453ab5736df1e89bb61de
Reviewed-on: https://gerrit.libreoffice.org/37427
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agoRelated tdf#107696: deal with non empty header without number
Julien Nabet [Tue, 16 May 2017 22:13:18 +0000 (17 00:13 +0200)]
Related tdf#107696: deal with non empty header without number

See first case of https://bugs.documentfoundation.org/show_bug.cgi?id=107696#c11

Change-Id: Ic76301cb10ae891901be7dd5a385356c1cc0523b
Reviewed-on: https://gerrit.libreoffice.org/37694
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 296c2296f5565556eea9fab51563050f28bbcafc)
Reviewed-on: https://gerrit.libreoffice.org/37792
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#107696: fix exports Heading style numbers
Julien Nabet [Mon, 15 May 2017 20:03:02 +0000 (15 22:03 +0200)]
tdf#107696: fix exports Heading style numbers

by taking into account text:is-list-header="true"
(thank you for having pointing at this attribute of header Regina!)

Change-Id: Ia0d9e0042e7ca3f31284c85f6b5336e1434bc0e6
Reviewed-on: https://gerrit.libreoffice.org/37655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit d67747c59c22e0346e13560810b9f3bf6c698428)
Reviewed-on: https://gerrit.libreoffice.org/37661
Reviewed-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#108017 xlsb import: protection settings were reversed
Justin Luth [Tue, 23 May 2017 12:35:13 +0000 (23 15:35 +0300)]
tdf#108017 xlsb import: protection settings were reversed

Back in LO4.3, commit 5728a56b20e01d6c9e86a23f20af64a1b68ad604
fdo#70499 selectn of lock/unlocked cells with worksheet protection reversed

...reversed finalizeImport's understanding of maSheetProt.* to match
xml import, but then it no longer matched the binary stream import.
So, .xlsb imported the opposite of what .xlsx/.xlsm imported.

Reviewed-on: https://gerrit.libreoffice.org/37952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 0d3fcbf809852aab0d0f88272bbfd2e8507d1c5e)
Reviewed-on: https://gerrit.libreoffice.org/38041

Change-Id: I2da3967ef52187e4ef36ce7d01b17a4672f61e1c
Reviewed-on: https://gerrit.libreoffice.org/38052
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
5 years agotdf#105002 Don't crash on mail wizard recreation
Maxim Monastirsky [Wed, 24 May 2017 23:17:06 +0000 (25 02:17 +0300)]
tdf#105002 Don't crash on mail wizard recreation

Change-Id: I8af4753cc654ec475d40223a64afa50a9de332ab
Reviewed-on: https://gerrit.libreoffice.org/38007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit ce40f2798f0fa2f8f6e3084e4bbbd50e749c55d6)
Reviewed-on: https://gerrit.libreoffice.org/38037

5 years agotdf#107868 PDF export of editeng fill color: restrict to logic map modes
Miklos Vajna [Mon, 22 May 2017 19:41:31 +0000 (22 21:41 +0200)]
tdf#107868 PDF export of editeng fill color: restrict to logic map modes

The original use case was Writer/Impress shape text, but when the map
mode is pixels, the reference device gives bogus values for the
PixelToLogic() calls, affecting e.g. form controls.

Just go back to the old way of not painting the background for those.

(cherry picked from commit 919a4ef592b6026a7533a93682f39118fef29ce8)

Conflicts:
vcl/qa/cppunit/pdfexport/pdfexport.cxx

Change-Id: I52f1901af15732274915fa3c77c06909b5164afb
Reviewed-on: https://gerrit.libreoffice.org/37977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#107782 xmlsecurity PDF verify: handle empty X509 certificate
Miklos Vajna [Thu, 18 May 2017 13:27:05 +0000 (18 15:27 +0200)]
tdf#107782 xmlsecurity PDF verify: handle empty X509 certificate

Leaving Signer as an empty reference will do exactly what we want: the
signature will be considered invalid.

(cherry picked from commit 18aa83acfa243741eb4c79a2e11aec6eaf1a9f02)

Change-Id: I25d7cbd260384110173fe953fc24f3dcf6b9acd5
Reviewed-on: https://gerrit.libreoffice.org/37813
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#106953 RTF import: fix missing paragraph left margin
Miklos Vajna [Tue, 16 May 2017 06:34:40 +0000 (16 08:34 +0200)]
tdf#106953 RTF import: fix missing paragraph left margin

See commit 3915bf2dc877d5f1140798e24933db0f21386a4a (tdf#95376 DOCX
import: fix incorrectly indented tab stops, 2016-01-26) for the various
sources that can determine the paragraph indentation.

In this case the problem was that too aggressive RTF style deduplication
removed a direct indent, which then meant a fallback to the ind-from-num
value, not to the ind-from-parastyle one.

(cherry picked from commit f528f9499bd91b700c549575e88fa102cfffede9)

Change-Id: I3b47b2bbeaaedf405baef24505d23dc49bd01865
Reviewed-on: https://gerrit.libreoffice.org/37670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agofix gdi resource leak (editeng/impedit)
Julien Nabet [Thu, 18 May 2017 21:25:32 +0000 (18 23:25 +0200)]
fix gdi resource leak (editeng/impedit)

Change-Id: Ia2d9ad88b5bcc2adf7f28ac7833132c04045d55b
Reviewed-on: https://gerrit.libreoffice.org/37802
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#103158 ctrl+shift should work on key up
Maxim Monastirsky [Thu, 4 May 2017 22:30:30 +0000 (5 01:30 +0300)]
tdf#103158 ctrl+shift should work on key up

Under gtk/gtk3 we send CommandEventId::ModKeyChange on
key down, to support the auto-accelerator feature. But
at least the handler in SwEditWin::Command must get it
on key up, in order to not interfere with other
ctrl+shift+X shortcuts, which work on key down.

To achieve that, we need:

- On key up pass the key that was just released, instead
  of the current state of nothing being pressed.

- Have a flag of whether it's a key down or up event, so
  it can be checked by the application code.

Reviewed-on: https://gerrit.libreoffice.org/37275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
(cherry picked from commit fe0451259d2fb93c809c1bfa3baf5abd90019c58)

Conflicts:
include/vcl/commandevent.hxx
vcl/source/window/commandevent.cxx
vcl/unx/generic/window/salframe.cxx
vcl/unx/gtk/gtksalframe.cxx
vcl/unx/gtk3/gtk3gtkframe.cxx

Change-Id: If188d6ccdc3b214a2c3ed20aad291d74d46b358f
Reviewed-on: https://gerrit.libreoffice.org/37516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agotdf#106424 fix crash in SfxItemPool::Put
Jochen Nitschke [Wed, 10 May 2017 20:56:35 +0000 (10 22:56 +0200)]
tdf#106424 fix crash in SfxItemPool::Put

This fix reverts commit 304d3856c138fb54ff536f41be3eff26ab4d6315
Date:   Wed Oct 16 07:55:09 2002 +0000
    #103124# possible unremoved SwFmt object fixed

and commit fab98924e01f211c1d1fc5823c0867019b590c60
Date:   Wed Oct 16 10:18:26 2002 +0000
    #103152# possible unremoved SwFmt object fixed

as they are causing crashes:
http://crashreport.libreoffice.org/stats/signature
/SfxItemPool::Put(SfxPoolItem%20const%20&,unsigned%20short)

The comments suggest there was/is a use-after-free when
SwFormatCharFormat is changed with API. This happens in unoobj.cxx
and unostyle.cxx by SwFormatDrop::SetCharFormat().

With following changes:
commit bf2ae97a223df987d6b9bc649afe311b5421f61e
    INTEGRATION: CWS os7 (1.64.4.3.34); FILE MERGED
    2003/03/25 14:23:43 os 1.64.4.3.34.1: #104245# table mode added
    to the SwXTextCursor::SetPropertyValue attribute list; 'Standard'
    character format not allowed as drop cap char style
and commit 9625366d0b2fd36a57c6283a4a80c47b80d57707
    INTEGRATION: CWS os8 (1.64.4.3.48); FILE MERGED
    2003/04/09 09:11:53 os 1.64.4.3.48.3: #104245# Default not
    allowed as DropCapCharStyleName, too

in unoobj.cxx, setting the documents' default SwFormatCharFormat is
rejected by throwing an exception. Likely to fix the same issue as
the first 2 commits.
So we do the same in unostyle.cxx now too.

Add an assert in SwFormatCharFormat::SetCharFormat and
SwFormatDrop::SetCharFormat, to uncover other changes to the default
SwFormatCharFormat or SwFormatDrop.
Such an case could happen in SwXTextDefaults::setPropertyValue
where we bail out now.

Change-Id: Iac59dffbd6285dd28d1000a8eacda8ffd3bdc962
Reviewed-on: https://gerrit.libreoffice.org/37499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 6d51bb3d54ac52e4870bd00a21fce3a3b1c5010b)
Reviewed-on: https://gerrit.libreoffice.org/38005
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 69330c31f5e8c35fb5ede92dcd130fde0bdc7e4f)
Reviewed-on: https://gerrit.libreoffice.org/38032

5 years agodisable use of poppler's internal JPEG2000 codec
David Tardon [Thu, 25 May 2017 14:14:36 +0000 (25 16:14 +0200)]
disable use of poppler's internal JPEG2000 codec

Change-Id: I7789d91f26577b08d88fc53460466798fc267e24
Reviewed-on: https://gerrit.libreoffice.org/38029
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
5 years agorhbz#1425304 sdext: join TimerScheduler thread before shutdown
Michael Stahl [Wed, 24 May 2017 14:14:56 +0000 (24 16:14 +0200)]
rhbz#1425304 sdext: join TimerScheduler thread before shutdown

Use a osl::Condition to interrupt the waiting thread, and join it.

Change-Id: I638a2495afd082446c39faf9362578bd0f758d04
(cherry picked from commit 15b033d1dd09cd1898a994a0f12e38ed5cf847cb)
Reviewed-on: https://gerrit.libreoffice.org/37992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agoResolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling
Caolán McNamara [Tue, 16 May 2017 09:12:09 +0000 (16 10:12 +0100)]
Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling

convert number of "lines" scrolled to double and allow
fractional parts of lines/columns

Change-Id: Ib99c815cfc8823e22fc1d76e201903c34ed0f61b

Related: rhbz#1367846 queue and merge scroll events

Reviewed-on: https://gerrit.libreoffice.org/37779
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 7f60978b2ccd0e17816b78bde60c6e0e60a9d52e)

Change-Id: Ib45f61bbb35bd240829491ac8a79803222974778
Reviewed-on: https://gerrit.libreoffice.org/37913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agoResolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entry
Caolán McNamara [Mon, 22 May 2017 11:05:17 +0000 (22 12:05 +0100)]
Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entry

we don't need MakeHexStr either, the colorbox will do that on its own

Reviewed-on: https://gerrit.libreoffice.org/37898
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 7539c77fd49889015ad3a952009e33fac5324df6)

Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53
Reviewed-on: https://gerrit.libreoffice.org/37905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agoofz: check for null para
Caolán McNamara [Sun, 21 May 2017 13:44:37 +0000 (21 14:44 +0100)]
ofz: check for null para

Change-Id: Id31273b2a203414f8ad4f827c334ae17689560af
(cherry picked from commit ebc2abf207c8d903b07f53ecefbca5731edcb1d6)
Reviewed-on: https://gerrit.libreoffice.org/37876
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
5 years agotdf#107877: Don't crash if all bitmaps are deleted
Xisco Fauli [Tue, 16 May 2017 10:25:24 +0000 (16 12:25 +0200)]
tdf#107877: Don't crash if all bitmaps are deleted

Change-Id: Ie21f8cf1ead7c75017ee09436102f87f5d5dc04c
Reviewed-on: https://gerrit.libreoffice.org/37673
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 9d55ce72b69934d17360142f88a699397e0aa41f)
Reviewed-on: https://gerrit.libreoffice.org/37724
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agotdf#100033: Frames with the same name are removed
Tamás Zolnai [Wed, 17 May 2017 12:43:18 +0000 (17 14:43 +0200)]
tdf#100033: Frames with the same name are removed

Allow to have frames with the same name. For removing
real duplicated frames (generated by LO earlier)
check other things also next to the frame name:
position, size or whether the two frames are anchored
to the same position.

Reviewed-on: https://gerrit.libreoffice.org/37702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 6952d696439981962ad378aa28b0d16ea6e48f0e)

Change-Id: I191ae5128d0228eb85f78f065b44b1f0b3ba6dcf
Reviewed-on: https://gerrit.libreoffice.org/37706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
5 years agotdf#107811: expert config, deal no parent case
Julien Nabet [Sat, 13 May 2017 10:03:48 +0000 (13 12:03 +0200)]
tdf#107811: expert config, deal no parent case

bt part:
3  0x00007ffff73c7ee2 in __GI___assert_fail (assertion=0x7ffff7ba5107 "false", file=0x7ffff7ba4ef8 "/home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx", line=1399,
    function=0x7ffff7ba6d00 <rtl_uString_newFromSubString::__PRETTY_FUNCTION__> "void rtl_uString_newFromSubString(rtl_uString**, const rtl_uString*, sal_Int32, sal_Int32)")
    at assert.c:101
4  0x00007ffff7b6a28b in rtl_uString_newFromSubString (ppThis=0x7ffffffef1b0, pFrom=0x55555e122230, beginIndex=1, count=-2)
    at /home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx:1399
5  0x00007fffa6e69136 in rtl::OUString::copy (this=0x7ffffffef1f8, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223
6  0x00007fffa6fed67b in CuiAboutConfigTabPage::InsertEntry (this=0x55555bda0b20, pEntry=0x55555e13eb40)
    at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:874
7  0x00007fffa6fed415 in CuiAboutConfigTabPage::SearchHdl_Impl (this=0x55555bda0b20) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:848

Change-Id: Id9d1003a0e5e52abb878229e710e3fd4612789a1
Reviewed-on: https://gerrit.libreoffice.org/37568
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 8aee79e35208dd263928d7f5daa3f931fd3de99d)
Reviewed-on: https://gerrit.libreoffice.org/37570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
5 years agotdf#107920: Crash when using ScCompiler in condformat
Julien Nabet [Wed, 17 May 2017 22:03:32 +0000 (18 00:03 +0200)]
tdf#107920: Crash when using ScCompiler in condformat

Just call SetGrammar from ScCompiler object with grammar of document
See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382

Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3
Reviewed-on: https://gerrit.libreoffice.org/37739
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 63843a97262ccfa38d838a9cbbc3faadba8290a6)
Reviewed-on: https://gerrit.libreoffice.org/37756
Tested-by: Eike Rathke <erack@redhat.com>
5 years agotdf#107892: fix negative values case with maxifs
Julien Nabet [Tue, 16 May 2017 21:50:46 +0000 (16 23:50 +0200)]
tdf#107892: fix negative values case with maxifs

std::numeric_limits<double>::min() returns positive value for float/double
so use std::numeric_limits<double>::lowest()
(see http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values)

Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e
Reviewed-on: https://gerrit.libreoffice.org/37693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 20d3a60b41bda2513723c145d919f584840b1056)
Reviewed-on: https://gerrit.libreoffice.org/37730

5 years agoofz#1605 check multiply and shift
Caolán McNamara [Mon, 15 May 2017 10:17:57 +0000 (15 11:17 +0100)]
ofz#1605 check multiply and shift

Change-Id: I6aad9ad23e7bf080b3b610223f92df7074530beb
Reviewed-on: https://gerrit.libreoffice.org/37642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>