Public Git Hosting - LibreOffice.git/log

Resolves: tdf#148053 fix a crash in out of range dx array

also seen with tdf#124116

Change-Id: I211c5b9d58ee5857c8286b2009e4159b35a9e047
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131602
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 29e996bd5e364e1b6b22d88d56d28dac7d3c97d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131865
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#147143 Word selection error in Arabic text

this reverts
    commit 563af8fd15aa37e75af8882cccbdf8914ebe8e61
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Fri Jan 7 22:50:29 2022 +0200
    tdf#144890 Invalid selection area when text in LTR run
and
    commit ec50b9e5eaec7c94df35617676077ef0d65cecc7
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Thu May 27 11:16:11 2021 +0200
    no need to allocate Sw2LinesPos separately on heap

No idea why the commits caused trouble, clearing there is some
"interesting" interaction going on.

Change-Id: I606768403db777b61554f378d3f69f9b4d33d493
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131533
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 22be1665dc6eb28ea1d52c7c5e4347628fc5a76b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131477
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 1b94a54826d4f8a4ae0c670868c317d68e246e3e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131481
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

tdf#147961 Crash Typing "++" and press Enter (AutoCorrect Create Table)

regression from
    commit 7cd5b35caa8d4fa9d0ba2b2c6ce4b88726ed2be6
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Fri Sep 24 13:21:35 2021 +0200
    return SwCursor from IShellCursorSupplier

Change-Id: I6a4e3f90653dc96a91091be1372f27c6303ba346
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131505
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 7c7f00a89a675dad541d32ea60695a7b11210102)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131470
(cherry picked from commit bcd3275a8c2088308970e012cf39c4753f5e582a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131471
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

update credits

Change-Id: Iae73e10952fcb87e9fe24a5d053bc3ab554b688e
(cherry picked from commit 4ac4d643425c26870bd6e0bac26bb5896186875c)
(cherry picked from commit 99165a82e31e4a761ae78e34adee1801877aeb1f)

Update git submodules

* Update translations from branch 'libreoffice-7-3-2'
  to 01f6609411c86665810950e050a0843608dd1dda
  - update translations for 7.3.2 rc2

    and force-fix errors using pocheck

    Change-Id: Ib6480bab155b2e9002bb08ae031971a7e5a5c184
    (cherry picked from commit a780685ea4662366848e750da1a99a6cd64703fe)

tdf#147928 "undo" may delete the current SwAnnotationShell

Change-Id: I69fb7e65e28743aa73e943e02d5029654b5543cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131366
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 15fb24db540dc29883346d7e8e37d96e4fe8dfb1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131472
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

hwpfilter: why isn't that path string null terminated

Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 4c86ed851bc1c0a2414e254082064760c99437f1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131589
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit dc566a7f687a728311490b5f4f624897f0aefd1d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131594
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

sw_redlinehide: more issues with SwEditWin Surrounding functions

.. and SwEditWinUIObject.

These need to work with TextFrameIndex. Add some functions to
SwCursorShell to make it possible.

Change-Id: I884c4822a0e7ecf254ea09a893762e1e6d539534
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131042
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 112592ac580108998a2cd99ae9bbf376c80c10d8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131109
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131552
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

sw_redlinehide: fix crashes in SwEditWin Surrounding functions

These foolish functions write into the shell cursor!

But the shell cursor's node isn't necessarily the same as before with
merged paragraphs, so could crash with out of bounds indexes.

Better use Push()/Pop().

Change-Id: I4fd0e2aa915b6c5448772a2c766848607bbf5aaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131041
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit aac9bd235e65b27faf63e64bba3ecd94837381d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131127
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131479
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

use internal SHA256Thumbprint api

Change-Id: I6a51359af58dbb79b6a0399944030dbcbe97152b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130963
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit f30bc3ccdfb48356910d64ee4a3dda685b11de93)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131202
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 08a9d2d250e041c3a6e7f7570cd2d6964dd96182)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131348
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Miklos Vajna <vmiklos@collabora.com>

tdf#147767 html pasted to calc has very small font

regression from
    commit da9bba7cc3c243e936daea689fea64ecaf110f35
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Mon Jul 26 10:10:17 2021 +0200
    use officecfg for SvxHtmlOptions

Change-Id: Ia84d713a18b4c694af98478681996b6156cbb928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131393
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 15c097010f1567d933abf046bc43447bd7415e4c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131364
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f7f28aa16efd4a113df0f8646fbb9b100acda8ec)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131469
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#147744: Make sure to pass valid position hints.

When pasting a single cell to a range with filtered rows, the existing
code wasn't updating the position hint iterator after inserting cloned
formula cells via ScColumn::CloneFormulaCell(). This caused the next
call into the cell store to receive an invalid position hint.

This problem has been there all along, but apparently it did not cause
a process termination with the previous storage layout of
multi_type_vector for a reason unknown to me.

Change-Id: Ie1a4b99c7077536499c6373ccb7022961e9d93e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131331
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
(cherry picked from commit f19ae9b5e629d163314ee18d56973d0561d5fb3b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131378
(cherry picked from commit 7049b1da30f715c502f38ed982eec037e096be08)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131406
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

bump product version to 7.3.2.1.0+

Change-Id: I8267895cb7839c333f74a4cbc20cda958d6f60e5

Branch libreoffice-7-3-2

This is 'libreoffice-7-3-2' - the stable branch for the 7.3.2 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.3.x release,
please use the 'libreoffice-7-3' branch.

If you want to build something cool, unstable, and risky, use master.

Update git submodules

* Update translations from branch 'libreoffice-7-3'
  to 67855245915e5d354ad30cd969de3660cf36cfc2
  - update translations for 7.3.2 rc1

    and fore-fix errors using pocheck

    Change-Id: I2f3b0bda0460d46862b3e684140bb96e8cafb87a

Resolves: tdf#146825 select under mouse on right click

if something isn't already selected

Change-Id: Ifa692cd71bb71ecb5c7af732deef510f2bac5fce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131130
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

proper columns range check (tdf#147830)

Change-Id: Ib23bc3f194fa418035e7c70a4f3e1b682f9c46b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131181
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit d032b81bbf2ca87114d15749d74166d0ba414972)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131194
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Sukapura: Update Frame Line Color icons

Change-Id: Ie6cab6f9853f4a6d338f6291b5e093efe1b0cec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131191
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Sifr: tdf#147838 image for Base preview

Change-Id: I3348ae989b57477ffa741b7f4e38ec9114fef66e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131189
Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

KJ: tdf#147838 image for Base preview

Change-Id: Iee19c5a60aa0f1f7e17a446661f1db3741e1350f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131144
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Breeze: tdf#147838 image for Base preview

Change-Id: Ib37ec53fed6d6d9ac2a39f9e81aff5564fb1d34a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131146
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

elementary: tdf#147838 image for Base preview

Change-Id: Ie840eae9f0ee2e05d76b21f7595e9d157b61baf5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131142
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Colibre: tdf#147838 revise Base dummy preview icons

Change-Id: I72f19849f48566769a12be8a3b04308c8fcf7846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131138
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Colibre: tdf#137520 Increase & Decrease Font icons

Change-Id: Idea7c926304008c00b281da6c9a37ceae4e6c9c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131140
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Sukapura: tdf#147835: Fix paragraph direction

Change-Id: I6cfb44ed407048c5ed77783889519ccb595541b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131136
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Revert "tdf#135843 Implement inside horizontal vertical borders."

This reverts commit 90f19b66d81b0a4958cacc40d2be0516f281d702.

Reason for revert: See tdf#147766. Reverting in 7.3 branch only

Change-Id: Ibda51d5cf4544383bdeb7896e1be31de759575a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131129
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

cid#1500515 Dereference after null check

Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130257
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#140077 sw_redlinehide: fix crash on SplitNode()

The problem is that CutImpl() was called with nLen=0 and so returned
without sending any hint to SwTextFrame.

Then the MergedPara gets recreated, but the problem is that the
SwParaPortion is never invalidated so it still contains the portions of
the previous merged paragraph, and painting it will crash.

But it turns out that there isn't a hint that would actually work here;
instead, generalise a condition in SwTextNode::SplitContentNode()
to simply throw away the portions.

(regression from commit eb92dc08f2abf5ed088da0d736266f213adf00de)

Change-Id: I06091ca695ea9180b32e61ddb88ce64fbf20443e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131039
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 6518c45dc0c2fb67500af85b97ed40466fd1d1e0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131025
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#146562 let toc default size and pos on first launch

so only use resize_to_request when the user toggles the checkbutton

Change-Id: Ib5fdac56da0441fae482bc9f2120d1d3ce173fe8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131023
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

uitest: simplify tests even more

- No need to open the dialog to click the cancel button
- Avoid repeated calls to document.DrawPage.getByIndex(0).
Similar to 26298f29e9d36313be527b785a9bb96089582037
this might fix the different failures these tests sometimes
have

Change-Id: I4e175b6c5d48c4651e5877ec2a72c4858b590321
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130727
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131102

uitest: remove duplicated tests

They are pretty much the same as the other one in the
same file

Besides, the 'with self.assertRaises(IndexOutOfBoundsException)'
nonsense

Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131101

ofz#45314 limit to valid day/month indexes

Change-Id: Ibf53fa1a0c1db3046a25367fb79da3b90f7cd924
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131020
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

uitest: fix sporadic UITest_impress_demo failures

Revert 9158d2d2f19cf7bccba12d2ad4cb340e882b51cc
< blind fix for UITest_impress_demo failed >
and 99d2ee15ad6fae7073a53f7df8868300328a36e7
< blind fix for UITest_impress_demo failures >
Instead of asserting the shapes' properties directly,
Use the Position and Size dialog

Change-Id: Ie9aec0dbd1f1fc2ccab0993b428c8ac17938b3b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130724
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 30c302cf489571ef13579c1ecd27c276945138d0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131022

ofz#45255 handle short O_hhea table

Change-Id: I649dfdb3eff868441125fbf62ff3c7d0d18d8d19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131015
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: Too many hatch points

Change-Id: I08cb9d09a9bb48ab31763f50bc2fa23cf723330f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131013
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: record less than 10 bytes is invalid

Change-Id: Ie6b88efbc12b4c7fddb7459e50cba28fcbcf35fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131010
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

cid#1500690 Explicit null dereferenced

this may stem from:
commit fcc31cd0e0a6544a13dac0fdc66005d77f6f5cf9
Date:   Fri Sep 7 18:41:58 2018 +0200
    Revert "clang-tidy performance-move-const-arg"

    This reverts commit 3d604d1cd6cc70ef96782ef769f0479b509987a8.
which didn't 100% revert 3d604d1cd6cc70ef96782ef769f0479b509987a8

so we went from:

LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pMasterPersistPtr)
: SlideFragmentHandler( rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout )

to

LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pMasterPersistPtr)
: SlideFragmentHandler(rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout)

Change-Id: I90cb437c467f88c75d248ed138d078bf56705a21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131007
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

clamp and add some logging like SvmReader

LIBREOFFICE-OWMTGGWJ

Change-Id: I8f744e1ab2684a0f0995abcc3e753a684a3b970a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130981
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

clamp in StretchTextHandler like TextHandler

Change-Id: I4e1247ef2945f46cd1e60e9e473c1a589f990bb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130980
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

tdf#38669 - Create the key event using a Unicode character

Instead of using a plain char, create a key event using a Unicode
character, otherwise the key event creates texts including rectangles or
wrong characters.

Change-Id: I9ec0d64998927d54eb3ae90a192c3b28e235f56d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130721
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
(cherry picked from commit 9d25f86236885c40662bcd24517f231688361e8c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131018
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#147121 PPTX: fix regression of font size export of empty lines

If the empty line has got direct formatted font size,
don't forget to export it, unless the master setting
is applied.

Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e
"tdf#111903 tdf#137152 PPTX export: fix placeholders".

Change-Id: If686e487bca9c198fd7c96860a21e4efe91381bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130005
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit f29c14e8c36819296d0c66bb995201acf0a2647e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130675
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#136632: Use 'Save transparency' when exporting selected objects for PNG

To avoid some regression, consider that transparency should be enabled by default.
So only remove transparency if it's required explicitely.

+ change QA test since "Translucent" property isn't a bool but a sal_Int32
In officecfg/registry/schema/org/openoffice/Office/Common.xcs:
<prop oor:name="Translucent" oor:type="xs:int" oor:nillable="false">

Change-Id: I9bfb6aae8e2e8a31dee82f73a9165989129f222a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131057
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131061
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

Fix tdf#147755 by copying the vector.

Revert partially 224953d896a3dba5d85992394525ab8b54d8c314

Change-Id: Ic12d3b0a080ad3af69fa5c4e8c9b4d331305a663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 82f9e12b737b3dbdf8cb9175c94d61005b666725)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131012
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#147565 Make navigate by comments skip hidden comments

Change-Id: I80f55146529505e5b6146db8cc324971fbc475e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130518
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 5df0289f6af5aa7142017b56a8e17c134d54fe41)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130644
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

ofz: detect endless loop in font processing

Change-Id: I4e6c61d8be15a560f43b5d37d646e7bad9739eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130778
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins

compare authors using Thumbprint

Change-Id: I338f58eb07cbf0a3d13a7dafdaddac09252a8546
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130929
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 65442205b5b274ad309308162f150f8d41648f72)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130865
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#45165 verify table offsets

Change-Id: I99649a03da28d3b896bed72999b50803ce0a4761
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130857
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#45073 don't dereference null pointer on bogus font

Change-Id: I28616696833b87c300d2ee7061a15921042934b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130613
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130937
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: Use-of-uninitialized-value

Change-Id: If10e8d2465ef6de62583f6547e3f68e92002f3f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130863
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: check hmtx offset

Change-Id: I650a37472c70771d40febe52efcb723195856421
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130912
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

Handle symlinks

LIBREOFFICE-PQ967WYM

Change-Id: I5e4df92401e009fe6b7238565d1223cfb77d10ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130930
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit c1ac79906bde5c902be5cb0ae6b530da96e52169)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130862
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

tdf#135843 Implement inside horizontal vertical borders.

wholeTbl as TableStylePart should be handled in different way. Before
left border of the whole table was handling like all cells left
border but it should be left border of the first column.

insideV and and insideH properties are imported but never handled. I
added the inside vertical and horizontal borders handling.

Change-Id: I5aea5cbefc746db637eac6c1438fa70a7d741bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128971
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
(cherry picked from commit 3faf005a367cbd28077403bf93810bbaf4805851)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130860

tdf#135843 Do not export unused border lines.

Setting as XML_solidFill all borders caused wrong exported borders.
All table parts aren't used for all table styles. We should set borderline
if only they had used.

Change-Id: I35b247f520c7d7862599ade2c6fdfb0d7efcd5c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129227
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
(cherry picked from commit 48575b3eb856406d9de406cb1d2de23866b0178f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130859

tdf#146171 DOCX: fix loss of change tracking, if no date

was specified, or it was specified as zero date (e.g. in
a LO DOCX export).

DateTime attribute w:date is optional in w:ins/w:del
according to the OOXML standard. Not specified w:date was
imported as invalid zero date "0-00-00T00:00:00Z" resulting
loss of change tracking data completely during an ODF
roundtrip.

Import this invalid zero date as Epoch time to avoid losing
change tracking data.

Change-Id: If8442db9aa5e41c470827545c36c64f598887101
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130885
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130907

tdf#118117 sc pivottable: STR_PIVOT_DATA is an existing name too

This fixes a LO 6.0 regression from
commit a078328e91ab9cbd78a92608c1abdc2c57ff9ac5

I looked for existing unit test examples using
assert (rLabel != ScResId(STR_PIVOT_DATA));
but found nothing.

I don't see the need for a unit test here.
The whole pivot table is messed up if you duplicate
a label, so why bother testing. It just is not
as bad now as it was before.

Change-Id: I59cc73becf91f766a29d2007c2d67685ffa2a65c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130751
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit b7f654a406b704f469d1df424d83a3d98ae46432)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130784
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

add a SwFrameDeleteGuard to SwSaveFootnoteHeight

Change-Id: Ic4f0bb7c26cc021119b09682075a05d5207b48a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit ac605821ecf3ea263d4812ebec352314a2dbff42)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130852
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: Use-of-uninitialized-value

Change-Id: I358d826a1dafe345f610d26d0d517a7357c838d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130853
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins

update credits

Change-Id: Iccc04d9704a9ee9800d2015b38e55e707ff69c41
(cherry picked from commit defa0142c92e50e7a24689bebac593db434bb778)

tdf#122471 xlsx import: pivottable error OUString, not uInt8

This fixes a LO 6.0 regression from
commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8
which only half-way changed to OUString from uInt8.

An exception was raised because in XLSX, an INT was written
while the corresponding read function was expecting an OUString.

However, doing this runs into problems with binary files (xlsb),
which were still setting the value to an int.
Unit test shows the need to use OUString for xlsb too,
which now matches what I see in Excel 2003.

make CppunitTest_sc_pivottable_filters_test \
CPPUNIT_TEST_NAME=testPivotTableErrorItem2FilterXLSX

Change-Id: I399c9e34984bb1ff71695a87aa56f53063d37b3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130714
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 6961f6732954742415413fa53bdeebd1b03d9ec5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130678
Reviewed-by: Eike Rathke <erack@redhat.com>

svx: the SdrObject of SvxGraphicObject can be nullptr

Crashreport:

        Graphic::GetType() const
                vcl/inc/impgraph.hxx:122
        SvxGraphicObject::getPropertyValueImpl(rtl::OUString const&, SfxItemPropertySimpleEntry const*, com::sun::star::uno::Any&)
                svx/source/unodraw/unoshap2.cxx:1466 (discriminator 1)
        SvxShape::_getPropertyValue(rtl::OUString const&)
                svx/source/unodraw/unoshape.cxx:1747
        non-virtual thunk to SvxShape::getPropertyValue(rtl::OUString const&)
                svx/source/unodraw/unoshape.cxx:1732

During SVG export of a selected shape.

Change-Id: I29b56d49b0c5418dfe8fec8491ac8667e5ade2ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130740
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130819
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit c1ce7d9f2c4036ae71f8cfa71e4bee4067f4d8d2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130848
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

ofz: don't read past end of record

Change-Id: I9fced38faf46dce9f4cc2b96e351e7ae945d0ac1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130825
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: measure legal range from glyph offset, not table start

Change-Id: I04c1036e004be678b70a7df197141970aa3c8b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130750
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130824
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

sw: really prevent footnote frame against delete while it's moved

This reverts commit fe5d3fbfe63fe8b433776bd3a0508dd712b868b0
(on master only)

It turns out that checking a single column's IsMovingFootnotes() is not
enough - as frames can move both forwards and backwards the entire chain
of columns would need to be checked.

(Most callers of MoveLowerFootnotes() move forwards, but one place in
tabfrm.cxx moves from a follow to master.)

But it turns out that this is probably the wrong way in any case: most
likely the intention in FormatAnchorFrameAndItsPrevs() is to format
previous frames in the same layout environment, so if there is a section
or column inside a footnote then this upper should be formatted, while
if the footnote is inside a section or column this upper should not be
formatted; this should make calls during MoveFootnotes_() safe as it
should prevent the formatting of frames in the footnote boss moving a
footnote that is already being moved.

So tweak the fix in commit fa1bcc22921941b2cd8a0b32fe0d15655d12d607
a little to make it more general.

Also it was previously possible that for a section with columns,
both the section branch and the column branch was taken, which seems
supperfluous.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130544
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 3f569ffc9238e6bf2915e78bf21c844ca5f1270d)

add a layout test to exercise UXTSOREL

Change-Id: I57b29dd7d73c08bdbf227676c4ce9034aabf418a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130493
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 10d46c0498b89350645cf45e744a528d3d8f1ac1)

Change-Id: I39487640322339fe4d511e845d9c6bced2ba9dad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130831
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

tdf#122098 xlsx im/export: let formulas guess their number format

SQUASHED backport: includes followup
commit 5a64b618d84edb65465950d54e3b4afc952a301c

This fixes the import side of a LO 4.2 regression
from commit 07b66cd3ac1a9f6c7b61a1d7da6e9d266e6de92d
and the export side of a LO 4.3 regression
from commit 69ecdad805281b2cb6ec2437da18daa19576deae

make CppunitTest_sc_pivottable_filters_test \
CPPUNIT_TEST_NAME=testPivotTableBoolFieldFilterXLSX

Change-Id: I4c680dbff844cf1eca52de641856daafa032eeb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130406
Tested-by: Justin Luth <jluth@mail.com>
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 8f5d8669ca74fed8608e438a8436c173e35d43a6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130386
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

ofz: measure maximum possible contours

Change-Id: Ie039abd835fef06514edde12b99e17360f5481a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130773
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins

protect frame from triggering deleting itself

LIBREOFFICE-N4LA0OHZ

Change-Id: I0d24277665a317f047b286fe0f0878b3814ded65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130788
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Resolves tdf#137381 - Use app colors on chapter numbering preview

Change-Id: I8e5edec1ad6f4b6f44855014ce91a642efbd75f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130133
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
(cherry picked from commit 87aeb7be943921942f791cd182122e8e073ce804)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130154
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Resolves: tdf#145580 need to use gtk_im_context_filter_keypress

for at least xim, ibus works fine. To reproduce under Fedora with gtk3
can use a keyboard layout of "US International with dead keys" with
export GDK_BACKEND=x11
export GTK_IM_MODULE=xim

and 'a in writer comment or calc header/footer dialog

Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130775
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

ofz#44997 Use-of-uninitialized-value

Change-Id: I3803232ddc7346967e22770ae2bdbc3378779f8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130488
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130523
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

lastPoint might be 0xFFFF

LIBREOFFICE-KYYAZMB9

Change-Id: Ic0d95bd39a01dc1e5e0fec83dcc2c40b3f23b747
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130461
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

cid#1501377 Dereference after null check

Change-Id: I9dceb5c33f62df16b43429ba502b0d12180fa403
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130694
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f5f3eaa63f24093453af08ad01967ae17f108af2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130673
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: verify table offsets

Change-Id: I49fa886508b3bf553d4f638bfe53c37fa3e2f338
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130682
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: glyph data must be at least 10 bytes long to be useful

Change-Id: I312c33c598013feced15c6f2dbcc66e493b703e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130686
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

fail more gracefully if m_aTmpPosition is empty

LIBREOFFICE-N4LA0OHZ

Change-Id: I7f863151f753ad5605c4f1f280cfd79aa4c6bce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130761
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz: don't register style if hbox load failed

Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130770
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#44991 keep paragraph's that failed to load until import is complete

to avoid dangling references to them

Change-Id: Ic8710f63a8cf6a6a665348c7c84bf0b43f0e2c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130642
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#45081 check font length

Change-Id: Ib8cea70652ae90403db3546c07d24a517b1ec93e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130634
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#45082 Out-of-memory

Change-Id: I274a6beeec0013f5b974017500fe31bcecabfa86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130636
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

Fix flaky test on Win64

Obviously the left values are unstable; they were excluded on macOS,
and they fail exactly on the same lines for me locally on Win64 build.
So just test that the values are restored after delete and undo.

Change-Id: I63dc50d223edb052a0ada200189cef94c2e0f8e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130738
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit da77aec27e3121c895a6c6c287225216489cc8bc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130769
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#146962 sw: hide deleted row at deletion in Hide Changes

In Hide Changes mode, deleting table rows with change tracking
wasn't applied on the table layout immediately, only using Show
Changes and Hide Changes again. Now the deleted row removed from
the table instead leaving an empty table row (except the last
row of a wholly deleted table).

See also commit 95213407dfcbf34056037d60243ff915340d1a2e
"tdf#146622 sw crash fix: don't delete already deleted rows".

Change-Id: I864957cafa38e631a65db0670c7b566cb689f4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130701
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit a74c51025fa4519caaf461492e4ed8e68bd34885)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130685
Tested-by: László Németh <nemeth@numbertext.org>

tdf#103800 PPTX shape import: fix regression of text color

defined by list styles. Properties in a:lstStyle of p:txBody
should take precedence over the same properties defined in
a:fontRef of style elements.

Change-Id: I02cc886eb9eba94f49fe413a63bf7c46c9e3c127
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130237
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130712
Tested-by: Jenkins

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

Small Caps icons

Change-Id: I1348cc7fbde63d335ba3676a4c424d76f8cf2349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130680
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

Update git submodules

* Update translations from branch 'libreoffice-7-3'
  to 1dab7b297f1b7c2c2ab834239fc40961f60b70e3
  - update translations for 7.3.1 rc3

    and force-fix errors using pocheck

    Change-Id: I41de399ba9bbdc8157aa5c04a76f1845d974fc8a

check if cast is to the right type

LIBREOFFICE-311XVJ95

Change-Id: I159f516daafad3e4088677fe2c8c6f5423b3e264
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130669
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

tdf#143239 sw: layout: invalidate fly position when moving off page

It's possible that flags on the fly are all valid when it is moved off page
when SwLayAction::FormatContent() returns and then it may not be positioned
again, keeping its (wrong) position on the old page and will appear to be
invisible unless you click on it.

(regression from commits c799de145f7e289f31e3669646e5bd12814e6c5e
and eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf)

Change-Id: If07d5af7b47eb288bef71d1b9e3459197b50fdc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130535
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit b14bb255199e7d6db6ec9155b5d9237cb35fdba7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130548
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

ensure null terminator

LIBREOFFICE-WB8DT2Q9

Change-Id: I98529325bbd3ff475ba84b4991eb17240440df4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130646
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins

chart2: Break labels text and limit the size to the axis size

Previously a long label wouldn't be broken into multiple lines
and be limited to the axis size if the chart sizing was automatic.
This would cause the label to distort the whole chart and make the
chart area very narrow. With this change the label text is limited
to the axis width and gets broken into multiple lines if this is
necessary.

BarChartVeryLongLabel.odp provides a test document which includes
automatic size and fixed size chart are. We make sure the area
that the label text occupies is not larger than the chart wall
size.

Change-Id: If58bfa3e51ab68f720f22df5416ae305401bcd34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129814
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit ca22f1ce703c1d03fc1b1ed1f5ac1fc903b09e6f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129900
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

chart2: crop x-axis label if it's too long on fixed size charts

If the label text is too long on a fixed size chart area, crop it
as we can't resize the chart area to accomodate for text breaking
into multiple lines.

The algorithm to determine if cropping is needed has assumed that
we need this in case the x-axis label is vertical, so there was
no check to actually make sure the text is horizontal or vertical
and in case it was horizontal, it has taken height into account
and not width, so nothing got cropped.

Change-Id: I8e73027fc51722280418c9e0be34ce487c41171e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129813
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 92da88582ae8d5ddbd786f9936e1b2b46eaddf2c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129899
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

tdf#147298: Add a simple test case for formula cell tracking by column.

Change-Id: Ibdd72c08f8660ade511fdce8b3fb7cd3ed97f4b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130511
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
(cherry picked from commit 974bf22680b702b9474d4a91dbf1d06a785ff774)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130554
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

tdf#146463 Apply data series filter to the chart legend

Consider a data series as hidden if there is no unfiltered value, do not
consider data labels. It solves a regression introduced when working on
tdf#134059.

Change-Id: I6072bf469137d70e0aa353ffbeb0d0a1216ffa5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128476
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 7c5cfe54357e4e8d08b4696e80741097d3335dcb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130645
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

ofz#44991 keep within legal ArrowShape range

Change-Id: I6bf70f27a66ba9b355a3f7ae0c68a696a7284871
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130561
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#44991 Use-of-uninitialized-value

Change-Id: I0e3bcce489b665bac3e470e743394935a2ba3a18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130557
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

cid#1500433 Using a moved object

Change-Id: I150cd0f021aeb1aefe411f19dfcac111ac35b295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130555
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

cid#1500654 Using a moved object

Change-Id: Ia4b74cdeeae7f0c03e7e050be30714f948c67106
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130549
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

cid#1500452 Using a moved object

and

cid#1500429 Using a moved object

Change-Id: Iecd989345cc043149ff1a2e24da4f6070c014c6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130550
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#44991 don't skip over terminator

Change-Id: Ibc942705a788db60c104d00916a45d595596285e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130559
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

ofz#45073 initialize names to NULL in case of 0 glyphs

Change-Id: Ie410d2a6f3d2fcda19b1925675bd7515673b07a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130563
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

tdf#146597 sw: fix freezing with GroupShape

in case it is anchored to character and wrap is none.

Regression from 8da3586cff9cc11cf5db985d19851f21f0d42eb8
"tdf#141220 sw: fix textbox popped out of off-page shape".

Note: This is a backport-compatible fix made also for the
7.3 backport. There will be a less urgent 7.4-only fix
for its unresolved group case soon.

Change-Id: I421c85e2dd16ad2649bc299fc4733d462be8d7b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130478
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
(cherry picked from commit e835c2c0d3aff4f1ee5d29c9eaf36400b1aca6a7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130456
Tested-by: Jenkins