Public Git Hosting - LibreOffice.git/log

don't overwrite the crashreport info that are written before upload

There was a race condition that the OpenGL code was initialized before
the old report has been uploaded. Therefore the OpenGL setting was
overwritten by the new start and we were not getting the old value.

Now we store any value that wants to be added before the dump.ini is
ready in a temporary map and will write them as soon as we write all the
common information.

This problem was introduced by the dialog requesting permission to
upload the crash report.

Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024
Reviewed-on: https://gerrit.libreoffice.org/31846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 80049d110a742060acedb89eaad763e66d7f75a5)
Reviewed-on: https://gerrit.libreoffice.org/31851
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a2d66138ffa6a5e886bdbb5fe05ee13a0618d27e)
Reviewed-on: https://gerrit.libreoffice.org/31944
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

tdf#101458 - check PNG for adequate compression

Change-Id: I7131d3b721ebb4d47b0bb43f09fcb9767f8ac6d8
Reviewed-on: https://gerrit.libreoffice.org/31190
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
(cherry picked from commit d96781383747299443f61e027285d54ffd5bc5c8)
Reviewed-on: https://gerrit.libreoffice.org/31412
(cherry picked from commit 1fd5c8080c47e75fff4aa377540ced29142da146)
Reviewed-on: https://gerrit.libreoffice.org/31605
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

tdf#104495: prevent autotext to crash when drag&drop

See bt https://bugs.documentfoundation.org/attachment.cgi?id=129407

For non regression, I retested tdf#91125 since the delete comes from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1

Change-Id: I7ce833ffce20f1f159242014ba8ffe0ce5b7b11c
Reviewed-on: https://gerrit.libreoffice.org/31773
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
(cherry picked from commit 8776c20c1c72110d0f205150913eb17cdf3f1aaa)
Reviewed-on: https://gerrit.libreoffice.org/31784
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 56261b0bb06e29b71e2cc555086100282e54d62e)
Reviewed-on: https://gerrit.libreoffice.org/31794
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

oss-fuzz: handle W_META_CREATEFONTINDIRECT like EMR_EXTCREATEFONTINDIRECTW

Change-Id: Iaa142d5d0ac0f00e89e8b7d7ffdef8137157cec9
(cherry picked from commit e718ac0ae415bba2988c96c36995755bbfd9df7f)
(cherry picked from commit d3ea20e55ca7d82b6121f7ed3db5fd170fcac94f)
Reviewed-on: https://gerrit.libreoffice.org/31839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 28ed3227267f7a00273595a60206744fd3c78b96)
Reviewed-on: https://gerrit.libreoffice.org/31936
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>

add Venetian (vec) ui language

Change-Id: I643eb91691dddf2c4ece2edb27383cb7dd0e3fdc
(cherry picked from commit cc89cb56d51b4f43d999701ff97a89ff9fb5a31a)
Reviewed-on: https://gerrit.libreoffice.org/31727
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

update credits

Change-Id: I0d80228d2e33c03daacb0b3be4c5f3fc90324836
(cherry picked from commit 2b5305d3020435c57d75d19f332acea10049ef69)
(cherry picked from commit 6e292a8a5a9e4dd8db68ce02643d1994d9759ce5)

update credits

Change-Id: I8ce476f182ce5004619a8380b9effb135bcf7d55
(cherry picked from commit 4136757b4e51c4e6f7cb4132c95538a7f831ef2c)
(cherry picked from commit e3b9d6c03f106b2cd5e96858347dd6c12b83d867)

Resolves: tdf#104152 suppress notifications from EditEngine during Paste

Broadcast once at the end instead to notify a11y.

(cherry picked from commit 7c20d0174c59d46b11fc5029fe3fc0c00f5dc6d0)

Conflicts:
editeng/source/editeng/impedit.cxx

Change-Id: I12383b6efbbb2b149f0d73c67d8576fcc050b253
Reviewed-on: https://gerrit.libreoffice.org/31427
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103756 fix crash of this on 5-2 with initial backport

This crashing when the user hits ctrl-Z, because when I backported:

    commit d1909ab7940109ce7d43da04e480db4e82b8310f
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Tue Nov 8 16:15:55 2016 +0200
    tdf#103756 - CTRL+Z not working to undo changes performed through
      Navigator

I missed that the older version of SdPageObjsTLB has two constructors
while the new version (on master) only has one, and I only added the new
line of code to one of them.

Change-Id: Ic5bc59a20e26fecb823f5b0fadba874b947e77ad
Reviewed-on: https://gerrit.libreoffice.org/31680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 78223678b7513ffe46804cb08f2dc5bc899b2bab)
Reviewed-on: https://gerrit.libreoffice.org/31708
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

bump product verion to 5.2.4.1.0+

Change-Id: I03ca7cbd2e6418d4f6199cf2852ce5789f7f8504

Branch libreoffice-5-2-4

This is 'libreoffice-5-2-4' - the stable branch for the 5.2.4 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 5.2.x release,
please use the 'libreoffice-5-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Id7a88dea28124e8be0a2f7a4343bdaab86633315

update emoji autocorrect files from po-files

Change-Id: If5bc2d9254832aad2c09092329a6c91bff211352

Updated core
Project: translations c11aab0b76ae0d9ea5627fedfda8a96657728faf

update translations for 5.2.4 rc1

and force-fix errors using pocheck

Change-Id: Ida54423aa1aac9b41d78099054649d943f010aed

Resolves: tdf#103493 copying note captions needs a completed destination sheet

If a copied sheet's destination position is before its source position, the
source's ScColumn::nTab members still pointed to the original source position
when the captions were created, which led to the wrong drawing layer page being
used and at the end the drawing shapes not being correctly assigned.

Change-Id: I9c3cc97d8b4486756023b9ab02da28079a1d0627
(cherry picked from commit 0a2a7436b4041bb34b01a183b9264af8488d1af3)
Reviewed-on: https://gerrit.libreoffice.org/31229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#34467 - FitToFrame: stretch text to fill drawing obj

Help for Fit To Frame says "Resizes the text to fit the entire area
of the drawing or text object".

reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef
and partially addresses the problem of "Shrink font automatically
when text overflows" by treating text as "Autofit" while it is being
edited.
It's not WYSIWYG, but good enough, and maybe better.

Since that part of the change prevents any way of setting ::Autofit,
I also changed clearing of Fit To Frame to Autofit instead of NONE, since there
is no good reason why text should be allowed to spill outside of a textbox.
For those who REALLY want that odd behaviour, they can use
.uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none".

NONE is still the original default if "Fit to Frame" is never touched. So it
can look a little inconsistent.
1. Turn off "frame height expands with text" and Fit2Frame defaults to
NONE - text can spill out of the textbox.
2. Turn on "Fit to Frame" and Fit2Frame is PROPORTIONAL - the text stretches
to fill the frame.
3. Turn off "Fit to Frame" and Fit2Frame is AUTOFIT - the text will shrink to
fit nicely inside of the frame.

Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9
Reviewed-on: https://gerrit.libreoffice.org/30727
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-on: https://gerrit.libreoffice.org/30869
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

tdf#104144: Missing dashed border, "break" should be "fallthrough" after all

...5ffd2c1595d1f67f5e4b14e48188a1f37f1956b5 "Presumably missing break in switch"
apparently decided wrongly in favor of "break" over "fallthrough".

Change-Id: I90372faac84a26514f5dc936e0e393a1ca12effa
(cherry picked from commit 787d31a94510ca3de9ce582d7b7402dfca584b23)
Reviewed-on: https://gerrit.libreoffice.org/31314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#101327 - tolerate exceptions during window construction better.

It appears we can end up being a frame window, which is not added
into the list of frames; so tolerate that.

Change-Id: I7696e79636f7794f327027f0ca73363eef1937e5
Reviewed-on: https://gerrit.libreoffice.org/31235
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 115671bf929a82709c535b475bf19f4967a666c8)
Reviewed-on: https://gerrit.libreoffice.org/31255
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#99687: Find Text widget fails to emit object:text-caret-moved events

Must be an integration bug:
efb23f29983f87104a684e7fab00b84fc59d131d

Change-Id: I53b15975fb97a299103fab870307b03b2607e9e5
Reviewed-on: https://gerrit.libreoffice.org/31238
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit c1afa80bb3613c9202fa9d83447fdd5d57667cb6)
Reviewed-on: https://gerrit.libreoffice.org/31247
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

respect read-only config items in Options - Load/Save - General dialog

Change-Id: I110e8eb2b858c8b86b01d46bec40873939ae53d8
Reviewed-on: https://gerrit.libreoffice.org/31237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 5f9bd7677047abfc9d3bde0db78f74ff23204f0d)
Reviewed-on: https://gerrit.libreoffice.org/31239
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#103788 sw: fix use-after-free in navigator dialog

The problem is that if SwContentTree::HasContentChanged() returns true,
it may have deleted the SwTypeNumber instances that are referenced in
SvTreeListEntry::pUserData, but it has not reset pUserData so those
pointers are now used to acceess deleted objects.

Also it looks like the HasContentChanged() detects additional conditions
that would not cause a modified event from the document but should still
cause a repaint, such as when the user moves the cursor between
headings.

Revert the optimization, it was a stupid idea.

(regression from 329742e6c9da7cd7848d92a6846e3d1249d8d9b4)

(cherry picked from commit cbdf4e007650cfda4f7808402e8e24ae66d45792)
Reviewed-on: https://gerrit.libreoffice.org/31194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit dbfa3841018672d8af8e9bf1bdb4caf6cdf0ce7d)

Change-Id: Idb5207e896b0638324fc41b7c214536be4ba864b
Reviewed-on: https://gerrit.libreoffice.org/31200
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#104201: PPTX: Group solid fill is not imported

Reviewed-on: https://gerrit.libreoffice.org/31263
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 7c5aaa254f444d54b9ebf6574f0ccd37af548ee5)

Change-Id: Iec273714108598d7017e73a9e7d384f8410d6ee1
Reviewed-on: https://gerrit.libreoffice.org/31267
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

tdf#104015: PPTX import: Title shape does not inherit fill properties

...from slide master.
The problem caused by that PPTX files contains not a
one-level master slide set, but has two levels: one
called slide master, other called slide layout.
Slide layout inherit properties from slide master and
normal slide inherit propetries from slide layout.
Bug appeared because, slide layout inherited properties
were not forwarded to the normal slide.

Reviewed-on: https://gerrit.libreoffice.org/30969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 8d613870b2cd2e3e4396b4fa97dbd8080fda8f52)

Conflicts:
sd/qa/unit/import-tests.cxx

Change-Id: I587582498cf4315087f9a576c1b7fc41ee23e2fd
Reviewed-on: https://gerrit.libreoffice.org/30971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

tdf#103876: PPTX import: Title shape's character properties are wrong

Text properties are applied on a shape during text insertion,
but if a placeholder shape has no text, then it has a placehodler
text which should have the right text properties.

Change-Id: I54175d52dd25915ee4d7153298e01ec07c6be1f6
Reviewed-on: https://gerrit.libreoffice.org/30881
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 5c7f3e4a7190bf9821bed102f96a926c9a894e59)
Reviewed-on: https://gerrit.libreoffice.org/30940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Related: coverity#1371267 copy ctor broken, nPagePos not copied

initially operator= was removed by

commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb
Date:   Fri Oct 3 10:39:28 2014 +0200

    remove SvRefBase::QueryDelete

and then operator= was restored by

commit faa6455995966e41653204779d055b885b27fc4c
Date:   Fri Oct 10 12:02:32 2014 +0200

    add copy constructor for ONDXPagePtr class

    which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb
    "remove SvRefBase::QueryDelete"

but nPagePos was missed

Change-Id: I6497934d4a199f5ea94cf2da840c164910e7a826
(cherry picked from commit 8ceb8b2d141a249127822bd511e66dd855fb1e59)
(cherry picked from commit 93154946452fdedad9b8b536ec3d9704a4707304)
Reviewed-on: https://gerrit.libreoffice.org/31166
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

tdf#103185 - Add VCL backend being used to About dialog

The VCL backend is now shown on the About dialog.

Change-Id: Ib4e6b33e9c2b3ec2fca229fed8f4533227a67ac6
Reviewed-on: https://gerrit.libreoffice.org/29798
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 6b5b773488a4ab77b5c18d82e663e68692f14b33)
Reviewed-on: https://gerrit.libreoffice.org/30039

tdf#103852 avoid clipboard deadlock

Deallocate the XTransferable object async using AsyncCallback
(that uses Application::PostUserEvent) which executes the
callback in a thread-safe way on the main thread. This avoids
a deadlock at deallocation so that the XTransferable.

Modify AsyncCallback to not hold the SolarMutexGuard because
Application::PostUserEvent is considered thread-safe.

Document Application::PostUserEvent thread-safety

Reviewed-on: https://gerrit.libreoffice.org/31126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit bdd108cd72e630189c360c5327c480c1d64d55b1)

Change-Id: I4237a1cf380e8be66b3eefc393a58bb4853bf4e1
Reviewed-on: https://gerrit.libreoffice.org/31168
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

with wayland scaling cairo is meddling with our font

so I see mixed large scaled and small unscaled letters in the writer header/footer
widget among other places

so don't give it our FreeType font face (FC_FT_FACE), keep that for ourselves,
but instead set the filename and face index and let it make a new one itself.

Reviewed-on: https://gerrit.libreoffice.org/31127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 8c3e1465223bd8c824c4cecfd0e6fc387583e592)

Change-Id: I2e5eceb7bf590ccfeb06123d0404120feacfff97
Reviewed-on: https://gerrit.libreoffice.org/31155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

drawing shapes aren't tracking style name changes correctly

in draw, create a box, enter some text, exit and select box
F11 for style navigator, new style, set font to e.g. 88
apply this style to the box. All ok.

If you modify the style and changes its font to e.g. bold
the text in the box tracks it as expected. All ok.

If you modify the style and change its name, the box resets
to something different and there's loads of warnings about
unknown styles. Not ok.

The style modification fires, but the style name gets overwritten
by the style stuck in a OutlinerParaObject that gets overlaid
over the editengine.

All the rTextProvider.getTextCount uses that don't iterate over all entries
look dubious to me, but I'll initially fix this one that I have hard evidence
for as broken.

All this is probably broken since...

commit 838c0fa8228f4ca656a264f6a5610c337ebf4fef
Author: Rüdiger Timm <rt@openoffice.org>
Date: Wed Mar 12 08:47:30 2008 +0000

INTEGRATION: CWS impresstables2 (1.14.72); FILE MERGED

Change-Id: Ib0dd2857ed26c49dcfa00aae923e36429a7f7862
Reviewed-on: https://gerrit.libreoffice.org/31151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Resolves: tdf#89760 add and use a ToolFontColor for toolbar item entries

instead of using the MenuBar text color, cause for Ambiance theme the
menubar is dark and its font is light, while the toolbars can be light,
so light font on light bg appears greyed out

(cherry picked from commit b79cf88a048e5d8c784c97d99155104aef3d5dca)

Change-Id: I0fa4ab8eabdd3cd69eb682e5ddba8314b8c9ff0f
Reviewed-on: https://gerrit.libreoffice.org/30937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Resolves: tdf#92776 backport gtk3 >= 3.20 themeing improvements

Related: tdf#92776 set parent style of notebook to toplevel window style

Change-Id: Iec16b2617c82c363a540f967f66c514b5b2b104b
(cherry picked from commit 570669631359021a8ad420753c87bcf4419d06cd)

Related: tdf#101699 gtk3: get correct combobox and listbox arrows

Change-Id: Ib2322bfda09b05925c74d93a530b9ed9fac73032
(cherry picked from commit 6e8dbdbe1a9d15d7e7d000e4132fd5df3fecd660)

Related: tdf#101699 gtk3: get correct arrow width

Change-Id: If02c598306ec6f19cf83958c4a176cafa67076dc
(cherry picked from commit 4cb720836ab03701ce508e302790c115c7808619)

silence warnings

Change-Id: I80abf5092c7d4e7b8cf75e4b79ffdb9a5e0c7580
(cherry picked from commit 7ae079274d15ab309c9811c0b3966bed727a6afe)

loplugin:nullptr

Change-Id: Id9f702b2772a23c52a9b829093d10c83a5ab3acd
(cherry picked from commit 1f8f140601bd654f97d0c1e6e05b3bef949ddfaf)

bundle duplicate code together

Change-Id: Id67e5026e21138c0583df8099436da01e4e2dab3
(cherry picked from commit e3fca8b4a0f5e517f994b35f1d4ff152fb17c3a2)

split these ifdefs into larger blocks

Change-Id: I501d06096aa51066af8806277b7d392e39747494
(cherry picked from commit d5b8b98393f529d1181b0305313a95ab90ef0bf2)

gtk3: select old/new gtk theme behaviour etc at runtime

Reviewed-on: https://gerrit.libreoffice.org/29969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 70f7697c4243739c28feaa33b091f6c64a8356cb)

Change-Id: Ie09419049e3d839315f4fc8a937f0dde74688d98

need 3.19.2 or above for these

(cherry picked from commit dd04278bfc3c89336283fcab1222147dcd796a77)

Change-Id: If385b45b12c72a0d7460a9a4c9d0b0e3bfc1195e

use released 3.20.0 instead of 3.19.2

(cherry picked from commit 4fce8bd59eae6d2ed6e5a3f9a3d4898fcd3431a9)

Change-Id: Iac311e0c326cf79a2dbacb889d39ab49ccaa9325

Resolves: tdf#101699 get combobox junction right

gtk3-demo has examples of foreign drawing, follow
the patterns there to figure out what to do, add
stuff to gtk3-demo to demo what we need to do if
any particular case here is lacking

Change-Id: Ia1a22280161c97a3eab2d94fc4744fe971d31727
(cherry picked from commit e2af8f92a7308bc28c257b7905ec3a8a724554b1)

gtk3: rework theme code to separate old and new theming schemes

Change-Id: I7c1341a920c4607937ffab06c182a0ba0e0b26fd
(cherry picked from commit ac53789077eef17e2d895826abfe22888716600a)

older gtk3 versions still out there to build against

Change-Id: I64cb12185fc3943a211928e35e756b82942095b0
(cherry picked from commit a906f24a7830a12c4f1e2f8fa0c3df7961a64d6c)

GTK_STYLE_CLASS_POPUP not defined in older gtks

Change-Id: I6192d13419aab42993e4b6dc011db30a4c3c1787
(cherry picked from commit 7403c95540ba96a304eaebcb4845e910746133bb)

Resolves: tdf#92776 ensure correct notebook tab font color

despite various theme layout differences

Change-Id: I209258583571b57b2b7869937fa4821855125eac
(cherry picked from commit 69c9acd4b8dcd7ec8a5c3c380ad5cd8b797661ea)

gtk3: split out gtk->vcl font mapping code

(cherry picked from commit eb935ee8f511265038a949f74958ae716ac0e8ca)

Change-Id: Ic379307ba9e663e0ffc27c945852f6d68197f995

gtk3: use theme tab font

Change-Id: I3ea5a9e65e62133c910945e603bdc1155c9a07c3
(cherry picked from commit d786606b33cfc146a3a1f3adf814196993d3b310)

gtk3: split tabitem rendering to a standalone thing

Change-Id: I88cd8926b733717c9ea0ecf64a9882eaa777dcfe
(cherry picked from commit dcfddd3f079a45fc59fe50475020091c6c4694e2)

GTK_STYLE_CLASS_LABEL no defined in all versions

Change-Id: I648067e30d5a2e725111b2bc920367ac2d5e0f80
(cherry picked from commit 352ddafd05c5de4335746d52c79e8cf9689cba86)

Resolves: tdf#89760 get correct menubar text color for 'close preview'

Change-Id: Ife6f2665eabeefd6125a53318404dbd7b9af42ee
(cherry picked from commit b5f9fdff49e6955550cffa5318bee9d5c09f3479)

-Werror,-Wimplicit-fallthrough

Change-Id: I13a6a64f118bcfb99f47cd47a0dc638c5c9a5a14
(cherry picked from commit e64ea98801d20e5024da900a0ac8faaf565f4bf3)

Resolves: tdf#100251 gtk3 toolbar separators are white in Adwaita

Change-Id: Iceeba474535026cd13393432ef9a2e25121c134a
(cherry picked from commit 3498ed37527b7af795f00dc6a55c11e65a313186)

Resolves: tdf#103320 pressed buttons appear as hover buttons in toolbar

since...

commit 3498ed37527b7af795f00dc6a55c11e65a313186
Author: Caolán McNamara <caolanm@redhat.com>
Date: Tue Oct 18 13:08:47 2016 +0100

Resolves: tdf#100251 gtk3 toolbar separators are white in Adwaita

so remove setting the parent of the toolbar again, colors remain good
cause we ended up using gtk_render_background+gtk_render_frame for
the new-style code path anyway

Change-Id: Idd01537acbd92d6b41e0ff7fa2306b8c49f23ad3
(cherry picked from commit 7f6f5519079e3508ac1302aa5907cfc6098c525e)

Resolves: tdf#92776 tab names unreadable under Ambiance theme 3.20

thanks Benjamin

Reviewed-on: https://gerrit.libreoffice.org/30910
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 567580bddfa7b3d437b072698de77968c6513513)

Change-Id: I7ea0f6c8a8b8b35f864036844f1dc786e1f6bda8

gtk3: spinbuttons under Ambiance don't look beautiful enough

lets draw the frame after the sub-contents are done, and
use a dedicated entry child

Change-Id: I7db1ac56e5cfb1a46ddd2fb56c5e95deaa83a95d
(cherry picked from commit 4579c43861635dda15158478404aa90151228e91)

put the render frame at the end of these blocks too

Change-Id: I72270faa4138377ea04467ad0c6f01a3de0156b6
(cherry picked from commit 7f1af0a1c7401552704eaba2091b078890567cd8)
Reviewed-on: https://gerrit.libreoffice.org/30936
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Resolves: tdf#99508 ensure sufficient size for hidpi backing surface

and match virtual device scale with widget device scale

Change-Id: I1f35dcbaec94be12758ad6e4276bfd6bda4b1e88
Reviewed-on: https://gerrit.libreoffice.org/31080
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d9a6e0023c9a192850b9db00f8120fbcc4256ec9)
Reviewed-on: https://gerrit.libreoffice.org/31156

Related: lp#1580537 tdf#103915 don't set toolbars as primary

because under Ambiance there are dark primary toolbars and light panels and
currently we can only render the same icons in the same colors on each.

Breeze was explicitly selected as the default icon set to use under unity
in

commit c0da1080b61a1d51654fc34fdaeba373226065ff
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Sat Feb 27 14:30:01 2016 +0100

    lp#1506544 tdf#92458: default to breeze theme on unity desktops

    Change-Id: I1e0e10d1561e32c5904e0e7352e914bb62b85363

and the downstream workaround of lp#1580537 for this problem is to turn
libreoffice toolbars light.

glade has toolbar and a panel, both of them are light, so best solution
I can see is to remove the primary class from our toolbars.

Change-Id: I2f94ff52d56af1806e2b80b97e4ae2c4c82ae57e
(cherry picked from commit 739c9780f003bf2628713f04d6e0d20451f14dfb)
Reviewed-on: https://gerrit.libreoffice.org/30905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

tdf#103982 DOCX export: make sure SdrObject margin is non-negative

Regression from commit a5a836d8c43dc9cebbbf8af39bf0142de603a7c6 (DOCX
filter: effect extent should be part of the margin, 2014-12-04), the
effect extent is added to the nominal margin in DOCX, so we exclude that
from the margin in our document model. But it shouldn't be ever
negative, ST_WrapDistance is a restriction of the W3C XML Schema
unsignedInt datatype.

(cherry picked from commit f9f7a4ddaed85427522834597271967ee494b436)

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx

Change-Id: I82b3c1ba0e3a14f7c585b0d389264a2c12e454e7
Reviewed-on: https://gerrit.libreoffice.org/31115
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#84650 Fix X-coordinate of SmMatrixNode's elements

which are aligned to left or right against the column.

Change-Id: Ie2b6944bc0dddb0e1589842472298f787fabf596
Reviewed-on: https://gerrit.libreoffice.org/30929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
(cherry picked from commit 395295a40c24a49c12415ec803860a888d734515)
Reviewed-on: https://gerrit.libreoffice.org/30943
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#104096 reset also rRawRes if trailing characters are present

... in lcl_ScAddress_Parse_OOo() so that ScRange::Parse() doesn't receive a
"partially valid" result and does not attempt to follow the entire column/row
path.

Change-Id: Ie37c9d22280e30f770422fb621e3b9d972ec1546
(cherry picked from commit 8846cc2218091aa2af8ee3aadd81fd8a80e3b303)
Reviewed-on: https://gerrit.libreoffice.org/31058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Make sure there's a single global RTTI for SfxLinkItem

...as otherwise dynamic_cast<SfxLinkItem*>(...) could fail at least on macOS (as
observed with CppunitTest_sc_screenshots)

(cherry picked from commit c5940eab8ecfbd0d878f6fe714db32fd9d3e73c3)
Conflicts:
include/sfx2/app.hxx

Change-Id: I4a41a8b085b839598119791637f79cd467ad4130
Reviewed-on: https://gerrit.libreoffice.org/31066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

gtk3: problems with gdk_drag_status under wayland

under wayland, the value selected by gdk_drag_status is not immediately
available via gdk_drag_context_get_selected_action, so use the value
we set on it, not the value it claims to have

pull common code together as getPreferredDragAction

Change-Id: I4d95c4b8183505f2203ad1a8f6947df983ce8d21
(cherry picked from commit 09972f971e13ff967c9897d50ba5fbf0f862e8a4)
Reviewed-on: https://gerrit.libreoffice.org/30899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: tdf#102957 revert SetMinOutputSizePixel workaround

of

commit afeddaf7e0d11ad9b1df0c80bcc3f50caa87e21a
Author: Caolán McNamara <caolanm@redhat.com>
Date: Wed Dec 16 10:46:10 2015 +0000

Related: rhbz#1281906 set a min size on un-resizeable non-layout dialogs

and using a mixture of gtk_window_set_default_size before its visible, and
gtk_window_set_default_size + gtk_window_resize after its shown now works for
me under wayland so the original problem can be solved that way

Change-Id: Iaf8fd3019a7e902ad07b6825f919c6f25288e9b7
(cherry picked from commit 7e2ef433d29fca84ed27a9203b5761dc8dbd8bf8)
Reviewed-on: https://gerrit.libreoffice.org/30875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: tdf#103914 if menu no longer has focus, leave focus where it is

In the normal course of events, the menu, or its children, has focus when its
popped down, in this case continue to restored the focus to the previous focus
window which had it when the menu appeared.

If some other non-child window of the menu has focus as popdown time, leave
the focus where it is.

Change-Id: Ia860f90350653ad4d8056738dacbc434fb364989
(cherry picked from commit 616bc7b854e237aea1962a6750abd7f139e38ac2)
Reviewed-on: https://gerrit.libreoffice.org/30862
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

gtk3: scrollbar damage area one pixel too narrow/short

under default Ambience theme Ubuntu 16.04

tools rectangle strikes again, rejig to be left/top +
width/height rather than left/top + right/bottom

Change-Id: Id5274f068863cd5219a89142b392c9ca53a1694d
Reviewed-on: https://gerrit.libreoffice.org/30851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

tdf#82824 DOCX import: fix at-char embedded object handling

The anchor type of embedded object was simply not handled, we always
assumed that it's as-char.

When it's at-char set the anchor type accordingly, and also set the
usual 6 properties determining the position of the anchored object.

(cherry picked from commit 10efab2b9a3cf7fc49655c90ba29db4512680c38)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: I3f8bede33c6f1a0bdc4f4d4ea59c4fc805802291
Reviewed-on: https://gerrit.libreoffice.org/30965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Update the reference rdbs to libreoffice-5-2

(This deliberately leaves out the published
css.mozilla.XRemoteServiceManagerProvider originally manually removed from
offapi/type_reference/offapi.idl with 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4
"tdf#96398 kill remaining NPAPI support for plugins _inside_ LO" and now fully
removed with b5589970125ae4b8c0a091cfc12d058ca42ce2ab "[API CHANGE] Remove
tdf#96398 leftover XRemoteServiceManagerProvider".)

Change-Id: I75d4cd82ba306099e2563a44739bfb3867a265e9
(cherry picked from commit 76683829204103446476443b099492c402929004)
Reviewed-on: https://gerrit.libreoffice.org/31045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Updated core
Project: translations 02803ddf83a003b347bdbda458c7dca2bdc28de2

Updated Slovenian translation

Change-Id: I0c76b852a5ac8feb3dcef52ff223efccb12c2a5a

tdf#92160 - sc: limit search results to 1000 entries.

Very large replace results give huge space consumption in the
display widget, and are of dubious usefulness.

Change-Id: Ib8ad01a673ea52976befaf958f8f695aca2190ae
Reviewed-on: https://gerrit.libreoffice.org/30574
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit ba68e6dd7ad99ef2a2720f327813d13550b98966)
Reviewed-on: https://gerrit.libreoffice.org/30665
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>

cppcanvas, oox: add missing #include <osl/endian.h>

These files use the macro OSL_BIGENDIAN but did not include the header
that defines it.

Found via:

git grep -l OSL_.*ENDIAN | grep -E '\.h(xx)?$' | while read f; do grep -L endian\\.h $f ; done

Change-Id: Iffb36336026e49a9c3d8fcf125a54ec857c7552e
(cherry picked from commit 2b14fb3a4f92b928f0a5fc536c6a5f4a6e51a9b8)
Reviewed-on: https://gerrit.libreoffice.org/31040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

connectivity, sc: add missing #include <osl/endian.h>

These files use the macro OSL_BIGENDIAN but did not include the header
that defines it.

Found via:

git grep -l OSL_.*ENDIAN | grep -v -E '\.h(xx)?$' | while read f; do case $f in *cxx) grep -L endian\\.h workdir/Dep/CxxObject/${f%.cxx}.d ;; *) grep -L endian\\.h workdir/Dep/CObject/${f%.c}.d ;; esac ; done

(cherry picked from commit e2f08f9def0869460ad38a1c2adb450778290f6e)

Change-Id: Iaf589a8235dbc8062840d2716ab843e64b5cb7a2
Reviewed-on: https://gerrit.libreoffice.org/31039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Resolves: tdf#103994 AdjustReferenceOnMove: handle external references

Change-Id: I8b104b0c843dd268d8760a2a73cdd3e672e6efd6
(cherry picked from commit 4665be3af48587505bb7f49a53e8422945ec49eb)
Reviewed-on: https://gerrit.libreoffice.org/30941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

ODF: do not write an empty style:text-position="" attribute for CharEscapement

... and CharEscapementHeight if the Any is void.
This was a real error complained about in the officeotron validation
https://bugs.documentfoundation.org/attachment.cgi?id=128411
https://bugs.documentfoundation.org/show_bug.cgi?id=103493

Also showed up as console warning

warn:legacy.osl:3269:1:xmloff/source/core/xmlerror.cxx:178: An error or a warning has occurred during XML import/export!
Error-Id: 0x20040003
Flags: 2 ERROR
Class: 4 API
Number: 3
Parameters:
0: CharEscapement
Exception-Message: UNKNOWN_PROPERTY
Position:
Public Identifier:
System Identifier: file:///.../103493-LotroPlan%203.8.ods
Row, Column: 2,1850164

Change-Id: Ifc634cc6b3d5d6dfa43741005ef0c9a1f7ff71fe
(cherry picked from commit 8aec9057a169acfda6f2d986af93edca54677fd2)
Reviewed-on: https://gerrit.libreoffice.org/30939
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#103334 - EDITING: Undo on bullet point style

I have checked the normal model and the editing model after UNDO, and
all seems to be well, this is purely a rendering/lack-of-invalidation
issue.

The extra invalidation I add here is restricted to the UNDO case to
prevent tripping up a LOK unit test
(SdTiledRenderingTest::testCursorViews).

I confess to not having followed the invalidation logic all the way to
see why exactly it makes the bug go away.

Reviewed-on: https://gerrit.libreoffice.org/30225
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit ee33745ced5ae12f9ae7735fac16a7298ccae474)

Change-Id: I34f7d84526462665b1ec09aba966c98cd4e8795f
Reviewed-on: https://gerrit.libreoffice.org/30425
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

tdf#103950 Undo does not revert bundled font size changes for table cells

Change-Id: Id41b7777739bfa93610f955e6c31f8bb979b8e2c
Reviewed-on: https://gerrit.libreoffice.org/30902
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 90646b4966c73637ddf592acd05b3091fb3fa41f)
Reviewed-on: https://gerrit.libreoffice.org/30956

-Werror,-Wswitch

Change-Id: I319f932f24a5b4c2eb331eac6795731a1bc483ca
(cherry picked from commit 149edab4435256b13a8681ac69bd4c35f6da8bb7)
Reviewed-on: https://gerrit.libreoffice.org/30957
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

backport various scoped enum conversion to make other backporting safer

Convert ControlType to scoped enum

Reviewed-on: https://gerrit.libreoffice.org/25554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 5c977a9ddff3c221c098a57855ede7c0ef4fe31f)

Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19

Convert ButtonValue to scoped enum

Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22
Reviewed-on: https://gerrit.libreoffice.org/26036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 7fb70ff650ce3a1e4a39bd1b936f511d6be8986c)

Convert RenderType to scoped enum

Change-Id: I2f4bb201babc9050b19de2dacc0dea462255dfa2
(cherry picked from commit 8a70742bf395fc2aab6197f04ddbfbd8ee16f263)

remove some unnecessary casting

Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942
Reviewed-on: https://gerrit.libreoffice.org/26184
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 2ed5fa14f0e7624db241fde26e10fdd1009adfc7)

Convert PART to scoped enum

Reviewed-on: https://gerrit.libreoffice.org/26173
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit cf5208b67180dc1deaeca611706087b1e2acc1ae)

Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4
Reviewed-on: https://gerrit.libreoffice.org/30911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fix tdf#101832 and tdf#100617

OutDev mapmode takes shortcuts for 'simple' mappings, so clear that flag
once we set scale/origin away from defaults.

Change-Id: I00321e27322d9cb8b86e6cc8400f6396d03328cc
Reviewed-on: https://gerrit.libreoffice.org/30855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 5d1a788468ef94cd1de4400d3c1e38d768f7bf8d)
Reviewed-on: https://gerrit.libreoffice.org/30876
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix regression in bubbleSortVersion

...introduced with 789055bc2acb4c71483fd60ea258d158bd5aec10 "clang-tidy
performance-unnecessary-copy-initialization" (so partially revert it). Whatever
clang-tidy erroneously reported there, cur and next are lvalue references into
vec, so this attempted copy now actually overwrote one with the other. The
result was that if multiple JREs are detected on the system, "Options -
LibreOffice - Advanced" would list a single one multiple times.

Change-Id: I7ef454c0f37669722812383848602dc2bacf7cd1
(cherry picked from commit 36a329b6395257d7df2013d23ba4205a5ef72f4d)
Reviewed-on: https://gerrit.libreoffice.org/30923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103756 - CTRL+Z not working to undo changes performed through Navigator

Hooked up the tree control to do explicit handling of accelerator key
input.

Note that there is an extra check for null in SdPageObjsTLB::SetViewFrame
to prevent various 'make check' failures. No idea why this did
not trigger on trunk.

Reviewed-on: https://gerrit.libreoffice.org/30694
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e9da91fd028e73846b1bed2618357d0abfbdcc57)

Change-Id: I8b47fc2d651f7db2549c73c5314fbc4a7f4efecc
Reviewed-on: https://gerrit.libreoffice.org/30769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

tdf#88827 - double-thin border: MINGAPWIDTH is a valid width

double-thin borders are available in the UI starting from 0.5pt.
The actual minumum (as seen in a round-trip), is 1.10pt.
(Each thin line is ~ .50pt, the gap is ~ .05pt, and then some
approximations and rounding show it as 1.10 - at least that is how I
understood it). 1.15pt is the first point at which the gap is larger
than the minimum - and double_thins with a minimum gap were considered
invalid, and thus were not imported.

With this fix, double-thin borders created with a size less than 1.15pt
are valid and visible on import.

cherry-picked from master, commit 9259fcd40b1749cd421c433bcc436cb335cbbe43

Conflicts:

sc/qa/unit/subsequent_export-test.cxx

Change-Id: Ia8cff677516eca371b7e8a9ef7ba33a1b8f176bf
Reviewed-on: https://gerrit.libreoffice.org/30856
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Resolves: tdf#103472 gtk3 dnd must clear listener after dragDropEnd dispatch

like the generic dnd impl does

Change-Id: Ie860c43329ee2f9332d12a53cd691ac7fcbb5eac
(cherry picked from commit 461e9cc64b5a6e9943db397d27c6415327386494)
Reviewed-on: https://gerrit.libreoffice.org/30260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

tdf#71251: VARCHAR max length is 32765 for Firebird

At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/)
Let's put the same for CHAR

Cherry-picked from ba8a41bac3765f7b3562d357aeb13f752ea14ba4
Reviewed-on: https://gerrit.libreoffice.org/30783
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7
Reviewed-on: https://gerrit.libreoffice.org/30786
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

tdf#103792: No placeholder text imported for empty title shape

Change-Id: I95b4358f0d4311e8f427c8de18863049fb718d9b
Reviewed-on: https://gerrit.libreoffice.org/30731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit dc024cdd91e3c33eeff8eea22fdef0d90d4dd2c0)
Reviewed-on: https://gerrit.libreoffice.org/30762
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#101042 Fix for frozen windows in Excel

Window protection is "not allowed to move and resize windows" in MS Excel,
it is definitely not Frozen Panes ( maData.mbFrozenPanes )

Change-Id: I04f0429738a6daecb26274f169c5118dba73e895
Reviewed-on: https://gerrit.libreoffice.org/30076
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 0637d0f43d3dc5b41a1bbc5726d6a68b7c36a519)
Reviewed-on: https://gerrit.libreoffice.org/30777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103544: DOCX exp.: Image loss when have a frame anchored to the same para.

Regression from:
83d51e5e52688c4c9bc0ad70a511458bb06a242d

Partly revert the commit causes this regression.
I checked the related bugs (tdf#78590,tdf#80748)
intended to be fixed by this commit and reverting
this part does not bring back the corruption.
I guess something changed in frames' and text boxes'
import in the meantime, because this MergeMarks::IGNORE
is useless now.

Reviewed-on: https://gerrit.libreoffice.org/30351
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx

Change-Id: If17776e8628561961c7ce2a2994e3fc609f75639
Reviewed-on: https://gerrit.libreoffice.org/30358
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#100352 Backport ca-ES, fr-FR and nl-NL classification files

Change-Id: I561ff1906c1ddfde5d66d31270633fc4de94589b
Reviewed-on: https://gerrit.libreoffice.org/30775
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#103689 do not slice 3D area broadcasters into separate sheets

Change-Id: Ie167e5e5e953c3e8064b8e128d52f6aa6740575b
(cherry picked from commit 129eddc18b4f2cb1320b60bf68de537cf86b60f2)
Reviewed-on: https://gerrit.libreoffice.org/30720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#103701 bulk-broadcast the correct hint ID for formula groups

BulkBroadcastGroupAreas() and BulkDataHint and thus
FormulaGroupAreaListener::Notify() omitted to transport the actual hint
and assumed SC_HINT_DATACHANGED, but SC_HINT_TABLEOPDIRTY needs to be
handled as well.

(cherry picked from commit 05d2a66955f8a6552a79696474386ca9f45f9ef2)

Backported.

Conflicts:
sc/inc/bulkdatahint.hxx
sc/inc/document.hxx
sc/source/core/data/bcaslot.cxx
sc/source/core/data/documen7.cxx
sc/source/core/data/document.cxx
sc/source/core/inc/bcaslot.hxx
sc/source/core/tool/bulkdatahint.cxx
sc/source/core/tool/grouparealistener.cxx

Change-Id: I765f7c95f7aeab295f35dcf6949a3b1926cbe248
Reviewed-on: https://gerrit.libreoffice.org/30701
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103826 Missing master page pane context menus in Draw

(cherry picked from commit 749fe62b32acc3159cf2756aae16df36f091a862)

changes from master: Removed officecfg part to avoid breaking
string freeze, added nullptr check to be on the safe side.

Change-Id: I355e9507692e770063a91d05efd3ebc3e2671d57
Reviewed-on: https://gerrit.libreoffice.org/30766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103087 Border widget must not have focus initially

... unless it was opened using the keyboard.

(based on 66b75b4ba9f0a1c8003fa52c7a29575e374644a2)

Change-Id: I95753d1c3086177764a08e654a3ff925243743e1
Reviewed-on: https://gerrit.libreoffice.org/30687
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#79329 DOCX import: fix missing outer table with floattable at cell start

The bug document has a normal table, then its C1 cell starts with a
nested table, which is floating. The problem is that converting the
nested table to a textframe invalidates the start text range of the C1
cell in the outer table we store, so the conversion of the outer table
from text to table fails.

This never worked, so to avoid the regression just don't convert inner
floating tables to textframes when they're anchored at the cell start.
A more general fix in the future can be addressing the actual
invalidation of the cell start/end text ranges, and then this specific
fix will not be necessary anymore.

(cherry picked from commit c1eebcdac9f2b289fd363399130c485ca5ff444c)

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
writerfilter/source/dmapper/DomainMapper.cxx

Change-Id: I12cefa41977cf719b07b0fb3ef9ec423c17ef3b1
Reviewed-on: https://gerrit.libreoffice.org/30770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103803 change from BGRA to RGBA color arrangement on Windows

BGRA is native color arrangement on Windows however some intel
drivers have problems with large textures if they read from a
BGRA buffer. So with this commit we switch to RGBA color
arrangement. This shouldn't cause much performance differences,
but we need to convert from RGBA to BGRA when printing.

+ fix: wrong GL format for RGBA image buffers
commit: ed42212f53b2e52238346e64dae31a931d6c90a1

Reviewed-on: https://gerrit.libreoffice.org/30544
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 6b571ae4608ac15256eb7582f442ce69975370f3)

Change-Id: Ic112dc6a6c5d8b70e96041d0de15a03bbbdc406f
Reviewed-on: https://gerrit.libreoffice.org/30763
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

tdf#103804 reduced register areaScale shader and detection for intel

Some intel drivers crash when areaScale shader with "large" array
is used. This adds a "reduced register" version of the areaScale
shader. We still use the first version of the shader for other
drivers and switch between the 2 implementations with a runtime
detection.

Change-Id: I1860f898c03b40a600eb1b41f7262719382a7171
Reviewed-on: https://gerrit.libreoffice.org/30571
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d115a235bf3ff5366d992d01fb418a3eacb9d125)
Reviewed-on: https://gerrit.libreoffice.org/30764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Resolves: tdf#97968 adjust references during Cut&Paste of formula groups

... and split groups for cases where references point outside or into the moved
range.

Change-Id: Iab799e94eed1677f266413b6304651ac4d330e95
(cherry picked from commit dfa92e106f7eaa8c3fc6cda034001197ecc53a8f)
Reviewed-on: https://gerrit.libreoffice.org/30067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#103809 the argument is a bool* not a VclPtr

(cherry picked from commit 8445764681bfe7bd6cd31194878e1314a8fafa3b)

Change-Id: Ia07f4ff7b243708304186c840135ec1180621fa5
Reviewed-on: https://gerrit.libreoffice.org/30760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

google docs can generate a pptx with an empty cmLst

Change-Id: I2a3dcae5361929c6880b2da1b3107cb2c8141f32
(cherry picked from commit e6157763e9fff300b86f3c17398216f306ba3f32)
Reviewed-on: https://gerrit.libreoffice.org/30672
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

remove OpenGL transitions config. file from scheme

The OpenGL transitions are optional, so the respective config. file
should only be listed in the ogltrans module.

This reverts commit dafcb2844bda4af2bc290548548392bda3262307.

Change-Id: Ie785db07d04a0baf3dc9fd385f1d8a34837dc38b
(cherry picked from commit f316f413f589989013bf161170087e77a82db2d3)
Reviewed-on: https://gerrit.libreoffice.org/30611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#90070 don't clip flys with borders

regression from commit e598ab04476a32a08f18e8f0662fafa5f78f1a4a
very aggressively forced a new frame size via compat setting
CLIPPED_PICTURES on any fly - not just images.

This only affects MS-format documents, EXCEPT that it is a document
property, so if the file every spent any part of it's life in MS-format,
it will always retain that compatibility setting. That explains
why the problem was intermittent for me - and was hard to reproduce
in a clean document, even though I'd seen it in .ODTs.

bIgnoreLine (ignore the fact that there is no visible line)
was a confusing word choice for "if there is no line,
then return a spacing size of zero". bEvenIfNoLine=false is better.

Change-Id: I50a3bdef3a67339ae517ee6319920651bc56f9be
Reviewed-on: https://gerrit.libreoffice.org/30585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit d034f273cb24ebe4fde20ad9089ac11cccf316d0)
Reviewed-on: https://gerrit.libreoffice.org/30595

tdf#62625 - reopen temp stream to readBasic .xls VBA

InputStream was closed, but an InStream was still open,
so InputStream was not being re-created.
Apparently either most web protocols aren't properly closed,
or else a second stream is needed for these kinds of protocols.

Required on Linux for INetProtocol::Http, Generic, Smb, Sftp
and perhaps more. Required on Windows/Mac for Remote WebDAV
(although http://xx/xx.xls worked)

Change-Id: Icb732518fb8185168c5ed1cb9e32c84c9d8d71bb
Reviewed-on: https://gerrit.libreoffice.org/30303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit d9c7b0a01162254240a1328fa594991eccf6bc65)
Reviewed-on: https://gerrit.libreoffice.org/30662
Reviewed-by: Justin Luth <justin_luth@sil.org>

tdf#103696 ensure glm always uses radians

This is set just locally for OGLTrans, because I have no idea what the
other places that use glm expect...

Change-Id: I83675ef2463ab945cb3d6885f803dcbae60a5558
(cherry picked from commit afe235a0abf9ef91a353a4d0dccf56961abd2fbf)
Reviewed-on: https://gerrit.libreoffice.org/30610
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Resolves: tdf#101583 references to be expanded must be at least 2 cols/rows

... wide/tall also in named expressions.

Change-Id: If0c192def74812cc9405ae633b6f83f7021344d0
(cherry picked from commit 6b9804b8f2ca85e9eb42d344d17cfee7a7a9414c)
Reviewed-on: https://gerrit.libreoffice.org/30023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103753: DOCX: Handle relative positions to left or right margin

Positioning relative to left or right margin in MS Word
works the same as the positioning relative to left or right
page border in LO Writer.

Reviewed-on: https://gerrit.libreoffice.org/30376
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx

Change-Id: I476a5e9e76f766b7fb7f1c7f4a068af8bb3c8813
Reviewed-on: https://gerrit.libreoffice.org/30377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103664: FILEOPEN: DOCX: Wingdings symbols are imported as rectangles

Reviewed-on: https://gerrit.libreoffice.org/30575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 5ef66db91e87ef84724be22977acf4c9c472ad6b)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx

Change-Id: Ifd9ff26f2460e5570ec1b736308d48acdb3e56a8
Reviewed-on: https://gerrit.libreoffice.org/30587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#103684 calculate status bar functions across sheets

Also trigger recalculation when additional sheets are selected or deselected.

Change-Id: I259396a3e30c5653ac252b7bb2eb6a0a9405d6cc
(cherry picked from commit 8d777f85eaff6af8896942590316b7cd9f2c3e75)
Reviewed-on: https://gerrit.libreoffice.org/30546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#103473: Ensure positive rectangle size

Also remove conversion of both negative scales into rotation,
because it is handled by flip; use strict comparison instead of
approximate float less because it's correct here, and also because
basegfx::fTools::less ultimately uses rtl_math_approxEqual, which
description states: attention
approxEqual( value!=0.0, 0.0 ) _never_ yields true.

Unit test included.

Change-Id: Ia878fce360cf8aed539d95f2d4a1a3ad94379978
Reviewed-on: https://gerrit.libreoffice.org/30373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 1c708eee636c0cdf3da2ec62849618f3262044bc)
Reviewed-on: https://gerrit.libreoffice.org/30378

tdf#79892: Improve performance of transliteration

Pass resolved language to transliterate call, so it doesn't
have to be resolved each time inside.

Change-Id: Ibcad3b8517cb92c3462e14207c0a79ca2c76d73b
Reviewed-on: https://gerrit.libreoffice.org/29829
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 2ed5057993fa8d0f57531303e6c9fafc37138737)
Reviewed-on: https://gerrit.libreoffice.org/30558
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

tdf#79892: Pass resolved locale to transliterate calls in Calc

Instead of ScGlobal::eLnge, use
ScGlobal::pSysLocale->GetLanguageTag().getLanguageType().

Change-Id: Ie0aa90098860ac2b6cee195180dbc213eaf3b5f8
Reviewed-on: https://gerrit.libreoffice.org/30240
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 8175e30b732e3f6f4f1058934e7fe8a1189f40cf)
Reviewed-on: https://gerrit.libreoffice.org/30559
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Resolves: tdf#99291 empty array element should not match empty cell

As weird as it is, but an empty cell is only to be matched by an empty string,
not another empty cell.

Affects spreadsheet functions SUMIF, AVERAGEIF, COUNTIF, SUMIFS, AVERAGEIFS and
COUNTIFS.

(cherry picked from commit 33090865c494618f4e528bf5a10aae8c4fc443d1)

Conflicts:
sc/source/core/tool/interpr1.cxx

Change-Id: Ib33402e8c93f26cd8e2648426a5bde6b267c55ab
Reviewed-on: https://gerrit.libreoffice.org/30451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#95031 DOCX import: auto spacing inside numbering means no spacing

The WW8 import has code for this in SwWW8ImplReader::AppendTextNode(),
with lots of corner-cases. Not all of that is implemented here yet, but
the bullet list in the bugdoc already looks correct now.

(cherry picked from commit c486e875de7c8e845594f5043a37ee8800865782)

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx

Change-Id: I9499bfa4d8d7fcc425d7b95e64987258c099f7f2
Reviewed-on: https://gerrit.libreoffice.org/30291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: tdf#92117 create only one Undo for all UnmergeCells() calls

... during DeleteCells() and InsertCells(), instead of one Undo per
UnmergeCells() call. And actually create Undo only if bRecord requested.

(cherry picked from commit 647e860435c781fbb111ae59bc70dc8e6776fed5)

Conflicts:
sc/source/ui/docshell/docfunc.cxx
sc/source/ui/inc/docfunc.hxx
sc/source/ui/inc/undoblk.hxx
sc/source/ui/undo/undoblk.cxx

init ScUndoRemoveMerge with range, tdf#92117 follow-up

So the original selection is restored after Undo.

(cherry picked from commit 0ebe9fab18e732468d2b9d53dddf9f266411a0e5)

e549a0b62da469ee38270ae089ea5abf9a6868e3

Change-Id: I4f1747c3f42f36e16be81f989f0af5d048ba9d9f
Reviewed-on: https://gerrit.libreoffice.org/30297
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#103178 Final SID can differ from the original one

e.g. if the same one is passed twice to deactivate the
current function. So the assumption of commit
11d605cc5a0c221d2423b6e63f502db660d085d2 that if
we don't use enum slots then we always use the original
one is wrong.

(cherry picked from commit d5eabed46ef3bc6754d381a0551ce070df933894)

Conflicts:
sc/source/ui/view/tabvwsh2.cxx

Change-Id: Ib22fa88c958e5af85333cb8fa287f65f92b30e08
Reviewed-on: https://gerrit.libreoffice.org/30171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#76002 Grab focus to sidebar dropdowns

Change-Id: I640cbcdcf08c34c06f0c787594e29f8e38407ece
Reviewed-on: https://gerrit.libreoffice.org/30059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix external libjpeg build

(cherry picked from commit f144d319d58cbb0d358250540cd666d9644f5fa5)

RepositoryExternal.mk: really fix jpeg build
(cherry picked from commit 8d1c80e2633b8a63050cdd81b7e089f27b996c0f)
Change-Id: I1969db554d156e6af0975d03013ea4f7c10d839f
Reviewed-on: https://gerrit.libreoffice.org/30527
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

configure: fix LIBJPEG_LIBS, jpeg-turbo can also be used on Linux

Change-Id: I710f8ba31b6f780e3fb1d174d9ea21f270f55264
(cherry picked from commit 6a866f99ecf21f6ebdbb7f00d3c72677a1361e74)
Reviewed-on: https://gerrit.libreoffice.org/30526
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

RepositoryExternal.mk: fix poppler linking on Ubuntu

need to link poppler static library *before* jpeg

Change-Id: I0fd2abc12c93432715a02a3a567349abda4f990b
(cherry picked from commit 43532a0944b0ee4727ea2ae480e54687e41d9201)
Reviewed-on: https://gerrit.libreoffice.org/30533
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#93825: Missing accessibility events when selecting/deselecting cells

Change-Id: I407f585354e78fb47a76561455ac67bb567c2771
(cherry picked from commit 2a818a0aafac218ca09bb079d7f2cf0879385e4a)
Reviewed-on: https://gerrit.libreoffice.org/30541
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

curl: upgrade to version 7.51.0

bump curl to 7.50.0
Reviewed-on: https://gerrit.libreoffice.org/27671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c772c8fd273d73af4734ce0ed1b4bb082dc1886c)

bump curl to 7.50.1
Reviewed-on: https://gerrit.libreoffice.org/28157
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 102815fe38dfdc2786bd5cf7a5acee564c912775)

curl: upgrade to version 7.51.0
- fixes about a dozen CVEs
- tweak curl-7.26.0_win-proxy.patch:
  there is a "checksrc" thing now in curl that fails the build with:
    warning: use of strtok is banned (BANNEDFUNC)
  so use strtok_s instead (which is MSVC's name for standard strtok_r)
- use Makefile.vc12 instead of Makefile.vc10
- remove strequal.obj from Makefile.vc12, it does not actually exist

Reviewed-on: https://gerrit.libreoffice.org/30484
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 3edb365f2651848ae8bc3b85bf0b56bd00d93270)

Change-Id: Ie2da64980d88c72b0c902376ffc01abf97a7bc91
Reviewed-on: https://gerrit.libreoffice.org/30503
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>