scenegraph: shared_ptr, findByName, SceneGraphFactory

The change includes:
* Use shared_ptr for the child nodes.
* Every node can have a name and we can search for the node with
  findByName.
* SceneGraphFactory class for easier initial construction of the
  scene graph.
* RootNode has been removed as we can just use a simple empty Node
  with type ROOT.

Change-Id: I7bee98cff6b46abb5c6baef25fc6f9bc084d4073

SceneGraph experiment

Change-Id: I1e88559034a2a2787c70bdb4bcf4f7c61fc328e1

Valgrind reports read of uninitialized bCLBool

...during e.g. CppunitTest_sc_subsequent_filters_test, where
CL_DEVICE_LINKER_AVAILABLE is apparently a later addition (<https://
www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clGetDeviceInfo.html>
mentions it while <https://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/
clGetDeviceInfo.html> doesn't).

Change-Id: Icdaeffa4adb0765a6317f443130fa295761eb93f

Fix typo

Change-Id: I3055f06c2b72d651ebf633bc46aaf682716a8fc2
Reviewed-on: https://gerrit.libreoffice.org/29139
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

ASan/UBSan reports read of uninitialized bHasStandardStyles

...during CppunitTest_sc_subsequent_filters_test, where
7911f21cd3e0deb6c1966dc97b8a5e5cf994d3af "Add to a method to check if stlpool
already has standard styles" apparently forgot to initialize it

Change-Id: I66c6ccb8f3a3ec38ed326ccf35f3a82711c4ef6f

unused header

Change-Id: I9339f192ae84d46a496ab76cb6430d32a28c7787
Reviewed-on: https://gerrit.libreoffice.org/29108
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

64-bit Windows build is not experimental for a while

Change-Id: I1b973c60a19e59c98c669d08e8472c18c2fc0c58
Reviewed-on: https://gerrit.libreoffice.org/29104
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

add SHEET test case

Change-Id: I0b968bef2e9dba00879868e7b63865ac5531ba7c
Reviewed-on: https://gerrit.libreoffice.org/29103
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

convert SfxItemPresentation to scoped enum

Change-Id: Ibf605706a9f804ab509ac4f92f5f88fcf3daebc1
Reviewed-on: https://gerrit.libreoffice.org/29131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Resolves: tdf#100795 SAL_MIN_INT32 32bit overflows on finding min limit

for control points, so halve it to the practical limit

Change-Id: I1285631bebebf86e257a2fdd804c0c81dcefac96

sw: use range-based for loop in textboxhelper

Change-Id: I5275e4bd9e812a1b1229ad67fba671fdb23d2b37

#i114963# Enable IPC before OpenClients to allow client connections when printing.

Patch By: aptitude@btconnect.com

(cherry picked from commit 602bd18953b23b7aa939cc118d2aa7cb24b172be)
Conflicts:
desktop/source/app/app.cxx

loplugin:implicitboolconversion

Change-Id: Id7dafb926a0eb7fae5e481555eae3d35fe795900

spelling Surregate->Surrogate

Change-Id: Ic7d79036f4e94a487c9b12edb18d6e4098938585

add dumpAsXml() to more pool items

Change-Id: I276109148bab8180ce2442f5ee69722357362453

cid#1371252: Add move semantics

Change-Id: I7cf1b4c92fdddbef681654c780a9ee466c33ce0b

Ignore temporary editor/tool files

Change-Id: Ibe47493edad6a6b016810ea777907d84d0f618f9
Reviewed-on: https://gerrit.libreoffice.org/28651
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

sc-perf: tdf#79023 do not call SvNumberFormatter also for numbers in OOXML

Change-Id: Ib565687bff2205da0213f6d523dd2bc42c96ad47

sc-perf: tdf#79023 for ODFF do not call SvNumberFormatter to determine numeric

Speedup of this particular function and callees by factor 33 ...

1000 calls for =12345.6789 and =123.456 alternating:

Before:
Ir       Irpc  Callee
9859177  9859  ScCompiler::IsValue
6246858  6246  SvNumberFormatter::IsNumberFormat
3496261  3496  SvNumberFormatter::GetStandardIndex

After:
 298000   298  ScCompiler::IsValue
 248000   248  rtl_math_uStringToDouble

Change-Id: I36eac8c5fe1b1cbf34dfb480c9e7ca6607769364

loplugin:defaultparams

Change-Id: Ic314f620e711f8e16980c568c28b7cc361c5c1a8

Improve warnings in pivot table code

Change-Id: I5230bcb4abbc720cc2177e26f8fa5b8969039624

sc draw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION when view is created

In multiple view environment, when a new view is created ensure to
notify other views graphic view selections.

Change-Id: If75f9525af6e851e096b6d273957b94882c441cf
Reviewed-on: https://gerrit.libreoffice.org/29094
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

lokdocview: guard against int overflow

If a too large rectangle is parsed, the width or the height may be
larger than std::numeric_limits<int>::max(), in that case just set
width/height to that max value, instead of allowing an overflow.

Change-Id: Ic01319b01a3f9286501c346ea765868be57466a1

cid#1371314: Add move semantics

Change-Id: I995cbdb2b6adc707abe5f1a179e94251641120bc

tdf#101536 sw: do load Insert Index dialog's document ReadOnly

Turns out SwOneExampleFrame is used for different things, so load doc
read-only only if it's an existing document.

(regression from 6a8407d82d71083c8bdec6a106ba9092a5196cbe)

Change-Id: I0a1ab0725ed9dccca23742c9d83cd9635a188edf

tdf#101359 Really walk the document mark list

In both functions we want to walk the current mark list and
act on the MarkType::BOOKMARK, so mimic the behaviour of
PopulateTable in HaveBookmarksChanged.

My previous commit 96454829f7dc6480f9ddd4262bc03d5ccabadea4
is broken and just works out of luck...

Change-Id: I2f53b775208cad7e83992d1ae4fb67a41588cb92

Fix "ubsan: 9 is not a valid value for type ´SvxNumType´" once again

...after 1658bd231bc662504a072097dc614c29fe2e116d "loplugin:unusedenumvalues"
broke it again after 992fba98f4d0b6ff0d20c15b0ddff09edd37847c "ubsan: 9 is not a
valid value for type ´SvxNumType´" had fixed it the last time.

This time, acknowledge that SvxNumType can apparently take on rather arbitrary
sal_Int16 values from the css::style::NumberingTypes constants, and make it an
alias for sal_Int16 (whether or not keeping such a trivial alias is good or bad
overall).

Or is the bug elsewhere, and values of type SvxNumType should really only take
on the restricted set of values originally encoded by the enum?  At least the
below UBSan backtrace (from CppunitTest_sw_rtfexport) suggests otherwise, but
then again there's also an SvxExtNumType enum (include/editeng/svxenum.hxx),
encompassing more parts of css::style::NumberingTypes.  Oh, my.

> svx/source/items/pageitem.cxx:49:25: runtime error: load of value 9, which is not a valid value for type 'SvxNumType'
>  #0 0x2aafdaebe669 in SvxPageItem::SvxPageItem(SvxPageItem const&) svx/source/items/pageitem.cxx:49:25
>  #1 0x2aafdaebf194 in SvxPageItem::Clone(SfxItemPool*) const svx/source/items/pageitem.cxx:59:16
>  #2 0x2aaf7fab9b7c in SfxItemPool::Put(SfxPoolItem const&, unsigned short) svl/source/items/itempool.cxx:632:40
>  #3 0x2aaf7fc4794a in SfxItemSet::Put(SfxPoolItem const&, unsigned short) svl/source/items/itemset.cxx:467:56
>  #4 0x2aaf7fb96635 in SfxItemSet::Put(SfxPoolItem const&) include/svl/itemset.hxx:131:42
>  #5 0x2aaf7fb89539 in SfxItemPropertySet::setPropertyValue(SfxItemPropertySimpleEntry const&, com::sun::star::uno::Any const&, SfxItemSet&) const svl/source/items/itemprop.cxx:256:14
>  #6 0x2aaf9ef1a5d4 in void SwXStyle::SetPropertyValue<(unsigned short)1>(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:1596:14
>  #7 0x2aaf9ef3c72f in SwXStyle::SetStyleProperty(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:2013:9
>  #8 0x2aaf9ef8103d in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3025:17
>  #9 0x2aaf9ef821ee in SwXPageStyle::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3053:9
>  #10 0x2ab00730d08b in writerfilter::dmapper::SectionPropertyMap::ApplyProperties_(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) writerfilter/source/dmapper/PropertyMap.cxx:1489:24
>  #11 0x2ab00731cede in writerfilter::dmapper::SectionPropertyMap::CloseSectionGroup(writerfilter::dmapper::DomainMapper_Impl&) writerfilter/source/dmapper/PropertyMap.cxx:1331:13
>  #12 0x2ab006b9ede2 in writerfilter::dmapper::DomainMapper::lcl_endSectionGroup() writerfilter/source/dmapper/DomainMapper.cxx:2823:30
>  #13 0x2ab0071db9f9 in writerfilter::LoggedStream::endSectionGroup() writerfilter/source/dmapper/LoggedResources.cxx:101:5
>  #14 0x2ab006712a3b in writerfilter::rtftok::RTFDocumentImpl::sectBreak(bool) writerfilter/source/rtftok/rtfdocumentimpl.cxx:633:18
>  #15 0x2ab0067a8c13 in writerfilter::rtftok::RTFDocumentImpl::popState() writerfilter/source/rtftok/rtfdocumentimpl.cxx:2789:13
>  #16 0x2ab006a26134 in writerfilter::rtftok::RTFTokenizer::resolveParse() writerfilter/source/rtftok/rtftokenizer.cxx:105:33
>  #17 0x2ab0067194f9 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/rtftok/rtfdocumentimpl.cxx:740:27
>  #18 0x2ab0075ebae7 in RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/RtfFilter.cxx:147:20
>  #19 0x2aafcf2873a5 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2261:30
>  #20 0x2aafcf22d4d2 in SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:764:23
>  #21 0x2aafcf4a4d09 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/doc/sfxbasemodel.cxx:1841:36
>  #22 0x2aafcfde31b3 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:698:28
>  #23 0x2aaffef07028 in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1110:37
>  #24 0x2aaffeeead5a in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20
>  #25 0x2aaffeee3919 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:14
>  #26 0x2aafff10ddac in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:596:12
>  #27 0x2aafff10e11a in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:582:64
>  #28 0x2aafab4c3938 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) unotest/source/cpp/macros_test.cxx:50:60
>  #29 0x2aaf90aee900 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:621:23
>  #30 0x2aaf90aed267 in SwModelTestBase::load(char const*, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:610:16
>  #31 0x2aaf90aec404 in SwModelTestBase::executeImportTest(char const*) sw/qa/extras/inc/swmodeltestbase.hxx:222:13
>  #32 0x2aaf90cf4d31 in testTdf65642::Import() sw/qa/extras/rtfexport/rtfexport.cxx:1013:1
>  #33 0x2aaf90cf62af in CppUnit::TestCaller<testTdf65642>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6
>  #34 0x2aaf4ee5d7dd in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
>  #35 0x2aaf680c4cd6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14
>  #36 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>  #37 0x2aaf5ea4a8a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
>  #38 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>  #39 0x2aaf5abd5ef4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:65:16
>  #40 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>  #41 0x2aaf4ed8c2ef in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
>  #42 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>  #43 0x2aaf4ee14101 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18
>  #44 0x2aaf4eede065 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28
>  #45 0x2aaf4ee5a929 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13
>  #46 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
>  #47 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>  #48 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
>  #49 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>  #50 0x2aaf4ef1eeb6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
>  #51 0x2aaf4eedbe79 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9
>  #52 0x2aaf4ef20440 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
>  #53 0x52b642 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20
>  #54 0x52604d in sal_main() sal/cppunittester/cppunittester.cxx:455:20
>  #55 0x524192 in main sal/cppunittester/cppunittester.cxx:362:1
>  #56 0x2aaf50b3c730 in __libc_start_main (/lib64/libc.so.6+0x20730)
>  #57 0x437658 in _start (workdir/LinkTarget/Executable/cppunittester+0x437658)

Change-Id: Id170860cbff9f4cae5c87cb5cfc70ffe3bc8c9c5

tdf#96662, only use the crossBetween="midCat" for line and scatter chart

Change-Id: Id2be263daf2c5a9f2d69ed50b79ac029143f02ca
Reviewed-on: https://gerrit.libreoffice.org/29080
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

tdf#102308 sw: improve redline timestamp precision

It's not clear why it was like this since the initial import, but at
least not clearing seconds is already an improvement.

Change-Id: Ic452256d4ab47e6779ec71fe6576eacb5b74fb43

tdf#101164 sw: Insert Database Columns dialog: expect selection

... as bookmarks, not raw row indexes.  Bookmarks is what
FmXGridPeer::getSelection() / FmGridControl::getSelectionBookmarks()
always produce, and it's unclear to me if there even is a case where
something other than a bookmark ends up pasted into Writer.

The only case where dbaccess creates a selection that doesn't contain
bookmarks is in SbaGridControl::implTransferSelectedRows() if no rows
are selected but i haven't figured out how to reach that state.

(regression in OOo 3.3)

Change-Id: Ib45787bc002447338df775102790843f2cb1dd3b

tdf#101164 sw: Insert Database Columns dialog: ensure one of ...

... the radio buttons is active by default, in case there's no
configuration to read the state from yet.

Change-Id: If1c0462eb5cb9ea5177f1d5a8953b34fabd0829c

o3tl: replace yet another sal_Size with std::size_t

Change-Id: I3f6a401d6d5ed7b44a71dc8bda559dcc4d57ee32

fix build

by reverting part of commit b18e1bc61ccba9d0c74274e2fe45b2b422c601cf
"loplugin:unusedfields"

Change-Id: I69274b54f65e22ec15a053b54af84635d245f51b

CPPUNIT_ASSERT_EQUAL disambiguation

Change-Id: I31d30627badb08469f7e0fd3ded957df78b58275

tdf#102223 EDITING Deleting all content from a cell changes font formatting

The code in question was added in:
  commit 48ea88c8c8194d65105aa22108583369575926e1
  Author: Rüdiger Timm <rt@openoffice.org>
  Date:   Wed Mar 12 09:02:20 2008 +0000
  INTEGRATION: CWS impresstables2 (1.1.2); FILE ADDED

So hard to tell what its original purpose was. Probably trying to clean
up the model, but had the unintended side effect of removing styles.

Change-Id: I7d774706c22cf72e914b356df9bbc5947ee2c1a5
Reviewed-on: https://gerrit.libreoffice.org/28950
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

loplugin:unusedfields

Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24
Reviewed-on: https://gerrit.libreoffice.org/29078
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Related: rhbz#1362451 avoid recursive ownerchanged handling during ownerchange

Change-Id: Id9c12b7ce6458348890d7c7ff7fdb2cd37c4601c

tdf#102295: remove mutex - use atomic for watchdog timings

Change-Id: I6587bad8b7906faeae39735343278b10be78c05b

Related cid#1371287: Work around missing OStringBuffer move semantics

...by adding more assign op overloads instead

Change-Id: I3686d6c29adc47b1a8c48be4260614fd53589c8b

Related cid#1371289: Work around missing OUStringBuffer move semantics

...by adding more assign op overloads instead

Change-Id: I2d2e1b7f19d1b57528707ed5a5cce94b5fa5c2d0

Related cid#1371287: Improve code to not depend on missing move assignment

Change-Id: I0397812ed7b728e03199d64929c42292fc9b1502

cid#1371306: Add move semantics

Change-Id: Id669a84742cc4ffa3bb9f225af7fa4d218999681

cid#1371245: Add move semantics

Change-Id: I35daf9030478831262521497a1977bdfbe661dd8

cid#1371291: Add move semantics

Change-Id: I9bca3413e023b6909fbf75e567ed75739189bc43

Related cid#1371289: Improve code to not depend on missing move assignment

Change-Id: I6f0b8247b6757ddee158bd870473b749f22e7671

Remove redundant default ctor definition

Change-Id: Ifdeaf8cde86eb284e7b5c67e8ef3bfe816c5654c

Related cid#1371287: Improve code to not depend on missing move assignment

Change-Id: I4c03ad08078e25ea7f7d754e6eaa587da7984c9d

Related cid#1371289: Improve code to not depend on missing move assignment

Change-Id: Id254fa76cafe33a36646d517d224ba6a05406c09

Related cid#1371289: Improve code to not depend on missing move assignment

Change-Id: I332010574a2ddd13590452f08da32f21f8ef882b

Mark new exported function as SAL_CALL

...for consistency with existing exported functions

Change-Id: Ib513dc8ce4dbf4e614f5453f2bbd32dcac4b8666

external/liborcus: Mark patch as upstreamed

Change-Id: Id830c74cbdfb759300ae278df2ece642eb3579bb

Adapt loplugin:dllprivate to DISABLE_DYNLOADING

Change-Id: I721cfeaa144c773ead457e1c9138009d4071a06a

external/liborcus: Let us override -fvisiblity=hidden

(needed by UBSan builds that use -fvisibility-ms-compat instead)

Change-Id: Ifabaf352cf2b9e77f9458eff46e240141f9e729d

tdf#84684 RTF import: fix ZOrder of child shapes inside group shape

Both ODF and OOXML's drawingML seem to just not write ZOrder for child
shapes (instead they just describe them in a bottom-up order), but RTF
does use dhgt, it seems. Given that ZOrder has different meaning inside
and outside a group shape use a stack of GraphicZOrderHelpers to get the
correct result.

Change-Id: I68dbd9f0ae59a1759da14bf414dc1d277d1c927d

tdf#102295: AMD actually has two vendor id's.

Change-Id: I9cc1341c8f8d154927a778dfa15b8d3013a9a487

tdf#102295: The relaxed values were actually too pessimistic.

Change-Id: Ia117ae4a60a10994f3c59316e8c9a161aa8e5baf

Remove HAVE_GCC_VISIBILITY_BROKEN, never true

The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug.
Its roots date back to 072e89cf68dcf9b6713945e402dd7a9fe5cea48d "INTEGRATION:
CWS newportstl" of the --with(out)-stlport area.  Lets assume whatever failure
is long since fixed.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d
Reviewed-on: https://gerrit.libreoffice.org/29075
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Remove obsolete HAVE_GCC_VISIBILITY_BROKEN check

<https://llvm.org/bugs/show_bug.cgi?id=12255> "with -fvisibility-inlines-hidden
needed copy not emitted for virtual inline function" (which covers the relevant
part of the Clang bug 11250 mentioned in the check) is reportedly fixed ever
since at last Clang 3.2.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I47edf92968f32735a509ef649e0e85b891baab4b
Reviewed-on: https://gerrit.libreoffice.org/29074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

[API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always true

* GCC documents -fvisibility at least as far back as the GCC 4.0 online
  documentation at
  <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.

* For external code, odk/settings/settings.mk unconditionally set
  HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Remove obsolete HAVE_GCC_VISIBILITY_FEATURE check

<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26905> "default-visibility class
symbol improperly resolved as hidden-visibility" is fixed ever since GCC 4.2.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: Ie365d5a0e2217a4efd1e8e2642963738ae7d20b1
Reviewed-on: https://gerrit.libreoffice.org/29072
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Remove obsolete HAVE_GCC_VISIBILITY_FEATURE check

<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19664> "libstdc++ headers should
have pop/push of the visibility around the declarations" (aka gcc#22482,
rhbz#162935) is fixed ever since GCC 4.2.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I3e8fde187b4b20652ee3164485ef868a9bf5a7ce
Reviewed-on: https://gerrit.libreoffice.org/29071
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

convert constants to scoped enum TblAction

move enum to header because default function parameters need them.
added default case to switch to mute 'not handled case' warnings.

Change-Id: I54d8734232e7568fd21ad0178a8492b4903866a3
Reviewed-on: https://gerrit.libreoffice.org/29038
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

adapt aMsgItemInfo to 5b8c22379

Change-Id: If5fd822f3f90b204d2661cf7b4446cb925ee6f3b

tdf#97049 Export "intd" to MathML

Change-Id: Ie1fc33e18958e73d4876b2b5daceec127011c3cc
Reviewed-on: https://gerrit.libreoffice.org/29003
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Obsolete workaround for SUNPRO 5 compiler

Change-Id: Ib51f08e1d0e0dff066b06ecd85976b777d722a33

Remove obsolete workaround for SUNPRO 5 compiler

...copy/pasted into three more places

Change-Id: I6661244d0248af509cd867fc3e8c451551068a78

Updated core
Project: help  229282b80660a023077e5330afbbae51398b9690

It’s called an asterisk

Change-Id: If15846de1cd0df1023198bff74711419ec3137f5

Updated core
Project: help  e8cbb3daf90aa2a6f2e68c01841535b49d53d066

tdf#97105 Fix location of the Freze Rows and Columns menu item

This is now under View -> Freeze Cells

Change-Id: I6968ee93a1d2f12451791b297b9497eae6e93cd6
Reviewed-on: https://gerrit.libreoffice.org/29024
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

tdf#102295: relax timeout timings for the GL watchdog

Some OS/GPU combinations need more relaxed watchdog timeout timings
as the shader compilation takes too long to complete.

Change-Id: Ifd9ff7ecfa4b004d5411d6d364dd01a389a3fcec

try to generate more excel compliant files, tdf#41722

§18.3.1.10 says for the operator attribute: "The operator in a "cell
value is" conditional formatting rule. This attribute is ignored if
type is not equal to cellIs"

but checking §18.18.15 there are at least 4 attribute values that are
not related to cellIs. I have added them now but need to test that this
really helps.

Change-Id: Id15efc7e0148b4e3b54404d1ffd911adc56b11ec

Resolves: tdf#102293 triple click results in visually unselected word

in previously unselected textboxes in impress

started happening after...

commit 16c7f8916661df24f4681ec82f6bd4d7ad85d141
Date:   Tue Jan 12 16:36:49 2016 +0000

    tdf#97075 - don't render sdr overlays before we paint

in impress instead flush the overlay after activating the edit object
if we go on to put the cursor in there. Seems to work.

Change-Id: Ib746c36d1074aee09771a3dc1d69834ce80a9c08

Explanation of the SPRM acronym added to definition of the Sprm class

Change-Id: I536cd6ba2d531292d5148819dfd914b76f4b1111
Reviewed-on: https://gerrit.libreoffice.org/29032
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

sw: emit LOK_CALLBACK_STATE_CHANGED when cursor enters/leaves a redline

For now only care about the start of the cursor, which can be only at a
single redline.

Add matching testcase + expose it in the gtktiledviewer status bar for
interactive manual testing.

Change-Id: Ib61757412d6b54bef64361d4a8563795ca0bab6c

in GetInt...() check !isFinite() instead of isNan()

... and propagate coded double error instead of setting
errIllegalArgument.

Change-Id: I28456c3b0320181a80fe255e875a0bd78216c279

Resolves: tdf#100409 do not return coded double error for single matrix value

Change-Id: I94477bf64ee7972e9822921a8a15d935cb01e53b

Fix '--as-needed' build for zmf with system libpng

Change-Id: I92378dae4a515a587c897fff83b15d8e836b0aa2
Reviewed-on: https://gerrit.libreoffice.org/28974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

tdf#100393, handle copying one cell to multiple cols with cond format

The same fix has been applied for rows already.

Change-Id: I77300680a657fb874d07641fbae928eb6c210acd

fftester: isAsciiLowerCase has a isUnicodeCodePoint assert

which is not helpful when the data is incoming from the outside
world

Change-Id: I00304ed0d577944a33f5fa6af155f1d130ab7d59

fftester: only decrement if there's a valid position before it

Change-Id: I64bddeb805ac5c2ad6d76e2b3271ae8a216d603f

Add .editorconfig file

See http://editorconfig.org

Change-Id: Ia571ca5d53fb9f02bd8d208b922c8ec5ef1939e5
Reviewed-on: https://gerrit.libreoffice.org/28962
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

tdf#101919: rename ownCloud to Remote server

Change-Id: I217fdc805ce425f8a4a17d0d0e924e532ec070de
Reviewed-on: https://gerrit.libreoffice.org/28983
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

tdf#101094 (32): Use a partial GET as a fall-back for HEAD...

... partial GET means a GET with no data returned, to test for
resource 'real' availability in case HEAD fails or is disabled.
At  the same time disable use of HEAD method on the resource
for the whole access procedure.

This change is needed to manage web servers that don't permit the
use of either HEAD or OPTIONS methods.
To accomodate pure web sites that enable only GET to fetch contents.

Change-Id: If52316ddd6ce637fb7d2ef518423de246ee2dcfb
Reviewed-on: https://gerrit.libreoffice.org/28992
Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>

Related: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...

This is similar to de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1 where

the master page is not the sole owner. Which happens when copying
and pasting slides which bring along a duplicate master page to
an already existing one, and the attempt to remove the duplicate
strips the fill properties from the shared stylesheet in use by
the other

regression from...

commit b876bbe2cacce8af379b10d82da6c7e7d229b361
Author: David Tardon <dtardon@redhat.com>
Date:   Tue Apr 26 09:17:11 2016 +0200

    rbhz#1326602 avoid exp. bg bitmaps from deleted slides

Change-Id: I0a3a34ade2ad8464b1edb67a6e28dab45c761a2c

convert storeAccessMode to scoped enum

Change-Id: I67705cdff0440487019a2992571147d648be1bfc

convert CopyOrNewType to scoped enum

Change-Id: I4bc01dfbf3305e7eaa0887444e894d14e9e4d092

convert UndoOrRedo_t to scoped enum

Change-Id: I8d4dec9a3a861a45e41f8c8699ae5f8d81211369

loplugin:unusedenumvalues

Change-Id: I9dcc9f73af6db5b4f7cc946bc28931e5c230b34c
Reviewed-on: https://gerrit.libreoffice.org/29012
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

cid#1371142: Move semantics for css::uno::WeakReferenceHelper

Change-Id: I442b2d8061bd7d50cbf832b345a7a63461e26224

Updated core
Project: help  f3339c932c24d48eb854399d92cd7ca64fe3ea1c

tdf#97823 Change SearchCriteria parameter of HLOOKUP

VLOOKUP uses singular, as it looks for one value.
Change it at HLOOKUP so it's both grammatically correct
and matches the parameter in the linked VLOOKUP description.

Change-Id: I4b8247ccb90fb726e3526675b4eba2f6fb51c29e
Reviewed-on: https://gerrit.libreoffice.org/29014
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Updated core
Project: help  939edb112114cf3e740012a429d1f69a0d1d9bdb

tdf#97823 Change VLOOKUP parameter SortOrder to Sorted

Sync with HLOOKUP's Sorted parameter. This is a boolean
indicating if the data is sorted or not, not the order
like ascending or descending.

Change-Id: Ic48de6597c6b1997502c4dffb4a5bb15cbe49d74
Reviewed-on: https://gerrit.libreoffice.org/29013
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Updated core
Project: help  da9f009d25a28d75b0c8dabdf57c0e72e505941e

Add couple of screenshots to help files

Change-Id: I5cfe4c7bb48c588aaecb1e9299e8e2b59c680fda
Reviewed-on: https://gerrit.libreoffice.org/28613
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

tdf#96453, tdf#100793 rework transfer of data between cond format dlgs

The xml based transfer of information was a bad idea from the start. It
can obviously not transport the temporary conditional format information
from the manager dialog. Therefore the whole handling here was
completely broken and deleted formats came back, changed formats were
not saved and added formats got applied directly to the document.

Now the document fornat list and the one from the manager are indepedent
again and as long as the manager has not been closed with ok nothing is
written to the document.

Change-Id: I9802be11cd15c2d2d877e55c91d836735fe0e0ff
Reviewed-on: https://gerrit.libreoffice.org/28995
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

sw: prefix members of SwAccessiblePortionData

Change-Id: Ia41a57b11e2df5261657855e92701dce4cbe95aa

Remove mention of NSIS from NOTICE cause we don't use it...

since

commit 2ba4a4bf6384cd57664d316dd479bddfa38760d6
Author: Andras Timar <atimar@suse.com>
Date:   Tue Dec 6 19:28:21 2011 +0100

    remove NSIS support

Change-Id: I2388acbcefbb9d7422d49c28e1a0a24f80fc1c1d

Related: rhbz#1373933 gtk3 emits a lot of style-updateds signals

so don't throw away font settings every time, check if the font settings
changed and only emit FontChanged if they differ from the last seen settings.

Change-Id: I129887e3e866f395da3b906a38cf568abea5de8e

liborcus: fix Android build

stoi() is missing in the std namespace on the broken Android toolchain,
work it around.

Change-Id: I9ea4f89bea346a4383fbb99e03b09ebae43d21e5

o3tl: refcounts should be native platform int width

Change-Id: I19854d85b680612733557c42ee58b35adb5ea4c3
Reviewed-on: https://gerrit.libreoffice.org/29002
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

add BETA.DIST test case

Change-Id: I514e06585fac3c16a40318f8d51d389fd13c9c5a
Reviewed-on: https://gerrit.libreoffice.org/28997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

add FTEST test case

Change-Id: Icae9ed5dee0f9b230e4629b47d9a3eaff0328534
Reviewed-on: https://gerrit.libreoffice.org/28988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Updated core
Project: help  e21bf9fa94cae8ec3527bed2aa6b4c71501b65eb

tdf#97821 Add section anchors to VLOOKUP/HLOOKUP links

The missing anchors caused the links to not work

Change-Id: I4af8d0467cec347dee535f510133819987e88491
Reviewed-on: https://gerrit.libreoffice.org/29010
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>