uitest: fixed for formatting and plugin stringconstant

Change-Id: Id657c19223f20d1175f9a774357e8b1f11344fdf

uitest: add the SideBar implementation

Change-Id: I7de9bd97e868624476b5c39a5e37afc945206e4e

uitest: ignore the logging part of the QuerySaveDialog while closing the app

Change-Id: I18fcc81fa54362dfaa574ec04125e66b37a5aad8

uitest: use prefix for names that has conflict with python's keywords

Change-Id: I01d044a96eeae60a070a5ca0fc8d6105d7333414

uitest: replace tabs with spaces

Change-Id: I40779dfdb65037838e1a1b7bed5d89a656047ce6

uitest: add footer line support

Change-Id: I740995d811be030f406f9d3ff53c56d28af2b786

uitest: solve problem with un-named parents

1) Add recursively query for the parent until find an parent with a name.

2) Remove the parent part "from xxxxxx" from the log statment if there is un-named parent

3) Update the compiler to use the most top parent if there is command with no un-named parent

Change-Id: Id7dd5092bc995312494b5536720141908e73af9a

uitest: log more events in Calc:

1) Rename Tab
2) Insert Tab

Change-Id: I7a653a4b274c0c8058672c5b0aa1645bb5a51e3a

uitest: log more events

Impress:
1) Delete Slide
2) Duplicate Slide
3) Rename Slide

Draw:
1) Delte Page
2) Rename Page

Change-Id: I124bdf96c58dfe00bdb039c5e93afc0dc6e7163d

uitest: add more events to ui logger

for Impress:
  add new Slide
for Draw:
  add new Page

Modify the UILogger System to save information about the name of the app

Change-Id: I87fd98b2a11783e3410f1c0eba633631addf389b

uitest: start logging draw events

Change-Id: I1b77b106db181a8cadc1ff0b2a5de6ad19fe6762

uitest: update UI logger grammar

1) Make small changes in the UI logger Grammar
2) Add Comments to be more documented

Change-Id: I5e68c33375870cf4a1f2537ee1a7eb997145f24f

uitest: log more events

for Calc:
1) Delete some Cells
2) Remove content from some cells
3) Insert Cells
4) Cut Cells
5) Copy Cells
6) Paste Cells
7) Merge Cells
8) Split Cell ( Delete Merge )

for Writer:
1) Insert Table
2) Copy Text
3) Cut Text
4) Paste Text
5) Inser Break Page

Also, Solve some bugs in the UI logger and UNO Commands.

Change-Id: Ic7cacbc20e1e400900a9760b61e8b45ae96c84ff

uitest: solve some bugs in the ui logger

Change-Id: I39836423fad8cb361a8f007f648108618906be8a

uitest: add general functions to remove redundunt lines

1) init_app
2) init_Object
3) write_line_without_parameters
4) write_line_with_one_parameters

Then Rewrite the handlers again

Change-Id: I8ceb01f4eaa48f1544ada8966c7585dcbd3e15aa

uitest: add more DSL commands

1) Calc
(calc_Type_command - calc_switch_sheet - calc_Select_cell - calc_AutoFill_filter)

2) impress
(impress_Type_command)

3) math
(math_element_selector - math_Type_command)

4) General Commands Compiler:
(setZoom_command)

Change-Id: Ifd2608c38474633b579a216356fe53c859c24975

uitest: add special commands of writer app implementation

1) Type Command
2) Select Command
3) GoTo page

Change-Id: I5ee773b6cd322c2c1bf0eba58e704b2ff1399ce7

uitest: implement the missing part of the dialog compiler

Change-Id: I08881b738b3e7922b74f9d007733278e2b6ef54e

uitest: add DSL compiler support for more UI items

1) ButtonUIObject
2) CheckBoxUIObject
3) TabControlUIObject
4) ComboBoxUIObject
5) RadioButtonUIObject
6) ListBoxUIObject
7) SpinFieldUIObject
8) EditUIObject

Change-Id: Ic81c2a0511351cf91f4514316b9c5854a64a4b05

uitest: start the implementation of the new DSL compiler

1) finish the functions that will parse inputs
2) add function to initialize the UI test Case
3) add function to print the ui new test case
4) add the UNO caommands handler
5) add the Dialog commands handler
6) add the Starter commands handler

Change-Id: Ided1c050023c5284457f62c4b8d5ea1cfa38c043

uitest: change small parts of the grammar and dialog logger

Change-Id: I615989baafe65a6f6ae26fcd452c1e21081168b4

uitest: Some new features in ui_logger project

this patch for:
1) general commands grammar
2) special commands of impress and math
3) log select element action
4) log SideBar Actions

Change-Id: If375cd3396cfde45f70d7c202339c829b1c43471

uitest: just update zoom statement

Change-Id: I0bc5c4179dcb94ed2cc4a551165fd135d884a75a

uitest: update the DSL grammar

Change-Id: I15fe20f1c5e8339f6d5a857b0d0bbfa30b09b44a

uitest: new logger DSL grammar

This patch is the first and second parts of the new DSL grammar. The
grammar of all the UIObjects , Dialogs , starter commands , All of uno
commands and Special commands for applications. example.ul shows an
example of the new syntax of the expected new logger.

Change-Id: Ib58aeab1da6627ebc464e4cb64253fd3bf91200e

uitest: Rewrite all the logger statements with the new grammar syntax

Finished parts from old logger:
1) UNOCommands
2) StarterCommands
3) UIObjectCommand
4) DialogCommand
5) SpecialCommand

Change-Id: Ia521efef0abe1a351b9a4fcabaab6dbf20e8fc89

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in sw

Change-Id: I40bae418b5cf966eb76ba130eb6cb5ceb29efff7
Reviewed-on: https://gerrit.libreoffice.org/77658
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in sc, sd

Change-Id: Id32e76ad37000084b99781e87428ed2c23ef02a6
Reviewed-on: https://gerrit.libreoffice.org/77657
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in vcl

Change-Id: Ibd66e5ed9064612b73d08fac179ee46dc5b0a4b6
Reviewed-on: https://gerrit.libreoffice.org/77656
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Simplify code in unoxml about initializations

Change-Id: I7bc1d82d70f26b1cb7289b87a52e1f59fb740817
Reviewed-on: https://gerrit.libreoffice.org/77655
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Related: tdf#126787: remove some defensive programming parts

I assume that these shouldn't be possible. If I am wrong, this commit
is easy to revert.

Change-Id: Icc2acb4d1150b713233823fe313b4d5044d4b33e
Reviewed-on: https://gerrit.libreoffice.org/77641
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in svx

Change-Id: I70cba5dbfed9b2bbfe82d89c9dc6a5875c953bd3
Reviewed-on: https://gerrit.libreoffice.org/77649
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in scaddins, scripting

Change-Id: I92e6380f535aec12c1f1c5c51d8b544c8a7d9611
Reviewed-on: https://gerrit.libreoffice.org/77650
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in sfx2, stoc

Change-Id: I7138f702317d0e693438216732bf181f1972cdc1
Reviewed-on: https://gerrit.libreoffice.org/77648
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

loplugin:unusedmethods

Change-Id: I781a514787c83063dadd549ee043bbb264eee060
Reviewed-on: https://gerrit.libreoffice.org/77619
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in hwpfilter, include/test, io, linguistic, oox, pyuno, reportdesign

Change-Id: I5c265c4fde85dd6d7faab8ae82809c4a0e6dd69b
Reviewed-on: https://gerrit.libreoffice.org/77646
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in connectivity

Change-Id: I00eeffd9a13cfad6bbf84ea2d4ab720eb8c45ed8
Reviewed-on: https://gerrit.libreoffice.org/77635
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

upload libvisio 0.1.7

Change-Id: I4eb115c7c085b325370e9cd8f80e1b03f16f5033
Reviewed-on: https://gerrit.libreoffice.org/77640
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

upload libabw 0.1.3

Change-Id: Ibb45a473f49a9ba8f9cf53593dead375ac8a1951
Reviewed-on: https://gerrit.libreoffice.org/77639
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Fix typos

Change-Id: I1a77a08fb565e61ca2e277cdc4d78daf52e5fae9
Reviewed-on: https://gerrit.libreoffice.org/77632
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: I3f7feca68e10e53ac1a6bce2b3920fa0a142a5ef
Reviewed-on: https://gerrit.libreoffice.org/77628
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in forms and fpicker

Change-Id: Ifa931bed6de434a2ee183c78e8e1be852ca06a56
Reviewed-on: https://gerrit.libreoffice.org/77637
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in cppuhelper, desktop, drawinglayer, embeddedobj, extensions

Change-Id: I4c970f08c0723299f79c9e18bc71b7372a7092e4
Reviewed-on: https://gerrit.libreoffice.org/77636
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Access2Base - access2base.py fix DebugPrint

Display basic objects

Change-Id: I45c5718d364c09d71bb6cd47171d0621fb4a00e7

move RoadmapWizard to vcl

Change-Id: Iae2f5e0ac52dcf862035508db3a22cfd86d02d8f
Reviewed-on: https://gerrit.libreoffice.org/76903
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

tdf#125340 transport preferred dialog parent down the migration dialog

Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3
Reviewed-on: https://gerrit.libreoffice.org/77606
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Access2Base - access2base.py fix module class

Properties changed to methods when having arguments
Methods Find and ProcOfLine not supported
because they require passing arguments by reference
(not available in Python)

Change-Id: I92044e8ea4a07e2093b23699bf28b9d1ac0fe695

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in comphelper

Change-Id: I4d9b9e13801ebf7671ff651b931a6c4144860985
Reviewed-on: https://gerrit.libreoffice.org/77626
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Update git submodules

* Update helpcontent2 from branch 'master'
  - Python console examples work better this way

    Change-Id: I0c325b7fed727f398c11eea41d7c46a061c3a837
    Reviewed-on: https://gerrit.libreoffice.org/77598
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

loplugin:unnecessaryvirtual

Change-Id: I9f2e524a4fb467ddc198fce1ff4740d3768ceeac
Reviewed-on: https://gerrit.libreoffice.org/77618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Simplify Sequence iterations in postprocess..sax

Use range-based loops, STL and comphelper functions

Change-Id: If738d8f4e792c4686870183b0c0fdfbb61fd3351
Reviewed-on: https://gerrit.libreoffice.org/77245
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in testtools and toolkit

Change-Id: I14b53c27906eb615e68482cbc3918be8da464212
Reviewed-on: https://gerrit.libreoffice.org/77624
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in ucb, xmlhelp

Change-Id: I79f6378cff14c71987f77e0c08e0107bd4b3eefb
Reviewed-on: https://gerrit.libreoffice.org/77623
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in embeddedobj and filter

Change-Id: I2da3fa1df8782e449852358d1c86f5e4bc79ea1a
Reviewed-on: https://gerrit.libreoffice.org/77627
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in xmloff

Change-Id: Id76c050f4e67bbcada29e78b938cc03ba5d0f6dd
Reviewed-on: https://gerrit.libreoffice.org/77622
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Use simplified syntax for Sequence

Change-Id: I92ac60fafcc404439c101d1950ed214fce140c91
Reviewed-on: https://gerrit.libreoffice.org/77621
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Call isLinkUpdateAllowedInDoc() early in loadSrcDocument()

... so getExternalFileData() and isFileLoadable() aren't called
over and over again just to be discarded. Which happens for every
formula expression trying to access the document.

Change-Id: Id303f9a960d14398ab5c4967346328a8128b60dc
Reviewed-on: https://gerrit.libreoffice.org/77614
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

tdf#126787: extend/restore item set ranges to hold RES_PARATR_GRABBAG

The original item set did not include that in its ranges list, so it
ignored attempts to set its value.

Change-Id: I5f928206f0614f0cfd54652e77d7dc6b9833fb26
Reviewed-on: https://gerrit.libreoffice.org/77617
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Use a nice way of merging ranges

... which will ensure correct sorted order of the ranges.

Change-Id: I6acb068c38af581354f4736f8058cf73d14f5dc2
Reviewed-on: https://gerrit.libreoffice.org/77585
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

LOK: move LOK callback-type-to-string helper to header

This is a very common function that is used by clients
as well as LO Core, so makes sense to have it implemented
once and updated when new callback-types are added,
all in one place.

Change-Id: Id6a1d6bcf5585d7be440b62a0c3a9c993e46e5e0
Reviewed-on: https://gerrit.libreoffice.org/77587
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

CppunitTest_sw_uiwriter: fix top/left confusion in testImageComment

This worked before as usually both are 1418, but in the case of
<https://ci.libreoffice.org/job/gerrit_windows/43226/console> the left
is a larger value (4194), while the top stays the same.

Change-Id: Ie31cb29720f6426ad9e2a28405f326e6e82febaa
Reviewed-on: https://gerrit.libreoffice.org/77597
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

move WizardMachine to vcl

Change-Id: I55cc4a6c1ad111a22a43fd66a3cd01b5b02fb7cb
Reviewed-on: https://gerrit.libreoffice.org/76902
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

get_current_page_help_id is now tried first already

Change-Id: Id7f5d2c4bcfaba68afc83d471151e1daabf1a830
Reviewed-on: https://gerrit.libreoffice.org/77558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix typos

Change-Id: Ifa56c292559977577af45204f4cc8346e5706616
Reviewed-on: https://gerrit.libreoffice.org/77611
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: I8ab75eb5cd54d14fda42bcdb1a251e9e2b6fefdf
Reviewed-on: https://gerrit.libreoffice.org/77612
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: I5d0776d5f90f44ebbeeb5916cbbf6e87406adcad
Reviewed-on: https://gerrit.libreoffice.org/77609
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: I488908096aac319daf30875aee1e46b914cc4759
Reviewed-on: https://gerrit.libreoffice.org/77608
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: I207333e9bafc5d6c38ffa53a303046e437b7a815
Reviewed-on: https://gerrit.libreoffice.org/77607
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Change-Id: Ia8335622cb2e2b44f2b1ee36f7370b126d1ae642
Reviewed-on: https://gerrit.libreoffice.org/77610
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

tdf#126819 Can't retrieve the mouse position written in the statusbar

regression from
    commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763
    Date:   Mon Jul 8 11:22:12 2019 +0200
    tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText

Make the custom StatusBarControls set better text on their parent
StatusBar. Also remove some unnecessary work being done in the Paint
methods, to reduce confusion.

Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4
Reviewed-on: https://gerrit.libreoffice.org/77586
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fix tests taken from RFC 2396

"/g" was missing, and "http:g" had an extra "." (consistently applied to all
three occurrences of "http", but for unclear reasons).

(<https://www.rfc-editor.org/errata/eid452> claims that "?y" is an invalid
example that should be removed, but our algorithm does resolve it to the value
<http://a/b/c/?y> originally given in RFC 2396, so lets keep it for now.)

Change-Id: I3187abd36135723bd13293367a6cb6c06ca70b90
Reviewed-on: https://gerrit.libreoffice.org/77602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Resolves: tdf#126928 allow link updates in an intermediate linked document

... if link updates are allowed in the current document and that
intermediate document resides in a trusted location.

This works with both, the "Always (from trusted locations)" and
the "On request" settings under Tools -> Options -> Calc ->
General. It can't work with documents residing in a non-trusted
location as there is no way to allow updates on demand for a such
loaded document (hidden via formulas).

Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423
Reviewed-on: https://gerrit.libreoffice.org/77588
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

This was meant to be 'continue', not 'break'

... when commit ee0bf5d58bc59052923c4ced928a989956e71456 had introduced
SwUnoCursorHelper::SetPropertyValues, and the intent obviously was to
skip bad values, populating relevant error messages, and set all correct
values.

Change-Id: Id699f74a9df179c810608400983f88db1a7164b8
Reviewed-on: https://gerrit.libreoffice.org/77584
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Adapt loplugin:nullptr to RecursiveASTVisitior::TraverseInitListExpr change

...<https://github.com/llvm/llvm-project/commit/
0a42fe70a566f22599e04a6f1344ca2dc5565e17> "[AST] Treat semantic form of
InitListExpr as implicit code in traversals"

Change-Id: Ifd17009fcc6933abf0e9178dbe47fb9c14b274b7
Reviewed-on: https://gerrit.libreoffice.org/77595
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Re-enable stoc/test/uriproc/

...which had gone missing with d2097ad456b4626dd6972e015489ce3d22eb1872
"gbuildize stoc".  Required lots of loplugin warning fixes now.

Change-Id: I411034f462846557f72ea1e9a91cd88517d2944c
Reviewed-on: https://gerrit.libreoffice.org/77579
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

tdf#126877 crash on inserting floating frame

regression from
    commit 5043421fdc527d18d18121ec5fe2d4e009c8191a
    Date:   Fri Jul 19 14:05:10 2019 +0200
    loplugin:referencecasting in embeddedobj

OSpecialEmbeddedObject is playing games and effectively "unimplementing"
an interface it's superclass implements by doing custom stuff in
OSpecialEmbeddedObject::queryInterface.

So lets rather implement this in a more direct and obvious way.

Change-Id: I341b8e0b6acafac80cbd55f745811b73d2593585
Reviewed-on: https://gerrit.libreoffice.org/77580
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fix typos

Change-Id: Id8c879b81cde8da6119ac08d9d9028221486dc6a
Reviewed-on: https://gerrit.libreoffice.org/76764
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Fix typos

Split from
https://gerrit.libreoffice.org/#/c/76764/

Change-Id: I19f11f80f08ce0d5b4ffda20449f1cddea980b7d
Reviewed-on: https://gerrit.libreoffice.org/77596
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

tdf#126254 Help - About is black with Linux gen and gtk2

Change-Id: If18693e1cb8a92a7a152dd9decc892fc5f2b7ab5
Reviewed-on: https://gerrit.libreoffice.org/77591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

CppunitTest_sw_uiwriter: get rid of hardcoded 1418 in testImageComment

See a different value at
<https://ci.libreoffice.org/job/gerrit_windows/43196/console> and the
intention is to make sure the comment anchor and the fly frame position
matches, not to check the actual value.

Change-Id: I28eb39cfe5cbb57713b2c642a703e8509da25323
Reviewed-on: https://gerrit.libreoffice.org/77582
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Reorder to only get item state when necessary

Change-Id: I58baca984d2e95a0c9753b761be800f8edac9274
Reviewed-on: https://gerrit.libreoffice.org/77578
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in i18npool

Change-Id: I99563b620056e7cd665a2b3330d15c73d0144c7e
Reviewed-on: https://gerrit.libreoffice.org/77583
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#126908 Add lang to Tooltiplabel

Addition to commit?id=c3ca559841c857bf7b39f665433d71c89d220d0f

Change-Id: Ie51412b31239f6aaf3813dee5c226a21c7d9c79d
Reviewed-on: https://gerrit.libreoffice.org/77562
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

in dbaccess

Change-Id: I7f91b5fd8ac1dfbf6244c408391a595f5250aa71
Reviewed-on: https://gerrit.libreoffice.org/77563
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

tdf#126663 speed up styles display by sorting twice

Change-Id: Ice5c2d0fd92196984efebf8c1183c1ed8399d1fb
Reviewed-on: https://gerrit.libreoffice.org/77573
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Gtk3 inform LO of drag leave

Actually the correct code was added in commit 0b354d18ccfc
("Related: tdf#93054 gtk3: implement enough dnd to be dragged
into.."), but never enabled and then removed in commit c3074cb57843
("vcl: remove dead code). It's at least needed, so D'n'D between
two LO Calc windows correctly removes the pre-drop cell rectangle,
when the mouse leaves the 2nd window without doing the drop.

Commit references:
* 0b354d18ccfc05e7c2582f851d9201e2aa353d7d
* c3074cb5784329eaf558c2f58d96a64085b42d48

Change-Id: I55461f0c87cdef7a03fc261b363dc82642a3933d
Reviewed-on: https://gerrit.libreoffice.org/77568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Resolves: tdf#126951 crash in custom slide show

on selecting entry 0 which doesn't exist

Change-Id: I67656bed63f9055bc6c5dd5781e79f967996500d
Reviewed-on: https://gerrit.libreoffice.org/77560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Drop TimerTest::testStopwatch

(that had been added with 6e13585508ca3c9b66c6571ad1eb42bfcb66ef0b "Add a
TaskStopwatch to interrupt idle loops").  By the same reasoning as in
92e42a0fde32e3f2dbe2c786a0e41547e4912b4b "Drop bogus check from
TimerTest::testStopwatch", there is no guarantee that a StopwatchIdle would run
(close to) ten iterations of Invoke before calling Stop, so the two checks

    CPPUNIT_ASSERT_DOUBLES_EQUAL(10.0, double(n1Iter), 1.1);
    CPPUNIT_ASSERT_DOUBLES_EQUAL(10.0, double(n2Iter), 1.1);

are bogus, too.  And there are reports of failures like
<https://ci.libreoffice.org//job/lo_tb_master_linux/37847/>:

> /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/vcl/qa/cppunit/timer.cxx:603:TimerTest::testStopwatch
> double equality assertion failed
> - Expected: 10
> - Actual  : 6
> - Delta   : 1.1

So remove those two bogus checks.  But with them gone, testStopwatch would be
rather pointless, so remove it completely.

Change-Id: Iec627de48d693665cde7b5eed445640fedee391c
Reviewed-on: https://gerrit.libreoffice.org/77570
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

use more TOOLS_WARN_EXCEPTION

Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86
Reviewed-on: https://gerrit.libreoffice.org/77569
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

member 'Context' of struct type 'uno.Exception' not given a value

Change-Id: Ie80f729e5c1dbf3214f9532dcb935b239bac7997
Reviewed-on: https://gerrit.libreoffice.org/77566
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

AttributeError on getMessage

Change-Id: If0bd315fe605b850ec397eb2267b08ad8039355c
Reviewed-on: https://gerrit.libreoffice.org/77565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix typos and formatting

Change-Id: I24f2b7138ef1efb9c981e24804819ad2779b1b4b
Reviewed-on: https://gerrit.libreoffice.org/77567
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

an absolute uri is invalid input

Change-Id: I392be4282be8ed67e3451b28d2c9f22acd4c87fc
Reviewed-on: https://gerrit.libreoffice.org/77564
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Drop bogus check from TimerTest::testStopwatch

(that had been added with 6e13585508ca3c9b66c6571ad1eb42bfcb66ef0b "Add a
TaskStopwatch to interrupt idle loops").  For each StopwatchIdle, m_nIters
counts the calls to Invoke before it calls Stop (which it calls based on
tools::Time::GetSystemTicks calculations).  But the number of such
GetSystemTicks() spent in each Invoke is nondeterministic (it can e.g. be
affected by the overall system load), so a2Idle may Stop prior to a1Idle and
thus have a lower nIter2 than nIter1.

Change-Id: I416eee9774c3605be25e9832b24dec7d9dcb00c2
Reviewed-on: https://gerrit.libreoffice.org/77561
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

tdf#126007 tdf#122355 online help won't look into a dialog notebook

when the focus is on the help button, offline will through the help fallback
route, but online will just fire and forget and let the server side do a
fallback, which can't know what the current notebook page was.

so bodge it to look at the notebook page right from the start if there is one
and its the help button itself which starts the request

Change-Id: Ida1d3101d838d99639dda12c438414c16b1ccda5
Reviewed-on: https://gerrit.libreoffice.org/77548
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

new loplugin:sequenceloop

look for places we should be using std::as_const on for-range
loops over uno::Sequence, to avoid triggering a copy

Change-Id: I7efb641bf09d37c87946f03428ee4eec90298c8a
Reviewed-on: https://gerrit.libreoffice.org/77441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

xmloff: create XMLImpressMetaExportOOO instances with an uno constructor

See tdf#74608 for motivation.

Change-Id: I6c390f6cef83393b630bd0c157aff8d1359c6754
Reviewed-on: https://gerrit.libreoffice.org/77551
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Related tdf#90429: Don't erroneously pop unrelated path segments

...when coming across a bad set node <prop> member.  The ooo2gd_3.0.0.oxt (see
referenced bug for links) Addons.xcu contains two such bogus props

> <node oor:name="AddonUI">
>   <node oor:name="OfficeMenuBarMerging">
>     <node oor:name="org.openoffice.gdocs.gdocs" oor:op="replace">
>       <prop oor:name="ImageIdentifier" oor:type="xs:string">
>         <value/>
>       </prop>
>     </node>
>   </node>
>   <node oor:name="OfficeToolBar">
>     <node oor:name="org.openoffice.gdocs.gdocs" oor:op="replace">
>       <prop oor:name="UIName" oor:type="xs:string">
>         <value>Google Docs</value>
>       </prop>
>     </node>
>   </node>
> </node>

so that a later

> <node oor:name="AddonUI">
>   <node oor:name="Images">

was processed with path_ erroneously stripped down to the root path.

It appears that this has been broken ever since
7d9bce7ca0408786d0ad448dee0f2bf480870d3e "jl153: #i110720# ignore spurious
<prop> elements in .xcu set nodes".

Change-Id: I1d069b7226c8202b6eb93f59d294ce7f25681f80
Reviewed-on: https://gerrit.libreoffice.org/77537
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Record external/liborcus/create-element.patch.0 as covered upstream

Change-Id: Ib1b1baf75cbd2d011e96a3d5b8876a6b356b0b7e
Reviewed-on: https://gerrit.libreoffice.org/77536
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

loplugin:sequenceloop in xmloff

Change-Id: I1fde11da5f6e97255a9140f11c298d6d525f7230
Reviewed-on: https://gerrit.libreoffice.org/77543
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>