fdo#70496 revert to using libmysqlclient

Change-Id: I5b98b5e7840e4f1c6005aee0c1f43ef814ecf77b

fdo#68657 bool->string conversion to 1/0, not "true"/"false

This matches what OO.org / older versions of LibreOffice did, and which was inadvertently changed in 2bd856e6

Change-Id: I1d45ea975a096c599a996caafc41e4aa06d35fcd

fdo#70480 do not crash reading malformed zip

Change-Id: Ibbdf7ce4979f8452c4a662cc9ae3f598cce23126
(cherry picked from commit f2422ab90d92104915b93e96f647a89bbf55ad30)
Signed-off-by: David Tardon <dtardon@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/6313
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix build against the 10.8 SDK

Change-Id: I74adcca901e9a7c31d02779b1ee853731a55ea43
Reviewed-on: https://gerrit.libreoffice.org/6253
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#70319 "exponent followed by at least on digit" also for special case 0.0

Change-Id: I07e7917417b8a22cf6d64f2b7a447f9084b9fa2d
(cherry picked from commit 7bbd58eafc3146abcefc73d2d1ca6869bb47ef5a)
Reviewed-on: https://gerrit.libreoffice.org/6294
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Resolves: rhbz#1015594 CVE-2013-2924 use-after-free

Added icu.10318.CVE-2013-2924_changeset_34076.patch from
https://ssl.icu-project.org/trac/changeset/34076 assigned to
https://ssl.icu-project.org/trac/ticket/10318

Change-Id: I93a33e59aec9b79fb8d4b1517cd0990c79ee65fb
(cherry picked from commit 7693a4b9fbb60105d8438465db51c7afef4c3eb1)
Reviewed-on: https://gerrit.libreoffice.org/6268
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#69548 do not remove last space from hyperlink target

Change-Id: Ia56a4012590cc56b3beaa887cbbb91318a0977b1
Reviewed-on: https://gerrit.libreoffice.org/6263
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#56007 - Read more bytes on Zip read (for thumbnails)

Change-Id: Ia8c6caa44ed8019a8139beb5a855f0f28805544d
Signed-off-by: Andras Timar <andras.timar@collabora.com>

fdo#56007 - fast zip directory find to accelerate Windows Explorer thumbnail.

Change-Id: Id9436def56f40d2bb54dea35bea916bd99964653
Signed-off-by: Andras Timar <andras.timar@collabora.com>

resolved fdo#70319 exponent must be followed by at least one digit

(cherry picked from commit f20feba4c43c34fd2ee05b4658b0de0248c08eb9)

work around crappy SbiScanner::NextSym(), fdo#70319

just to make test not fail that was wrong anyway

(cherry picked from commit 472ad8ba7ef99982025b37aba562f2135ca8a999)

Change-Id: Icdd22fa0f1efcdd18cfea7cb48e1cbf2cf8d3533
Reviewed-on: https://gerrit.libreoffice.org/6241
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

CID#736943 clamp no of ttc entries to physical max

Change-Id: Ic63defe9c14c6ee2b86bd5b7730a570238ca3981
(cherry picked from commit 225539ab08043b6937fdd67d9ae308ebd4104646)
Reviewed-on: https://gerrit.libreoffice.org/6150
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

sw: fix regex search/replace of $ in selection

SwView::Replace() nowadays first searches for the to-be-replaced text in
the current selection, which does not work in the corner case of "$"
when the selection starts at end of a paragraph, as it will when
clicking "Find" to look for "$" and then clicking "Replace".

The problem is that there is some antique code in SwPaM::Find() to
move the cursor forward if it's at the end of a paragraph, which is
presumably some pointless micro-optimization; the result is that
"Replace" does not replace the selected paragraph break but the
one in the following paragraph.

(regression from 68a014dbca8bbd25056f75ef551fb81a0dbfb1b7)

Conflicts:
sw/source/core/crsr/findtxt.cxx

(cherry picked from commit b60ce8465c8f01242354abccebe00742d164af60)

Change-Id: I5aae9c272d102a48166c63e01775dc6322f9f02d
Reviewed-on: https://gerrit.libreoffice.org/6230
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#64495: sw: fix regex search for soft hyphen \xAD

The problem is that the soft hyphen apparently needs special handling,
and SwPaM::DoSearch() looked for the no longer supported legacy syntax,
not for any of the unicode character syntax that ICU regex supports.

Change-Id: I754296d2cf9286242e083cc7906ce3b8fda78dd5
(cherry picked from commit dca5163b6ef206ceb1f2d56feb7546c1929afe60)
Reviewed-on: https://gerrit.libreoffice.org/6229
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#67796: sw: fix table cursor when setting language in status bar

Unfortunately it turns out that the neat hack in commit
b227a8e4d65e4bbfe991aed9342fe3e30eca8639 does not work unless something
actually _deletes_ the current m_pTblCrsr between Push() and Pop(),
e.g. by calling SwCrsrShell::ClearMark() or KillPams().

It would be possible to do some invalidation of m_pTblCrsr in
SwCrsrShell::ClearUpCrsrs() or UpdateCrsr(), to set it's bChg flag
or perhaps call ParkTblCrsr(); not sure if doing that is an improvement;
certainly it shouldn't be tried in a 4.0.6 backport.

So work around the problem locally in SwTextShell::Execute().

Conflicts:
sw/source/ui/shells/textsh1.cxx

(cherry picked from commit 9533e01713c0170bdae030429de38756d9c5ca74)

Change-Id: I2981506b3065e824532deda28d21dad4a5734a8c
Reviewed-on: https://gerrit.libreoffice.org/6212
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fixed another "Out of bounds substring access"

Introduced with 3c2a26c84e70fd996855181d319970e2230b2459
Didn't have consequences here because the result was used to check for a
"startsWith" condition which it wouldn't had matched anyway. However,
use the real startsWith() now.

(cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197)

With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this
as well.

Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b
Reviewed-on: https://gerrit.libreoffice.org/6218
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Resolves: rhbz#996162 apparent NULL bullet font

Change-Id: I2f50ef1dabe2f152f2e18025edc88734158dbea2
(cherry picked from commit 166510ed48bf49b75a031ce973f41d08fb4e4518)
Reviewed-on: https://gerrit.libreoffice.org/6153
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Extension shared library components must not use the "prefix" feature

...at least no non-bundled ones, see 9dfcee9266c9769153444cdcd4ab0e6e636c3eb6
"Not being able to honor a 'prefix' is a rather hard error" and the description
there how that can lead to a crash when using mysql-connector-ooo.oxt:  "'rm -rf
instdir/*/share/extensions/mysql-connector-ooo', 'instdir/*/program/soffice
workdir/*/Extension/mysql-connector.oxt', install the [extension] per-user, then
'File - New - Database - Connect to an existing database: MySQL - Next >> -
Connect directly - Next >> - Database name: foo - Server / Port - Server: bar -
Next >> - Test Connection', crash."

This is a partial revert of cd79d51420b90117d0f3e1d5f3cdf9187bd61b88 "prefix all
component_getFactory methods."

Change-Id: Ia7a6272eb0597e3b3bbf4ab333174b3232448539
(cherry picked from commit 3bafe5f5f529f6539363c5a291dd13ef1e2cbbde)
Reviewed-on: https://gerrit.libreoffice.org/6209
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

resolved fdo#69948 honor a detected FilterName

TypeDetection::queryTypeByDescriptor() adds the FilterName property to
the MediaDescriptor, use that if present.

Strangely enough the sequence returned by XNameAccess::getByName(sType)
of the type detection contains an empty PreferredFilter value so that is
useless in this scenario.

(cherry picked from commit 823278dd095d754d0f673ef140c36c9fa7ebeffd)

Backported.

Change-Id: I5cdc9fe71e35bdb7c511739c7f7728134941649a
Reviewed-on: https://gerrit.libreoffice.org/6207
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

fdo#70143: fix SwDoc::ReplaceRangeImpl()

Fix fdo#70143 by reporting swaping of positions

(regression from 6b08fe833186a04f9aef698a540d3a7493ac4519,
which changed SwUndoReplace::Impl::SetEnd to use the wrongly set end
position in rPam)

Change-Id: I14c6f58bc5c1418c69eb565d42f1829856eed58c
(cherry picked from commit 9685d20f2a0526a4c454cea1bd947eccbaeefa84)

Fixes regex replace of "$" with nothing (to delete line
breaks).

Change-Id: If7ec1e5f524f7bb308a2949ace16cb8aa6989106
(cherry picked from commit f011a5c5071ed4a60f0ee7117608b72cecbb958d)
Reviewed-on: https://gerrit.libreoffice.org/6175
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

Resolves: #i123359# need to call SdrEndTextEdit before...

manipulating objects at model/view

(cherry picked from commit b5e8564995cd92e19cadcf8a6e9151be3efeeff4)

Change-Id: Ie282370c7fc2dea4f9d59d85aac742b41d7c4541
(cherry picked from commit 668730fbdd1ccf9a23d0a55361d019ca9e58ff39)

Updated core
Project: dictionaries  8349227a9dd98665d90b1ce744247fdaf5582936

updated pt dictionary

Change-Id: I9380049c2e0b6716287c71aa2693f40dc78facf6
Reviewed-on: https://gerrit.libreoffice.org/6178
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>

Fail fast at least in debug builds

Change-Id: I266d5cf5b98827617f7ed65c94a772e28808f386
(cherry picked from commit 57a28dc9556b4e6fff337e0eb9d0d8abc5223161)
Reviewed-on: https://gerrit.libreoffice.org/6186
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Prevent out-of-bounds arguments to OUString::copy

...which would somewhat unhelpfully result in returning "!!br0ken!!"

(partial backport of 34e951bd7284d2e771c279e3adc3899d191fdad0 "More
OUString::copy out-of-bounds fixes")

Change-Id: Ibf66d218fe5f0d7b6216795a3b991705d4afda73
Reviewed-on: https://gerrit.libreoffice.org/6183
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

CID#736174 yikes, sizeof(char[]) includes 0, so 4 not 3

Change-Id: Ia54ecab9e08485ebffe98dc064f328360c17a120
(cherry picked from commit 8254648828e4f4d65a0516e160e5732f3d85765a)
Reviewed-on: https://gerrit.libreoffice.org/6173
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

bnc#779620 DOCX import: try harder to convert floating tables to text frames

Since 78d1f1c2835b9fae0f91ed771fc1d594c7817502, we convert floating
tables to text frames only in case it's possible that there will be
wrapping, to give better results for multi-page tables, which are
multi-page, and technically floating ones, but that has no effect on the
layout.

The problem was that we try to do this decision too early, effectively
the page width and margins were counted from the default letter size,
instead of the actual values, which did not arrive at the time of the
decision. Fix this by moving this logic at the section end.

(cherry picked from commit bbef85c157169efa958ea1014d91d467cb243e6f)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx
writerfilter/source/dmapper/DomainMapper_Impl.hxx

Change-Id: Ic1fbceb54c8ec223ed01836fafe6220bb3b2410a
Reviewed-on: https://gerrit.libreoffice.org/6104
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix fdo#70220 Superscript not imported from pptx.

Import works now, though EditEngine still fscks up font scaling -
seems for CharEscapementHeight to work, there has to be reference,
non-scaled text in the same portion ...

Change-Id: I5505ae83bd6b700ebe8c3465beec40a4df2efb78
Reviewed-on: https://gerrit.libreoffice.org/6154
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#67074 push the localized macinstall.ulf to solver

Change-Id: I0c7ed3d5bbad93adeba6175f0a9789fcb8ec3d3f
Reviewed-on: https://gerrit.libreoffice.org/6170
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#64400: DXF import filter: fix OUString handling

The DXF import filter stores all strings read from the file in
char[DXF_MAX_STRING_LEN+1] arrays, and then calls OUString constructor
with that which then asserts because the string is actually shorter than
the size of the array... avoid that by converting from char* to OString.

Actually this also fixes the actual bug: the weird lines in the exported
PDF were tiny Text elements from the document, repeated.

(cherry picked from commit 96852a89da058084b2acf5ff706d9679b127b29a)

Change-Id: I93c52788f88fe5d21968d450d029ed5db101d88b
Reviewed-on: https://gerrit.libreoffice.org/6151
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#70201: sw: eliminate no-extent RSID-only AUTOFMT hints

These are already filtered out in SwpHints::TryInsertHint(), but they
can be produced by a SwTxtNode::Update() following some deletion like in
SwTxtNode::ReplaceText() (or maybe CutImpl() and RstAttr() too?).

So in order to prevent SwHistorySetTxt being created for these,
filter them out in SwpHints::MergePortions(), which has the advantage
that it's one location to change; probably filtering in Update() and
RstAttr() both would work too.

(regression from 6db39dbd7378351f6476f6db25eb7110c9cfb291)

Change-Id: I597a9ab290dcc3fb1b624dd2dca241c462acf256
(cherry picked from commit 91159b1c31a7fd474ba0b97828f593604790ce3c)
Reviewed-on: https://gerrit.libreoffice.org/6167
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#62994 reportbuilder survive empty formula

Change-Id: I1da053871d107730ad9a135deb48313d8a877d89
Reviewed-on: https://gerrit.libreoffice.org/6166
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

WaE [-Wstrict-overflow] assuming signed overflow does not occur

... when assuming that (X - c) <= X is always true
... or that (X + c) < X is always false

Change-Id: Ib2313827cd6358ced0141b41cba753896b676e28
(cherry picked from commit ca576e0804324bbb36b697543cbe992e34d4b951)
Reviewed-on: https://gerrit.libreoffice.org/6158
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

bump product version to 4.1.4.0.0+

Change-Id: I7416968f44df48b25416bafe9d5357988cc55fef

Updated core
Project: translations  e80c5f716acc72479afcb558d920a72925d1ff47

I forgot to add -d swith to signtool

The UAC prompt shows a temporary random Program Name for msi, if the
-d switch is not given.

One more change: probably it is not wise to print the password of
code signing key in clear text to log and to screen.

Change-Id: I1f555754eee19708bbd7a3c70280fe662c77fc3a
Reviewed-on: https://gerrit.libreoffice.org/6081
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

fdo#52004 set resolution of .dmg background image to 72DPI

Apparently Mac OS X looks at the DPI value, not to the actual pixel
size of the image.

Change-Id: I9fd43228e4d2e05397f798ed4902d7d80ef2145f
Reviewed-on: https://gerrit.libreoffice.org/6162
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

fdo#66591 help needs this image

Change-Id: I52c6455c1e8a09a6658b3d940e61d3424a16206e
Reviewed-on: https://gerrit.libreoffice.org/6145
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#70196: Python 2 compatibility for UNO import error handling

Add backwards compatibility support for Python 2 to the earlier
change in fdo#66025 to improve import error handling under Python 3.

Change-Id: I47bf8ef255c4c2a3e4a2754414977aaa8ed32483
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit df1076965f63eedc6cc104c96b993ab598b8b1d4)

rhbz#1001768: avoid deadlock in OAccessibleContextHelper::disposing()

De facto this class is locked by SolarMutex, which is what the
OExternalLockGuard actually locks;
do not lock m_Mutex because it may cause deadlock.

Change-Id: I88b226d73dbef9a5803347b0ac3191bec2ba4515
(cherry picked from commit 4100e3b6204fc304cc7b60b9d7ff2af75118b805)
Reviewed-on: https://gerrit.libreoffice.org/6114
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

fix STL assert in accessibility::AccessibleGridControl::commitTableEvent

While running some JunitTest, crashes on an attempt to delete entries
of an empty vector m_pImpl->m_pTable->m_pCellVector.

The entries are created on-demand by
AccessibleGridControlTable::getAccessibleChild(), so presumably that
hadn't been called yet when the rows were deleted.

Also fix bizarre abuse of all applicable variable naming conventions.

(regression from 2095b2e1d44a158418d17836019352ed92f95d21)

Change-Id: Id2d70ca4601a166718629c0fe922f805dd72eec1
(cherry picked from commit 4fc7deb7b0528010ebf644654bf4a36594e03f8c)
Reviewed-on: https://gerrit.libreoffice.org/6131
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: #i123417# handle subsetting of empty ttf compound glyphs gracefully

(cherry picked from commit d519b07ecd4b67cedf1fe3e1860ef33a48a01ae4)
Signed-off-by: Caolán McNamara <caolanm@redhat.com>
Conflicts:
vcl/source/fontsubset/sft.cxx

Change-Id: I51d4a97f1f01be49cb5ab058019cd153e23437bd
(cherry picked from commit 6489f97fc428446c53c17f885963776cdcc21490)
Signed-off-by: Caolán McNamara <caolanm@redhat.com>

fdo#69384 fix impress -> writer copy&paste

Regression from 2ade07126971b79c92f729fae5709f2e2e2b495c (fdo#62044 RTF
import: don't overwrite existing styles when pasting, 2013-06-04),
during paste, if existing style was found, then the intention was to
skip that style, but instead we tried to create one.

(cherry picked from commit 5ebe826caf75e8d00656b3333385bf0bbc05cb27)

Conflicts:
writerfilter/source/dmapper/StyleSheetTable.cxx

Change-Id: I83adaf9fe6b8a578fa60c21b9463fabde7707d7e
Reviewed-on: https://gerrit.libreoffice.org/6126
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Initial fix for fdo#69915

Change-Id: Id673eb7a55aefb35ff8ab612f926bfd115129ab4
Reviewed-on: https://gerrit.libreoffice.org/6132
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

compare against IDF_HARDATTR, fdo#69720

regression from e851ea0ed30e9bb95c273a29aeab7f48f606145f

Change-Id: I07819f90efe87fe9d82515d637960fe48ca40c80
(cherry picked from commit 6f2957969bd72308ddf79cb2befa2373f2dc1dbe)
Reviewed-on: https://gerrit.libreoffice.org/6034
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

allow to build for Windows XP when using Visual Studio 2012

VS 2012 Update 1 added the possibility to target Windows XP by using a
SDK that is based on the Windows 7 one.
http://blogs.msdn.com/b/vcblog/archive/2012/10/08/10357555.aspx

This patch probably should not be integrated as is, as it disables a
test that fails in this configuration (CppunitTest_connectivity_ado)

Change-Id: I3ba8723882452950c40049ccdc95b04c60862cbf
Reviewed-on: https://gerrit.libreoffice.org/4966
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-on: https://gerrit.libreoffice.org/6125
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

configure.ac: always search for md5sum

Since edf8db717f49199833de9fc9d2c9817bab613795, the MD5SUM env variable
is used by solenv/bin/modules/{installer.pm,installer/systemactions.pm}
like this:
echo $languagestring | $ENV{'MD5SUM'} | sed -e "s/ .*//g"

Because the MD5SUM check is behind "$enable_fetch_external" != "no",
this causes an error with  --disable-fetch external:
sh: -c: line 0: syntax error near unexpected token `|'

Move it out of the enable_fetch_external check.

Change-Id: Ib0a9694226deed3957868c17fe4d982f38fd84b1
Reviewed-on: https://gerrit.libreoffice.org/6128
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Media/LastSequence is i4, so it has to be 32767->65535 in _Validation table

Change-Id: Icfcd8c70da350e5b431d6ac802a34b35adf8035b
Reviewed-on: https://gerrit.libreoffice.org/6108
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

fdo#58144 - disable the ARP 'Remove' button on Windows XP

Windows installer on Windows XP cannot display messages, when the
installer database is encoded in UTF-8 and support for CTL languages
is not installed. This patch is a workaround, it disables the 'Remove'
button in Control Panel's Add or Remove Programs applet, so the user
has to choose 'Change', and has to uninstall LibreOffice with the
Wizard, which does not exhibit the problem.

Initially this bug was not expected, when we changed the enconding
from legacy codepages to UTF-8 - I would say irreversibly.
Then the severity of the bug was underestimated, because usually
uninstallation needs no user interaction, so it does not matter,
if the text is unreadable. However, in some circumstances
uninstallation needs to reboot the computer, and the user needs
to understand the question, whether to reboot now or later.

Change-Id: I7d6b4e82cbe4142d23c29313e43a90fa43944b2f
Reviewed-on: https://gerrit.libreoffice.org/6109
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

CID#705749 mem leak

Change-Id: I8626e60d802b1c966667867d8c59ececff0a4255
(cherry picked from commit e17c91d1ff5c39b9b541b4d1bfb291c419fc76b5)
Reviewed-on: https://gerrit.libreoffice.org/6118
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

rhbz#1001768: AtkListener::disposing(): delay notification

Frame #10 in libatk-bridge.so calls atk_misc_threads_enter(),
and having a look at the RHEL 6.5 at-spi package in
./at-spi-1.28.1/atk-bridge/bridge.c there is always the same call
pattern:

  bridge_threads_leave ();
  [one function call]
  bridge_threads_enter ();

... so the bridge_threads_leave() has called the VCL gtk-plug function
GtkHookedYieldMutex::ThreadsLeave() which releases the SolarMutex.

This is of course not a good idea while there is a Window being deleted,
and is the reason why the same Window is being deleted in thread 1 and
thread 2:

31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30,
__in_chrg=<value optimized out>) at
/usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272

16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30,
__in_chrg=<value optimized out>) at
/usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272

Try to avoid the problem by delaying the
atk_object_notify_state_change() that will release SolarMutex until idle,
when deletion of the Window is finished.

Thread 2 (Thread 0xfff4cbcf110 (LWP 17011)):
2  0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6
3  0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114
4  0x00000fff963a7908 in acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:58
5  ClearableGuard (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:177
6  cppu::WeakAggComponentImplHelperBase::dispose (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:392
7  0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114
8  0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326
9  0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612
10 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136
11 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121
12 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123
13 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66
14 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272
15 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255
16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272
17 0x00000fff94a61138 in Window::~Window (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4683
18 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56
19 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957
20 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff70115a80) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263
21 0x00000fff94a60130 in Window::~Window (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334
22 0x00000fff949cc8b4 in DockingAreaWindow::~DockingAreaWindow (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96
23 0x00000fff949cc918 in DockingAreaWindow::~DockingAreaWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96
24 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56
25 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957
26 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff7001a320) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263
27 0x00000fff94a60130 in Window::~Window (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334
28 0x00000fff94a1f7fc in SystemWindow::~SystemWindow (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/syswin.cxx:89
29 0x00000fff94a6c744 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150
30 0x00000fff94a6c7e8 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150
31 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56
32 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957
33 0x00000fff88258ec0 in framework::Frame::impl_disposeContainerWindow (this=<value optimized out>, xWindow=...) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:2689
34 0x00000fff8826d71c in framework::Frame::dispose (this=0xfff8c308a08) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1887
35 0x00000fff88263018 in framework::Frame::close (this=0xfff8c308a08, bDeliverOwnerShip=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1650
36 0x00000fff88255908 in framework::Desktop::impl_closeFrames (this=<value optimized out>, bAllowUI=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:1928
37 0x00000fff88256120 in framework::Desktop::terminate (this=0xfff8b3de388) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:292

Thread 1 (Thread 0xfff930e82a0 (LWP 16956)):
2  0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6
3  0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114
4  0x00000fff946cd114 in vcl::SolarMutexObject::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/solarmutex.cxx:35
5  0x00000fff94a6ecb8 in SalYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/generic/app/geninst.cxx:49
6  0x00000fff8c24cb90 in GtkHookedYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:91
7  0x00000fff8c24cd2c in GtkHookedYieldMutex::ThreadsEnter (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:64
8  0x00000fff8b6dfabc in ?? () from /usr/lib64/gtk-2.0/modules/libgail.so
9  0x00000fff8b9f333c in .atk_misc_threads_enter () from /usr/lib64/libatk-1.0.so.0
10 0x00000fff8c1d534c in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so
11 0x00000fff8c1d65fc in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so
12 0x00000fff936af4e0 in ?? () from /lib64/libgobject-2.0.so.0
13 0x00000fff936b13d0 in .g_signal_emit_valist () from /lib64/libgobject-2.0.so.0
14 0x00000fff936b18f8 in .g_signal_emit () from /lib64/libgobject-2.0.so.0
15 0x00000fff8b9e5f3c in .atk_object_notify_state_change () from /usr/lib64/libatk-1.0.so.0
16 0x00000fff8c23083c in AtkListener::disposing (this=0xfff5f98dbc8) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/a11y/atklistener.cxx:81
17 0x00000fff963aee2c in cppu::OInterfaceContainerHelper::disposeAndClear (this=<value optimized out>, rEvt=...) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/interfacecontainer.cxx:316
18 0x00000fff9659d944 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=<value optimized out>, _rxEventSource=...) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessibleeventnotifier.cxx:162
19 0x00000fff9659b20c in comphelper::OAccessibleContextHelper::disposing (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessiblecontexthelper.cxx:130
20 0x00000fff5f275898 in VCLXAccessibleToolBoxItem::disposing (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolboxitem.cxx:265
21 0x00000fff963a79fc in cppu::WeakAggComponentImplHelperBase::dispose (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:404
22 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114
23 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326
24 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612
25 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136
26 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121
27 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123
28 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66
29 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272
30 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255
31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272
32 0x00000fff949d41c4 in DockingWindow::~DockingWindow (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockwin.cxx:473
33 0x00000fff94a35944 in ToolBox::~ToolBox (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/toolbox.cxx:1698
34 0x00000fff88343e40 in framework::ToolBar::~ToolBar (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35
35 0x00000fff88343e88 in framework::ToolBar::~ToolBar (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35
36 0x00000fff94a66a00 in ~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:162
37 vcl::LazyDeletor<Window>::~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:164
38 0x00000fff94998868 in vcl::LazyDelete::flush () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/helper/lazydelete.cxx:54
39 0x00000fff946d2294 in ImplYield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:434
40 Application::Yield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:463
41 0x00000fff946d22f8 in Application::Execute () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:408

Change-Id: Ic742442dd6ffeba59655c2e66df8dbabc906f061
(cherry picked from commit c3ef735fd5d8866c8ce28b89744150e733087427)
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Updated core
Project: dictionaries  307cb4cdf237ee21d4a90e9059a347b524b13f69

Resolves: rhbz#1013844 fdo#47482 encrypted OOo 1.0 docs cannot be reopened

Workaround for the encrypted OpenOffice.org 1.0 documents generated by
Libreoffice <= 3.6 with the new encryption format and using SHA256, but missing
a specified startkey of SHA256

Change-Id: Ib1acc4441b5adc6721cb3cde7a1191aa978e9a1b
(cherry picked from commit 11ad93f4ba84f190c908e92a2c960f7a9fa800c0)
Reviewed-on: https://gerrit.libreoffice.org/6105
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

rhbz#1014010: Missing dependencies in isBootstrapType list

...the list has been fixed now by copying its elements into an ENTRIES file and
running "unoidl-write udkapi/ @ENTITIES TEMP && unoidl-read TEMP >/dev/null" and
adding any reported unknown entities until it succeeds.

However, the updated list lead to deadlock when css.reflection.ParamInfo UnoType
resolves css.reflection.XIdlClass UnoType resolves css.reflection.XIdlMethod
UnoType resolves css.reflection.ParamInfo UnoType, so broke the circle by no
longer resolving the interface methods' return and parameter types in
InterfaceType::dumpMethodsCppuDecl (which is why those type infos are only
generated on demand anyway; looks like this had been a careless thinko in the
generation of comprehensive type info that had remained unnoticed all the time).

Change-Id: I50ef2fde16242298e055c6fa5971e70fad1a2b68
(cherry picked from commit 254f59f623f58c320175a06a2c93bcee7868b623)
Reviewed-on: https://gerrit.libreoffice.org/6099
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

All the content of cppuhelper/source/compat.cxx must be in namespace cppu

Change-Id: I30dde10d1c299dbd9c0b2cb2fa025ce432df6cce
(cherry picked from commit 69f1846f4095a9dc607a0e568980d8625d657c94)
Reviewed-on: https://gerrit.libreoffice.org/6097
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

fdo#66743 fix import of some RTF_CLSHDNG values

This should be in sync with model.xml, got broken when the somewhat
random values got fixed to be the same as the ones which are in the ww8
spec.

(Regression from 26d40686128e70916a636e20f5ccc5763bbb6cc8.)

(cherry picked from commit 21e07d473d1ce995ca0f1d0ac0edb03e75a7dfc1)

Conflicts:
sw/qa/extras/rtfexport/rtfexport.cxx

Change-Id: Id62047e0b2d5d8402a7c8bce95de487afe627e32
Reviewed-on: https://gerrit.libreoffice.org/6091
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Sign .msi/.msp files when build signing is enabled on Windows

Change-Id: I927d78ae898596e6425b086f4d50fc4e1b9361c1
Reviewed-on: https://gerrit.libreoffice.org/5987
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.

Change-Id: Ib971824a7f274334012b872acec65310535ad767
Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Uploading libmwaw 0.1.11

Change-Id: Idf9589e13eaf143c854a9c98e2d773d8a28bd43f
Reviewed-on: https://gerrit.libreoffice.org/6033
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

fdo#54686 Treat hard blank as soft blank in number

AutoCorrect option "Add non-breaking space in French..." insert
non-breaking space (hard blank) and avoid recognition of percent
number and time number. This patch treats hard blanks as soft blank
in number format recognition

Rev.#1: change #define to const variable. Same change in svxaccor
Rev.#2: improvements

Reviewed-on: https://gerrit.libreoffice.org/6015
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 2f4d7eacabd62db35777682bcca353e142e024bf)

Signed-off-by: Eike Rathke <erack@redhat.com>
Conflicts:
editeng/source/misc/svxacorr.cxx
svl/source/numbers/zforfind.cxx

Change-Id: I30c2c36778cb53a0238a0829043dad4d709f97d2

Resolves: fdo#69220 crash in doc (ww6)

Change-Id: I5a09d121a0b0342f28ba5d2d39027b27e9c9eba2
(cherry picked from commit 2e93541d00f9d4aaa6ad2aeb35ee0c901d216cc0)
Reviewed-on: https://gerrit.libreoffice.org/5989
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: fdo#68431 style:font-name unknown in non autostyles in impress/draw

Reviewed-on: https://gerrit.libreoffice.org/5810
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d87cb77b42b591b1333aacd60e107514d6e20864)

Conflicts:
xmloff/source/style/xmlexppr.cxx

Change-Id: Ib904af4fac5659821ba3b5dbbf62370df8243001
Reviewed-on: https://gerrit.libreoffice.org/5988
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#41833: fix visual cursor position after resizing

SetOutputArea updates a cursor position, SetVisArea doesn't => call SetOutputArea
after SetVisArea.

Change-Id: Ie8f079cb3d567f759c84587a8072b98fab43588b
(cherry picked from commit ddbcb6687722314b37cfda3170596ac7a4f69602)
Reviewed-on: https://gerrit.libreoffice.org/5977
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

valgrind: init. member variables

Change-Id: I7e0d99f549841d466d5dfb69cde74b424ae98b0b
(cherry picked from commit 38797f7f4129e1e09be9308a36311cf2f1afef79)
(cherry picked from commit 86128f3b24a830df87db4ed2f7176d84ede7230f)
Reviewed-on: https://gerrit.libreoffice.org/5994
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Avoid crash when a comment contains data, but no text

calling back() on empty vector results in undef behaviour

Crash originally reported here:
http://lists.freedesktop.org/archives/libreoffice/2013-September/055827.html

Change-Id: Ibefdc7e2495fc31d748c16fedd3cee5eb957bfa2
(cherry picked from commit 3750deae3e2d8fcf8bcf795fe327e1da370a2c4d)
Reviewed-on: https://gerrit.libreoffice.org/5974
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Resolves: fdo#69440 only ask for tabcontrol in builder dialogs

(cherry picked from commit d4edce3b72d585915516a0a27c4815a0d4996cfb)

Change-Id: I6001f8921f3b90283525355b0094c4377c42c663
Reviewed-on: https://gerrit.libreoffice.org/5992
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

fdo#40100 make function YEARFRAC comply with ODF Version 1.2

example of wrong result:
 =YEARFRAC(DATE(2023;1;1);DATE(2024;1;1);1)
Pretty much by definition, this should be exactly 1,
but it currently returns slightly less.

Change-Id: I5ebb2ecde49dfca8a6191d2a7c11b9581669f455
Reviewed-on: https://gerrit.libreoffice.org/5980
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

fdo#64455 Handle unknown color in color line

Change-Id: Ice4205056cc64ae50bd3c8136aeae6f648adbd0b
Signed-off-by: Ivan Timofeev <timofeev.i.s@gmail.com>

Updated core
Project: help  d78c3cb249a11ea45542d340754e960d47a35fa6

documentation for new UNO Date/Time/DateTime struct <-> Basic Time conversions

Change-Id: I8679534affa1ac5ee22393189188ff1ac09aa0f5
Reviewed-on: https://gerrit.libreoffice.org/5945
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix fdo#69381 by skipping empty option groups

Change-Id: Idaf0f0a3f5430a5aea6f77a003e205116a87cc67
Reviewed-on: https://gerrit.libreoffice.org/5949
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/5972

Resolves: fdo#67697 source formatting option list in autocorrect

regression from 0513e10635c85fc1aa214948de4992d4b76d555c
"fdo#49350 Speedup "OK" action of auto-correct dialog"

Change-Id: Iede6063729433beb3ac50dbdb45230c1d774cea0
(cherry picked from commit 95e566b9a0df06d130e118181058273f034bcf2c)
Reviewed-on: https://gerrit.libreoffice.org/5956
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Resolves: fdo#67730 Preview colors on Smart Tags & Shadows are swapped

Change-Id: I63916283c67b9acd79df96a48485dba6b25cf8cb
(cherry picked from commit 342b1895d768dc633c3067df6618cd3567b72a6d)

Related: fdo#67730 automatic turns the preview a blue color

Change-Id: I31c9129472ab64bfda283bb766fad949acb96754
(cherry picked from commit e2fc3ae88dafd13215019532845db76d726f151d)

Related: fdo#67730 label overlaps listbox and steals its click

Change-Id: I9b803bb966916210495025e3811732224585c213
(cherry picked from commit d6e9bb17675200e12777ed23d0c685fbd2bb4c59)
Reviewed-on: https://gerrit.libreoffice.org/5955
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#69091: Copying data from Base-table to Calc by drag and drop

Depending on whether the data source is registered, either
rDescriptor[svx::daDataSource]
or
rDescriptor[svx::daDatabaseLocation]
will be filled in (and should be used).

Luckily, ODataAccessDescriptor provides a utility
function that will automatically return the one
that is set. Use that instead of hardcoding svx::daDataSource.

Thank you Lionel!

Change-Id: I02673e7924c4323915dea579015326194c3f5077
Reviewed-on: https://gerrit.libreoffice.org/5959
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

fdo#68874: Highlighter icon doesn't change color if no text is selected

the problem is that bChoiceFromPalette becomes false too early when StateChanged
is called with nSID=SID_ATTR_CHAR_COLOR_BACKGROUND_EXT (we don't handle it in the
switch) and the following call with nSID=SID_ATTR_CHAR_COLOR_BACKGROUND (which
we actually want to handle) is no-op.

Change-Id: I024f6a443535411648bda44576e838c3d863e7de
(cherry picked from commit 1d0e18703523139e5fd6d11b6f3d72bb0b368036)
Reviewed-on: https://gerrit.libreoffice.org/5942
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fix for fdo#69173 crasher

the layout changes for the basic IDE ( for the object browser and object
catalog ) seem flacky, I have seen since those changes have been introduced
some strange ( but random ) behaviour ( like the odd unrepeatable core ( maybe
related to this ) and also sometimes Modules appearing in the tree under the
wrong nodes etc. I'm no expert in the basic IDE code but this patch seems to
fix the problem.
However there is one drawback, in the core inducing scenario the tree view
( object catalog ) dissappears, this is because the patch suppresses the
problematic layout in this case ( as the layout seem not to be currently able
to deal with 'no-existent' (recently) deleted current window )
Probably in this scenario a fallback currentwin (instead of nil) could be set
this would behave better but ideally. Ultimately the layout class should
probably be modified ( possibly redesigned )

Change-Id: I9d1e23bd6fc4aae32aa78da8278c318f7051136a

fdo#69147 report sort columns are RESULT columns

as opposed to table columns or other expressions.
So it makes no sense to slap a table name on them.
Notwithstanding HSQLDB 1.8 (our embedded database) bugs.

Change-Id: Ib5d0b1479e29b9efeafca9ebc2eb7ed8e0f42b79
Reviewed-on: https://gerrit.libreoffice.org/5931
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Resolves: fdo#34987 skip autoheight reset if it will be set to the same value

Triggered by aa9af08b389a106fcfb53842ac7669b208a27205 which explicitly sets
rSet.Put( SdrTextAutoGrowHeightItem(FALSE) ); so there is something set on the
style which is being overwritten.

The code here resets the style to the default of "true" before going on to set
it to the explicit "false" again. In that window of time the master shapes
listen to the property change, on being set to autoheight they resize and on
being unset, they remain stuck on their autoheight calculated size.

Reviewed-on: https://gerrit.libreoffice.org/5887
Reviewed-by: mhofmann <borim7@web.de>
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
(cherry picked from commit 14e7a290dab7fead66ef6ff7f94c6a425d80ceb6)

Conflicts:
xmloff/source/draw/ximpstyl.cxx

Change-Id: I567a791b2bbbcb3a1a111633fabf509142984645
Reviewed-on: https://gerrit.libreoffice.org/5929
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

Easier conversion between Basic Date and UNO Date/Time

Utility functions to convert between Basic Date type
and the representations of Date and Time in UNO, namely:
 - com.sun.star.util.Date
 - com.sun.star.util.Time
 - com.sun.star.util.DateTime

Name of new functions:
 - CDateToUnoDate
 - CDateFromUnoDate
 - CDateToUnoTime
 - CDateFromUnoTime
 - CDateToUnoDateTime
 - CDateFromUnoDateTime

Change-Id: I2b971df20df1c0351d071023e042169b548894f1
Reviewed-on: https://gerrit.libreoffice.org/5897
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
Reviewed-on: https://gerrit.libreoffice.org/5919

Resolves: rhbz#1006850 crash in SwCommentRuler::GetCommentControlRegion

Change-Id: Ic846da3b22391d724da6f8df94dd771e89d2efb4
(cherry picked from commit b73dec8a06ef762098e642b2c37e4baad780b11a)
Reviewed-on: https://gerrit.libreoffice.org/5924
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

CID#736212 clip word 2 pap bounds

and add a unit test for the word 2..5 formats

Change-Id: I6c7c26be6092acbb81282080de6c393d92ad5dd4
(cherry picked from commit 5d8a9d56de7c1217cfdbe2288c1a3a9128c3dbb5)
Reviewed-on: https://gerrit.libreoffice.org/5908
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

#i123198# catch and ignore uno exceptions in sfx2::sidebar::TabBar::Item::HandleClick()

Patch by: Herbert Duerr
Scenario found by: Thorsten Wagner

(cherry picked from commit 1a078f3584e8a288c0ec33f176638406423ade63)
(cherry picked from commit fe2a249257a9fb4a994514bce5f49268f7bfd770)

CID#1078757 nOfs <= nPersistPtrAnz

Change-Id: Icf2729a4a7f8476d71d4609e060d3da2d172e7a8
(cherry picked from commit a46fade2c1c7ea29ff7553d5d10afbf813839af1)
Reviewed-on: https://gerrit.libreoffice.org/5891
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

CID#1079180 initialize buffer

Change-Id: Id00bce6fe4826293f6b0ae842bc70b536e9aa99a
(cherry picked from commit c119ec426b2a20b79d3ecaccaa91d15bc8d43a23)
Reviewed-on: https://gerrit.libreoffice.org/5892
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

CID#1079181 initialize buffer

Change-Id: I516aedd445c8fcd4cefed1ed23d5bf8157b200a6
Reviewed-on: https://gerrit.libreoffice.org/5889
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 21efe9ed56372dee93258fdbfd1bc88a0fd45760)
Reviewed-on: https://gerrit.libreoffice.org/5890
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

fdo#68291 RTF paste: don't set PageDescName during paste

In general, paste should not deal with page styles. In this case, it
even caused an additional page break.

(cherry picked from commit b226dcb50d6728b62f39c9fa2e016724324944e3)

Change-Id: Ia7c5a9ad844821b6622babfbd94469ec3c04cf0a
Reviewed-on: https://gerrit.libreoffice.org/5883
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#779642 VML import: groupshape-related fixes

1) fix TextHorizontalAdjust when layout-flow is vertical

The shape had no special properties about hori/vert text adjustment, so
it should be hori left / vert top. Then it has vertical layout-flow, so
vert should be top and hori should be right (vert was center).

2) import result of sdt fields

We can't have e.g. placeholder fields on drawinglayer rectangles, but at
least the result of the field is now imported.

3) handle drawinglayer rectangle inset

4) handle drawinglayer rectangle char spacing

(cherry picked from commits b10afb26296e33c77e94a6eda3f2c36c4d34c2aa,
3847de4b724f4f435bb68bceef9a5e187c3f363c,
870a2394a87c77740daf41e1aa81b130113f8e00 and
4cbc41bc4eaa822829e68c1ee11eafe834bb7da7)

Change-Id: I79fa72c9235682030d23a03fdb0c7c40370c4a8a
Reviewed-on: https://gerrit.libreoffice.org/5847
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#65330 fix meta.xml of AbstractYellow.otp

title was Abstract Green instead of Abstract Yellow

Change-Id: I80344940d96163809b889482334f02bb4f7a124f
Reviewed-on: https://gerrit.libreoffice.org/5872
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fix validity dialog with lists, fdo#65686

regression from b0cf3aba085373d84a55ef144b273a8a89d017af

Change-Id: Ia3d39e02f35f3e23d93c7fe771bdbeb6eb3d2caf
Reviewed-on: https://gerrit.libreoffice.org/5856
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fdo#69041 LibreLogo: fix SVG/SMIL timing with filled polylines

Change-Id: Icebd47d57a830986c371a62ec7dab81ca8fd930a
Reviewed-on: https://gerrit.libreoffice.org/5845
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

n#779642: 0 width or height in //v:shape[@style] produces weird results

(cherry picked from commit 3d5fb88cc0aa8ee6be6cec5ce0255f1412368519)

Change-Id: I37ba59dd54ac692f234f3228e442799c5a5f450b
Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#68313 fix combining diacritics problem with Graphite fonts

Change-Id: Ied29f864dc5fc21fc55aaa5ddd40b02b53a564f8

Resolves: fdo#68081 why would I want a spinner that doesn't repeat

surely WB_SPIN should imply repeat in the first place, *shrug*

Change-Id: I1e4cb5a01d473cd0f8d907d566cd26d51a81da93
(cherry picked from commit f96771165ea145a759f1bab76cd34bb70def04f6)
Reviewed-on: https://gerrit.libreoffice.org/5839
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

fdo#68607 bnc#816593 DomainMapperTableHandler: don't always start a frame

This is a port of commit 8fe8bd6c3b5b1a539b7370f8c457fa69c061d2de
"Related: fdo#61594 SwWW8ImplReader::StartApo: don't always start a
frame" from the WW8 filter to the DOCX one.

(regression from edc4861a68e0269b83b17e0ec57912a1ce4220ad)

(cherry picked from commit 78d1f1c2835b9fae0f91ed771fc1d594c7817502)

Change-Id: If1bb4a8a3786aacd618585cf859b57ce9be85c51
Reviewed-on: https://gerrit.libreoffice.org/5788
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#816593 DOCX import: ignore page breaks in tables

(cherry picked from commit 7d3778e0ef9f54f3c8988f1b84d58e7002d6c625)

Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx

Change-Id: Ibb250148d41d1929fa17dd993bb71c93c0e09dcf
Reviewed-on: https://gerrit.libreoffice.org/5787
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#816593 DOCX filter: import paragraph spacing from table style

(cherry picked from commit 17e904ed66c3caf87e658b9d3a18d7b13f4a0b52)

Change-Id: I9dce59ecd8a2d2bfadb8c7273cd46c6c0cf17774
Reviewed-on: https://gerrit.libreoffice.org/5786
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#816593 DOCX import: fix auto table width wrt nested tables

This is a backport of the fix + 3 other commits from master, which were
needed to make the testcase pass on -4-1 as well.

(cherry picked from commits 74c5ed19f430327988194cdcd6bdff09591a93fa,
824cc4bf4ae9035d4108e8da8e81eb57284f0b54,
53d27a30ce5f2c9f7d37a4089286116854c16215 and
76d1ca523ddcf89cc269fe51c70e66066943ef5a)

Change-Id: I62a1f526cf1d4e4056daa1495d61f1b9f5c0b1b2
Reviewed-on: https://gerrit.libreoffice.org/5785
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#816593 DOCX import: let w:before not overwrite w:beforeAutospacing

And do the same for w:after / w:afterAutospacing. The spec says that if
w:beforeAutospacing is read, w:before should be ignored, this implies
that if we already had w:beforeAutospacing, w:before should not
overwrite the already existing top margin.

(cherry picked from commit de516780bf2d5f74afe643033bfc528c53013902)

Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx

Change-Id: I9437cb5c6fc352a360e27aa279d0a789706c5578
Reviewed-on: https://gerrit.libreoffice.org/5784
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

bnc#816593 DOCX import: fix auto para spacing without compat option

Paragraph auto spacing (before and after) without the
w:doNotUseHTMLParagraphAutoSpacing compat option was incorrect.

(cherry picked from commit 279ff2e03371542d014bf281e73282ba8080cf6b)

Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx

Change-Id: I56d6153f7c489de7fceaf6fab7325c42ee8f9cae
Reviewed-on: https://gerrit.libreoffice.org/5783
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fix misspelled text with VoiceOver on 10.9

More in Apple's docs (Application Kit Release Notes for OS X v10.9,
section "New Accessibility constants").

Change-Id: I92fb6d552e86997bfc789723f32626d908d11419
Reviewed-on: https://gerrit.libreoffice.org/5833
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

tests that ensure the master to be broken arent that helpful

Change-Id: Ie59f2ba4daec0375d1d64b765be3b1484e8cba3e
Reviewed-on: https://gerrit.libreoffice.org/5830
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

fdo#68210: Make tiff import work again with merged-libs

- there was a symbol mismatch for dynamic loading
- while this fixes fdo#68210, similar fixes are likely needed for the other
  dynamically loaded functionality
- this also includes Change-Id: I6041ca10f58335187928995368db673c1ce22e7b

Change-Id: I7e4d6baf256dbe7b145dcbc118b4cac2075e07f5
Reviewed-on: https://gerrit.libreoffice.org/5811
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Consistently use rtl_getAppCommandArg here

...2a9c1d1a75b7d4e79dfbc6be3dada1a1e959e58e "Make dialogs fail with an exception
in headless tests" missed one of the osl_getCommandArg calls, which can lead to
problems when there are any -env: arguments preceeding the --display argument.
Reported by renduly on IRC.

Change-Id: I98dd24be840d561dce51034088f3e44adff9f2ff
(cherry picked from commit 379a53017447fbf2a459f82ae8905b6683e80e8d)
Reviewed-on: https://gerrit.libreoffice.org/5821
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>