| commit | ff166845fa5ed178a97b54bb2deef4beb0cf3bdf | |
| author | Dennis Francis <dennis.francis@collabora.co.uk> | |
| Tue, 23 Jan 2018 14:23:19 +0000 (23 19:53 +0530) | ||
| committer | Dennis Francis <dennis.francis@collabora.co.uk> | |
| Wed, 24 Jan 2018 06:55:01 +0000 (24 07:55 +0100) | ||
| tree | e7e0c7fc0159a6ffac9392ebb01fdedd16248892 | treesnapshot (tar.gz zip) |
| parent | f8aca037896ce7085f0be0ab524b524bae57d38c | commitdiff |
tdf#115093 : Do not reuse singleref tokens...
...in formula group computation if the formula contains
only a single reference besides any ocOpen/ocClose pairs
wrapping it as the sole content.
In such a case the "result" formula token
returned by ScInterpreter::GetResultToken() is the same
as the original singleref token, so for each row of the
formulagroup, we need to use a separate singleref token.
Also added a unit test in sc/qa/unit/parallelism.cxx
Change-Id: I6032efc5be9b51ca1e9daf9bdd19997a949d2f43
Reviewed-on: https://gerrit.libreoffice.org/48449
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
...in formula group computation if the formula contains
only a single reference besides any ocOpen/ocClose pairs
wrapping it as the sole content.
In such a case the "result" formula token
returned by ScInterpreter::GetResultToken() is the same
as the original singleref token, so for each row of the
formulagroup, we need to use a separate singleref token.
Also added a unit test in sc/qa/unit/parallelism.cxx
Change-Id: I6032efc5be9b51ca1e9daf9bdd19997a949d2f43
Reviewed-on: https://gerrit.libreoffice.org/48449
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
| sc/qa/unit/parallelism.cxx | diffblobblamehistory | |
| sc/source/core/tool/formulagroup.cxx | diffblobblamehistory |