| commit | f020784e14a55c82418e4f231855040177ac9f82 | |
| author | Stephan Bergmann <sbergman@redhat.com> | |
| Fri, 9 Jul 2021 11:04:19 +0000 (9 13:04 +0200) | ||
| committer | Stephan Bergmann <sbergman@redhat.com> | |
| Fri, 9 Jul 2021 13:07:05 +0000 (9 15:07 +0200) | ||
| tree | a2d5c1d2b5778e564b9ee529de0453c73907ce70 | treesnapshot (tar.gz zip) |
| parent | ac7bba3cc1e13824732f5ab69af602848e4ba227 | commitdiff |
Make loplugin:stringadd slightly more aggressive
...by assuming that all const member functions are side-effect free. (This
presumably means that some of the special cases in
StringAdd::isSideEffectFree are obsoleted by this more general case, but any
such removal is postponed to later clean-up.)
(Came across this when idly wondering why
8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid
OStringBuffer style" had not been found by the plugin before.)
Change-Id: I6bca10df53885b14a590543aabd61f23b3748572
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...by assuming that all const member functions are side-effect free. (This
presumably means that some of the special cases in
StringAdd::isSideEffectFree are obsoleted by this more general case, but any
such removal is postponed to later clean-up.)
(Came across this when idly wondering why
8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid
OStringBuffer style" had not been found by the plugin before.)
Change-Id: I6bca10df53885b14a590543aabd61f23b3748572
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
12 files changed: