tdf#128895 sc xmlimport: create enough dynamic cols if props
commitea229b09c3de7edb8fcb01a727b656f4d35821d4
authorJustin Luth <justin_luth@sil.org>
Wed, 8 Dec 2021 12:22:01 +0000 (8 14:22 +0200)
committerJustin Luth <jluth@mail.com>
Sat, 11 Dec 2021 15:56:17 +0000 (11 16:56 +0100)
tree32494f4933f21a36b4a06ad029d7f1974f716e9c
parent8c752abcdfbb09c039b4b9364ca415346ee0d3b0
tdf#128895 sc xmlimport: create enough dynamic cols if props

Since LO 6.3, only 64 columns are created by default,
where previously it was a fixed 1024.

A common user practice is to hide all columns not used,
but this collapsed property was lost because
only part of the columns were actually created and thus exported.

In this example, import specifies 1017 hidden columns (H-AMJ),
but since only 64 columns are created, export only specified 57.

So ensure that on import, any column with defined properties
is created - even if they don't contain any content.

Change-Id: If928880baf5585613715a1f4361a9059584d1ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126540
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
(cherry picked from commit 297ab561c6754f89326a1e8ce1751233669578d7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126668
sc/qa/unit/data/ods/tdf128895_emptyHiddenCols.ods [new file with mode: 0644]
sc/qa/unit/subsequent_export_test.cxx
sc/source/filter/xml/xmlcoli.cxx