| commit | dd2681813d02089c71a8b0f4dc4c8e2bf63d1791 | |
| author | Justin Luth <justin.luth@collabora.com> | |
| Fri, 10 Apr 2020 17:02:20 +0000 (10 20:02 +0300) | ||
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | |
| Sat, 11 Apr 2020 08:10:45 +0000 (11 10:10 +0200) | ||
| tree | 09bc7f81bc0cebc9eb70314c3686616c36454b98 | treesnapshot (tar.gz zip) |
| parent | 822da642f1355f8ed1074737560430876d9ac932 | commitdiff |
NFC writerfilter: remove pointless asserts
In an age where GDB (or whatever other platform debugger
you prefer) is easy to use, there is no point in
asserting something that is going to crash anyway, is there?
Asserting is only good in these cases if you follow it using
an _if_ statement. Noel informed me that it can also be used
to silence false positive coverity warnings.
Change-Id: I5a5cb7a22019768ec2807f6918d4a8ebb51194de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92049
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In an age where GDB (or whatever other platform debugger
you prefer) is easy to use, there is no point in
asserting something that is going to crash anyway, is there?
Asserting is only good in these cases if you follow it using
an _if_ statement. Noel informed me that it can also be used
to silence false positive coverity warnings.
Change-Id: I5a5cb7a22019768ec2807f6918d4a8ebb51194de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92049
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| writerfilter/source/dmapper/DomainMapper_Impl.cxx | diffblobblamehistory | |
| writerfilter/source/rtftok/rtfdocumentimpl.cxx | diffblobblamehistory |