Integer division could cancel small values of wrong sign
commitc0c1145d9f7aa82417bfa8194de0a27c2c556aab
authorMike Kaganski <mike.kaganski@collabora.com>
Mon, 27 Jun 2022 12:29:25 +0000 (27 15:29 +0300)
committerXisco Fauli <xiscofauli@libreoffice.org>
Tue, 28 Jun 2022 16:18:26 +0000 (28 18:18 +0200)
tree40f65bf71074db4dcee3d45f156f33b9375173cc
parent66ae8a2c0e6d01d06a01fa877cf03507c0656f8d
Integer division could cancel small values of wrong sign

... as seen at some documents where the values are like -1. There
the checks in pushToPropMap may pass (the division result would be 0),
but the original small negative values would fail the asserts that
were introduced in commit 5772cef244dbee5834efbc693bc714d89ae6301d
  Author Mike Kaganski <mike.kaganski@collabora.com>
  Date   Wed Jun 15 18:33:38 2022 +0300
    tdf#134210: Reimplement cropping from srcRect and fillRect

Change-Id: I114588862b5cfd2b2e4491424430cc139bdbaae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136492
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2d9f3c066a065d6aa98f1e594dcf8a091fec2bde)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136471
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136556
oox/source/drawingml/fillproperties.cxx
sd/qa/unit/data/pptx/croppedTo0.pptx
sd/qa/unit/import-tests2.cxx