| commit | bb50474225f80b8aeea49f14ad66173462026a41 | |
| author | Aron Budea <aron.budea@collabora.com> | |
| Mon, 23 Jan 2017 02:47:19 +0000 (23 03:47 +0100) | ||
| committer | Aron Budea <aron.budea@collabora.com> | |
| Mon, 23 Jan 2017 17:44:19 +0000 (23 17:44 +0000) | ||
| tree | 2feb1d16bbea23d420adebbc55c524ce8afd87fc | treesnapshot (tar.gz zip) |
| parent | 30672569d5576e86ea47e92c8bcb40416ebadd7c | commitdiff |
tdf#100151: Dispose of window if DX device creation failed
Before, if the device lacked Direct3D capabilities, VclPtr
handling became compromised, and caused a crash. This was
particularly a problem in virtualized/remote desktop
connections in Windows.
Now mpWindow instance is disposed of right away if DX
device creation fails.
Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6
Reviewed-on: https://gerrit.libreoffice.org/33413
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Before, if the device lacked Direct3D capabilities, VclPtr
handling became compromised, and caused a crash. This was
particularly a problem in virtualized/remote desktop
connections in Windows.
Now mpWindow instance is disposed of right away if DX
device creation fails.
Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6
Reviewed-on: https://gerrit.libreoffice.org/33413
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
| canvas/source/directx/dx_9rm.cxx | diffblobblamehistory |