| commit | 8c717ea3854130067919658e9ec7433e0b5e2ba0 | |
| author | Stephan Bergmann <sbergman@redhat.com> | |
| Wed, 18 Aug 2021 10:35:21 +0000 (18 12:35 +0200) | ||
| committer | Stephan Bergmann <sbergman@redhat.com> | |
| Wed, 18 Aug 2021 21:01:22 +0000 (18 23:01 +0200) | ||
| tree | 0a4762830b1a398b244e7ea609b11c246f8907d0 | treesnapshot (tar.gz zip) |
| parent | 5d224d9141a07814f1e93c147de3ba03d643de34 | commitdiff |
GCC bug 96878 is fixed in upcoming GCC 12
However, restricting the workaround to GCC <= 11 then revealed that some old
versions of Clang apparently had a similar issue, causing "error: use of class
template 'OStringLiteral' requires template arguments; argument deduction not
allowed here", and thus also need the workaround. I saw the non-workaround code
fail with a build of Clang 6.0.0 and succeed with a build of Clang 7.0.0.
Change-Id: I6e4cf6c8c3a11618a578401574e5679e6b65d7f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
However, restricting the workaround to GCC <= 11 then revealed that some old
versions of Clang apparently had a similar issue, causing "error: use of class
template 'OStringLiteral' requires template arguments; argument deduction not
allowed here", and thus also need the workaround. I saw the non-workaround code
fail with a build of Clang 6.0.0 and succeed with a build of Clang 7.0.0.
Change-Id: I6e4cf6c8c3a11618a578401574e5679e6b65d7f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
| sal/qa/rtl/strings/test_ostring_concat.cxx | diffblobblamehistory | |
| sal/qa/rtl/strings/test_oustring_concat.cxx | diffblobblamehistory |