| commit | 7965bb9a1d8b29778c6eac279537952e6a9e9502 | |
| author | Justin Luth <justin.luth@collabora.com> | |
| Sat, 11 Apr 2020 11:07:02 +0000 (11 14:07 +0300) | ||
| committer | Michael Stahl <michael.stahl@cib.de> | |
| Wed, 15 Apr 2020 09:18:49 +0000 (15 11:18 +0200) | ||
| tree | 12e7cf87c409676c0b6b5f7df9d2fd506bd5a730 | treesnapshot (tar.gz zip) |
| parent | 24e1563b5db3de5abac0d4fd0f737ec319e703e8 | commitdiff |
Revert "NFC writerfilter: remove pointless asserts"
This reverts commit 708f95b87410c640f0e9e22892f4a71194631cd9.
Stephan said I have it all backwards.
Asserts are primarily "documentation", and there is no point
in asserting something if you aren't going to accept it as true,
at least not without any other qualifying remarks etc. So a
simple "assert(p)" should never be followed by "if(p)".
These asserts basically show that "yes, I'm using this pointer
without checking on purpose, and not as an oversight."
Change-Id: I7350b627a2acf027d1a6d5b33ea272050d23ce6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92059
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
This reverts commit 708f95b87410c640f0e9e22892f4a71194631cd9.
Stephan said I have it all backwards.
Asserts are primarily "documentation", and there is no point
in asserting something if you aren't going to accept it as true,
at least not without any other qualifying remarks etc. So a
simple "assert(p)" should never be followed by "if(p)".
These asserts basically show that "yes, I'm using this pointer
without checking on purpose, and not as an oversight."
Change-Id: I7350b627a2acf027d1a6d5b33ea272050d23ce6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92059
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
| writerfilter/source/dmapper/DomainMapper_Impl.cxx | diffblobblamehistory | |
| writerfilter/source/rtftok/rtfdocumentimpl.cxx | diffblobblamehistory |