tdf#133370 docx export: don't export unseen columnbreak
commit3fb424b4326cff4f810fb24977e387bdb9e5a34e
authorJustin Luth <justin.luth@collabora.com>
Mon, 25 May 2020 15:55:59 +0000 (25 18:55 +0300)
committerMiklos Vajna <vmiklos@collabora.com>
Wed, 27 May 2020 07:07:39 +0000 (27 09:07 +0200)
treea61caab7d3fa803d585c4e30610222e61bdf5aad
parent6d0eba11f7b859303759af97c6fbc417fd2c5a9f
tdf#133370 docx export: don't export unseen columnbreak

A compatibility option indicates whether a column break
is treated as a page break when there are no columns.
(Currently true only for DOCX). Don't export this column
break when compat is off, because it WILL show up as
a page-break in Word and LO when loaded.

In theory, the RTF and DOC code that converts these
into page-breaks on import could now be removed, but I
can't think of any reason why that would be of benefit.

testColumnBreak_ColumnCountIsZero in ooxmlexport4
covers the situation where docx MUST round-trip these.

Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
sw/qa/extras/ooxmlexport/data/tdf133370_columnBreak.odt [new file with mode: 0644]
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
sw/source/filter/ww8/docxexport.hxx
sw/source/filter/ww8/rtfexport.hxx
sw/source/filter/ww8/wrtww8.hxx
sw/source/filter/ww8/ww8atr.cxx