sw_redlinehide_4b: FrameMode::Existing is not idempotent
commit1b4fdcf1b13c0be54cd4c4423122580948445069
authorMichael Stahl <Michael.Stahl@cib.de>
Tue, 11 Dec 2018 13:45:01 +0000 (11 14:45 +0100)
committerMichael Stahl <Michael.Stahl@cib.de>
Tue, 18 Dec 2018 16:55:29 +0000 (18 17:55 +0100)
tree5f281fd300d4a1cd60b5784e568637dc194e0445
parent87cf3bcccf9ba72caf97b3e4c37120ab8fca305c
sw_redlinehide_4b: FrameMode::Existing is not idempotent

... so use it only once.  The problem is that the second time it will
call DelFrames() on every non-first node, which then empties the first
frame's newly created MergedPara instance.

This can be reproduced by toggling Edit->Tracked Changes->Show in
tdf99766-2.odt.

Also change some function parameters on e.g. SwTextFootnote::DelFrames()
to SwRootFrame to make it obvious that these don't actually need a
particular SwTextFrame.

Change-Id: I129be5db4a30546905c24c5e8820a5f105a33109
sw/inc/txtftn.hxx
sw/source/core/doc/DocumentRedlineManager.cxx
sw/source/core/inc/ftnfrm.hxx
sw/source/core/layout/wsfrm.cxx
sw/source/core/text/redlnitr.cxx
sw/source/core/text/txtfrm.cxx
sw/source/core/txtnode/atrftn.cxx
sw/source/core/txtnode/ndtxt.cxx
sw/source/core/undo/undel.cxx