| commit | 038c1983122ada4cfe0c85b527940a410643ace1 | |
| author | Stephan Bergmann <stephan.bergmann@allotropia.de> | |
| Fri, 19 Apr 2024 13:06:03 +0000 (19 15:06 +0200) | ||
| committer | Stephan Bergmann <stephan.bergmann@allotropia.de> | |
| Fri, 19 Apr 2024 19:38:50 +0000 (19 21:38 +0200) | ||
| tree | c6d1b5166a203301917130cd9d65827fb3d89198 | treesnapshot (tar.gz zip) |
| parent | b209d17236778b5bd2ca8f519166e75447ed9117 | commitdiff |
Embind: Clarify need for emscripten::internal::raw_destructor specializations
...which are needed at compile time (the emscripten::class_<T> ctor always
records the address of emscripten::internal::raw_destructor<T>, even in cases
where it never calls it; and raw_destructor internally calls delete, but the
dtor of the UNO interface types is protected) but not at runtime (as those UNO
interface types are only accessed through css::uno::Reference smart pointers)
Change-Id: I09e4f258f8dfc0fc53c0fe7210c7f709d86be176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166304
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
...which are needed at compile time (the emscripten::class_<T> ctor always
records the address of emscripten::internal::raw_destructor<T>, even in cases
where it never calls it; and raw_destructor internally calls delete, but the
dtor of the UNO interface types is protected) but not at runtime (as those UNO
interface types are only accessed through css::uno::Reference smart pointers)
Change-Id: I09e4f258f8dfc0fc53c0fe7210c7f709d86be176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166304
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
| static/source/embindmaker/embindmaker.cxx | diffblobblamehistory |