From 78fcdf07c193efddbe145c0c5778f6ff8c4bfb38 Mon Sep 17 00:00:00 2001 From: AJ Rossini Date: Fri, 12 Oct 2012 10:52:37 +0200 Subject: [PATCH] found some functions that could be "name-tightened". But need to ensure that the dependency structure surrounding listoflist is managed. No circ depends! Signed-off-by: AJ Rossini --- src/data/dataframe.lisp | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/data/dataframe.lisp b/src/data/dataframe.lisp index b90be94..dc90016 100644 --- a/src/data/dataframe.lisp +++ b/src/data/dataframe.lisp @@ -1,6 +1,6 @@ ;;; -*- mode: lisp -*- -;;; Time-stamp: <2012-10-09 03:21:23 tony> +;;; Time-stamp: <2012-10-12 10:48:15 tony> ;;; Creation: <2008-03-12 17:18:42 blindglobe@gmail.com> ;;; File: dataframe.lisp ;;; Author: AJ Rossini @@ -351,6 +351,17 @@ construction of proper DF-array." |# +;;; FIXME: the following two functions hurt the eyes. I think that +;;; +;;; array->listoflist :order '(:column :row) +;;; +;;; would be a better approach. But don't we already have this in the +;;; listoflist package? and more critically, we should have this as a +;;; generic, so that it would be more like +;;; +;;; dataframe->listoflist :order '(:column :row) +;;; + (defun row-order-as-list (ary) "Pull out data in row order into a list." (let ((result (list)) @@ -361,7 +372,7 @@ construction of proper DF-array." (append result (aref ary i j)))))) (defun col-order-as-list (ary) - "Pull out data in row order into a list." + "Pull out data in column order into a list." (let ((result (list)) (nrows (nth 0 (array-dimensions ary))) (ncols (nth 1 (array-dimensions ary)))) -- 2.11.4.GIT