From 48e69b31d3daf020057d93a38122dfe826af23ba Mon Sep 17 00:00:00 2001 From: neil Date: Thu, 6 Oct 2016 03:28:07 +0000 Subject: [PATCH] Improvements to comments and other minor changes. git-svn-id: https://svn.aros.org/svn/aros/trunk/AROS@52973 fb15a70f-31f2-0310-bbcc-cdcc74a49acc --- arch/arm-native/kernel/platform_bcm2708.c | 16 ++++++++-------- compiler/include/rexx/rexxcall-m68k.h | 6 +++--- compiler/include/rexx/rexxcall.h | 6 +++--- compiler/include/rexx/rxslib.h | 4 ++-- compiler/include/rexx/storage.h | 6 +++--- rom/dos/systemtaglist.c | 4 ++-- rom/storage/includes/device.h | 9 +++++++-- rom/storage/includes/unit.h | 9 +++++++-- rom/storage/includes/volume.h | 5 +++++ workbench/c/Shell/convertRedir.c | 4 ++-- workbench/libs/diskfont/diskfont_intern.h | 4 ++-- workbench/libs/rexxsyslib/createargstring.c | 11 +++++------ 12 files changed, 49 insertions(+), 35 deletions(-) diff --git a/arch/arm-native/kernel/platform_bcm2708.c b/arch/arm-native/kernel/platform_bcm2708.c index 27e79d0451..f905f5bf2b 100644 --- a/arch/arm-native/kernel/platform_bcm2708.c +++ b/arch/arm-native/kernel/platform_bcm2708.c @@ -1,5 +1,5 @@ /* - Copyright © 2015, The AROS Development Team. All rights reserved. + Copyright © 2015-2016, The AROS Development Team. All rights reserved. $Id$ */ @@ -125,12 +125,12 @@ static void bcm2708_init(APTR _kernelBase, APTR _sysBase) *((uint32_t *)(BCM2836_MAILBOX3_SET0 + (0x10 * cpu))) = (uint32_t)trampoline_dst; /* - * Try to obtain spinlock again. - * This should put this cpu to sleep since the locked was already obtained. Once the cpu startup - * is ready, it will call KrnSpinUnLock too - */ - KrnSpinLock(&startup_lock, NULL, SPINLOCK_MODE_WRITE); - KrnSpinUnLock(&startup_lock); + * Try to obtain spinlock again. + * This should put this cpu to sleep since the lock was already obtained. Once the cpu startup + * is ready, it will call KrnSpinUnLock() too + */ + KrnSpinLock(&startup_lock, NULL, SPINLOCK_MODE_WRITE); + KrnSpinUnLock(&startup_lock); } } } @@ -341,7 +341,7 @@ static void bcm2708_gputimer_handler(unsigned int timerno, void *unused1) DTIMER(bug("[Kernel:BCM2708] %s(%d)\n", __PRETTY_FUNCTION__, timerno)); - /* Aknowledge our timer interrupt */ + /* Acknowledge our timer interrupt */ *((volatile unsigned int *)(SYSTIMER_CS)) = 1 << timerno; /* Signal the Exec VBlankServer */ diff --git a/compiler/include/rexx/rexxcall-m68k.h b/compiler/include/rexx/rexxcall-m68k.h index f17001010f..69206f70e5 100644 --- a/compiler/include/rexx/rexxcall-m68k.h +++ b/compiler/include/rexx/rexxcall-m68k.h @@ -1,15 +1,15 @@ /* - Copyright © 1995-2011, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ - Desc: Macro's to make calling arexx library querying functions portable + Desc: Macros to make calling ARexx library querying functions portable Lang: English */ #ifndef AROS_REXXCALL_M68K_H #define AROS_REXXCALL_M68K_H -/* Some macro's to make ARexx portable to non-m68k platforms */ +/* Some macros to make ARexx portable to non-m68k platforms */ #define RexxCallQueryLibFunc(rexxmsg, libbase, offset, retargstringptr) \ ({ \ int _offset=abs(offset)/6; \ diff --git a/compiler/include/rexx/rexxcall.h b/compiler/include/rexx/rexxcall.h index a07b7fcc2d..e704f7a131 100644 --- a/compiler/include/rexx/rexxcall.h +++ b/compiler/include/rexx/rexxcall.h @@ -1,8 +1,8 @@ /* - Copyright © 1995-2011, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ - Desc: Macro's to make calling arexx library querying functions portable + Desc: Macros to make calling ARexx library querying functions portable Lang: English */ @@ -17,7 +17,7 @@ #else -/* Some macro's to make ARexx portable to non-m68k platforms */ +/* Some macros to make ARexx portable to non-m68k platforms */ #define RexxCallQueryLibFunc(rexxmsg, libbase, offset, retargstringptr) \ ({ \ int _offset=abs(offset)/6; \ diff --git a/compiler/include/rexx/rxslib.h b/compiler/include/rexx/rxslib.h index 312305456a..3ecc5ff90e 100644 --- a/compiler/include/rexx/rxslib.h +++ b/compiler/include/rexx/rxslib.h @@ -2,7 +2,7 @@ #define REXX_RXSLIB_H /* - Copyright © 1995-2001, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ Desc: ARexx data structures @@ -87,7 +87,7 @@ struct RxsLib #define RXSSTACK 4096 */ -/* I'm not sure about these ones but let's dissable them for now +/* I'm not sure about these ones but let's disable them for now #define CTB_SPACE 0 #define CTB_DIGIT 1 #define CTB_ALPHA 2 diff --git a/compiler/include/rexx/storage.h b/compiler/include/rexx/storage.h index d4240cc2d2..192e6120a7 100644 --- a/compiler/include/rexx/storage.h +++ b/compiler/include/rexx/storage.h @@ -2,7 +2,7 @@ #define REXX_STORAGE_H /* - Copyright © 1995-2001, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ Desc: ARexx data structures @@ -95,8 +95,8 @@ struct RexxArg { LONG ra_Size; UWORD ra_Length; - UBYTE ra_Depricated1; /* Was ra_Flags but not used anymore */ - UBYTE ra_Depricated2; /* Was ra_Hash but not used anymore */ + UBYTE ra_Deprecated1; /* Was ra_Flags but not used anymore */ + UBYTE ra_Deprecated2; /* Was ra_Hash but not used anymore */ BYTE ra_Buff[8]; }; diff --git a/rom/dos/systemtaglist.c b/rom/dos/systemtaglist.c index 130cc37848..fe9d4dbb88 100644 --- a/rom/dos/systemtaglist.c +++ b/rom/dos/systemtaglist.c @@ -1,5 +1,5 @@ /* - Copyright © 1995-2014, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ Desc: @@ -341,7 +341,7 @@ struct Process *cliproc; /* Note: SystemTagList + CliInitNewcli/CliInitRun + AROS_CLI macro manage - * the creation and destruction of pr_CIS/pr_COS/pr_CES. CrateNewProc + * the creation and destruction of pr_CIS/pr_COS/pr_CES. CreateNewProc * logic is not used in such case. */ struct TagItem proctags[] = diff --git a/rom/storage/includes/device.h b/rom/storage/includes/device.h index 2ff71728e9..a6966e6001 100644 --- a/rom/storage/includes/device.h +++ b/rom/storage/includes/device.h @@ -2,8 +2,13 @@ #define _STORAGE_DEVICE_H /* - Definitions relating to storage devices (i.e controllers) - */ + Copyright © 1995-2016, The AROS Development Team. All rights reserved. + $Id$ +*/ + +/* + Definitions relating to storage devices (i.e. controllers) +*/ struct StorageDevice { diff --git a/rom/storage/includes/unit.h b/rom/storage/includes/unit.h index da463a1eff..58e026f175 100644 --- a/rom/storage/includes/unit.h +++ b/rom/storage/includes/unit.h @@ -2,8 +2,13 @@ #define _STORAGE_UNIT_H /* - Definitions relating to storage units (i.e drives) - */ + Copyright © 1995-2016, The AROS Development Team. All rights reserved. + $Id$ +*/ + +/* + Definitions relating to storage units (i.e. drives) +*/ struct StorageUnit { diff --git a/rom/storage/includes/volume.h b/rom/storage/includes/volume.h index df23c50960..3444df2054 100644 --- a/rom/storage/includes/volume.h +++ b/rom/storage/includes/volume.h @@ -1,6 +1,11 @@ #if !defined(_STORAGE_VOLUME_H) #define _STORAGE_VOLUME_H +/* + Copyright © 1995-2016, The AROS Development Team. All rights reserved. + $Id$ +*/ + struct StorageVolume { struct Node sv_Node; // ln_Name points to the IDNode; diff --git a/workbench/c/Shell/convertRedir.c b/workbench/c/Shell/convertRedir.c index 3b5d019a0b..5f0d15d843 100644 --- a/workbench/c/Shell/convertRedir.c +++ b/workbench/c/Shell/convertRedir.c @@ -1,5 +1,5 @@ /* - Copyright (C) 1995-2011, The AROS Development Team. All rights reserved. + Copyright (C) 1995-2016, The AROS Development Team. All rights reserved. $Id$ */ @@ -26,7 +26,7 @@ LONG convertRedir(ShellState *ss, Buffer *in, Buffer *out) if (*s == '>') { - if (ss->newOut) /* multiple > not allowed */ + if (ss->newOut) /* multiple > or >> not allowed */ return ERROR_TOO_MANY_LEVELS; if (*++s == '>') diff --git a/workbench/libs/diskfont/diskfont_intern.h b/workbench/libs/diskfont/diskfont_intern.h index 3dba9461f0..5041ac0e03 100644 --- a/workbench/libs/diskfont/diskfont_intern.h +++ b/workbench/libs/diskfont/diskfont_intern.h @@ -1,5 +1,5 @@ /* - Copyright © 1995-2011, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ */ @@ -112,7 +112,7 @@ struct AADiskFontHeader /* Prototypes */ /**************/ -struct DiskfontBase; /* prerefrence */ +struct DiskfontBase; /* prereference */ /* memoryfontfunc.c */ diff --git a/workbench/libs/rexxsyslib/createargstring.c b/workbench/libs/rexxsyslib/createargstring.c index 77b4ea7ceb..350804d076 100644 --- a/workbench/libs/rexxsyslib/createargstring.c +++ b/workbench/libs/rexxsyslib/createargstring.c @@ -1,5 +1,5 @@ /* - Copyright © 1995-2002, The AROS Development Team. All rights reserved. + Copyright © 1995-2016, The AROS Development Team. All rights reserved. $Id$ Desc: @@ -31,8 +31,7 @@ length - Length of the string to copy. RESULT - Will return a pointer the string part of the allocated RexxArg - structure. + A pointer to the string part of the allocated RexxArg structure. NOTES Pointer to the string returned by this function may be used as a @@ -63,11 +62,11 @@ ra->ra_Size = size; ra->ra_Length = length; /* FIXME: Maybe the next two fields only need to be intialized on m68k? */ - /* Initialize the depricated fields to a sane value for compatibility under AmigaOS */ - ra->ra_Depricated1 = 1<<1 | 1<<2 | 1<<6; /* Was ra_Flags = NSF_ALPHA | NSF_EXT */ + /* Initialize the deprecated fields to a sane value for compatibility under AmigaOS */ + ra->ra_Deprecated1 = 1<<1 | 1<<2 | 1<<6; /* Was ra_Flags = NSF_ALPHA | NSF_EXT */ for (i=0; ira_Depricated2 = (UBYTE)(hash & 255); /* Was ra_Hash */ + ra->ra_Deprecated2 = (UBYTE)(hash & 255); /* Was ra_Hash */ CopyMem(string, ra->ra_Buff, length); *(ra->ra_Buff + length) = '\0'; -- 2.11.4.GIT