Cleanup most createArea and some createObjectGroup calls in random map scripts.
commitc23058b0d164b15596166ae11b6e4ea59564be16
authorelexis <elexis@3db68df2-c116-0410-a063-a993310a9797>
Sun, 15 Oct 2017 17:53:12 +0000 (15 17:53 +0000)
committerelexis <elexis@3db68df2-c116-0410-a063-a993310a9797>
Sun, 15 Oct 2017 17:53:12 +0000 (15 17:53 +0000)
treebacedb6ac8e2994a4808d4e78fd6aef36bd8659e
parent05e2b02dc433acc09b949ccc00921c45f45da7eb
Cleanup most createArea and some createObjectGroup calls in random map scripts.

Inline the placer, terrainPainter, elevationPainter, group and sizes helper variables that are used only once.
Thus do not hoist variable declarations from unrelated scopes.
Remove few dozens of painters that are overpainted by the paintBasedOnTerrainHeight call afterwards.
Remove 334 noisy misaligned code comments (// terrains // widths // blend radius and // some variation).
Label the createArea calls so that the reader knows what they do.
Remove unbenefitial Math.PI/8 grass min/max angle limitation.
Use height variables for the SmoothElevationPainter calls so that levels can be modified more easily.
Use Math prototype functions instead of the unfortunate rmgen proxies.
Does not touch starting base code, Unknown maps, Snowflake Searocks and Corsica & Sardinia which need special treatment.

git-svn-id: https://svn.wildfiregames.com/public/ps/trunk@20301 3db68df2-c116-0410-a063-a993310a9797
50 files changed:
binaries/data/mods/public/maps/random/aegean_sea.js
binaries/data/mods/public/maps/random/african_plains.js
binaries/data/mods/public/maps/random/alpine_lakes.js
binaries/data/mods/public/maps/random/alpine_valley.js
binaries/data/mods/public/maps/random/anatolian_plateau.js
binaries/data/mods/public/maps/random/archipelago.js
binaries/data/mods/public/maps/random/ardennes_forest.js
binaries/data/mods/public/maps/random/atlas_mountains.js
binaries/data/mods/public/maps/random/cantabrian_highlands.js
binaries/data/mods/public/maps/random/canyon.js
binaries/data/mods/public/maps/random/continent.js
binaries/data/mods/public/maps/random/corinthian_isthmus.js
binaries/data/mods/public/maps/random/cycladic_archipelago.js
binaries/data/mods/public/maps/random/english_channel.js
binaries/data/mods/public/maps/random/extinct_volcano.js
binaries/data/mods/public/maps/random/flood.js
binaries/data/mods/public/maps/random/fortress.js
binaries/data/mods/public/maps/random/gear.js
binaries/data/mods/public/maps/random/guadalquivir_river.js
binaries/data/mods/public/maps/random/gulf_of_bothnia.js
binaries/data/mods/public/maps/random/harbor.js
binaries/data/mods/public/maps/random/hyrcanian_shores.js
binaries/data/mods/public/maps/random/island_stronghold.js
binaries/data/mods/public/maps/random/islands.js
binaries/data/mods/public/maps/random/kerala.js
binaries/data/mods/public/maps/random/lake.js
binaries/data/mods/public/maps/random/lorraine_plain.js
binaries/data/mods/public/maps/random/mainland.js
binaries/data/mods/public/maps/random/migration.js
binaries/data/mods/public/maps/random/neareastern_badlands.js
binaries/data/mods/public/maps/random/northern_lights.js
binaries/data/mods/public/maps/random/oasis.js
binaries/data/mods/public/maps/random/persian_highlands.js
binaries/data/mods/public/maps/random/phoenician_levant.js
binaries/data/mods/public/maps/random/polar_sea.js
binaries/data/mods/public/maps/random/pyrenean_sierra.js
binaries/data/mods/public/maps/random/rhine_marshlands.js
binaries/data/mods/public/maps/random/river_archipelago.js
binaries/data/mods/public/maps/random/rivers.js
binaries/data/mods/public/maps/random/rmbiome/randombiome.js
binaries/data/mods/public/maps/random/rmgen2/gaia.js
binaries/data/mods/public/maps/random/saharan_oases.js
binaries/data/mods/public/maps/random/sahel.js
binaries/data/mods/public/maps/random/sahel_watering_holes.js
binaries/data/mods/public/maps/random/schwarzwald.js
binaries/data/mods/public/maps/random/snowflake_searocks.js
binaries/data/mods/public/maps/random/survivalofthefittest.js
binaries/data/mods/public/maps/random/syria.js
binaries/data/mods/public/maps/random/the_nile.js
binaries/data/mods/public/maps/random/volcanic_lands.js