From e9717ed719fbba0d7fb2a3693ee43e5357919ced Mon Sep 17 00:00:00 2001 From: David Maciejak Date: Thu, 2 Mar 2023 23:05:41 +0800 Subject: [PATCH] Coverity: fix WPrefs appearance time of check time of use --- WPrefs.app/Appearance.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c index b986e64f..cc415301 100644 --- a/WPrefs.app/Appearance.c +++ b/WPrefs.app/Appearance.c @@ -1831,7 +1831,7 @@ static void createPanel(Panel * p) panel->fprefix = wstrconcat(wuserdatapath(), "/" PACKAGE_TARNAME); if (access(panel->fprefix, F_OK) != 0) { - if (mkdir(panel->fprefix, 0755) < 0) { + if (-1 == mkdir(panel->fprefix, 0755) && errno != EEXIST) { werror("%s", panel->fprefix); ok = False; } @@ -1841,7 +1841,7 @@ static void createPanel(Panel * p) wfree(panel->fprefix); panel->fprefix = tmp; if (access(panel->fprefix, F_OK) != 0) { - if (mkdir(panel->fprefix, 0755) < 0) { + if (-1 == mkdir(panel->fprefix, 0755) && errno != EEXIST) { werror("%s", panel->fprefix); } } -- 2.11.4.GIT