From d4ee17f0b5f092ff3e1b18608a9a75005f00b0a9 Mon Sep 17 00:00:00 2001
From: David Maciejak <david.maciejak@gmail.com>
Date: Fri, 3 Mar 2023 13:36:04 +0800
Subject: [PATCH] Coverity: fix WPrefs workspace negative array index read

---
 WPrefs.app/Workspace.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/WPrefs.app/Workspace.c b/WPrefs.app/Workspace.c
index 62b134e3..e87d6a33 100644
--- a/WPrefs.app/Workspace.c
+++ b/WPrefs.app/Workspace.c
@@ -207,12 +207,15 @@ static void createPanel(Panel * p)
 
 static void storeData(_Panel * panel)
 {
+	int tmp = WMGetPopUpButtonSelectedItem(panel->posP);
+
+	if (tmp < 0)
+		return;
 	SetBoolForKey(!WMGetButtonSelected(panel->linkB), "DontLinkWorkspaces");
 	SetBoolForKey(WMGetButtonSelected(panel->cyclB), "CycleWorkspaces");
 	SetBoolForKey(WMGetButtonSelected(panel->newB), "AdvanceToNewWorkspace");
 
-	SetStringForKey(WSNamePositions[WMGetPopUpButtonSelectedItem(panel->posP)],
-			"WorkspaceNameDisplayPosition");
+	SetStringForKey(WSNamePositions[tmp], "WorkspaceNameDisplayPosition");
 }
 
 Panel *InitWorkspace(WMWidget *parent)
-- 
2.11.4.GIT