From 824255b1ae225394dc093c193082cfb7186e3eda Mon Sep 17 00:00:00 2001 From: Christophe CURIS Date: Wed, 10 Oct 2012 23:07:53 +0200 Subject: [PATCH] Fixed incorrect attributes for XCreateWindow's attributes The code was setting some values in the window's attribute structure which were not being used (missing the corresponding vmask flag) and was setting some vmask bits without setting the corresponding value in the structure. --- src/wcore.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/wcore.c b/src/wcore.c index 1abe8425..3650591b 100644 --- a/src/wcore.c +++ b/src/wcore.c @@ -51,10 +51,9 @@ WCoreWindow *wCoreCreateTopLevel(WScreen *screen, int x, int y, int width, int h core = wmalloc(sizeof(WCoreWindow)); - vmask = CWBorderPixel | CWCursor | CWEventMask | CWOverrideRedirect | CWColormap; + vmask = CWBackPixel | CWBorderPixel | CWCursor | CWEventMask | CWOverrideRedirect | CWColormap; attribs.override_redirect = True; attribs.cursor = wCursor[WCUR_DEFAULT]; - attribs.background_pixmap = None; attribs.background_pixel = screen->black_pixel; attribs.border_pixel = screen->frame_border_pixel; attribs.event_mask = SubstructureRedirectMask | ButtonPressMask | @@ -98,9 +97,8 @@ WCoreWindow *wCoreCreate(WCoreWindow *parent, int x, int y, int width, int heigh core = wmalloc(sizeof(WCoreWindow)); - vmask = CWBorderPixel | CWCursor | CWEventMask | CWColormap; + vmask = CWBackPixel | CWCursor | CWEventMask | CWColormap; attribs.cursor = wCursor[WCUR_DEFAULT]; - attribs.background_pixmap = None; attribs.background_pixel = parent->screen_ptr->black_pixel; attribs.event_mask = KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask | ButtonMotionMask | -- 2.11.4.GIT