| commit | c7f2a189c48bd4c9eb87958fff66b52e0fdcb7ce | |
| author | Carlos R. Mafra <crmafra@gmail.com> | |
| Tue, 15 Sep 2009 10:52:14 +0000 (15 12:52 +0200) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Tue, 15 Sep 2009 10:52:14 +0000 (15 12:52 +0200) | ||
| tree | 84cecd06b9ea10a7787e73ec741f9b3ce26ad19c | treesnapshot (tar.gz zip) |
| parent | ca2c1f900d81284f64047c6702e7733c9a9f29cd | commitdiff |
Fix the call to XChangeProperty() in 64-bit mode
The man page of XChangeProperty() says:
"If the specified format is 32, the property data must be a
long array."
And as we call it with format 32, the type of 'data' must
be 'long'. It happens to work nowadays in 32-bit architectures
because sizeof(CARD32) = sizeof(long), but that is no longer
true in 64-bit mode.
This patch was downloaded from
www.openbsd.org/cgi-bin/cvsweb/ports/x11/windowmaker/patches/patch-WINGs_wwindow_c
and I thank Alexey I. Frolov and Vladimir Nadvornik for helping me
to understand it on a wmaker-dev thread.
The man page of XChangeProperty() says:
"If the specified format is 32, the property data must be a
long array."
And as we call it with format 32, the type of 'data' must
be 'long'. It happens to work nowadays in 32-bit architectures
because sizeof(CARD32) = sizeof(long), but that is no longer
true in 64-bit mode.
This patch was downloaded from
www.openbsd.org/cgi-bin/cvsweb/ports/x11/windowmaker/patches/patch-WINGs_wwindow_c
and I thank Alexey I. Frolov and Vladimir Nadvornik for helping me
to understand it on a wmaker-dev thread.
| WINGs/wwindow.c | diffblobblamehistory |