| commit | 80a59696e5ac90dec0b7c230a727d524d631d9e0 | |
| author | Christophe CURIS <christophe.curis@free.fr> | |
| Fri, 10 May 2013 22:07:15 +0000 (11 00:07 +0200) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Fri, 10 May 2013 23:17:27 +0000 (11 00:17 +0100) | ||
| tree | 6b2bb838b72e102d85f9effa394a2d5a8df761ae | treesnapshot (tar.gz zip) |
| parent | 8238e4681aa09a3b64c65b68b6f73195c2256267 | commitdiff |
Fixed improper variables definition in header file
Some header were creating variable, this is a bad practice which
is likely to not behave as expected. This creates one distinct
variable in each object file that used the header, and:
- on well behaved compiler, this ends up in a link error (see
commit 39fdb451ba6ff84430507e327fa01a43f40b7315 for an example)
- on bad behaving compiler, this can be linked as multiple local
variable, thus having strange effects when running program
- on insouciant compiler (who said gcc?) the variables are
silently merged, hiding portability issues
Some header were creating variable, this is a bad practice which
is likely to not behave as expected. This creates one distinct
variable in each object file that used the header, and:
- on well behaved compiler, this ends up in a link error (see
commit 39fdb451ba6ff84430507e327fa01a43f40b7315 for an example)
- on bad behaving compiler, this can be linked as multiple local
variable, thus having strange effects when running program
- on insouciant compiler (who said gcc?) the variables are
silently merged, hiding portability issues
| src/screen.c | diffblobblamehistory | |
| src/screen.h | diffblobblamehistory | |
| util/wmmenugen.c | diffblobblamehistory | |
| util/wmmenugen.h | diffblobblamehistory |