| commit | 587a37dc60f48b64d96f88364cc3aa79740573a3 | |
| author | Iain Patterson <wm@iain.cx> | |
| Sun, 9 Jun 2013 12:18:18 +0000 (9 13:18 +0100) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Sun, 9 Jun 2013 12:52:06 +0000 (9 13:52 +0100) | ||
| tree | 91110c3f970adcb24bd78c8df0f05781b3ac8c2d | treesnapshot (tar.gz zip) |
| parent | 70909f4d5d7d6d97706b375500e054ed4c2a0473 | commitdiff |
Maximization regression
wMaximizeWindow() was previously rewritten and simplified.
Unfortunately the rewrite introduced a regression with windows which
were horizontally maximized or Maximusized, whereby they would be too
small after the maximization.
The bug is easy to see by opening a standard 80x24 terminal and hitting
the maximize horizontally shortcut. The terminal shrinks to 21 lines.
Pressing the shortcut key again correctly restores it to 80x24.
The fix is to refrain from shrinking the final window height, which is
done to account for its frame border and titlebar, for the affected
maximization styles.
wMaximizeWindow() was previously rewritten and simplified.
Unfortunately the rewrite introduced a regression with windows which
were horizontally maximized or Maximusized, whereby they would be too
small after the maximization.
The bug is easy to see by opening a standard 80x24 terminal and hitting
the maximize horizontally shortcut. The terminal shrinks to 21 lines.
Pressing the shortcut key again correctly restores it to 80x24.
The fix is to refrain from shrinking the final window height, which is
done to account for its frame border and titlebar, for the affected
maximization styles.
| src/actions.c | diffblobblamehistory |