From 6aafd2f1dedfe286e75892bef866d89150c12377 Mon Sep 17 00:00:00 2001 From: Aric Stewart Date: Thu, 19 Apr 2012 08:11:12 -0500 Subject: [PATCH] quartz: Correct a critical section lock reversal issue found by Marcus Meissner (Coverity). --- dlls/quartz/videorenderer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index e1e96282096..27c656cfd0a 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -368,11 +368,11 @@ static HRESULT WINAPI VideoRenderer_EndFlush(BaseRenderer* iface) if (This->renderer.pMediaSample) { ResetEvent(This->hEvent); LeaveCriticalSection(iface->pInputPin->pin.pCritSec); - LeaveCriticalSection(&iface->filter.csFilter); LeaveCriticalSection(&iface->csRenderLock); + LeaveCriticalSection(&iface->filter.csFilter); WaitForSingleObject(This->hEvent, INFINITE); - EnterCriticalSection(&iface->csRenderLock); EnterCriticalSection(&iface->filter.csFilter); + EnterCriticalSection(&iface->csRenderLock); EnterCriticalSection(iface->pInputPin->pin.pCritSec); } if (This->renderer.filter.state == State_Paused) { -- 2.11.4.GIT