From fae81bf5180620c8d89c282dbac1da4048e44f3b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20=28kix=29?= Date: Mon, 16 Jul 2012 20:27:10 +0200 Subject: [PATCH] Format string bug in WMenuParserError There is a format string (FS) bug in the function WMenuParserError. It is the tipical FS bug, like printf(a) instead of printf("%s", a); See http://en.wikipedia.org/wiki/Uncontrolled_format_string for more info. --- WINGs/menuparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WINGs/menuparser.c b/WINGs/menuparser.c index 7659817d..96555cdf 100644 --- a/WINGs/menuparser.c +++ b/WINGs/menuparser.c @@ -102,7 +102,7 @@ void WMenuParserError(WMenuParser parser, const char *msg, ...) va_start(args, msg); vsnprintf(buf, sizeof(buf), msg, args); va_end(args); - __wmessage("WMenuParser", parser->file_name, parser->line_number, WMESSAGE_TYPE_WARNING, buf); + __wmessage("WMenuParser", parser->file_name, parser->line_number, WMESSAGE_TYPE_WARNING, "%s", buf); for (parent = parser->parent_file; parent != NULL; parent = parent->parent_file) __wmessage("WMenuParser", parser->file_name, parser->line_number, WMESSAGE_TYPE_WARNING, -- 2.11.4.GIT