wNETWMCheckClientHintChange should be void
authorRodolfo García Peñas (kix) <kix@kix.es>
Tue, 23 Oct 2012 21:59:50 +0000 (23 23:59 +0200)
committerCarlos R. Mafra <crmafra@gmail.com>
Sun, 28 Oct 2012 10:58:42 +0000 (28 10:58 +0000)
The function wNETWMCheckClientHintChange returns a Bool,
but this value is never used, son can be removed.

This function now is void.

kix@osaka:~/src/wmaker/wmaker-crm-tosnd/src$ grep wNETWMCheckClientHintChange *.[ch]
client.c:                       wNETWMCheckClientHintChange(wwin, event);
wmspec.c:Bool wNETWMCheckClientHintChange(WWindow * wwin, XPropertyEvent * event)
wmspec.h:Bool wNETWMCheckClientHintChange(WWindow *wwin, XPropertyEvent *event);

src/wmspec.c
src/wmspec.h

index 76e72a9..9424012 100644 (file)
@@ -1457,10 +1457,8 @@ Bool wNETWMProcessClientMessage(XClientMessageEvent * event)
        return done;
 }
 
-Bool wNETWMCheckClientHintChange(WWindow * wwin, XPropertyEvent * event)
+void wNETWMCheckClientHintChange(WWindow *wwin, XPropertyEvent *event)
 {
-       Bool ret = True;
-
 #ifdef DEBUG_WMSPEC
        wmessage("clientHintChange type %s\n", XGetAtomName(dpy, event->atom));
 #endif
@@ -1485,11 +1483,7 @@ Bool wNETWMCheckClientHintChange(WWindow * wwin, XPropertyEvent * event)
                }
        } else if (event->atom == net_wm_icon) {
                updateIconImage(wwin);
-       } else {
-               ret = False;
        }
-
-       return ret;
 }
 
 int wNETWMGetPidForWindow(Window window)
index af75684..63d1eff 100644 (file)
@@ -35,7 +35,7 @@ Bool wNETWMGetUsableArea(WScreen *scr, int head, WArea *area);
 void wNETWMCheckInitialClientState(WWindow *wwin);
 Bool wNETWMProcessClientMessage(XClientMessageEvent *event);
 void wNETWMCheckClientHints(WWindow *wwin, int *layer, int *workspace);
-Bool wNETWMCheckClientHintChange(WWindow *wwin, XPropertyEvent *event);
+void wNETWMCheckClientHintChange(WWindow *wwin, XPropertyEvent *event);
 void wNETWMUpdateActions(WWindow *wwin, Bool del);
 void wNETWMUpdateDesktop(WScreen *scr);
 void wNETWMPositionSplash(WWindow *wwin, int *x, int *y, int width, int height);