| commit | bed5ebea89c225434a032eb860040901ce315a09 | |
| author | Christophe CURIS <christophe.curis@free.fr> | |
| Fri, 8 May 2015 11:19:09 +0000 (8 13:19 +0200) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Fri, 8 May 2015 17:53:30 +0000 (8 18:53 +0100) | ||
| tree | 58f4e042c8398d72ba304a5a86465fc8287c6fc5 | treesnapshot (tar.gz zip) |
| parent | edc12fad9f755944648d98dcac3ee3b98eaba7f2 | commitdiff |
wmaker: moved the definition of the list of entries for the window menu to an array
By defining the const array with everything at the beginning of the file,
it is easier to maintain and to make evolve (all stuff at the same place).
Merged the function makeMakeShortcutMenu into makeOptionsMenu because it
allows to use a simple callback in the structure like for the other
submenus and because its complexity did not justify a dedicated function.
Took opportunity to give a more appropriate name to the index
MC_DUMMY_MOVETO which did not mean what the entry is about.
As a side effect, this should close Coverity #50251 which was about saving
the return value of function into a variable but not using it, which is not
really good for maintainability.
Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
By defining the const array with everything at the beginning of the file,
it is easier to maintain and to make evolve (all stuff at the same place).
Merged the function makeMakeShortcutMenu into makeOptionsMenu because it
allows to use a simple callback in the structure like for the other
submenus and because its complexity did not justify a dedicated function.
Took opportunity to give a more appropriate name to the index
MC_DUMMY_MOVETO which did not mean what the entry is about.
As a side effect, this should close Coverity #50251 which was about saving
the return value of function into a variable but not using it, which is not
really good for maintainability.
Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
| src/winmenu.c | diffblobblamehistory |